Re: [TESTPATCH v2] xhci: fix usb2 resume timing and races.

2015-12-04 Thread Daniel J Blueman
On 1 December 2015 at 16:26, Mathias Nyman wrote: > usb2 ports need to signal resume for 20ms before moving to U0 state. > Both device and host can initiate resume. > > On host initated resume port is set to resume state, sleep 20ms, > and finally set port to U0 state. > > On device initated resum

[PATCH v2] usb: xhci-mtk: fix AHB bus hang up caused by roothubs polling

2015-12-04 Thread Chunfeng Yun
when ip fails to enter sleep mode, register access protection will be disabled, at the same time if all clocks are disabled, access register will hang up AHB bus. the common case causes ip sleep failure is that after all ports enter U3 but before ip enters sleep mode, a port receives a resume signa

Re: [PATCH] usb: xhci-mtk: fix AHB bus hang up caused by roothubs polling

2015-12-04 Thread chunfeng yun
Hi, On Fri, 2015-12-04 at 16:24 +0300, Sergei Shtylyov wrote: > Hello. > > Sorry for the grammar nitpicking but since it's in the comments, I felt > the necessity to comment. > > On 12/4/2015 5:40 AM, Chunfeng Yun wrote: > > > when ip fail to enter sleep mode, register access protection wil

Re: kernel panic while in interrupt handler

2015-12-04 Thread Peter Stuge
Hi Enrico, Enrico Mioso wrote: > In case I am able, I'll provide more hints. There are a few ways to get the kernel oops output off the computer without copying off the screen; netconsole, a USB debug device, and last but not least photographing the computer screen. One problem with using a USB

Re: Infrastructure for zerocopy I/O

2015-12-04 Thread Alan Stern
On Fri, 4 Dec 2015, Steinar H. Gunderson wrote: > On Fri, Dec 04, 2015 at 01:29:05AM +0100, Steinar H. Gunderson wrote: > > I must be doing something wrong, because I don't seem to get any frames > > from my video capture, and when I close the application, I get a slowpath > > warning: > > OK, th

Re: [PATCH 0/6] net: qmi_wwan: MDM9x30 support

2015-12-04 Thread David Miller
From: Bjørn Mork Date: Thu, 3 Dec 2015 19:24:17 +0100 > We add new device IDs all the time, often without any testing on > actual hardware. This is usually OK as long as the device is similar > to already supported devices, using the same chipset and firmware > basis. But the Sierra Wireless MC

[RFC] usb: coccinelle and checkpatch cleanup

2015-12-04 Thread Geyslan G. Bem
While applying the "scripts/coccinelle/misc/compare_const_fl.cocci" in usb/host/ tree I found files that deserve almost a full cleanup (very wrong coding style). Eg. drivers/usb/host/ohci-dbg.c Can I do a full cleaning or only coccinelle patches? -- Regards, Geyslan G. Bem hackingbits.com -- To

Re: [PATCH 2/3] usb: whci: replace dma_pool_alloc and memset with dma_pool_zalloc

2015-12-04 Thread Geyslan G. Bem
2015-12-04 14:18 GMT-03:00 Greg Kroah-Hartman : > On Fri, Dec 04, 2015 at 02:13:35PM -0300, Geyslan G. Bem wrote: >> 2015-12-04 13:44 GMT-03:00 Greg Kroah-Hartman : >> > On Fri, Dec 04, 2015 at 01:33:18PM -0300, Geyslan G. Bem wrote: >> >> >> >> If you wish, you could list me subsystems in need of

Re: [PATCH 2/3] usb: whci: replace dma_pool_alloc and memset with dma_pool_zalloc

2015-12-04 Thread Greg Kroah-Hartman
On Fri, Dec 04, 2015 at 02:13:35PM -0300, Geyslan G. Bem wrote: > 2015-12-04 13:44 GMT-03:00 Greg Kroah-Hartman : > > On Fri, Dec 04, 2015 at 01:33:18PM -0300, Geyslan G. Bem wrote: > >> > >> If you wish, you could list me subsystems in need of maintenance. > > > > I don't understand what you mean

Re: [PATCH 2/3] usb: whci: replace dma_pool_alloc and memset with dma_pool_zalloc

2015-12-04 Thread Geyslan G. Bem
2015-12-04 13:44 GMT-03:00 Greg Kroah-Hartman : > On Fri, Dec 04, 2015 at 01:33:18PM -0300, Geyslan G. Bem wrote: >> >> If you wish, you could list me subsystems in need of maintenance. > > I don't understand what you mean by this. I meant that would be great to know which usb subsystems you do pr

[PATCH v3] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-12-04 Thread Saurabh Sengar
added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar --- v3: reverted to v1 logic, on top of usb-next branch drivers/usb/host/pci-quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/u

Re: [PATCH 2/3] usb: whci: replace dma_pool_alloc and memset with dma_pool_zalloc

2015-12-04 Thread Greg Kroah-Hartman
On Fri, Dec 04, 2015 at 01:33:18PM -0300, Geyslan G. Bem wrote: > > If you wish, you could list me subsystems in need of maintenance. I don't understand what you mean by this. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel

Re: kernel panic while in interrupt handler

2015-12-04 Thread Greg KH
On Fri, Dec 04, 2015 at 05:29:30PM +0100, Enrico Mioso wrote: > Hello guys. > with my current hardware setup (EEE PC 701, 1GB RAM), I get occasional > PANICs while in interrupt handlers. It seems I get these when dealing with > USB devices: it happened seeminglsy while using my braille display some

Re: kernel panic while in interrupt handler

2015-12-04 Thread Enrico Mioso
Thank you Greg. In case I am able, I'll provide more hints. Thank you again, Enrico -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] usb: whci: replace dma_pool_alloc and memset with dma_pool_zalloc

2015-12-04 Thread Geyslan G. Bem
2015-12-04 13:25 GMT-03:00 Greg Kroah-Hartman : > On Wed, Dec 02, 2015 at 05:43:11PM -0300, Geyslan G. Bem wrote: >> Replace dma_pool_alloc and memset with a single call to dma_pool_zalloc. >> >> Caught by coccinelle. >> >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/host/whci/qset.c | 3

Re: [PATCH v2] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-12-04 Thread Saurabh Sengar
On 4 December 2015 at 21:53, Greg KH wrote: > On Wed, Dec 02, 2015 at 10:51:37PM +0530, Saurabh Sengar wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar >> --- >> v2: changed logic a bit, because of recent patches pushed to usb-next

kernel panic while in interrupt handler

2015-12-04 Thread Enrico Mioso
Hello guys. with my current hardware setup (EEE PC 701, 1GB RAM), I get occasional PANICs while in interrupt handlers. It seems I get these when dealing with USB devices: it happened seeminglsy while using my braille display some days ago, and repeated today when "hciconfig hci0 up"'ing a bluet

Re: [PATCH 2/3] usb: whci: replace dma_pool_alloc and memset with dma_pool_zalloc

2015-12-04 Thread Greg Kroah-Hartman
On Wed, Dec 02, 2015 at 05:43:11PM -0300, Geyslan G. Bem wrote: > Replace dma_pool_alloc and memset with a single call to dma_pool_zalloc. > > Caught by coccinelle. > > Signed-off-by: Geyslan G. Bem > --- > drivers/usb/host/whci/qset.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH 1/3] usb: uhci: replace dma_pool_alloc and memset with dma_pool_zalloc

2015-12-04 Thread Greg Kroah-Hartman
On Wed, Dec 02, 2015 at 05:41:44PM -0300, Geyslan G. Bem wrote: > Replace dma_pool_alloc and memset with a single call to dma_pool_zalloc. > > Caught by coccinelle. > > Signed-off-by: Geyslan G. Bem > --- > drivers/usb/host/uhci-q.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thi

Re: [PATCH v2] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-12-04 Thread Greg KH
On Wed, Dec 02, 2015 at 10:51:37PM +0530, Saurabh Sengar wrote: > added iounmap inorder to free memory mapped to base before returning > > Signed-off-by: Saurabh Sengar > --- > v2: changed logic a bit, because of recent patches pushed to usb-next > drivers/usb/host/pci-quirks.c | 2 +- > 1 file

[PATCH] usb: phy: Remove unused Renesas R-Car (Gen1) USB PHY driveer

2015-12-04 Thread Geert Uytterhoeven
As of commit 3d7608e4c169af03 ("ARM: shmobile: bockw: remove legacy board file and config"), the Renesas R-Car (Gen1) USB PHY driver is no longer used. In theory it could still be used on R-Car Gen1 SoCs, but that would require adding DT support to the driver. Instead, a new driver using the generi

Re: patch - VID/PID for Yaesu SCU-18 cable for ftdi-usb-sio

2015-12-04 Thread Harald Linden
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Greg, Sorry, I tried, I just don't find the time to read the docs and bring this patch into the form you requested. Can you just add the Yaesu device to the definitions? Vendor ID: 0x0584 Product ID: 0xB03A Yaesu SCU-18 data cable made by RATOC

Re: Infrastructure for zerocopy I/O

2015-12-04 Thread Steinar H. Gunderson
On Thu, Dec 03, 2015 at 04:31:35PM -0500, Alan Stern wrote: >> Seemingly controller is already a pointer, so the & is redundant. No idea why >> it didn't crash plain out. Fixing that, I can allocate, although I have some >> other bug causing an oops somewhere else. > Ah, an easy mistake to miss. B

Re: [PATCH 6/7] usb: xhci: plat: add generic PHY support

2015-12-04 Thread Jisheng Zhang
cc linux-usb@vger.kernel.org On Fri, 4 Dec 2015 22:10:51 +0800 Jisheng Zhang wrote: > Marvell BG4CT SoC needs two phy: one for usb2 and another for usb3. Add > the calls to retrieve generic PHY to xhci plat in order to support this. > > Signed-off-by: Jisheng Zhang > --- > drivers/usb/host/xhc

Re: [PATCH 7/7] usb: xhci: plat: add vbus regulator control

2015-12-04 Thread Jisheng Zhang
cc linux-usb@vger.kernel.org On Fri, 4 Dec 2015 22:10:52 +0800 Jisheng Zhang wrote: > The Marvell BG4CT STB board has board level vbus control through gpio. > This patch adds the vbus regulator control to support this board. > > Signed-off-by: Jisheng Zhang > --- > drivers/usb/host/xhci-plat.

Re: [PATCH 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path

2015-12-04 Thread Jisheng Zhang
cc linux-usb@vger.kernel.org On Fri, 4 Dec 2015 22:10:50 +0800 Jisheng Zhang wrote: > Commit 63589e92c2d9 ("clk: Ignore error and NULL pointers passed to > clk_{unprepare, disable}()") allows NULL or error pointer to be passed > unconditionally. > > This patch is to simplify probe error and remo

Re: [PATCH 4/7] usb: xhci: plat: sort the headers in alphabetic order

2015-12-04 Thread Jisheng Zhang
cc linux-usb@vger.kernel.org On Fri, 4 Dec 2015 22:10:49 +0800 Jisheng Zhang wrote: > Sorting the headers in alphabetic order will help to reduce the conflict > when adding new headers later. > > Signed-off-by: Jisheng Zhang > --- > drivers/usb/host/xhci-plat.c | 4 ++-- > 1 file changed, 2 in

Re: [PATCH 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd

2015-12-04 Thread Jisheng Zhang
cc linux-usb@vger.kernel.org On Fri, 4 Dec 2015 22:10:47 +0800 Jisheng Zhang wrote: > Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the > usb_phy for usb3, but it attached the usb_phy to incorrect hcd. The > xhci->shared_hcd is the hcd for usb3, this patch fixes this issue > b

Re: [PATCH 1/7] usb: xhci: plat: Fix suspend/resume when the optional clk exists

2015-12-04 Thread Jisheng Zhang
cc linux-usb@vger.kernel.org On Fri, 4 Dec 2015 22:10:46 +0800 Jisheng Zhang wrote: > Commit 4718c1774051 ("usb: host: xhci-plat: add clock support") adds > optional clk support, but it forgets to prepare/disable and > enable/unprepare the clk in the resume/suspend path. This path fixes > this is

Re: [PATCH 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists

2015-12-04 Thread Jisheng Zhang
cc linux-usb@vger.kernel.org On Fri, 4 Dec 2015 22:10:48 +0800 Jisheng Zhang wrote: > Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the > usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the > suspend/resume path. This patch fixes this issue by adding missing >

Re: [PATCH 0/7] usb: xhci-plat: support generic PHY and vbus regulator

2015-12-04 Thread Jisheng Zhang
cc linux-usb@vger.kernel.org Sorry, I forget to do so. Will cc linux-usb in the future. On Fri, 4 Dec 2015 22:10:45 +0800 Jisheng Zhang wrote: > The Marvell BG4CT has xhci controller. This controller has two phys: > one for usb2 and another for usb3. BG4CT boards have board level vbus > control

[PATCH 1/2] xhci: Fix memory leak in xhci_pme_acpi_rtd3_enable()

2015-12-04 Thread Mathias Nyman
From: Mika Westerberg There is a memory leak because acpi_evaluate_dsm() actually returns an object which the caller is supposed to release. Fix this by calling ACPI_FREE() for the returned object (this expands to kfree() so passing NULL there is fine as well). While there correct indentation in

[PATCH 2/2] usb: xhci: fix config fail of FS hub behind a HS hub with MTT

2015-12-04 Thread Mathias Nyman
From: Chunfeng Yun if a full speed hub connects to a high speed hub which supports MTT, the MTT field of its slot context will be set to 1 when xHCI driver setups an xHCI virtual device in xhci_setup_addressable_virt_dev(); once usb core fetch its hub descriptor, and need to update the xHC's inte

[PATCH 0/2] xhci fixes for usb-linus

2015-12-04 Thread Mathias Nyman
Hi Greg Only a couple small fixes for xhci, one fix allowing a FS hub to be connected behind a HS hub, and one acpi variable memory leak. -Mathias Chunfeng Yun (1): usb: xhci: fix config fail of FS hub behind a HS hub with MTT Mika Westerberg (1): xhci: Fix memory leak in xhci_pme_acpi_rtd3

Re: [PATCH] usb: xhci-mtk: fix AHB bus hang up caused by roothubs polling

2015-12-04 Thread Sergei Shtylyov
Hello. Sorry for the grammar nitpicking but since it's in the comments, I felt the necessity to comment. On 12/4/2015 5:40 AM, Chunfeng Yun wrote: when ip fail to enter sleep mode, register access protection will Fails. be disabed, at the same time if all clocks are disabled, acces

reading data at 500Hz

2015-12-04 Thread Jose Colmenares
Hi, I'm using a USB Inertial Measurement Unit that theoretically produces data at 500Hz. According to the timestamps on the data, indeed the data is being produced at 500Hz. But I'm getting it in burst, with an "efective" sampling rate of 6ms instead of 2ms. That is, 166Hz instead of 500hz. I'

Re: Infrastructure for zerocopy I/O

2015-12-04 Thread Steinar H. Gunderson
On Fri, Dec 04, 2015 at 01:29:05AM +0100, Steinar H. Gunderson wrote: > I must be doing something wrong, because I don't seem to get any frames > from my video capture, and when I close the application, I get a slowpath > warning: OK, the slowpath warning is a red herring -- it's just because I do

Re: [PATCH] usb: xhci: fix config fail of FS hub behind a HS hub with MTT

2015-12-04 Thread Mathias Nyman
On 03.12.2015 08:14, Chunfeng Yun wrote: if a full speed hub connects to a high speed hub which supports MTT, the MTT field of its slot context will be set to 1 when xHCI driver setups an xHCI virtual device in xhci_setup_addressable_virt_dev(); once usb core fetch its hub descriptor, and need to

Re: [PATCH 0/6] net: qmi_wwan: MDM9x30 support

2015-12-04 Thread Aleksander Morgado
On Thu, Dec 3, 2015 at 7:24 PM, Bjørn Mork wrote: > We add new device IDs all the time, often without any testing on > actual hardware. This is usually OK as long as the device is similar > to already supported devices, using the same chipset and firmware > basis. But the Sierra Wireless MC7455 i

Re: [PATCHv2 1/2] extcon: add driver for Intel USB mux

2015-12-04 Thread Heikki Krogerus
Hi, > I do never want to add some specific funtcion for only this driver. > I think is not appropriate way. > - intel_usb_mux_unregister > - intel_usb_mux_register > > The client driver using extcon driver should use the standard extcon API > for code consistency. Also, I'll do the more detailed