of_match_device could return NULL, and so cause a NULL pointer
dereference later.
Signed-off-by: LABBE Corentin
---
drivers/usb/phy/phy-mxs-usb.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index 4d863eb
of_match_device could return NULL, and so cause a NULL pointer
dereference later. Renaming id to of_id (like all others do) in the
process.
Reported-by: coverity (CID 1324133)
Signed-off-by: LABBE Corentin
---
drivers/usb/phy/phy-msm-usb.c | 9 ++---
1 file changed, 6 insertions(+), 3 deleti
of_match_device could return NULL, and so cause a NULL pointer
dereference later. Renaming tmp_dev to of_id (like all others do) in the
process.
Reported-by: coverity (CID 1324135)
Signed-off-by: LABBE Corentin
---
drivers/usb/chipidea/usbmisc_imx.c | 10 ++
1 file changed, 6 insertions(
of_match_device could return NULL, and so cause a NULL pointer
dereference later.
Reported-by: coverity (CID 1324138)
Signed-off-by: LABBE Corentin
---
drivers/usb/chipidea/ci_hdrc_imx.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_
Am 12.11.2015 um 05:39 schrieb John Youn:
On 11/11/2015 3:20 PM, Stefan Wahren wrote:
Hi John,
Am 11.11.2015 um 00:21 schrieb John Youn:
On 11/9/2015 12:43 PM, Stefan Wahren wrote:
Hi,
The gadget side required it but it looks like the host side
didn't.
When Marek did the low-level hw refac
Hi, Baolu
On 11/12/15 at 10:45am, Lu, Baolu wrote:
> Hi Dave,
>
> Which device are you testing with? This implementation was developed
> and tested on Intel Skylake devices.
>
> It doesn't surprise me if it doesn't work with other silicons. But it do
> remind me to create a verified-list and put
The current code has info->bufnmb_last to calculate the BUFNMB bits of
PIPEBUF register. However, since the bufnmb_last is initialized in
the usbhs_pipe_init() only, this driver is possible to set unexpected
value to the register if usb_ep_{enable,disable}() are called many times.
So, this patch m
This patch modifies the ep.caps.type_{iso,bulk,int} setting and
the second argument of usb_ep_maxpacket_limit() using
the dparam.pipe_configs.
In the previous code, all the type_{iso,bulk,int} were set to true.
However, to avoid waste time for finding suitable pipe in usb_ep_enable(),
this driver
This patch fixes an issue that NULL pointer dereference happens when
a gadget driver calls usb_ep_dequeue() after usb_ep_disable().
Signed-off-by: Yoshihiro Shimoda
---
drivers/usb/renesas_usbhs/mod_gadget.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/
This patch is based on the latest Felipe's usb.git / testing/next branch.
(The commit id = 81e9d14a53eb1abfbe6ac828a87a2deb4702b5f1)
Yoshihiro Shimoda (3):
usb: renesas_usbhs: gadget: Fix NULL pointer dereference in
usbhsg_ep_dequeue()
usb: renesas_usbhs: Modify pipe configuration
usb: r
John,
On Wed, Nov 11, 2015 at 8:29 PM, John Youn wrote:
> I also feel it is not quite right as the SSPLIT should be able to
> happen during the SSPLIT of another device. I tried to reproduce
> and see the same scheduling but don't see any hang due to it.
>
> Yunzhi, any details on what kind of hu
On 11/11/2015 3:20 PM, Stefan Wahren wrote:
> Hi John,
>
> Am 11.11.2015 um 00:21 schrieb John Youn:
>> On 11/9/2015 12:43 PM, Stefan Wahren wrote:
>>> Hi,
>>
>> The gadget side required it but it looks like the host side
>> didn't.
>>
>> When Marek did the low-level hw refactor, some of the gadge
On 11/11/2015 4:22 PM, Doug Anderson wrote:
> John,
>
> On Fri, Nov 6, 2015 at 2:04 AM, Yunzhi Li wrote:
>> hi John ,
>>
>> As we talked yesterday, I tried to fix the split schedule sequence. This
>> patch will
>> avoid scheduling SSPLIT-IN packet for another device between
>> SSPLIT-OUT-begin
Hi Dave,
Which device are you testing with? This implementation was developed
and tested on Intel Skylake devices.
It doesn't surprise me if it doesn't work with other silicons. But it do
remind me to create a verified-list and put those known-to-work devices
in it.
Thanks,
Baolu
On 11/11/2015
USB3 LPM is default on in Linux kernel if both xHCI host controller
and the USB devices declare to be LPM-capable. Unfortunately, some
devices are known to work well with LPM disabled, but to be broken
if LPM is enabled, although it declares the LPM capability. Users
won't be able to use this kind
Commit 655fe4effe0f ("usbcore: add sysfs support to xHCI usb3
hardware LPM") introduced usb3_hardware_lpm sysfs node. This
doesn't show the correct status of USB3 U1 and U2 LPM status.
This patch fixes this by replacing usb3_hardware_lpm with two
nodes, usb3_hardware_lpm_u1 (for U1) and usb3_hardw
Hi,
This patch series is about to add a sysfs attribute, through which
users can disable or enable USB3 LPM (link power management) from
a USB port. Once LPM is disabled from the USB port, LPM between the
downstreaming device and the hub port will not be activated. This
helps users to use any LPM-
Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.")
adds usb3_lpm_enabled member to struct usb_device. There is no reference
to this member now. Hence, it could be removed.
Signed-off-by: Lu Baolu
---
include/linux/usb.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/inc
On 11/11/2015 11:10 PM, Alan Stern wrote:
On Wed, 11 Nov 2015, Lu Baolu wrote:
Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.")
adds usb3_lpm_enabled member to struct usb_device. There is no reference
to this member now. Hence, it could be removed.
Signed-off-by: Lu Bao
John,
On Fri, Nov 6, 2015 at 2:04 AM, Yunzhi Li wrote:
> hi John ,
>
> As we talked yesterday, I tried to fix the split schedule sequence. This
> patch will
> avoid scheduling SSPLIT-IN packet for another device between
> SSPLIT-OUT-begin and
> SSPLIT-OUT-end, now the keyboard and Jebra audio s
On Mon, 2 Nov 2015 10:27:00 +0100
Jiri Slaby wrote:
> Signed-off-by: Jiri Slaby
> --- a/drivers/usb/class/usblp.c
> +++ b/drivers/usb/class/usblp.c
> @@ -884,11 +884,11 @@ static int usblp_wwait(struct usblp *usblp, int
> nonblock)
>
> add_wait_queue(&usblp->wwait, &waita);
> for
Am 11.11.2015 um 22:58 schrieb John Youn:
On 11/8/2015 2:13 AM, Stefan Wahren wrote:
--->8
diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index 5859b0f..0e80087 100644
--- a/drivers/usb/dwc2/platform.c
++
Hi John,
Am 11.11.2015 um 00:21 schrieb John Youn:
On 11/9/2015 12:43 PM, Stefan Wahren wrote:
Hi,
The gadget side required it but it looks like the host side
didn't.
When Marek did the low-level hw refactor, some of the gadget
stuff was brought up to the common layer, including the returnin
On 11/8/2015 2:13 AM, Stefan Wahren wrote:
> Hi Stephen,
>
> Am 08.11.2015 um 06:06 schrieb Stephen Warren:
>> On 11/07/2015 05:16 PM, Stefan Wahren wrote:
>>> Hi,
>>> [...]
>>>* phys (optional)
>>>* phy-names (optional)
>>>
>>> So here are my questions:
>>>
>>> How to fix the kernel oops
Without this function, when the port is closed the data in the chip's
transmit FIFO are lost. If the actual byte count is reported the close
can be delayed until all data are sent.
Signed-off-by: Konstantin Shkolnyy
---
drivers/usb/serial/cp210x.c | 60 +++
On Wed, Nov 11, 2015 at 09:03:14PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 11, 2015 at 1:16 PM, Dave Penkler wrote:
> > Background:
> > When performing a read on an instrument that is executing a function
> > that runs longer than the USB timeout the instrument may hang and require
> > a devic
Hello.
On 11/11/2015 10:36 PM, John Youn wrote:
When searching for PHYs, any error was treated as if the PHY did not
exist or was not specified (-ENODEV). Thus the probe function did not
correctly return error conditions such as -EPROBE_DEFER.
Fixed so that only -ENODEV is ignored and any othe
On Tue, Nov 10, 2015 at 04:46:50PM -0800, Tim Bird wrote:
> Add optional async_irq to msm_hsusb binding doc.
>
> Signed-off-by: Tim Bird
Acked-by: Rob Herring
> ---
> Documentation/devicetree/bindings/usb/msm-hsusb.txt | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> di
On Wed, Nov 11, 2015 at 9:48 PM, Sergei Shtylyov
wrote:
> On 11/11/2015 10:03 PM, Andy Shevchenko wrote:
>> Won't comment precisely by line, but common nitpicks about style:
>> - added empty lines where no need
>> - redundant parens
>> - pieces of code takes whole line when they are quite f
Hello.
On 11/11/2015 10:03 PM, Andy Shevchenko wrote:
Background:
When performing a read on an instrument that is executing a function
that runs longer than the USB timeout the instrument may hang and require
a device reset to recover. The READ_STATUS_BYTE operation always returns
even when the
On Wed, Nov 11, 2015 at 1:21 PM, Dave Penkler wrote:
> These ioctls provide support for the USBTMC-USB488 control requests
> for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT
>
> Signed-off-by: Dave Penkler
> ---
> drivers/usb/class/usbtmc.c | 76
>
>
When searching for PHYs, any error was treated as if the PHY did not
exist or was not specified (-ENODEV). Thus the probe function did not
correctly return error conditions such as -EPROBE_DEFER.
Fixed so that only -ENODEV is ignored and any other error is returned.
Reported-by: Alexander Aring
On Wed, Nov 11, 2015 at 1:20 PM, Dave Penkler wrote:
> This is a convenience function to obtain an instrument's capabilities
> from its file descriptor without having to access sysfs from the user
> program.
>
> Signed-off-by: Dave Penkler
> ---
> drivers/usb/class/usbtmc.c | 12
>
Fixes commit 09a75e85
"usb: dwc2: refactor common low-level hw code to platform.c"
The above commit consolidated the low-level phy access into a common
location. This change introduced a check from the gadget requiring
that a PHY is specified. This requirement never existed on the host
side and br
This series address a couple issues with setting up and checking the
PHY during probe.
Resending to linux-usb list with fixed up headers and fixed cover
letter subject.
John Youn (2):
usb: dwc2: Make PHY optional
usb: dwc2: Return errors from PHY
drivers/usb/dwc2/platform.c | 36 +++
On 11/11/2015 9:57 AM, Alexander Aring wrote:
> Hi,
>
> On Tue, Nov 10, 2015 at 11:21:56PM +, John Youn wrote:
>> On 11/9/2015 12:43 PM, Stefan Wahren wrote:
>>> Hi,
>>>
>>> Am 09.11.2015 um 12:53 schrieb Marek Szyprowski:
Hello,
This change looks reasonable, I remember the
On Wed, Nov 11, 2015 at 1:16 PM, Dave Penkler wrote:
> Background:
> In many situations operations on multiple instruments need to be
> synchronized. poll/select provide a convenient way of waiting on a number
> of different instruments and other peripherals simultaneously.
>
> Signed-off-by: Dave
On Wed, Nov 11, 2015 at 1:16 PM, Dave Penkler wrote:
> Background:
> When performing a read on an instrument that is executing a function
> that runs longer than the USB timeout the instrument may hang and require
> a device reset to recover. The READ_STATUS_BYTE operation always returns
> even wh
Also known as Verizon U620L.
The device is modeswitched from 1410:9020 to 1410:9022 by selecting the 4th USB
configuration:
$ sudo usb_modeswitch –v 0x1410 –p 0x9020 –u 4
This configuration provides a ECM interface as well as TTYs ('Enterprise Mode'
according to the U620 Linux integration guide
In some cases, like when you've got a "Microsoft Wireless Keyboard 2000"
connected to dwc2 with a hub, expected that we'll get some transfer
errors sometimes. The controller is expected to try at least 3 times
before giving up. See figure "Figure A-67. Normal HS CSPLIT 3 Strikes
Smash" in the USB
In some cases, like when you've got a "Microsoft Wireless Keyboard 2000"
connected to dwc2 with a hub, expected that we'll get some transfer
errors sometimes. The controller is expected to try at least 3 times
before giving up. See figure "Figure A-67. Normal HS CSPLIT 3 Strikes
Smash" in the USB
Hi Johan,
2015-11-06 12:24 GMT+01:00 Johan Hovold :
> On Thu, Nov 05, 2015 at 01:57:43PM +0100, Jonas Jonsson wrote:
>> Some modems, such as the Telit UE910, are using an Infineon Flash Loader
>> utility. It has two interfaces, 2/2/0 (Abstract Modem) and 10/0/0 (CDC
>> Data). The latter can be use
Hello.
On 11/11/2015 12:38 PM, Felipe Ferreri Tonello wrote:
This avoids duplication of USB requests for OUT endpoint and
re-enabling endpoints.
Signed-off-by: Felipe F. Tonello
---
drivers/usb/gadget/function/f_midi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Hi,
On Tue, Nov 10, 2015 at 11:21:56PM +, John Youn wrote:
> On 11/9/2015 12:43 PM, Stefan Wahren wrote:
> > Hi,
> >
> > Am 09.11.2015 um 12:53 schrieb Marek Szyprowski:
> >> Hello,
> >>
> >>
> >> This change looks reasonable, I remember the similar issue was in
> >> s3c-hsotg driver
> >> and
On 11/10/2015 07:14 PM, Peter Chen wrote:
> On Tue, Nov 10, 2015 at 04:46:51PM -0800, Tim Bird wrote:
>> This fixes a bug where if you disconnect and re-connect the USB cable,
>> the gadget driver stops working.
>>
>> Add support for async_irq to wake up driver from low power mode.
>> Without thi
On Tue, 10 Nov 2015, Dmitry Katsubo wrote:
> On 10/11/2015 16:00, Alan Stern wrote:
> > On Tue, 10 Nov 2015, Dmitry Katsubo wrote:
> >
> >> Hello everyone,
> >>
> >> Sorry for cross-posting from linux-s...@vger.kernel.org
> >>
> >> In continuation to the issue described in [1] and [2]:
> >>
> >> U
On Wed, 11 Nov 2015, Lu Baolu wrote:
> Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.")
> adds usb3_lpm_enabled member to struct usb_device. There is no reference
> to this member now. Hence, it could be removed.
>
> Signed-off-by: Lu Baolu
> ---
> include/linux/usb.h | 1
Hi Johan
Ok, I'll include a changelog in future patches. Here is the current changlog :
Changes in v2:
* Use generic implementation for read/write code
* Use TIOCSRS485/TIOCGRS485 instead of moxa specific ioctl
* Other problems pointed out by Johan review
Changes in v3:
* Drop unused defines
* F
Move constants to the right of binary operators.
Semantic patch information:
Depends on personal taste in some cases.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
CC: Dave Penkler
Signed-off-by: Fengguang Wu
Signed-off-by: Julia Lawall
---
This is what Coccinelle generates.
These ioctls provide support for the USBTMC-USB488 control requests
for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT
Signed-off-by: Dave Penkler
---
drivers/usb/class/usbtmc.c | 76
include/uapi/linux/usb/tmc.h | 9 +-
2 files changed, 84 inserti
This is a convenience function to obtain an instrument's capabilities
from its file descriptor without having to access sysfs from the user
program.
Signed-off-by: Dave Penkler
---
drivers/usb/class/usbtmc.c | 12
include/uapi/linux/usb/tmc.h | 21 ++---
2 files ch
Background:
In many situations operations on multiple instruments need to be
synchronized. poll/select provide a convenient way of waiting on a number
of different instruments and other peripherals simultaneously.
Signed-off-by: Dave Penkler
---
drivers/usb/class/usbtmc.c | 23 ++
Background:
By configuring an instrument's event status register various conditions
can be reported via an SRQ notification. This complements the synchronous
polling approach using the READ_STATUS_BYTE ioctl with an asynchronous
notification.
Signed-off-by: Dave Penkler
---
drivers/usb/class/usb
Background:
When performing a read on an instrument that is executing a function
that runs longer than the USB timeout the instrument may hang and require
a device reset to recover. The READ_STATUS_BYTE operation always returns
even when the instrument is busy permitting to poll for the appropriate
Implement support for the USB488 defined READ_STATUS_BYTE ioctl (1/5)
and SRQ notifications with fasync (2/5) and poll/select (3/5) in order
to be able to synchronize with variable duration instrument operations.
Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
LOCAL_LOCKOUT. (4/5
Hi Lu,
[auto build test WARNING on v4.3-rc7]
[also build test WARNING on next-2015]
url:
https://github.com/0day-ci/linux/commits/Lu-Baolu/usb-core-lpm-add-sysfs-node-for-usb3-lpm-permit/2015-160805
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
include
On Wed, Nov 11, 2015 at 10:35:47AM +0100, Mathieu OTHACEHE wrote:
> Add a driver which supports :
>
> - UPort 1110 : 1 port RS-232 USB to Serial Hub.
> - UPort 1130 : 1 port RS-422/485 USB to Serial Hub.
> - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation.
> - UPort 1150 : 1 po
Hi Sergei,
On 10/11/15 18:43, Sergei Shtylyov wrote:
> Hello.
>
> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>
>> This avoids duplication of USB requests for OUT endpoint and
>> re-enabling endpoints.
>>
>> Signed-off-by: Felipe F. Tonello
>> ---
>> drivers/usb/gadget/function/f_midi.c
Add a driver which supports :
- UPort 1110 : 1 port RS-232 USB to Serial Hub.
- UPort 1130 : 1 port RS-422/485 USB to Serial Hub.
- UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation.
- UPort 1150 : 1 port RS-232/422/485 USB to Serial Hub.
- UPort 1150I : 1 port RS-232/422/485 USB
Hi,
This patch series is about to add a sysfs attribute, through which
users can disable or enable USB3 LPM (link power management) from
a USB port. Once LPM is disabled from the USB port, LPM between the
downstreaming device and the hub port will not be activated. This
helps users to use any LPM-
Commit 655fe4effe0f ("usbcore: add sysfs support to xHCI usb3
hardware LPM") introduced usb3_hardware_lpm sysfs node. This
doesn't show the correct status of USB3 U1 and U2 LPM status.
This patch fixes this by replacing usb3_hardware_lpm with two
nodes, usb3_hardware_lpm_u1 (for U1) and usb3_hardw
USB3 LPM is default on in Linux kernel if both xHCI host controller
and the USB devices declare to be LPM-capable. Unfortunately, some
devices are known to work well with LPM disabled, but to be broken
if LPM is enabled, although it declares the LPM capability. Users
won't be able to use this kind
Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.")
adds usb3_lpm_enabled member to struct usb_device. There is no reference
to this member now. Hence, it could be removed.
Signed-off-by: Lu Baolu
---
include/linux/usb.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/inclu
63 matches
Mail list logo
