Re: [PATCH v2 1/1] usb: dwc2: gadget: parity fix in isochronous mode

2015-09-03 Thread John Youn
On 8/31/2015 9:17 AM, Scott Branden wrote: > From: Roman Bacik > > USB OTG driver in isochronous mode has to set the parity of the receiving > microframe. The parity is set to even by default. This causes problems for > an audio gadget, if the host starts transmitting on odd microframes. > > Thi

Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-09-03 Thread Olliver Schinagl
Hey Hans, On 07-08-15 10:45, Olliver Schinagl wrote: If you change the dr_mode to host then you _must_ also remove any id_det and vbus_det gpio settings from the usb_phy node in the dts, as the sun4i phy code detects host vs otg mode by checking for the presence of these. Yes, this fixes it

[PATCH] USB: serial: add Moxa UPORT 11x0 driver

2015-09-03 Thread Mathieu OTHACEHE
Add a driver which supports : - UPort 1110 : 1 port RS-232 USB to Serial Hub. - UPort 1130 : 1 port RS-422/485 USB to Serial Hub. - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation. - UPort 1150 : 1 port RS-232/422/485 USB to Serial Hub. - UPort 1150I : 1 port RS-232/422/485 USB

[PATCH 3/3][v4] arm: dts: ls1021a: Add quirk for Erratum A009116

2015-09-03 Thread Nikhil Badola
Add "snps,quirk-frame-length-adjustment" property to USB3 node for erratum A009116. This property provides value of GFLADJ_30MHZ for post silicon frame length adjustment. Signed-off-by: Nikhil Badola --- Changes for v4: None arch/arm/boot/dts/ls1021a.dtsi | 1 + 1 file changed, 1 insertion(+)

[PATCH 2/3][v4] drivers: usb: dwc3: Add frame length adjustment quirk

2015-09-03 Thread Nikhil Badola
Add adjust_frame_length_quirk for writing to fladj register which adjusts (micro)frame length to value provided by "snps,quirk-frame-length-adjustment" property thus avoiding USB 2.0 devices to time-out over a longer run Signed-off-by: Nikhil Badola --- Changes for v4: Removed mixed declerations

[PATCH 1/3][v4] Documentation: dt: dwc3: Add snps,quirk-frame-length-adjustment property

2015-09-03 Thread Nikhil Badola
Add snps,quirk-frame-length-adjustment property which provides value for post silicon frame length adjustment Signed-off-by: Nikhil Badola --- Changes for v4: None Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bind

RE: [PATCH v2 1/1] usb: dwc2: gadget: parity fix in isochronous mode

2015-09-03 Thread Roman Bacik
Is there anything else we should address in this patch? Thanks, Roman > -Original Message- > From: Scott Branden [mailto:sbran...@broadcom.com] > Sent: August-31-15 9:17 AM > To: John Youn; Greg Kroah-Hartman; linux-usb@vger.kernel.org; Roman > Bacik > Cc: linux-ker...@vger.kernel.org; bc

Re: PROBLEM: lsusb -v freezes kernel on Acer ES1-111M

2015-09-03 Thread Alan Stern
On Thu, 3 Sep 2015, Roland Weber wrote: > Hello Alan, > > > The kernel freezes before the > > new log statements, or any others in hub.c, are executed. > > Wrong filename there, it's usb.c of course. I'm not sure what you mean by that. Everything we have been discussing is in hub.c, not usb.c.

RE: [PATCH 2/3][v3] drivers: usb: dwc3: Add frame length adjustment quirk

2015-09-03 Thread Badola Nikhil
> -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, September 03, 2015 9:25 PM > To: Badola Nikhil-B46172 > Cc: linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; linux- > o...@vger.kernel.org; ba...@ti.com; gre...@linuxfoundation.org > Subject: Re: [PAT

Re: PROBLEM: lsusb -v freezes kernel on Acer ES1-111M

2015-09-03 Thread Roland Weber
Hello Alan, > The kernel freezes before the > new log statements, or any others in hub.c, are executed. Wrong filename there, it's usb.c of course. I've collected debug output from the boot sequence of the bad kernel, with extra entry/exit statements, and of the last good kernel, without the ext

Re: [PATCH v4 1/9] usb: dwc3: add dual-role support

2015-09-03 Thread Felipe Balbi
Hi, On Thu, Sep 03, 2015 at 03:21:48PM +0300, Roger Quadros wrote: > >> + dwc->fsm->id = id; > >> + dwc->fsm->b_sess_vld = vbus; > >> + usb_otg_sync_inputs(dwc->fsm); > >> +} > >> + > >> +static int dwc3_drd_start_host(struct otg_fsm *fsm, int on) > >> +{ > >> + struct device *dev = usb_otg_fs

Re: [PATCH 2/3][v3] drivers: usb: dwc3: Add frame length adjustment quirk

2015-09-03 Thread Felipe Balbi
On Thu, Sep 03, 2015 at 11:34:04AM +0530, Nikhil Badola wrote: > Add adjust_frame_length_quirk for writing to fladj register > which adjusts (micro)frame length to value provided by > "snps,quirk-frame-length-adjustment" property thus avoiding > USB 2.0 devices to time-out over a longer run > > Si

Re: [PATCH v4 4/9] usb: dwc3: core: Adapt to named interrupts

2015-09-03 Thread Felipe Balbi
Hi, On Thu, Sep 03, 2015 at 03:46:43PM +0300, Roger Quadros wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 02/09/15 17:34, Felipe Balbi wrote: > > On Wed, Sep 02, 2015 at 05:24:19PM +0300, Roger Quadros wrote: > >> From: Felipe Balbi > >> > >> Add support to use interrupt name

Re: [PATCH v4 5/9] usb: dwc3: core: make dual-role work with OTG irq

2015-09-03 Thread Felipe Balbi
Hi, On Thu, Sep 03, 2015 at 04:52:02PM +0300, Roger Quadros wrote: > >>if (on) { > >> - dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_HOST); > >> + /* OCTL.PeriMode = 0 */ > >> + reg = dwc3_readl(dwc->regs, DWC3_OCTL); > >> + reg &= ~DWC3_OCTL_PERIMODE; > >> +

Re: [PATCH] usb/gadget/function/u_ether.c: Allow jumbo frames

2015-09-03 Thread Greg KH
On Thu, Sep 03, 2015 at 11:36:15AM +0200, Mike Looijmans wrote: > I'd like to bring this to your attention again please. > > If there is something wrong about this patch, please tell me so. It's the middle of the merge window and we can't do anything with new patches at the moment until 4.3-rc1

Re: [PATCH] usb/gadget/function/u_ether.c: Allow jumbo frames

2015-09-03 Thread Mike Looijmans
I'd like to bring this to your attention again please. If there is something wrong about this patch, please tell me so. And also note that this patch does not enable jumbo frames on itself, it just removes the artificial limits in the kernel prohibiting mtus above 1500. The MTU can be set fro

Re: [PATCH v4 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role

2015-09-03 Thread Sergei Shtylyov
On 09/03/2015 05:10 PM, Roger Quadros wrote: We can't rely just on dr_mode to decide if we're in host or gadget mode when we're configured as otg/dual-role. So while dr_mode is OTG, we find out from the otg state machine if we're in host or gadget mode and take the necessary actions during susp

Re: [PATCH v4 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role

2015-09-03 Thread Roger Quadros
On 03/09/15 17:05, Sergei Shtylyov wrote: > Hello. > > On 09/03/2015 05:01 PM, Roger Quadros wrote: > We can't rely just on dr_mode to decide if we're in host or gadget mode when we're configured as otg/dual-role. So while dr_mode is OTG, we find out from the otg state machine if

Re: [PATCH v4 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role

2015-09-03 Thread Sergei Shtylyov
Hello. On 09/03/2015 05:01 PM, Roger Quadros wrote: We can't rely just on dr_mode to decide if we're in host or gadget mode when we're configured as otg/dual-role. So while dr_mode is OTG, we find out from the otg state machine if we're in host or gadget mode and take the necessary actions dur

Re: [PATCH v4 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role

2015-09-03 Thread Roger Quadros
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 02/09/15 17:48, Felipe Balbi wrote: > On Wed, Sep 02, 2015 at 05:24:24PM +0300, Roger Quadros wrote: >> We can't rely just on dr_mode to decide if we're in host or gadget >> mode when we're configured as otg/dual-role. So while dr_mode is >> OTG,

Re: [PATCH v4 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role

2015-09-03 Thread Roger Quadros
On 02/09/15 20:22, Sergei Shtylyov wrote: > Hello. > > On 09/02/2015 05:24 PM, Roger Quadros wrote: > >> We can't rely just on dr_mode to decide if we're in host or gadget >> mode when we're configured as otg/dual-role. So while dr_mode is >> OTG, we find out from the otg state machine if we're

Re: [PATCH v4 8/9] usb: dwc3: core: Prevent otg events from disabling themselves

2015-09-03 Thread Roger Quadros
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 02/09/15 17:47, Felipe Balbi wrote: > On Wed, Sep 02, 2015 at 05:24:23PM +0300, Roger Quadros wrote: >> There is a race happening during dwc3_drd_init() that causes >> otg events to get disabled. This is what happens. >> >> dwc3_otg_irq() happens

Re: [PATCH v4 6/9] usb: dwc3: save/restore OTG registers during suspend/resume

2015-09-03 Thread Roger Quadros
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 02/09/15 17:44, Felipe Balbi wrote: > On Wed, Sep 02, 2015 at 05:24:21PM +0300, Roger Quadros wrote: >> Without this we loose OTG controller register context and malfunction >> after a system suspend-resume. >> >> Signed-off-by: Roger Quadros >>

Re: [PATCH v4 5/9] usb: dwc3: core: make dual-role work with OTG irq

2015-09-03 Thread Roger Quadros
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 02/09/15 17:43, Felipe Balbi wrote: > Hi, > > On Wed, Sep 02, 2015 at 05:24:20PM +0300, Roger Quadros wrote: >> If the ID pin event is not available over extcon >> then we rely on the OTG controller to provide us ID and VBUS >> information. >> >>

Re: [PATCH v4 4/9] usb: dwc3: core: Adapt to named interrupts

2015-09-03 Thread Roger Quadros
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 02/09/15 17:34, Felipe Balbi wrote: > On Wed, Sep 02, 2015 at 05:24:19PM +0300, Roger Quadros wrote: >> From: Felipe Balbi >> >> Add support to use interrupt names, >> >> Following are the interrupt names >> >> Peripheral Interrupt - peripheral >

Re: [PATCH v4 1/9] usb: dwc3: add dual-role support

2015-09-03 Thread Roger Quadros
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 02/09/15 17:31, Felipe Balbi wrote: > Hi, > > On Wed, Sep 02, 2015 at 05:24:16PM +0300, Roger Quadros wrote: >> Register with the USB OTG core. Since we don't support >> OTG yet we just work as a dual-role device even >> if device tree says "otg"

[PATCH] usb: musb: Disable interrupts on suspend, enable them on resume

2015-09-03 Thread pascal . huerst
From: Pascal Huerst In certain situations, an interrupt triggers on resume, before musb_start() has been called. This has been observed to cause enumeration issues after suspend/resume cycles with AM335x. Signed-off-by: Pascal Huerst --- drivers/usb/musb/musb_core.c | 6 ++ 1 file changed,

Re: usb: musb: host: enumeration issues

2015-09-03 Thread Pascal Huerst
On 02.09.2015 22:50, Felipe Balbi wrote: > Hi, > > On Wed, Sep 02, 2015 at 06:33:11PM +0200, Pascal Huerst wrote: >> Hey, >> >> On 02.09.2015 14:28, Felipe Balbi wrote: >>> Hi, >>> >>> On Wed, Sep 02, 2015 at 11:35:45AM +0200, Pascal Huerst wrote: Hey Felipe, on a custom built, am