Re: Re: [PATCH] xHCI: FSE handled cleanly by incrementing event dequeue pointer

2015-07-02 Thread SAUROV KANTI SHYAM
Hi Mathias The kernel version is 3.8.2, but patches of 3.17 are back ported into it. > Event ring dequeue is increased either in handle_tx_event(), cleanup: > if (trb_comp_code == COMP_MISSED_INT || !ep->skip) { >inc_deq(xhci, xhci->event_ring); Event ring dequeue should b

Re: musb gadget HUB traffic sniffing/forwarding

2015-07-02 Thread Felipe Balbi
Hi, On Thu, Jul 02, 2015 at 06:02:50PM -0700, Y. Zhang wrote: > Hi all, > > I'm new to linux usb and would like some guidance on achieving some of > the following goals. > I have a beaglebone black (BBB - currently running kernel v3.12) with you need to ask for support from whoever gave you that

[PATCH 1/1] usb: gadget: composite: only control read may need zero length packet

2015-07-02 Thread Peter Chen
According to the USB 2.0 Spec CH5.5.3 and CH8.5.3.2, only control read (IN) needs zero length packet. Cc: Alan Stern Signed-off-by: Peter Chen --- drivers/usb/gadget/composite.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/us

Re: About zero-length packet design for EHCI

2015-07-02 Thread Peter Chen
On Thu, Jul 02, 2015 at 10:46:36AM -0400, Alan Stern wrote: > On Thu, 2 Jul 2015, Peter Chen wrote: > > > > If a control-IN transfer has a data stage that is shorter than wLength > > > and is a multiple of the ep0 maxpacket value, then the peripheral must > > > send a zero-length packet to indicat

musb gadget HUB traffic sniffing/forwarding

2015-07-02 Thread Y. Zhang
Hi all, I'm new to linux usb and would like some guidance on achieving some of the following goals. I have a beaglebone black (BBB - currently running kernel v3.12) with OTG in peripheral mode on usb bus#1 and a host port to connect devices on usb bus#2. 1. usb bus#1: connect OTG on BBB as a musb

Re: [PATCH v2] arm: koelsch: make USB0 perform Host/Function switching

2015-07-02 Thread Simon Horman
Hi Phil, when you re-spin this patch could you change the prefix to the following? ARM: shmobile: koelsch: Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH] usb: dwc3: core: avoid NULL pointer dereference

2015-07-02 Thread Felipe Balbi
commit 3e10a2ce98d1 ("usb: dwc3: add hsphy_interface property") introduced a possible NULL pointer dereference because dwc->hsphy_interface can be NULL. In order to fix it, all we have to do is guard strncmp() against a NULL argument. Fixes: 3e10a2ce98d1 ("usb: dwc3: add hsphy_interface property"

[PATCH v2] usb: move assignment out of if condition

2015-07-02 Thread Kris Borer
Fix four occurrences of checkpatch.pl error: ERROR: do not use assignment in if condition Signed-off-by: Kris Borer --- drivers/usb/core/hcd.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index be5b207..

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-02 Thread Alan Stern
On Thu, 2 Jul 2015, Jeremy White wrote: > > Oliver is talking about the danger of having part of the communication > > path for a block device run through userspace. > > > > Imagine a situation where the client uses a USB storage device provided > > by the server as a swap device. And suppose a

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-02 Thread Jeremy White
On 07/02/2015 02:59 PM, Alan Stern wrote: > On Thu, 2 Jul 2015, Jeremy White wrote: > I don't follow that analysis. The usbip interactions with the usb stack all seem to be atomic, and never trigger a syscall, as far as I can tell. A port reset will flip a few bits and return. A

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-02 Thread Alan Stern
On Thu, 2 Jul 2015, Jeremy White wrote: > >> I don't follow that analysis. The usbip interactions with the usb stack > >> all seem to be atomic, and never trigger a syscall, as far as I can > >> tell. A port reset will flip a few bits and return. A urb enqueue > >> queues and wakes a different

Re: [PATCH v2 4/5] usb: gadget: mass_storage: Use static array for luns

2015-07-02 Thread Krzysztof Opasiak
On 07/02/2015 09:29 PM, Michal Nazarewicz wrote: On Thu, Jul 02 2015, Krzysztof Opasiak wrote: This patch replace dynamicly allocated luns array with static one. This simplifies the code of mass storage function and modules. It also fix issue with reporting wrong number of LUNs in GET_MAX_LUN

Re: [PATCH v2 5/5] usb: gadget: mass_storage: Warn if LUNs ids are not contiguous

2015-07-02 Thread Michal Nazarewicz
On Thu, Jul 02 2015, Krzysztof Opasiak wrote: > According to mass storage specification: > > "Logical Unit Numbers on the device shall be numbered contiguously > starting from LUN 0 to a maximum LUN of 15 (Fh)" > > So let's at least print a warning message that LUNs ids should be > contiguous. > >

Re: [PATCH v2 4/5] usb: gadget: mass_storage: Use static array for luns

2015-07-02 Thread Michal Nazarewicz
On Thu, Jul 02 2015, Krzysztof Opasiak wrote: > This patch replace dynamicly allocated luns array with static one. > This simplifies the code of mass storage function and modules. > It also fix issue with reporting wrong number of LUNs in GET_MAX_LUN > request. > > Also change the nluns to max_luns

Re: [PATCH v2 1/5] usb: gadget: mass_storage: Free buffers if create lun fails

2015-07-02 Thread Krzysztof Opasiak
Felippe, Could you please take this patch as a fix now and leave the rest of this series to merge window or should I resend it separately? On 07/02/2015 08:56 PM, Krzysztof Opasiak wrote: Creation of LUN 0 may fail (for example due to ENOMEM). As fsg_common_set_num_buffers() does some memory

Re: Configfs usb mass_storage device always reports 8 LUNs ?

2015-07-02 Thread Krzysztof Opasiak
On 07/02/2015 09:14 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 09:12:30PM +0200, Krzysztof Opasiak wrote: On 07/02/2015 07:16 PM, Michal Nazarewicz wrote: On 07/02/2015 05:25 PM, Michal Nazarewicz wrote: Since I think we agreed that luns should just be turned into an array with static

Re: Configfs usb mass_storage device always reports 8 LUNs ?

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 09:12:30PM +0200, Krzysztof Opasiak wrote: > > > On 07/02/2015 07:16 PM, Michal Nazarewicz wrote: > >>On 07/02/2015 05:25 PM, Michal Nazarewicz wrote: > >>>Since I think we agreed that luns should just be turned into an array > >>>with static length the above won’t be too

Re: Configfs usb mass_storage device always reports 8 LUNs ?

2015-07-02 Thread Krzysztof Opasiak
On 07/02/2015 07:16 PM, Michal Nazarewicz wrote: On 07/02/2015 05:25 PM, Michal Nazarewicz wrote: Since I think we agreed that luns should just be turned into an array with static length the above won’t be too far from that goal. On Thu, Jul 02 2015, Krzysztof Opasiak wrote: True, just star

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-02 Thread Jeremy White
On 07/02/2015 01:46 PM, Oliver Neukum wrote: > On Thu, 2015-07-02 at 10:57 -0500, Jeremy White wrote: >> On 07/02/2015 07:10 AM, Oliver Neukum wrote: >>> On Thu, 2015-07-02 at 13:35 +0200, Hans de Goede wrote: Hi, On 02-07-15 10:45, Oliver Neukum wrote: > On Wed, 2015-07-01 at 10

Re: [PATCH v3] usb: xhci: Add support for URB_ZERO_PACKET to bulk/sg transfers

2015-07-02 Thread Reyad Attiyat
This version of the patch changes last_trb varible name to last_trb_num and fixes code style. I have also added a td to the urb td array. This now gets prepared properl,y with prepare_transfer(), and is handled correctly when transferred and completed. It only calls the urb completion callback once

[PATCH v2 2/5] usb: gadget: mass_storage: Place EXPORT_SYMBOL_GPL() after func definition

2015-07-02 Thread Krzysztof Opasiak
EXPORT_SYMBOL_GPL() is usually placed after function definition not before. Signed-off-by: Krzysztof Opasiak Acked-by: Michal Nazarewicz --- drivers/usb/gadget/function/f_mass_storage.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_mass_sto

[PATCH v2 1/5] usb: gadget: mass_storage: Free buffers if create lun fails

2015-07-02 Thread Krzysztof Opasiak
Creation of LUN 0 may fail (for example due to ENOMEM). As fsg_common_set_num_buffers() does some memory allocation we should free it before it becomes unavailable. Signed-off-by: Krzysztof Opasiak Acked-by: Michal Nazarewicz --- drivers/usb/gadget/function/f_mass_storage.c |5 + 1 file

[PATCH v2 3/5] usb: gadget: storage-common: Set FSG_MAX_LUNS to 16

2015-07-02 Thread Krzysztof Opasiak
Mass storage spec allows up to 16 LUNs, so let's don't add some more restrictive limits. Signed-off-by: Krzysztof Opasiak Acked-by: Michal Nazarewicz --- drivers/usb/gadget/function/f_mass_storage.c |2 +- drivers/usb/gadget/function/storage_common.h |2 +- 2 files changed, 2 insertions

[PATCH v2 4/5] usb: gadget: mass_storage: Use static array for luns

2015-07-02 Thread Krzysztof Opasiak
This patch replace dynamicly allocated luns array with static one. This simplifies the code of mass storage function and modules. It also fix issue with reporting wrong number of LUNs in GET_MAX_LUN request. Also change the nluns to max_luns which is better name for value stored in that place as w

[PATCH v2 5/5] usb: gadget: mass_storage: Warn if LUNs ids are not contiguous

2015-07-02 Thread Krzysztof Opasiak
According to mass storage specification: "Logical Unit Numbers on the device shall be numbered contiguously starting from LUN 0 to a maximum LUN of 15 (Fh)" So let's at least print a warning message that LUNs ids should be contiguous. Signed-off-by: Krzysztof Opasiak --- drivers/usb/gadget/fu

[PATCH v2 0/5] Mass storage fixes and improvements

2015-07-02 Thread Krzysztof Opasiak
Hello, This series fix a few bugs in mass storage function, adds a warning message when binding function with not contiguous LUN ids and replace dynamically allocated luns array with static one what simplifies the code. This series also fix GET_MAX_LUNS request to return max id of valid lun, not

[PATCH v3] usb: xhci: Add support for URB_ZERO_PACKET to bulk/sg transfers

2015-07-02 Thread Reyad Attiyat
This commit checks for the URB_ZERO_PACKET flag and creates an extra zero-length td if the urb transfer length is a multiple of the endpoint's max packet length. Signed-off-by: Reyad Attiyat --- drivers/usb/host/xhci-ring.c | 66 ++-- drivers/usb/host/xhci

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-02 Thread Oliver Neukum
On Thu, 2015-07-02 at 10:57 -0500, Jeremy White wrote: > On 07/02/2015 07:10 AM, Oliver Neukum wrote: > > On Thu, 2015-07-02 at 13:35 +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 02-07-15 10:45, Oliver Neukum wrote: > >>> On Wed, 2015-07-01 at 10:06 +0100, Daniel P. Berrange wrote: > >>> > >>>

Re: usb:gadget:hid:Add BOOT mode support

2015-07-02 Thread Alan Stern
On Wed, 27 May 2015, Golmer Palmer wrote: > Hi Alan, > > Thank you for the new patch! > However, a comment: > > * At page 74 of the specifications, > section F.3 Boot Keyboard Requirements, > (http://www.usb.org/developers/hidpage/HID1_11.pdf) > is defined that: > "The Boot Keyboard shall, upon

Re: Configfs usb mass_storage device always reports 8 LUNs ?

2015-07-02 Thread Michal Nazarewicz
> On 07/02/2015 05:25 PM, Michal Nazarewicz wrote: >> Since I think we agreed that luns should just be turned into an array >> with static length the above won’t be too far from that goal. On Thu, Jul 02 2015, Krzysztof Opasiak wrote: > True, just started working on it. I just got this to compile

Re: MUSB dual-role on AM335x behaving weirdly

2015-07-02 Thread Bin Liu
Hi, On Thu, Jul 2, 2015 at 2:16 AM, Gregory CLEMENT wrote: > Hi Felipe, > > On 27/05/2015 11:42, Alexandre Belloni wrote: >> Hi, >> >> On 26/05/2015 at 09:51:18 -0500, Felipe Balbi wrote : >>> On Thu, May 14, 2015 at 04:36:33PM -0500, Bin Liu wrote: Alexandre, On Thu, May 14, 2015

Re: Configfs usb mass_storage device always reports 8 LUNs ?

2015-07-02 Thread Krzysztof Opasiak
On 07/02/2015 05:25 PM, Michal Nazarewicz wrote: Sorry, I didn’t notice this reply before. On 06/22/2015 04:24 PM, Michal Nazarewicz wrote: common->nluns is set to FSG_MAX_LUNS in fsg_alloc_inst (which is called prior to fsg_alloc) so this is not an issue. On Mon, Jun 22 2015, Krzysztof Op

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-02 Thread Jeremy White
On 07/02/2015 07:10 AM, Oliver Neukum wrote: > On Thu, 2015-07-02 at 13:35 +0200, Hans de Goede wrote: >> Hi, >> >> On 02-07-15 10:45, Oliver Neukum wrote: >>> On Wed, 2015-07-01 at 10:06 +0100, Daniel P. Berrange wrote: >>> I don't really think it is sensible to be defining & implementing new

Re: [PATCH] usb-storage: ignore ZTE MF 823 in mode 0x1225

2015-07-02 Thread Dan Williams
On Thu, 2015-07-02 at 15:43 +0200, Oliver Neukum wrote: > On Thu, 2015-07-02 at 20:33 +0700, Lars Melin wrote: > > On 2015-07-02 20:01, Oliver Neukum wrote: > > > On Thu, 2015-07-02 at 14:43 +0200, Oliver Neukum wrote: > > >> On Wed, 2015-07-01 at 22:50 +0700, Lars Melin wrote: > > >> > > >>> Then

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Michal Nazarewicz
> On 07/02/2015 03:14 PM, Felipe Balbi wrote: >> I'm taking Michal's patch as a quick fix for the -rc though. That patch >> is simple enough to get in and solves the issue at hand. On Thu, Jul 02 2015, Krzysztof Opasiak wrote: > Nope it doesn't. It may read past buffer in case of legacy gadgets >

Re: Configfs usb mass_storage device always reports 8 LUNs ?

2015-07-02 Thread Michal Nazarewicz
Sorry, I didn’t notice this reply before. > On 06/22/2015 04:24 PM, Michal Nazarewicz wrote: >> common->nluns is set to FSG_MAX_LUNS in fsg_alloc_inst (which is called >> prior to fsg_alloc) so this is not an issue. On Mon, Jun 22 2015, Krzysztof Opasiak wrote: > True, but all legacy gadgets whic

Re: About zero-length packet design for EHCI

2015-07-02 Thread Steve Calfee
On Wed, Jul 1, 2015 at 11:00 PM, Peter Chen wrote: > If "one" is "multiple"? > The wLength at setup packet is 64 bytes, Maximum Packet Length at > dQH is 64 bytes, and the Total Bytes at dTD is 64 bytes too, does device > must prepare a zero-length packet? > > I would like to double confirm it sin

Re: About zero-length packet design for EHCI

2015-07-02 Thread Alan Stern
On Thu, 2 Jul 2015, Peter Chen wrote: > > If a control-IN transfer has a data stage that is shorter than wLength > > and is a multiple of the ep0 maxpacket value, then the peripheral must > > send a zero-length packet to indicate the end of the data stage. > > Thus, the UDC driver must prepare a

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Gregory CLEMENT
Hi Felipe, On 02/07/2015 16:01, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 03:52:32PM +0200, Gregory CLEMENT wrote: >> Hi Felipe, >> >> On 02/07/2015 15:14, Felipe Balbi wrote: >>> On Thu, Jul 02, 2015 at 02:55:34PM +0200, Krzysztof Opasiak wrote: On 07/02/2015 02:45 PM, Michal N

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Krzysztof Opasiak
On 07/02/2015 03:14 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 02:55:34PM +0200, Krzysztof Opasiak wrote: On 07/02/2015 02:45 PM, Michal Nazarewicz wrote: On Thu, Jul 02, 2015 at 12:51:54PM +0200, Gregory CLEMENT wrote: When I use configs to configure the mass storage function for the

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

2015-07-02 Thread Maciej S. Szmigiero
On 02.07.2015 10:40, Peter Chen wrote: > On Wed, Jul 01, 2015 at 12:06:19PM -0300, Fabio Estevam wrote: >> From: Fabio Estevam >> >> This reverts commit 73dea4a912b2bfe955305de4891018f9e71e399d. >> >> Since commit 73dea4a912b2("usb: chipidea: usbmisc_imx: delete clock >> information") it is not po

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 03:52:32PM +0200, Gregory CLEMENT wrote: > Hi Felipe, > > On 02/07/2015 15:14, Felipe Balbi wrote: > > On Thu, Jul 02, 2015 at 02:55:34PM +0200, Krzysztof Opasiak wrote: > >> > >> > >> On 07/02/2015 02:45 PM, Michal Nazarewicz wrote: > On Thu, Jul 02, 2015 at 12:51:54P

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Gregory CLEMENT
Hi Felipe, On 02/07/2015 15:14, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 02:55:34PM +0200, Krzysztof Opasiak wrote: >> >> >> On 07/02/2015 02:45 PM, Michal Nazarewicz wrote: On Thu, Jul 02, 2015 at 12:51:54PM +0200, Gregory CLEMENT wrote: > When I use configs to configure the mass st

Re: [PATCH] usb-storage: ignore ZTE MF 823 in mode 0x1225

2015-07-02 Thread Oliver Neukum
On Thu, 2015-07-02 at 20:33 +0700, Lars Melin wrote: > On 2015-07-02 20:01, Oliver Neukum wrote: > > On Thu, 2015-07-02 at 14:43 +0200, Oliver Neukum wrote: > >> On Wed, 2015-07-01 at 22:50 +0700, Lars Melin wrote: > >> > >>> Then I would like to see an lsusb listing for 19d2:1225 with an SD-card >

Re: [PATCH] usb-storage: ignore ZTE MF 823 in mode 0x1225

2015-07-02 Thread Lars Melin
On 2015-07-02 20:01, Oliver Neukum wrote: On Thu, 2015-07-02 at 14:43 +0200, Oliver Neukum wrote: On Wed, 2015-07-01 at 22:50 +0700, Lars Melin wrote: Then I would like to see an lsusb listing for 19d2:1225 with an SD-card interface, I have only seen 19d2:1225 with a single storage interface w

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Felipe Balbi
On Thu, Jul 02, 2015 at 02:55:34PM +0200, Krzysztof Opasiak wrote: > > > On 07/02/2015 02:45 PM, Michal Nazarewicz wrote: > >>On Thu, Jul 02, 2015 at 12:51:54PM +0200, Gregory CLEMENT wrote: > >>>When I use configs to configure the mass storage function for the > >>>gadget, and when the device is

Re: [PATCH] usb-storage: ignore ZTE MF 823 in mode 0x1225

2015-07-02 Thread Oliver Neukum
On Thu, 2015-07-02 at 14:43 +0200, Oliver Neukum wrote: > On Wed, 2015-07-01 at 22:50 +0700, Lars Melin wrote: > > > Then I would like to see an lsusb listing for 19d2:1225 with an SD-card > > interface, I have only seen 19d2:1225 with a single storage interface > > which is for the windows inst

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Krzysztof Opasiak
On 07/02/2015 02:45 PM, Michal Nazarewicz wrote: On Thu, Jul 02, 2015 at 12:51:54PM +0200, Gregory CLEMENT wrote: When I use configs to configure the mass storage function for the gadget, and when the device is plugged under Windows, then the partition that I expose is well managed, but I also

RE: [PATCH 2/3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

2015-07-02 Thread Phil Edworthy
Hi Kishon, On 02 July 2015 09:22, Kishon wrote: > Hi, > > On Monday 22 June 2015 08:12 PM, Phil Edworthy wrote: > > Instead of statically selecting the PHY connection to either the > > USBHS (Function) or PCI0 (Host) IP blocks, this change allows the > > dts to specifiy gpio pins for the vbus and

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Michal Nazarewicz
> On Thu, Jul 02, 2015 at 12:51:54PM +0200, Gregory CLEMENT wrote: >> When I use configs to configure the mass storage function for the >> gadget, and when the device is plugged under Windows, then the >> partition that I expose is well managed, but I also see 7 other gadget >> in the device manage

Re: [PATCH] usb-storage: ignore ZTE MF 823 in mode 0x1225

2015-07-02 Thread Oliver Neukum
On Wed, 2015-07-01 at 22:50 +0700, Lars Melin wrote: > Then I would like to see an lsusb listing for 19d2:1225 with an SD-card > interface, I have only seen 19d2:1225 with a single storage interface > which is for the windows install cd-rom. > There are almost no 3G dongles having the SD-card in

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Felipe Balbi
Hi, On Thu, Jul 02, 2015 at 01:58:44PM +0200, Gregory CLEMENT wrote: > Hi Felipe, > > thanks for you prompt feedback. > > On 02/07/2015 13:45, Felipe Balbi wrote: > > Hi, > > > > On Thu, Jul 02, 2015 at 12:51:54PM +0200, Gregory CLEMENT wrote: > >> Hello, > >> > >> When I use configs to configu

Re: [PATCH] xHCI: FSE handled cleanly by incrementing event dequeue pointer

2015-07-02 Thread Mathias Nyman
Hi On 02.07.2015 13:45, SAUROV KANTI SHYAM wrote: > Some undefined values, mostly null are coming in event->buffer in my case for > "stop,-invalid length” transfer event. That doesn't sound good, what xhci vendor and version are you using? Have you seen/tried this on other xhci hw as well? Wha

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-02 Thread Oliver Neukum
On Thu, 2015-07-02 at 13:35 +0200, Hans de Goede wrote: > Hi, > > On 02-07-15 10:45, Oliver Neukum wrote: > > On Wed, 2015-07-01 at 10:06 +0100, Daniel P. Berrange wrote: > > > >> I don't really think it is sensible to be defining & implementing new > >> network services which can't support strong

RE: [PATCH v2] arm: koelsch: make USB0 perform Host/Function switching

2015-07-02 Thread Phil Edworthy
Hi Sergei. On 02 July 2015 12:32, Sergei wrote: > Hello. > > On 7/2/2015 11:14 AM, Phil Edworthy wrote: > > > Both USB Host (pci0) and Function (USBHS) drivers are enabled. > > The USB PHY driver determines which IP block should be connected > > based on vbus and id signals read via gpios. > >

RE: [PATCH v2] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-02 Thread Phil Edworthy
Hi Sergei, On 02 July 2015 12:17, Sergei wrote: > To: Phil Edworthy; Yoshihiro Shimoda > Hello. > > On 7/2/2015 10:36 AM, Phil Edworthy wrote: > > > These changes allow a PHY driver to trigger a VBUS interrupt and > > to provide the value of VBUS. > > > Signed-off-by: Phil Edworthy > > [...]

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Gregory CLEMENT
Hi Felipe, thanks for you prompt feedback. On 02/07/2015 13:45, Felipe Balbi wrote: > Hi, > > On Thu, Jul 02, 2015 at 12:51:54PM +0200, Gregory CLEMENT wrote: >> Hello, >> >> When I use configs to configure the mass storage function for the >> gadget, and when the device is plugged under Windows

Re: Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Felipe Balbi
Hi, On Thu, Jul 02, 2015 at 12:51:54PM +0200, Gregory CLEMENT wrote: > Hello, > > When I use configs to configure the mass storage function for the > gadget, and when the device is plugged under Windows, then the > partition that I expose is well managed, but I also see 7 other gadget > in the de

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-02 Thread Hans de Goede
Hi, On 02-07-15 10:45, Oliver Neukum wrote: On Wed, 2015-07-01 at 10:06 +0100, Daniel P. Berrange wrote: I don't really think it is sensible to be defining & implementing new network services which can't support strong encryption and authentication. Rather than passing the file descriptor to t

Re: [PATCH v2] arm: koelsch: make USB0 perform Host/Function switching

2015-07-02 Thread Sergei Shtylyov
Hello. On 7/2/2015 11:14 AM, Phil Edworthy wrote: Both USB Host (pci0) and Function (USBHS) drivers are enabled. The USB PHY driver determines which IP block should be connected based on vbus and id signals read via gpios. Note that switch SW5 and SW6 on Koelsch board needs to be set to posi

Re: [PATCH v2] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-02 Thread Sergei Shtylyov
Hello. On 7/2/2015 10:36 AM, Phil Edworthy wrote: These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy [...] diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index dc2aa32

Viewing many gadgets in error under Windows with mass storage function and configfs

2015-07-02 Thread Gregory CLEMENT
Hello, When I use configs to configure the mass storage function for the gadget, and when the device is plugged under Windows, then the partition that I expose is well managed, but I also see 7 other gadget in the device manager with error. This seven bogus gadget seems to be the 7 other LUN that

Re: Re: [PATCH] xHCI: FSE handled cleanly by incrementing event dequeue pointer

2015-07-02 Thread SAUROV KANTI SHYAM
Some undefined values, mostly null are coming in event->buffer in my case for "stop,-invalid length” transfer event. However, in the portion of the code you suggested does not increment the dequeue pointer of transfer event ring, for trb_comp_code = COMP_STOP_INVAL. In handle_tx_event() cleanup:

[PATCH v3] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-02 Thread Phil Edworthy
These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy --- v3: - Changed how indirect vbus is plumbed in. - Removed unnecessary (void) on call to otg_set_peripheral. - Moved code that connects to bus through transceiver s

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

2015-07-02 Thread Peter Chen
On Wed, Jul 01, 2015 at 12:06:19PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > This reverts commit 73dea4a912b2bfe955305de4891018f9e71e399d. > > Since commit 73dea4a912b2("usb: chipidea: usbmisc_imx: delete clock > information") it is not possible to boot a kernel on a mx27pdk: > > us

RE: [PATCH 1/2] usb: chipidea: Reduce ULPI PHY reset pulse to datasheet spec of 1us

2015-07-02 Thread David Laight
From: Peter Chen > Sent: 30 June 2015 03:06 > On Fri, Jun 26, 2015 at 03:47:03PM +0200, Mike Looijmans wrote: > > The datasheet for the 334x PHY mentions that a reset can be performed: > > "... by bringing the pin low for a minimum of 1 microsecond and > > then high." > > A delay of 5ms to implemen

Re: [PATCH] usb-storage: ignore ZTE MF 823 in mode 0x1225

2015-07-02 Thread Oliver Neukum
On Wed, 2015-07-01 at 22:50 +0700, Lars Melin wrote: Hi, > Then I would like to see an lsusb listing for 19d2:1225 with an SD-card > interface, I have only seen 19d2:1225 with a single storage interface > which is for the windows install cd-rom. My dongle indeed has only one interface. But one

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-02 Thread Oliver Neukum
On Wed, 2015-07-01 at 10:06 +0100, Daniel P. Berrange wrote: > I don't really think it is sensible to be defining & implementing new > network services which can't support strong encryption and authentication. > Rather than passing the file descriptor to the kernel and having it do > the I/O direc

RE: [PATCH v2] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-02 Thread Phil Edworthy
Hi Laurent, On 02 July 2015 09:15, Laurent wrote: > Hi Phil, > > (CC'ing Morimoto-san) > > Thank you for the patch. > > On Thursday 02 July 2015 08:36:42 Phil Edworthy wrote: > > These changes allow a PHY driver to trigger a VBUS interrupt and > > to provide the value of VBUS. > > > > Signed-of

Re: [PATCH 2/3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

2015-07-02 Thread Kishon Vijay Abraham I
Hi, On Monday 22 June 2015 08:12 PM, Phil Edworthy wrote: > Instead of statically selecting the PHY connection to either the > USBHS (Function) or PCI0 (Host) IP blocks, this change allows the > dts to specifiy gpio pins for the vbus and id signals. Additional > gpio pins are used to control power

[PATCH v2] arm: koelsch: make USB0 perform Host/Function switching

2015-07-02 Thread Phil Edworthy
Both USB Host (pci0) and Function (USBHS) drivers are enabled. The USB PHY driver determines which IP block should be connected based on vbus and id signals read via gpios. Note that switch SW5 and SW6 on Koelsch board needs to be set to position 3 for this to work. --- Not for upstream until th

Re: [PATCH v2] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-02 Thread Laurent Pinchart
Hi Phil, (CC'ing Morimoto-san) Thank you for the patch. On Thursday 02 July 2015 08:36:42 Phil Edworthy wrote: > These changes allow a PHY driver to trigger a VBUS interrupt and > to provide the value of VBUS. > > Signed-off-by: Phil Edworthy > > --- > v2: > - vbus variables changed from in

[PATCH v2] phy: rcar-gen2 usb: Add Host/Function switching for USB0

2015-07-02 Thread Phil Edworthy
Instead of statically selecting the PHY connection to either the USBHS (Function) or PCI0 (Host) IP blocks, this change allows the dts to specifiy gpio pins for the vbus and id signals. Additional gpio pins are used to control power to an external OTG device and an override to turn vbus on/off. No

Re: [RESEND PATCH 2/2] ARM: at91/dt: update udc compatible strings

2015-07-02 Thread Nicolas Ferre
Le 01/07/2015 22:35, Kevin Hilman a écrit : > Nicolas Ferre writes: > >> From: Boris Brezillon >> >> at91sam9g45, at91sam9x5 and sama5 SoCs should not use >> "atmel,at91sam9rl-udc" for their USB device compatible property since >> this compatible is attached to a specific hardware bug fix. >> >>

[PATCH v2] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-02 Thread Phil Edworthy
These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy --- v2: - vbus variables changed from int to bool. - dev_info() changed to dev_err() --- drivers/usb/renesas_usbhs/common.h | 2 ++ drivers/usb/renesas_usbhs/mod.

Re: MUSB dual-role on AM335x behaving weirdly

2015-07-02 Thread Gregory CLEMENT
Hi Felipe, On 27/05/2015 11:42, Alexandre Belloni wrote: > Hi, > > On 26/05/2015 at 09:51:18 -0500, Felipe Balbi wrote : >> On Thu, May 14, 2015 at 04:36:33PM -0500, Bin Liu wrote: >>> Alexandre, >>> >>> On Thu, May 14, 2015 at 4:26 PM, Alexandre Belloni >>> wrote: On 14/05/2015 at 16:16:12

Re: About zero-length packet design for EHCI

2015-07-02 Thread Peter Chen
On Wed, Jul 01, 2015 at 10:16:12AM -0400, Alan Stern wrote: > On Wed, 1 Jul 2015, Peter Chen wrote: > > > On Tue, Jun 30, 2015 at 12:03:34PM -0400, Alan Stern wrote: > > > On Tue, 30 Jun 2015, Peter Chen wrote: > > > > > > > Hi Alan, > > > > > > > > When reading the code (at qh_urb_transaction)