On Tue, Jun 30, 2015 at 08:46:51AM +0200, Linus Walleij wrote:
> On Sun, Jun 21, 2015 at 12:12 AM, Stefan Agner wrote:
>
> > Add interface to allow CBUS access. The functions set_bitmode and
> > read_pins use control transfers only hence should not interfere
> > with the serial operation mode.
>
On Sun, Jun 21, 2015 at 12:12 AM, Stefan Agner wrote:
> Add interface to allow CBUS access. The functions set_bitmode and
> read_pins use control transfers only hence should not interfere
> with the serial operation mode.
>
> Signed-off-by: Stefan Agner
Interesting. Waiting for Johan's review o
Am 30.06.2015 um 08:10 schrieb Felipe Balbi:
> On Tue, Jun 30, 2015 at 07:30:35AM +0200, Stefan Wahren wrote:
>> Am 15.06.2015 um 06:37 schrieb Stefan Wahren:
>>> Triggering suspend to RAM via sysfs on a i.MX28 causes a NULL pointer
>>> dereference. This patch avoids the oops in mxs_phy_get_vbus_st
On Tue, Jun 30, 2015 at 07:30:35AM +0200, Stefan Wahren wrote:
> Am 15.06.2015 um 06:37 schrieb Stefan Wahren:
> > Triggering suspend to RAM via sysfs on a i.MX28 causes a NULL pointer
> > dereference. This patch avoids the oops in mxs_phy_get_vbus_status()
> > by aborting since there is no syscon
Am 15.06.2015 um 06:37 schrieb Stefan Wahren:
> Triggering suspend to RAM via sysfs on a i.MX28 causes a NULL pointer
> dereference. This patch avoids the oops in mxs_phy_get_vbus_status()
> by aborting since there is no syscon available.
>
> Signed-off-by: Stefan Wahren
> Fixes: efdbd3a5d6e ("usb
On Fri, Jun 26, 2015 at 07:15:18PM +0200, Sébastien Pruvost wrote:
> Hello,
>
> I'm sending this mail to report a bug concerning the latest kernel 4.1.
>
> Here is the problem (and the test I've done):
>
> I have firstly used the 3.10.53 kernel for my two sabrelites
> in
> order
On Fri, Jun 26, 2015 at 03:47:04PM +0200, Mike Looijmans wrote:
> The datasheet for the USB343x PHY mentions a 50ms wait time before
> reading back the ID bit after enabling the internal pull-up or a
> reset:
> "To monitor the status of the ID pin, the Link activates the IdPullup
> bit in the OTG C
On Fri, Jun 26, 2015 at 03:47:03PM +0200, Mike Looijmans wrote:
> The datasheet for the 334x PHY mentions that a reset can be performed:
> "... by bringing the pin low for a minimum of 1 microsecond and
> then high."
> A delay of 5ms to implement that seems overly long, so reduce it to
> just 1us.
On Tue, Jun 30, 2015 at 6:50 AM, Peter Chen wrote:
>
>> On Tue, Jun 30, 2015 at 12:33 AM, Steve Calfee
>> wrote:
>> > On Mon, Jun 29, 2015 at 7:16 AM, Alan Stern
>> wrote:
>> >> On Mon, 29 Jun 2015, Peter Chen wrote:
>> >>
>> >>> Just like Steve pointed, it should be a ZLT problem, do you have
>
Hey Mathias,
The intention is to send an extra endpoint packet of length zero as my
wireless card needs this to function properly. I have skimmed through
the xhci spec and assumed that each td would generate a packet. That
is why I do not chain the last trb or add a interrupt flag, since I
don't w
> On Tue, Jun 30, 2015 at 12:33 AM, Steve Calfee
> wrote:
> > On Mon, Jun 29, 2015 at 7:16 AM, Alan Stern
> wrote:
> >> On Mon, 29 Jun 2015, Peter Chen wrote:
> >>
> >>> Just like Steve pointed, it should be a ZLT problem, do you have
> >>> below patch in your tree, and the host may not send zl
Hi,
On Mon, Jun 29, 2015 at 08:18:48PM -0500, Felipe Balbi wrote:
> It's just a lot clearer to use | operator instead of
> + operator.
>
> Caught by coccicheck:
>
> "
> drivers/usb/dwc2/gadget.c:2883:26-27: WARNING: sum of probable
> bitmasks, consider |
> "
>
> Cc: John
It's just a lot clearer to use | operator instead of
+ operator.
Caught by coccicheck:
"
drivers/usb/dwc2/gadget.c:2883:26-27: WARNING: sum of probable
bitmasks, consider |
"
Cc: John Youn
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file
Hi,
On Mon, Jun 29, 2015 at 11:56:10PM +, John Youn wrote:
> On 6/29/2015 2:04 AM, Mian Yousaf Kaukab wrote:
> > This series fixes 3 sources of sleep while atomic bugs. Including
> > the one reported by Heiko Stuebner here:
> > http://www.spinics.net/lists/linux-usb/msg125186.html
> >
> > Ple
>
> On Mon, Jun 29, 2015 at 7:16 AM, Alan Stern
> wrote:
> > On Mon, 29 Jun 2015, Peter Chen wrote:
> >
> >> Just like Steve pointed, it should be a ZLT problem, do you have
> >> below patch in your tree, and the host may not send zlt, but you may
> >> queue an zero-length request, the f_hid do
On 6/29/2015 2:48 PM, Felipe Balbi wrote:
> Hi again,
>
> On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote:
>> On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote:
>>> We need to return error to caller if command is not sent to
>>> controller succesfully.
>>>
>>> S
On 6/29/2015 2:04 AM, Mian Yousaf Kaukab wrote:
> This series fixes 3 sources of sleep while atomic bugs. Including
> the one reported by Heiko Stuebner here:
> http://www.spinics.net/lists/linux-usb/msg125186.html
>
> Please review.
>
> Thank you,
>
> Best regards,
> Yousaf
>
> History:
> v2:
On Mon, Jun 29, 2015 at 11:23:47PM +0200, Stefan Koch wrote:
> Am Donnerstag, den 18.06.2015, 13:30 -0400 schrieb Alan Stern:
> > On Thu, 18 Jun 2015, Stefan Koch wrote:
> >
> > > This patch introduces an interface authorization for USB devices.
> > > The kernel supports a device authorization bec
Hi again,
On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote:
> On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote:
> > We need to return error to caller if command is not sent to
> > controller succesfully.
> >
> > Signed-off-by: Subbaraya Sundeep Bhatta
> > Fixe
Hi,
On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote:
> We need to return error to caller if command is not sent to
> controller succesfully.
>
> Signed-off-by: Subbaraya Sundeep Bhatta
> Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
> Cc:
> ---
> v2 ch
Am Donnerstag, den 18.06.2015, 13:30 -0400 schrieb Alan Stern:
> On Thu, 18 Jun 2015, Stefan Koch wrote:
>
> > This patch introduces an interface authorization for USB devices.
> > The kernel supports a device authorization because of wireless USB.
> >
> > But the new interface authorization allo
Am Montag, 29. Juni 2015, 11:05:27 schrieb Mian Yousaf Kaukab:
> This series fixes 3 sources of sleep while atomic bugs. Including
> the one reported by Heiko Stuebner here:
> http://www.spinics.net/lists/linux-usb/msg125186.html
>
> Please review.
the current state of mainline during the merge w
On Tue, Jun 30, 2015 at 12:33 AM, Steve Calfee wrote:
> On Mon, Jun 29, 2015 at 7:16 AM, Alan Stern wrote:
>> On Mon, 29 Jun 2015, Peter Chen wrote:
>>
>>> Just like Steve pointed, it should be a ZLT problem, do you have
>>> below patch in your tree, and the host may not send zlt, but you
>>> may
On Sun, Jun 28, 2015 at 12:41 AM, Jayan John wrote:
> If this is a bug in the chipidea UDC driver or hardware, how can I
> address this i.e. register an errata? I am hoping this is something
> Peter might be able to help with.
What is the kernel version you are using? Could you test it with kern
On Mon, Jun 29, 2015 at 7:16 AM, Alan Stern wrote:
> On Mon, 29 Jun 2015, Peter Chen wrote:
>
>> Just like Steve pointed, it should be a ZLT problem, do you have
>> below patch in your tree, and the host may not send zlt, but you
>> may queue an zero-length request, the f_hid does not set req->zer
Hi
On 29.06.2015 03:53, Reyad Attiyat wrote:
> This commmit checks for the URB_ZERO_PACKET flag and creates an extra
> zero-length td if the urb transfer length is a multiple of the endpoint's
> max packet length.
>
> Signed-off-by: Reyad Attiyat
> ---
Thanks for the patch.
Generic idea and imp
On Mon, 29 Jun 2015, Peter Chen wrote:
> Hi Alan,
>
> I am not sure if you have noticed the patch[1], it is the solution for
> this issue, in the RTL, the default reserved time for one packet is
> 1023 bytes for siTD, so after 4 * 64 packets has transfered, the
> reserved time is not enough for 1
On Mon, 29 Jun 2015, Peter Chen wrote:
> Just like Steve pointed, it should be a ZLT problem, do you have
> below patch in your tree, and the host may not send zlt, but you
> may queue an zero-length request, the f_hid does not set req->zero
> flag either.
>
> commit 953c66469735aed8d2ada639a72b1
[ Please keep me in CC as I'm not subscribed ]
Hello,
I'm the happy owner of a Intel NUC D54250WYKH (updated it to latest Intel
firmware) which has an XHCI host controller. It's connected over USB 3 to
a JBOD-configured disk enclosure (ICYBOX IB-RD3640SU3E2) which uses a
JMicron USB to ATA bridge
On Mon, 29 Jun 2015, Oliver Neukum wrote:
> > This is a HW property and nothing kernel can do about. I am not saying it
> > doesn't bring the LEDs up to a proper state again once auto-resumed. But I
> > hate the LEDs going off a few seconds after I stop typing (i.e. once the
> > keyboard gets a
On Mon, 2015-06-29 at 13:16 +0200, Jiri Kosina wrote:
> On Mon, 29 Jun 2015, Oliver Neukum wrote:
>
> > > Last time we were testing this, autosuspend for USB HID devices was quite
> > > a disaster.
> > >
> > > Do you have any idea whether udev developers tested the "autosuspend on
> > > by
> >
On Mon, 29 Jun 2015, Oliver Neukum wrote:
> > Last time we were testing this, autosuspend for USB HID devices was quite
> > a disaster.
> >
> > Do you have any idea whether udev developers tested the "autosuspend on by
> > default for USB HID devices" on reasonable set of devices?
> >
> > The
On Sat, 2015-06-27 at 08:29 +0200, Jiri Kosina wrote:
> On Fri, 26 Jun 2015, Greg Kroah-Hartman wrote:
> Last time we were testing this, autosuspend for USB HID devices was quite
> a disaster.
>
> Do you have any idea whether udev developers tested the "autosuspend on by
> default for USB HID d
From: Oliver Neukum
During open() it is unnecessary to wait for the device to flush
stale inputs if the device is polled while closed due to a quirk
or opening fails.
Signed-off-by: Oliver Neukum
---
drivers/hid/usbhid/hid-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
Register backup function can be called from atomic context. Instead
of using atomic memory pool, embed backup storage space in
struct dwc2_hsotg.
Also add a valid flag in each struct as NULL pointer can't be used as
the content validity check any more.
Acked-by: John Youn
Tested-by: Heiko Stuebn
To avoid sleep while atomic bugs, allocate qtd before calling
dwc2_hcd_urb_enqueue. No need to pass mem_flags to
dwc2_hcd_urb_enqueue any more as no memory allocations are done in it.
Acked-by: John Youn
Tested-by: Heiko Stuebner
Tested-by: Doug Anderson
Signed-off-by: Mian Yousaf Kaukab
---
To avoid sleep while atomic bugs, allocate qh before calling
dwc2_hcd_urb_enqueue. qh pointer can be used directly now instead of
passing ep->hcpriv as double pointer.
Acked-by: John Youn
Tested-by: Heiko Stuebner
Tested-by: Doug Anderson
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2
This series fixes 3 sources of sleep while atomic bugs. Including
the one reported by Heiko Stuebner here:
http://www.spinics.net/lists/linux-usb/msg125186.html
Please review.
Thank you,
Best regards,
Yousaf
History:
v2:
- Fixed John's comment
v1:
- Added John's Acked-by
Mian Yousaf Kaukab (
On Tue, Mar 31, 2015 at 10:02:52AM -0400, Alan Stern wrote:
> On Tue, 31 Mar 2015, Peter Chen wrote:
>
> > I reproduced this issue, I can't see the fifth endpoints during the SoFs
> > although the time to SoF boundary is about 800us, see attached.
> >
> > - At transaction 3749, the third UAC2 gad
On Sun, Jun 28, 2015 at 09:11:30AM +0530, Jayan John wrote:
> On Sun, Jun 28, 2015 at 5:34 AM, Alan Stern wrote:
> > On Sat, 27 Jun 2015, Jayan John wrote:
> >
> >> Thanks.
> >>
> >> Yes, the wLength value in the Setup packet is equal to 64. "Aligned"
> >> was the wrong term, multiple of 64 would
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/audio.c | 34 +++---
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/zero.c | 32 ++--
1 f
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/printer.c | 26 +++---
1 file
Check property of usb hardware to update otg version and disable SRP, HNP
and ADP if its disable flag is present.
Signed-off-by: Li Jun
---
drivers/usb/common/common.c | 47 +
include/linux/usb/of.h | 7 +++
2 files changed, 54 insertions(+)
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations, free it while
ether unbind. If otg capability is not defined, keep its otg
descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/ether.c | 36 +
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/multi.c | 37
This patch adds a structure usb_otg_caps to cover all otg related
capabilities of the device, including otg revision, and if hnp/srp/adp
is supported.
Signed-off-by: Li Jun
Reviewed-by: Roger Quadros
---
include/linux/usb/otg.h | 15 +++
1 file changed, 15 insertions(+)
diff --git
Allocate usb otg descriptor and initialize it according to gadget's otg
capabilities, if usb_otg_caps is not set, keep settings as current gadget
drivers. With this 2 new interfaces, gadget can use usb_otg_descriptor
for OTG 1.x, and usb_otg20_descriptor for OTG 2.0 or above, and otg
features can b
From: Macpaul Lin
Copy usb_otg_descriptor from config's descriptor if host requests
USB_DT_OTG.
Signed-off-by: Macpaul Lin
Signed-off-by: Li Jun
Reviewed-by: Roger Quadros
---
drivers/usb/gadget/composite.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/driv
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/hid.c | 36
After introduce usb otg properties, update ci_otg_is_fsm_mode conditions
to be depending on both usb hardware properties and usb driver config,
also resolve a compile issue in debug.c after the API change.
Signed-off-by: Li Jun
---
drivers/usb/chipidea/ci.h| 5 -
drivers/usb/chipidea/deb
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/g_ffs.c | 32 +---
1
Init and update otg capabilities by DT, set gadget's otg capabilities
accordingly.
Signed-off-by: Li Jun
---
drivers/usb/chipidea/core.c | 10 ++
drivers/usb/chipidea/udc.c | 7 ++-
include/linux/usb/chipidea.h | 1 +
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/mass_storage.c | 35 +
From: Macpaul Lin
Add USB_OTG_ADP definition for usb_otg_descriptor.bmAttributes.
Signed-off-by: Macpaul Lin
Signed-off-by: Li Jun
Acked-by: Peter Chen
---
include/uapi/linux/usb/ch9.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/usb/ch9.h b/include/uapi/linux/usb/c
Add otg version, srp, hnp and adp support for usb OTG port, then those OTG
features don't have to be decided by usb gadget drivers.
Signed-off-by: Li Jun
Reviewed-by: Roger Quadros
---
Documentation/devicetree/bindings/usb/generic.txt | 15 +++
1 file changed, 15 insertions(+)
diff
From: Macpaul Lin
Add usb_otg_caps pointer to usb_gadget structure to indicate its
otg capabilities.
Signed-off-by: Macpaul Lin
Signed-off-by: Li Jun
Reviewed-by: Roger Quadros
---
include/linux/usb/gadget.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/usb/gadget.h b/i
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/ncm.c | 34 +++---
1
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/cdc2.c | 35 +++
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/acm_ms.c | 35 +++
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations. If otg capability
is not defined, keep its original otg descriptor unchanged.
Signed-off-by: Li Jun
---
drivers/usb/gadget/legacy/serial.c | 29 +++--
1 fi
Allocate and initialize usb otg descriptor according to gadget otg
capabilities, add it for each usb configurations, free it while
composite unbind. If otg capability is not defined, keep its otg
descriptor unchanged.
Signed-off-by: Li Jun
Reviewed-by: Roger Quadros
---
drivers/usb/gadget/confi
From: Macpaul Lin
OTG 2.0 introduces bcdOTG in otg descriptor to identify the OTG and EH
supplement release number with which the OTG device is compliant, this
patch adds structure usb_otg20_descriptor for OTG 2.0 and above.
Signed-off-by: Macpaul Lin
Signed-off-by: Li Jun
Reviewed-by: Roger Q
Change for v6:
- Change of_usb_set_otg_caps to be of_usb_update_otg_caps, and add
sanity check of otg-rev.
- Add chipidea otg-rev ability to be 0x0200, which will be updated
in DT, if not passed, will be reset to be 0.
- Remove unnecessary change: move config's descriptor and bmAttributes
ini
64 matches
Mail list logo
