Re: [cdc_ncm] guidance and help refactoring cdc_ncm

2015-05-31 Thread Enrico Mioso
Hello Greg, hello everyone reading. I am sorry If I wasn't specific enough - I'll be this time! :) Or I try at least. On Mon, 1 Jun 2015, Greg KH wrote: ==Date: Mon, 1 Jun 2015 02:59:17 ==From: Greg KH ==To: Enrico Mioso ==Cc: linux-usb@vger.kernel.org, net...@vger.kernel.org, ==Oliver Neu

RE: [PATCH 3/5] drivers:usb:fsl: Replace macros with enumerated type

2015-05-31 Thread Badola Nikhil
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, June 01, 2015 2:32 AM > To: Joe Perches > Cc: Badola Nikhil-B46172; linux-ker...@vger.kernel.org; > st...@rowland.harvard.edu; linux-usb@vger.kernel.org > Subject: Re: [PATCH 3/5] drivers:usb:fsl: Repla

Re: [PATCH v5 2/3] usb: xhci: implement device_suspend/device_resume entries

2015-05-31 Thread Greg Kroah-Hartman
On Sat, May 09, 2015 at 09:15:29AM +0800, Lu Baolu wrote: > This patch implements device_suspend/device_resume entries for xHC driver. > device_suspend will be called when a USB device is about to suspend. It > will issue a stop endpoint command for each endpoint in this device. The > Suspend(SP) b

[PATCH] USB: serial: Use setup_timer

2015-05-31 Thread Vaishali Thakkar
Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@ expression e1, e2, e3, e4, a, b; @@ -init_timer(&e1); +setup_timer(&e1, a, b); ...

Re: [cdc_ncm] guidance and help refactoring cdc_ncm

2015-05-31 Thread Greg KH
On Sun, May 31, 2015 at 04:37:11PM +0200, Enrico Mioso wrote: > Hello guys. > I am writing to you all to ask for help and assistance in refactoring the > cdc_ncm driver to support newer devices. > In particular - I would need step-by-step guidance in doing this: or any > other kind of help would be

[PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

2015-05-31 Thread Colin King
From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer dereference on req. Check for null to avoid this. Detected with smatch static analysis: drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request() error: potential null dereference 'req'.

Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

2015-05-31 Thread Colin Ian King
On 31/05/15 23:15, Sergei Shtylyov wrote: > Hello. > > On 06/01/2015 01:00 AM, Colin King wrote: > >> From: Colin Ian King > >> If kzalloc returns null then isp1760_ep_alloc_request performs >> a null pointer deference on req. > >Dereference, not "deference". Shall I send v2 for this stup

Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

2015-05-31 Thread Sergei Shtylyov
Hello. On 06/01/2015 01:00 AM, Colin King wrote: From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer deference on req. Dereference, not "deference". No, it doesn't. It calculates the address of the 'isp1760_request::req' instead, there

[PATCH] usb: isp1760: fix null dereference if kzalloc returns null

2015-05-31 Thread Colin King
From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer deference on req. Check for null to avoid this. Detected with smatch static analysis: drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request() error: potential null dereference 'req'. (

Re: [PATCH 3/5] drivers:usb:fsl: Replace macros with enumerated type

2015-05-31 Thread Greg KH
On Sun, May 31, 2015 at 12:11:18AM -0700, Joe Perches wrote: > On Sun, 2015-05-31 at 15:50 +0900, Greg KH wrote: > > On Tue, May 26, 2015 at 05:15:48PM +0530, Nikhil Badola wrote: > > > Replace macros with enumerated type to represent usb ip > > > controller version > > > > > > Signed-off-by: Nikh

[PATCH TRIVIAL] drivers/usb/gadget/composite.c: i18n is not an acronym

2015-05-31 Thread Diego Viola
Signed-off-by: Diego Viola --- drivers/usb/gadget/composite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 4e3447b..79a3ae0 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composi

Fwd: Add capacity to disable usb port at boot parameter

2015-05-31 Thread Quentin Deldycke
Hi, On a asrock Z97 Extreme 6 motherboard, the system provides: - 6 usb3 port in backplate - 1 usb (2-3? i don't know) port on the board near power switch - 2 usb sockets (to be used with brackets) on the board near power switch - in my case, they are both used with usb2-double port brackets

[PATCH 1/1] usb: Remove Vernier devices from lsusb and hid_ignore_list

2015-05-31 Thread Dennis O'Brien
From: Dennis O'Brien Removes Vernier Software & Technology devices from the ldusb driver and the hid_ignore_list table of the usbhid driver in the Linux tree. These devices will now be supported via the hidraw driver. A user space driver for these devices will be found in the Go! Software Deve

[PATCH v4 2/2] musb: Add support for the Allwinner sunxi musb controller

2015-05-31 Thread Hans de Goede
This is based on initial code to get the Allwinner sunxi musb controller supported by Chen-Yu Tsai and Roman Byshko. This adds support for the Allwinner sunxi musb controller in both host only and otg mode. Peripheral only mode is not supported, as no boards use that. This has been tested on a cu

[PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-05-31 Thread Hans de Goede
The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over the pullups, enable these on phy_init and disable them on phy_exit. 2) It has bits to signal id and vbus detect to the musb-core, add support for for monitoring id and vbus

[PATCH v4 0/2] Remaining sunxi musb patches

2015-05-31 Thread Hans de Goede
Hi Kishon & Felipe, Here is an updated version of the remaining (not yet merged in Felipe's tree) sunxi musb patches. The "phy-sun4i-usb: Add full support for usb0 phy / OTG" patch has been updated with a small bug-fix and is ready for merging. The "musb: Add support for the Allwinner sunxi musb

[cdc_ncm] guidance and help refactoring cdc_ncm

2015-05-31 Thread Enrico Mioso
Hello guys. I am writing to you all to ask for help and assistance in refactoring the cdc_ncm driver to support newer devices. In particular - I would need step-by-step guidance in doing this: or any other kind of help would be anyway greatly apreciated. 1 - What we need: We would need to re

Re: [PATCH 3/5] drivers:usb:fsl: Replace macros with enumerated type

2015-05-31 Thread Joe Perches
On Sun, 2015-05-31 at 15:50 +0900, Greg KH wrote: > On Tue, May 26, 2015 at 05:15:48PM +0530, Nikhil Badola wrote: > > Replace macros with enumerated type to represent usb ip > > controller version > > > > Signed-off-by: Nikhil Badola > > --- > > include/linux/fsl_devices.h | 13 - >

Re: [PATCH 3/5] drivers:usb:fsl: Replace macros with enumerated type

2015-05-31 Thread Greg KH
On Tue, May 26, 2015 at 05:15:48PM +0530, Nikhil Badola wrote: > Replace macros with enumerated type to represent usb ip > controller version > > Signed-off-by: Nikhil Badola > --- > include/linux/fsl_devices.h | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git