Re: [RFC][PATCH 1/9] usb: hcd: Introduce usb_start/stop_hcd()

2015-03-19 Thread Peter Chen
On Thu, Mar 19, 2015 at 01:38:32PM +0200, Roger Quadros wrote: > On 18/03/15 21:49, Alan Stern wrote: > > On Wed, 18 Mar 2015, Roger Quadros wrote: > > > >> To support OTG we want a mechanism to start and stop > >> the HCD from the OTG state machine. Add usb_start_hcd() > >> and usb_stop_hcd(). >

[PATCH] usb: Add driver for Altus Metrum ChaosKey device (v2)

2015-03-19 Thread Keith Packard
This is a hardware random number generator. The driver provides both a /dev/chaoskeyX entry and hooks the entropy source up to the kernel hwrng interface. More information about the device can be found at http://chaoskey.org The USB ID for ChaosKey was allocated from the OpenMoko USB vendor space

[PATCH 1/2] USB: Use usb_disabled() consistently

2015-03-19 Thread Viresh Kumar
At few places we have used usb_disabled() and at other places used 'nousb' directly. Lets be consistent and use usb_disabled(); Signed-off-by: Viresh Kumar --- drivers/usb/core/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/usb.c b/drivers/usb/core

[PATCH 2/2] USB: Move usb_disabled() towards top of the file

2015-03-19 Thread Viresh Kumar
Move usb_disabled() and module_param()/core_param() towards the top of the file, where 'nousb' is defined, as they are all related. Signed-off-by: Viresh Kumar --- drivers/usb/core/usb.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/driver

Re: [PATCH] usb: Add driver for Altus Metrum ChaosKey device

2015-03-19 Thread Keith Packard
Oliver Neukum writes: > Please see the comments in the quoted code. Thanks so much for your review; it's my first USB driver, so I was pretty sure I'd make plenty of mistakes. > Do we really need yet another version of home grown debug macros? No, and now that the driver is working, it's just

Re: [PATCH v4 0/8] add HNP polling support for usb otg fsm

2015-03-19 Thread Peter Chen
On Thu, Mar 19, 2015 at 11:11:17AM +0800, Li Jun wrote: > HNP polling is a mechanism which allows the OTG device currently acting as > host > to determine when the other attached OTG device wishes to take the host role. > When an OTG host, which supports HNP, is connected to an OTG peripheral whic

Re: [PATCH 05/12] usb: chipidea: introduce ci_platform_config

2015-03-19 Thread Peter Chen
On Thu, Mar 19, 2015 at 11:19:29AM +0100, Michael Grzeschik wrote: > On Thu, Mar 19, 2015 at 09:19:16AM +0800, Peter Chen wrote: > > It is used to configure controller parameters according to > > platform data, like speed, interrupt threshold, stream mode, etc. > > > > Signed-off-by: Peter Chen >

Re: [PATCH 00/12] USB: chipidea: patchset for performance improvement

2015-03-19 Thread Peter Chen
On Thu, Mar 19, 2015 at 11:36:29AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 09:19 Thu 19 Mar , Peter Chen wrote: > > Hi all, > > > > In this patch set, I add some interfaces for tuning the performance > > of chipidea usb driver. With this set, the USB performance can be improved >

[PATCH v2] usb: musb: Fix fifo reads for dm816x with musb_dsps

2015-03-19 Thread Tony Lindgren
Looks like dm81xx can only do 32-bit fifo reads like am35x. Let's set up musb-dsps with a custom read_fifo function based on the compatible flag. Otherwise we can get the following errors when starting dhclient on a asix USB Ethernet adapter: asix 2-1:1.0 eth2: asix_rx_fixup() Bad Header Length 0

[PATCH v3] phy: Add a driver for dm816x USB PHY

2015-03-19 Thread Tony Lindgren
Add a minimal driver for dm816x USB. This makes USB work on dm816x without any other changes needed as it can use the existing musb_dsps glue layer for the USB controller. Note that this phy is different from dm814x and am335x. Cc: Bin Liu Cc: Brian Hutchinson Cc: Felipe Balbi Cc: Matthijs van

Re: [PATCH v1 00/20] usb: third series of updates for dwc2 driver

2015-03-19 Thread John Youn
On 3/19/2015 8:53 AM, Kaukab, Yousaf wrote: > > >> -Original Message- >> From: John Youn [mailto:john.y...@synopsys.com] >> Sent: Wednesday, March 18, 2015 8:14 PM >> To: Kaukab, Yousaf; John Youn; linux-usb@vger.kernel.org; ba...@ti.com >> Cc: Herrero, Gregory; r.bald...@samsung.com; >>

Re: [PATCH v1 07/20] usb: dwc2: set parameter values in probe function

2015-03-19 Thread John Youn
On 3/17/2015 2:54 AM, Mian Yousaf Kaukab wrote: > So the parameters can be used in both host and gadget modes. > Also consolidate param functions in the core.h > > Signed-off-by: Mian Yousaf Kaukab > --- > drivers/usb/dwc2/core.c | 19 +++ > drivers/usb/dwc2/core.h | 13 +

Re: [PATCH v2] usb: ehci-orion: add more constants for register values

2015-03-19 Thread Thomas Petazzoni
Alan, On Thu, 19 Mar 2015 16:30:09 -0400 (EDT), Alan Stern wrote: > On Thu, 19 Mar 2015, Thomas Petazzoni wrote: > > > These are indeed all valid concerns. However, as you can see, those > > concerns are completely orthogonal to the patch: the original code > > already has those issues. > > Quit

Re: Occasionally a USB mouse and keyboard connected to a USB hub stop working. Helps recover only reconnect USB hub.

2015-03-19 Thread Alan Stern
On Thu, 19 Mar 2015, Михаил Гаврилов wrote: > Occasionally a USB mouse and keyboard connected to a USB hub stop > working. Helps recover only reconnect USB hub. It sounds like something is wrong with the hub. Have you tried replacing it? Alan Stern -- To unsubscribe from this list: send the l

Re: [RFC 01/19] extcon: add extcon-odroid-usbotg driver

2015-03-19 Thread Chanwoo Choi
Hi Roger, On Thu, Mar 19, 2015 at 11:45 PM, Roger Quadros wrote: > On 19/03/15 14:19, George Cherian wrote: >> Hi Robert, >> >> +Roger >> On Thu, Mar 19, 2015 at 5:37 PM, Robert Baldyga >> wrote: >>> Hi George, >>> >>> On 03/19/2015 09:50 AM, George Cherian wrote: Hi Robert, This

Re: [PATCH v2] usb: ehci-orion: add more constants for register values

2015-03-19 Thread Alan Stern
On Thu, 19 Mar 2015, Thomas Petazzoni wrote: > These are indeed all valid concerns. However, as you can see, those > concerns are completely orthogonal to the patch: the original code > already has those issues. Quite true. You may add Acked-by: Alan Stern to the v2 patch. > Regarding the ad

Re: [PATCH 10/13] usb: gadget: atmel_usba: use endian agnostic IO on ARM

2015-03-19 Thread Felipe Balbi
On Thu, Mar 19, 2015 at 05:46:47PM +0100, Nicolas Ferre wrote: > Le 18/03/2015 16:53, Ben Dooks a écrit : > > Change from using the __raw IO accesors to the endian agnostic versions > > of readl/writel_relaxed when not on AVR32. This fixes issues with running > > big endian on ARMv7. > > > > Signe

Re: [PATCH] usb: musb: Fix fifo reads for dm816x with musb_dsps

2015-03-19 Thread Sergei Shtylyov
On 03/19/2015 08:55 PM, Tony Lindgren wrote: --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -655,6 +655,36 @@ static int dsps_musb_reset(struct musb *musb) return !session_restart; } +/* Similar to am35x, dm81xx support only 32-bit read operation */ +static voi

Re: [PATCH] usb: musb: Fix fifo reads for dm816x with musb_dsps

2015-03-19 Thread Tony Lindgren
* Sergei Shtylyov [150319 10:50]: > On 03/19/2015 04:30 PM, Sergei Shtylyov wrote: > >>--- a/drivers/usb/musb/musb_dsps.c > >>+++ b/drivers/usb/musb/musb_dsps.c > >>@@ -655,6 +655,36 @@ static int dsps_musb_reset(struct musb *musb) > >> return !session_restart; > >> } > >> > >>+/* Similar to

Re: [PATCH] usb: musb: Fix fifo reads for dm816x with musb_dsps

2015-03-19 Thread Sergei Shtylyov
On 03/19/2015 04:30 PM, Sergei Shtylyov wrote: Looks like dm81xx can only do 32-bit fifo reads like am35x. Let's set up musb-dsps with a custom read_fifo function based on the compatible flag. Otherwise we can get the following errors when starting dhclient on a asix USB Ethernet adapter:

Re: linux-next: Tree for Mar 19 (usb/dwc2)

2015-03-19 Thread Randy Dunlap
On 03/19/15 00:28, Stephen Rothwell wrote: > Hi all, > > Changes since 20150318: > on i386: drivers/built-in.o: In function `dwc2_pci_remove': pci.c:(.text+0x37ecf1): undefined reference to `usb_phy_generic_unregister' drivers/built-in.o: In function `dwc2_pci_probe': pci.c:(.text+0x37ee8d): un

Re: [PATCH] USB: keyspan_pda: add new device id

2015-03-19 Thread Johan Hovold
On Mon, Mar 16, 2015 at 11:19:55AM -0400, Nathaniel W Filardo wrote: > Add USB VID/PID for Xircom PGMFHUB USB/serial component. (The hub and SCSI > bridge on that hardware are recognized out of the box by existing drivers.) > Tested VID/PID using new_id and loopback connection and was met with > s

Re: [PATCH 10/13] usb: gadget: atmel_usba: use endian agnostic IO on ARM

2015-03-19 Thread Nicolas Ferre
Le 18/03/2015 16:53, Ben Dooks a écrit : > Change from using the __raw IO accesors to the endian agnostic versions > of readl/writel_relaxed when not on AVR32. This fixes issues with running > big endian on ARMv7. > > Signed-off-by: Ben Dooks > -- > CC: Nicolas Ferre Felipe, for the record: Ack

Re: [PATCH v2 00/14] usb: generic resume timeout

2015-03-19 Thread Felipe Balbi
On Mon, Feb 23, 2015 at 12:39:40PM -0600, Felipe Balbi wrote: > Hi all, > > here's v2 of usb generic timeout patchset. Rebased on > v4.0-rc1 and tested on AM437x SK, and BBB. > > skipped boards: > > . AM57x x15 has pending patches to enable USB > . AM437x IDK doesn't pin out USB > . DM3730 Overo

Re: [PATCH 1/3] usb: gadget: rndis: use rndis_params instead of configNr

2015-03-19 Thread Felipe Balbi
On Fri, Feb 06, 2015 at 01:43:28PM +0100, Andrzej Pietrasiewicz wrote: > RNDIS function has a limitation on the number of allowed instances. > So far it has been RNDIS_MAX_CONFIGS, which happens to be one. > In order to eliminate this kind of arbitrary limitation we should not > preallocate a prede

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-19 Thread Tony Lindgren
* Matthijs van Duin [150319 04:20]: > On 17 March 2015 at 03:19, Tony Lindgren wrote: > > Yes so it seem here too, this is dm816x rev c, what do you have? > > jtag ID reads 0x1b81e02f, so that would be rev 1.1 / rev A. > > > Anyways, I'll add a note that at least rev c does not seems to do > >

RE: [PATCH v1 00/20] usb: third series of updates for dwc2 driver

2015-03-19 Thread Kaukab, Yousaf
> -Original Message- > From: John Youn [mailto:john.y...@synopsys.com] > Sent: Wednesday, March 18, 2015 8:14 PM > To: Kaukab, Yousaf; John Youn; linux-usb@vger.kernel.org; ba...@ti.com > Cc: Herrero, Gregory; r.bald...@samsung.com; > dingu...@opensource.altera.com; zhangfei@linaro.or

Re: [PATCH] usb: musb: Fix fifo reads for dm816x with musb_dsps

2015-03-19 Thread Tony Lindgren
* Sergei Shtylyov [150319 06:30]: > On 3/19/2015 1:48 AM, Tony Lindgren wrote: > > >Looks like dm81xx can only do 32-bit fifo reads like am35x. Let's set > >up musb-dsps with a custom read_fifo function based on the compatible > >flag. ... > >--- a/drivers/usb/musb/musb_dsps.c > >+++ b/drivers/us

RE: [PATCH] Documentation: ABI: Fix documentation for mass_storage function

2015-03-19 Thread Krzysztof Opasiak
Dear all, Please ignore this patch for now. There seems to be a bigger bug in configfs interface for mass storage function which end up in NULL pointer dereference[1]. How to reproduce: $ cd /sys/kernel/config $ mkdir g1 $ cd g1 $ mkdir configs/c.1 $ mkdir functions/mass_storage.1 $ mkdir functio

Re: [RFC][PATCH 3/9] usb: otg: add OTG core

2015-03-19 Thread Roger Quadros
On 19/03/15 16:41, Li Jun wrote: > On Thu, Mar 19, 2015 at 12:30:46PM +0200, Roger Quadros wrote: >> On 19/03/15 10:26, Li Jun wrote: >>> On Wed, Mar 18, 2015 at 03:55:57PM +0200, Roger Quadros wrote: The OTG core instantiates the OTG Finite State Machine per OTG controller and manages st

Re: [RFC][PATCH 2/9] usb: gadget: add usb_gadget_start/stop()

2015-03-19 Thread Roger Quadros
On 19/03/15 16:09, Li Jun wrote: > On Thu, Mar 19, 2015 at 12:14:39PM +0200, Roger Quadros wrote: >> On 19/03/15 05:30, Peter Chen wrote: >>> On Wed, Mar 18, 2015 at 03:55:56PM +0200, Roger Quadros wrote: The OTG state machine needs a mechanism to start and stop the gadget controller. Add

Re: [RFC][PATCH 3/9] usb: otg: add OTG core

2015-03-19 Thread Li Jun
On Thu, Mar 19, 2015 at 12:30:46PM +0200, Roger Quadros wrote: > On 19/03/15 10:26, Li Jun wrote: > > On Wed, Mar 18, 2015 at 03:55:57PM +0200, Roger Quadros wrote: > >> The OTG core instantiates the OTG Finite State Machine > >> per OTG controller and manages starting/stopping the > >> host and ga

Re: [RFC 01/19] extcon: add extcon-odroid-usbotg driver

2015-03-19 Thread Roger Quadros
On 19/03/15 14:19, George Cherian wrote: > Hi Robert, > > +Roger > On Thu, Mar 19, 2015 at 5:37 PM, Robert Baldyga wrote: >> Hi George, >> >> On 03/19/2015 09:50 AM, George Cherian wrote: >>> Hi Robert, >>> >>> This looks like a extcon driver based on gpio for USB. >>> >>> Roger posted a generic

Re: [PATCH v2] usb: ehci-orion: add more constants for register values

2015-03-19 Thread Thomas Petazzoni
Dear Alan Stern, On Thu, 19 Mar 2015 10:27:18 -0400 (EDT), Alan Stern wrote: > > @@ -69,8 +75,8 @@ static void orion_usb_phy_v1_setup(struct usb_hcd *hcd) > > /* > > * Reset controller > > */ > > - wrl(USB_CMD, rdl(USB_CMD) | 0x2); > > - while (rdl(USB_CMD) & 0x2); > > + wrl(U

Re: [PATCH v2] usb: ehci-orion: add more constants for register values

2015-03-19 Thread Alan Stern
On Thu, 19 Mar 2015, Thomas Petazzoni wrote: > This commit adds new register values for the USB_CMD and USB_MODE > registers, which allows to avoid the usage of a number of magic values > in orion_usb_phy_v1_setup(). > > Signed-off-by: Thomas Petazzoni The new symbol values are fine. But (side

Re: [RFC][PATCH 1/9] usb: hcd: Introduce usb_start/stop_hcd()

2015-03-19 Thread Alan Stern
On Thu, 19 Mar 2015, Roger Quadros wrote: > > It would be a lot simpler to unbind the host controller driver > > completely when switching to device mode and rebind it when switching > > back. I guess that is the sort of heavy-duty approach you want to > > avoid, but it may be the only practical

Re: [RFC][PATCH 2/9] usb: gadget: add usb_gadget_start/stop()

2015-03-19 Thread Li Jun
On Thu, Mar 19, 2015 at 12:14:39PM +0200, Roger Quadros wrote: > On 19/03/15 05:30, Peter Chen wrote: > > On Wed, Mar 18, 2015 at 03:55:56PM +0200, Roger Quadros wrote: > >> The OTG state machine needs a mechanism to start and > >> stop the gadget controller. Add usb_gadget_start() > >> and usb_gad

[PATCH v2] usb: ehci-orion: add more constants for register values

2015-03-19 Thread Thomas Petazzoni
This commit adds new register values for the USB_CMD and USB_MODE registers, which allows to avoid the usage of a number of magic values in orion_usb_phy_v1_setup(). Signed-off-by: Thomas Petazzoni --- Changes since v1: use tabs instead of spaces for alignment. drivers/usb/host/ehci-orion.c | 18

Re: [PATCH] usb: ehci-orion: add more constants for register values

2015-03-19 Thread Sergei Shtylyov
Hello. On 3/19/2015 1:32 PM, Thomas Petazzoni wrote: This commit adds new register values for the USB_CMD and USB_MODE registers, which allows to avoid the usage of a number of magic values in orion_usb_phy_v1_setup(). Signed-off-by: Thomas Petazzoni --- drivers/usb/host/ehci-orion.c | 18

Re: [PATCH] usb: musb: Fix fifo reads for dm816x with musb_dsps

2015-03-19 Thread Sergei Shtylyov
Hello. On 3/19/2015 1:48 AM, Tony Lindgren wrote: Looks like dm81xx can only do 32-bit fifo reads like am35x. Let's set up musb-dsps with a custom read_fifo function based on the compatible flag. Otherwise we can get the following errors when starting dhclient on a asix USB Ethernet adapter:

Re: [RFC 01/19] extcon: add extcon-odroid-usbotg driver

2015-03-19 Thread George Cherian
Hi Robert, +Roger On Thu, Mar 19, 2015 at 5:37 PM, Robert Baldyga wrote: > Hi George, > > On 03/19/2015 09:50 AM, George Cherian wrote: >> Hi Robert, >> >> This looks like a extcon driver based on gpio for USB. >> >> Roger posted a generic one a while back. >> https://lkml.org/lkml/2015/2/2/187 >

Re: [RFC 01/19] extcon: add extcon-odroid-usbotg driver

2015-03-19 Thread Robert Baldyga
Hi George, On 03/19/2015 09:50 AM, George Cherian wrote: > Hi Robert, > > This looks like a extcon driver based on gpio for USB. > > Roger posted a generic one a while back. > https://lkml.org/lkml/2015/2/2/187 > > Doesn't this serve the purpose rather than adding this driver? Roger's driver d

Re: [PATCH 00/12] USB: chipidea: patchset for performance improvement

2015-03-19 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:19 Thu 19 Mar , Peter Chen wrote: > Hi all, > > In this patch set, I add some interfaces for tuning the performance > of chipidea usb driver. With this set, the USB performance can be improved > at some user cases with suitable parameters. The main changes: > > - Interface to tune inter

Re: [PATCHv2 09/12] usb: dwc3: pci: add quirk for Baytrails

2015-03-19 Thread Heikki Krogerus
> > @@ -65,6 +76,31 @@ static int dwc3_pci_quirks(struct pci_dev *pdev) > > sizeof(pdata)); > > } > > > > + if (pdev->vendor == PCI_VENDOR_ID_INTEL && > > + pdev->device == PCI_DEVICE_ID_INTEL_BYT) { > > + struct gpio_desc *gpio; >

Re: [PATCHv2 10/12] usb: dwc3: add ULPI interface support

2015-03-19 Thread Heikki Krogerus
> > +config USB_DWC3_ULPI > > + bool "Register ULPI PHY Interface" > > + depends on USB_ULPI_BUS=y > > USB_ULPI_BUS is added in 01/12 as a bool symbol. So why not use just > depends on USB_ULPI_BUS True. Originally I was planning to support building the ULPI bus as a module and have nev

Re: [PATCHv2 01/12] usb: add bus type for USB ULPI

2015-03-19 Thread Heikki Krogerus
> > +#include > > So is this include needed? I can change it to linux/kmod.h. We'll still do the request_module call even after these changes. > > +static int __init ulpi_init(void) > > +{ > > + return bus_register(&ulpi_bus); > > +} > > +module_init(ulpi_init); > > This will be equivalent t

Re: [RFC][PATCH 1/9] usb: hcd: Introduce usb_start/stop_hcd()

2015-03-19 Thread Roger Quadros
On 18/03/15 21:49, Alan Stern wrote: > On Wed, 18 Mar 2015, Roger Quadros wrote: > >> To support OTG we want a mechanism to start and stop >> the HCD from the OTG state machine. Add usb_start_hcd() >> and usb_stop_hcd(). >> >> Signed-off-by: Roger Quadros > > There are a few problems in this pro

[PATCH v1 2/2] chipidea: pci: make it depends on NOP_USB_XCEIV

2015-03-19 Thread Andy Shevchenko
After commit ba1aff67f99a (chipidea: pci: register nop PHY) the PCI glue driver requires nop-PHY to be selected. Thus, make it an explicit dependency. Reported-by: kbuild test robot Fixes: ba1aff67f99a (chipidea: pci: register nop PHY) Signed-off-by: Andy Shevchenko --- drivers/usb/chipidea/Kco

[PATCH v1 1/2] chipidea: introduce specific Kconfig options for glue drivers

2015-03-19 Thread Andy Shevchenko
This patch introduces USB_CHIPIDEA_PCI and USB_CHIPIDEA_OF Kconfig options, one per each specific glue driver. This is needed to provide different dependencies they have. Signed-off-by: Andy Shevchenko --- drivers/usb/chipidea/Kconfig | 10 ++ drivers/usb/chipidea/Makefile | 9 ++--

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-19 Thread Matthijs van Duin
On 17 March 2015 at 03:19, Tony Lindgren wrote: > Yes so it seem here too, this is dm816x rev c, what do you have? jtag ID reads 0x1b81e02f, so that would be rev 1.1 / rev A. > Anyways, I'll add a note that at least rev c does not seems to do > anything with USB_CTRL but that we follow what the

Re: [PATCH] usb: Add driver for Altus Metrum ChaosKey device

2015-03-19 Thread Oliver Neukum
On Thu, 2015-03-19 at 03:07 -0700, Keith Packard wrote: Hi, unfortunately there are a few issues with this driver. Please see the comments in the quoted code. Regards Oliver > +#define CK_DEBUG(mask, fmt, args...) do {\ > + if (un

[PATCH] usb: ehci-orion: add more constants for register values

2015-03-19 Thread Thomas Petazzoni
This commit adds new register values for the USB_CMD and USB_MODE registers, which allows to avoid the usage of a number of magic values in orion_usb_phy_v1_setup(). Signed-off-by: Thomas Petazzoni --- drivers/usb/host/ehci-orion.c | 18 -- 1 file changed, 12 insertions(+), 6 del

Re: [RFC][PATCH 0/9] USB: OTG Core functionality

2015-03-19 Thread Roger Quadros
On 18/03/15 19:37, Tony Lindgren wrote: > * Roger Quadros [150318 07:00]: >> Hi, >> >> [NOTE: RFC only. Not for merge yet.] >> >> This is an attempt to centralize OTG functionality in the kernel. >> Still work in progress but I wanted to get an early feedback >> to avoid major rework. :) >> >> Wh

Re: [RFC][PATCH 3/9] usb: otg: add OTG core

2015-03-19 Thread Roger Quadros
On 19/03/15 10:26, Li Jun wrote: > On Wed, Mar 18, 2015 at 03:55:57PM +0200, Roger Quadros wrote: >> The OTG core instantiates the OTG Finite State Machine >> per OTG controller and manages starting/stopping the >> host and gadget controllers based on the bus state. >> >> It provides APIs for the f

Re: [RFC][PATCH 8/9] usb: otg-fsm: Remove unused members in struct otg_fsm

2015-03-19 Thread Roger Quadros
On 19/03/15 05:46, Peter Chen wrote: > On Wed, Mar 18, 2015 at 03:56:02PM +0200, Roger Quadros wrote: >> These members are not used anywhere so remove them. >> >> Signed-off-by: Roger Quadros >> --- >> include/linux/usb/otg-fsm.h | 5 - >> 1 file changed, 5 deletions(-) >> >> diff --git a/inc

Re: [PATCH 05/12] usb: chipidea: introduce ci_platform_config

2015-03-19 Thread Michael Grzeschik
On Thu, Mar 19, 2015 at 09:19:16AM +0800, Peter Chen wrote: > It is used to configure controller parameters according to > platform data, like speed, interrupt threshold, stream mode, etc. > > Signed-off-by: Peter Chen > --- > drivers/usb/chipidea/ci.h | 2 ++ > drivers/usb/chipidea/core.c |

Re: [RFC][PATCH 3/9] usb: otg: add OTG core

2015-03-19 Thread Roger Quadros
On 19/03/15 05:40, Peter Chen wrote: > On Wed, Mar 18, 2015 at 03:55:57PM +0200, Roger Quadros wrote: >> The OTG core instantiates the OTG Finite State Machine >> per OTG controller and manages starting/stopping the >> host and gadget controllers based on the bus state. >> >> It provides APIs for t

[PATCH] usb: Add driver for Altus Metrum ChaosKey device

2015-03-19 Thread Keith Packard
This is a hardware random number generator. The driver provides both a /dev/chaoskeyX entry and hooks the entropy source up to the kernel hwrng interface. More information about the device can be found at http://chaoskey.org The USB ID for ChaosKey was allocated from the OpenMoko USB vendor space

Re: [RFC][PATCH 2/9] usb: gadget: add usb_gadget_start/stop()

2015-03-19 Thread Roger Quadros
On 19/03/15 05:30, Peter Chen wrote: > On Wed, Mar 18, 2015 at 03:55:56PM +0200, Roger Quadros wrote: >> The OTG state machine needs a mechanism to start and >> stop the gadget controller. Add usb_gadget_start() >> and usb_gadget_stop(). >> >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/ga

Re: [RFC 01/19] extcon: add extcon-odroid-usbotg driver

2015-03-19 Thread George Cherian
Hi Robert, This looks like a extcon driver based on gpio for USB. Roger posted a generic one a while back. https://lkml.org/lkml/2015/2/2/187 Doesn't this serve the purpose rather than adding this driver? -George On Wed, Mar 18, 2015 at 7:34 PM, Robert Baldyga wrote: > This patch adds extcon

Re: [RFC][PATCH 3/9] usb: otg: add OTG core

2015-03-19 Thread Li Jun
On Wed, Mar 18, 2015 at 03:55:57PM +0200, Roger Quadros wrote: > The OTG core instantiates the OTG Finite State Machine > per OTG controller and manages starting/stopping the > host and gadget controllers based on the bus state. > > It provides APIs for the following tasks > > - Registering an OT

Re: [RFC 00/19] dwc3: add USB OTG role switch support

2015-03-19 Thread Robert Baldyga
Hi Chanwoo, On 03/19/2015 03:33 AM, Chanwoo Choi wrote: > Hi Robert, > > Did you test the extcon-odroid-otg driver on Odroid-U3? Yes, I tested it with Odroid U3, U3+, X2, XU3 and it works well. Best regards, Robert > > Thanks, > Chanwoo Choi > > On 03/18/2015 11:04 PM, Robert Baldyga wrote:

[PATCH] Documentation: ABI: Fix documentation for mass_storage function

2015-03-19 Thread Krzysztof Opasiak
Luns in mass storage function are identified using their id. While creating lun's directory user cannot choose any arbitrary name other than arabic numeral from 1 to FSG_MAX_LUNS. Signed-off-by: Krzysztof Opasiak --- .../ABI/testing/configfs-usb-gadget-mass-storage |7 ++- 1 file chang

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-19 Thread Linus Walleij
On Mon, Mar 9, 2015 at 8:10 PM, David Cohen wrote: > But at least on ACPI case, GPIO API blocks the ability to create > children platform devices that require GPIO as platform data, despite > we've many drivers on upstream that expect this behavior: e.g. extcon-gpio.c > > Are we considering those

Re: [RFC 11/19] dwc3: add OTG handling code

2015-03-19 Thread George Cherian
Hi Robert, On Wed, Mar 18, 2015 at 7:34 PM, Robert Baldyga wrote: > > This patch introduces OTG support in DWC3 driver. OTG feature is responsible > for dynamic USB role switching (between host and peripheral modes) based > on detected cable type. > > Each role switch causes complete core reinit