[PATCH v4 4/5] usb: dwc3: Add quirk for Synopsis device disconnection errata

2015-02-16 Thread Sneeker Yeh
Synopsis Designware USB3 IP earlier than v3.00a which is configured in silicon with DWC_USB3_SUSPEND_ON_DISCONNECT_EN=1, would need a specific quirk to prevent xhci host controller from dying when device is disconnected. Since DWC_USB3_SUSPEND_ON_DISCONNECT_EN is an IP configuration whose state ca

[PATCH v4 0/5] Add support for Fujitsu USB host controller

2015-02-16 Thread Sneeker Yeh
These patches add support for XHCI compliant Host controller found on Fujitsu Socs, and are based on http://lwn.net/Articles/629162/ The first patch is to add Fujitsu glue layer of Synopsis DesignWare USB3 driver and last four patch is about quirk implementation of errata in Synopsis DesignWare USB

[PATCH v4 3/5] usb: dwc3: add revision number DWC3_REVISION_290A and DWC3_REVISION_300A

2015-02-16 Thread Sneeker Yeh
Add the contstant for v2.90a and v3.00a dwc3 IP detection Signed-off-by: Sneeker Yeh --- drivers/usb/dwc3/core.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index d201910..0b3bb0f 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/us

[PATCH v4 2/5] xhci: Platform: Set Synopsis device disconnection quirk based on platform data

2015-02-16 Thread Sneeker Yeh
If an xhci platform has Synopsis device disconnection errata then enable XHCI_DISCONNECT_QUIRK quirk flag. Signed-off-by: Sneeker Yeh --- drivers/usb/host/xhci-plat.c |3 +++ include/linux/usb/xhci_pdriver.h |4 2 files changed, 7 insertions(+) diff --git a/drivers/usb/host/xhc

[PATCH v4 5/5] usb: dwc3: add Fujitsu Specific Glue layer

2015-02-16 Thread Sneeker Yeh
This patch adds support for Synopsis DesignWare USB3 IP Core found on Fujitsu Socs. Signed-off-by: Sneeker Yeh --- .../devicetree/bindings/usb/fujitsu-dwc3.txt | 33 drivers/usb/dwc3/Kconfig | 11 ++ drivers/usb/dwc3/Makefile |

[PATCH v4 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-16 Thread Sneeker Yeh
This issue is defined by a three-way race at disconnect, between 1) Class driver interrupt endpoint resheduling attempts if the ISR gave an ep error event due to device detach (it would try 3 times) 2) Disconnect interrupt on PORTSC_CSC, which is cleared by hub thread asynchronously 3) The ha

Re: [PATCH v2] usb: move definition of PCI_VENDOR_ID_SYNOPSYS to linux/pci_ids.h

2015-02-16 Thread Greg KH
On Mon, Feb 16, 2015 at 07:32:46PM -0700, Joseph Kogut wrote: > Removed FIXME from usb/dwc3/dwc3-pci.c by moving definition of > PCI_VENDOR_ID_SYNOPSYS shared with usb/dwc2 to linux/pci_ids.h. > > Signed-off-by: Joseph Kogut > --- > drivers/usb/dwc2/pci.c | 1 - > drivers/usb/dwc3/dwc3-pci.

RE: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

2015-02-16 Thread yoshihiro shimoda
Hi Geert-san, Thank you for the reply again! > Hi Shimoda-san, > > On Mon, Feb 16, 2015 at 2:52 AM, Yoshihiro Shimoda > wrote: > > According to the gadget.h, a "complete" function will always be called > > with interrupts disabled. However, sometimes usbhsg_queue_pop() function > > is called wi

[PATCH v2] usb: move definition of PCI_VENDOR_ID_SYNOPSYS to linux/pci_ids.h

2015-02-16 Thread Joseph Kogut
Removed FIXME from usb/dwc3/dwc3-pci.c by moving definition of PCI_VENDOR_ID_SYNOPSYS shared with usb/dwc2 to linux/pci_ids.h. Signed-off-by: Joseph Kogut --- drivers/usb/dwc2/pci.c | 1 - drivers/usb/dwc3/dwc3-pci.c | 2 -- include/linux/pci_ids.h | 2 ++ 3 files changed, 2 insertions(

Re: [PATCH] usb: move definition of PCI_VENDOR_ID_SYNOPSYS to linux/pci_ids.h

2015-02-16 Thread Greg KH
On Mon, Feb 16, 2015 at 07:16:36PM -0700, Joseph Kogut wrote: > On Mon, 2015-02-16 at 17:57 -0800, Greg KH wrote: > > On Mon, Feb 16, 2015 at 06:45:53PM -0700, Joseph Kogut wrote: > > > Signed-off-by: Joseph Kogut > > > > You need a changelog description here please. > > > > Should I reply inli

Re: [PATCH] usb: move definition of PCI_VENDOR_ID_SYNOPSYS to linux/pci_ids.h

2015-02-16 Thread Joseph Kogut
On Mon, 2015-02-16 at 17:57 -0800, Greg KH wrote: > On Mon, Feb 16, 2015 at 06:45:53PM -0700, Joseph Kogut wrote: > > Signed-off-by: Joseph Kogut > > You need a changelog description here please. > Should I reply inline, or is resending the patch okay? -- To unsubscribe from this list: send th

Re: [PATCH] usb: move definition of PCI_VENDOR_ID_SYNOPSYS to linux/pci_ids.h

2015-02-16 Thread Greg KH
On Mon, Feb 16, 2015 at 06:45:53PM -0700, Joseph Kogut wrote: > Signed-off-by: Joseph Kogut You need a changelog description here please. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://v

[PATCH] usb: move definition of PCI_VENDOR_ID_SYNOPSYS to linux/pci_ids.h

2015-02-16 Thread Joseph Kogut
Signed-off-by: Joseph Kogut --- drivers/usb/dwc2/pci.c | 1 - drivers/usb/dwc3/dwc3-pci.c | 2 -- include/linux/pci_ids.h | 2 ++ 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c index a4e724b..6646adb 100644 --- a/drivers/usb

Re: [PATCH V6 03/10] USB: f81232: implement RX bulk-in ep

2015-02-16 Thread Peter Hung
Hello, Greg KH 於 2015/2/17 上午 03:41 寫道: + if (unlikely(data[i+0] & UART_LSR_BRK_ERROR_BITS)) { Never use unlikely() unless you can prove that it actually matters if you use it. Hint, it's almost impossible to prove, so don't use it, the compiler and processor look-ahead is almo

Re: [PATCH 01/13] usb: define a generic USB_RESUME_TIMEOUT macro

2015-02-16 Thread Felipe Balbi
Hi, On Sun, Feb 15, 2015 at 09:06:15AM +0800, Peter Chen wrote: > On Fri, Feb 13, 2015 at 07:42:22PM -0600, Felipe Balbi wrote: > > On Sat, Feb 14, 2015 at 08:13:36AM +0800, Greg KH wrote: > > > On Fri, Feb 13, 2015 at 03:07:43PM -0600, Felipe Balbi wrote: > > > > Every USB Host controller should

Re: dwc3/xHCI max connection limit

2015-02-16 Thread Felipe Balbi
On Mon, Feb 16, 2015 at 08:52:35AM -0600, Bin Liu wrote: > Felipe, > > On Mon, Feb 16, 2015 at 7:17 AM, Felipe Balbi wrote: > > On Wed, Feb 11, 2015 at 04:14:49PM -0600, Bin Liu wrote: > >> Alan, > >> > >> On Wed, Feb 11, 2015 at 3:56 PM, Alan Stern > >> wrote: > >> > On Wed, 11 Feb 2015, Bin L

[PATCH] usb: plusb: Add support for National Instruments host-to-host cable

2015-02-16 Thread Ben Shelton
The National Instruments USB Host-to-Host Cable is based on the Prolific PL-25A1 chipset. Add its VID/PID so the plusb driver will recognize it. Signed-off-by: Ben Shelton --- drivers/net/usb/plusb.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/usb/plusb.c b/drivers/net/

Re: please can you add my device ?

2015-02-16 Thread Greg KH
On Sun, Feb 15, 2015 at 11:10:05AM +0100, faivre.laur...@laposte.net wrote: > Thanks for your reply. > > If I use directly the ftdi_sio driver, I can't read anything. > some details : > $ dmesg > usb 1-1.3: new full-speed USB device number 4 using dwc_otg > usb 1-1.3: New USB device found,

Re: [PATCH V6 03/10] USB: f81232: implement RX bulk-in ep

2015-02-16 Thread Greg KH
On Mon, Feb 16, 2015 at 03:57:55PM +0800, Peter Hung wrote: > The F81232 bulk-in is RX data + LSR channel, data format is > [LSR+Data][LSR+Data]. , We had reimplemented in this patch. > > Signed-off-by: Peter Hung > --- > drivers/usb/serial/f81232.c | 68 > +++---

Re: [PATCH] usb: dwc3: Moved PCI IDS to linux/pci_ids.h

2015-02-16 Thread Greg Kroah-Hartman
On Mon, Feb 16, 2015 at 09:27:09AM -0700, Joseph Kogut wrote: > It seems that the Synopsys vendor ID is used in usb/dwc2 as well, and > the rest of the definitions aren't referenced outside of usb/dwc3. > Would the proper approach be to move the Synopsys vendor ID to > linux/pci_ids.h, remove the r

Re: please can you add my device ?

2015-02-16 Thread faivre.laur...@laposte.net
Hi, just a remark, in the dmesg result, there is no lines likes : usb 1-1.3: Endpoint 1 MaxPacketSize 64 usb 1-1.3: Endpoint 2 MaxPacketSize 64 usb 1-1.3: Setting MaxPacketSize 64 Is this normal ? Thanks Le 15/02/2015 11:10, faivre.laur...@laposte.net a écrit : Thanks for your reply. If I us

Re: [PATCH] usb: dwc3: Moved PCI IDS to linux/pci_ids.h

2015-02-16 Thread Joseph Kogut
It seems that the Synopsys vendor ID is used in usb/dwc2 as well, and the rest of the definitions aren't referenced outside of usb/dwc3. Would the proper approach be to move the Synopsys vendor ID to linux/pci_ids.h, remove the redefinition in usb/dwc2, and remove the fixme? -- To unsubscribe from

Re: [PATCH 02/13] usb: host: xhci: use new USB_RESUME_TIMEOUT

2015-02-16 Thread Mathias Nyman
On 13.02.2015 23:07, Felipe Balbi wrote: > Make sure we're using the new macro, so our > resume signaling will always pass certification. > > Signed-off-by: Felipe Balbi > --- > drivers/usb/host/xhci-ring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/hos

Re: [PATCH] usb: dwc3: Moved PCI IDS to linux/pci_ids.h

2015-02-16 Thread Bjorn Helgaas
On Sun, Feb 15, 2015 at 6:17 PM, Joseph Kogut wrote: > Moved DWC3 PCI IDS to linux/pci_ids.h per the FIXME. > > Signed-off-by: Joseph Kogut > --- > drivers/usb/dwc3/dwc3-pci.c | 10 +- > include/linux/pci_ids.h | 8 > 2 files changed, 9 insertions(+), 9 deletions(-) > > dif

Re: dwc3/xHCI max connection limit

2015-02-16 Thread Bin Liu
Felipe, On Mon, Feb 16, 2015 at 7:17 AM, Felipe Balbi wrote: > On Wed, Feb 11, 2015 at 04:14:49PM -0600, Bin Liu wrote: >> Alan, >> >> On Wed, Feb 11, 2015 at 3:56 PM, Alan Stern >> wrote: >> > On Wed, 11 Feb 2015, Bin Liu wrote: >> > >> >> > The problem probably isn't the number of endpoints,

Re: [PATCH v2 1/3] usb: XHCI: platform: Move the Marvell quirks after the enabling the clocks

2015-02-16 Thread Mathias Nyman
On 09.02.2015 10:31, Greg Kroah-Hartman wrote: > On Mon, Feb 09, 2015 at 09:22:50AM +0100, Maxime Ripard wrote: >> On Wed, Feb 04, 2015 at 05:04:18AM -0800, Greg Kroah-Hartman wrote: >>> On Wed, Feb 04, 2015 at 10:35:22AM +0100, Maxime Ripard wrote: Hi Mathias, Greg, On Mon, Jan 19,

Re: dwc3/xHCI max connection limit

2015-02-16 Thread Felipe Balbi
On Wed, Feb 11, 2015 at 04:14:49PM -0600, Bin Liu wrote: > Alan, > > On Wed, Feb 11, 2015 at 3:56 PM, Alan Stern wrote: > > On Wed, 11 Feb 2015, Bin Liu wrote: > > > >> > The problem probably isn't the number of endpoints, but rather the > >> > scheduling entries for interrupt and isochronous end

Re: [PATCH V5 3/8] USB: f81232: implement RX bulk-in ep

2015-02-16 Thread Johan Hovold
On Mon, Feb 16, 2015 at 07:59:45PM +0700, Johan Hovold wrote: > On Fri, Feb 06, 2015 at 05:46:49PM +0800, Peter Hung wrote: > I'll try to look at the rest of the series soon. Managed to comment on v5 rather than v6, but looks like comments on this patch still apply. Johan -- To unsubscribe from

Re: [PATCH V5 3/8] USB: f81232: implement RX bulk-in ep

2015-02-16 Thread Johan Hovold
On Fri, Feb 06, 2015 at 05:46:49PM +0800, Peter Hung wrote: > The F81232 bulk-in is RX data + LSR channel, data format is > [LSR+Data][LSR+Data]. , We had reimplemented in this patch. > > Signed-off-by: Peter Hung > --- > drivers/usb/serial/f81232.c | 68 > +++---

need an additional option to access first check-in of a file

2015-02-16 Thread temp sha
Hi All, Not sure where I should post this as this is a Git infra related suggestion. I think we should have an additional option "first/oldest" along with "Newer/Older" in Git. This will be helpful in browsing the first check-in of a file. Thanks.

Re: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

2015-02-16 Thread Geert Uytterhoeven
Hi Shimoda-san, On Mon, Feb 16, 2015 at 2:52 AM, Yoshihiro Shimoda wrote: > According to the gadget.h, a "complete" function will always be called > with interrupts disabled. However, sometimes usbhsg_queue_pop() function > is called with interrupts enabled. So, this function should calls > local

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-16 Thread Mathias Nyman
On 15.02.2015 16:29, Sneeker Yeh wrote: > hi Mathias: > > thanks for reviewing these patch, > and sorry for replying lately~ > >>> + status = readl(port_array[dev_port_num - 1]); >>> + >>> + /* write 1 to clear */ >>> + if (!(status & PORT_CONNECT) && (status & PORT_CSC)) >>> +

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-16 Thread Andrzej Pietrasiewicz
W dniu 15.02.2015 o 23:43, Ruslan Bilovol pisze: In my opinion all things which you have described are working out-of-box when you use configfs interface. It's mostly ready so you may create equivalent of most legacy gadgets (apart from printer and tcm) and just bind from one udc to another w

[PATCH V6 03/10] USB: f81232: implement RX bulk-in ep

2015-02-16 Thread Peter Hung
The F81232 bulk-in is RX data + LSR channel, data format is [LSR+Data][LSR+Data]. , We had reimplemented in this patch. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 68 +++-- 1 file changed, 35 insertions(+), 33 deletions(-) diff --git

[PATCH V6 01/10] USB: f81232: rename private struct member name

2015-02-16 Thread Peter Hung
Change private struct member name from line_status to modem_status. It will store MSR for some functions used Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81

[PATCH V6 00/10] USB: f81232: V6 patches

2015-02-16 Thread Peter Hung
This series patch V6 is improvement from V5&V4 as following: 1. transform all function not to use private data as parameter, using usb_serial_port instead. 2. process_read_urb() add process of Break/FrameError/ParityError/OE. (patch: 03/10) 3. fix calc_baud_divisor() will cause divide by z

[PATCH V6 02/10] USB: f81232: implement read IIR/MSR with endpoint

2015-02-16 Thread Peter Hung
The interrupt Endpoint will report current IIR. If we got IIR with MSR Changed , We will do read MSR with interrupt_work worker to do f81232_read_msr() func. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 109 1 file changed, 100 insertio

[PATCH V6 10/10] USB: f81232: modify/add author

2015-02-16 Thread Peter Hung
Add me to co-author and fix no '>' in greg kh's email Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c index 5134a19..5e35859 100644 --- a/drivers/usb/serial/f

[PATCH V6 04/10] USB: f81232: implement set_termios

2015-02-16 Thread Peter Hung
The original driver had do not any h/w change in driver. This patch implements with configure H/W for baud/parity/word length/stop bits functional. Some init step extract to f81232_port_init(), called once with open(). And refine baudrate setting to f81232_set_baudrate() Signed-off-by: Peter Hung

[PATCH V6 09/10] USB: f81232: implement delta change for MSR count

2015-02-16 Thread Peter Hung
We implement delta change for MSR counting. This patch is referenced from ftdi_sio.c Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.

[PATCH V6 05/10] USB: f81232: implement MCR/MSR function

2015-02-16 Thread Peter Hung
This patch implement relative MCR/MSR function, such like tiocmget()/tiocmset()/dtr_rts(). The f81232_set_mctrl() replace set_control_lines() to do MCR control so we clean-up the set_control_lines() function. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 98 +++

[PATCH V6 06/10] USB: f81232: clarify f81232_ioctl and fix

2015-02-16 Thread Peter Hung
We extract TIOCGSERIAL section in f81232_ioctl() to f81232_get_serial_info() to make it clarify. Also we fix device type from 16654 to 16550A, and set it's baud_base to 115200 (1.8432MHz/16) Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 30 +++--- 1 file ch

[PATCH V6 07/10] USB: f81232: fix error in f81232_carrier_raised()

2015-02-16 Thread Peter Hung
It's should compared with UART_MSR_DCD, not UART_DCD. also we clean-up some non-used define to avoid impropriety use. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drive

[PATCH V6 08/10] USB: f81232: fix read MSR strange value

2015-02-16 Thread Peter Hung
When we use RS232 loopback, assume doing RTS change will cause CTS change, DTR change will cause DCD/DSR change too. Sometimes we got 7~4 bits of MSR changed but the 3~0 bits of MSR(delta) maybe not changed when set & get MCR fasterly. So we add more check not only UART_MSR_ANY_DELTA but also wit