[PATCH v2 5/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

This issue is defined by a three-way race at disconnect, between 1) Class driver interrupt endpoint resheduling attempts if the ISR gave an ep error event due to device detach (it would try 3 times) 2) Disconnect interrupt on PORTSC_CSC, which is cleared by hub thread asynchronously 3) The ha

[PATCH v2 4/5] xhci: Platform: Set Synopsis device disconnection quirk based on platform data

If an xhci platform has Synopsis device disconnection errata then enable XHCI_DISCONNECT_QUIRK quirk flag. Signed-off-by: Sneeker Yeh --- drivers/usb/host/xhci-plat.c |3 +++ include/linux/usb/xhci_pdriver.h |4 2 files changed, 7 insertions(+) diff --git a/drivers/usb/host/xhc

[PATCH net-next 0/7] r8152: adjust the code

Code adjustment. Hayes Wang (7): r8152: adjust rx_bottom r8152: adjust lpm timer r8152: check linking status with netif_carrier_ok r8152: check RTL8152_UNPLUG for rtl8152_close r8152: adjust the link feed for hw_features r8152: replace get_protocol with vlan_get_protocol r8152: use B

[PATCH net-next 1/7] r8152: adjust rx_bottom

If a error occurs when submitting rx, skip the remaining submissions and try to submit them again next time. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.

[PATCH net-next 4/7] r8152: check RTL8152_UNPLUG for rtl8152_close

It is unnecessary to accress the hw register if the device is unplugged. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 21f853f..9be642e 100644 --- a/drivers/net/usb

[PATCH net-next 2/7] r8152: adjust lpm timer

Set LPM timer to 500us, except for RTL_VER_04 which doesn't link at USB 3.0. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 78a8917..3ee9d06 100644 --- a/drive

[PATCH net-next 3/7] r8152: check linking status with netif_carrier_ok

Replace (tp->speed & LINK_STATUS) with netif_carrier_ok(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 3ee9d06..21f853f 100644 --- a/driv

[PATCH net-next 6/7] r8152: replace get_protocol with vlan_get_protocol

vlan_get_protocol() has been defined and use it to replace get_protocol(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index f66ffbd..46440ed 100644 -

[PATCH net-next 5/7] r8152: adjust the link feed for hw_features

Keep NETIF_F_HW_VLAN_CTAG_RX and NETIF_F_HW_VLAN_CTAG_TX at the same line. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 9be642e..f66ffbd 100644 --- a/drivers/net

[PATCH net-next 7/7] r8152: use BIT macro

Use BIT macro to replace (1 << bits). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 46440ed..c3a0224 100644 --- a/drivers/net/u

Re: query on DWC3

Hi Felipe, On Thu, Jan 8, 2015 at 10:27 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jan 06, 2015 at 12:39:55PM +0530, sundeep subbaraya wrote: >> >> On Sun, Dec 14, 2014 at 08:39:18AM +0530, sundeep subbaraya wrote: >> >> > Hi Paul, >> >> > >> >> > As per my understanding, for BULK OUT we do queue

[PATCH 1/2] usb: renesas_usbhs: add usbhsf_dma_init_pdev() function

To add support for requesting DT DMA in the future, this patch adds usbhsf_dma_init_pdev() function. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/renesas_usbhs/fifo.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers

[PATCH 2/2] usb: renesas_usbhs: add support for requesting DT DMA

This patch adds dma_request_slave_channel_reason() calling to request dma slave channels for multiplatform environment. Signed-off-by: Yoshihiro Shimoda --- .../devicetree/bindings/usb/renesas_usbhs.txt |2 ++ drivers/usb/renesas_usbhs/fifo.c | 11 ++- 2 file

[PATCH 0/2] usb: renesas_usbhs: add support for requesting DT DMA

This patch series is based on Felipe's usb.git / testing/next branch. (commit id = 05cf6e00b8ff2b80c8b2d1e69f07cdd6c830efe0) Yoshihiro Shimoda (2): usb: renesas_usbhs: add usbhsf_dma_init_pdev() function usb: renesas_usbhs: add support for requesting DT DMA .../devicetree/bindings/usb/renesa

Re: [PATCH v3 1/3] usb: udc: add usb_gadget_find_udc

On Fri, Jan 16, 2015 at 10:15:45AM -0600, Felipe Balbi wrote: > On Fri, Jan 16, 2015 at 11:05:07AM -0500, Alan Stern wrote: > > On Fri, 16 Jan 2015, Peter Chen wrote: > > > > > This is an internal API, and is used to find corresponding udc according > > > to gadget. > > > > > > Signed-off-by: Pet

[PATCH 1/1] usb: serial: Fintek F81232 driver improvement

The original driver completed with TX function, but RX/MSR/MCR/LSR is not workable with this driver. So we rewrite it to make this device workable. This patch is tested with PassMark BurnInTest with Cycle-to-115200 + MCR/MSR check for 15mins & checked with Suspend-To-RAM/DISK Signed-off-by: Peter

Re: [PATCH v3 3/3] usb: udc: add usb_udc_activation_handler

On Fri, Jan 16, 2015 at 11:11:56AM -0500, Alan Stern wrote: > On Fri, 16 Jan 2015, Peter Chen wrote: > > > During this API, the deactivation count will be update, and it > > will try to connect or disconnect gadget. It can be used to > > enable functions for gadget. > > > > Signed-off-by: Peter C

Re: [PATCHv2 2/2] USB: host: ohci_at91: Stop/start USB PLL for all sleep modes

On 17/01/2015 at 16:36:35 +0100, Sylvain Rochet wrote : > Disable/unprepare clocks without testing the sleep target_state, removed > the at91_suspend_entering_slow_clock() call (which is only a > target_state == PM_SUSPEND_MEM). > > Other kind of suspend now benefit from the power save induced by

Re: [PATCH 3/3] usb: gadget: uvc: comments for iterating over streaming hierarchy

Hi Andrzej, Thank you for the patch. On Friday 16 January 2015 15:14:28 Andrzej Pietrasiewicz wrote: > The purpose of the functions and their parametrs might not be obvious > to the reader, so explain it. > > Signed-off-by: Andrzej Pietrasiewicz > > --- > drivers/usb/gadget/function/uvc_config

Re: [PATCH 2/3] usb: gadget: uvc: preserve the address passed to kfree()

Hi Andrzej, Thank you for the patch. On Friday 16 January 2015 15:14:27 Andrzej Pietrasiewicz wrote: > __uvcg_fill_strm() called from __uvcg_iter_stream_cls() > might have advanced the "data" even if __uvcg_iter_stream_cls() > returns an error, so use a backup copy as an argument to kfree(). > >

Re: [PATCH 1/3] Revert "usb: gadget: uvc: cleanup __uvcg_fill_strm()"

Hi Andrzej, Thank you for the patch. On Friday 16 January 2015 15:14:26 Andrzej Pietrasiewicz wrote: > This reverts commit c0b53cb16250 ("usb: gadget: uvc: cleanup > __uvcg_fill_strm()"). I can't find that commit in Linus' master, next/master or Felipe's next branch. If the patch hasn't been ap

Re: [patch 6/6] usb: gadget: uvc: cleanup UVCG_FRAME_ATTR macro

Hi Dan, Thank you for the patch. On Thursday 15 January 2015 00:06:35 Dan Carpenter wrote: > 1) Change "conv" an "vnoc" to "to_cpu_endian" to "to_little_endian". > 2) No need to check the "limit" because that is already handled in >kstrtoXX so delete that parameter along with the check. > 3)

Re: [patch 4/6] usb: gadget: uvc: memory leak in uvcg_frame_make()

Hi Dan, Thank you for the patch. On Thursday 15 January 2015 00:03:08 Dan Carpenter wrote: > We need to add a kfree(h) on an error path. > > Signed-off-by: Dan Carpenter Acked-by: Laurent Pinchart > diff --git a/drivers/usb/gadget/function/uvc_configfs.c > b/drivers/usb/gadget/function/uvc_c

Re: [patch 3/6] usb: gadget: uvc: remove an impossible condition

Hi Dan, Thank you for the patch. On Thursday 15 January 2015 00:02:18 Dan Carpenter wrote: > "num" is a u32 so "(num > 0x)" is never true. Also the range > is already checked in kstrtou32(). > > Signed-off-by: Dan Carpenter Acked-by: Laurent Pinchart > diff --git a/drivers/usb/gadge

Re: [patch 1/6] usb: gadget: uvc: fix some error codes

Hi Dan, Thank you for the patch. On Wednesday 14 January 2015 23:59:48 Dan Carpenter wrote: > We're basically saying ERR_CAST(NULL) and PTR_ERR(NULL) here, which is > nonsensical. > > Signed-off-by: Dan Carpenter Acked-by: Laurent Pinchart > diff --git a/drivers/usb/gadget/function/uvc_confi

[PATCH 23/23] wusbcore: rh: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/wusbcore/rh.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: usb/drivers/usb/wusbcore/rh.c =

[PATCH 22/23] usbip: vhci_hcd: use HUB_CHAR_*

Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/usbip/vhci_hcd.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: usb/drivers/usb/usbip/vhci_hcd.c =

[PATCH 21/23] renesas_usbhs: mod_host: use HUB_CHAR_*

Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/renesas_usbhs/mod_host.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: usb/drivers/usb/renesas_usbhs/

[PATCH 20/23] musb_virthub: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/musb/musb_virthub.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Index: usb/drivers/usb/musb/musb_virt

[PATCH 19/23] dummy_hcd: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/gadget/udc/dummy_hcd.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) Index: usb/drivers/usb/gadget/udc

[PATCH 18/23] dwc2: hcd: use HUB_CHAR_*

Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/dwc2/hcd.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: usb/drivers/usb/dwc2/hcd.c

[PATCH 17/23] uhci-hub: use HUB_CHAR_*

Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/uhci-hub.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: usb/drivers/usb/host/uhci-hub.c

[PATCH 16/23] u132-hcd: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/u132-hcd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: usb/drivers/usb/host/u132-hcd.c

[PATCH 15/23] sl811-hcd: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/sl811-hcd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: usb/drivers/usb/host/sl811-hcd.c =

[PATCH 14/23] r8a66597-hcd: use HUB_CHAR_*

Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/r8a66597-hcd.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: usb/drivers/usb/host/r8a66597-hcd.c

[PATCH 13/23] oxu210hp-hcd: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/oxu210hp-hcd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: usb/drivers/usb/host/oxu210hp-h

[PATCH 12/23] ohci-s3c2410: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . While at it, stop setting already set HUB_CHAR_INDV_PORT_LPSM once again. Signed-off-by: Sergei Shtylyov --- drivers/usb/host/ohci-s3c2410.c |6 +++--- 1 file chang

[PATCH 11/23] ohci-hub: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . While at it, fix the indentation. Signed-off-by: Sergei Shtylyov --- drivers/usb/host/ohci-hub.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Ind

[PATCH 10/23] ohci-at91: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . While at it, stop setting already set HUB_CHAR_INDV_PORT_LPSM once again. Signed-off-by: Sergei Shtylyov --- drivers/usb/host/ohci-at91.c |6 -- 1 file changed,

[PATCH 09/23] max3421-hcd: use HUB_CHAR_*

Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/max3421-hcd.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: usb/drivers/usb/host/max3421-hcd.c =

[PATCH 08/23] isp1760-hcd: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/isp1760-hcd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: usb/drivers/usb/host/isp1760-hcd

[PATCH 07/23] isp1362-hcd: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . While at it, avoid duplicate computation when calling DBG(). Signed-off-by: Sergei Shtylyov --- drivers/usb/host/isp1362-hcd.c |8 ++-- 1 file changed, 6 insert

[PATCH 06/23] isp116x-hcd: use HUB_CHAR_*

Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/isp116x-hcd.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: usb/drivers/usb/host/isp116x-hcd.c

[PATCH 05/23] imx21-hcd: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/imx21-hcd.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Index: usb/drivers/usb/host/imx21-hcd.c ==

[PATCH 04/23] fusbh200-hcd: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/fusbh200-hcd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: usb/drivers/usb/host/fusbh200-hcd

[PATCH 03/23] fotg210-hcd: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/fotg210-hcd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: usb/drivers/usb/host/fotg210-hcd.c

[PATCH 02/23] fhci-hub: use HUB_CHAR_*

Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/fhci-hub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: usb/drivers/usb/host/fhci-hub.c =

[PATCHv5 6/6] USB: host: ohci-at91: usb_hcd_at91_probe(), remove useless stack initialisation

struct usb_hcd *hcd = NULL; ... hcd = usb_create_hcd(driver, dev, "at91"); This patch remove *hcd useless initialisation Signed-off-by: Sylvain Rochet --- drivers/usb/host/ohci-at91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/

[PATCHv5 2/6] USB: host: ohci-at91: Use struct dev_pm_ops instead of struct platform_driver

This patch replace struct platform_driver.{resume,suspend} PM bindings to a new struct dev_pm_ops. Signed-off-by: Sylvain Rochet --- drivers/usb/host/ohci-at91.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb

[PATCHv5 4/6] USB: host: ohci-at91: Fix wake-up support

This device needs to be continuously clocked to provide wake up support, previously, if STANDBY target were chosen the device were enable_irq_wake()-prepared and clock still active and if MEM target were chosen the device were also enable_irq_wake()-prepared but not clocked anymore, which is wrong.

[PATCHv5 0/6] USB: host: Atmel OHCI and EHCI drivers improvements

USB: host: Atmel OHCI and EHCI drivers improvements Suspend/resume support for EHCI. struct dev_pm_ops for OHCI. Removed global variables from both. Fixed OHCI wake up support for STANDBY(wake-up enabled) and MEM(wake-up disabled) sleep targets. Changes since v4: * Re-add at91_suspend_entering

[PATCH 01/23] ehci-hub: use HUB_CHAR_*

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/ehci-hub.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: usb/drivers/usb/host/ehci-hub.c =

[PATCHv5 3/6] USB: host: ehci-atmel: Move global variables to private struct

This patch move Atmel EHCI global variables (clocks ptr and clocked boolean) to private struct atmel_ehci_priv, stored in ehci->priv. Signed-off-by: Sylvain Rochet --- drivers/usb/host/ehci-atmel.c | 79 +++ 1 file changed, 50 insertions(+), 29 deletions(-

[PATCHv5 1/6] USB: host: ehci-atmel: Add suspend/resume support

This patch add suspend/resume support for Atmel EHCI, mostly about disabling and unpreparing clocks so USB PLL is stopped before entering sleep state. Signed-off-by: Sylvain Rochet --- drivers/usb/host/ehci-atmel.c | 31 +++ 1 file changed, 31 insertions(+) diff --gi

[PATCHv5 5/6] USB: host: ohci-at91: Move global variables to private struct

This patch move AT91 OHCI global variables (clocks ptr and clocked boolean) to private struct ohci_at91_priv, stored in ohci->priv. Signed-off-by: Sylvain Rochet --- drivers/usb/host/ohci-at91.c | 86 ++-- 1 file changed, 52 insertions(+), 34 deletions(-)

[PATCH 00/23] Use USB_CHAR_* in the host drivers

Hello. Here's a set of 23 patches against the 'usb-next' branch of Greg KH's 'usb.git' repo plus 2 FHCI patches I posted a week ago. It's to replace the use of the hex numbers where the USB_CHAR_* #define's should have been used. [01/23] ehci-hub: use HUB_CHAR_* [02/23] fhci-hub: use HUB_CHAR_

Re: Suspected (out of tree) HCI issue

Hello, (please keep me cc'ed, I'm not subscribed) On Thu, 27 Nov 2014 13:00:28 -0500 (EST), Alan Stern wrote: > If your hardware resembles, say, the DWC2 hardware then maybe the DWC2 > driver (drivers/usb/dwc2/) can be made to work with it. I've worked on this and have a functional USB port us

Re: [PATCHv4 3/6] USB: host: ohci-at91: Stop/start USB PLL for all sleep modes

Hello, On Sun, Jan 18, 2015 at 08:36:03PM +0100, Sylvain Rochet wrote: > Disable/unprepare clocks without testing the sleep target_state, removed > the at91_suspend_entering_slow_clock() call (which is only a > target_state == PM_SUSPEND_MEM). > > Other kind of suspend now benefit from the power

Re: [PATCH 001/001] usbhid: Fix initialisation and force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

On Sun, 18 Jan 2015, Jim Keir wrote: > From: Jim Keir > Signed-off-by: Jim Keir > > Currently the SWFF2 driver fails during initialisation, making the force > capability of the joystick unusable. Further, there is a long-standing > bug in the same driver where commands to update force parameter

Control message failures kill entire XHCI stack

Hello, I'm debugging some issues on a couple of different USB TV tuners which boil down to the following error: xhci_hcd :00:14.0: xHCI host not responding to stop endpoint command. This is followed by the XHCI driver disconnecting *all* USB devices from the controller. I've done a bit of d

Re: Fatal Exception on device when Hotsyncing Palm in linux

On Sat, 2015-01-17 at 00:06 +0100, Henri Manson wrote: > I figured out how to get debug output, enclosed the results. How can I > get usbserial debug output on Ubuntu 9.04? It appears it wasn't a > module yet back then. > > out-crash: debug output form Ubuntu 14.04.1 which causes the Palm m505 to

Re: [PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support

Hello. On 01/18/2015 01:49 AM, Sylvain Rochet wrote: There's little inconsistency in your patch subjects: you're using '_' but the files you're modifying are named using '-'... Indeed. @@ -187,6 +217,8 @@ static struct platform_driver ehci_atmel_driver = { .probe = eh

Re: [PATCHv3 0/5] USB: host: Atmel OHCI and EHCI drivers improvements

Hello Alan, On Sun, Jan 18, 2015 at 12:20:49PM -0500, Alan Stern wrote: > On Sat, 17 Jan 2015, Sylvain Rochet wrote: > > > Sylvain Rochet (5): > > USB: host: ehci_atmel: Add suspend/resume support > > USB: host: ohci_at91: Stop/start USB PLL for all sleep modes > > USB: host: ehci_atmel: Mo

[PATCHv4 0/6] USB: host: Atmel OHCI and EHCI drivers improvements

Suspend/resume support for EHCI. struct dev_pm_ops for OHCI. PLL stop for all sleep modes for OHCI. Removed global variables from both. Removed at91_suspend_entering_slow_clock() from both. Changes since v3: * Using struct dev_pm_ops instead of static struct platform_driver resume and suspen

[PATCHv4 3/6] USB: host: ohci-at91: Stop/start USB PLL for all sleep modes

Disable/unprepare clocks without testing the sleep target_state, removed the at91_suspend_entering_slow_clock() call (which is only a target_state == PM_SUSPEND_MEM). Other kind of suspend now benefit from the power save induced by this PLL deactivation. The resume penalty is about 500 us, which i

[PATCHv4 5/6] USB: host: ohci-at91: Move global variables to private struct

This patch move AT91 OHCI global variables (clocks ptr and clocked boolean) to private struct ohci_at91_priv, stored in ohci->priv. Signed-off-by: Sylvain Rochet --- drivers/usb/host/ohci-at91.c | 86 ++-- 1 file changed, 52 insertions(+), 34 deletions(-)

[PATCHv4 6/6] USB: host: ohci-at91: usb_hcd_at91_probe(), remove useless stack initialisation

struct usb_hcd *hcd = NULL; ... hcd = usb_create_hcd(driver, dev, "at91"); This patch remove *hcd useless initialisation Signed-off-by: Sylvain Rochet --- drivers/usb/host/ohci-at91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/

[PATCHv4 1/6] USB: host: ehci-atmel: Add suspend/resume support

This patch add suspend/resume support for Atmel EHCI, mostly about disabling and unpreparing clocks so USB PLL is stopped before entering sleep state. Signed-off-by: Sylvain Rochet --- drivers/usb/host/ehci-atmel.c | 31 +++ 1 file changed, 31 insertions(+) diff --gi

[PATCHv4 2/6] USB: host: ohci-at91: Use struct dev_pm_ops instead of struct platform_driver

This patch replace struct platform_driver.{resume,suspend} PM bindings to a new struct dev_pm_ops. Signed-off-by: Sylvain Rochet --- drivers/usb/host/ohci-at91.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb

[PATCHv4 4/6] USB: host: ehci-atmel: Move global variables to private struct

This patch move Atmel EHCI global variables (clocks ptr and clocked boolean) to private struct atmel_ehci_priv, stored in ehci->priv. Signed-off-by: Sylvain Rochet --- drivers/usb/host/ehci-atmel.c | 79 +++ 1 file changed, 50 insertions(+), 29 deletions(-

Re: [PATCH v2 3/4] mfd: dln2: add start/stop RX URBs helpers

On Tue, 16 Dec 2014, Octavian Purdila wrote: > This is in preparation for adding suspend / resume support. Please re-submit this set with the Acks you have received. Also draft a cover-letter with the current status of set, what you need next etc. > Signed-off-by: Octavian Purdila > --- > dri

Re: [PATCH 2/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change

On Sun, 18 Jan 2015 15:51:21 +0100 Sylvain Rochet wrote: > Prepare_enable on rising edge, disable_unprepare on falling edge. Reduce > power consumption if USB PLL is not already necessary for OHCI or EHCI. > If USB host is not connected we can sleep with USB PLL stopped. > > This driver does not

[PATCHv3 0/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change

Prepare_enable on rising edge, disable_unprepare on falling edge. Reduce power consumption if USB PLL is not already necessary for OHCI or EHCI. If USB host is not connected we can sleep with USB PLL stopped. This driver does not support suspend/resume yet, not suspending if we are still attached

[PATCHv3 1/2] USB: gadget: atmel_usba_udc: Fixed vbus_prev initial state

If vbus gpio is high at init, we should set vbus_prev to true accordingly to the current vbus state. Without that, we skip the first vbus interrupt because the saved vbus state is not consistent. Signed-off-by: Sylvain Rochet --- drivers/usb/gadget/udc/atmel_usba_udc.c | 2 ++ 1 file changed, 2

[PATCHv3 2/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change

Prepare_enable on rising edge, disable_unprepare on falling edge. Reduce power consumption if USB PLL is not already necessary for OHCI or EHCI. If USB host is not connected we can sleep with USB PLL stopped. This driver does not support suspend/resume yet, not suspending if we are still attached

[PATCH 001/001] usbhid: Fix initialisation and force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

From: Jim Keir Signed-off-by: Jim Keir Currently the SWFF2 driver fails during initialisation, making the force capability of the joystick unusable. Further, there is a long-standing bug in the same driver where commands to update force parameters are addressed to the last-created force effect

Re: [PATCHv3 0/5] USB: host: Atmel OHCI and EHCI drivers improvements

On Sat, 17 Jan 2015, Sylvain Rochet wrote: > Sylvain Rochet (5): > USB: host: ehci_atmel: Add suspend/resume support > USB: host: ohci_at91: Stop/start USB PLL for all sleep modes > USB: host: ehci_atmel: Move global variables to private struct > USB: host: ohci_at91: Move global variables

Re: [PATCH 2/2] Add HCS_PPC when getting root hub status

On Sun, 18 Jan 2015, Chechun Kuo wrote: > for some platform ehci controller, it is possible there is no port power > control capability in the root hub. > And we add port power control determination when getting root hub port status. Why do you need to do this? Doesn't the current code always g

Re: [PATCH 1/2] Add hub port switchable when checking port power

On Sun, 18 Jan 2015, Chechun Kuo wrote: > In check_port_resume_type, we will check port power status to determine > whether the status should change to -ENODEV. > If all ports power control of the hub are handled at once, the port power > status may not represent the real case and cause resume f

Re: [PATCH 2/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change

On Sun, 18 Jan 2015 15:51:21 +0100 Sylvain Rochet wrote: > Prepare_enable on rising edge, disable_unprepare on falling edge. Reduce > power consumption if USB PLL is not already necessary for OHCI or EHCI. > If USB host is not connected we can sleep with USB PLL stopped. > > This driver does not

Re: Difference between run time and normal suspend

On Sun, 18 Jan 2015, vichy wrote: > after tracing the source, I only can find the ehci_suspend is called > when system hibernate/suspend. > rpm_suspend use below method to find out suspend callback > if (dev->pm_domain) > callback = dev->pm_domain->ops.runtime_suspend; > else if (d

Re: hard lockup with USB3380

Ricardo, I think I figured out the problem: my 3380 was running in legacy adapter mode. I am now capable of connecting both g_mass_storage and g_ether without any kernel panics after ensuring the 3380 is in enhanced adapter mode. My only concern is the speed from my Mac to Linux: - g_ether: scp

[PATCH v4 09/11] usb: storage: adjust module reference for scsi host

The unusual usb storage drivers (ums-alauda, ums-cypress, ...) depend on usb-storage module. The module reference of these scsi host is initialized to usb-storage's one. Because these drivers use usb_stor_probe1() which is defined in usb-storage module and calls scsi_host_alloc(). So these drive

[PATCH v4 07/11] scsi: move module reference from scsi_host_template to Scsi_Host

While accessing a scsi_device, the use count of the underlying LLDD module is incremented. The module reference is retrieved through .module field of struct scsi_host_template. This mapping between scsi_device and underlying LLDD module works well except some drivers which consist with the core d

[PATCH v4 00/11] scsi: fix module reference mismatch for scsi host

While accessing a scsi_device, the use count of the underlying LLDD module is incremented. The module reference is retrieved through .module field of struct scsi_host_template. This mapping between scsi_device and underlying LLDD module works well except some drivers which consist with the core d

[PATCH 2/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change

Prepare_enable on rising edge, disable_unprepare on falling edge. Reduce power consumption if USB PLL is not already necessary for OHCI or EHCI. If USB host is not connected we can sleep with USB PLL stopped. This driver does not support suspend/resume yet, not suspending if we are still attached

[PATCHv2 1/2] USB: gadget: atmel_usba_udc: Fixed vbus_prev initial state

If vbus gpio is high at init, we should set vbus_prev to true accordingly to the current vbus state. Without that, we skip the first vbus interrupt because the saved vbus state is not consistent. Signed-off-by: Sylvain Rochet --- drivers/usb/gadget/udc/atmel_usba_udc.c | 2 ++ 1 file changed, 2

[PATCHv2 0/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change

Prepare_enable on rising edge, disable_unprepare on falling edge. Reduce power consumption if USB PLL is not already necessary for OHCI or EHCI. If USB host is not connected we can sleep with USB PLL stopped. This driver does not support suspend/resume yet, not suspending if we are still attached

Re: Difference between run time and normal suspend

>> Is 3rd situation you mentioned above the function will be called is >> hcd->bus_suspend? > > hcd->bus_suspend will be called first, and shortly afterward > ehci->suspend will be called (if this is an EHCI controller). > >> > Fourthly, you should realize that "controller itself will also be put >

[PATCH 2/2] Add HCS_PPC when getting root hub status

for some platform ehci controller, it is possible there is no port power control capability in the root hub. And we add port power control determination when getting root hub port status. Signed-off-by: Chechun Kuo --- drivers/usb/host/ehci-hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH 1/2] Add hub port switchable when checking port power

In check_port_resume_type, we will check port power status to determine whether the status should change to -ENODEV. If all ports power control of the hub are handled at once, the port power status may not represent the real case and cause resume fail. At this patch, we add hub_is_port_power_swit

Re: [PATCH 01/12] mfd: syscon: Add atmel-matrix registers definition

Hi Lee, On Sun, 18 Jan 2015 12:52:59 + Lee Jones wrote: > On Wed, 14 Jan 2015, Alexandre Belloni wrote: > > > From: Boris Brezillon > > > > AT91 SoCs have a memory range reserved for internal bus configuration. > > Expose those registers so that drivers can make use of the matrix syscon >

Re: [PATCH 03/12] mfd: syscon: Add atmel-smc registers definition

On Wed, 14 Jan 2015, Alexandre Belloni wrote: > From: Boris Brezillon > > Atmel AT91 SoCs have a memory range reserved for SMC (Static Memory > Controller) configuration. > Expose those registers so that drivers can make use of the smc syscon > declared in at91 DTs. > > Signed-off-by: Boris Bre

Re: [PATCH 04/12] mfd: syscon: Add Atmel SMC binding doc

On Wed, 14 Jan 2015, Alexandre Belloni wrote: > From: Boris Brezillon > > The SMC registers are used to configure Atmel EBI (External Bus Interface) > to interface with standard memory devices (NAND, NOR, SRAM or specialized > devices like FPGAs). > > Declare this memory region as a syscon, so

Re: [PATCH 02/12] mfd: syscon: Add Atmel Matrix bus DT binding documentation

On Wed, 14 Jan 2015, Alexandre Belloni wrote: > From: Boris Brezillon > > The Matrix registers are provided to configure internal bus behavior on > at91 SoCs. > Some registers might be accessed by several drivers (e.g. to configure > external memory bus timings), hence we declare this register s

Re: [PATCH 01/12] mfd: syscon: Add atmel-matrix registers definition

On Wed, 14 Jan 2015, Alexandre Belloni wrote: > From: Boris Brezillon > > AT91 SoCs have a memory range reserved for internal bus configuration. > Expose those registers so that drivers can make use of the matrix syscon > declared in at91 DTs. > > Signed-off-by: Boris Brezillon > Acked-by: Lee

Re: Fatal Exception on device when Hotsyncing Palm in linux

Ubuntu 9.04: Linux ubuntu 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 2009 i686 GNU/Linux Ubuntu 10.04.4: Linux ubuntu 2.6.32-38-generic #83-Ubuntu SMP Wed Jan 4 11:13:04 UTC 2012 i686 GNU/Linux On Fri, Jan 16, 2015 at 12:24 PM, Johan Hovold wrote: > On Thu, Jan 15, 2015 at 12:00:2

Re: [PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support

Hi Sylvain, On Sat, 17 Jan 2015 23:49:00 +0100 Sylvain Rochet wrote: > Hi Sergei, > > > On Sun, Jan 18, 2015 at 01:22:38AM +0300, Sergei Shtylyov wrote: > > > >There's little inconsistency in your patch subjects: you're using > > '_' but the files you're modifying are named using '-'... >