Re: PROBLEM: USB isochronous urb leak on EHCI driver

2015-01-08 Thread Peter Chen
On Wed, Jan 7, 2015 at 2:22 AM, Alan Stern wrote: > On Tue, 6 Jan 2015, Michael Tessier wrote: > >> > > > > That is interresting, however, I have an older kernel running an >> > > > > OHCI driver which is able to handle 4 codecs. Same usb hardware >> > > > > (codecs and hub), but older kernel on a

Re: Possible race condition in USB gadget probing?

2015-01-08 Thread Peter Chen
On Sun, Jan 4, 2015 at 1:44 AM, Felipe Balbi wrote: > Hi, > > On Sat, Jan 03, 2015 at 10:53:20PM +1100, Daniel Tang wrote: >> Hi, >> >> I’ve run into a problem which I suspect is to with how >> usb_gadget_probe_driver is implemented in >> drivers/usb/gadget/udc/udc-core.c >> >> I have an embedded

Re: [PATCH 2/3] usb: gadget: uac1: struct gaudio is useless for struct f_uac1_opts

2015-01-08 Thread Peter Chen
On Mon, Dec 1, 2014 at 4:09 PM, Peter Chen wrote: > Since we call gaudio_cleanup at f_audio_free, the f_uac1_opts > doesn't need to use gaudio any more. > > Signed-off-by: Peter Chen > --- > drivers/usb/gadget/function/f_uac1.c | 1 - > drivers/usb/gadget/function/u_uac1.h | 1 - > 2 files chang

Re: [PATCH 2/3] gpio: dln2: use bus_sync_unlock instead of scheduling work

2015-01-08 Thread Linus Walleij
On Fri, Jan 9, 2015 at 12:40 AM, Octavian Purdila wrote: > On Thu, Jan 1, 2015 at 9:56 AM, Linus Walleij > wrote: >> On Thu, Dec 11, 2014 at 2:02 PM, Octavian Purdila >> wrote: >> >>> Use the irq_chip bus_sync_unlock method to update hardware registers >>> instead of scheduling work from the ma

Re: Difference between run time and normal suspend

2015-01-08 Thread Peter Chen
On Wed, Jan 07, 2015 at 10:33:29AM -0500, Alan Stern wrote: > On Wed, 7 Jan 2015, vichy wrote: > > > I attach usbmon for your reference. > > But keyboard is still not working on runtime suspend. > > The usbmon trace resembles what I got during a test some time ago. I > don't remember the details

Re: [RFC] usb: dwc3: add DWC3_SKIP_USB3PHY and DWC3_SKIP_USB2_PHY quirks

2015-01-08 Thread Jisheng Zhang
Hi Felipe, On Thu, 8 Jan 2015 09:08:15 -0800 Felipe Balbi wrote: > Hi, > > On Mon, Dec 08, 2014 at 09:35:51PM +0800, Jisheng Zhang wrote: > > On platforms which has native usb hosts/phys and pci-dwc3 controller, > > the dwc3 core may get the wrong usb2_phy and usb3_phy by > > devm_usb_get_phy()

Re: [PATCH RFC] usb: chipidea: add support for usb_phy in generic usb2

2015-01-08 Thread Peter Chen
On Mon, Jan 05, 2015 at 11:09:35AM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Sunday 04 January 2015 11:58 AM, Baruch Siach wrote: > > Signed-off-by: Baruch Siach > > --- > > drivers/usb/chipidea/ci_hdrc_usb2.c | 5 + > > 1 file changed, 5 insertions(+) > > > > I'm sending this as RF

Re: [PATCH 2/2] Chipidea: Set connect-at-fullspeed bit when entering host mode if CI_HDRC_FORCE_FULLSPEED is set in the platform data

2015-01-08 Thread Peter Chen
On Sun, Jan 04, 2015 at 01:14:59PM +1100, Daniel Tang wrote: > PORTSC_PFSC is not set on entering host mode which means the USB OTG > controller will attempt to enumerate USB devices at high speed even when the > CI_HDRC_FORCE_FULLSPEED flag is set in the platform data. > > This patch ensures it i

[PATCH net-next v2 0/2 RESEND] r8152: adjust r8152_submit_rx

2015-01-08 Thread Hayes Wang
v2: Replace the patch #1 with "call rtl_start_rx after netif_carrier_on". For patch #2, replace checking tp->speed with netif_carrier_ok. v1: Avoid r8152_submit_rx() from submitting rx during unexpected moment. This could reduce the time of stopping rx. For patch #1, the tp->speed should be upda

[PATCH net-next v2 1/2 RESEND] r8152: call rtl_start_rx after netif_carrier_on

2015-01-08 Thread Hayes Wang
Remove rtl_start_rx() from rtl_enable() and put it after calling netif_carrier_on(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 57ec23e..cd93388 100644 --- a/d

[PATCH net-next v2 2/2 RESEND] r8152: check the status before submitting rx

2015-01-08 Thread Hayes Wang
Don't submit the rx if the device is unplugged, stopped, or linking down. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index cd93388..b23426e 100644 --- a/drivers/net/usb/r8152.c +

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-08 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Friday, December 12, 2014 7:10 AM > > Get PHY parameters from devicetree and power off usb PHY during > system suspend. > > Signed-off-by: Yunzhi Li > Acked-by: Paul Zimmerman > > --- > > Changes in v7: None > Changes in v6: None > Change

[PATCH v2 1/1] usb: chipidea: host: add .bus_suspend quirk

2015-01-08 Thread Peter Chen
For chipidea, its resume sequence is not-EHCI compatible, see below description for FPR at portsc. So in order to send SoF in time for remote wakeup sequence(within 3ms), the RUN/STOP bit must be set before the resume signal is ended, but the usb resume code may run after resume signal is ended, so

[PATCH] usb: renesas_usbhs: Add access control for INTSTS1 and INTENB1 register

2015-01-08 Thread Nobuhiro Iwamatsu
INTSTS1 and INTENB1 register of renesas_usbhs can access only Host mode. This adds process of accessing INTSTS1 and INTENB1 only when renesas_usbhs is Host mode. Signed-off-by: Nobuhiro Iwamatsu --- drivers/usb/renesas_usbhs/mod.c | 61 +++-- 1 file changed, 3

Re: [PATCH 2/3] gpio: dln2: use bus_sync_unlock instead of scheduling work

2015-01-08 Thread Octavian Purdila
On Thu, Jan 1, 2015 at 9:56 AM, Linus Walleij wrote: > On Thu, Dec 11, 2014 at 2:02 PM, Octavian Purdila > wrote: > >> Use the irq_chip bus_sync_unlock method to update hardware registers >> instead of scheduling work from the mask/unmask methods. This simplifies >> a bit the driver and make it m

[PATCH v2] usb: phy: generic: add vbus support

2015-01-08 Thread Felipe Balbi
From: Robert Jarzmik Add support for vbus detection and power supply. This code is more or less stolen from phy-gpio-vbus-usb.c, and aims at providing a detection mechanism for VBus (ie. usb cable plug) based on a GPIO line, and a power supply activation which draws current from the VBus. [ ba..

Re: [PATCH v2 3/3] usb: phy: generic: add vbus support

2015-01-08 Thread Felipe Balbi
On Sat, Dec 06, 2014 at 10:05:15PM +0100, Robert Jarzmik wrote: > Add support for vbus detection and power supply. This code is more or > less stolen from phy-gpio-vbus-usb.c, and aims at providing a detection > mechanism for VBus (ie. usb cable plug) based on a GPIO line, and a > power supply acti

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-01-08 Thread Linus Walleij
On Mon, Dec 22, 2014 at 11:43 PM, David Cohen wrote: > Some platforms have an USB OTG port fully (or partially) controlled by > GPIOs: > > (1) USB ID is connected directly to GPIO > > Optionally: > (2) VBUS is enabled by a GPIO (when ID is grounded) > (3) Platform has 2 USB controllers connected

Re: [PATCH v2 0/3] usb: phy: generic: device-tree support

2015-01-08 Thread Felipe Balbi
On Thu, Jan 08, 2015 at 07:49:39PM +0100, Robert Jarzmik wrote: > Felipe Balbi writes: > > > Hi, > > Happy new year Felipe, same to you :-) > > sorry for the long delay, got caught up with other stuff. It's now in my > > testing/next and I'll start testing with the boards I have. > Excellent n

Re: [PATCH v2 0/3] usb: phy: generic: device-tree support

2015-01-08 Thread Robert Jarzmik
Felipe Balbi writes: > Hi, Happy new year Felipe, > sorry for the long delay, got caught up with other stuff. It's now in my > testing/next and I'll start testing with the boards I have. Excellent news. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb"

Re: [PATCH 1/4] usb: phy: Fix deferred probing

2015-01-08 Thread Felipe Balbi
On Thu, Jan 08, 2015 at 07:04:18PM +0100, Thierry Reding wrote: > On Thu, Jan 08, 2015 at 11:24:11AM -0600, Felipe Balbi wrote: > > * PGP Signed by an unknown key > > > > On Thu, Jan 08, 2015 at 06:32:27PM +0200, grygorii.stras...@linaro.org > > wrote: > > > Hi, > > > > > > On 01/07/2015 06:41 A

[PATCH] usb: f_fs: refactor and document __ffs_ep0_read_events better

2015-01-08 Thread Michal Nazarewicz
Instead of using variable length array, use a static length equal to the size of the ffs->ev.types array. This gets rid of a sparse warning: drivers/usb/gadget/function/f_fs.c:401:44: warning: Variable length array is used. and makes it more explicit that the array has a very tig

Re: [PATCH 1/4] usb: phy: Fix deferred probing

2015-01-08 Thread Thierry Reding
On Thu, Jan 08, 2015 at 11:24:11AM -0600, Felipe Balbi wrote: > * PGP Signed by an unknown key > > On Thu, Jan 08, 2015 at 06:32:27PM +0200, grygorii.stras...@linaro.org wrote: > > Hi, > > > > On 01/07/2015 06:41 AM, Olof Johansson wrote: > > > On Tue, Jan 6, 2015 at 7:45 AM, Maxime Ripard > > >

Re: [PATCH 1/4] usb: phy: Fix deferred probing

2015-01-08 Thread Felipe Balbi
On Thu, Jan 08, 2015 at 06:32:27PM +0200, grygorii.stras...@linaro.org wrote: > Hi, > > On 01/07/2015 06:41 AM, Olof Johansson wrote: > > On Tue, Jan 6, 2015 at 7:45 AM, Maxime Ripard > > wrote: > >> Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on > >> failure") actually

Re: [PATCH v2 0/3] usb: phy: generic: device-tree support

2015-01-08 Thread Felipe Balbi
Hi, On Tue, Dec 23, 2014 at 12:38:28PM -0600, Felipe Balbi wrote: > On Mon, Dec 15, 2014 at 12:13:18AM +0100, Robert Jarzmik wrote: > > Robert Jarzmik writes: > > > > > Hi Felipe, > > > > > > This is the 2nd opus of this serie. > > > For patches 1 and 2, all comments have been addressed. > > > >

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2015-01-08 Thread Felipe Balbi
Hi, On Tue, Dec 30, 2014 at 05:49:27PM +0800, Songjun Wu wrote: > Executing the 'insmod g_hid.ko', then executing the > 'rmmod g_hid.ko', the NULL pointer oops will be triggered. > > When unloading the module 'g_hid.ko', the urb request will be > dequeued and the completion routine will be excute

Re: USB HID Gadget Support for Intel Edison

2015-01-08 Thread Felipe Balbi
Hi, On Thu, Jan 08, 2015 at 09:05:24AM -0800, Chris McClimans wrote: > I'm trying to get the g_hid module working with the Intel Edison. > > I tried just compiling intel's patch(1) to 3.10.17 with > CONFIG_USB_GADGETFS=m CONFIG_USB_G_HID=m but I get an error trying to > load the module: > > modp

Re: [RFC] usb: dwc3: add DWC3_SKIP_USB3PHY and DWC3_SKIP_USB2_PHY quirks

2015-01-08 Thread Felipe Balbi
Hi, On Mon, Dec 08, 2014 at 09:35:51PM +0800, Jisheng Zhang wrote: > On platforms which has native usb hosts/phys and pci-dwc3 controller, > the dwc3 core may get the wrong usb2_phy and usb3_phy by > devm_usb_get_phy(). It depends on which usb phy driver is initialized > firstly, the usb_phy_gener

USB HID Gadget Support for Intel Edison

2015-01-08 Thread Chris McClimans
I'm trying to get the g_hid module working with the Intel Edison. I tried just compiling intel's patch(1) to 3.10.17 with CONFIG_USB_GADGETFS=m CONFIG_USB_G_HID=m but I get an error trying to load the module: modprobe: ERROR: could not insert 'g_hid': No such device According to https://www.kern

Re: [PATCH v3] usb: gadget: ffs: Fix sparse error

2015-01-08 Thread Felipe Balbi
Hi, On Wed, Dec 24, 2014 at 03:23:07PM +0100, Michal Nazarewicz wrote: > On Wed, Dec 24 2014, Rohith Seelaboyina wrote: > > This patch fixes the sparse error in functionfs > > driver. > > > > drivers/usb/gadget/function/f_fs.c:400:44: error: bad > > constant experssion. > > > > Dynamic memory allo

Re: [PATCH v2 2/3] usb: phy: add lubbock phy driver

2015-01-08 Thread Felipe Balbi
On Sun, Nov 30, 2014 at 01:02:04AM +0300, Dmitry Eremin-Solenikov wrote: > Extract lubbock-specific code from pxa25x_udc driver. As a bonus, phy > driver determines connector/VBUS status by reading CPLD register. Also > it uses a work to call into udc stack, instead of pinging vbus session > right

Re: query on DWC3

2015-01-08 Thread Felipe Balbi
Hi, On Tue, Jan 06, 2015 at 12:39:55PM +0530, sundeep subbaraya wrote: > >> On Sun, Dec 14, 2014 at 08:39:18AM +0530, sundeep subbaraya wrote: > >> > Hi Paul, > >> > > >> > As per my understanding, for BULK OUT we do queue a request with 512 > >> > bytes length since we do not > >> > >> sometimes

Re: regression: Wrong device reset in port_event()

2015-01-08 Thread Alan Stern
On Thu, 8 Jan 2015, Hans de Goede wrote: > > Read through this and it seems we really may end up doing a extra reset if > > the hub wq happends to to catch the device in middle of a remote wakeup. > > (i.e. RESUME -> U0, PLC set, but interrupt handler clearing PLC flag not > > yet run) > > > > re

Re: [PATCH v3 20/20] usb: isp1760: Make HCD support optional

2015-01-08 Thread Felipe Balbi
On Tue, Dec 30, 2014 at 01:49:48PM +0200, Laurent Pinchart wrote: > Enable compilation of the isp1760 driver in pure host mode, pure device > mode, or dual-role mode. > > Signed-off-by: Laurent Pinchart this patch adds a build breakage with allmodconfig. -- balbi signature.asc Description: D

Re: [PATCH 1/4] usb: phy: Fix deferred probing

2015-01-08 Thread grygorii.stras...@linaro.org
Hi, On 01/07/2015 06:41 AM, Olof Johansson wrote: > On Tue, Jan 6, 2015 at 7:45 AM, Maxime Ripard > wrote: >> Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on >> failure") actually broke the deferred probing mechanism, since it now returns >> EPROBE_DEFER only when the try

RE: [PATCH 1/1] usb: chipidea: host: add .bus_suspend quirk

2015-01-08 Thread Alan Stern
On Thu, 8 Jan 2015, Peter Chen wrote: > I have traced three cases: > Case 1: with my patch > Case 2: without my patch > Case 3: without my patch, and add PORT_SUSPEND before sending the resume ... > Let's see why case 3 can't work: > - At packet 31187, it is resume signal for remote wakeup, aft

Re: regression: Wrong device reset in port_event()

2015-01-08 Thread Hans de Goede
Hi, On 08-01-15 16:22, Mathias Nyman wrote: On 30.12.2014 08:54, Zhuang Jin Can wrote: Pasting the log to better explain the issue. <7>[ 589.157489] usb 2-5: usb auto-suspend, wakeup 1 <7>[ 589.168496] xhci_hcd :00:14.0: set port remote wake mask, actual port 0 status = 0xe0002a0 <7>[

Re: regression: Wrong device reset in port_event()

2015-01-08 Thread Mathias Nyman
On 30.12.2014 08:54, Zhuang Jin Can wrote: > Pasting the log to better explain the issue. > > <7>[ 589.157489] usb 2-5: usb auto-suspend, wakeup 1 > <7>[ 589.168496] xhci_hcd :00:14.0: set port remote wake mask, actual > port 0 status = 0xe0002a0 > <7>[ 589.168543] xhci_hcd :00:14.0:

Re: [PATCH v2 0/3] scsi: ufs & ums-*: fix module reference counting

2015-01-08 Thread Alan Stern
On Thu, 8 Jan 2015, Akinobu Mita wrote: > >> Why don't ufs and usb-storage define the host templates in the sub drivers? > >> That's what libata or the mpt fusion driver do. > > > > Originally the subdrivers were all part of usb-storage. When they were > > split out into separate modules, there d

RE: [PATCH v2 00/30] usb: updates for dwc2 gadget driver

2015-01-08 Thread Kaukab, Yousaf
Hi, > -Original Message- > From: Kaukab, Yousaf > Sent: Wednesday, January 7, 2015 7:55 PM > To: Dinh Nguyen; Paul Zimmerman; linux-usb@vger.kernel.org; ba...@ti.com > Cc: Herrero, Gregory; sergei.shtyl...@cogentembedded.com; > r.bald...@samsung.com > Subject: RE: [PATCH v2 00/30] usb: upd

[PATCH 2/2] uas: Add US_FL_NO_ATA_1X for 2 more Seagate disk enclosures

2015-01-08 Thread Hans de Goede
Just like all previous UAS capable Seagate disk enclosures, these need the US_FL_NO_ATA_1X to not crash when udev probes them. Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede --- drivers/usb/storage/unusual_uas.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/

[PATCH 1/2] uas: Do not blacklist ASM1153 disk enclosures

2015-01-08 Thread Hans de Goede
Our detection logic to avoid doing UAS on ASM1051 bridge chips causes problems with newer ASM1153 disk enclosures in 2 ways: 1) Some ASM1153 disk enclosures re-use the ASM1051 device-id of 5106, which we assume is always an ASM1051, so remove the quirk for 5106, and instead use the same dete

Re: [PATCH v2 0/3] scsi: ufs & ums-*: fix module reference counting

2015-01-08 Thread Akinobu Mita
2015-01-08 0:09 GMT+09:00 Alan Stern : > On Wed, 7 Jan 2015, Christoph Hellwig wrote: > >> On Wed, Jan 07, 2015 at 11:02:59PM +0900, Akinobu Mita wrote: >> > While accessing a scsi_device, the use count of the underlying LLDD module >> > is incremented. The module reference is retrieved through .m

Re: [PATCH] xhci: remove unused parameter 'xhci' in function xhci_handshake().

2015-01-08 Thread Mathias Nyman
On 06.01.2015 12:08, Lin Wang wrote: > Parameter 'xhci' is no longer be used in function xhci_handshake(), > just remove it. > > Signed-off-by: Lin Wang > --- > drivers/usb/host/xhci-ring.c |2 +- > drivers/usb/host/xhci.c | 19 +-- > drivers/usb/host/xhci.h |

Re: [PATCH] xhci: Clean up work to xhci_add_endpoint().

2015-01-08 Thread Mathias Nyman
On 06.01.2015 12:02, Lin Wang wrote: > This patch removes unused variable "out_ctx" and avoid multiple calls > to function xhci_get_endpoint_flag(). > > Signed-off-by: Lin Wang Thanks, added to my tree, will send forward to Greg later -Mathias -- To unsubscribe from this list: send the line "u

Re: [PATCH] xhci: clean up work to remove unused parameters for functions in xhci-mem.c

2015-01-08 Thread Mathias Nyman
On 06.01.2015 12:05, Lin Wang wrote: > Some parameters are not used by functions in xhci-mem.c, just > remove it. > > Signed-off-by: Lin Wang > --- > drivers/usb/host/xhci-dbg.c |2 +- > drivers/usb/host/xhci-mem.c | 21 + > drivers/usb/host/xhci-ring.c |6 +++---