Re: [PATCH 1/4] usb: phy: Fix deferred probing

2015-01-06 Thread Olof Johansson
Hi, On Tue, Jan 6, 2015 at 7:45 AM, Maxime Ripard wrote: > Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on > failure") actually broke the deferred probing mechanism, since it now returns > EPROBE_DEFER only when the try_module_get call fails, but not when the phy > lookup

[PATCH 1/1] x86: Added support for Japanese Surface Type Cover 3

2015-01-06 Thread Alan Wu
Based on code for the US Surface Type Cover 3 from commit be3b16341d5cd8cf2a64fcc7a604a8efe6599ff0 ("HID: add support for MS Surface Pro 3 Type Cover"): Signed-off-by: Alan Wu Tested-by: Karlis Dreizis --- drivers/hid/hid-core.c | 4 +++- drivers/hid/hid-ids.h | 1 + driver

Re: [PATCH v2 00/30] usb: updates for dwc2 gadget driver

2015-01-06 Thread Dinh Nguyen
On 01/05/2015 01:16 PM, Paul Zimmerman wrote: > Adding Dinh to CC. > > Robert, Dinh, I would like to have your tested-bys for this series, please. > This patch series is producing this error on the SOCFPGA platform. I'll try to bisect to a specific patch. root@socfpga_cyclone5:~# [ 47.929743]

Re: [PATCH v2 00/30] usb: updates for dwc2 gadget driver

2015-01-06 Thread Dinh Nguyen
On 01/06/2015 05:47 PM, Dinh Nguyen wrote: > On 01/05/2015 01:16 PM, Paul Zimmerman wrote: >> Adding Dinh to CC. >> >> Robert, Dinh, I would like to have your tested-bys for this series, please. >> > > This patch series is producing this error on the SOCFPGA platform. I'll > try to bisect to a spe

Re: [xhci_hcd] USB3 device unplug breaks system suspend

2015-01-06 Thread Tobias Jakobi
Just a short note that the issue remains with vanilla 3.18.1. Greets, Tobias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] USB: qcserial/option: make AT URCs work for Sierra Wireless MC73xx

2015-01-06 Thread Reinhard Speyerer
As has been discussed in the thread starting with https://lkml.kernel.org/g/549748e9.d+sijzqu50f1r4lsal043...@arcor.de Sierra Wireless MC73xx devices with USB VID/PID 0x1199:0x68c0 require the option_send_setup() code to be used on the USB interface for the AT port to make unsolicited response code

Re: [PATCH] Use memzero_explicit to clear local buffers

2015-01-06 Thread Herbert Xu
On Tue, Jan 06, 2015 at 08:42:26PM +0100, Giel van Schijndel wrote: > > Question: are you sure the compiler won't optimize the call to memset(0) > way if it's immediately followed by kfree()? Yes it won't be optimised away. However, you could use kzfree. > Another actually does change a stack-a

Re: kernel panic with USB3+DVB+ARM

2015-01-06 Thread JPT
Am 06.01.2015 um 18:38 schrieb Greg KH: > On Tue, Jan 06, 2015 at 11:47:29AM +0100, JPT wrote: >> Hi Greg >> >> Am 06.01.2015 um 02:54 schrieb Greg KH: >>> >>> Is that where the kernel panics show the problem happens? Without them, >>> there's nothing we can do to help out except randomly guess, s

[PATCH] usb: gadget: udc: avoid dereference before NULL check in ep_queue

2015-01-06 Thread John W. Linville
Coverity: CID 1260069 Signed-off-by: John W. Linville --- drivers/usb/gadget/udc/bdc/bdc_ep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c b/drivers/usb/gadget/udc/bdc/bdc_ep.c index ff67ceac77c4..d4fe8d769bd6 100644 --- a/drivers/usb

Re: [PATCH] Use memzero_explicit to clear local buffers

2015-01-06 Thread Giel van Schijndel
On Mon, Jan 05, 2015 at 10:36:37 +1100, Herbert Xu wrote: > On Sun, Jan 04, 2015 at 11:49:09PM +0100, Giel van Schijndel wrote: >> >>> sctx does not point to stack memory so this is bogus. >>> >>> Only stack memory cleared just before it goes out of scope needs >>> memzero_explicit. >> >> Is that

Re: [PATCH 3/4] usb: xhci: plat: Add USB phy support

2015-01-06 Thread Sergei Shtylyov
Hello. On 01/06/2015 06:45 PM, Maxime Ripard wrote: The Marvell Armada 385 AP needs a dumb phy in order to enable the USB3 VBUS. Add a call to retrieve a USB PHY to XHCI plat in order to support this. Signed-off-by: Maxime Ripard [...] diff --git a/drivers/usb/host/xhci.h b/drivers/u

Re: [PATCHv2 1/2] usb: ohci-platform: add support for multiple phys per controller

2015-01-06 Thread Arun Ramamurthy
Thank you for the comments Alan On 15-01-06 07:45 AM, Alan Stern wrote: On Thu, 11 Dec 2014 arun.ramamur...@broadcom.com wrote: From: Arun Ramamurthy Added support for cases where one controller is connected to multiple phys Will this continue to work on systems that use only one PHY? Wha

Re: [PATCH net] r8152: support ndo_features_check

2015-01-06 Thread David Miller
From: Hayes Wang Date: Tue, 6 Jan 2015 17:41:58 +0800 > Support ndo_features_check to avoid: > - the transport offset is more than the hw limitation when using hw checksum. > - the skb->len of a GSO packet is more than the limitation. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsu

RE: PROBLEM: USB isochronous urb leak on EHCI driver

2015-01-06 Thread Alan Stern
On Tue, 6 Jan 2015, Michael Tessier wrote: > > > > > That is interresting, however, I have an older kernel running an > > > > > OHCI driver which is able to handle 4 codecs. Same usb hardware > > > > > (codecs and hub), but older kernel on a different CPU, with much > > > > > less power. This m

Re: kernel panic with USB3+DVB+ARM

2015-01-06 Thread Greg KH
On Tue, Jan 06, 2015 at 11:47:29AM +0100, JPT wrote: > Hi Greg > > Am 06.01.2015 um 02:54 schrieb Greg KH: > > > > Is that where the kernel panics show the problem happens? Without them, > > there's nothing we can do to help out except randomly guess, sorry. > > well. at least xhci is contained

RE: PROBLEM: USB isochronous urb leak on EHCI driver

2015-01-06 Thread Michael Tessier
> > > > That is interresting, however, I have an older kernel running an > > > > OHCI driver which is able to handle 4 codecs. Same usb hardware > > > > (codecs and hub), but older kernel on a different CPU, with much > > > > less power. This makes me believe that there's a solution to make it

RE: PROBLEM: USB isochronous urb leak on EHCI driver

2015-01-06 Thread Michael Tessier
> > If sound is ok when using only 1 codec and becomes choppy when adding > > a second codec, then it means that this issue is still in the 3.x > > kernel. This answer will tell me if it is worth working on using a newer > > kernel or not. > > I have to say that I'm not a linux expert, so I see

RE: PROBLEM: USB isochronous urb leak on EHCI driver

2015-01-06 Thread Michael Tessier
> > > > Hi, > > > > > > > > I am dealing with a USB EHCI driver bug. Here is the info: > > > > > > > > My configuration: > > > > - > > > > > > > > Host: Freescale i.MX512 with ARM Cortex A8 (USB 2.0 host > > > > controller) Linux kernel: 2.6.31, using EHCI USB driver > > > > > >

RE: PROBLEM: USB isochronous urb leak on EHCI driver

2015-01-06 Thread Alan Stern
On Tue, 6 Jan 2015, Michael Tessier wrote: > > > That is interresting, however, I have an older kernel running an OHCI > > > driver which is able to handle 4 codecs. Same usb hardware (codecs and > > > hub), but older kernel on a different CPU, with much less power. This > > > makes me believe

Re: [PATCH 2/4] usb: XHCI: platform: Move the Marvell quirks after the enabling the clocks

2015-01-06 Thread Thomas Petazzoni
Dear Maxime Ripard, On Tue, 6 Jan 2015 16:45:08 +0100, Maxime Ripard wrote: > + if (of_device_is_compatible(pdev->dev.of_node, > + "marvell,armada-375-xhci") || > + of_device_is_compatible(pdev->dev.of_node, > + "marvell

Re: Difference between run time and normal suspend

2015-01-06 Thread Alan Stern
On Tue, 6 Jan 2015, vichy wrote: > >> But I cannot see the keyboard go to suspend even I force autosuspend as 0. > >> is there any other way to trigger runtime suspend immediately instead > >> of waiting kernel judge it is idle for a while? > > > > There may be other reasons why the keyboard does

Re: [PATCH 2/2 resend v2] USB: host: Introduce flag to enable use of 64-bit dma_mask for ehci-platform

2015-01-06 Thread Alan Stern
On Tue, 6 Jan 2015, Andreas Herrmann wrote: > ehci-octeon driver used a 64-bit dma_mask. With removal of ehci-octeon > and usage of ehci-platform ehci dma_mask is now limited to 32 bits > (coerced in ehci_platform_probe). > > Provide a flag in ehci platform data to allow use of 64 bits for > dma_

[PATCH 1/4] usb: phy: Fix deferred probing

2015-01-06 Thread Maxime Ripard
Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on failure") actually broke the deferred probing mechanism, since it now returns EPROBE_DEFER only when the try_module_get call fails, but not when the phy lookup does. All the other similar functions seem to return ENODEV when

[PATCH 4/4] ARM: mvebu: armada-385-ap: Enable USB3 port

2015-01-06 Thread Maxime Ripard
The Armada 385 AP board has a USB3 port exposed that uses a GPIO to drive the VBUS line. Enable the needed drivers to support this. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/armada-385-ap.dts | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm/boot

[PATCH 3/4] usb: xhci: plat: Add USB phy support

2015-01-06 Thread Maxime Ripard
The Marvell Armada 385 AP needs a dumb phy in order to enable the USB3 VBUS. Add a call to retrieve a USB PHY to XHCI plat in order to support this. Signed-off-by: Maxime Ripard --- drivers/usb/host/xhci-plat.c | 13 + drivers/usb/host/xhci.h | 2 ++ 2 files changed, 15 insert

[PATCH 2/4] usb: XHCI: platform: Move the Marvell quirks after the enabling the clocks

2015-01-06 Thread Maxime Ripard
The commit 973747928514 ("usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers") extended the xhci-plat driver to support the Armada 375/38x SoCs, mostly by adding a quirk configuring the MBUS window. However, that quirk was run before the clock the controllers needs has been

[PATCH 0/4] ARM: mvebu: Enable XHCI on the A385-AP

2015-01-06 Thread Maxime Ripard
Hi all, This serie enables the Armada 385 AP XHCI controller. Since the controller uses a GPIO-controlled VBUS, we used the phy-generic driver, and made the needed additions to the xhci-plat driver to retrieve a USB phy. Unfortunately, some glitches were also found along the way, mostly because

Re: [PATCHv2 1/2] usb: ohci-platform: add support for multiple phys per controller

2015-01-06 Thread Alan Stern
On Thu, 11 Dec 2014 arun.ramamur...@broadcom.com wrote: > From: Arun Ramamurthy > > Added support for cases where one controller is connected > to multiple phys Will this continue to work on systems that use only one PHY? What about systems that don't use DT? > diff --git a/drivers/usb/host/o

Re: [PATCH] USB: cp210x: add IDs for CEL USB sticks and MeshWorks devices

2015-01-06 Thread Johan Hovold
On Tue, Jan 06, 2015 at 03:00:52PM +, Peterson, David wrote: > From: David Peterson > > Added virtual com port VID/PID entries for CEL USB sticks and MeshWorks > devices > > Signed-off-by: David Peterson Applied, thanks. Johan > --- > drivers/usb/serial/cp210x.c | 3 +++ > 1 file chang

Re: [PATCH] snd-usb-audio: Add support for Akai MPC Element MIDI controller

2015-01-06 Thread Paul Bonser
On 01/06/2015 07:39 AM, Clemens Ladisch wrote: > Paul Bonser wrote: >> This device incorrectly reports its bInterfaceClass as 255, when it >> should really be 1 (USB_CLASS_AUDIO). >> >> +++ b/sound/usb/quirks-table.h >> +{ >> +/* Akai MPC Element */ >> +USB_DEVICE(0x09e8, 0x0021), >> +.

Re: Difference between run time and normal suspend

2015-01-06 Thread vichy
hi Alan: 2015-01-06 23:03 GMT+08:00 Alan Stern : > On Tue, 6 Jan 2015, vichy wrote: > >> I use keyboard, it should be default support runtime suspend, for >> testing runtime suspend like the attach log. >> insert related modules, change related suspend parameters. >> >> But I cannot see the keyboa

Re: Difference between run time and normal suspend

2015-01-06 Thread Alan Stern
On Tue, 6 Jan 2015, vichy wrote: > > I use keyboard, it should be default support runtime suspend, for > > testing runtime suspend like the attach log. > > insert related modules, change related suspend parameters. > > > > But I cannot see the keyboard go to suspend even I force autosuspend as 0.

Re: Difference between run time and normal suspend

2015-01-06 Thread Alan Stern
On Tue, 6 Jan 2015, vichy wrote: > I use keyboard, it should be default support runtime suspend, for > testing runtime suspend like the attach log. > insert related modules, change related suspend parameters. > > But I cannot see the keyboard go to suspend even I force autosuspend as 0. > is ther

Re: Difference between run time and normal suspend

2015-01-06 Thread Alan Stern
On Tue, 6 Jan 2015, vichy wrote: > The mouse will reconnect even I just kept it connected and not moving it. > is there any method or debug message we can tell what is going on to > make it resume? usbmon. My guess is that the mouse disconnects and reconnects all by itself after a few seconds of

USB 3.0 storage keep reconnecting after safely removed

2015-01-06 Thread Taegil Bae
Hi all, Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=90791 My machine is Thinkpad Yoga with Onelink dock attached. Onelink dock is a USB 3.0 dock functioning as a USB 3.0 hub. This has two USB 3.0 ports in front. I connected a USB HDD enclosure to one of those ports. After use, I safely

[PATCH v2 3/5] ARM: at91/dt: update udc compatible strings

2015-01-06 Thread Boris Brezillon
at91sam9g45, at91sam9x5 and sama5 SoCs should not use "atmel,at91sam9rl-udc" for their USB device compatible property since this compatible is attached to a specific hardware bug fix. Signed-off-by: Boris Brezillon --- arch/arm/boot/dts/at91sam9g45.dtsi | 2 +- arch/arm/boot/dts/at91sam9x5.dtsi

[PATCH v2 4/5] usb: atmel_usba_udc: Mask status with enabled irqs

2015-01-06 Thread Boris Brezillon
Avoid interpreting useless status flags when we're not waiting for such events by masking the status variable with the interrupt enabled register value. Reported-by: Patrice VILCHEZ Signed-off-by: Boris Brezillon --- drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +- 1 file changed, 5 insertio

[PATCH v2 2/5] usb: atmel_usba_udc: Add at91sam9g45 and at91sam9x5 errata handling

2015-01-06 Thread Boris Brezillon
at91sam9g45 and at91sam9x5 SoCs have an hardware bug forcing us to generate a pulse on the BIAS signal on "USB end of reset” and “USB end of resume" events. Reported-by: Patrice VILCHEZ Signed-off-by: Boris Brezillon --- drivers/usb/gadget/udc/atmel_usba_udc.c | 28 +++-

[PATCH v2 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling

2015-01-06 Thread Boris Brezillon
at91sam9rl SoC has an erratum forcing us to toggle the BIAS on USB suspend/resume events. This specific handling is only activated when CONFIG_ARCH_AT91SAM9RL is set and this option is only set when building a non-DT kernel, which is problematic since non-DT support for at91sam9rl SoC has been rem

[PATCH v2 5/5] usb: gadget: atmel_usba: Cache INT_ENB register value

2015-01-06 Thread Boris Brezillon
Cache INT_ENB register value in order to avoid uncached iomem access, and thus improve access time to INT_ENB value. Signed-off-by: Boris Brezillon --- drivers/usb/gadget/udc/atmel_usba_udc.c | 52 ++--- drivers/usb/gadget/udc/atmel_usba_udc.h | 2 ++ 2 files changed

[PATCH v2 0/5] usb: atmel_usba_udc: Rework errata handling

2015-01-06 Thread Boris Brezillon
Hello, Here is a set of patches porting existing at91sam9rl erratum handling to DT and adding new code to handle at91sam9g45/9x5 erratum. It also adds several compatible strings to differentiate those errata. These patches should be backported to 3.17 and 3.18 stable releases but they do not appl

Re: [PATCH] snd-usb-audio: Add support for Akai MPC Element MIDI controller

2015-01-06 Thread Clemens Ladisch
Paul Bonser wrote: > This device incorrectly reports its bInterfaceClass as 255, when it > should really be 1 (USB_CLASS_AUDIO). > > +++ b/sound/usb/quirks-table.h > +{ > + /* Akai MPC Element */ > + USB_DEVICE(0x09e8, 0x0021), > + .bInterfaceClass = USB_CLASS_AUDIO, > +}, This is not

[PATCH 0/2 resend v2] USB: host: Misc patches to remove hard-coded octeon platform information

2015-01-06 Thread Andreas Herrmann
This is a re-submission of patches 2 and 3 from http://marc.info/?i=1415914590-31647-1-git-send-email-andreas.herrm...@caviumnetworks.com (Only patch 1/3 made it into usb-next and meanwhile is in mainline.) Please apply. Thanks, Andreas PS: It's v2 as with last submission I hit the merge windo

Re: [PATCH 0/2 resend v2] USB: host: Misc patches to remove hard-coded octeon platform information

2015-01-06 Thread Andreas Herrmann
On Tue, Jan 06, 2015 at 01:46:44PM +0100, Andreas Herrmann wrote: > This is a re-submission of patches 2 and 3 from > http://marc.info/?i=1415914590-31647-1-git-send-email-andreas.herrm...@caviumnetworks.com > (Only patch 1/3 made it into usb-next and meanwhile is in mainline.) > > Please apply. >

[PATCH 2/2 resend v2] USB: host: Introduce flag to enable use of 64-bit dma_mask for ehci-platform

2015-01-06 Thread Andreas Herrmann
ehci-octeon driver used a 64-bit dma_mask. With removal of ehci-octeon and usage of ehci-platform ehci dma_mask is now limited to 32 bits (coerced in ehci_platform_probe). Provide a flag in ehci platform data to allow use of 64 bits for dma_mask. Cc: David Daney Cc: Alex Smith Cc: Alan Stern S

[PATCH 1/2 resend v2] USB: host: Remove hard-coded octeon platform information for ehci/ohci

2015-01-06 Thread Andreas Herrmann
Instead rely on device tree information for ehci and ohci. This was suggested with http://www.linux-mips.org/cgi-bin/mesg.cgi?a=linux-mips&i=1401358203-60225-4-git-send-email-alex.smith%40imgtec.com "The device tree will *always* have correct ehci/ohci clock configuration, so use it. This al

Re: Difference between run time and normal suspend

2015-01-06 Thread vichy
hi all: 2015-01-06 16:06 GMT+08:00 vichy : > hi alan: > > 2015-01-06 8:39 GMT+08:00 vichy : >> 2015-01-05 23:40 GMT+08:00 Alan Stern : >>> On Mon, 5 Jan 2015, vichy wrote: >>> hi all: after tracing and reading kernel usb source code about run time and normal suspend. 1. how cou

Re: kernel panic with USB3+DVB+ARM

2015-01-06 Thread JPT
Hi Greg Am 06.01.2015 um 02:54 schrieb Greg KH: > > Is that where the kernel panics show the problem happens? Without them, > there's nothing we can do to help out except randomly guess, sorry. well. at least xhci is contained in the call stack: > [] (crc32_be) from [] (dvb_dmx_crc32+0x10/0x18

[patch] usb: gadget: gadgetfs: fix an oops in ep_write()

2015-01-06 Thread Dan Carpenter
We try to free an ERR_PTR on this error path. Fixes: b44be2462dbe ('usb: gadget: gadgetfs: Free memory allocated by memdup_user()') Signed-off-by: Dan Carpenter diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index 0804861..db49ec4 100644 --- a/drivers/usb/ga

Re: [PATCH] usb: phy: Restore deferred probing path

2015-01-06 Thread Thierry Reding
On Mon, Jan 05, 2015 at 12:33:51PM -0700, Stephen Warren wrote: > On 12/23/2014 11:36 AM, Felipe Balbi wrote: > >On Thu, Dec 04, 2014 at 01:06:07PM +0100, Thierry Reding wrote: > >>From: Thierry Reding > >> > >>Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on > >>failure")

Re: qcserial: AT unsolicited response codes missing with Sierra Wireless MC7304

2015-01-06 Thread Johan Hovold
On Tue, Jan 06, 2015 at 09:58:40AM +0100, Bjørn Mork wrote: > Johan Hovold writes: > > > Ok, let's move the PID to option and if it turns out that more of these > > devices require the modem-control signals (e.g. with more recent > > firmware) we can consider moving it back after adding such supp

[PATCH net] r8152: support ndo_features_check

2015-01-06 Thread Hayes Wang
Support ndo_features_check to avoid: - the transport offset is more than the hw limitation when using hw checksum. - the skb->len of a GSO packet is more than the limitation. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 17 + 1 file changed, 17 insertions(+) diff --

Re: qcserial: AT unsolicited response codes missing with Sierra Wireless MC7304

2015-01-06 Thread Bjørn Mork
Johan Hovold writes: > Ok, let's move the PID to option and if it turns out that more of these > devices require the modem-control signals (e.g. with more recent > firmware) we can consider moving it back after adding such support to > qcserial. > > Bjørn, do you see any problems with this? Are

RE: [PATCH v2] renesas_usbhs: fix platform init error message

2015-01-06 Thread yoshihiro shimoda
Hi Greet-san, > > Hi Shimoda-san, > > On Wed, Dec 24, 2014 at 11:02 AM, yoshihiro shimoda > wrote: > >> > > Er, OK. Could you update MAINTAINERS? > >> > there is no entry for renesas driver in MAINTAINERS. > >> > Shimoda-san, care to send a patch adding yourself or Morimoto-san

Re: qcserial: AT unsolicited response codes missing with Sierra Wireless MC7304

2015-01-06 Thread Johan Hovold
On Mon, Jan 05, 2015 at 10:12:33PM +0100, Reinhard Speyerer wrote: > Johan Hovold wrote: > > > On Sat, Dec 27, 2014 at 10:54:09PM +0100, Reinhard Speyerer wrote: > > > Reinhard Speyerer wrote: > > > > Johan Hovold wrote: > > > > > On Sun, Dec 21, 2014 at 11:25:45PM +0100, Reinhard Speyerer wrot

Re: Difference between run time and normal suspend

2015-01-06 Thread vichy
hi alan: 2015-01-06 8:39 GMT+08:00 vichy : > 2015-01-05 23:40 GMT+08:00 Alan Stern : >> On Mon, 5 Jan 2015, vichy wrote: >> >>> hi all: >>> after tracing and reading kernel usb source code about run time and >>> normal suspend. >>> 1. how could we check the rum time suspend is work on some device?