Re: [PATCH RFC] usb: chipidea: add support for usb_phy in generic usb2

2015-01-04 Thread Baruch Siach
Hi Kishon, On Mon, Jan 05, 2015 at 11:09:35AM +0530, Kishon Vijay Abraham I wrote: > On Sunday 04 January 2015 11:58 AM, Baruch Siach wrote: > > Signed-off-by: Baruch Siach > > --- > > drivers/usb/chipidea/ci_hdrc_usb2.c | 5 + > > 1 file changed, 5 insertions(+) > > > > I'm sending this as

Re: [PATCH RFC] usb: chipidea: add support for usb_phy in generic usb2

2015-01-04 Thread Kishon Vijay Abraham I
Hi, On Sunday 04 January 2015 11:58 AM, Baruch Siach wrote: > Signed-off-by: Baruch Siach > --- > drivers/usb/chipidea/ci_hdrc_usb2.c | 5 + > 1 file changed, 5 insertions(+) > > I'm sending this as RFC as I'm not sure this is the right thing to do. There > seems to be a move away from USB

Re: [PATCH] Use memzero_explicit to clear local buffers

2015-01-04 Thread Herbert Xu
On Sun, Jan 04, 2015 at 11:49:09PM +0100, Giel van Schijndel wrote: > > > sctx does not point to stack memory so this is bogus. > > > > Only stack memory cleared just before it goes out of scope needs > > memzero_explicit. > > Is that because the compiler can't safely optimize memset(0) away for

Re: [PATCH] Use memzero_explicit to clear local buffers

2015-01-04 Thread Giel van Schijndel
On Sun, Jan 04, 2015 at 19:05:40 +0100, Giel van Schijndel wrote: > When leaving a function use memzero_explicit instead of memset(0) to > clear locally allocated/owned buffers. memset(0) may be optimized away. > > All of the affected buffers contain sensitive data, key material or > derivatives o

Re: [PATCH] Use memzero_explicit to clear local buffers

2015-01-04 Thread Giel van Schijndel
On Mon, Jan 05, 2015 at 08:35:38 +1100, Herbert Xu wrote: > On Sun, Jan 04, 2015 at 07:05:40PM +0100, Giel van Schijndel wrote: >> When leaving a function use memzero_explicit instead of memset(0) to >> clear locally allocated/owned buffers. memset(0) may be optimized away. >> >> All of the affect

Re: [PATCH] Use memzero_explicit to clear local buffers

2015-01-04 Thread Herbert Xu
On Sun, Jan 04, 2015 at 07:05:40PM +0100, Giel van Schijndel wrote: > When leaving a function use memzero_explicit instead of memset(0) to > clear locally allocated/owned buffers. memset(0) may be optimized away. > > All of the affected buffers contain sensitive data, key material or > derivatives

[PATCH] Use memzero_explicit to clear local buffers

2015-01-04 Thread Giel van Schijndel
When leaving a function use memzero_explicit instead of memset(0) to clear locally allocated/owned buffers. memset(0) may be optimized away. All of the affected buffers contain sensitive data, key material or derivatives of one of those two. --- arch/x86/crypto/sha256_ssse3_glue.c | 2 +- drivers

[PATCH] USB: option: clean up blacklist handling

2015-01-04 Thread Johan Hovold
Clean up the unnecessarily complicated blacklist implementation somewhat. Signed-off-by: Johan Hovold --- drivers/usb/serial/option.c | 60 +++-- 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a/drivers/usb/serial/option.c b/drivers/usb/seri

Re: qcserial: AT unsolicited response codes missing with Sierra Wireless MC7304

2015-01-04 Thread Johan Hovold
On Sat, Dec 27, 2014 at 10:54:09PM +0100, Reinhard Speyerer wrote: > Reinhard Speyerer wrote: > > Johan Hovold wrote: > > > On Sun, Dec 21, 2014 at 11:25:45PM +0100, Reinhard Speyerer wrote: > With the qcserial.c patch below (for Linux kernel 3.16.3) I was able to > verify that adding the send_s

Re: qcserial: AT unsolicited response codes missing with Sierra Wireless MC7304

2015-01-04 Thread Johan Hovold
On Tue, Dec 23, 2014 at 07:48:30PM +0100, Reinhard Speyerer wrote: > Johan Hovold wrote: > > > From comparing option.c and qcserial.c the only difference in > > > initialization visible to me is the option_send_setup code. The > > > proposed patch below for kernel 3.19 or later moves Sierra Wire