Re: [PATCH 0/3] usb: chipidea: add one errata for revision 2.40a

2014-12-23 Thread Sanchayan Maity
On 12/23/2014 05:39 AM, Peter Chen wrote: > On Mon, Dec 22, 2014 at 06:39:42PM +0530, Sanchayan Maity wrote: >> On 12/22/2014 06:48 AM, Peter Chen wrote: >>> On Fri, Dec 19, 2014 at 03:25:26PM +0530, Sanchayan Maity wrote: The first two patches add identification register API's. These can >>>

regression: Wrong device reset in port_event()

2014-12-23 Thread Zhuang Jin Can
Hi Hans de Goede, Sarah, Mathias, This is about a regression caused by commit a82b76f7f usb: Reset USB-3 devices on USB-3 link bounce. When we do some stress remote wakeup tests with usb3 internal roothub autosuspend enabled, it's found that hub thread calling the port_event() may run before hand

[PATCH 2/2] usb: phy: phy-mxs-usb: do not depend on speed for disconnect notifier

2014-12-23 Thread Peter Chen
For some user cases, like plug out and replug in usb device during the system suspend, the speed negotiation will be error due to host doesn't know the device's disconnection, and it still hopes the high speed device, but the device backs to "powered" state which its high speed termination is not e

[PATCH 1/3] usb: chipidea: clear otg interrupt status for otg capable controller

2014-12-23 Thread Peter Chen
We need to do it for all otg capable controller, not only peripheral featured otg capable controller, otherwise, the host-only role, but otg capable controller may be responded by otg interrupt. Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c | 9 + 1 file changed, 5 insertions

[PATCH 3/3] usb: chipidea: usbmisc_imx: add imx6sx initialization routine

2014-12-23 Thread Peter Chen
Except the same process with earlier imx6, it has below two features: - Choose which vbus voltage as vbus wakeup source We choose B_SESSION_VALID as vbus wakeup source since when the system goes to suspend, the vbus comparator can't compare the vbus voltage for VBUS_VALID. - Disable dp/dm (linest

[PATCH 1/2] usb: phy: phy-mxs-usb: add power down and disable wakeup for .shutdown

2014-12-23 Thread Peter Chen
When we shut down the PHY, we need to power down all PHY's functions as well as disable wakeup, it is the opposite operation we do at .init. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/phy/phy-mxs-usb.c

[PATCH 2/3] doc: usb: usbmisc-imx: add imx6sx compatible string

2014-12-23 Thread Peter Chen
Add compatible string for imx6sx-usbmisc. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/usbmisc-imx.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt index c

[PATCH 4/6] usb: chipidea: add usb as system wakeup source

2014-12-23 Thread Peter Chen
The USB signal can be system wakeup source, this patch add the support, for how to enable it, see Documentation/usb/chipidea.txt. Since USB wakeup enable logic is vendor/platform specific, the glue layer needs to implement it to support this feature. Signed-off-by: Peter Chen --- drivers/usb/chi

[PATCH 1/6] usb: chipidea: add runtime power management support

2014-12-23 Thread Peter Chen
Add runtime power management support. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci.h| 6 +++ drivers/usb/chipidea/core.c | 100 --- drivers/usb/chipidea/otg.c | 2 + include/linux/usb/chipidea.h | 1 + 4 files changed, 103 insertions(

[PATCH 6/6] doc: usb: chipidea: add usb wakeup enable example

2014-12-23 Thread Peter Chen
Add the example for how to enable USB as system wakeup source. Signed-off-by: Peter Chen --- Documentation/usb/chipidea.txt | 21 + 1 file changed, 21 insertions(+) diff --git a/Documentation/usb/chipidea.txt b/Documentation/usb/chipidea.txt index 995c8bc..3f848c1 100644 ---

[PATCH 3/6] usb: chipidea: imx: add runtime power management support

2014-12-23 Thread Peter Chen
Add runtime pm support for imx, only imx6 series are supported and tested. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 106 ++--- 1 file changed, 100 insertions(+), 6 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/u

[PATCH 2/6] usb: chipidea: usbmisc_imx: add .set_wakeup interface

2014-12-23 Thread Peter Chen
This API is used to enable/disable usb wakeup, only imx6 series are added, since I don't have other imx hardware on hand. Other imx users can add their API according to reference manual after testing. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.h | 1 + drivers/usb/chipidea/u

[PATCH 5/6] usb: chipidea: imx: add usb as system wakeup source

2014-12-23 Thread Peter Chen
Enable USB as system wakeup source, and each platform needs to implement imx_usbmisc_set_wakeup in usbmisc_imx.c to support. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/d

[PATCH 0/6] chipidea: add runtime pm and usb wakeup

2014-12-23 Thread Peter Chen
Hi all, This is enhancement for "usb: chipidea: add runtime power management support" (http://www.spinics.net/lists/linux-usb/msg118987.html), it adds - USB as wakeup source support - Fix system hang when unload module The runtime pm close the clock before access hardware registers. - Fix system h

[PATCH v2 1/4] ARM: dts: Add exynos_usbphy node for exynos3250

2014-12-23 Thread Jaewon Kim
This patch adds device tree node for exynos_usbphy to use USB 2.0 Device. Signed-off-by: Jaewon Kim --- arch/arm/boot/dts/exynos3250.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 2246549..27d385

[PATCH v2 0/4] ARM: dts: Add USB node for exynos3250 SoC boards

2014-12-23 Thread Jaewon Kim
This patch series adds USB device node and phy for exynos3250 SoC. And enables for rinato and monk boards. Changes in v2: - remove unnessasary property "samsung,sysreg-phandle" - change "xusbxti" clock to "CLK_SCLK_UPLL" Jaewon Kim (4): ARM: dts: Add exynos_usbphy node for exynos3250 ARM: d

[PATCH v2 3/4] ARM: dts: Enable USB node for exynos3250-rinato

2014-12-23 Thread Jaewon Kim
This patch enables hsotg and usbphy node to use USB 2.0 Device. Signed-off-by: Jaewon Kim --- arch/arm/boot/dts/exynos3250-rinato.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts index 80aa8b4

[PATCH v2 4/4] ARM: dts: Enable USB node for exynos3250-monk

2014-12-23 Thread Jaewon Kim
This patch adds device tree node for hsotg to control USB 2.0 Device. Signed-off-by: Jaewon Kim --- arch/arm/boot/dts/exynos3250-monk.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts index 24822aa

[PATCH v2 2/4] ARM: dts: Add hsotg node for exynos3250

2014-12-23 Thread Jaewon Kim
This patch adds device tree node for hsotg to control USB 2.0 Device. Signed-off-by: Jaewon Kim --- arch/arm/boot/dts/exynos3250.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 27d385f..204a84b 1

Re: [PATCH] usb: gadget: ffs: Fix sparse error

2014-12-23 Thread Joe Perches
On Wed, 2014-12-24 at 10:59 +0530, Rohith Seelaboyina wrote: > Dynamic memory allocation through kmalloc is more safer > than declaring variable array size, Fix this error by > using kmalloc for memory allocation, Check if memory > allocation is successful and return -ENOMEM on failure. [] > diff -

[PATCH] usb: gadget: ffs: Fix sparse error

2014-12-23 Thread Rohith Seelaboyina
This patch fixes the sparse error in functionfs driver. drivers/usb/gadget/function/f_fs.c:400:44: error: bad constant experssion. Dynamic memory allocation through kmalloc is more safer than declaring variable array size, Fix this error by using kmalloc for memory allocation, Check if memory all

[PATCH 1/1] Revert "usb: chipidea: remove duplicate dev_set_drvdata for host_start"

2014-12-23 Thread Peter Chen
This reverts commit 14b4099c074f2ddf4d84b22d370170e61b527529 It moved platform_set_drvdata(pdev, ci) before hcd is created, and the hcd will assign itself as ci controller's drvdata during the hcd creation function (in usb_create_shared_hcd), so it overwrites the real ci's drvdata which we want to

[PATCH 0/1] usb: chipidea: one bug fix for v3.19

2014-12-23 Thread Peter Chen
Hi Greg, It causes oops during the system suspend routine at host mode sometimes. Peter Chen (1): Revert "usb: chipidea: remove duplicate dev_set_drvdata for host_start" drivers/usb/chipidea/core.c | 2 +- drivers/usb/chipidea/host.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread Peter Chen
On Tue, Dec 23, 2014 at 11:40:23AM -0800, David Cohen wrote: > Hi Peter, > > Thanks for the review. > > On Tue, Dec 23, 2014 at 09:25:18AM +0800, Peter Chen wrote: > > On Mon, Dec 22, 2014 at 02:43:37PM -0800, David Cohen wrote: > > > Some platforms have an USB OTG port fully (or partially) contr

Re: Query regarding root hub reset

2014-12-23 Thread Peter Chen
On Tue, Dec 23, 2014 at 03:15:45PM -0500, Alan Stern wrote: > On Tue, 23 Dec 2014, Peter Chen wrote: > > > > The Linux USB stack supports turning off port power only under a very > > > limited > > > set of conditions. For example, if the port is hard-wired or not > > > connected at all, > > > a

Re: USB Creative Soundcard non-functioning on 3.13 kernel and above

2014-12-23 Thread robtongue
On Tuesday 23 December 2014 15:06:17 Alan Stern wrote: > On Mon, 22 Dec 2014 robton...@gmail.com wrote: > > Ok I tried that kernel option first, and that actually worked without > > issue. I then tried your patch without that kernel option set, and it > > also worked. Finally I tried that kernel op

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-23 Thread Wu, Songjun
在 12/24/2014 00:24, Felipe Balbi 写道: On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: When unloading the module, the urb request will be dequeued and the completion routine will be excuted. If no urb packet, the urb request will not be added to the endpoint queue and the completion r

Re: [PATCH v2] renesas_usbhs: fix platform init error message

2014-12-23 Thread Felipe Balbi
On Tue, Dec 23, 2014 at 10:41:49PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/23/2014 10:17 PM, Felipe Balbi wrote: > > [...] > > >There is a typo ("prove" instead of "probe") in the error message > >printed when > >the platform initialization fails. Replace that w

Re: [PATCH v2 05/22] usb: isp1760: Merge platform and OF glue codes

2014-12-23 Thread Felipe Balbi
On Tue, Dec 23, 2014 at 12:47:42PM -0600, Felipe Balbi wrote: > On Mon, Dec 01, 2014 at 09:47:06PM +0200, Laurent Pinchart wrote: > > Both handle platform devices, merge them. > > > > Signed-off-by: Laurent Pinchart > > doesn't apply: > > checking file drivers/usb/host/isp1760-if.c > Hunk #1 FA

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread Felipe Balbi
Hi, On Mon, Dec 22, 2014 at 02:43:37PM -0800, David Cohen wrote: > Some platforms have an USB OTG port fully (or partially) controlled by > GPIOs: > > (1) USB ID is connected directly to GPIO > > Optionally: > (2) VBUS is enabled by a GPIO (when ID is grounded) ok, so a fixed regulator with a G

Re: [GIT PULL] USB patches

2014-12-23 Thread Greg KH
On Tue, Dec 23, 2014 at 10:53:11AM -0600, Felipe Balbi wrote: > Hi Greg, > > Here's my first set of fixes for v3.19-rc cycle. An early > Winter Solstice gift for you. > > All patches have gone through my 300 randconfigs (no build > breakages or new warnings found) and I boot tested with > AM437x

Re: [PATCH v5] usb: gadget: f_fs: add "no_disconnect" mode

2014-12-23 Thread Felipe Balbi
On Tue, Dec 23, 2014 at 12:47:55PM -0800, David Cohen wrote: > On Tue, Dec 23, 2014 at 12:48:58PM -0600, Felipe Balbi wrote: > > On Thu, Dec 18, 2014 at 09:55:10AM +0100, Robert Baldyga wrote: > > > Since we can compose gadgets from many functions, there is the problem > > > related to gadget break

Re: usb: musb: Scheduling of interrupt endpoints

2014-12-23 Thread Felipe Balbi
Hi, A: No. Q: Should I include quotations after my reply? On Tue, Dec 23, 2014 at 01:39:14PM -0600, Carsten Behling wrote: > The following comment can be found in 'musb_schedule()': > > '* REVISIT what we really want here is a regular schedule tree > * like e.g. OHCI uses.' > > So I assume the

Re: usb: musb: Scheduling of interrupt endpoints

2014-12-23 Thread Felipe Balbi
Hi, On Tue, Dec 23, 2014 at 02:16:57PM -0600, Carsten Behling wrote: > >On Tue, Dec 23, 2014 at 08:59:39AM -0600, Carsten Behling wrote: > >>Would it help if I send a patch as a suggestion and as basis for > >>discussion? > >yes, it would also help if you didn't top-post :-) > > > So would you sug

Re: [PATCH 06/17] net2280: Remove restart_dma inline function definition

2014-12-23 Thread Felipe Balbi
Hi, (top-post :-) On Tue, Dec 23, 2014 at 09:20:23PM +0100, Ricardo Ribalda Delgado wrote: > Hello Felipe > > I was waiting for more comments for the other patches and I forgot to > resend this patch. > > I am on holidays and without access to a computer with the right > tools, nevertheless , s

Re: Kernel 3.17.x Attaching Keyspan 4-Port Serial to USB Adapter Causes Kernel Panic

2014-12-23 Thread Richard
> So the same kernel is used (3.17.4), but only the new system oopses? Yes, using kernel.org's 3.17.4 on both systems, only the new Asus X99-A based system oopses. The older Asus P6X58D motherboard, running a very similarly configured 3.17.4 kernel has no issues with Keyspan USB adapter. > This

Re: [PATCH v5] usb: gadget: f_fs: add "no_disconnect" mode

2014-12-23 Thread David Cohen
On Tue, Dec 23, 2014 at 12:48:58PM -0600, Felipe Balbi wrote: > On Thu, Dec 18, 2014 at 09:55:10AM +0100, Robert Baldyga wrote: > > Since we can compose gadgets from many functions, there is the problem > > related to gadget breakage while FunctionFS daemon being closed. FFS > > function is userspa

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread David Cohen
On Tue, Dec 23, 2014 at 11:09:44PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/23/2014 10:57 PM, David Cohen wrote: > > >>>Some platforms have an USB OTG port fully (or partially) controlled by > >>>GPIOs: > > >>>(1) USB ID is connected directly to GPIO > > >>>Optionally: > >>>(2) VBUS is

Re: Query regarding root hub reset

2014-12-23 Thread Alan Stern
On Tue, 23 Dec 2014, Deepak Das wrote: > On 22 December 2014 at 22:13, Alan Stern wrote: > > On Mon, 22 Dec 2014, Deepak Das wrote: > > > >> Can somebody please help me to find the test-case/use-case of > >> following snippet of code in drivers/usb/core/hub.c:hub_port_connect() > >> :- > >> > >>

Re: [PATCH 06/17] net2280: Remove restart_dma inline function definition

2014-12-23 Thread Ricardo Ribalda Delgado
Hello Felipe I was waiting for more comments for the other patches and I forgot to resend this patch. I am on holidays and without access to a computer with the right tools, nevertheless , since the changes are only on the commit message I have modified the patch with vi. I have been very carefu

RE: [DISCUSSION] USB device remote wakeup is not working for S3 case

2014-12-23 Thread Alan Stern
On Tue, 23 Dec 2014, Du, Changbin wrote: > > You have to make sure that wakeup is also enabled for the host > > controller the device is attached to. For some host controllers, it > > may also be necessary to enable wakeup for the root hub. > > > Yes, the root-hub is not wakeup enabled by defaul

Re: usb: musb: Scheduling of interrupt endpoints

2014-12-23 Thread Carsten Behling
Hi Felipe, On 12/23/2014 12:27 PM, Felipe Balbi wrote: Hi, On Tue, Dec 23, 2014 at 08:59:39AM -0600, Carsten Behling wrote: Would it help if I send a patch as a suggestion and as basis for discussion? yes, it would also help if you didn't top-post :-) So would you suggestion be to port that

RE: Query regarding root hub reset

2014-12-23 Thread Alan Stern
On Tue, 23 Dec 2014, Peter Chen wrote: > > The Linux USB stack supports turning off port power only under a very > > limited > > set of conditions. For example, if the port is hard-wired or not connected > > at all, > > and if remote wakeup is not required. > > > > Alan, any reasons/limitatio

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread Sergei Shtylyov
Hello. On 12/23/2014 10:57 PM, David Cohen wrote: Some platforms have an USB OTG port fully (or partially) controlled by GPIOs: (1) USB ID is connected directly to GPIO Optionally: (2) VBUS is enabled by a GPIO (when ID is grounded) Can't the host driver still control Vbus? I ca

Re: USB Creative Soundcard non-functioning on 3.13 kernel and above

2014-12-23 Thread Alan Stern
On Mon, 22 Dec 2014 robton...@gmail.com wrote: > Ok I tried that kernel option first, and that actually worked without issue. > I > then tried your patch without that kernel option set, and it also worked. > Finally I tried that kernel option =y with your patch, and it worked as well. > >

Re: [xhci_hcd] USB3 device unplug breaks system suspend

2014-12-23 Thread Alan Stern
On Tue, 23 Dec 2014, Tobias Jakobi wrote: > > I don't know what would be appropriate. Someone more familiar with the > > xhci-hcd driver might be able to help. > > > > It's not always easy to tell why a device sends a wakeup signal. > Hmm, I got the impression that this issue is very similar to

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread David Cohen
Hi Sergei, On Tue, Dec 23, 2014 at 04:10:44PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/23/2014 1:43 AM, David Cohen wrote: > > >Some platforms have an USB OTG port fully (or partially) controlled by > >GPIOs: > > >(1) USB ID is connected directly to GPIO > > >Optionally: > >(2) VBUS is

Re: [PATCH v2] renesas_usbhs: fix platform init error message

2014-12-23 Thread Sergei Shtylyov
Hello. On 12/23/2014 10:17 PM, Felipe Balbi wrote: [...] There is a typo ("prove" instead of "probe") in the error message printed when the platform initialization fails. Replace that word with more fitting "init". Signed-off-by: Sergei Shtylyov this actually goes through me, I'll take

Re: usb: musb: Scheduling of interrupt endpoints

2014-12-23 Thread Carsten Behling
The following comment can be found in 'musb_schedule()': '* REVISIT what we really want here is a regular schedule tree * like e.g. OHCI uses.' So I assume the best practice would be to make an implementation based on the code in in ohci-q.c. And it would be waste of time to port the old interr

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread David Cohen
Hi Peter, Thanks for the review. On Tue, Dec 23, 2014 at 09:25:18AM +0800, Peter Chen wrote: > On Mon, Dec 22, 2014 at 02:43:37PM -0800, David Cohen wrote: > > Some platforms have an USB OTG port fully (or partially) controlled by > > GPIOs: > > > > (1) USB ID is connected directly to GPIO > >

Re: [PATCH v2] renesas_usbhs: fix platform init error message

2014-12-23 Thread Felipe Balbi
On Fri, Dec 12, 2014 at 10:45:26PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/05/2014 01:53 AM, Felipe Balbi wrote: > > >>There is a typo ("prove" instead of "probe") in the error message printed > >>when > >>the platform initialization fails. Replace that word with more fitting > >>"init

Re: [PATCH v2] renesas_usbhs: fix platform init error message

2014-12-23 Thread Felipe Balbi
On Fri, Dec 19, 2014 at 03:46:41PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/19/2014 4:33 AM, yoshihiro shimoda wrote: > > [...] > > >>>There is a typo ("prove" instead of "probe") in the error message > >>>printed when > >>>the platform initialization fails. Replace that wor

[PATCH] gadget: cleanup on stack DECLARE_COMPLETIONs

2014-12-23 Thread Nicholas Mc Guire
fixups for incorrect use of DECLARE_COMPLETION. see also commit 6e9a4738 ("completions: lockdep annotate on stack completions") patch is against 3.18.0 linux-next This was only code reviewed and compile tested Signed-off-by: Nicholas Mc Guire --- drivers/usb/gadget/udc/fsl_qe_udc.c |2 +-

Re: [PATCH v5] usb: gadget: f_fs: add "no_disconnect" mode

2014-12-23 Thread Felipe Balbi
On Thu, Dec 18, 2014 at 09:55:10AM +0100, Robert Baldyga wrote: > Since we can compose gadgets from many functions, there is the problem > related to gadget breakage while FunctionFS daemon being closed. FFS > function is userspace code so there is no way to know when it will close > files (it does

Re: qcserial: AT unsolicited response codes missing with Sierra Wireless MC7304

2014-12-23 Thread Reinhard Speyerer
Johan Hovold wrote: > On Sun, Dec 21, 2014 at 11:25:45PM +0100, Reinhard Speyerer wrote: > > > When using a MC7304 with firmware revision SWI9X15C_05.05.16.02 on > > Knoppix 7.4.2 with Linux kernel 3.16.3 and the qcserial driver I noticed > > that AT unsolicited response codes (URCs) like +CREG w

Re: [PATCH v2 05/22] usb: isp1760: Merge platform and OF glue codes

2014-12-23 Thread Felipe Balbi
On Mon, Dec 01, 2014 at 09:47:06PM +0200, Laurent Pinchart wrote: > Both handle platform devices, merge them. > > Signed-off-by: Laurent Pinchart doesn't apply: checking file drivers/usb/host/isp1760-if.c Hunk #1 FAILED at 12. Hunk #2 succeeded at 304 (offset -1 lines). Hunk #3 succeeded at 332

Re: [PATCH 06/17] net2280: Remove restart_dma inline function definition

2014-12-23 Thread Felipe Balbi
On Fri, Nov 28, 2014 at 11:16:16PM +0300, Sergei Shtylyov wrote: > On 11/28/2014 06:21 PM, Ricardo Ribalda Delgado wrote: > > >Thanks for reviewing. I will fix it and resend it on the next version > >of the patchset to avoid spamming the ML > > >I guess it is ok to add your Reviewed-by > >Ye

Re: USB OTG doesn't work in HOST mode on OMAP3 processor on 3.18-rc5

2014-12-23 Thread Felipe Balbi
Hi, (no top-posting) On Fri, Dec 19, 2014 at 12:16:04PM +0100, Eduard Gavin wrote: > Hi Everybody, > > After several test with IGEPv2 board (OMAP3) and linux kernel 3.17 and > 3.18, the OTG works but, (from my point of view) with an weird > behaviour. > > The OTG like a Host only is activated a

Re: [PATCH v2 0/3] usb: phy: generic: device-tree support

2014-12-23 Thread Felipe Balbi
On Mon, Dec 15, 2014 at 12:13:18AM +0100, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Hi Felipe, > > > > This is the 2nd opus of this serie. > > For patches 1 and 2, all comments have been addressed. > > > > For patch 3, you had a question about device charging spec and the regulator > >

Re: [PATCH] usb: phy: Restore deferred probing path

2014-12-23 Thread Felipe Balbi
On Thu, Dec 04, 2014 at 01:06:07PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on > failure") broke platforms that rely on deferred probing to order probing > of PHY and host controller drivers. The reason is that t

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-23 Thread Felipe Balbi
On Tue, Dec 23, 2014 at 07:34:15AM +0100, Robert Baldyga wrote: > Hi Felipe, > > On 12/22/2014 05:34 PM, Felipe Balbi wrote: > > On Mon, Dec 15, 2014 at 11:05:22AM +0100, Robert Baldyga wrote: > >> On 12/15/2014 06:13 AM, Peter Chen wrote: > >>> On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Bal

Re: usb: musb: Scheduling of interrupt endpoints

2014-12-23 Thread Felipe Balbi
Hi, On Tue, Dec 23, 2014 at 08:59:39AM -0600, Carsten Behling wrote: > Would it help if I send a patch as a suggestion and as basis for > discussion? yes, it would also help if you didn't top-post :-) -- balbi signature.asc Description: Digital signature

Re: [PATCH] cleanup on stack DECLARE_COMPLETIONs

2014-12-23 Thread Felipe Balbi
On Tue, Dec 23, 2014 at 06:34:08PM +0100, Nicholas Mc Guire wrote: > fixups for incorrect use of DECLARE_COMPLETION. see also commit > 6e9a4738 ("completions: lockdep annotate on stack completions") > The only somewhat special case being > drivers/misc/sgi-gru/grukservices.c:quicktest2 > which had

[PATCH] cleanup on stack DECLARE_COMPLETIONs

2014-12-23 Thread Nicholas Mc Guire
fixups for incorrect use of DECLARE_COMPLETION. see also commit 6e9a4738 ("completions: lockdep annotate on stack completions") The only somewhat special case being drivers/misc/sgi-gru/grukservices.c:quicktest2 which had a static qualifier in the original DECLARE_COMPLETION() but that seems to be

[GIT PULL] USB patches

2014-12-23 Thread Felipe Balbi
Hi Greg, Here's my first set of fixes for v3.19-rc cycle. An early Winter Solstice gift for you. All patches have gone through my 300 randconfigs (no build breakages or new warnings found) and I boot tested with AM437x SK, AM437x IDK, Beagle x15 and Beagle Bone Black. cheers The following chang

[PATCH] usb: dwc2: Fixed a few typos in comments

2014-12-23 Thread Mickael Maison
Fixed 3 typos in comments Signed-off-by: Mickael Maison --- drivers/usb/dwc2/core.c | 2 +- drivers/usb/dwc2/core.h | 2 +- drivers/usb/dwc2/gadget.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index 7605850b..d5197

[PATCH] usb: dwc3: Fixed a typo in comments

2014-12-23 Thread Mickael Maison
Fixed a typo in comments Signed-off-by: Mickael Maison --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index f03b136..bd9f48d 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadg

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-23 Thread Felipe Balbi
On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: > When unloading the module, the urb request will be dequeued > and the completion routine will be excuted. > If no urb packet, the urb request will not be added to the endpoint queue > and the completion routine pointer in urb request is

Re: [PATCH] usb: dwc3: Fixed a typo in comments

2014-12-23 Thread Felipe Balbi
On Tue, Dec 23, 2014 at 05:22:21PM +0100, Mickael Maison wrote: > Signed-off-by: Mickael Maison even obvious patches need a commit log, please write one and I'll certainly queue your patch. > --- > drivers/usb/dwc3/gadget.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] usb: dwc3: Fixed a typo in comments

2014-12-23 Thread Mickael Maison
Signed-off-by: Mickael Maison --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index f03b136..bd9f48d 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2077,7 +2077,7 @@

[PATCH] usb: dwc2: Fixed a few typos in comments

2014-12-23 Thread Mickael Maison
Signed-off-by: Mickael Maison --- drivers/usb/dwc2/core.c | 2 +- drivers/usb/dwc2/core.h | 2 +- drivers/usb/dwc2/gadget.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index 7605850b..d5197d4 100644 --- a/drivers/usb

Re: usb: musb: Scheduling of interrupt endpoints

2014-12-23 Thread Carsten Behling
Would it help if I send a patch as a suggestion and as basis for discussion? On 12/19/2014 01:38 PM, Carsten Behling wrote: Hi all, Long time ago, TI shipped a kernel named linux-2.6.32.17-psp03.01.01.39 with an additional kernel option for scheduling of interrupt endpoints. AFAIK, this seem

Re: [PATCH v1 11/29] usb: dwc2: gadget: configure fifos from device tree

2014-12-23 Thread Robert Baldyga
Hi, On 12/21/2014 05:15 PM, Mian Yousaf Kaukab wrote: > From: Gregory Herrero > > As fifo size can vary between SOCs, add possibility to configure > them from device tree. Fifo sizes used by the legacy driver will > be used If they are not provided by the device tree. > > Signed-off-by: Gregory

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread Sergei Shtylyov
Hello. On 12/23/2014 1:43 AM, David Cohen wrote: Some platforms have an USB OTG port fully (or partially) controlled by GPIOs: (1) USB ID is connected directly to GPIO Optionally: (2) VBUS is enabled by a GPIO (when ID is grounded) Can't the host driver still control Vbus? (3) Plat

Re: [PATCH v1 04/29] usb: dwc2: gadget: don't embed ep0 buffers

2014-12-23 Thread Robert Baldyga
Hi, On 12/21/2014 05:14 PM, Mian Yousaf Kaukab wrote: > When using DMA, data of the previous setup packet can be read back > from cache because ep0 and ctrl buffers are embedded in struct s3c_hsotg. > Allocate buffers instead of embedding them. > > Signed-off-by: Mian Yousaf Kaukab > --- > driv

[PATCH 2/4] ARM: dts: Add hsotg node for exynos3250

2014-12-23 Thread Jaewon Kim
This patch adds device tree node for hsotg to control USB 2.0 Device. Signed-off-by: Jaewon Kim --- arch/arm/boot/dts/exynos3250.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index d976007..e5c891a 1

[PATCH 3/4] ARM: dts: Enable USB node for exynos3250-rinato

2014-12-23 Thread Jaewon Kim
This patch enables hsotg and usbphy node to use USB 2.0 Device. Signed-off-by: Jaewon Kim --- arch/arm/boot/dts/exynos3250-rinato.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts index 80aa8b4

[PATCH 1/4] ARM: dts: Add exynos_usbphy node for exynos3250

2014-12-23 Thread Jaewon Kim
This patch adds device tree node for exynos_usbphy to use USB 2.0 Device. Signed-off-by: Jaewon Kim --- arch/arm/boot/dts/exynos3250.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 2246549..d9760

[PATCH 4/4] ARM: dts: Enable USB node for exynos3250-monk

2014-12-23 Thread Jaewon Kim
This patch adds device tree node for hsotg to control USB 2.0 Device. Signed-off-by: Jaewon Kim --- arch/arm/boot/dts/exynos3250-monk.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts index 24822aa

[PATCH 0/4] ARM: dts: Add USB node for exynos3250 SoC boards

2014-12-23 Thread Jaewon Kim
This patch series adds USB device node and phy for exynos3250 SoC. And enables for rinato and monk boards. Jaewon Kim (4): ARM: dts: Add exynos_usbphy node for exynos3250 ARM: dts: Add hsotg node for exynos3250 ARM: dts: Enable USB node for exynos3250-rinato ARM: dts: Enable USB node for e

RE: [PATCH 17/29] usb: dwc2: gadget: manage ep0 state in software

2014-12-23 Thread Kaukab, Yousaf
Hi, > -Original Message- > From: Kaukab, Yousaf > Sent: Thursday, December 18, 2014 7:54 PM > To: linux-usb@vger.kernel.org; ba...@ti.com > Cc: Herrero, Gregory; pa...@synopsys.com; Kaukab, Yousaf > Subject: [PATCH 17/29] usb: dwc2: gadget: manage ep0 state in software > > Manage ep0 stat

Re: qcserial: AT unsolicited response codes missing with Sierra Wireless MC7304

2014-12-23 Thread Johan Hovold
On Sun, Dec 21, 2014 at 11:25:45PM +0100, Reinhard Speyerer wrote: > When using a MC7304 with firmware revision SWI9X15C_05.05.16.02 on > Knoppix 7.4.2 with Linux kernel 3.16.3 and the qcserial driver I noticed > that AT unsolicited response codes (URCs) like +CREG were missing (the mobile > has b

Re: [PATCH] USB: serial: cp210x: Correcting IDs for production CEL MeshConnect USB Stick

2014-12-23 Thread Johan Hovold
On Sun, Dec 21, 2014 at 11:33:39PM -0600, Preston Fick wrote: Please add a proper commit message here describing why this is needed. Are there any devices with the original PID or was that just a typo? > Signed-off-by: Preston Fick > --- > drivers/usb/serial/cp210x.c | 2 +- > 1 file changed, 1

RE: [PATCH v1 16/29] usb: dwc2: gadget: kill requests after disabling ep

2014-12-23 Thread Kaukab, Yousaf
Hi, > -Original Message- > From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Tuesday, December 23, 2014 9:40 AM > To: Mian Yousaf Kaukab; linux-usb@vger.kernel.org; ba...@ti.com > Cc: Herrero, Gregory; pa...@synopsys.com; > sergei.shtyl...@cogentembedded.com; Kaukab, Yousaf > Sub

Re: [PATCH v2] OHCI: add a quirk for ULi M5237 blocking on reset

2014-12-23 Thread Nikita Yushchenko
> In my case root cause was elsewhere - USB port that I thought was driven > by ULI, actually was not. And ULI's builtin OHCI was not > hardware-enabled (but still was available on bus). I workarounded it by > masking entire device in platform-specific quirk. For reference, here is the patch that

Re: [PATCH v1 16/29] usb: dwc2: gadget: kill requests after disabling ep

2014-12-23 Thread Robert Baldyga
Hi, On 12/21/2014 05:15 PM, Mian Yousaf Kaukab wrote: > kill_all_requests() can flush the fifo. Call it after disabling the > endpoint. Moreover, remove even the current IN request so that next > IN request after s3c_hsotg_ep_enable can be properly handled. > > Signed-off-by: Mian Yousaf Kaukab