Re: [PATCH] usb: host: max3421-hcd: use time_after()

2014-12-14 Thread David Mosberger
Acked-by: David Mosberger On Mon, Dec 15, 2014 at 8:22 AM, Asaf Vertz wrote: > To be future-proof and for better readability the time comparisons are > modified to use time_after() instead of plain, error-prone math. > > Signed-off-by: Asaf Vertz > --- > drivers/usb/host/max3421-hcd.c |3 +

[PATCH] usb: host: max3421-hcd: use time_after()

2014-12-14 Thread Asaf Vertz
To be future-proof and for better readability the time comparisons are modified to use time_after() instead of plain, error-prone math. Signed-off-by: Asaf Vertz --- drivers/usb/host/max3421-hcd.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/max3421

Re: [sur40] Videobuf2 and/or DMA?

2014-12-14 Thread Florian Echtler
On 15.12.2014 04:24, Alan Stern wrote: > On Fri, 12 Dec 2014, Florian Echtler wrote: >> thanks - good to know for sure. AFAICT if I want to transfer bulk >> messages using DMA, I can't just use kalloc and usb_bulk_msg, but need >> usb_alloc_coherent, usb_fill_bulk_urb and usb_submit_urb, correct? >

Re: How do I begin?

2014-12-14 Thread Andrzej Pietrasiewicz
W dniu 13.12.2014 o 18:53, Vedant Nevetia pisze: Thanks a lot! How would you recommend I then go on to submit full-scale drivers? Should I read through the whole of LDD3 or is there another means to acquire the knowledge? What about this: http://eudyptula-challenge.org ? A quote from the said

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-14 Thread Peter Chen
On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Baldyga wrote: > As usb function drivers assumes that all usb request will be completed > before function unbind call, we should supply such behavior. In some > cases ep_disable() won't kill all request effectively, because some > IN requests can be

Re: [PATCH 2/3] usb: chipidea: usbmisc_imx: delete clock information

2014-12-14 Thread Peter Chen
On Fri, Dec 12, 2014 at 02:21:02PM +0100, Philipp Zabel wrote: > Hi Peter, > > Am Freitag, den 12.12.2014, 15:09 +0800 schrieb Peter Chen: > > All imx usb controller's non core registers uses the same clock gate with > > core registers, the usbmisc_imx is the library for imx glue driver, the > > g

Re: [sur40] Videobuf2 and/or DMA?

2014-12-14 Thread Alan Stern
On Fri, 12 Dec 2014, Florian Echtler wrote: > Hello Alan, > > On 11.12.2014 20:36, Alan Stern wrote: > > On Sun, 7 Dec 2014, Florian Echtler wrote: > >> - Can I always use DMA on the USB side (for bulk transfers), or does > >> this in any way require support from the USB device's hardware? (I'm >

Re: Query regarding USB gadget driver

2014-12-14 Thread Peter Chen
On Fri, Dec 12, 2014 at 06:55:36PM +0530, Sanchayan Maity wrote: > Hello, > > On 12/12/2014 07:21 AM, Peter Chen wrote: > > On Thu, Dec 11, 2014 at 08:34:45AM -0600, Felipe Balbi wrote: > >> Hi, > >> > >> On Thu, Dec 11, 2014 at 04:08:43PM +0530, Sanchayan Maity wrote: > >>> Hello, > >>> > >>> I a

Re: [GIT PULL] USB driver patches for 3.19-rc1

2014-12-14 Thread Linus Torvalds
On Sun, Dec 14, 2014 at 3:17 PM, Stephen Rothwell wrote: > > Attached is the message I sent about this on Nov 24 to which I received > no response and so assumed it was ok ... Looks like the same resolution I got. I'd still prefer to get an actual positive "yup, tested it" about it.

Re: [GIT PULL] USB driver patches for 3.19-rc1

2014-12-14 Thread Stephen Rothwell
Hi Linus, On Sun, 14 Dec 2014 15:06:07 -0800 Linus Torvalds wrote: > > On Sun, Dec 14, 2014 at 2:35 PM, Greg KH wrote: > > > > Hans de Goede (1): > > uas: Make uas work with blk-mq > > So I got some fairly trivial conflicts on this one (conflicting with > the scsi cleanups mainly by Chri

Re: [PATCH v2 0/3] usb: phy: generic: device-tree support

2014-12-14 Thread Robert Jarzmik
Robert Jarzmik writes: > Hi Felipe, > > This is the 2nd opus of this serie. > For patches 1 and 2, all comments have been addressed. > > For patch 3, you had a question about device charging spec and the regulator > timings. I read the specs, saw the 15mn timing you were speaking of, but > didn'

Re: [GIT PULL] USB driver patches for 3.19-rc1

2014-12-14 Thread Linus Torvalds
On Sun, Dec 14, 2014 at 2:35 PM, Greg KH wrote: > > Hans de Goede (1): > uas: Make uas work with blk-mq So I got some fairly trivial conflicts on this one (conflicting with the scsi cleanups mainly by Christoph Hellwig. I resolved the conflict easily, and it all *looks* fine, but quite fra

[GIT PULL] USB driver patches for 3.19-rc1

2014-12-14 Thread Greg KH
The following changes since commit 009d0431c3914de64666bec0d350e54fdd59df6a: Linux 3.18-rc7 (2014-11-30 16:42:27 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.19-rc1 for you to fetch changes up to 81e1dadfb5b2d47aa51

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-14 Thread George McCollister
Johan, While working on the tx_empty changes you suggested it occurred to me that it might not be obvious to others that the firmware doesn't send a packet with the NT124_CTRL_TXEMPTY flag cleared when it begins transmitting. The practical implication is that if the driver sets tx_empty = true whe