How do I begin?

2014-12-12 Thread Vedant Nevetia
Hello, I am sorry if this has been posted by someone else before. I'd really like some help. So a little background: I'm a 17 year old Linux enthusiast. I've always wanted to contribute in any way to the kernel. Now I feel I can, so I picked up LDD3. I have little knowledge when it comes to the h

Re: [PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-12 Thread Kishon Vijay Abraham I
hi, On Saturday 13 December 2014 05:49 AM, Doug Anderson wrote: > Yunzhi, > > On Fri, Dec 12, 2014 at 7:07 AM, Yunzhi Li wrote: >> This patch to add a generic PHY driver for ROCKCHIP usb PHYs, >> currently this driver can support RK3288. The RK3288 SoC have >> three independent USB PHY IPs which

query on DWC3

2014-12-12 Thread sundeep subbaraya
Hi Felipe, In DWC3 driver, for three stage Control OUT transfer there is a check: else if (!IS_ALIGNED(req->request.length, dep->endpoint.maxpacket) && (dep->number == 0)) {. } I understand that we check for alignment of sizes and if not we prepare trb with maxpacket and ena

Re: [PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-12 Thread Doug Anderson
Yunzhi, On Fri, Dec 12, 2014 at 7:07 AM, Yunzhi Li wrote: > This patch to add a generic PHY driver for ROCKCHIP usb PHYs, > currently this driver can support RK3288. The RK3288 SoC have > three independent USB PHY IPs which are all configured through a > set of registers located in the GRF (gener

[PATCH] renesas_usbhs: kill dead code in usbhs_probe()

2014-12-12 Thread Sergei Shtylyov
usbhsc_drvcllbck_notify_hotplug() always returns 0, so it's rather pointless to store and check its result for being < 0. Signed-off-by: Sergei Shtylyov --- This patch is against the 'next' branch of Felipe Balbi's 'usb.git' repo. drivers/usb/renesas_usbhs/common.c |6 +- 1 file change

Re: [PATCH v2] renesas_usbhs: fix platform init error message

2014-12-12 Thread Sergei Shtylyov
Hello. On 11/05/2014 01:53 AM, Felipe Balbi wrote: There is a typo ("prove" instead of "probe") in the error message printed when the platform initialization fails. Replace that word with more fitting "init". Signed-off-by: Sergei Shtylyov this actually goes through me, I'll take it in a

[PATCH] xhci: Check if slot is already in default state before moving it there

2014-12-12 Thread Mathias Nyman
Solves xhci error cases with debug messages: xhci_hcd :00:14.0: Setup ERROR: setup context command for slot 1. usb 1-6: hub failed to enable device, error -22 xhci will give a context state error if we try to set a slot in default state to the same default state with a special address device c

Re: [GIT PULL] USB driver fixes for 3.18-rc7

2014-12-12 Thread Mathias Nyman
On 11.12.2014 20:47, Greg KH wrote: > On Wed, Dec 03, 2014 at 06:02:08PM +0200, Mathias Nyman wrote: >> On 02.12.2014 20:18, Greg KH wrote: >>> On Sun, Nov 30, 2014 at 11:47:20AM -0800, Linus Torvalds wrote: Hmm, Greg. I seem to get this problem possibly more commonly at boot these d

RE: [PATCH v4 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

2014-12-12 Thread Muthu Mani
Hi, Thanks for reviewing the code. > > +/* > > + * It exposes sysfs entries under the i2c adapter for getting the i2c > > +transfer > > + * status, reset i2c read/write module, get/set nak and stop bits. > > + */ > > Yes, I see that. Yet, I don't know why they are needed? The driver should > know

[PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-12 Thread Yunzhi Li
Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li Acked-by: Paul Zimmerman --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Fix coding style: both branches of the if() which only one br

[PATCH] usb: usb-nop-xceiv.txt: Fix the description of 'vcc-supply'

2014-12-12 Thread Fabio Estevam
From: Fabio Estevam Since bd27fa44e13830d2b ("usb: phy: generic: Don't use regulator framework for RESET line") we no longer model the reset line as a regulator supply, so adapt the documentation accordingly. Signed-off-by: Fabio Estevam --- Documentation/devicetree/bindings/usb/usb-nop-xceiv

[PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-12 Thread Yunzhi Li
This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB PHY IPs which are all configured through a set of registers located in the GRF (general register files) module. Signed-off-by: Yunzhi Li --- Changes

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-12 Thread George McCollister
Johan, Thanks for the thorough review. On Wed, Dec 10, 2014 at 7:04 AM, Johan Hovold wrote: > On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote: >> This driver is for the NovaTech 124 4x serial expansion board for the >> NovaTech OrionLXm. >> >> Firmware source code can be found

[PATCH v7 0/5] Patches to add support for Rockchip usb PHYs.

2014-12-12 Thread Yunzhi Li
Patches to add support for Rockchip usb phys.Add a new Rockchip usb phy driver and modify dwc2 controller driver to make dwc2 platform devices support a generic PHY framework driver. This patch set has been tested on my rk3288-evb and power off the usb phys would reduce about 60mW power budget in

[PATCH v7 0/5] Patches to add support for Rockchip usb PHYs.

2014-12-12 Thread Yunzhi Li
Patches to add support for Rockchip usb phys.Add a new Rockchip usb phy driver and modify dwc2 controller driver to make dwc2 platform devices support a generic PHY framework driver. This patch set has been tested on my rk3288-evb and power off the usb phys would reduce about 60mW power budget in

Re: [PATCH] uas: disable UAS on Apricorn SATA dongles

2014-12-12 Thread Greg Kroah-Hartman
On Fri, Dec 12, 2014 at 11:42:12AM +0100, Hans de Goede wrote: > > > On 11-12-14 20:01, Darrick J. Wong wrote: > >The Apricorn SATA dongle will occasionally return "USBSUSBSUSB" in > >response to SCSI commands when running in UAS mode. Therefore, > >disable UAS mode on this dongle. > > > >Signed

RE: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-12 Thread Krzysztof Opasiak
> -Original Message- > From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Friday, December 12, 2014 2:17 PM > To: ba...@ti.com > Cc: gre...@linuxfoundation.org; peter.c...@freescale.com; linux- > u...@vger.kernel.org; linux-ker...@vger.kernel.org; > m.szyprow...@samsung.com; k.op

Re: Query regarding USB gadget driver

2014-12-12 Thread Sanchayan Maity
Hello, On 12/12/2014 07:21 AM, Peter Chen wrote: > On Thu, Dec 11, 2014 at 08:34:45AM -0600, Felipe Balbi wrote: >> Hi, >> >> On Thu, Dec 11, 2014 at 04:08:43PM +0530, Sanchayan Maity wrote: >>> Hello, >>> >>> I am working on a Freescale Cortex-A5 Vybrid Processor. The chip core >>> is clocked at

Re: [PATCH 2/3] usb: chipidea: usbmisc_imx: delete clock information

2014-12-12 Thread Philipp Zabel
Hi Peter, Am Freitag, den 12.12.2014, 15:09 +0800 schrieb Peter Chen: > All imx usb controller's non core registers uses the same clock gate with > core registers, the usbmisc_imx is the library for imx glue driver, the > glue keeps clock on when it calls usbmisc_imx API to change non-core registe

[PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-12 Thread Robert Baldyga
As usb function drivers assumes that all usb request will be completed before function unbind call, we should supply such behavior. In some cases ep_disable() won't kill all request effectively, because some IN requests can be in running state. In such situation it's possible to have unbind functio

Re: [RFC PATCH] mfd: dln2: add support for ACPI

2014-12-12 Thread Octavian Purdila
On Thu, Dec 11, 2014 at 11:44 PM, Rafael J. Wysocki wrote: > > On Thursday, December 11, 2014 06:32:07 PM Octavian Purdila wrote: > > This patch adds support to load a custom ACPI table that describes > > devices connected via the DLN2 USB to I2C/SPI/GPIO bridge. > > > > The ACPI table is loaded a

[PATCH 1/1] Revert "usb: chipidea: remove duplicate dev_set_drvdata for host_start"

2014-12-12 Thread Peter Chen
This reverts commit 14b4099c074f2ddf4d84b22d370170e61b527529 It moved platform_set_drvdata(pdev, ci) before hcd is created, and the hcd will assign itself as ci controller's drvdata during the hcd creation function (in usb_create_shared_hcd), so it overwrites the real ci's drvdata which we want to

[PATCH 0/1] usb: chipidea: one bug fix for v3.19

2014-12-12 Thread Peter Chen
Hi Greg, I find one bug that existed at chipidea driver in patch series which I sent you for v3.19, it will cause oops during the system suspend routine at host mode, hope it is not too late for merge. Apologize for that. Peter Chen (1): Revert "usb: chipidea: remove duplicate dev_set_drvdata f

Re: [sur40] Videobuf2 and/or DMA?

2014-12-12 Thread Florian Echtler
Hello Alan, On 11.12.2014 20:36, Alan Stern wrote: > On Sun, 7 Dec 2014, Florian Echtler wrote: >> - Can I always use DMA on the USB side (for bulk transfers), or does >> this in any way require support from the USB device's hardware? (I'm >> guessing no, but a definite answer would be great.) > D

Re: [PATCH] uas: disable UAS on Apricorn SATA dongles

2014-12-12 Thread Hans de Goede
On 11-12-14 20:01, Darrick J. Wong wrote: The Apricorn SATA dongle will occasionally return "USBSUSBSUSB" in response to SCSI commands when running in UAS mode. Therefore, disable UAS mode on this dongle. Signed-off-by: Darrick J. Wong Looks good: Acked-by: Hans de Goede Greg, can you a

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-12 Thread Hans de Goede
Hi, On 11-12-14 09:37, Darrick J. Wong wrote: On Wed, Dec 10, 2014 at 05:41:54PM -0800, Darrick J. Wong wrote: On Wed, Dec 10, 2014 at 02:29:29AM -0800, Darrick J. Wong wrote: On Wed, Dec 10, 2014 at 02:15:14AM -0800, Darrick J. Wong wrote: On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J.

[PATCH 2/3] usb: chipidea: usbmisc_imx: delete clock information

2014-12-12 Thread Peter Chen
All imx usb controller's non core registers uses the same clock gate with core registers, the usbmisc_imx is the library for imx glue driver, the glue keeps clock on when it calls usbmisc_imx API to change non-core register. Besides, we will support runtime pm in the future, it also needs to close

[PATCH 1/3] usb: chipidea: imx: using common platform flag directly

2014-12-12 Thread Peter Chen
It is meaningless the glue layer driver has its own platform flag which is the same meaning with common platform flag. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c

[PATCH 3/3] usb: chipidea: imx: simplify the usbmisc callers

2014-12-12 Thread Peter Chen
Move struct imx_usbmisc_data NULL pointer judgement from caller to each API, it can simplify the caller. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 22 -- drivers/usb/chipidea/usbmisc_imx.c | 12 ++-- 2 files changed, 18 insertions(+), 16 delet