Re: USB 3.0 drive crashes system when plugged in - regression

2014-12-02 Thread Oliver Neukum
On Wed, 2014-12-03 at 00:29 +0100, Marcin Zajączkowski wrote: > Hi, > > After upgrade to Fedora 21 with 3.17.3-300.fc21.x86_64 (from 3.14.x in > Fedora 19) my USB 3.0 drive (Seagate Backup+ 1TB) stopped working with > USB 3.0 port (works fine with USB 2.0 port). > > When plug in for the first tim

Re: [PATCH net-next] r8152: reduce memory copy for rx

2014-12-02 Thread Eric Dumazet
On Wed, 2014-12-03 at 07:05 +, Hayes Wang wrote: > Eric Dumazet [mailto:eric.duma...@gmail.com] > > Sent: Wednesday, December 03, 2014 2:08 PM > [...] > > Better performance for what workload exactly ? > > I test it by using Chariot with 4 Tx and 4 Rx. > It has about 4% improvement. > Have

RE: [PATCH net-next] r8152: reduce memory copy for rx

2014-12-02 Thread Hayes Wang
Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Wednesday, December 03, 2014 2:08 PM [...] > Better performance for what workload exactly ? I test it by using Chariot with 4 Tx and 4 Rx. It has about 4% improvement. > cloning in rx path has many drawbacks, with skb->truesize > being usuall

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
No problems. I remain there - for anything. Especially because if we collaborate and are able to find a good solution to this problem, then it is so much better for all. Tell me if I can do something useful or try something useful... Enrico On Wed, 3 Dec 2014, Kevin Zhu wrote: ==Date: Wed, 3 Dec

Re: [PATCH net-next] r8152: reduce memory copy for rx

2014-12-02 Thread Eric Dumazet
On Wed, 2014-12-03 at 13:14 +0800, Hayes Wang wrote: > If the data size is more than half of the AGG_BUG_SZ, allocate a new > rx buffer and use skb_clone() to avoid the memory copy. > > The original method is that allocate the memory and copy data for each > packet in a rx buffer. The new one is t

Re: Is this 32-bit NCM?

2014-12-02 Thread Kevin Zhu
OK. I will. Thank you for everything! Regards, Kevin On 12/03/2014 02:00 PM, Enrico Mioso wrote: > Yes - I think this would be ok. You might try this with the 16-bit river > first, > and then with the 32-bit one to see how things work. > I hope for the best. > Let us all know, > Enrico > > > On

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
Yes - I think this would be ok. You might try this with the 16-bit river first, and then with the 32-bit one to see how things work. I hope for the best. Let us all know, Enrico On Wed, 3 Dec 2014, Kevin Zhu wrote: ==Date: Wed, 3 Dec 2014 06:38:27 ==From: Kevin Zhu ==To: Enrico Mioso ==Cc: Bj

Re: [PATCH] arm: omap3: twl: remove usb phy init data

2014-12-02 Thread Kishon Vijay Abraham I
Hi Greg, On Monday 01 December 2014 02:14 PM, Kishon Vijay Abraham I wrote: > From: Heikki Krogerus > > The driver does no use it any more. > > Signed-off-by: Heikki Krogerus > Signed-off-by: Kishon Vijay Abraham I This patch is required to get rid of the error that Stephen Rothwell reported

Re: Is this 32-bit NCM?

2014-12-02 Thread Kevin Zhu
My dongle also works with the huawei driver. I think only the 32bit format and NDP location matter. We may modify the TX function to put NTH and NDP at the beginning of a NTB and see if it will work with the driver cdc_ncm. Regards, Kevin On 12/02/2014 11:28 PM, Enrico Mioso wrote: > ... And what

[PATCH net-next] r8152: reduce memory copy for rx

2014-12-02 Thread Hayes Wang
If the data size is more than half of the AGG_BUG_SZ, allocate a new rx buffer and use skb_clone() to avoid the memory copy. The original method is that allocate the memory and copy data for each packet in a rx buffer. The new one is that when the data size for a rx buffer is more than RX_THRESHOL

Re: [PATCH 8/8] wusb: replace memset by memzero_explicit

2014-12-02 Thread Daniel Borkmann
On 12/03/2014 01:14 AM, Greg Kroah-Hartman wrote: On Sun, Nov 30, 2014 at 05:59:34PM +0100, Julia Lawall wrote: From: Julia Lawall Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simpl

Re: [PATCH 8/8] wusb: replace memset by memzero_explicit

2014-12-02 Thread Greg Kroah-Hartman
On Sun, Nov 30, 2014 at 05:59:34PM +0100, Julia Lawall wrote: > From: Julia Lawall > > Memset on a local variable may be removed when it is called just before the > variable goes out of scope. Using memzero_explicit defeats this > optimization. A simplified version of the semantic patch that ma

Re: [PATCH V2] usb: {ohci,ehci}-platform: Use new OF big-endian helper function

2014-12-02 Thread Greg KH
On Thu, Nov 27, 2014 at 08:43:43PM -0800, Kevin Cernekee wrote: > This handles the existing "big-endian" case, and in addition, it also does > the right thing when "native-endian" is specified. > > Signed-off-by: Kevin Cernekee > Acked-by: Alan Stern > --- > Documentation/devicetree/bindings/us

USB 3.0 drive crashes system when plugged in - regression

2014-12-02 Thread Marcin Zajączkowski
Hi, After upgrade to Fedora 21 with 3.17.3-300.fc21.x86_64 (from 3.14.x in Fedora 19) my USB 3.0 drive (Seagate Backup+ 1TB) stopped working with USB 3.0 port (works fine with USB 2.0 port). When plug in for the first time (USB 3.0 port) I see in log: > kernel: xhci_hcd :04:00.0: ERROR Trans

Re: randconfig build error with next-20141201, in drivers/usb/musb/tusb6010.c

2014-12-02 Thread Felipe Balbi
Hi, On Tue, Dec 02, 2014 at 10:13:16AM -0800, Greg Kroah-Hartman wrote: > On Mon, Dec 01, 2014 at 10:00:35AM -0700, Jim Davis wrote: > > Building with the attached random configuration file, > > > > drivers/built-in.o: In function `tusb_remove': > > tusb6010.c:(.text+0x16a817): undefined referenc

Re: [PATCH V6 05/12] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-12-02 Thread Andrew Bresticker
On Tue, Dec 2, 2014 at 1:47 AM, Thierry Reding wrote: > On Mon, Nov 24, 2014 at 04:17:17PM -0800, Andrew Bresticker wrote: >> The Tegra xHCI controller's firmware communicates requests to the host >> processor through a mailbox interface. While there is only a single >> physical channel, messages

Re: [GIT PULL] USB driver fixes for 3.18-rc7

2014-12-02 Thread Greg KH
On Sun, Nov 30, 2014 at 11:47:20AM -0800, Linus Torvalds wrote: > Hmm, Greg. > > I seem to get this problem possibly more commonly at boot these days: > > usb 1-6: new full-speed USB device number 2 using xhci_hcd > usb 1-6: device descriptor read/64, error -71 > xhci_hcd :00:14.0: Setu

Re: randconfig build error with next-20141201, in drivers/usb/musb/tusb6010.c

2014-12-02 Thread Greg Kroah-Hartman
On Mon, Dec 01, 2014 at 10:00:35AM -0700, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/built-in.o: In function `tusb_remove': > tusb6010.c:(.text+0x16a817): undefined reference to > `usb_phy_generic_unregister' > drivers/built-in.o: In function `tusb_probe'

Re: [PATCH] usb: gadget: zero: fix INT endpoint assignment

2014-12-02 Thread Sebastian Andrzej Siewior
On 11/26/2014 10:40 PM, Alan Stern wrote: > On Wed, 26 Nov 2014, Sebastian Andrzej Siewior wrote: > >> On 11/26/2014 04:24 PM, Alan Stern wrote: On 11/25/2014 10:52 PM, Sebastian Andrzej Siewior wrote: > The max packet size within the FS descriptor has to be highest possible > value a

Re: [PATCH] usb: gadget: zero: fix INT endpoint assignment

2014-12-02 Thread Sebastian Andrzej Siewior
On 11/25/2014 08:39 PM, Paul Zimmerman wrote: >> diff --git a/drivers/usb/gadget/function/f_sourcesink.c >> b/drivers/usb/gadget/function/f_sourcesink.c >> index 80be25b32cd7..7d8f0216e1a6 100644 >> --- a/drivers/usb/gadget/function/f_sourcesink.c >> +++ b/drivers/usb/gadget/function/f_sourcesink.

Re: [PATCH] usb: gadget: zero: fix INT endpoint assignment

2014-12-02 Thread Sebastian Andrzej Siewior
On 11/26/2014 02:08 PM, Amit Virdi wrote: > Dear Sebastian, Hi Amit, > On 11/25/2014 10:52 PM, Sebastian Andrzej Siewior wrote: >> The max packet size within the FS descriptor has to be highest possible >> value and _not_ the one that is (or will be) used on FS. > > The current code sets wMaxPac

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
... And what do you think about the source code of their ndis driver? We at least know now the device work with it, so we have something to mimic :D thank you for your work and patience Kevin. On Tue, 2 Dec 2014, Kevin Zhu wrote: ==Date: Tue, 2 Dec 2014 16:04:25 ==From: Kevin Zhu ==To: Enrico Mi

Re: [RFC] usb: gadget: libcomposite: provide usb_get_cdesc()

2014-12-02 Thread Sebastian Andrzej Siewior
On 11/27/2014 11:09 AM, Andrzej Pietrasiewicz wrote: > Hi Sebastian, Hi Andrzej, >> +struct usb_descriptor_header *usb_get_cdesc(struct >> usb_descriptor_header **hdr, >> + struct usb_descriptor_header *desc, >> + struct usb_descriptor_header **c) >

Re: Is this 32-bit NCM?

2014-12-02 Thread Kevin Zhu
I do not understand why the wSequence matters. By the way, I think I see some NDPs are right after NTH headers in the windows capture. From: Enrico Mioso Sent: Tuesday, December 2, 2014 21:53 To: Bjørn Mork Cc: Kevin Zhu; Eli Britstein; Alex Strizhevsky;

Re: "Real" USB3 mass storage speed

2014-12-02 Thread Sebastian Andrzej Siewior
On 12/02/2014 03:20 PM, Felipe Balbi wrote: > > Sebastian, do you still have any notes on how to use UASP gadget with > either RAM or a real storage backend ? I have a shell script dated 2k11: CONFIGFS=/sys/kernel/config/; TARGET=$CONFIGFS/target/core/ FABRIC=$CONFIGFS/target/loopback/ mkdir -p

Re: "Real" USB3 mass storage speed

2014-12-02 Thread Felipe Balbi
Hi, On Tue, Dec 02, 2014 at 11:55:29AM +0100, Ricardo Ribalda Delgado wrote: > Hello > > As you know I am trying to improve the net2280 driver to a point where > it is usable for my company (qtec.com). We develop smart cameras based > on linux, and we want to provide also a mass storage interface

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
Thank you very much Bjorn. On Tue, 2 Dec 2014, Bjørn Mork wrote: ==Date: Tue, 2 Dec 2014 14:37:03 ==From: Bjørn Mork ==To: Enrico Mioso ==Cc: Kevin Zhu , ==Eli Britstein , ==Alex Strizhevsky , ==Midge Shaojun Tan , =="you...@gmail.com" , =="linux-usb@vger.kernel.org" , ==

Re: Is this 32-bit NCM?

2014-12-02 Thread Bjørn Mork
Enrico Mioso writes: > ... but out of curiosity: are NCM specs allowing to change order of things in > the package or not? > This is not to start philosofical falames or something, but to understand > better how things work. And, if they do: how much arbitrarily? Only the NTB header has a fixe

Re: "Real" USB3 mass storage speed

2014-12-02 Thread Ricardo Ribalda Delgado
Hello >> If I want to get closer to the maximum speed should I just forget >> about mass storage and use something else? What? >> > > You might want to look into UAS (USB Attached SCSI). > There is "USB Gadget Target Fabric Module" in Kconfig. > There is a gadget-cli tool to control it from usersp

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
... but out of curiosity: are NCM specs allowing to change order of things in the package or not? This is not to start philosofical falames or something, but to understand better how things work. And, if they do: how much arbitrarily? On Tue, 2 Dec 2014, Bjørn Mork wrote: ==Date: Tue, 2 Dec 20

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
To be clear - I also rebooted the remote system to power cycle the modem, wanting to avoid at^reset But this modification of the driver unfortunately seems to lead to no changes. Thank you so much Bjorn. Interetingly - a misbehaviour of the firmware was observed - I wasn't able to at^ndisdup=1,

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
Testing it right now - let you know in a moment. On Tue, 2 Dec 2014, Bjørn Mork wrote: ==Date: Tue, 2 Dec 2014 12:21:18 ==From: Bjørn Mork ==To: Enrico Mioso ==Cc: Kevin Zhu , ==Eli Britstein , ==Alex Strizhevsky , ==Midge Shaojun Tan , =="you...@gmail.com" , =="linux-usb@v

Re: Is this 32-bit NCM?

2014-12-02 Thread Bjørn Mork
Enrico Mioso writes: > Kevin - it works! the key seems to be in the tx_fixup function; there is a > special handling for frames effectively. > Please ... help me backport those changes to the standard Linux driver - it > will be a gain for us all, and in general you'll have a more probable > m

Re: "Real" USB3 mass storage speed

2014-12-02 Thread Andrzej Pietrasiewicz
W dniu 02.12.2014 o 11:55, Ricardo Ribalda Delgado pisze: Hello As you know I am trying to improve the net2280 driver to a point where it is usable for my company (qtec.com). We develop smart cameras based on linux, and we want to provide also a mass storage interface to the camera. Right now,

"Real" USB3 mass storage speed

2014-12-02 Thread Ricardo Ribalda Delgado
Hello As you know I am trying to improve the net2280 driver to a point where it is usable for my company (qtec.com). We develop smart cameras based on linux, and we want to provide also a mass storage interface to the camera. Right now, the maximum speed I have been able to achieve is around 80 M

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
Errata corrige - they might re-define those structurtes to be able to re-use the same parsing code. Sorry. On Tue, 2 Dec 2014, Kevin Zhu wrote: ==Date: Tue, 2 Dec 2014 09:03:21 ==From: Kevin Zhu ==To: Eli Britstein , ==Enrico Mioso ==Cc: Bjørn Mork , Alex Strizhevsky , ==Midge Shaojun

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
Oh - they define even custom structs for NCM_NTH32! :) Mhm... unfortunately reading all the driver will be needed to find out the details. Probably using 16 or 32 bit is ok, but you have the choise now that a cdc_ncm.c 32-bit capable driver exists. But in that case an eventual merge will be need

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
So, we can say that: 1 - They use 32-bit NCM if I am not wrong: so we where in the right direction Alex! 2 - The driver is "all-in-one": it supports QMI also, not only cdc_ncm. 3 - It #undefs some things from the headers and might be redefine them... mhm... On Tue, 2 Dec 2014, Kevin Zhu wrote:

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
Kevin - it works! the key seems to be in the tx_fixup function; there is a special handling for frames effectively. Please ... help me backport those changes to the standard Linux driver - it will be a gain for us all, and in general you'll have a more probable maintenance than you would with th

Re: [PATCH 14/17] Documentation: usb: SERIAL function testing

2014-12-02 Thread Johan Hovold
On Mon, Dec 01, 2014 at 09:33:45AM +0100, Andrzej Pietrasiewicz wrote: > W dniu 28.11.2014 o 16:37, Johan Hovold pisze: > > On Fri, Nov 28, 2014 at 02:57:47PM +0100, Andrzej Pietrasiewicz wrote: > >> Summary of how to test SERIAL function of USB gadget. > > > >> +Testing the SERIAL function > >> +-

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
It works! Now the modem is working... and the answer is in the huawei NDIS driver. https://dl.dropboxusercontent.com/u/15043728/ArchLinuxArm/huawei_ndis/ndis_src.tar.xz On Tue, 2 Dec 2014, Kevin Zhu wrote: ==Date: Tue, 2 Dec 2014 09:03:21 ==From: Kevin Zhu ==To: Eli Britstein , ==Enrico Mio

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
Ok - I am a newbie; but looking back at the mistake I did last time - I did modify the memset call at line 1049 to change the padding. This is wrong ... but, it was an attempt. On Tue, 2 Dec 2014, Kevin Zhu wrote: ==Date: Tue, 2 Dec 2014 09:03:21 ==From: Kevin Zhu ==To: Eli Britstein , ==E

Re: Is this 32-bit NCM?

2014-12-02 Thread Enrico Mioso
Mhmhm; trying to change different values in the cdc_ncm.c driver might be the only way. I am sorry - I am not noticing strange things, but fixed parameters. Try to change them ... I can not do that, I lost my test system due to a kernel-related programming error, so for now I am a passive observe

Re: [PATCH V6 05/12] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-12-02 Thread Thierry Reding
On Mon, Nov 24, 2014 at 04:17:17PM -0800, Andrew Bresticker wrote: > The Tegra xHCI controller's firmware communicates requests to the host > processor through a mailbox interface. While there is only a single > physical channel, messages sent by the controller can be divided > into two groups: th

Re: Is this 32-bit NCM?

2014-12-02 Thread Kevin Zhu
Below is the content of the INF file oem54.inf. ; Copyright (c) 2010,2011 Huawei Incorporated ; Manufacturer: Huawei Incorporated ; ; CDC ECM & NCM driver ; [Version] Signature="$WINDOWS NT$" Class=Net ClassGUID={4d36e972-e325-11ce-bfc1-08002be10318} Provider=%Mfg% DriverVer=04/14/2014,1.0.13.0 C