Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 November 2014 09:06 PM, Heikki Krogerus wrote: > On Tue, Nov 18, 2014 at 10:49:18AM +0530, Kishon Vijay Abraham I wrote: >> On Monday 17 November 2014 09:10 PM, Heikki Krogerus wrote: >>> On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote: How about adding the chan

Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 November 2014 09:06 PM, Heikki Krogerus wrote: > On Tue, Nov 18, 2014 at 10:49:18AM +0530, Kishon Vijay Abraham I wrote: >> On Monday 17 November 2014 09:10 PM, Heikki Krogerus wrote: >>> On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote: How about adding the chan

[PATCH net-next v2 0/2] r8152: adjust rx functions

2014-11-18 Thread Hayes Wang
v2: For patch #1, set actual_length to 0 before adding the rx to the list, when a error occurs. For patch #2, change the flow. Stop submitting the rx if a error occurs, and add the remaining rx to the list for submitting later. v1: Adjust some flows and codes which are relative to r8152_submit_rx

[PATCH net-next v2 2/2] r8152: adjust rtl_start_rx

2014-11-18 Thread Hayes Wang
If there is a error for r8152_submit_rx(), add the remaining rx buffers to the list. Then the remaining rx buffers could be submitted later. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/usb/r8152.c b/dr

[PATCH net-next v2 1/2] r8152: adjust r8152_submit_rx

2014-11-18 Thread Hayes Wang
The behavior of handling the returned status from r8152_submit_rx() is almost same, so let r8152_submit_rx() deal with the error directly. This could avoid the duplicate code. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 41 + 1 file changed, 21

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 04:33:42PM -0500, Jorge Ramirez-Ortiz wrote: > On 11/18/2014 03:47 PM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: > > you have no clue what these mean, do you ? How about reading the USB > > specification

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 06:44:39PM -0600, Bin Liu wrote: > Felipe, > > On Tue, Nov 18, 2014 at 3:17 PM, Felipe Balbi wrote: > > On Fri, Nov 14, 2014 at 01:54:46PM +0530, George Cherian wrote: > >> Disable the MUSB interrupts till MUSB is recovered fully from BABBLE > >> condition. There are chanc

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 09:45:13PM +, Paul Zimmerman wrote: > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > > Sent: Tuesday, November 18, 2014 12:47 PM > > > > On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrot

Re: [PATCH v2] usb: dwc2: resume root hub when device detect with suspend state

2014-11-18 Thread Julius Werner
>> You should be aware that it's not safe to use hcd->state for anything >> in a host controller driver. That field is owned by usbcore, not by >> the HCD, and it is not protected by any locks. >> >> Thus, for example, hcd->state does not get set to HC_STATE_SUSPENDED >> until some time after the

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-18 Thread Bin Liu
Felipe, On Tue, Nov 18, 2014 at 3:17 PM, Felipe Balbi wrote: > On Fri, Nov 14, 2014 at 01:54:46PM +0530, George Cherian wrote: >> Disable the MUSB interrupts till MUSB is recovered fully from BABBLE >> condition. There are chances that we could get multiple interrupts >> till the time the babble

USB devices disappering on resume on pantherpoint chipset with dock

2014-11-18 Thread Brian Campbell
Hi, I'm having trouble with USB devices connected to a Thinkpad X230's dock disappearing after a few suspend/resume cycles. Devices connected directly to the laptop rather than the dock are not affected. The main symptom in the logs is a complaint about bandwidth, and comes from the bandwidth ch

[PATCH] usb: gagdet: f_midi: fix parameter assignment

2014-11-18 Thread Daniel Mack
f_midi_register_card() uses midi->id and midi->index, so they need to be assigned before the function is called from f_midi_bind_config(). Move the assigment of midi->buflen and midi->qlen as well so they are all grouped. Compile tested only. Signed-off-by: Daniel Mack --- drivers/usb/gadget/fu

RE: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Tuesday, November 18, 2014 12:47 PM > > On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: > > > > notice that the original PLX driver was still far from the theo

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Jorge Ramirez-Ortiz
On 11/18/2014 03:47 PM, Felipe Balbi wrote: > Hi, > > On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: > you have no clue what these mean, do you ? How about reading the USB > specification of even http://www.beyondlogic.org/usbnutshell/usb1.shtml Unfortunately I do

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-18 Thread Felipe Balbi
On Fri, Nov 14, 2014 at 01:54:46PM +0530, George Cherian wrote: > Disable the MUSB interrupts till MUSB is recovered fully from BABBLE > condition. There are chances that we could get multiple interrupts > till the time the babble recover work gets scheduled. Sometimes > this could even end up in a

Re: [PATCH v2 2/2] [usb] add support for ACPI identification to xhci-platform

2014-11-18 Thread Feng Kan
On Tue, Nov 18, 2014 at 12:33 PM, Mark Langsdorf wrote: > On 11/18/2014 02:05 PM, Feng Kan wrote: >> >> On Thu, Nov 13, 2014 at 10:36 AM, Mark Langsdorf >> wrote: >>> >>> On 11/04/2014 11:12 AM, Greg KH wrote: On Tue, Nov 04, 2014 at 10:50:33AM -0600, Mark Langsdorf wrote: >>> >>>

RE: [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-11-18 Thread Paul Zimmerman
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] > Sent: Friday, October 31, 2014 3:13 AM > > This patch adds mutex, which protects initialization and > deinitialization procedures against suspend/resume methods. > > Signed-off-by: Marek Szyprowski > --- > drivers/usb/dwc2/core.h |

RE: [PATCH v5] usb: dwc2/gadget: rework disconnect event handling

2014-11-18 Thread Paul Zimmerman
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] > Sent: Monday, November 17, 2014 1:00 AM > > This patch adds a call to s3c_hsotg_disconnect() from 'end session' > interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem > about unplugged usb cable. DISCONNINT interrupt cann

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Felipe Balbi
Hi, On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: > >>> you have no clue what these mean, do you ? How about reading the USB > >>> specification of even http://www.beyondlogic.org/usbnutshell/usb1.shtml > >> > >> Unfortunately I do. > >> It was easier to temporarily hack the

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Jorge Ramirez-Ortiz
On 11/18/2014 01:00 PM, Felipe Balbi wrote: > Hi, > > (fix your mailer, lines should be broken at 80-characters. > Documentation/email-clients.txt has tips) > > On Tue, Nov 18, 2014 at 12:52:11PM -0500, Jorge Ramirez-Ortiz wrote: >> On 11/18/2014 10:17 AM, Felipe Balbi wrote: >>> Hi, >>> >>> On Tue

Re: [PATCH v2 2/2] [usb] add support for ACPI identification to xhci-platform

2014-11-18 Thread Mark Langsdorf
On 11/18/2014 02:05 PM, Feng Kan wrote: On Thu, Nov 13, 2014 at 10:36 AM, Mark Langsdorf wrote: On 11/04/2014 11:12 AM, Greg KH wrote: On Tue, Nov 04, 2014 at 10:50:33AM -0600, Mark Langsdorf wrote: #endif +#ifdef CONFIG_ACPI +static const struct acpi_device_id usb_xhci_acpi_match[] =

[PATCH] usb: gadget: add USB3 support to the printer driver

2014-11-18 Thread Jorge Ramirez-Ortiz
Add SS descriptors to support the capabilities provided by USB3 controller drivers; unit tests run using a PLX 3380 [max transfer speed measured of 1Gbps] This driver shall fallback to lower operating modes when the higher ones are not available. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/u

[PATCH] usb: gadget: add USB3 support to the printer driver

2014-11-18 Thread Jorge Ramirez-Ortiz
This patch adds USB3 support to the printer driver. Tests used two binaries (host/device) to handle the file transfer [gadget] $ dmesg net2280 :02:00.0: usb_reset_338x: Defect 7374 FsmValue 0xf000 net2280 :02:00.0: usb_reinit_338x: Defect 7374 FsmValue f000 net2280 :02:00.0

Re: [PATCH v2 2/2] [usb] add support for ACPI identification to xhci-platform

2014-11-18 Thread Feng Kan
On Thu, Nov 13, 2014 at 10:36 AM, Mark Langsdorf wrote: > On 11/04/2014 11:12 AM, Greg KH wrote: >> >> On Tue, Nov 04, 2014 at 10:50:33AM -0600, Mark Langsdorf wrote: > > #endif >>> >>> >>> +#ifdef CONFIG_ACPI >>> +static const struct acpi_device_id usb_xhci_acpi_match[] = { >>> + /* APM X

Re: [PATCH v8 00/13] ARM: berlin: USB support

2014-11-18 Thread Sebastian Hesselbarth
On 17.11.2014 14:35, Antoine Tenart wrote: This series adds the support for ChipIdea USB2 (ci13xxx) controllers, the USB PHYs of the Marvell Berlin SoCs and also adds a reset controller for these SoCs. The reset controller is used by the PHY driver and shares the existing chip controller node wi

Re: [PATCH v8 13/13] ARM: dts: berlin: enable USB on the Google Chromecast

2014-11-18 Thread Sebastian Hesselbarth
On 17.11.2014 14:35, Antoine Tenart wrote: From: Sebastian Hesselbarth Enable usb1 on Google Chromecast which is connected to micro-USB plug used for external power supply, too. Signed-off-by: Sebastian Hesselbarth Signed-off-by: Antoine Tenart Applied to berlin/dt. Thanks! --- arch/a

Re: [PATCH v8 12/13] ARM: dts: berlin: add BG2CD nodes for USB support

2014-11-18 Thread Sebastian Hesselbarth
On 17.11.2014 14:35, Antoine Tenart wrote: From: Sebastian Hesselbarth Adds nodes describing the Marvell Berlin BG2CD USB PHY and USB. The BG2CD SoC has 2 USB ChipIdea controllers, with usb0 host-only and usb1 dual-role capable. Signed-off-by: Sebastian Hesselbarth Signed-off-by: Antoine Tena

Re: [PATCH v8 11/13] ARM: dts: Berlin: enable USB on the BG2Q DMP

2014-11-18 Thread Sebastian Hesselbarth
On 17.11.2014 14:35, Antoine Tenart wrote: Enable the 2 available USB PHY and USB nodes on the Marvell Berlin BG2Q DMP. Signed-off-by: Antoine Tenart Applied to berlin/dt. Thanks! --- arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 53 ++ 1 file changed, 53 inse

Re: [PATCH v8 10/13] ARM: dts: berlin: add BG2Q nodes for USB support

2014-11-18 Thread Sebastian Hesselbarth
On 17.11.2014 14:35, Antoine Tenart wrote: Adds nodes describing the Marvell Berlin BG2Q USB PHY and USB. The BG2Q SoC has 3 USB host controller, compatible with ChipIdea. Signed-off-by: Antoine Tenart Applied to berlin/dt with the whitespace removed that Sergei pointed out. Thanks! ---

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Felipe Balbi
Hi, (fix your mailer, lines should be broken at 80-characters. Documentation/email-clients.txt has tips) On Tue, Nov 18, 2014 at 12:52:11PM -0500, Jorge Ramirez-Ortiz wrote: > On 11/18/2014 10:17 AM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Nov 18, 2014 at 09:19:36AM -0500, Jorge Ramirez-Ortiz

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Jorge Ramirez-Ortiz
On 11/18/2014 10:17 AM, Felipe Balbi wrote: > Hi, > > On Tue, Nov 18, 2014 at 09:19:36AM -0500, Jorge Ramirez-Ortiz wrote: >> Hi Felipe/Greg >> >> Thanks for your comments on my previous attempt. >> I think I addressed them here. > no you haven't. Read Documentation/SubmittingPatches, read the mail

Re: [PATCH V5 09/12] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver

2014-11-18 Thread Andrew Bresticker
On Mon, Nov 17, 2014 at 4:33 PM, Felipe Balbi wrote: >> >> +static int tegra_xhci_load_firmware(struct tegra_xhci_hcd *tegra) >> >> +{ >> >> + struct device *dev = tegra->dev; >> >> + struct tegra_xhci_fw_cfgtbl *cfg_tbl; >> >> + struct tm fw_tm; >> >> + u32 val, code_tag_blocks, c

Re: [RFC v6 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

2014-11-18 Thread Kiran Raparthy
On 18 November 2014 21:25, Felipe Balbi wrote: > Hi, > > On Wed, Nov 12, 2014 at 12:11:19PM +0530, Kiran Kumar Raparthy wrote: >> From: Todd Poynor >> >> usb: phy: hold wakeupsource when USB is enumerated in peripheral mode >> >> Some systems require a mechanism to prevent system to enter into su

Re: [PATCH v2] usb: dwc2: resume root hub when device detect with suspend state

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 11:07:34AM -0500, Alan Stern wrote: > On Tue, 18 Nov 2014, Kever Yang wrote: > > > After we implement the bus_suspend/resume, auto suspend id enabled. > > The root hub will be auto suspend if there is no device connected, > > we need to resume the root hub when a device con

[PATCH v2] usbnet: rtl8150: remove unused variable

2014-11-18 Thread Sudip Mukherjee
remove unused variable Signed-off-by: Sudip Mukherjee --- change in v2: changed the commit message drivers/net/usb/rtl8150.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 6e87e57..d37b7dc 100644 --- a/drivers/n

USB-serial console and lockdep

2014-11-18 Thread Johan Hovold
Hi Peter, I get this missing-lockdep-annotation warning which I haven't seen before when booting with a usb-serial console on 3.18-rc5. It's been a while since I last tested this, though, and the tty_ldisc_ref wasn't introduced until 833efc0ed19c ("USB: serial: invoke dcd_change ldisc's handler.")

Re: [PATCH v2] usb: dwc2: resume root hub when device detect with suspend state

2014-11-18 Thread Alan Stern
On Tue, 18 Nov 2014, Kever Yang wrote: > After we implement the bus_suspend/resume, auto suspend id enabled. > The root hub will be auto suspend if there is no device connected, > we need to resume the root hub when a device connect detect. > > This patch tested on rk3288. > > Signed-off-by: Roy

Re: [PATCH] usbnet: rtl8150: remove unused variable

2014-11-18 Thread Petko Manolov
On 14-11-18 18:29:59, Sudip Mukherjee wrote: > we were just returning the initial value of res, instead now > we are returning the value directly. Looks OK, but could you please fix the wording of the commit message to something like: Remove unused variable. This is a tiny patch and the

Re: [RFC v6 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

2014-11-18 Thread Felipe Balbi
Hi, On Wed, Nov 12, 2014 at 12:11:19PM +0530, Kiran Kumar Raparthy wrote: > From: Todd Poynor > > usb: phy: hold wakeupsource when USB is enumerated in peripheral mode > > Some systems require a mechanism to prevent system to enter into suspend > state when USB is connected and enumerated in pe

Re: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 12:05:45AM +0400, Dmitry Eremin-Solenikov wrote: > Hello, > > 2014-11-17 21:44 GMT+03:00 Robert Jarzmik : > > Dmitry Eremin-Solenikov writes: > > > >> Change clk_enable/disable() calls to clk_prepare_enable() and > >> clk_disable_unprepare(). > >> > >> Signed-off-by: Dmitr

Re: USB OTG doesn't work in HOST mode on OMAP3 processor on 3.18-rc5

2014-11-18 Thread Tony Lindgren
* Enric Balletbo Serra [141118 01:04]: > Hi Tony, > > 2014-11-17 19:04 GMT+01:00 Tony Lindgren : > > > > Just tested v3.18-rc5 with beagleboard xm, and the host mode > > enumerates the devices, then may fail with "insufficient bus power" > > at least for the WLAN device I tried with. > > > > Is

Re: [PATCHv4 2/6] phy: improved lookup method

2014-11-18 Thread Heikki Krogerus
On Tue, Nov 18, 2014 at 10:49:18AM +0530, Kishon Vijay Abraham I wrote: > On Monday 17 November 2014 09:10 PM, Heikki Krogerus wrote: > > On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote: > >> How about adding the change in attached patch [1] on top of this patch. > >> Just introduced t

Re: [PATCH v2 1/3] usb: chipidea: add controller reset API

2014-11-18 Thread Felipe Balbi
On Mon, Nov 17, 2014 at 10:19:49AM +0800, Peter Chen wrote: > On Fri, Nov 14, 2014 at 09:06:47AM -0600, Felipe Balbi wrote: > > On Fri, Nov 14, 2014 at 03:33:44PM +0800, Peter Chen wrote: > > > On Thu, Nov 13, 2014 at 09:55:34PM -0600, Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Fri, Nov 14

Re: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Felipe Balbi
Hi, On Tue, Nov 18, 2014 at 09:19:36AM -0500, Jorge Ramirez-Ortiz wrote: > Hi Felipe/Greg > > Thanks for your comments on my previous attempt. > I think I addressed them here. no you haven't. Read Documentation/SubmittingPatches, read the mailing list archives and you'll see your basic mistake.

Re: Huawei E173 USB modem

2014-11-18 Thread Lars Melin
On 2014-11-18 14:48, Jesse van der Berg wrote: Hi, uname -a Linux Firen4ALL 3.17.3-031703-generic #201411141335 SMP Fri Nov 14 18:36:40 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Gives me the following in the syslog when I attach a Huawei E173 3G USB modem to my computer. I don't know if it's rele

[PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Jorge Ramirez-Ortiz
Hi Felipe/Greg Thanks for your comments on my previous attempt. I think I addressed them here. I added some logs of a run captured on a recent kernel, fixed the indentations, replaced the if/else with a switch statement and removed the copyright. Note that the tests seem to indicate a performance

Re: [PATCH V2 4/5] mfd: t7l66xb: prepare/unprepare clocks

2014-11-18 Thread Lee Jones
On Mon, 17 Nov 2014, Dmitry Eremin-Solenikov wrote: > Change clk_enable/disable() calls to clk_prepare_enable() and > clk_disable_unprepare(). > > Signed-off-by: Dmitry Eremin-Solenikov > --- > drivers/mfd/t7l66xb.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Applied

[PATCH] usbnet: rtl8150: remove unused variable

2014-11-18 Thread Sudip Mukherjee
we were just returning the initial value of res, instead now we are returning the value directly. Signed-off-by: Sudip Mukherjee --- drivers/net/usb/rtl8150.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 6e87e57

Re: [PATCH v7 1/2] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-11-18 Thread Vivek Gautam
On Mon, Nov 17, 2014 at 9:46 PM, Sergei Shtylyov wrote: > Hello. > > On 11/17/2014 9:36 AM, Vivek Gautam wrote: > The host controller by itself may sometimes need to handle PHY and re-initialize it to re-configure some of the PHY parameters to get full support out of the PHY control

Re: [PATCH V2 5/5] mfd: tc6387xb: prepare/unprepare clocks

2014-11-18 Thread Lee Jones
On Mon, 17 Nov 2014, Dmitry Eremin-Solenikov wrote: > Change clk_enable/disable() calls to clk_prepare_enable() and > clk_disable_unprepare(). > > Signed-off-by: Dmitry Eremin-Solenikov > --- > drivers/mfd/tc6387xb.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Looks good

Re: USB OTG doesn't work in HOST mode on OMAP3 processor on 3.18-rc5

2014-11-18 Thread Enric Balletbo Serra
2014-11-18 10:02 GMT+01:00 Enric Balletbo Serra : > Hi Tony, > > 2014-11-17 19:04 GMT+01:00 Tony Lindgren : >> * Enric Balletbo Serra [141117 07:15]: >>> Hi all, >>> >>> I'm trying to use the USB OTG driver of OMAP3 processor in HOST mode >>> when it's configured in dual role mode (CONFIG_USB_MUS

[PATCH 3/3] USB: ssu100: fix overrun-error reporting

2014-11-18 Thread Johan Hovold
Fix reporting of overrun errors, which should only be reported once using the inserted null character. Fixes: 6b8f1ca5581b ("USB: ssu100: set tty_flags in ssu100_process_packet") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/ssu100.c | 11 +++ 1 file changed, 3 insertion

[PATCH 1/3] USB: keyspan: fix tty line-status reporting

2014-11-18 Thread Johan Hovold
Fix handling of TTY error flags, which are not bitmasks and must specifically not be ORed together as this prevents the line discipline from recognising them. Also insert null characters when reporting overrun errors as these are not associated with the received character. Fixes: 1da177e4c3f4 ("L

[PATCH 2/3] USB: keyspan: fix overrun-error reporting

2014-11-18 Thread Johan Hovold
Fix reporting of overrun errors, which are not associated with a character. Instead insert a null character and report only once. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/keyspan.c | 21 +++-- 1 file changed, 11 inser

[PATCHv3 1/4] xhci: don't start a halted endpoint before its new dequeue is set

2014-11-18 Thread Mathias Nyman
A halted endpoint ring must first be reset, then move the ring dequeue pointer past the problematic TRB. If we start the ring too early after reset, but before moving the dequeue pointer we will end up executing the same problematic TRB again. As we always issue a set transfer dequeue command afte

[PATCHv3 2/4] xhci: Reset a halted endpoint immediately when we encounter a stall.

2014-11-18 Thread Mathias Nyman
If a device is halted and reuturns a STALL, then the halted endpoint needs to be cleared both on the host and device side. The host side halt is cleared by issueing a xhci reset endpoint command. The device side is cleared with a ClearFeature(ENDPOINT_HALT) request, which should be issued by the de

[PATCHv3 4/4] usb: xhci: rework root port wake bits if controller isn't allowed to wakeup

2014-11-18 Thread Mathias Nyman
From: Lu Baolu When system is being suspended, if host device is not allowed to do wakeup, xhci_suspend() needs to clear all root port wake on bits. Otherwise, some platforms may generate spurious wakeup, even if PCI PME# is disabled. The initial commit ff8cbf250b44 ("xhci: clear root port wake

[PATCHv3 3/4] Revert "xhci: clear root port wake on bits if controller isn't wake-up capable"

2014-11-18 Thread Mathias Nyman
From: Lu Baolu commit ff8cbf250b44 ("xhci: clear root port wake on bits if controller isn't") can cause device detection error if runtime PM is enabled, and S3 wake is disabled. Revert it. https://bugzilla.kernel.org/show_bug.cgi?id=85701 This commit got into stable and should be reverted from t

[PATCHv3 0/4] xhci fixes for 3.18-rc

2014-11-18 Thread Mathias Nyman
Hi Greg third try v3: fix code comment to be in line with what the code does v2: correcting a wrong fixes commit ID, and missing stable version These patches for usb-linus solve two xhci issues, fixing xhci halted endpoint handling to now follow the specification, and pass testusb control message

Re: [PATCHv2 1/4] xhci: don't start a halted endpoint before its new dequeue is set

2014-11-18 Thread Mathias Nyman
On 17.11.2014 16:52, David Laight wrote: > From: Mathias Nyman >> A halted endpoint ring must first be reset, then move the ring >> dequeue pointer past the problematic TRB. If we start the ring too >> early after reset, but before moving the dequeue pointer we >> will end up executing the same pro

Re: USB OTG doesn't work in HOST mode on OMAP3 processor on 3.18-rc5

2014-11-18 Thread Enric Balletbo Serra
Hi Tony, 2014-11-17 19:04 GMT+01:00 Tony Lindgren : > * Enric Balletbo Serra [141117 07:15]: >> Hi all, >> >> I'm trying to use the USB OTG driver of OMAP3 processor in HOST mode >> when it's configured in dual role mode (CONFIG_USB_MUSB_DUAL_ROLE=y) >> >> The test case that I'm trying to solve