One more attempt at getting some feedback.
Original:
The FUSBH200 and FOTG210 are not EHCI-compatible and require standalone
drivers. See discussion at:
http://comments.gmane.org/gmane.linux.usb.general/84169
But these controllers do implement an EHCI-compatible debug port and
therefore leve
The FUSBH200 debug port has a EHCI-compatible register layout so there
is no need to define a custom struct.
Signed-off-by: Chris Rorvick
---
drivers/usb/host/fusbh200.h | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb/ho
The fusbh200_dbg_port struct is a copy of the ehci_dbg_port definition
in the header. Embedded in this definition are
a number of macros which came along for the ride. These macros are not
used in the fusbh200 driver and will conflict those in the new
header.
Signed-off-by: Chris Rorvick
---
If CONFIG_XEN_DOM0 is enabled, the ehci-dbgp driver notifies Xen of
controller reset events via xen_dbgp_reset_prep() and
xen_dbgp_external_startup() (via calls to xen_dbgp_op().) Otherwise
defines them as no-ops to disable this logic.
The fusbh200 driver copies much of the dbgp code from ehci_d
Now that ehci-dbgp has its own header, use it rather than duplicating
the declarations, etc.
Signed-off-by: Chris Rorvick
---
drivers/usb/host/fusbh200.h | 40 ++--
1 file changed, 2 insertions(+), 38 deletions(-)
diff --git a/drivers/usb/host/fusbh200.h b/dr
If CONFIG_XEN_DOM0 is enabled, the ehci-dbgp driver notifies Xen of
controller reset events via xen_dbgp_reset_prep() and
xen_dbgp_external_startup() (via calls to xen_dbgp_op().) Otherwise
defines them as no-ops to disable this logic.
The fotg210 driver copies much of the dbgp code from ehci_de
The fotg210_dbg_port struct is a copy of the ehci_dbg_port definition
in the header. Embedded in this definition are
a number of macros which came along for the ride. These macros are not
used in the fotg210 driver and will conflict those in the new
header.
Signed-off-by: Chris Rorvick
---
d
The FUSBH200 debug port has a EHCI-compatible register layout so there
is no need to define a custom struct.
Signed-off-by: Chris Rorvick
---
drivers/usb/host/fotg210.h | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/usb/host/fotg210.h b/drivers/usb/host
Specifying these attributes in both the prototype and the function
definition is unnecessary and could cause confusion or bugs if they are
inconsistent. As such, __init should only be specified at the function
definition.
Keith Owens suggested this as a janitorial task on LKML several years
ago:
Now that ehci-dbgp has its own header, use it rather than duplicating
the declarations, etc.
Signed-off-by: Chris Rorvick
---
drivers/usb/host/fotg210.h | 40 ++--
1 file changed, 2 insertions(+), 38 deletions(-)
diff --git a/drivers/usb/host/fotg210.h b/driv
The FUSBH200 and FOTG210 controllers implement sufficiently EHCI-
compatible debug ports to leverage ehci-dbgp from their respective
drivers. Rather than including header, though,
they replicate the necessary declarations in their own headers. Move
the ehci-dbgp stuff into its own header as a fi
Hayes Wang :
> David Miller [da...@davemloft.net]
[...]
> > If another thread of control sets the bit between the test and the
> > clear, you will lose an event.
>
> It is fine. The flag is used to schedule a tasklet, so if the tasklet is
> starting running, all the other plans for scheduling a
Use #defines instead of magic values.
Signed-off-by: Joe Perches
---
drivers/usb/storage/debug.c | 2 +-
include/linux/kern_levels.h | 13 +
kernel/printk/printk.c | 28 +---
lib/dynamic_debug.c | 4 ++--
4 files changed, 29 insertions(+), 18 de
Add documentation for device-tree binding of the generic gpio-vbus phy
controller.
Signed-off-by: Robert Jarzmik
Cc: devicet...@vger.kernel.org
---
.../devicetree/bindings/phy/gpio-vbus.txt | 23 ++
1 file changed, 23 insertions(+)
create mode 100644 Documentation/d
Add device-tree support for the generic gpio-vbus driver.
Signed-off-by: Robert Jarzmik
Cc: devicet...@vger.kernel.org
---
drivers/usb/phy/phy-gpio-vbus-usb.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/usb/phy/phy-gpio-vbus-usb.c
b/drivers/usb/phy/phy-gpio-vbus
In order to prepare device-tree conversion, port gpio_vbus to use
gpio_desc.
Signed-off-by: Robert Jarzmik
---
drivers/usb/phy/phy-gpio-vbus-usb.c | 105 +++-
1 file changed, 56 insertions(+), 49 deletions(-)
diff --git a/drivers/usb/phy/phy-gpio-vbus-usb.c
b/dr
David Miller [da...@davemloft.net]
> This is racey.
> If another thread of control sets the bit between the test and the
> clear, you will lose an event.
It is fine. The flag is used to schedule a tasklet, so if the tasklet is
starting running, all the other plans for scheduling a tasklet could
Hi Guys,
I have been having an issue with the ethernet on Arndale and it
bisects down to this commit:
commit 3cc81d85ee01e5a0b7ea2f4190e2ed1165f53c31
Author: Michel Stam
asix: Don't reset PHY on if_up for ASIX 88772
I am afraid I am not overly familiar with the USB or networking
subsystems. But
Am 02.11.2014 um 04:35 schrieb Lars Melin:
On 2014-11-01 23:01, Matthias Klein wrote:
Add ID of the Peiker LTE NAD for legacy serial interface
Signed-off-by: Matthias Klein
---
drivers/usb/serial/option.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/option.c b/dri
19 matches
Mail list logo
