From: Hayes Wang
Date: Fri, 17 Oct 2014 16:55:08 +0800
> Remove calling cancel_delayed_work_sync() for runtime suspend,
> because it would cause dead lock. Instead, return -EBUSY to
> avoid the device enters suspending if the net is running and
> the delayed work is pending or running. The delaye
that call is completely unnecessary because
usb_del_gadget_udc() already makes sure the
gadget driver is properly unregistered from
the UDC.
Signed-off-by: Felipe Balbi
---
found while reading code
drivers/usb/gadget/udc/net2272.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/
that call is completely unnecessary because
usb_del_gadget_udc() already makes sure the
gadget driver is properly unregistered from
the UDC.
Signed-off-by: Felipe Balbi
---
found while reading code
drivers/usb/gadget/udc/dummy_hcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/us
that call is completely unnecessary because
usb_del_gadget_udc() already makes sure the
gadget driver is properly unregistered from
the UDC.
Signed-off-by: Felipe Balbi
---
found while reading code
drivers/usb/gadget/udc/pxa27x_udc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/u
that call is completely unnecessary because
usb_del_gadget_udc() already makes sure the
gadget driver is properly unregistered from
the UDC.
Signed-off-by: Felipe Balbi
---
found while reading code
drivers/usb/dwc2/gadget.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/usb/
No functional changes, just adding a prefix
which should have been there from the start.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/configfs.c | 2 +-
drivers/usb/gadget/udc/udc-core.c | 4 ++--
include/linux/usb/gadget.h| 2 +-
3 files changed, 4 insertions(+), 4 deletions(-
Documentation/kbuild/kconfig-language.txt warns to use select with care,
and in general use select only for non-visible symbols and for symbols
with no dependencies, because select will force a symbol to a value
without visiting the dependencies.
Select has become particularly problematic, interde
These are the remaining patches from the initial serie.
They have been tested on pxa27x :
- on Felipe's testing/next branch (last commit "usb: gadget: remove
unnecessary 'driver' argument")
- with :
echo disconnect > /sys/class/udc/pxa27x-udc/soft_connect && sleep 1 &&
echo connect > /s
Use devm_* helpers in the probe function to simplify the error path and
the remove path.
Signed-off-by: Robert Jarzmik
Cc: Sergei Shtylyov
---
Since V1: Addressed Sergei's comments
Since V2: Addressed Sergei's comments on includes
Since V4: Addressed Sergei's comment on clk_uprepare in probe()
Add documentation for device-tree binding of arm PXA 27x udc (usb
device) driver.
Signed-off-by: Robert Jarzmik
Cc: devicet...@vger.kernel.org
Acked-by: Arnd Bergmann
---
Since V1: change OF id mrvl,pxa27x_udc -> marvell,pxa27x-udc
This is a consequence of other DT reviews on the marv
As the udc clock controls both the output signals and the internal IP,
it must be enabled before any UDC register is touched.
The bug is revealed when the clock framework disables the clock for a
couple of milliseconds during the boot sequence, and the endpoint
configuration is lost. The bug is hi
On Fri, 17 Oct 2014, Mark Knibbs wrote:
> On Fri, 17 Oct 2014 15:22:02 -0400 (EDT)
> Alan Stern wrote:
>
> > On Fri, 17 Oct 2014, Mark Knibbs wrote:
> >
> > > ...
> > > It looks like the 5000 timeout in usb_stor_euscsi_init() should be
> > > replaced
> > > by 5*HZ then?
> >
> > Yes, it does loo
Hi,
v2: Remove incorrect use of USB_CTRL_SET_TIMEOUT (=5000);
usb_stor_control_msg() timeout argument is actually specified in jiffies.
usb_stor_euscsi_init() enables multi-target mode for SCM eUSB SCSI bridge
devices. The control message it sends has wLength = 1 and the byte sent is
0x01. While
Hi,
After the recent linux-usb mailing list thread "usb_stor_control_msg()
timeout argument"...
The timeout argument to usb_stor_control_msg() is specified in jiffies, not
milliseconds.
Signed-off-by: Mark Knibbs
---
diff -up linux-3.17/drivers/usb/storage/initializers.c.orig
linux-3.17/drive
On Fri, 17 Oct 2014 15:22:02 -0400 (EDT)
Alan Stern wrote:
> On Fri, 17 Oct 2014, Mark Knibbs wrote:
>
> > ...
> > It looks like the 5000 timeout in usb_stor_euscsi_init() should be replaced
> > by 5*HZ then?
>
> Yes, it does look wrong. There may be other places that also call the
> function w
On Fri, 17 Oct 2014, Mark Knibbs wrote:
> Ah, thanks. Given that, it seems my recent patch
> "[PATCH] storage: Replace magic number with define in usb_stor_euscsi_init()"
> which replaced 5000 with USB_CTRL_SET_TIMEOUT wasn't correct, though that
> patch wouldn't change the compiled code.
>
> It
On Fri, Oct 17, 2014 at 12:35:39PM +0200, Marek Szyprowski wrote:
> Hello,
>
> On 2014-10-16 15:33, Felipe Balbi wrote:
> >On Thu, Oct 16, 2014 at 02:57:57PM +0200, Marek Szyprowski wrote:
> >>This patch adds a call to s3c_hsotg_disconnect() from 'end session'
> >>interrupt to correctly notify gad
From: Sudip Mukherjee
sparse was giving the following warning:
warning: context imbalance in 's3c_hsotg_ep_enable'
- different lock contexts for basic block
we were returning ENOMEM while still holding the spinlock.
The sparse warning was fixed by releasing the sp
On Fri, Oct 17, 2014 at 09:08:51PM +0200, Robert Jarzmik wrote:
> Felipe Balbi writes:
>
> > Hi,
> >
> > On Fri, Oct 17, 2014 at 08:06:45PM +0200, Robert Jarzmik wrote:
> >> Felipe Balbi writes:
> >>
> >> Thanks Felipe.
> >>
> >> Can I post now the remaining 3 patches of the partial serie, ie.
On Fri, Oct 17, 2014 at 07:05:19PM +, Paul Zimmerman wrote:
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Friday, October 17, 2014 11:52 AM
> >
> > On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote:
> > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> > > >
Felipe Balbi writes:
> Hi,
>
> On Fri, Oct 17, 2014 at 08:06:45PM +0200, Robert Jarzmik wrote:
>> Felipe Balbi writes:
>>
>> Thanks Felipe.
>>
>> Can I post now the remaining 3 patches of the partial serie, ie. :
>> - usb: gadget: pxa27x_udc device-tree documentation
>> - usb: gadget: pxa27x
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Friday, October 17, 2014 11:52 AM
>
> On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote:
> > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> > > Sent: Thursday, October 16, 2014 9:44 PM
> > >
> > > sparse was giving the
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/net2280.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/driv
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> Sent: Thursday, October 16, 2014 9:44 PM
>
> modified the function to have a single return statement at the end
> instead of multiple return statement in the middle of the function
> to improve the readability of the code.
>
> This pat
On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote:
> > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> > Sent: Thursday, October 16, 2014 9:44 PM
> >
> > sparse was giving the following warning:
> > warning: context imbalance in 's3c_hsotg_ep_enable'
> >
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> Sent: Thursday, October 16, 2014 9:44 PM
>
> sparse was giving the following warning:
> warning: context imbalance in 's3c_hsotg_ep_enable'
> - different lock contexts for basic block
>
> we were returning
Hi,
On Fri, Oct 17, 2014 at 06:41:04PM +, Paul Zimmerman wrote:
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Friday, October 17, 2014 8:00 AM
> >
> > On Fri, Oct 17, 2014 at 04:53:41PM +0800, Huang Rui wrote:
> > > AMD NL needs to suspend usb3 ss phy, but this doesn't enable on simu
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Friday, October 17, 2014 8:00 AM
>
> On Fri, Oct 17, 2014 at 04:53:41PM +0800, Huang Rui wrote:
> > AMD NL needs to suspend usb3 ss phy, but this doesn't enable on simulation
> > board.
> >
> > Signed-off-by: Huang Rui
> > ---
> > drivers/usb/dw
Hi,
On Fri, Oct 17, 2014 at 08:06:45PM +0200, Robert Jarzmik wrote:
> Felipe Balbi writes:
>
> Thanks Felipe.
>
> Can I post now the remaining 3 patches of the partial serie, ie. :
> - usb: gadget: pxa27x_udc device-tree documentation
> - usb: gadget: pxa27x_udc: use devm_* helpers
> - usb:
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> Sent: Friday, October 17, 2014 3:03 AM
>
> On Fri, Oct 17, 2014 at 09:02:00AM +, David Laight wrote:
> > From: Of Sudip Mukherjee
> > > modified the function to have a single return statement at the end
> > > instead of multiple ret
Felipe Balbi writes:
Thanks Felipe.
Can I post now the remaining 3 patches of the partial serie, ie. :
- usb: gadget: pxa27x_udc device-tree documentation
- usb: gadget: pxa27x_udc: use devm_* helpers
- usb: gadget: pxa27x_udc: fix clock prepare and enable
Do you want me to rebase against a
On Fri, 17 Oct 2014 12:53:45 -0400 (EDT)
Alan Stern wrote:
> On Fri, 17 Oct 2014, Mark Knibbs wrote:
>
> > In include/linux/usb.h, there is
> > /*
> > * timeouts, in milliseconds, used for sending/receiving control messages
> > * they typically complete within a few frames (msec) after they're
I noticed that this has been missing for quite
some time so I decided it was about time to
document it.
Signed-off-by: Felipe Balbi
---
Documentation/ABI/stable/sysfs-class-udc | 93
1 file changed, 93 insertions(+)
create mode 100644 Documentation/ABI/stable/sy
From: George Cherian
Enabling the core interrupts in complete is too late for
XHCI, and stops it from proper operation. The root of the
problem is due to a disagreement between dwc3-omap and XHCI
about when IRQs should be enabled.
As it turns out, ->resume's documentation states that:
"... gene
From: Yoshihiro Shimoda
To support both usb PHY and generic PHY, this patch cleans up rcar2.c.
Signed-off-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/renesas_usbhs/rcar2.c | 48 +--
1 file changed, 26 insertions(+), 22 deletions(-)
di
We know that our udc points to our gadget and our
gadget_driver, simplify the interface by passing
a single argument.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/udc-core.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/gadget/ud
now that we provide generic register/unregister
debugging messages from udc-core, we can remove
the same messages from this driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/net2272.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/u
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/renesas_usbhs/common.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/common.c
b/drivers/usb/r
Using ->prepare()/->complete() to mask/unmask
IRQs is wrong at least for dwc3. We need to
make sure that by the end of ->resume(), IRQs
are working and ready to fire because a child
device may need working IRQs for its own ->resume()
method.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/core.
now that we provide generic register/unregister
debugging messages from udc-core, we can remove
the same messages from this driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/s3c-hsudc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/gadget/udc/s3c-hsudc.c
b/dri
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/phy/phy-rcar-gen2-usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c
b/drivers/usb
now that we provide generic register/unregister
debugging messages from udc-core, we can remove
the same messages from this driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/dummy_hcd.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/udc/
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/net2272.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers
now that we provide generic register/unregister
debugging messages from udc-core, we can remove
the same messages from this driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/at91_udc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/at91_udc.c
b/drivers/
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/phy/phy-msm-usb.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/ph
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/at91_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb
From: Robert Jarzmik
Convert the mach info, and store the udc_command in the pxa_udc control
structure.
It is to be noticed that the udc_is_connected() in mach info is not
transfered. This was not used, as mioa701 machine doesn't need it,
balloon3 doesn't really use it, and most importantly the
From: Robert Jarzmik
Add support for device-tree device discovery. If devicetree is not
provided, fallback to legacy platform data "discovery".
Signed-off-by: Robert Jarzmik
Cc: devicet...@vger.kernel.org
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/pxa27x_udc.c | 11 +++
1
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/phy/phy-tegra-usb.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/ph
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/lpc32xx_udc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/udc
Currently, we're printing gadget driver name when
registering and UDC name when unregistering. Standardize
on always printing gadget driver name.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/udc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadg
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/mv_udc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/phy/phy-rcar-usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/phy/phy-rcar-usb.c b/drivers/usb/phy/phy-rc
Add TRB tracepoints for ep0 TRBs as that
might help finding bugs with ep0 handling.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/ep0.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
index ee216c6..4182210 100644
--- a/drivers/usb/dwc
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/musb_gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/us
From: Robert Jarzmik
For this preparation, a preliminary cleanup is done :
- convert the probing of pxa27x_udc to gpio_desc.
The conversion is partial because :
- the platform data still provides a gpio number, not a gpio desc
Signed-off-by: Robert Jarzmik
Signed-off-by: Felipe Balbi
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/s3c-hsudc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/s3c-hsudc.c
b/drivers/usb/g
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/phy/phy-mxs-usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/davinci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c
ind
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/omap2430.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/us
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/dummy_hcd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drive
now that we provide generic register/unregister
debugging messages from udc-core, we can remove
the same messages from this driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/phy/phy-am335x-control.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/phy/phy-am335x-control.c
b/drivers/u
now that we provide generic register/unregister
debugging messages from udc-core, we can remove
the same messages from this driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/gr_udc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/us
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/pxa27x_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/u
now that no UDC driver relies on the extra
'driver' argument to ->udc_stop(), we can
safely remove it.
Signed-off-by: Felipe Balbi
---
drivers/usb/chipidea/udc.c | 6 ++
drivers/usb/dwc2/gadget.c | 3 +--
drivers/usb/dwc3/gadget.c | 3 +--
drivers/usb
From: Vinod Koul
The drivers should use dmaengine_terminate_all() or dmaengine_slave_config()
API instead of accessing the device_control which will be deprecated soon
Signed-off-by: Vinod Koul
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/ux500_dma.c | 7 ++-
1 file changed, 2 inserti
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/s3c-hsudc.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/dr
From: Heikki Krogerus
Adding ACPI ID used on newer Intel SoCs.
Signed-off-by: Heikki Krogerus
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/core.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 1384300..4d4e854 100
In case we unload a gadget driver while any of
os_desc_req or req are still pending, we need
to make sure to dequeue them.
By using our setup_pending and os_desc_pending
flags we achieve that in a way that doesn't
cause any regressions because we won't dequeue
a request which was already completed
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/amd5536udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/u
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/mv_u3d_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/
now that we provide generic register/unregister
debugging messages from udc-core, we can remove
the same messages from this driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/net2280.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers
DWC3's GUID register is supposed to be used to write
any sort of version we might want. It helps when getting
bug reports for platforms you don't have HW to know
which kernel version of the driver was running on the
platform.
Because we don't really track driver version, but we _do_
track the kern
when disconnecting from host using our soft_connect
sysfs interface, also let the gadget driver know about
it by calling the gadget driver's ->disconnect()
method.
No problems have been found while not calling ->disconnect()
so far, it's just good convention.
Signed-off-by: Felipe Balbi
---
dri
now that we provide generic register/unregister
debugging messages from udc-core, we can remove
the same messages from this driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/fsl_qe_udc.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c
b/dr
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/bcm63xx_udc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c
b/drivers/u
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/pxa25x_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/u
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/ux500.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
index dc6
Some gadget/function drivers might want to do
improper request recycling by allocating a single
request from one particular endpoint and queueing
it to another completely unrelated endpoint.
One such case was found with f_loopback.c.
To prevent such cases from happening again, let's
WARN() so we
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/fsl_qe_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
future patches will remove the extra 'driver'
argument to ->udc_stop(), in order to do that,
we must make sure that our UDC does not rely
on it first.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/net2280.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/driver
now that we provide generic register/unregister
debugging messages from udc-core, we can remove
the same messages from this driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/musb_gadget.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/phy/phy-mv-usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/phy/phy-mv-usb.c b/drivers/usb/phy/phy-mv-usb
From: Heikki Krogerus
Most devices are configured for 32-bit DMA addresses.
Setting the mask to 32-bit here removes the need for the
drivers to do it separately.
Acked-by: Rafael J. Wysocki
Signed-off-by: Heikki Krogerus
Signed-off-by: Felipe Balbi
---
drivers/acpi/acpi_platform.c | 2 ++
1
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/musb_dsps.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsp
tracing infrastructure already adds those for us.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/ep0.c | 18 +-
drivers/usb/dwc3/trace.h | 8
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
index 0a34e
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/tusb6010.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/musb/tusb6010.c b/drivers/usb/musb/tusb6010.c
whenever we get a Disconnect Interrupt, we should
make sure to update out udc state to NOT_ATTACHED,
otherwise sysfs will show wrong values.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/gadget.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/fsl_qe_udc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c
b/drivers/usb/gadget/udc/fsl_qe_u
by doing that we will be able to match our
requests against req and os_desc_req and also
clear our pending flags from complete callback.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/composite.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/gadget/composite.c b/driv
From: Dan Carpenter
This NULL check sets off a static checker warning because we already
dereferenced "card" earlier in the function. However, since "card" is
never NULL so we can just remove the check.
Signed-off-by: Dan Carpenter
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/function/
From: Yoshihiro Shimoda
To support a generic phy driver in this driver later, this patch
renames "struct usb_phy *phy" to "struct usb_phy *usb_phy".
Signed-off-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/renesas_usbhs/common.h | 2 +-
drivers/usb/renesas_usbhs/rcar2.c
From: Yoshihiro Shimoda
This patch adds support for the generic PHY. The generic PHY will be
used in multiplatform environment.
Acked-by: Kishon Vijay Abraham I
Signed-off-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/renesas_usbhs/common.h | 1 +
drivers/usb/renesas_usb
From: Andrzej Pietrasiewicz
USB gadgets composed with configfs lack suspend and resume
methods. This patch uses composite_suspend()/composite_resume()
the same way e.g. composite_setup() or composite_disconnect()
are used in a configfs-based gadget.
Signed-off-by: Andrzej Pietrasiewicz
Signed-o
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/blackfin.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackf
From: Peter Chen
The memory subsystem has already had similar message for it.
Signed-off-by: Peter Chen
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/mv_udc_core.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/udc/mv_udc_core.c
b/drivers
These flags we be set to true whenever their
matching request is queued. They will be cleared
to false when that request completes.
Signed-off-by: Felipe Balbi
---
include/linux/usb/composite.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/usb/composite.h b/include/linux
From: Heikki Krogerus
If the probe drivers have already set the dma_mask, not
replacing the value.
Signed-off-by: Heikki Krogerus
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/core.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drive
Hi folks,
here's a giant set of patches which I already have pending
for v3.19 merge window. They still sit in my testing/next
and will only be moved to next once all fixes reach v3.18-rc.
Until then, I will keep rebasing them.
Note that for this set to properly work, we are still pending
a fix
1 - 100 of 206 matches
Mail list logo
