Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

2014-09-28 Thread Chen Gang
On 9/29/14 9:52, Greg Kroah-Hartman wrote: > On Wed, Sep 24, 2014 at 11:41:55AM -0400, Alan Stern wrote: >> On Mon, 22 Sep 2014, Michal Simek wrote: >> >>> Alan: Can you please add this patch to your queue? >>> Greg: If Alan is not maintaining this part of kernel, is this patch in your >>> queue?

Re: [PATCH 2/6] phy: improved lookup method

2014-09-28 Thread Kishon Vijay Abraham I
On Thursday 25 September 2014 12:30 PM, Heikki Krogerus wrote: > Assume you have 2 phys in your system.. > static struct phy_lookup usb_lookup = { > .phy_name = "phy-usb.0", > .dev_id = "usb.0", > .con_id = "usb", >>>

Re: [PATCH] drivers: usb :fsl: Add support for USB controller version-2.5

2014-09-28 Thread Greg KH
On Mon, Sep 29, 2014 at 03:46:02AM +, nikhil.bad...@freescale.com wrote: > >-Original Message- > >From: Greg KH [mailto:g...@kroah.com] > >Sent: Wednesday, September 24, 2014 10:19 AM > >To: Badola Nikhil-B46172 > >Cc: linux-usb@vger.kernel.org > >Subject: Re: [PATCH] drivers: usb :fsl:

[PATCH v5 RESEND 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-28 Thread Vivek Gautam
Now that we have completely moved from older USB-PHY drivers to newer GENERIC-PHY drivers for PHYs available with USB controllers on Exynos series of SoCs, we can remove the support for the same in our host drivers too. We also defer the probe for our host in case we end up getting EPROBE_DEFER er

Re: [PATCH v5 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-28 Thread Vivek Gautam
On Mon, Sep 29, 2014 at 7:21 AM, Greg KH wrote: > On Thu, Sep 25, 2014 at 10:50:22AM +0530, Vivek Gautam wrote: >> Hi Greg, >> >> >> On Mon, Sep 22, 2014 at 11:15 AM, Vivek Gautam >> wrote: >> > Now that we have completely moved from older USB-PHY drivers >> > to newer GENERIC-PHY drivers for PH

Re: [PATCH v5 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-28 Thread Greg KH
On Thu, Sep 25, 2014 at 10:50:22AM +0530, Vivek Gautam wrote: > Hi Greg, > > > On Mon, Sep 22, 2014 at 11:15 AM, Vivek Gautam > wrote: > > Now that we have completely moved from older USB-PHY drivers > > to newer GENERIC-PHY drivers for PHYs available with USB controllers > > on Exynos series o

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

2014-09-28 Thread Greg Kroah-Hartman
On Wed, Sep 24, 2014 at 11:41:55AM -0400, Alan Stern wrote: > On Mon, 22 Sep 2014, Michal Simek wrote: > > > Hi Alan and Greg, > > > > On 09/20/2014 06:19 AM, Chen Gang wrote: > > > Hello Maintainers: > > > > > > Please help check this patch, when you have time. > > > > > > Thanks. > > > > > >

[RFC RESEND 00/10] Create separate header for ehci-dbgp driver

2014-09-28 Thread Chris Rorvick
Is there any interest in something like this? Original: The FUSBH200 and FOTG210 are not EHCI-compatible and require standalone drivers. See discussion at: http://comments.gmane.org/gmane.linux.usb.general/84169 But these controllers do implement an EHCI-compatible debug port and therefore l

[RFC RESEND 02/10] fusbh200: Make Xen notificaiton consistent with EHCI

2014-09-28 Thread Chris Rorvick
If CONFIG_XEN_DOM0 is enabled, the ehci-dbgp driver notifies Xen of controller reset events via xen_dbgp_reset_prep() and xen_dbgp_external_startup() (via calls to xen_dbgp_op().) Otherwise defines them as no-ops to disable this logic. The fusbh200 driver copies much of the dbgp code from ehci_d

[RFC RESEND 04/10] fusbh200: Remove duplicate ehci-dbgp declarations

2014-09-28 Thread Chris Rorvick
Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b/dr

[RFC RESEND 06/10] fotg210: Make Xen notificaiton consistent with EHCI

2014-09-28 Thread Chris Rorvick
If CONFIG_XEN_DOM0 is enabled, the ehci-dbgp driver notifies Xen of controller reset events via xen_dbgp_reset_prep() and xen_dbgp_external_startup() (via calls to xen_dbgp_op().) Otherwise defines them as no-ops to disable this logic. The fotg210 driver copies much of the dbgp code from ehci_de

[RFC RESEND 05/10] fusbh200: Use ehci_dbg_port struct

2014-09-28 Thread Chris Rorvick
The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fusbh200.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fusbh200.h b/drivers/usb/ho

[RFC RESEND 01/10] usb: Create separate header for ehci-dbgp

2014-09-28 Thread Chris Rorvick
The FUSBH200 and FOTG210 controllers implement sufficiently EHCI- compatible debug ports to leverage ehci-dbgp from their respective drivers. Rather than including header, though, they replicate the necessary declarations in their own headers. Move the ehci-dbgp stuff into its own header as a fi

[RFC RESEND 03/10] fusbh200: Remove superfluous macro definitions

2014-09-28 Thread Chris Rorvick
The fusbh200_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fusbh200 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick ---

[RFC RESEND 07/10] fotg210: Remove superfluous macro definitions

2014-09-28 Thread Chris Rorvick
The fotg210_dbg_port struct is a copy of the ehci_dbg_port definition in the header. Embedded in this definition are a number of macros which came along for the ride. These macros are not used in the fotg210 driver and will conflict those in the new header. Signed-off-by: Chris Rorvick --- d

[RFC RESEND 08/10] fotg210: Remove duplicate ehci-dbgp declarations

2014-09-28 Thread Chris Rorvick
Now that ehci-dbgp has its own header, use it rather than duplicating the declarations, etc. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/usb/host/fotg210.h b/driv

[RFC RESEND 09/10] fotg210: Use ehci_dbg_port struct

2014-09-28 Thread Chris Rorvick
The FUSBH200 debug port has a EHCI-compatible register layout so there is no need to define a custom struct. Signed-off-by: Chris Rorvick --- drivers/usb/host/fotg210.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fotg210.h b/drivers/usb/host

[RFC RESEND 10/10] usb: Remove __init from early_dbgp_init() prototype

2014-09-28 Thread Chris Rorvick
Specifying these attributes in both the prototype and the function definition is unnecessary and could cause confusion or bugs if they are inconsistent. As such, __init should only be specified at the function definition. Keith Owens suggested this as a janitorial task on LKML several years ago:

RE: [PATCH] drivers: usb :fsl: Add support for USB controller version-2.5

2014-09-28 Thread nikhil.bad...@freescale.com
>-Original Message- >From: Greg KH [mailto:g...@kroah.com] >Sent: Wednesday, September 24, 2014 10:19 AM >To: Badola Nikhil-B46172 >Cc: linux-usb@vger.kernel.org >Subject: Re: [PATCH] drivers: usb :fsl: Add support for USB controller >version-2.5 > >On Thu, Aug 21, 2014 at 12:56:22PM +0530

RE: [PATCH] drivers: usb :fsl: Add support for USB controller version-2.5

2014-09-28 Thread nikhil.bad...@freescale.com
>-Original Message- >From: Greg KH [mailto:g...@kroah.com] >Sent: Wednesday, September 24, 2014 10:18 AM >To: Badola Nikhil-B46172 >Cc: linux-usb@vger.kernel.org >Subject: Re: [PATCH] drivers: usb :fsl: Add support for USB controller >version-2.5 > >On Thu, Aug 21, 2014 at 12:56:22PM +0530

[PATCH v2 1/1] usb: chipidea: using devm_request_irq to instead of request_irq

2014-09-28 Thread Peter Chen
Using devm_request_irq to instead of request_irq. Found-by: Arnd Bergmann Signed-off-by: Peter Chen --- Changes at v2: - Add miss "device" parameter for devm_reqeust_irq drivers/usb/chipidea/core.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-28 Thread Huang Rui
On Sun, Sep 28, 2014 at 06:46:14PM -0500, Felipe Balbi wrote: > Hi, > > On Sun, Sep 28, 2014 at 05:18:58PM +0800, Huang Rui wrote: > > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > > Sent: Friday, September 26, 2014 5:54 PM > > > > > > > > > > On Fri, Sep 26, 2014 at 11:18:48PM +, Pa

[PATCH 1/1] usb: core: return -ENOTSUPP for all targeted hosts

2014-09-28 Thread Peter Chen
The current code only returns -ENOTSUPP for OTG host, but in fact, embedded host also needs to returns -ENOTSUPP if the peripheral is not at TPL. Signed-off-by: Peter Chen --- Hi Greg, If the time is ok, it is for 3.18-rc1, otherwise, it is a bugfix for 3.18, thanks. drivers/usb/core/hub.c |

Re: [RFC PATCH 4/4] usb: dwc3: introduce dual role switch function with debugfs

2014-09-28 Thread Huang Rui
On Fri, Sep 26, 2014 at 09:35:55AM -0500, Felipe Balbi wrote: > Hi, > > On Fri, Sep 26, 2014 at 05:22:09PM +0800, Huang Rui wrote: > > > What you need here is something to talk to usbcore and udc-core and > > > orchestrate the mode change through usb_add_hcd()/usb_add_gadget_udc() > > > and their

[PATCH 1/1] usb: chipidea: using devm_request_irq to instead of request_irq

2014-09-28 Thread Peter Chen
Using devm_request_irq to instead of request_irq. Found-by: Arnd Bergmann Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 3df5005..8bae48a 100644 -

Re: [PATCH v6 0/7] usb: add support for the generic PHY framework

2014-09-28 Thread Peter Chen
On Tue, Sep 23, 2014 at 12:11:55PM +0200, Antoine Tenart wrote: > Patches can also be found at: > git://git.free-electrons.com:users/antoine-tenart/linux.git usb-phy > > The series applies on top of Sergei generic PHY support in HCD[1] > and on top of Peter Chen's ci-for-usb-next branch[2]. > > T

Re: problems with usb stick after suspend and wake up

2014-09-28 Thread Norbert Preining
Hi Alan, sorry for the journalctl output. I have now done the following:L * boot into 3.17-rc7 * mount the usb stick (recovery completed) * unmount, mount, unmount - just to be sure all is fine * started usbmon capturing on bus 3 * mount the usb stick * suspend to ram * wake up now the st

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-28 Thread Felipe Balbi
Hi, On Sun, Sep 28, 2014 at 05:18:58PM +0800, Huang Rui wrote: > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Friday, September 26, 2014 5:54 PM > > > > > > > > On Fri, Sep 26, 2014 at 11:18:48PM +, Paul Zimmerman wrote: > > > > > > From: Felipe Balbi [mailto:ba...@ti.com] > >

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-28 Thread Felipe Balbi
Hi, On Sun, Sep 28, 2014 at 11:11:23AM +0800, Huang Rui wrote: > On Fri, Sep 26, 2014 at 09:35:21AM -0500, Felipe Balbi wrote: > > On Fri, Sep 26, 2014 at 04:50:26PM +0800, Huang Rui wrote: > > > On Thu, Sep 25, 2014 at 09:50:32AM -0500, Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Thu, Sep

Re: [PATCH net-next 0/3] r8152: support setting eee by ethtool

2014-09-28 Thread David Miller
From: Hayes Wang Date: Thu, 25 Sep 2014 20:53:59 +0800 > Modify some definitions about EEE, and add the support of setting > the EEE through ethtool. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.

Re: Regression: USB 3.0 stick only running at USB 2.0 speed

2014-09-28 Thread Julian Andres Klode
On Mon, Sep 15, 2014 at 4:14 PM, Greg KH wrote: > On Mon, Sep 15, 2014 at 04:07:30PM +0200, Julian Andres Klode wrote: >> [Originally reported at >> https://bugzilla.kernel.org/show_bug.cgi?id=84611, gregkh told me to >> report it here] >> >> My brother's USB 3.0 stick is only recognized as USB 2.

Re: Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-09-28 Thread Mark Knibbs
On Thu, 25 Sep 2014 11:15:40 -0400 (EDT) Alan Stern wrote: > On Wed, 24 Sep 2014, Mark Knibbs wrote: > > > On Wed, 24 Sep 2014 11:37:11 -0400 (EDT) > > Alan Stern wrote: > > > > > On Wed, 24 Sep 2014, Mark Knibbs wrote: > > > > > > > I did some benchmarks to check the maximum transfer rate of

Re: [PATCH fix for 3.17 1/2] xhci: Check for eps[ep_index].ring being NULL after an usb_device_reset

2014-09-28 Thread Alan Stern
On Sun, 28 Sep 2014, Hans de Goede wrote: > >> The problem is the following call sequence (simplified): > >> > >> 1) usb_reset_device > >> 2) usb_reset_and_verify_device > >> 2) hub_port_init > >> 3)hub_port_finish_reset > >> 3) xhci_discover_or_reset_device > >> This frees xhci

Re: [PATCH fix for 3.17 1/2] xhci: Check for eps[ep_index].ring being NULL after an usb_device_reset

2014-09-28 Thread Hans de Goede
Hi, On 09/28/2014 04:29 PM, Alan Stern wrote: > On Sat, 27 Sep 2014, Hans de Goede wrote: > >> This commit fixes the following oops: >> >> [10238.622067] scsi host3: uas_eh_bus_reset_handler start >> [10240.766164] usb 3-4: reset SuperSpeed USB device number 3 using xhci_hcd >> [10245.779365] usb

Re: [PATCH fix for 3.17 1/2] xhci: Check for eps[ep_index].ring being NULL after an usb_device_reset

2014-09-28 Thread Alan Stern
On Sat, 27 Sep 2014, Hans de Goede wrote: > This commit fixes the following oops: > > [10238.622067] scsi host3: uas_eh_bus_reset_handler start > [10240.766164] usb 3-4: reset SuperSpeed USB device number 3 using xhci_hcd > [10245.779365] usb 3-4: device descriptor read/8, error -110 > [10245.883

Re: problems with usb stick after suspend and wake up

2014-09-28 Thread Alan Stern
On Sun, 28 Sep 2014, Norbert Preining wrote: > Hi Alan, > > thanks for your answer. > > > I do not recognize this problem based on your description. Please post > > the dmesg log. > > Here cleaned output of journalctl, removed mainly networkmanager stuff. I would have preferred to see the ou

Re: [PATCH fix for 3.17 1/2] xhci: Check for eps[ep_index].ring being NULL after an usb_device_reset

2014-09-28 Thread Ben Hutchings
On Sat, 2014-09-27 at 15:01 +0200, Hans de Goede wrote: [...] > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -1146,10 +1146,12 @@ unsigned int xhci_last_valid_endpoint(u32 added_ctxs) > * returns 0 this is a root hub; returns -EINVAL for NULL pointers. > */ > static int x

Re: problems with usb stick after suspend and wake up

2014-09-28 Thread Norbert Preining
Hi Alan, thanks for your answer. > I do not recognize this problem based on your description. Please post > the dmesg log. Here cleaned output of journalctl, removed mainly networkmanager stuff. This is about a wake up after sleep, where before the stick was ok. More details necessary, let m

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-28 Thread Huang Rui
On Fri, Sep 26, 2014 at 11:30:44PM -0500, Felipe Balbi wrote: > Hi, > > On Sat, Sep 27, 2014 at 01:05:46AM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Friday, September 26, 2014 5:54 PM > > > > > > On Fri, Sep 26, 2014 at 11:18:48PM +, Paul Zimmerma