[PATCH v2 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-09-24 Thread Muthu Mani
Adds support for USB-I2C/GPIO interfaces of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. Details about the device can be found at: http://www.cypress.com/?rID=84126 Signed-off-by: Muthu Mani Signed-off-by: Rajaram Regupathy --- drivers/mfd/Kconfig | 12 +++ drivers/

RE: [PATCH 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-09-24 Thread Muthu Mani
> -Original Message- > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold > Sent: Monday, September 22, 2014 4:29 PM > To: Muthu Mani > Cc: Samuel Ortiz; Lee Jones; Wolfram Sang; linux-...@vger.kernel.org; Linus > Walleij; Alexandre Courbot; linux-g...@vger.kernel.org;

[PATCH v2 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-09-24 Thread Muthu Mani
Adds support for USB-GPIO interface of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. The GPIO get/set can be done through vendor command on control endpoint. Details about the device can be found at: http://www.cypress.com/?rID=84126 Signed-off-by: Muthu Mani Signed-off-by: Raja

[PATCH v2 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

2014-09-24 Thread Muthu Mani
Adds support for USB-I2C interface of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. The read/write operation is setup using vendor command through control endpoint and actual data transfer happens through bulk in/out endpoints. Details about the device can be found at: http://www.

RE: [PATCH 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-09-24 Thread Muthu Mani
> -Original Message- > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold > Sent: Monday, September 22, 2014 5:14 PM > To: Muthu Mani > Cc: Samuel Ortiz; Lee Jones; Wolfram Sang; linux-...@vger.kernel.org; Linus > Walleij; Alexandre Courbot; linux-g...@vger.kernel.org;

RE: [PATCH 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

2014-09-24 Thread Muthu Mani
> -Original Message- > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold > Sent: Monday, September 22, 2014 5:00 PM > To: Muthu Mani > Cc: Samuel Ortiz; Lee Jones; Wolfram Sang; linux-...@vger.kernel.org; Linus > Walleij; Alexandre Courbot; linux-g...@vger.kernel.org;

Re: [PATCH v5 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-24 Thread Vivek Gautam
Hi Greg, On Mon, Sep 22, 2014 at 11:15 AM, Vivek Gautam wrote: > Now that we have completely moved from older USB-PHY drivers > to newer GENERIC-PHY drivers for PHYs available with USB controllers > on Exynos series of SoCs, we can remove the support for the same > in our host drivers too. > > W

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi again, On Wed, Sep 24, 2014 at 09:40:37PM -0500, Felipe Balbi wrote: > On Thu, Sep 25, 2014 at 01:37:05AM +, Paul Zimmerman wrote: > > > > > Then, after the host cleared the halt, the gadget apparently sent the > > > > > data that _should_ have been sent previously. The host was expecting

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Thu, Sep 25, 2014 at 01:37:05AM +, Paul Zimmerman wrote: > > > > Then, after the host cleared the halt, the gadget apparently sent the > > > > data that _should_ have been sent previously. The host was expecting > > > > to receive the CSW at this point, so there was an overflow error.

RE: g_mass_storage bug ?

2014-09-24 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Wednesday, September 24, 2014 12:18 PM > > On Wed, Sep 24, 2014 at 01:08:15PM -0500, Felipe Balbi wrote: > > On Wed, Sep 24, 2014 at 01:53:31PM -0400, Alan Stern wrote: > > > On We

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Peter Chen
On Tue, Sep 23, 2014 at 12:28:03PM +0200, Antoine Tenart wrote: > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock > and DMA mask, to support USB2 ChipIdea controllers that don't need > specific functions. > > Tested on the Marvell Berlin SoCs USB controllers. > > Signed-off-by: A

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Peter Chen
On Wed, Sep 24, 2014 at 02:23:38PM +0200, Arnd Bergmann wrote: > On Wednesday 24 September 2014 19:29:05 Peter Chen wrote: > > > > So, it is IP CORE LIB (you suggest) vs IP CORE Platform Driver > > (dwc3, musb, chipidea) you are talking about, right? Except for > > creating another platform driver

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Sören Brinkmann
On Tue, 2014-09-23 at 12:28PM +0200, Antoine Tenart wrote: > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock > and DMA mask, to support USB2 ChipIdea controllers that don't need > specific functions. > > Tested on the Marvell Berlin SoCs USB controllers. > > Signed-off-by: Antoin

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 05:18:30PM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 11:41:55PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 24, 2014 at 03:59:36PM -0500, Felipe Balbi wrote: > > > On Wed, Sep 24, 2014 at 10:43:17PM +0200, Michal Sojka wrote: > > > > This adds LED triggers fo

Re: [PATCH v6 3/4] usb: Rename usb-common.c

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 10:43:20PM +0200, Michal Sojka wrote: > In the next commit, we will want the usb-common module to be composed of > two object files. Since Kbuild cannot "append" another object to an > existing one, we need to rename usb-common.c to something > else (common.c) and create usb

Re: [PATCH v6 2/4] usb: gadget: Refactor request completion

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 10:43:19PM +0200, Michal Sojka wrote: > Use the recently introduced usb_gadget_giveback_request() in favor of > direct invocation of the completion routine. > > All places in drivers/usb/ matching "[-.]complete(" were replaced with a > call to usb_gadget_giveback_request().

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:41:55PM +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 24, 2014 at 03:59:36PM -0500, Felipe Balbi wrote: > > On Wed, Sep 24, 2014 at 10:43:17PM +0200, Michal Sojka wrote: > > > This adds LED triggers for USB host and device. First two patches > > > refactor UDC drivers as

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-24 Thread Greg Kroah-Hartman
On Wed, Sep 24, 2014 at 03:59:36PM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 10:43:17PM +0200, Michal Sojka wrote: > > This adds LED triggers for USB host and device. First two patches > > refactor UDC drivers as requested by Felipe Balbi, the next renames a > > file and the last is the

[PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Robert Jarzmik
For this preparation, a preliminary cleanup is done : - convert the probing of pxa27x_udc to gpio_desc. The conversion is partial because : - the platform data still provides a gpio number, not a gpio desc - the "invert" attribute is lost, hence a loss in the translation The drawba

[PATCH v6 partial v2 2/3] usb: gadget: pxa27x_udc: transfer mach_info into pxa_udc

2014-09-24 Thread Robert Jarzmik
Convert the mach info, and store the udc_command in the pxa_udc control structure. It is to be noticed that the udc_is_connected() in mach info is not transfered. This was not used, as mioa701 machine doesn't need it, balloon3 doesn't really use it, and most importantly the current driver never us

[PATCH v6 partial v2 3/3] usb: gadget: pxa27x_udc: add devicetree support

2014-09-24 Thread Robert Jarzmik
Add support for device-tree device discovery. If devicetree is not provided, fallback to legacy platform data "discovery". Signed-off-by: Robert Jarzmik Cc: devicet...@vger.kernel.org --- Since V1: change OF id mrvl,pxa27x_udc -> marvell,pxa27x-udc This is a consequence of other DT rev

Re: [PATCH v6 1/4] usb: gadget: Introduce usb_gadget_giveback_request()

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 10:43:18PM +0200, Michal Sojka wrote: > All USB peripheral controller drivers call completion routines directly. > This patch adds usb_gadget_giveback_request() which will be used instead > of direct invocation in the next patch. The goal here is to have a place > where comm

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 10:43:17PM +0200, Michal Sojka wrote: > This adds LED triggers for USB host and device. First two patches > refactor UDC drivers as requested by Felipe Balbi, the next renames a > file and the last is the actual implementation of the LED triggers. > > Changes from v5: > - R

Re: [PATCH v6 4/4] usb: Add LED triggers for USB activity

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 10:43:21PM +0200, Michal Sojka wrote: > With this patch, USB activity can be signaled by blinking a LED. There > are two triggers, one for activity on USB host and one for USB gadget. > > Both triggers should work with all host/device controllers. Tested only > with mu

Re: [PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 10:44:23PM +0200, Robert Jarzmik wrote: > > On Wed, Sep 24, 2014 at 10:14:53PM +0200, Robert Jarzmik wrote: > > if you reply like this again I'll start ignoring your patches. Settle > > down, I'm trying to help you get your patches merged. > > > > With that said: > > >

[PATCH v6 2/4] usb: gadget: Refactor request completion

2014-09-24 Thread Michal Sojka
Use the recently introduced usb_gadget_giveback_request() in favor of direct invocation of the completion routine. All places in drivers/usb/ matching "[-.]complete(" were replaced with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested

[PATCH v6 4/4] usb: Add LED triggers for USB activity

2014-09-24 Thread Michal Sojka
With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both triggers should work with all host/device controllers. Tested only with musb. Performace: I measured performance overheads on ARM Cortex-A8 (TI AM335x

[PATCH v6 0/4] LED triggers for USB host and device

2014-09-24 Thread Michal Sojka
This adds LED triggers for USB host and device. First two patches refactor UDC drivers as requested by Felipe Balbi, the next renames a file and the last is the actual implementation of the LED triggers. Changes from v5: - Refactoring of USB gadget completion split into two patches (Filipe Balbi

[PATCH v6 3/4] usb: Rename usb-common.c

2014-09-24 Thread Michal Sojka
In the next commit, we will want the usb-common module to be composed of two object files. Since Kbuild cannot "append" another object to an existing one, we need to rename usb-common.c to something else (common.c) and create usb-common.o by linking the wanted objects together. Currently, usb-commo

[PATCH v6 1/4] usb: gadget: Introduce usb_gadget_giveback_request()

2014-09-24 Thread Michal Sojka
All USB peripheral controller drivers call completion routines directly. This patch adds usb_gadget_giveback_request() which will be used instead of direct invocation in the next patch. The goal here is to have a place where common functionality can be added. Signed-off-by: Michal Sojka --- driv

Re: [PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Robert Jarzmik
Felipe Balbi writes: > Hi, > > On Wed, Sep 24, 2014 at 10:14:53PM +0200, Robert Jarzmik wrote: > if you reply like this again I'll start ignoring your patches. Settle > down, I'm trying to help you get your patches merged. > > With that said: > > patch 1 should *ONLY* convert gpio_* to gpiod_*. T

Re: [PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 10:14:53PM +0200, Robert Jarzmik wrote: > Felipe Balbi writes: > > > On Wed, Sep 24, 2014 at 09:41:12PM +0200, Robert Jarzmik wrote: > >> For this preparation, a preliminary cleanup is done : > >> - convert the probing of pxa27x_udc to gpio_desc. > >> The conver

Re: Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-09-24 Thread Mark Knibbs
On Wed, 24 Sep 2014 11:37:11 -0400 (EDT) Alan Stern wrote: > On Wed, 24 Sep 2014, Mark Knibbs wrote: > > > I did some benchmarks to check the maximum transfer rate of a USB-to-SCSI > > converter. The converter is USB 1.1, so limited to the 12Mbps full speed > > rate. The performance when connect

Re: [PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Robert Jarzmik
Felipe Balbi writes: > On Wed, Sep 24, 2014 at 09:41:12PM +0200, Robert Jarzmik wrote: >> For this preparation, a preliminary cleanup is done : >> - convert the probing of pxa27x_udc to gpio_desc. >> The conversion is partial because : >> - the platform data still provides a gpio numbe

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 03:06:15PM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 02:40:12PM -0500, Felipe Balbi wrote: > > On Wed, Sep 24, 2014 at 03:31:13PM -0400, Alan Stern wrote: > > > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > > > > > > According to the kerneldoc for usb_ep_set_h

Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper

2014-09-24 Thread Rafael J. Wysocki
On Wednesday, September 24, 2014 09:44:50 PM Vinod Koul wrote: > This patch series adds a simple macro pm_runtime_last_busy_and_autosuspend() > which invokes pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend() > sequentially. Then we do a tree wide update of current patterns which are > pr

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 02:40:12PM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 03:31:13PM -0400, Alan Stern wrote: > > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > > > > According to the kerneldoc for usb_ep_set_halt: > > > > > > > > > > * Attempts to halt IN endpoints will fail (re

Re: [PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 09:41:12PM +0200, Robert Jarzmik wrote: > For this preparation, a preliminary cleanup is done : > - convert the probing of pxa27x_udc to gpio_desc. > The conversion is partial because : > - the platform data still provides a gpio number, not a gpio desc > - t

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 03:48:29PM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > alright fixed. Below you can see a combined diff which I'll still split > > > into patches so they can be applied properly. > > > > OTOH, there's really no way to split it. It's all need

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Felipe Balbi wrote: > > alright fixed. Below you can see a combined diff which I'll still split > > into patches so they can be applied properly. > > OTOH, there's really no way to split it. It's all needed to fix a single > bug. Do you want me to add Reported-by: Alan Stern

[PATCH v6 2/2] usb: gadget: pxa27x_udc: add devicetree support

2014-09-24 Thread Robert Jarzmik
Add support for device-tree device discovery. If devicetree is not provided, fallback to legacy platform data "discovery". Signed-off-by: Robert Jarzmik Cc: devicet...@vger.kernel.org --- Since V1: change OF id mrvl,pxa27x_udc -> marvell,pxa27x-udc This is a consequence of other DT rev

[PATCH v6 partial 0/2] pxa27x_udc port to device-tree and gpio_desc

2014-09-24 Thread Robert Jarzmik
Hi Felipe and Linus, As you requested, Felipe, I made the translation for the driver's probing from gpio to gpio_desc. Even if the code is functional, I'm pretty unhappy about my patch 1, because I lost the "active_low" notion in the transformation. I have not found in the gpiolib anything for a

[PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Robert Jarzmik
For this preparation, a preliminary cleanup is done : - convert the probing of pxa27x_udc to gpio_desc. The conversion is partial because : - the platform data still provides a gpio number, not a gpio desc - the "invert" attribute is lost, hence a loss in the translation - convert

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 03:31:13PM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > > According to the kerneldoc for usb_ep_set_halt: > > > > > > > > * Attempts to halt IN endpoints will fail (returning -EAGAIN) if any > > > > * transfer requests are still queued, or

Re: [PATCH v6 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:31:11PM +0400, Sergei Shtylyov wrote: > Hello. > > On 09/24/2014 11:28 PM, Felipe Balbi wrote: > > >>From: Antoine Tenart > > >>The USB PHY member of the HCD structure is renamed to 'usb_phy' and > >>modifications are done in all drivers accessing it. > >>This is in p

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > According to the kerneldoc for usb_ep_set_halt: > > > > > > * Attempts to halt IN endpoints will fail (returning -EAGAIN) if any > > > * transfer requests are still queued, or if the controller hardware > > > * (usually a FIFO) still holds bytes t

Re: [PATCH v6 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Sergei Shtylyov
Hello. On 09/24/2014 11:28 PM, Felipe Balbi wrote: From: Antoine Tenart The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. This is in preparation to adding the generic PHY support. Signed-off-by: Antoine Tenart [Sergei

Re: [PATCH v6 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:05:50PM +0400, Sergei Shtylyov wrote: > From: Antoine Tenart > > The USB PHY member of the HCD structure is renamed to 'usb_phy' and > modifications are done in all drivers accessing it. > This is in preparation to adding the generic PHY support. > > Signed-off-by: Ant

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 02:18:14PM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 01:08:15PM -0500, Felipe Balbi wrote: > > On Wed, Sep 24, 2014 at 01:53:31PM -0400, Alan Stern wrote: > > > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > > > > > I'll capture usbmon and send here shortl

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 01:08:15PM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 01:53:31PM -0400, Alan Stern wrote: > > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > > > I'll capture usbmon and send here shortly. > > > > > > here it is... Interesting part starts at line 73 (114 on

[PATCH v6 2/2] usb: hcd: add generic PHY support

2014-09-24 Thread Sergei Shtylyov
Add the generic PHY support, analogous to the USB PHY support. Intended it to be used with the PCI EHCI/OHCI drivers and the xHCI platform driver. Signed-off-by: Sergei Shtylyov Signed-off-by: Yoshihiro Shimoda --- Changes in version 5: - renamed the new 'gen_phy' field of 'struct usb_phy' back

[PATCH v6 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Sergei Shtylyov
From: Antoine Tenart The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. This is in preparation to adding the generic PHY support. Signed-off-by: Antoine Tenart [Sergei: added missing 'drivers/usb/misc/lvstest.c' file, resolved

[PATCH v6 0/2] Add generic PHY support to USB HCD

2014-09-24 Thread Sergei Shtylyov
Hello. This patchset is against the usb-next' branch of Greg KH's 'usb.git' repo. Here I add support for the generic PHY to the 'struct usb_hcd' (having to rename the existing 'phy' field to 'usb_phy' beforehand). This was mainly intended to be used with the PCI OHCI/EHCI drivers and also xHCI

Re: [PATCH v5 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Sergei Shtylyov
hello. On 09/24/2014 09:11 AM, Greg KH wrote: From: Antoine Tenart The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. This is in preparation to adding the generic PHY support. Signed-off-by: Antoine Tenart [Sergei: add

MUSB: extra cppi irq?

2014-09-24 Thread Bin Liu
Hi Felipe and all, The musb driver musb_host_tx() has the following: 1244 /* with CPPI, DMA sometimes triggers "extra" irqs */ 1245 if (!urb) { 1246 dev_dbg(musb->controller, "extra TX%d ready, csr %04x\n", epnum, tx_csr); 1247 return; 1248

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 01:53:31PM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > I'll capture usbmon and send here shortly. > > > > here it is... Interesting part starts at line 73 (114 on this email) > > where the data transport received EPIPE (due to Stall). This t

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 01:56:21PM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > so here's sequence of events so far: > > > > - Enumration goes fine > > - Get Max Lun -> 0 (single lun) > > - Inquiry -> Passed

Re: [PATCH v2] usb: core: downgrade log severity to info when descriptor unavailable

2014-09-24 Thread Scot Doyle
On Tue, 23 Sep 2014, Greg Kroah-Hartman wrote: On Tue, Sep 23, 2014 at 07:12:40PM +, Scot Doyle wrote: According to commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0 USB: fix LANGID=0 regression usb devices are not required to report string descriptors. Since they are optional, log an inf

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Felipe Balbi wrote: > so here's sequence of events so far: > > - Enumration goes fine > - Get Max Lun -> 0 (single lun) > - Inquiry -> Passed > - Test Unit Ready -> Failed > - Request Sense (Unit Attentio

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Felipe Balbi wrote: > > I'll capture usbmon and send here shortly. > > here it is... Interesting part starts at line 73 (114 on this email) > where the data transport received EPIPE (due to Stall). This time > however, I was eventually able to talk to the device and managed t

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 12:19:13PM -0500, Felipe Balbi wrote: > Hi, > > On Wed, Sep 24, 2014 at 11:20:31AM -0500, Felipe Balbi wrote: > > > > > > Therefore stalling is appropriate. Why it causes it problem for > > > > > > your > > > > > > system is a different matter. Is your UDC hardware capa

Re: [RFC PATCH] usb: core: log more general message on malformed LANGID descriptor

2014-09-24 Thread Scot Doyle
On Tue, 23 Sep 2014, Greg Kroah-Hartman wrote: > On Tue, Sep 23, 2014 at 10:28:49PM +, Scot Doyle wrote: >> I'd like to change this error message: >> [3.325837] usb 1-4: string descriptor 0 malformed (err = -61), >> defaulting to 0x0409 >> >> into an error message followed by a debug mess

[PATCH v2] storage: Don't scan target 7 for SCM USB-SCSI converters

2014-09-24 Thread Mark Knibbs
Hi, Regarding the patch I posted to prevent the bus scan of SCM USB-SCSI converters attempting to scan the converter itself, there is probably a neater way. In drivers/scsi/scsi_scan.c, function __scsi_scan_target(), there is: if (shost->this_id == id) /*

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 11:20:31AM -0500, Felipe Balbi wrote: > > > > > Therefore stalling is appropriate. Why it causes it problem for your > > > > > system is a different matter. Is your UDC hardware capable of > > > > > halting > > > > > bulk endpoints? > > > > > > > > yeah, that part

[PATCH 26/27] usb: musb: omap2430: use pm_runtime_last_busy_and_autosuspend helper

2014-09-24 Thread Vinod Koul
Use the new pm_runtime_last_busy_and_autosuspend helper instead of open coding the same code Signed-off-by: Vinod Koul --- drivers/usb/musb/omap2430.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index d36

[PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper

2014-09-24 Thread Vinod Koul
This patch series adds a simple macro pm_runtime_last_busy_and_autosuspend() which invokes pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend() sequentially. Then we do a tree wide update of current patterns which are present. As evident from log below this pattern is frequent in the kernel

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 11:40:54AM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Felipe Balbi wrote: > > > > Therefore stalling is appropriate. Why it causes it problem for your > > > system is a different matter. Is your UDC hardware capable of halting > > > bulk endpoints? > > > > ye

Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

2014-09-24 Thread Alan Stern
On Mon, 22 Sep 2014, Michal Simek wrote: > Hi Alan and Greg, > > On 09/20/2014 06:19 AM, Chen Gang wrote: > > Hello Maintainers: > > > > Please help check this patch, when you have time. > > > > Thanks. > > > > On 09/08/2014 01:20 PM, Michal Simek wrote: > >> On 09/03/2014 05:50 PM, Chen Gang

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Felipe Balbi wrote: > > Therefore stalling is appropriate. Why it causes it problem for your > > system is a different matter. Is your UDC hardware capable of halting > > bulk endpoints? > > yeah, that part is just fine; I also verified with my sniffer that bulk > halt is

Re: Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Mark Knibbs wrote: > Hi, > > I did some benchmarks to check the maximum transfer rate of a USB-to-SCSI > converter. The converter is USB 1.1, so limited to the 12Mbps full speed > rate. The performance when connected to a USB 3.0 port is significantly > worse than when connec

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 10:30:17AM -0500, Felipe Balbi wrote: > On Wed, Sep 24, 2014 at 11:17:18AM -0400, Alan Stern wrote: > > On Wed, 24 Sep 2014, Alan Stern wrote: > > > > > > Case (6) is when Hi == Di, looking at my logs, I have: > > > > > > > > 720 [ 286.843965] SCSI CDB: 1a 00 3f 00 c0 00

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:17:18AM -0400, Alan Stern wrote: > On Wed, 24 Sep 2014, Alan Stern wrote: > > > > Case (6) is when Hi == Di, looking at my logs, I have: > > > > > > 720 [ 286.843965] SCSI CDB: 1a 00 3f 00 c0 00 > > > 721 [ 286.844000] g_mass_storage gadget: SCSI command: MODE SENSE(6

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Octavian Purdila
On Wed, Sep 24, 2014 at 6:07 PM, Johan Hovold wrote: > On Wed, Sep 24, 2014 at 05:54:15PM +0300, Octavian Purdila wrote: >> On Wed, Sep 24, 2014 at 4:54 PM, Johan Hovold wrote: >> > On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote: >> >> On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovo

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 11:05:58AM -0400, Alan Stern wrote: > On Tue, 23 Sep 2014, Felipe Balbi wrote: > > > Hi Alan, > > > > Need your help looking over this detail here. When I run g_mass_storage > > with stall=0 everything works fine. As soon as I remove it, things go > > bonkers. > > >

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Alan Stern wrote: > > Case (6) is when Hi == Di, looking at my logs, I have: > > > > 720 [ 286.843965] SCSI CDB: 1a 00 3f 00 c0 00 > > 721 [ 286.844000] g_mass_storage gadget: SCSI command: MODE SENSE(6); > > Dc=6, Di=192; Hc=6, Hi=192 > > 722 [ 286.844018] g_mass_storag

Re: [PATCH][RFC] storage: Simplify condition to reject bad target in usb_stor_control_thread()

2014-09-24 Thread Alan Stern
On Wed, 24 Sep 2014, Mark Knibbs wrote: > Hi, > > This follows on from something I mentioned in my recent post "[PATCH] > storage: Don't scan target 7 for SCM USB-SCSI converters". > > In drivers/usb/storage/usb.c, usb_stor_control_thread(): > /* reject if target != 0 or if LUN is higher t

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 05:54:15PM +0300, Octavian Purdila wrote: > On Wed, Sep 24, 2014 at 4:54 PM, Johan Hovold wrote: > > On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote: > >> On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold wrote: > >> > On Fri, Sep 19, 2014 at 11:22:42PM +0300,

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Octavian Purdila
On Wed, Sep 24, 2014 at 4:54 PM, Johan Hovold wrote: > On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote: >> On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold wrote: >> > On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote: >> >> >> >> >> + * dln2_dev.mod_rx_slots and the

Re: g_mass_storage bug ?

2014-09-24 Thread Alan Stern
On Tue, 23 Sep 2014, Felipe Balbi wrote: > Hi Alan, > > Need your help looking over this detail here. When I run g_mass_storage > with stall=0 everything works fine. As soon as I remove it, things go > bonkers. > > Looking at the bulk-only spec, I see: > > "6.7.2 Hi - Host expects to receive da

Re: [PATCH v5 1/3] usb: gadget: Refactor request completion

2014-09-24 Thread Alan Stern
On Tue, 23 Sep 2014, Michal Sojka wrote: > >> +/** > >> + * usb_gadget_giveback_request - give the request back to the gadget layer > >> + * Context: in_interrupt() > >> + * > >> + * This is called by device controller drivers in order to return the > >> + * completed request back to the gadget la

Re: [PATCH v5 1/3] usb: gadget: Refactor request completion

2014-09-24 Thread Felipe Balbi
Hi, On Tue, Sep 23, 2014 at 10:09:22AM +0200, Michal Sojka wrote: > >> +/** > >> + * usb_gadget_giveback_request - give the request back to the gadget layer > >> + * Context: in_interrupt() > >> + * > >> + * This is called by device controller drivers in order to return the > >> + * completed requ

Re: [resend PATCH 3/3] usb: dwc3: add ACPI support

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:00:39AM +0300, Heikki Krogerus wrote: > Adds ACPI ID used on newer Intel SoCs. > > Signed-off-by: Heikki Krogerus > --- > drivers/usb/dwc3/core.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > i

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Lars Melin
On 2014-09-24 20:12, Heiko Schocher wrote: Hello Lars, Am 24.09.2014 14:25, schrieb Lars Melin: On 2014-09-24 13:48, Heiko Schocher wrote: use the values for RNDIS over Ethernet as defined in http://www.usb.org/developers/defined_class (search for RDNIS): - baseclass: 0xef (miscellaneous) - s

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote: > On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold wrote: > > On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote: > > > > >> + * dln2_dev.mod_rx_slots and then the echo header field to index the > >> + * slots field an

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-24 Thread Octavian Purdila
On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold wrote: > On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote: >> + * dln2_dev.mod_rx_slots and then the echo header field to index the >> + * slots field and find the receive context for a particular >> + * request. >> + */ >> +struct d

Re: [resend PATCH 1/3] ACPI / platform: provide default DMA mask

2014-09-24 Thread Rafael J. Wysocki
On Wednesday, September 24, 2014 11:00:37 AM Heikki Krogerus wrote: > Most devices are configured for 32-bit DMA addresses. > Setting the mask to 32-bit here removes the need for the > drivers to do it separately. > > Signed-off-by: Heikki Krogerus > Cc: "Rafael J. Wysocki" ACK > --- > driver

[PATCH 1/2] usb: gadget: f_uvc: rename a macro to avoid conflicts

2014-09-24 Thread Andrzej Pietrasiewicz
When configfs is integrated, CONFIGFS_ATTR_STRUCT and CONFIGFS_ATTR_OPS macros should be used, but the latter expects that tere is a to_f_uvc_opts function accepting a config_item, whereas the macro being changed can be applied to a different type of argument. Signed-off-by: Andrzej Pietrasiewicz

[PATCH 2/2] usb: gadget: uvc: configfs support in uvc function

2014-09-24 Thread Andrzej Pietrasiewicz
Add support for using the uvc function as a component of USB gadgets composed with configfs. Signed-off-by: Andrzej Pietrasiewicz --- Documentation/ABI/testing/configfs-usb-gadget-uvc | 264 +++ drivers/usb/gadget/Kconfig| 11 + drivers/usb/gadget/function/Makefile

[PATCH 0/2] Equivalent of g_webcam with configfs

2014-09-24 Thread Andrzej Pietrasiewicz
This series aims at integrating configfs into uvc, the way it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet, mass_storage, FunctionFS, loopback, sourcesink, uac1 and uac2. The preparation series is already on Felipe's next, so this series in fact consists of a small prepara

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Heiko Schocher
Hello Lars, Am 24.09.2014 14:25, schrieb Lars Melin: On 2014-09-24 13:48, Heiko Schocher wrote: use the values for RNDIS over Ethernet as defined in http://www.usb.org/developers/defined_class (search for RDNIS): - baseclass: 0xef (miscellaneous) - subclass: 0x04 - protocol: 0x01 That is usb

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Heiko Schocher
Hello Michal, Am 24.09.2014 11:38, schrieb Michal Nazarewicz: On Wed, Sep 24 2014, Heiko Schocher wrote: use the values for RNDIS over Ethernet as defined in http://www.usb.org/developers/defined_class (search for RDNIS): - baseclass: 0xef (miscellaneous) - subclass: 0x04 - protocol: 0x01 wi

Re: [PATCH v5 4/4] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-24 Thread Johan Hovold
On Fri, Sep 19, 2014 at 11:22:45PM +0300, Octavian Purdila wrote: > +struct dln2_gpio { > + struct platform_device *pdev; > + struct gpio_chip gpio; > + > + /* > + * Cache pin direction to save us one transfer, since the > + * hardware has separate commands to read the in and

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 03:34:08PM +0300, Octavian Purdila wrote: > I can follow-up with a v3 3 patch series: first for the fix, second > for the OOM & error path cleanup, third for devm conversion. I'd include the error-path clean up bit in the devres conversion as that is what it's really all a

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Octavian Purdila
On Wed, Sep 24, 2014 at 3:26 PM, Johan Hovold wrote: > On Wed, Sep 24, 2014 at 01:00:02PM +0100, Lee Jones wrote: >> On Wed, 24 Sep 2014, Johan Hovold wrote: >> >> > On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: >> > > On Mon, 22 Sep 2014, Octavian Purdila wrote: >> > > >> > > > Curre

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 01:00:02PM +0100, Lee Jones wrote: > On Wed, 24 Sep 2014, Johan Hovold wrote: > > > On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: > > > On Mon, 22 Sep 2014, Octavian Purdila wrote: > > > > > > > Currently the I/O buffer is allocated part of the device status >

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Lars Melin
On 2014-09-24 13:48, Heiko Schocher wrote: use the values for RNDIS over Ethernet as defined in http://www.usb.org/developers/defined_class (search for RDNIS): - baseclass: 0xef (miscellaneous) - subclass: 0x04 - protocol: 0x01 That is usb class, it is not the same thing as communication devic

[PATCH][RFC] storage: Simplify condition to reject bad target in usb_stor_control_thread()

2014-09-24 Thread Mark Knibbs
Hi, This follows on from something I mentioned in my recent post "[PATCH] storage: Don't scan target 7 for SCM USB-SCSI converters". In drivers/usb/storage/usb.c, usb_stor_control_thread(): /* reject if target != 0 or if LUN is higher than * the maximum known LUN */

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Arnd Bergmann
On Wednesday 24 September 2014 19:29:05 Peter Chen wrote: > > So, it is IP CORE LIB (you suggest) vs IP CORE Platform Driver > (dwc3, musb, chipidea) you are talking about, right? Except for > creating another platform driver as well as related DT node (optional), > are there any advantages compar

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Lee Jones
On Wed, 24 Sep 2014, Johan Hovold wrote: > On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: > > On Mon, 22 Sep 2014, Octavian Purdila wrote: > > > > > Currently the I/O buffer is allocated part of the device status > > > structure, potentially sharing the same cache line with other memb

Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-09-24 Thread Mark Knibbs
Hi, I did some benchmarks to check the maximum transfer rate of a USB-to-SCSI converter. The converter is USB 1.1, so limited to the 12Mbps full speed rate. The performance when connected to a USB 3.0 port is significantly worse than when connected to a USB 2.0 port, about 26.5% slower (0.63MB/sec

  1   2   >