Yes I have incorporated review comment from Greg.
Regards
Sanjeev Sharma
-Original Message-
From: Hans de Goede [mailto:hdego...@redhat.com]
Sent: Tuesday, August 12, 2014 11:59 AM
To: Sharma, Sanjeev
Cc: gre...@linuxfoundation.org; kra...@redhat.com;
mdharm-...@one-eyed-alien.net; linu
On Tue, Aug 12, 2014 at 02:01:53PM +0800, Greg KH wrote:
> On Tue, Aug 12, 2014 at 11:38:37AM +0530, Sanjeev Sharma wrote:
> > spin_is_locked() always return false in uniprocessor configuration and
> > therefore it
> > would be advise to replace with lockdep_assert_held().
>
> Add "on some archit
Done !
Thanks
Sanjeev Sharma
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Tuesday, August 12, 2014 11:32 AM
To: Sharma, Sanjeev
Cc: hdego...@redhat.com; kra...@redhat.com; mdharm-...@one-eyed-alien.net;
linux-usb@vger.kernel.org; linux-ker...@vger.kernel.or
Hi,
On 08/12/2014 08:40 AM, Sanjeev Sharma wrote:
> on some architecture spin_is_locked() always return false in
> uniprocessor configuration and therefore it would be advise
> to replace with lockdep_assert_held().
>
> Signed-off-by: Sanjeev Sharma
> ---
> Changes in v3:
> incorporated review
on some architecture spin_is_locked() always return false in
uniprocessor configuration and therefore it would be advise
to replace with lockdep_assert_held().
Signed-off-by: Sanjeev Sharma
---
Changes in v3:
incorporated review comment suggested by Greg
drivers/usb/storage/uas.c | 8
On Tue, Aug 12, 2014 at 11:38:37AM +0530, Sanjeev Sharma wrote:
> spin_is_locked() always return false in uniprocessor configuration and
> therefore it
> would be advise to replace with lockdep_assert_held().
Add "on some architectures" in here somewhere, as it's not broken on the
large majority
Hi,
On 08/12/2014 08:08 AM, Sanjeev Sharma wrote:
> spin_is_locked() always return false in uniprocessor configuration and
> therefore it
> would be advise to replace with lockdep_assert_held().
>
> Signed-off-by: Sanjeev Sharma
> ---
> Changes in v2:
> - replaced WARN_ON_ONCE() with lockdep_a
spin_is_locked() always return false in uniprocessor configuration and
therefore it
would be advise to replace with lockdep_assert_held().
Signed-off-by: Sanjeev Sharma
---
Changes in v2:
- replaced WARN_ON_ONCE() with lockdep_assert_held() to
avoid runtime overhead instead of assert_spin_lock
On Mon, Aug 11, 2014 at 04:16:11PM -0400, Alan Stern wrote:
> On Mon, 11 Aug 2014, Michael Grzeschik wrote:
>
> > Hi Alan,
> >
> > On Mon, Aug 11, 2014 at 10:28:12AM -0400, Alan Stern wrote:
> > > On Mon, 11 Aug 2014, Felipe Balbi wrote:
> > >
> > > > On Mon, Aug 11, 2014 at 09:44:05AM -0400, Al
On Mon, Aug 11, 2014 at 02:34:33PM +0200, Michael Grzeschik wrote:
> Hi Peter,
>
> On Mon, Aug 11, 2014 at 12:56:47AM +, Peter Chen wrote:
> > > I have seen this call is still returning EOPNOTSUPP which is also
> > > returned by usb_gadget_connect and usb_gadget_disconnect if the pullup
> > >
> Hey Linux USBer's,
>
> I'm looking to add host support to the qualcomm OTG USB driver. The
> driver in mainline currently has gadget support only. I'm starting with
> an out-of-tree driver that has full gadget and host support. It has it's
> own OTG state machine implement in the driver, th
On Mon, Aug 11, 2014 at 11:56:17AM +, Sharma, Sanjeev wrote:
> Hi Greg,
>
> Please find my comment in line.
As it should, but where is it, your quoting is all messed up...
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Monday, August 11, 2014 1:58 P
Hey Linux USBer's,
I'm looking to add host support to the qualcomm OTG USB driver. The
driver in mainline currently has gadget support only. I'm starting
with an out-of-tree driver that has full gadget and host support. It
has it's own OTG state machine implement in the driver, that I was
about
On Mon, 11 Aug 2014, Michael Grzeschik wrote:
> Hi Alan,
>
> On Mon, Aug 11, 2014 at 10:28:12AM -0400, Alan Stern wrote:
> > On Mon, 11 Aug 2014, Felipe Balbi wrote:
> >
> > > On Mon, Aug 11, 2014 at 09:44:05AM -0400, Alan Stern wrote:
> > > > On Mon, 11 Aug 2014, Felipe Balbi wrote:
> > > >
>
Hi,
On 08/11/2014 09:08 PM, Guenter Roeck wrote:
> On Mon, Aug 11, 2014 at 08:55:07PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 08/11/2014 08:19 PM, Guenter Roeck wrote:
>>> On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote:
spin_is_locked() always return false in uniprocessor
On Mon, Aug 11, 2014 at 08:55:07PM +0200, Hans de Goede wrote:
> Hi,
>
> On 08/11/2014 08:19 PM, Guenter Roeck wrote:
> > On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote:
> >> spin_is_locked() always return false in uniprocessor configuration and
> >> therefore it
> >> would be adv
Hi,
On 08/11/2014 09:59 AM, Sanjeev Sharma wrote:
> spin_is_locked() always return false in uniprocessor configuration and
> therefore it
> would be advise to repalce with assert_spin_locked().
>
> Signed-off-by: Sanjeev Sharma
Looks sane / good to me:
Acked-by: Hans de Goede
Regards,
Hans
Hi,
On 08/11/2014 08:19 PM, Guenter Roeck wrote:
> On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote:
>> spin_is_locked() always return false in uniprocessor configuration and
>> therefore it
>> would be advise to repalce with assert_spin_locked().
>>
>> Signed-off-by: Sanjeev Sharma
On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote:
> spin_is_locked() always return false in uniprocessor configuration and
> therefore it
> would be advise to repalce with assert_spin_locked().
>
> Signed-off-by: Sanjeev Sharma
> ---
> drivers/usb/storage/uas.c | 8
> 1 f
Hi Alan,
On Mon, Aug 11, 2014 at 10:28:12AM -0400, Alan Stern wrote:
> On Mon, 11 Aug 2014, Felipe Balbi wrote:
>
> > On Mon, Aug 11, 2014 at 09:44:05AM -0400, Alan Stern wrote:
> > > On Mon, 11 Aug 2014, Felipe Balbi wrote:
> > >
> > > > > > I don't know what exactly problem you met, but curren
On Mon, 11 Aug 2014, Alexei P wrote:
> I believe the focus of this thread has gone in wrong direction. The question
> should not be about how to disable the flood of "detected XactErr" messages,
> but (a) why does it occur in this particular case, and (b) why there are so
> many of them.
> My opi
Hi,
On Mon, Aug 11, 2014 at 04:52:38PM +0200, Richard Leitner wrote:
> On Mon, 11 Aug 2014 08:50:34 -0500
> Felipe Balbi wrote:
>
> > On Mon, Aug 11, 2014 at 03:04:35PM +0200, Richard Leitner wrote:
> > > Hi,
> > > this patch was lying around for some time...
> > > are there any comments or obje
Alan Stern writes:
>
> On Wed, 29 Aug 2012, Gary E. Miller wrote:
>
> > Yo Alan!
> >
> > On Wed, 29 Aug 2012 17:08:43 -0400 (EDT)
> > Alan Stern wrote:
> >
> > > > Uh, not easy. This is a production machine. Acceptable downtime is
> > > > very small. There should be a way to turn it off a
Hi,
On Mon, 11 Aug 2014 08:50:34 -0500
Felipe Balbi wrote:
> On Mon, Aug 11, 2014 at 03:04:35PM +0200, Richard Leitner wrote:
> > Hi,
> > this patch was lying around for some time...
> > are there any comments or objections on this?
>
> you realise we're still in the middle of the merge window,
I thought there was some reason why the code didn't already trust the
length. I even made a comment to the fact that the system already
tells me that its needed, so my patch to turn it on seems silly. I
just assumed there was a reason it didn't trust it and printed a
message asking if it should.
On 08/11/2014 02:15 PM, David Laight wrote:
> From: Behalf Of Evan Langlois
>> Sorry if this is answered somewhere, but I couldn't find anything
>> specific on Google as far as how to determine if this quirk is needed
>> or if its configurable at boot/run-time. Its an HP laptop, and it
>> looks l
On Mon, 11 Aug 2014, Felipe Balbi wrote:
> On Mon, Aug 11, 2014 at 09:44:05AM -0400, Alan Stern wrote:
> > On Mon, 11 Aug 2014, Felipe Balbi wrote:
> >
> > > > > I don't know what exactly problem you met, but current pullup dp
> > > > > during loading
> > > > > gadget driver behavior is not suit
Ping!
On Mon, Jul 07, 2014 at 12:53:45PM +0200, Michael Grzeschik wrote:
> I am currently working with an udc where the userspace should react on
> plugging
> and unplugging of the device. The layers used trigger the
> usb_gadget_state_work
> as expected, but the sysfs_notify never cross the use
Hi,
On Mon, Aug 11, 2014 at 03:50:08PM +0200, Michael Grzeschik wrote:
> > > As the driver is mainline we can remove the version numbers.
> > >
> > > Signed-off-by: Michael Grzeschik
> > > ---
> > > drivers/usb/gadget/uvc.h | 3 ---
> > > drivers/usb/gadget/uvc_v4l2.c | 1 -
> > > 2 files
On Mon, Aug 11, 2014 at 08:45:52AM -0500, Felipe Balbi wrote:
> On Mon, Aug 11, 2014 at 09:44:05AM -0400, Alan Stern wrote:
> > On Mon, 11 Aug 2014, Felipe Balbi wrote:
> >
> > > > > I don't know what exactly problem you met, but current pullup dp
> > > > > during loading
> > > > > gadget driver
On Mon, Aug 11, 2014 at 03:04:35PM +0200, Richard Leitner wrote:
> Hi,
> this patch was lying around for some time...
> are there any comments or objections on this?
you realise we're still in the middle of the merge window, right ?
--
balbi
signature.asc
Description: Digital signature
Hi,
On Mon, Aug 11, 2014 at 08:32:37AM -0500, Felipe Balbi wrote:
> Hi,
>
> On Mon, Aug 11, 2014 at 01:15:06PM +0200, Michael Grzeschik wrote:
> > As the driver is mainline we can remove the version numbers.
> >
> > Signed-off-by: Michael Grzeschik
> > ---
> > drivers/usb/gadget/uvc.h | 3
On Mon, Aug 11, 2014 at 09:44:05AM -0400, Alan Stern wrote:
> On Mon, 11 Aug 2014, Felipe Balbi wrote:
>
> > > > I don't know what exactly problem you met, but current pullup dp during
> > > > loading
> > > > gadget driver behavior is not suitable for webcam and android use case
> > > > even vbu
On Mon, 11 Aug 2014, Felipe Balbi wrote:
> > > I don't know what exactly problem you met, but current pullup dp during
> > > loading
> > > gadget driver behavior is not suitable for webcam and android use case
> > > even vbus
> > > is there.
> >
> > Why not? What's wrong with it?
>
> g_uvc ne
On Mon, Aug 11, 2014 at 09:35:46AM -0400, Alan Stern wrote:
> On Mon, 11 Aug 2014, Peter Chen wrote:
>
> > > Hello Peter,
> > >
> > > I have seen this call is still returning EOPNOTSUPP which is also
> > > returned by usb_gadget_connect and usb_gadget_disconnect if the pullup
> > > function is no
On Fri, Aug 8, 2014 at 10:41 PM, Valentina Manea
wrote:
> On Thu, Aug 7, 2014 at 1:16 PM, Greg KH wrote:
>>
>> The top of the MAINTAINERS should have this information, look in the S:
>> Status section about what type of category you are in.
>>
>> Basically I'd like you to be the one to handle pat
On Mon, 11 Aug 2014, Peter Chen wrote:
> > Hello Peter,
> >
> > I have seen this call is still returning EOPNOTSUPP which is also
> > returned by usb_gadget_connect and usb_gadget_disconnect if the pullup
> > function is not available. Should it not handle that case somehow special?
> >
> >
> >
Hi,
On Mon, Aug 11, 2014 at 01:15:06PM +0200, Michael Grzeschik wrote:
> As the driver is mainline we can remove the version numbers.
>
> Signed-off-by: Michael Grzeschik
> ---
> drivers/usb/gadget/uvc.h | 3 ---
> drivers/usb/gadget/uvc_v4l2.c | 1 -
> 2 files changed, 4 deletions(-)
>
>
Hi,
this patch was lying around for some time...
are there any comments or objections on this?
regards,
richard
On Fri, 18 Jul 2014 11:39:46 +0200
Richard Leitner wrote:
> Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with
> the hardcoded ttyGS string.
>
> This macro
Hi Peter,
On Mon, Aug 11, 2014 at 12:56:47AM +, Peter Chen wrote:
> > I have seen this call is still returning EOPNOTSUPP which is also
> > returned by usb_gadget_connect and usb_gadget_disconnect if the pullup
> > function is not available. Should it not handle that case somehow special?
> >
Hi Greg,
Please find my comment in line.
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Monday, August 11, 2014 1:58 PM
To: Sharma, Sanjeev
Cc: hdego...@redhat.com; kra...@redhat.com; mdharm-...@one-eyed-alien.net;
linux-usb@vger.kernel.org; linux-ker...@vger
> >
> > /**
> > * usb_enumerate_device_otg - FIXME (usbcore-internal) @@ -2261,21
> > +2259,6 @@ static int usb_enumerate_device_otg(struct usb_device *udev)
> > }
> > }
> > }
> > -
> > - if (!is_targeted(udev)) {
> > -
> > - /* Maybe it can ta
From: Behalf Of Evan Langlois
> Sorry if this is answered somewhere, but I couldn't find anything
> specific on Google as far as how to determine if this quirk is needed
> or if its configurable at boot/run-time. Its an HP laptop, and it
> looks like other HP models have the problem.
>
> I most
As the driver is mainline we can remove the version numbers.
Signed-off-by: Michael Grzeschik
---
drivers/usb/gadget/uvc.h | 3 ---
drivers/usb/gadget/uvc_v4l2.c | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb/gadget/uvc.h
index 49d9573..e593a10 1
On Mon, Aug 11, 2014 at 12:24:02PM +0200, Michael Grzeschik wrote:
> The define is unused and can be thrown into the
> garbage bag of other unused defines.
>
> Signed-off-by: Michael Grzeschik
> ---
> drivers/usb/gadget/uvc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/g
The define is unused and can be thrown into the
garbage bag of other unused defines.
Signed-off-by: Michael Grzeschik
---
drivers/usb/gadget/uvc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb/gadget/uvc.h
index 49d9573..5ae5c5e 100644
--- a/drivers/us
The define is unused and can be thrown into the
garbage bag of other unused defines.
Signed-off-by: Michael Grzeschik
---
drivers/usb/gadget/uvc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb/gadget/uvc.h
index 49d9573..5ae5c5e 100644
--- a/drivers/us
> (Also, I'm wondering if we should just drop the code that skips whole
> segments to make it simpler, since I can hardly think of any
> real-world examples where a single TD would cover a whole segment.)
That can happen, raw access to USB disks can generate very long
fragment lists.
OTOH simplify
> It's starting to get a bit too complicated.
> xhci find_new_dequeue_state() now has four places where it can toggle the
> cycle bit
> in addition to the cycle toggle in find_trb_seg().
>
> In the end we really just want to do it max once.
>
> I'll see if I can simplify the whole cycle bit code
Hi all,
On Sat, Aug 9, 2014 at 12:03 PM, Kristian Evensen
wrote:
> 2) When disconnecting any WIFI dongle, I always get a kernel oops.
> This happens irrespective of if the dongle is active (for example
> connected to network) or if I have just connected it to the router.
> The kernel oops looks l
On Mon, 2014-08-11 at 16:22 +0800, Greg KH wrote:
> On Mon, Aug 11, 2014 at 09:10:35AM +0200, Oliver Neukum wrote:
> > On Thu, 2014-08-07 at 20:31 -0700, Greg KH wrote:
> > > On Fri, Aug 08, 2014 at 10:56:57AM +0800, w wrote:
> > > >
> > > > If use symlinks it can work well.
> > > >
> > > > But w
On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote:
> spin_is_locked() always return false in uniprocessor configuration
Really? On what processor type? I don't see that being the case on a
few processors, but I didn't check them all, or I might be totally
confused with all of the ar
On Mon, Aug 11, 2014 at 09:10:35AM +0200, Oliver Neukum wrote:
> On Thu, 2014-08-07 at 20:31 -0700, Greg KH wrote:
> > On Fri, Aug 08, 2014 at 10:56:57AM +0800, w wrote:
> > >
> > > If use symlinks it can work well.
> > >
> > > But why program in userspace can prevent driver release the node?
> >
On Thu, 2014-08-07 at 20:31 -0700, Greg KH wrote:
> On Fri, Aug 08, 2014 at 10:56:57AM +0800, w wrote:
> >
> > If use symlinks it can work well.
> >
> > But why program in userspace can prevent driver release the node?
> > The program just open the node, nothing else.
>
> If it holds the node op
spin_is_locked() always return false in uniprocessor configuration and
therefore it
would be advise to repalce with assert_spin_locked().
Signed-off-by: Sanjeev Sharma
---
drivers/usb/storage/uas.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/storage/u
55 matches
Mail list logo
