Re: [PATCH net] r8152: fix the checking of the usb speed

2014-07-24 Thread David Miller
From: Hayes Wang Date: Thu, 24 Jul 2014 16:37:43 +0800 > When the usb speed of the RTL8152 is not high speed, the USB_DEV_STAT[2:1] > should be equal to [0 1]. That is, the STAT_SPEED_FULL should be equal > to 2. > > There is a easy way to check the usb speed by the speed field of the > struct u

[PATCH resend] Revert "usb: gadget: u_ether: synchronize with transmit when stopping queue"

2014-07-24 Thread roy . qing . li
From: Li RongQing This reverts commit a9232076374334ca2bc2a448dfde96d38a54349a. It introduced a dead lock, and did not fix anything. it made netif_tx_lock() be called in IRQ context, but in softirq context, the same lock is locked without disabling IRQ. In fact, the commit a923207637 did not fi

Re: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-07-24 Thread Peter Chen
On Wed, Jul 16, 2014 at 10:26:01AM +0200, Antoine Ténart wrote: > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock > and DMA mask, to support USB2 ChipIdea controllers that don't need > specific functions. You may need to indicate it is a generic usb2 glue layer driver at both subj

Re: Report about a "please report the device ID to the Linux USB developers!" message

2014-07-24 Thread Lars Melin
On 2014-07-25 00:50, Antonio wrote: Hi! [...] will probably fix your problem Thank you for being kind. As far as I can tell, the modem is working correctly, I wrote to this list because I saw a "usb_modeswitch: please report the device ID to the Linux USB developers!" message and I thought t

RE: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-24 Thread Peter Chen
> > > > > > - if (ci->platdata->usb_phy) > > > + if (ci->platdata->phy) > > > + ci->phy = ci->platdata->phy; > > > + else if (ci->platdata->usb_phy) > > > ci->usb_phy = ci->platdata->usb_phy; > > > else > > > - ci->usb_phy = devm_usb_get_phy(dev, USB_PHY_TYPE_USB2); >

Re: OMAP3/AM3517 EHCI USB Issue

2014-07-24 Thread Michael Welling
On Wed, Jul 23, 2014 at 3:34 PM, Michael Welling wrote: > There appears to be a bug in the USB host driver for the AM3517 in the > 3.16 kernel. When the AM3517 board boots with a USB device plugged in > the host it detects and works fines as long as it is plugged in. > > The board does not detect

Re: Linux 3.16-rc6

2014-07-24 Thread John Stoffel
> "Waiman" == Waiman Long writes: Waiman> On 07/24/2014 02:36 PM, Peter Zijlstra wrote: >> On Thu, Jul 24, 2014 at 11:18:16AM -0700, Linus Torvalds wrote: >>> On Thu, Jul 24, 2014 at 5:58 AM, Peter Zijlstra >>> wrote: So going by the nifty picture rostedt made: [ 61.454336

Re: Linux 3.16-rc6

2014-07-24 Thread Borislav Petkov
On Thu, Jul 24, 2014 at 04:38:28PM -0400, Waiman Long wrote: > Borislav, can you apply the following patch on top of the lockdep > patch to see if it can fix the problem? It is too late here for me to test anything but the ingridients to reproduce are nothing special. Just grab a kvm guest and pic

Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

2014-07-24 Thread Greg KH
On Thu, Jul 24, 2014 at 12:20:37PM -0400, Sasha Levin wrote: > On 07/24/2014 12:04 PM, Greg KH wrote: > >> If you add a revert and leave the original broken commit in, wouldn't it > >> cause issues > >> > for anyone trying to bisect a build breakage? > > Yes it does. > > > > I can not rebase my p

Re: Linux 3.16-rc6

2014-07-24 Thread Waiman Long
On 07/24/2014 02:36 PM, Peter Zijlstra wrote: On Thu, Jul 24, 2014 at 11:18:16AM -0700, Linus Torvalds wrote: On Thu, Jul 24, 2014 at 5:58 AM, Peter Zijlstra wrote: So going by the nifty picture rostedt made: [ 61.454336]CPU0CPU1 [ 61.454336]

Re: Linux 3.16-rc6

2014-07-24 Thread Peter Zijlstra
On Thu, Jul 24, 2014 at 11:18:16AM -0700, Linus Torvalds wrote: > On Thu, Jul 24, 2014 at 5:58 AM, Peter Zijlstra wrote: > > > > So going by the nifty picture rostedt made: > > > > [ 61.454336]CPU0CPU1 > > [ 61.454336] > > [ 61.

Re: Linux 3.16-rc6

2014-07-24 Thread Linus Torvalds
On Thu, Jul 24, 2014 at 5:58 AM, Peter Zijlstra wrote: > > So going by the nifty picture rostedt made: > > [ 61.454336]CPU0CPU1 > [ 61.454336] > [ 61.454336] lock(&(&p->alloc_lock)->rlock); > [ 61.454336]

Re: Report about a "please report the device ID to the Linux USB developers!" message

2014-07-24 Thread Antonio
Hi! > [...] will probably fix your problem Thank you for being kind. As far as I can tell, the modem is working correctly, I wrote to this list because I saw a "usb_modeswitch: please report the device ID to the Linux USB developers!" message and I thought that reporting was my duty :-). But no

[PATCH v4] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-24 Thread Wang YanQing
PL2303HX has two GPIOs, this patch add interface for it. Signed-off-by: Wang YanQing --- Changes v3-v4: 1: fix missing static for gpio_dir_mask and gpio_value_mask 2: reduce unneeded compile macro defined suggested by gno...@lxorguk.ukuu.org.uk 3: use true instead of 1 corrected by Linus Wal

Re: Linux 3.16-rc6

2014-07-24 Thread Borislav Petkov
On Thu, Jul 24, 2014 at 02:58:14PM +0200, Peter Zijlstra wrote: > Of course we should have made the lockdep change before merging qrwlock, > and that's entirely my fail, but with qrwlock in these new semantics are > already a reality. > > We could of course disable qrwlock until all such issues ar

Re: [PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Arnd Bergmann
On Thursday 24 July 2014 15:14:12 Peter Griffin wrote: > > > > Depending on what kind of special requirements the ST version has, > > > > this can be done either by using the generic ohci/ehci bindings > > > > with extensions where necessary, or by creating a new binding and > > > > new driver fil

Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

2014-07-24 Thread Sasha Levin
On 07/24/2014 12:04 PM, Greg KH wrote: >> If you add a revert and leave the original broken commit in, wouldn't it >> cause issues >> > for anyone trying to bisect a build breakage? > Yes it does. > > I can not rebase my public trees, nor should any other kernel > maintainer. This has been true

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 9:07 AM, Vlastimil Babka wrote: > On 07/23/2014 05:24 AM, Nick Krause wrote: >> >> On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin wrote: >>> >>> On 07/18/2014 10:52 PM, Nick Krause wrote: >> >> Please explain exactly why it's not needed, why it can never be NULL, >>>

Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

2014-07-24 Thread Greg KH
On Thu, Jul 24, 2014 at 09:14:49AM -0400, Sasha Levin wrote: > On 07/23/2014 12:49 PM, Greg KH wrote: > > On Wed, Jul 23, 2014 at 08:56:10AM -0400, Sasha Levin wrote: > >> > Revert since the commit message is incorrect and the original author > >> > refuses > >> > to fix/maintain it because "it's

Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return

2014-07-24 Thread Joe Perches
On Thu, 2014-07-24 at 17:46 +0200, Fabian Frederick wrote: > > > On 24 July 2014 at 13:37 Oliver Neukum wrote: > > > > > > On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote: > > > Small patchset addressing break redundancy on drivers/usb branch > > > (suggested by Joe Perches). > > > > Fr

Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return

2014-07-24 Thread Fabian Frederick
> On 24 July 2014 at 13:37 Oliver Neukum wrote: > > > On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote: > > Small patchset addressing break redundancy on drivers/usb branch > > (suggested by Joe Perches). > > Frankly, that is not a good idea. Somebody will remove a "goto" > and forget t

Re: [PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Alan Stern
On Thu, 24 Jul 2014, Arnd Bergmann wrote: > > > The way you do this apparently is to create a device that encapsulates > > > the OHCI and the EHCI and then goes on to create child devices that > > > are bound to the real drivers. > > > > Yes, although this isn't the first driver to take that appr

Re: [PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Peter Griffin
Hi Arnd, > > > > I'm of course happy to change it if required. I see looking through that a > > lot > > of other platforms do it the way you describe with a > > > > ehci-.c and ohci-.c > > Right. We are trying to gradually move some of them over to use the > generic *hci-platform.c drivers

Re: [PATCH] usb: xhci: Fix Set TR Dequeue Pointer cycle state for quirky xHCs

2014-07-24 Thread Mathias Nyman
On 07/17/2014 10:50 PM, Julius Werner wrote: >> Hmm. Wouldn't it be safer to have a quirk for this, and only enable >> the workaround if the Asmedia controller is detected? This code is so >> complicated that it is difficult to see whether this could have a >> harmful effect on controllers without

Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"

2014-07-24 Thread Sasha Levin
On 07/23/2014 12:49 PM, Greg KH wrote: > On Wed, Jul 23, 2014 at 08:56:10AM -0400, Sasha Levin wrote: >> > Revert since the commit message is incorrect and the original author >> > refuses >> > to fix/maintain it because "it's in the kernel already". > How can someone "fix" a commit message that i

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-24 Thread Vlastimil Babka
On 07/23/2014 05:24 AM, Nick Krause wrote: On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin wrote: On 07/18/2014 10:52 PM, Nick Krause wrote: Please explain exactly why it's not needed, why it can never be NULL, and what prevents it from being NULL. "after dicussing" (do you run spellcheck on you

Re: [PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Arnd Bergmann
On Thursday 24 July 2014 13:22:54 Peter Griffin wrote: > Thanks for reviewing, see my comments below: - > > > Unfortunately, this seems to be done in a rather strange way, > > I suspect you'll have to start over, but I'll let Alan and Greg > > weigh in. > > > > > + > > > +struct st_hcd_dev { > >

Re: Linux 3.16-rc6

2014-07-24 Thread Peter Zijlstra
On Thu, Jul 24, 2014 at 02:25:13PM +0200, Borislav Petkov wrote: > On Thu, Jul 24, 2014 at 10:41:27AM +0200, Borislav Petkov wrote: > > you can easily reproduce by booting a kvm guest with rc6 + tip/master. > > Right, so reverting > > 586fefe5bbdc ("locking/selftest: Support queued rwlock") > e06

Re: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-24 Thread Antoine Ténart
Hi Peter, On Thu, Jul 24, 2014 at 07:39:42PM +0800, Peter Chen wrote: > On Tue, Jul 15, 2014 at 04:39:16PM +0200, Antoine Ténart wrote: > > > > /** > > + * _ci_usb_phy_init: initialize phy taking in account both phy and usb_phy > > + * interfaces > > + * @ci: the controller > > + * > > + * This

Re: Linux 3.16-rc6

2014-07-24 Thread Borislav Petkov
On Thu, Jul 24, 2014 at 10:41:27AM +0200, Borislav Petkov wrote: > you can easily reproduce by booting a kvm guest with rc6 + tip/master. Right, so reverting 586fefe5bbdc ("locking/selftest: Support queued rwlock") e0645a111cb4 ("locking/lockdep: Restrict the use of recursive read_lock() with qr

Re: [PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Peter Griffin
Hi Arnd, Thanks for reviewing, see my comments below: - > Unfortunately, this seems to be done in a rather strange way, > I suspect you'll have to start over, but I'll let Alan and Greg > weigh in. > > > + > > +struct st_hcd_dev { > > + int port_nr; > > + struct platform_device *ehci_device;

Re: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-24 Thread Peter Chen
On Tue, Jul 15, 2014 at 04:39:16PM +0200, Antoine Ténart wrote: > This patch adds support of the PHY framework for ChipIdea drivers. > Changes are done in both the ChipIdea common code and in the drivers > accessing the PHY. This is done by adding a new PHY member in > ChipIdea's structures and by

Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return

2014-07-24 Thread Oliver Neukum
On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote: > Small patchset addressing break redundancy on drivers/usb branch > (suggested by Joe Perches). Frankly, that is not a good idea. Somebody will remove a "goto" and forget to readd the "break" Regards Oliver -- T

Re: [PATCH 06/10 linux-next] xhci: remove unnecessary break after return

2014-07-24 Thread Mathias Nyman
On 07/24/2014 11:18 AM, Fabian Frederick wrote: > Signed-off-by: Fabian Frederick > --- Acked-by: Mathias Nyman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Lee Jones
On Thu, 24 Jul 2014, Peter Griffin wrote: > This driver adds support for the USB HCD present in STi > SoC's from STMicroelectronics. It has been tested on the > stih416-b2020 board. > > Signed-off-by: Peter Griffin > --- > drivers/usb/host/Kconfig | 12 ++ > drivers/usb/host/Makefile | 1 +

Re: [PATCH v2 7/8] usb: rename transceiver and phy to usb_phy in ChipIdea

2014-07-24 Thread Peter Chen
On Tue, Jul 15, 2014 at 04:39:15PM +0200, Antoine Ténart wrote: > This patch prepares the introduction of the generic PHY support in the > USB ChipIdea common functions. The USB PHY member of the ChipIdea > structure ('transceiver') is renamed to 'usb_phy', the 'phy' member of > the ChipIdea pdata

Re: [PATCH v2 2/3] usb: host: st-hcd: Add st-hcd devicetree bindings documentation.

2014-07-24 Thread Lee Jones
On Thu, 24 Jul 2014, Peter Griffin wrote: > This patch documents the device tree documentation required for > the ST HCD controller found in STMicroelectronics SoCs. > > Signed-off-by: Peter Griffin > --- > Documentation/devicetree/bindings/usb/st-hcd.txt | 49 > > 1 f

Re: [PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Arnd Bergmann
On Thursday 24 July 2014 12:00:14 Peter Griffin wrote: > This driver adds support for the USB HCD present in STi > SoC's from STMicroelectronics. It has been tested on the > stih416-b2020 board. Unfortunately, this seems to be done in a rather strange way, I suspect you'll have to start over, but

Re: [PATCH v2 3/3] MAINTAINERS: Add st-hcd to ARCH/STI architecture

2014-07-24 Thread Lee Jones
On Thu, 24 Jul 2014, Peter Griffin wrote: > Signed-off-by: Peter Griffin > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) I Acked, this already. Please carry them forward through revisions. Acked-by: Lee Jones > diff --git a/MAINTAINERS b/MAINTAINERS > index 702ca10..359a64e 1006

[PATCH v2 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Peter Griffin
This driver adds support for the USB HCD present in STi SoC's from STMicroelectronics. It has been tested on the stih416-b2020 board. Signed-off-by: Peter Griffin --- drivers/usb/host/Kconfig | 12 ++ drivers/usb/host/Makefile | 1 + drivers/usb/host/st-hcd.c | 460 ++

[PATCH v2 3/3] MAINTAINERS: Add st-hcd to ARCH/STI architecture

2014-07-24 Thread Peter Griffin
Signed-off-by: Peter Griffin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 702ca10..359a64e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1325,6 +1325,7 @@ F:drivers/pinctrl/pinctrl-st.c F: drivers/media/rc/st_rc.c F: driver

[PATCH v2 2/3] usb: host: st-hcd: Add st-hcd devicetree bindings documentation.

2014-07-24 Thread Peter Griffin
This patch documents the device tree documentation required for the ST HCD controller found in STMicroelectronics SoCs. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/st-hcd.txt | 49 1 file changed, 49 insertions(+) create mode 100644 Documentat

[PATCH v2 0/3] Add USB HCD support for STi SoCs

2014-07-24 Thread Peter Griffin
This driver adds support for the USB HCD controller present in STi SoC's from STMicroelectronics. It has been tested on the stih416-b2020 board. The original author is no longer with the company and therefore emails to his address bounce, thus I have not added him to CC. Changes since v1: - Corr

Re: Report about a "please report the device ID to the Linux USB developers!" message

2014-07-24 Thread Antonio
Hi! > What we see here is a device not being stable on the usb bus and the > same has been reported for Ubuntu 14.04, multiple switching due to the > device being reset. > What kind of USB port is it connected to, USB 3.0? The modem is connected to a USB 2.0 port (that lapton only has USB 2.0

Re: Report about a "please report the device ID to the Linux USB developers!" message

2014-07-24 Thread Lars Melin
On 2014-07-24 16:07, Antonio wrote: Hi! When using a ZTE usb modem (that works correctly) I found a "please report the device ID to the Linux USB developers!" message in the /var/log/syslog file of a computer running Kubuntu 14.04. The command "uname -a" answers Linux laptop 3.13.0-32-gene

Re: [PATCH 1/3] usb: host: st-hcd: Add USB HCD support for STi SoCs

2014-07-24 Thread Peter Griffin
Hi Lee, Thanks for reviewing. All your review comments have been fixed in v2. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-24 Thread One Thousand Gnomes
On Wed, 23 Jul 2014 09:21:29 -0700 Greg KH wrote: > On Wed, Jul 23, 2014 at 05:03:14PM +0100, One Thousand Gnomes wrote: > > > + if (gpiochip_remove(&spriv->gpio->gpio_chip)) > > > + dev_err(&serial->interface->dev, "unable to remove > > > gpio_chip?\n"); > > > +

Report about a "please report the device ID to the Linux USB developers!" message

2014-07-24 Thread Antonio
Hi! When using a ZTE usb modem (that works correctly) I found a "please report the device ID to the Linux USB developers!" message in the /var/log/syslog file of a computer running Kubuntu 14.04. The command "uname -a" answers Linux laptop 3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:

Re: Linux 3.16-rc6

2014-07-24 Thread Borislav Petkov
On Thu, Jul 24, 2014 at 08:43:53AM +0200, Peter Zijlstra wrote: > On Wed, Jul 23, 2014 at 05:37:43PM -0700, Linus Torvalds wrote: > > On Wed, Jul 23, 2014 at 2:53 AM, Borislav Petkov wrote: > > > > > > Well, it looks like we f*cked up something after -rc5 since I'm starting > > > to see lockdep sp

[PATCH net] r8152: fix the checking of the usb speed

2014-07-24 Thread Hayes Wang
When the usb speed of the RTL8152 is not high speed, the USB_DEV_STAT[2:1] should be equal to [0 1]. That is, the STAT_SPEED_FULL should be equal to 2. There is a easy way to check the usb speed by the speed field of the struct usb_device. Use it to replace the original metheod. Signed-off-by: Ha

[PATCH 10/10 linux-next] USB: microtek: remove unnecessary break after goto

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/image/microtek.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c index 37b44b0..5cf2111 100644 --- a/drivers/usb/image/microtek.c +++ b/drivers/usb/image/microtek.c @@ -294,7 +294,6 @@ s

[PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return

2014-07-24 Thread Fabian Frederick
Small patchset addressing break redundancy on drivers/usb branch (suggested by Joe Perches). Fabian Frederick (10): USB: iowarrior: remove unnecessary break after goto USB: usblcd: remove unnecessary break after return usb: dcw3: remove unnecessary break after return usb: gadget: remove un

[PATCH 02/10 linux-next] USB: usblcd: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/misc/usblcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c index 1184390..5085d69 100644 --- a/drivers/usb/misc/usblcd.c +++ b/drivers/usb/misc/usblcd.c @@ -190,7 +190,6 @@ static long lcd_

[PATCH 01/10 linux-next] USB: iowarrior: remove unnecessary break after goto

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/misc/iowarrior.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index c6bfd13..17ce9a4 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -381,7 +381,6 @

[PATCH 03/10 linux-next] usb: dcw3: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/dwc3/ep0.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index 21a3520..927dad3 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c @@ -422,7 +422,6 @@ static int dwc3_ep0_handle_fe

[PATCH 04/10 linux-next] usb: gadget: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/gadget/legacy/tcm_usb_gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/legacy/tcm_usb_gadget.c b/drivers/usb/gadget/legacy/tcm_usb_gadget.c index 6cdb7a5..fb7cbb4 100644 --- a/drivers/usb/gadget/legacy/tcm_usb_gadget

[PATCH 07/10 linux-next] usb: storage: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/storage/freecom.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/storage/freecom.c b/drivers/usb/storage/freecom.c index ef16068..e6f8c1f 100644 --- a/drivers/usb/storage/freecom.c +++ b/drivers/usb/storage/freecom.c @@ -417,7 +417,6

[PATCH 06/10 linux-next] xhci: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/host/xhci-mem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 8056d90..aa5eb64 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -1129,7 +1129,6 @@ int

[PATCH 08/10 linux-next] USB: serial: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/serial/iuu_phoenix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c index 5ad4a0f..705e9dd 100644 --- a/drivers/usb/serial/iuu_phoenix.c +++ b/drivers/usb/serial/iuu_phoenix.c

[PATCH 05/10 linux-next] usb: gadget: remove unnecessary break after goto

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/gadget/function/f_hid.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c index a95290a..21c4b9c 100644 --- a/drivers/usb/gadget/function/f_hid.c +++ b/drivers/usb/g

[PATCH 09/10 linux-next] USB: ftdi_sio: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/serial/ftdi_sio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index b9035c3..bb45c71 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -2414,7 +2414

[PATCH 1/2] USB: serial: ftdi_sio: Annotate the current Xsens PID assignments

2014-07-24 Thread Frans Klaver
From: Patrick Riphagen The converters are used in specific products. It can be useful to know which they are exactly. Signed-off-by: Patrick Riphagen Signed-off-by: Frans Klaver Cc: Johan Hovold Cc: Greg Kroah-Hartman Cc: stable --- drivers/usb/serial/ftdi_sio_ids.h | 10 +- 1 file

[PATCH 2/2] USB: serial: ftdi_sio: Add support for new Xsens devices

2014-07-24 Thread Frans Klaver
From: Patrick Riphagen This adds support for new Xsens devices, using Xsens' own Vendor ID. Signed-off-by: Patrick Riphagen Signed-off-by: Frans Klaver Cc: Johan Hovold Cc: Greg Kroah-Hartman Cc: stable --- drivers/usb/serial/ftdi_sio.c | 2 ++ drivers/usb/serial/ftdi_sio_ids.h | 3 +++

Re: [PATCH 0/2] USB: serial: ftdi_sio: Add support for new Xsens devices

2014-07-24 Thread Frans Klaver
Hi Greg, On Wed, Jul 23, 2014 at 05:01:02PM -0700, Greg Kroah-Hartman wrote: > Your patches were mal-formed and could not be applied at all, please fix > up your email client to not eat tabs and resend. It seems we're running into mail server settings that have been adapted for my use, but not fo