Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-15 Thread Pratyush Anand
Hi David, Thanks for your review. On Tue, Jul 15, 2014 at 10:58:03PM +0800, David Laight wrote: > From: Alan Stern > > On Tue, 15 Jul 2014, Pratyush Anand wrote: > ... > > > +static int wait_for_ss_port_enable(struct usb_device *udev, > > > + struct usb_hub *hub, >

Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-15 Thread Pratyush Anand
Hi Alan, Thanks a lot for your review. On Tue, Jul 15, 2014 at 10:46:00PM +0800, Alan Stern wrote: > On Tue, 15 Jul 2014, Pratyush Anand wrote: > > > Problem Summary: Problem has been observed generally with PM states > > where VBUS goes off during suspend. There are some SS USB devices which >

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-15 Thread Peter Chen
On Tue, Jul 15, 2014 at 05:24:37PM +0200, Antoine Ténart wrote: > Hi, > > On Thu, Jul 03, 2014 at 08:17:34AM +0530, punnaiah choudary kalluri wrote: > > Since its a generic driver, support for configuring the dma_mask using > > dma_coerce_mask_and_coherent would be good. > > > > Should I add a D

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-15 Thread Peter Chen
On Tue, Jul 15, 2014 at 05:22:30PM +0200, Antoine Ténart wrote: > Hi guys, > > On Wed, Jul 02, 2014 at 01:10:00AM +, Peter Chen wrote: > > > On 07/01/2014 02:42 PM, Alexandre Belloni wrote: > > > > > > > Well, there is nothing specific about the Berlin CI. Some > > > > subsystems use

RE: Iso trbs for xhci arrangement

2014-07-15 Thread Paul Zimmerman
> From: vichy [mailto:vichy@gmail.com] > Sent: Tuesday, July 15, 2014 1:42 AM > > > Please read section 3.2.11 in the xHCI spec, which is freely available on > > the web. > I found what you mean. > I dump "ep context", "ep ring" and "event ring" for handling short package. > > Driver prepare

Re: [PATCH v4 3/4] usb: gadget: pxa27x_udc: use devm_* helpers

2014-07-15 Thread Robert Jarzmik
Felipe Balbi writes: > > will do. Just give me a couple days as I'm dealing with a lot right now > ;-) Ok, no problem. That would give a bit of time for Mark to send his Acked-by, won't it Mark ? ;) Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in th

Re: uas regression in 3.15 with Lacie Rugged USB3 and NEC uPD720200

2014-07-15 Thread Julian Sikorski
W dniu 15.07.2014 07:31, Julian Sikorski pisze: > W dniu 14.07.2014 23:59, Jonathan pisze: >> Julian, >> >> My issue appears to be related to the Etron xhci controller on my >> motherboard and not the ASMedia chipset in my USB dock. You can identify >> your xhci controller with the lspci command

Re: [PATCH v4 3/4] usb: gadget: pxa27x_udc: use devm_* helpers

2014-07-15 Thread Felipe Balbi
On Tue, Jul 15, 2014 at 07:50:35PM +0200, Robert Jarzmik wrote: > Sergei Shtylyov writes: > > > Hello. > > > >> @@ -2524,35 +2518,21 @@ static int pxa_udc_probe(struct platform_device > >> *pdev) > >>pxa_eps_setup(udc); > >> > >>/* irq setup after old hardware state is cleaned up */ > >>

Re: [PATCHv4 0/3] Gadget directory cleanup

2014-07-15 Thread Felipe Balbi
Hi, On Tue, Jul 15, 2014 at 01:09:43PM +0200, Andrzej Pietrasiewicz wrote: > This is a follow-up to this thread: > > http://www.spinics.net/lists/linux-usb/msg107611.html > > The cleanup rearranges the way source code files are located in the > drivers/usb/gadget directory. New subdirectories ar

Re: Possible bug in xhci-ring.c

2014-07-15 Thread Julius Werner
Hi Maciej, On Tue, Jul 15, 2014 at 11:29 AM, Maciej Puzio wrote: > Julius, I tested the patch on kernel 3.2.61, on two USB 3.0 host > controllers (Asmedia and NEC), and four USB 3.0 devices (three of > which were previously triggering the issue, and one worked fine). On > the Asmedia controller,

Re: Possible bug in xhci-ring.c

2014-07-15 Thread Maciej Puzio
Julius, I tested the patch on kernel 3.2.61, on two USB 3.0 host controllers (Asmedia and NEC), and four USB 3.0 devices (three of which were previously triggering the issue, and one worked fine). On the Asmedia controller, the patch fixes the regression, but with one of the devices (Areca ARC-5040

Re: [PATCH v4 3/4] usb: gadget: pxa27x_udc: use devm_* helpers

2014-07-15 Thread Robert Jarzmik
Sergei Shtylyov writes: > Hello. > >> @@ -2524,35 +2518,21 @@ static int pxa_udc_probe(struct platform_device >> *pdev) >> pxa_eps_setup(udc); >> >> /* irq setup after old hardware state is cleaned up */ >> -retval = request_irq(udc->irq, pxa_udc_irq, >> -IRQF_S

Re: [PATCH v2 0/8] usb: add support for the generic PHY framework

2014-07-15 Thread Alan Stern
On Tue, 15 Jul 2014, Antoine Ténart wrote: > Hi all, > > This is an attempt to add more common USB code aware of the generic PHY > framework, while keeping the compatibility for the USB PHY one. It does > not add the full support, some USB PHY specific functions not being > available currently in

Re: [PATCH v2 4/8] usb: rename phy to usb_phy in HCD

2014-07-15 Thread Sergei Shtylyov
Hello. On 07/15/2014 06:39 PM, Antoine Ténart wrote: The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. Signed-off-by: Antoine Ténart I've been thru that and such change has been turned down already. WBR, Sergei --

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-15 Thread Antoine Ténart
Hi, On Thu, Jul 03, 2014 at 08:17:34AM +0530, punnaiah choudary kalluri wrote: > Since its a generic driver, support for configuring the dma_mask using > dma_coerce_mask_and_coherent would be good. > Should I add a DMA mask dt property? Or just not add this and wait for someone needing it in his

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-15 Thread Antoine Ténart
Hi guys, On Wed, Jul 02, 2014 at 01:10:00AM +, Peter Chen wrote: > > On 07/01/2014 02:42 PM, Alexandre Belloni wrote: > > > > > Well, there is nothing specific about the Berlin CI. Some > > > subsystems use the 'generic' keyword in these cases. Do you see a > > > particular reason

System freezes when plugging in / resume with USB3 Dock

2014-07-15 Thread Milan Votava
I have two USB3 Docks (Asus HZ-1 at home, Toshiba Dynadock at office). Every day in the evening I put my laptop (Razer Blade Pro) into sleep with Asus USB dock plugged in. Next day in the morning I unplug the dock (laptop still sleeps) and move to the office where I plug in another USB3 dock (Toshi

RE: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-15 Thread David Laight
From: Alan Stern > On Tue, 15 Jul 2014, Pratyush Anand wrote: ... > > +static int wait_for_ss_port_enable(struct usb_device *udev, > > + struct usb_hub *hub, > > + int *port1, > > + u16 *portchange

Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-15 Thread Alan Stern
On Tue, 15 Jul 2014, Pratyush Anand wrote: > Problem Summary: Problem has been observed generally with PM states > where VBUS goes off during suspend. There are some SS USB devices which > takes slightly longer time for link training compared to many others. > Such devices fails to reconnect with

[PATCH v2 4/8] usb: rename phy to usb_phy in HCD

2014-07-15 Thread Antoine Ténart
The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. Signed-off-by: Antoine Ténart --- drivers/usb/chipidea/host.c | 2 +- drivers/usb/core/hcd.c| 20 ++-- drivers/usb/core/hub.c| 8 d

[PATCH v2 0/8] usb: add support for the generic PHY framework

2014-07-15 Thread Antoine Ténart
Hi all, This is an attempt to add more common USB code aware of the generic PHY framework, while keeping the compatibility for the USB PHY one. It does not add the full support, some USB PHY specific functions not being available currently in the generic PHY subsystem (e.g. usb_phy_set_power()). B

[PATCH v2 6/8] usb: allow to supply the PHY in the drivers when using HCD

2014-07-15 Thread Antoine Ténart
This patch modify the generic code handling PHYs to allow them to be supplied from the drivers. This adds checks to ensure no PHY was already there when looking for one in the generic code. This also makes sure we do not modify its state in the generic HCD functions, it it was provided by the drive

[PATCH v2 2/8] usb: rename phy to usb_phy in OTG

2014-07-15 Thread Antoine Ténart
This patch prepares the introduction of the generic PHY support in the USB OTG common functions. The USB PHY member of the OTG structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. Renaming this pointer will allow to keep the compatibility for USB PHY drivers. S

[PATCH v2 5/8] usb: rename gen_phy to phy in HCD

2014-07-15 Thread Antoine Ténart
The patch adding support to the generic PHY framework introduced a 'gen_phy' member in the HCD structure. Rename it to 'phy' to have a consistent USB framework. Signed-off-by: Antoine Ténart --- drivers/usb/core/hcd.c | 22 +++--- include/linux/usb/hcd.h | 4 +++- 2 files chang

[PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-15 Thread Antoine Ténart
This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by taking care of it in the code. Signed-off-by: Antoine Ténart --- driv

[PATCH v2 7/8] usb: rename transceiver and phy to usb_phy in ChipIdea

2014-07-15 Thread Antoine Ténart
This patch prepares the introduction of the generic PHY support in the USB ChipIdea common functions. The USB PHY member of the ChipIdea structure ('transceiver') is renamed to 'usb_phy', the 'phy' member of the ChipIdea pdata structure is renamed to 'usb_phy' and modifications are done in all driv

[PATCH v2 3/8] usb: add support to the generic PHY framework in OTG

2014-07-15 Thread Antoine Ténart
This patch adds support of the PHY framework in OTG and keeps the USB PHY compatibility. Here the only modification is to add PHY member in the OTG structure, along with the USB PHY one. Signed-off-by: Antoine Ténart --- include/linux/usb/otg.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

Re: disable VBUS?

2014-07-15 Thread Alan Stern
On Mon, 14 Jul 2014, Grant wrote: > >> >> I should have been more specific then. I think I understand, but to > >> >> be sure, if I splice a USB cable, power VBUS with an external 5V power > >> >> supply, and connect a host and device, the device will work as if the > >> >> cable was connected to

Re: [PATCH 1/1] usb: Check if port status is equal to RxDetect

2014-07-15 Thread Alan Stern
On Fri, 11 Jul 2014, Gavin Guo wrote: > When using USB 3.0 pen drive with the [AMD] FCH USB XHCI Controller > [1022:7814], the second hotplugging will experience the USB 3.0 pen > drive is recognized as high-speed device. After bisecting the kernel, > I found the commit number 41e7e056cdc662f704fa

[PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-07-15 Thread Li Jun
This patch try to dequeue the cdev->req to guarantee the request is not queued before free it. Signed-off-by: Li Jun --- drivers/usb/gadget/composite.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index f801519..6935a82 10

[PATCH] usb: gadget: fix the sequence modules are built

2014-07-15 Thread Andrzej Pietrasiewicz
If gadget g_*.ko modules are built-in their initialization happens before libcomposite is initialized. This results in e.g. g_ether not initializing if compiled-in. This patch fixes the order modules are built, so that they are initialized in proper order when built-in. Signed-off-by: Andrzej Piet

[PATCHv4 0/3] Gadget directory cleanup

2014-07-15 Thread Andrzej Pietrasiewicz
This is a follow-up to this thread: http://www.spinics.net/lists/linux-usb/msg107611.html The cleanup rearranges the way source code files are located in the drivers/usb/gadget directory. New subdirectories are introduced: - "udc" for UDC chip drivers - "function" for actual usb functions' imple

[RFC] USB: Fix persist resume of some SS USB devices

2014-07-15 Thread Pratyush Anand
Problem Summary: Problem has been observed generally with PM states where VBUS goes off during suspend. There are some SS USB devices which takes slightly longer time for link training compared to many others. Such devices fails to reconnect with same old address which was associated with it before

Re: [PATCH 3/4] usb: add support to the PHY framework for HCD

2014-07-15 Thread Antoine Ténart
Hi Vivek, On Mon, Jul 14, 2014 at 02:38:03PM +0530, Vivek Gautam wrote: > On Wed, Jul 9, 2014 at 3:47 PM, Antoine Ténart > wrote: > > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > > index bec31e2efb88..b985af5b167c 100644 > > --- a/drivers/usb/core/hcd.c > > +++ b/drivers/usb/cor

Re: Iso trbs for xhci arrangement

2014-07-15 Thread vichy
hi Paul: > Please read section 3.2.11 in the xHCI spec, which is freely available on > the web. I found what you mean. I dump "ep context", "ep ring" and "event ring" for handling short package. Driver prepare ep ring like below xhci.0: @2796e150 279cfb04 000404fc 80021415 /