Re: [PATCH v2 05/12] usb: phy: add the Berlin USB PHY driver

2014-06-27 Thread Felipe Balbi
On Fri, Jun 27, 2014 at 06:05:57PM +0200, Antoine Ténart wrote: > Hi Felipe, > > On Fri, Jun 27, 2014 at 10:56:22AM -0500, Felipe Balbi wrote: > > On Tue, Jun 24, 2014 at 12:35:14PM +0200, Antoine Ténart wrote: > > > Add the driver driving the Marvell Berlin USB PHY. This allows to > > > initializ

Re: [PATCH v1 6/9] usb: xhci: Add NVIDIA Tegra XHCI host-controller driver

2014-06-27 Thread Stephen Warren
On 06/27/2014 03:19 PM, Andrew Bresticker wrote: > On Thu, Jun 26, 2014 at 11:07 AM, Stephen Warren > wrote: >> On 06/25/2014 06:06 PM, Andrew Bresticker wrote: >>> On Wed, Jun 25, 2014 at 3:37 PM, Stephen Warren >>> wrote: On 06/18/2014 12:16 AM, Andrew Bresticker wrote: > Add support

Re: [PATCH v1 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-06-27 Thread Andrew Bresticker
On Thu, Jun 26, 2014 at 11:08 AM, Stephen Warren wrote: > On 06/25/2014 05:30 PM, Andrew Bresticker wrote: >> On Wed, Jun 25, 2014 at 3:12 PM, Stephen Warren >> wrote: >>> On 06/18/2014 12:16 AM, Andrew Bresticker wrote: In addition to the PCIe and SATA PHYs, the XUSB pad controller also >>

Re: [PATCH v1 6/9] usb: xhci: Add NVIDIA Tegra XHCI host-controller driver

2014-06-27 Thread Andrew Bresticker
On Thu, Jun 26, 2014 at 11:07 AM, Stephen Warren wrote: > On 06/25/2014 06:06 PM, Andrew Bresticker wrote: >> On Wed, Jun 25, 2014 at 3:37 PM, Stephen Warren >> wrote: >>> On 06/18/2014 12:16 AM, Andrew Bresticker wrote: Add support for the on-chip XHCI host controller present on Tegra SoCs

Re: [usb-storage] Re: External USB3 disk fails with "Invalid field in cdb"

2014-06-27 Thread Michael Büsch
On Fri, 27 Jun 2014 15:23:42 -0400 (EDT) Alan Stern wrote: > > MaxPower=2mA is a nice guess for a hard disk. ;) > > That refers to the amount of power the device draws from the USB bus. > Since the disk drive is self-powered, it doesn't use much bus power. Unless the device uses free energy o

Re: [usb-storage] Re: External USB3 disk fails with "Invalid field in cdb"

2014-06-27 Thread Alan Stern
On Fri, 27 Jun 2014, Michael Büsch wrote: > On Fri, 27 Jun 2014 14:42:01 -0400 (EDT) > Alan Stern wrote: > > > Michael, can you post the "lsusb -v" output for this device? I see it > > is made by JMicron; they are notorious for buggy USB-ATA bridges. > > Of course. Here you go: > > Bus 004 D

Re: External USB3 disk fails with "Invalid field in cdb"

2014-06-27 Thread Michael Büsch
On Fri, 27 Jun 2014 14:42:01 -0400 (EDT) Alan Stern wrote: > Michael, can you post the "lsusb -v" output for this device? I see it > is made by JMicron; they are notorious for buggy USB-ATA bridges. Of course. Here you go: Bus 004 Device 009: ID 152d:0567 JMicron Technology Corp. / JMicron US

Re: External USB3 disk fails with "Invalid field in cdb"

2014-06-27 Thread Alan Stern
On Fri, 27 Jun 2014, Michael Büsch wrote: > On Fri, 27 Jun 2014 08:48:01 -0700 > James Bottomley wrote: > > > On Fri, 2014-06-27 at 17:34 +0200, Michael Büsch wrote: > > > I tried the following patch: > > > > > > Index: linux/drivers/scsi/sd.c > > > =

RE: [PATCH] usb: dwc2: fix sparse warning in platform.c

2014-06-27 Thread Paul Zimmerman
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Friday, June 27, 2014 11:00 AM > > On 06/27/2014 07:09 PM, dingu...@altera.com wrote: > >> From: Dinh Nguyen > >> This patch fixes this sparse warning: > >> drivers/usb/dwc2/platform.c:168:25: warning: incorrect type i

Re: External USB3 disk fails with "Invalid field in cdb"

2014-06-27 Thread Michael Büsch
On Fri, 27 Jun 2014 08:48:01 -0700 James Bottomley wrote: > On Fri, 2014-06-27 at 17:34 +0200, Michael Büsch wrote: > > I tried the following patch: > > > > Index: linux/drivers/scsi/sd.c > > === > > --- linux.orig/drivers/scsi/sd.c

Re: [PATCH] usb: dwc2: fix sparse warning in platform.c

2014-06-27 Thread Sergei Shtylyov
Hello. On 06/27/2014 07:09 PM, dingu...@altera.com wrote: From: Dinh Nguyen This patch fixes this sparse warning: drivers/usb/dwc2/platform.c:168:25: warning: incorrect type in argument 1 (different address spaces) drivers/usb/dwc2/platform.c:168:25:expected void const *ptr drivers/

Re: [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-27 Thread Greg Kroah-Hartman
On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote: > Replace all hardcoded ttyGS strings with the PREFIX macro. Why? > Therefore the PREFIX definition is moved to u_serial.h. Why? > Furthermore the modified files are checkpatch.pl compliant now. You are doing two different things

Re: [GIT PULL] USB-serial fixes for v3.16-rc3

2014-06-27 Thread Greg Kroah-Hartman
On Wed, Jun 25, 2014 at 10:26:52AM +0200, Johan Hovold wrote: > The following changes since commit a497c3ba1d97fc69c1e78e7b96435ba8c2cb42ee: > > Linux 3.16-rc2 (2014-06-21 19:02:54 -1000) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-

Re: Jetson TK1 USB support?

2014-06-27 Thread Alan Stern
On Fri, 27 Jun 2014, Grant wrote: > The following wiki page indicates that USB3 is not working on the Jetson TK1: > > http://elinux.org/Tegra/Boards/NVIDIA_Jetson_TK1 > > Does that mean USB is not working at all or should USB2 work? USB-2 won't work if the board includes only a USB-3 controller

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-27 Thread Olof Johansson
On Fri, Jun 27, 2014 at 9:32 AM, Doug Anderson wrote: > Felipe, > > On Fri, Jun 27, 2014 at 8:59 AM, Felipe Balbi wrote: >>> I'll admit to not having been involved with the previous discussions, >>> but this seems strange to me. Are we throwing in the towel and >>> deciding that it's too hard to

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-27 Thread Doug Anderson
Felipe, On Fri, Jun 27, 2014 at 8:59 AM, Felipe Balbi wrote: >> I'll admit to not having been involved with the previous discussions, >> but this seems strange to me. Are we throwing in the towel and >> deciding that it's too hard to get the Kconfigs right and that we'll >> just rely on individu

Jetson TK1 USB support?

2014-06-27 Thread Grant
The following wiki page indicates that USB3 is not working on the Jetson TK1: http://elinux.org/Tegra/Boards/NVIDIA_Jetson_TK1 Does that mean USB is not working at all or should USB2 work? I would have thought USB2 would still work but I think I tried disabling xhci_hcd and enabling ehci_hcd/ohc

Re: [PATCH v2 05/12] usb: phy: add the Berlin USB PHY driver

2014-06-27 Thread Antoine Ténart
Hi Felipe, On Fri, Jun 27, 2014 at 10:56:22AM -0500, Felipe Balbi wrote: > On Tue, Jun 24, 2014 at 12:35:14PM +0200, Antoine Ténart wrote: > > Add the driver driving the Marvell Berlin USB PHY. This allows to > > initialize the PHY and to use it from the USB driver later. > > > > Signed-off-by: A

Re: [PATCH v1 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-06-27 Thread Stephen Warren
On 06/27/2014 09:00 AM, Felipe Balbi wrote: > On Wed, Jun 25, 2014 at 04:30:48PM -0700, Andrew Bresticker wrote: +static int usb3_phy_power_on(struct phy *phy) +{ + struct tegra_xusb_padctl *padctl = phy_get_drvdata(phy); + int port = usb3_phy_to_port(phy); + in

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-27 Thread Felipe Balbi
On Fri, Jun 27, 2014 at 08:55:31AM -0700, Doug Anderson wrote: > Felipe, > > On Fri, Jun 27, 2014 at 8:46 AM, Felipe Balbi wrote: > > On Thu, Jun 26, 2014 at 11:09:37AM +0530, Sachin Kamat wrote: > >> EHCI and OHCI drivers on Exynos platforms do not work without their > >> corresponding SoC speci

Re: [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once

2014-06-27 Thread Felipe Balbi
On Wed, Jun 25, 2014 at 02:28:30PM +0200, Rickard Strandqvist wrote: > A struct member variable is set to the same value more than once > > This was found using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist I think there was a bigger series from Roger re

Re: [PATCH v2 05/12] usb: phy: add the Berlin USB PHY driver

2014-06-27 Thread Felipe Balbi
On Tue, Jun 24, 2014 at 12:35:14PM +0200, Antoine Ténart wrote: > Add the driver driving the Marvell Berlin USB PHY. This allows to > initialize the PHY and to use it from the USB driver later. > > Signed-off-by: Antoine Ténart since this is a brand new driver, it should go to drivers/phy instea

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-27 Thread Doug Anderson
Felipe, On Fri, Jun 27, 2014 at 8:46 AM, Felipe Balbi wrote: > On Thu, Jun 26, 2014 at 11:09:37AM +0530, Sachin Kamat wrote: >> EHCI and OHCI drivers on Exynos platforms do not work without their >> corresponding SoC specific phy drivers. Hence it makes no sense to >> keep these phy drivers as us

Re: [RFC PATCH 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-27 Thread Felipe Balbi
Hi, On Wed, Jun 18, 2014 at 06:01:08PM +0100, Srinivas Kandagatla wrote: > Use case is when the phy is configured in host mode and a usb device is > attached to board before bootup. On bootup, with the existing code and > runtime pm enabled, the driver would decrement the pm usage count > without

Re: musb + full speed device

2014-06-27 Thread Felipe Balbi
Hi, (please avoid top-posting) On Wed, Jun 25, 2014 at 10:59:57AM +0200, Pedro Erencia wrote: > Hi, > > Thanks for the suggestions Felipe. > > We are not processing our packets in during giveback, but anyway I've > tried your patch and it results in a very little (~5%) increase in > transfer ra

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-27 Thread Felipe Balbi
On Thu, Jun 26, 2014 at 11:09:37AM +0530, Sachin Kamat wrote: > EHCI and OHCI drivers on Exynos platforms do not work without their > corresponding SoC specific phy drivers. Hence it makes no sense to > keep these phy drivers as user selectable. Instead select them from > the respective USB configs

Re: [PATCH v6 1/1] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-06-27 Thread Felipe Balbi
On Wed, Jun 18, 2014 at 02:15:42PM +0900, Magnus Damm wrote: > Hi Felipe, > > On Fri, Jun 13, 2014 at 11:25 PM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Jun 13, 2014 at 09:20:31PM +0900, Yoshihiro Shimoda wrote: > >> The R-Car H2 and M2 SoCs come with an xHCI controller that requires > >> some

[PATCH] usb: dwc2: fix sparse warning in platform.c

2014-06-27 Thread dinguyen
From: Dinh Nguyen This patch fixes this sparse warning: drivers/usb/dwc2/platform.c:168:25: warning: incorrect type in argument 1 (different address spaces) drivers/usb/dwc2/platform.c:168:25:expected void const *ptr drivers/usb/dwc2/platform.c:168:25:got void [noderef] *regs drivers/us

Re: [PATCH v1 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-06-27 Thread Felipe Balbi
On Wed, Jun 25, 2014 at 04:30:48PM -0700, Andrew Bresticker wrote: > >> +static int usb3_phy_power_on(struct phy *phy) > >> +{ > >> + struct tegra_xusb_padctl *padctl = phy_get_drvdata(phy); > >> + int port = usb3_phy_to_port(phy); > >> + int lane = padctl->usb3_ports[port].lane; > >> +

Re: Fwd: Problem with Etron EJ168 USB3.0 Host Controller connected to USB 2.0 HUB and mouse/keyboard

2014-06-27 Thread Alan Stern
On Fri, 27 Jun 2014, Mathias Nyman wrote: > The configure endpoint command that fails with bandwidth error looks fine, > At least nothing suspicious in the bandwidth related data (input context) > sent with the command. > > This is a real bandwidth error, not like the Bugzilla bug that's actual

Re: Fwd: Problem with Etron EJ168 USB3.0 Host Controller connected to USB 2.0 HUB and mouse/keyboard

2014-06-27 Thread Mathias Nyman
On 06/27/2014 11:09 AM, Carsten Koepp wrote: > Hi Mathias, > > thanks for your quick response. You are right, it's a "bandwidth error" in > the bugzilla report, but it's not the same. > > Bugzilla: > > [ 316.281166] usb 8-2: Manufacturer: Hanlincrest Ltd. > [ 316.300249] xhci_hcd :02:00.

Re: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-27 Thread Alan Stern
On Fri, 27 Jun 2014, Chen, Alvin wrote: > From: Bryan O'Donoghue > > The EHCI packet buffer in/out threshold is programmable for Intel Quark X1000 > USB host > controller, and the default value is 0x20 dwords. The in/out threshold can be > programmed > to 0x80 dwords, but only when isochronous

Re: usb audio breaks ohci-pci

2014-06-27 Thread Alan Stern
On Thu, 26 Jun 2014, Dennis New wrote: > > > I wonder if this unbind'ing and bind'ing should be done > > > automatically, when a crash is detected? > > > > That's a separate discussion. To a large degree it doesn't matter, > > because most hardware is designed not to crash during use. > > > > I

Re: [PATCH v2 2/2] usb: chipidea: Add support for zynq usb host and device controller

2014-06-27 Thread Michael Grzeschik
Hi, On Fri, Jun 27, 2014 at 04:53:53PM +0530, Punnaiah Choudary Kalluri wrote: > Zynq soc uses Chipidea/Synopsys usb IP core(CI13612). This patch adds > necessary glue to allow the chipidea driver to work on zynq soc. > Did you see the currently discussed patches for the generic chipidea glue?

[PATCH 1/1] Add support for Corsair usb dongle

2014-06-27 Thread Andras
From: Andras Kovacs Corsair USB Dongles are shipped with Corsair AXi series PSUs. These are cp210x serial usb devices, so make driver detect these. I have a program, that can get information from these PSUs. Tested with 2 different dongles shipped with Corsair AX860i and AX1200i units. Signed-o

Re: [PATCH v2 1/2] usb: chipidea: zynq: Add device tree binding information

2014-06-27 Thread Sergei Shtylyov
Hello. On 06/27/2014 03:23 PM, Punnaiah Choudary Kalluri wrote: Document device tree binding information as required by the ZYNQ USB controller. Signed-off-by: Punnaiah Choudary Kalluri [...] diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt b/Documentation/devicetree/

[PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-27 Thread Richard Leitner
Replace all hardcoded ttyGS strings with the PREFIX macro. Therefore the PREFIX definition is moved to u_serial.h. Furthermore the modified files are checkpatch.pl compliant now. Signed-off-by: Richard Leitner --- drivers/usb/gadget/f_acm.c| 49 + d

[PATCH v2 2/2] usb: chipidea: Add support for zynq usb host and device controller

2014-06-27 Thread Punnaiah Choudary Kalluri
Zynq soc uses Chipidea/Synopsys usb IP core(CI13612). This patch adds necessary glue to allow the chipidea driver to work on zynq soc. Signed-off-by: Punnaiah Choudary Kalluri --- Changes in v2: - modified the commit message for better readability - fixed the dev_err message --- drivers/usb/chip

[PATCH v2 1/2] usb: chipidea: zynq: Add device tree binding information

2014-06-27 Thread Punnaiah Choudary Kalluri
Document device tree binding information as required by the ZYNQ USB controller. Signed-off-by: Punnaiah Choudary Kalluri --- Changes in v2: - none --- .../devicetree/bindings/usb/ci-hdrc-zynq.txt | 23 1 files changed, 23 insertions(+), 0 deletions(-) create mode 1

RE: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-27 Thread Chen, Alvin
> -Original Message- > From: David Laight [mailto:david.lai...@aculab.com] > Sent: Friday, June 27, 2014 4:08 PM > ... > > /* The maximal threshold value is 0x80, which means 512 bytes */ > > #define EHCI_THRESHOLD_512BYTES 0x80 > > #define EHCI_THRESHOLD_508BYTES

RE: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-27 Thread David Laight
From: Jingoo Han ... > /* The maximal threshold value is 0x80, which means 512 bytes */ > #define EHCI_THRESHOLD_512BYTES 0x80 > #define EHCI_THRESHOLD_508BYTES 0x79 It would be better to define these using expressions. So: #define EHCI_THRESHOLD_512BYTES (512u

RE: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-27 Thread Chen, Alvin
> > > The EHCI packet buffer in/out threshold is programmable for Intel > > > Quark X1000 USB host controller, and the default value is 0x20 > > > dwords. The in/out threshold can be programmed to 0x80 dwords, but > > > only when isochronous/interrupt transactions are not initiated by > > > the US