Re: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-06-06 Thread Thierry Reding
On Fri, Jun 06, 2014 at 06:32:42PM +0530, Vivek Gautam wrote: > On Wed, Jun 4, 2014 at 6:43 PM, Thierry Reding > wrote: > > On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote: > >> On Sat, May 10, 2014 at 5:30 PM, Vivek Gautam > >> wrote: [...] > >> > diff --git a/drivers/usb/host/ohc

[PATCH] usb: doc: hotplug.txt code typos

2014-06-06 Thread Jeremiah Mahler
Fixed several typos in the code examples given in Documentation/usb/hotplug.txt. - missing [] with array of struct usb_device_id - checkpatch.pl warning: space between function name and parenthesis - missing terminating ';' Signed-off-by: Jeremiah Mahler --- Documentation/usb/hotplug.tx

[PATCH 10/13] xhci: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc:

[PATCH] usb: option: add/modify Olivetti Olicard modems

2014-06-06 Thread Bjørn Mork
Adding a couple of Olivetti modems and blacklisting the net function on a couple which are already supported. Reported-by: Lars Melin Cc: Signed-off-by: Bjørn Mork --- drivers/usb/serial/option.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/driver

[PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators

2014-06-06 Thread Vivek Gautam
Facilitate getting required 3.3V and 1.0V VDD supply for EHCI controller on Exynos. With patches for regulators' nodes merged in 3.15: c8c253f ARM: dts: Add regulator entries to smdk5420 275dcd2 ARM: dts: add max77686 pmic node for smdk5250, certain perripherals will now need to ensure that, they

[PATCH v2 2/2] usb: ohci-exynos: Make provision for vdd regulators

2014-06-06 Thread Vivek Gautam
Facilitate getting required 3.3V and 1.0V VDD supply for OHCI controller on Exynos. With patches for regulators' nodes merged in 3.15: c8c253f ARM: dts: Add regulator entries to smdk5420 275dcd2 ARM: dts: add max77686 pmic node for smdk5250, certain perripherals will now need to ensure that, they

Re: ASMedia AS2105 interface on USB 3.0 corrupts data

2014-06-06 Thread Heinz Diehl
On 05.06.2014, Mathias Nyman wrote: > What kind of a hard drive did you have connected? > and with what filsystem? Just in case if that somehow affects the USB traffic. The HDD is a Western Digital 160 GB drive, here's the (abridged) output of "hdparm -I" [root@keera ~]# hdparm -I /dev/sdc /

Re: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-06-06 Thread Vivek Gautam
Hi, On Wed, Jun 4, 2014 at 6:43 PM, Thierry Reding wrote: > On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote: >> Hi, >> >> >> On Sat, May 10, 2014 at 5:30 PM, Vivek Gautam >> wrote: >> > Using devm_ioremap_resource() API should actually be preferred over >> > devm_ioremap(), since

[PATCH 1/4] phy: Add provision for calibrating phy.

2014-06-06 Thread Vivek Gautam
Some PHY controllers may need to calibrate certain PHY settings after initialization of the controller and sometimes even after initializing the PHY-consumer too. Add support for the same in order to let consumers do so in need. Signed-off-by: vivek Gautam --- drivers/phy/phy-core.c | 36

[PATCH 2/4] usb: host: xhci-plat: Add support to get PHYs

2014-06-06 Thread Vivek Gautam
The host controller by itself may sometimes need to handle PHY and/or calibrate some of the PHY settings to get full support out of the PHY controller. The PHY core provides a calibration funtionality now to do so. Therefore, facilitate getting the two possible PHY types for xhci controller, viz. U

[PATCH 3/4] usb: host: xhci-plat: Caibrate PHY post host reset

2014-06-06 Thread Vivek Gautam
Some quirky PHYs may require to be calibrated post the host controller initialization. The USB 3.0 DRD PHY on Exynos5420/5800 systems is one such PHY which needs to calibrated post xhci's reset at initialization time and at resume time, to get the controller work at SuperSpeed. Signed-off-by: Vive

[PATCH 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-06-06 Thread Vivek Gautam
Adding phy calibrate callback, which facilitates setting certain PHY settings post initialization of the PHY controller. Exynos5420 and Exynos5800 have 28nm USB 3.0 DRD PHY for which the Loss-of-Signal (LOS) Detector Threshold Level as well as Tx-Vboost-Level should be controlled for Super-Speed op

[PATCH v1 0/4] Fine tune USB 3.0 PHY on exynos5420

2014-06-06 Thread Vivek Gautam
The RFC version of this series was posted long time back, around December last year [1]. This series is based on Heikki's patches for simpliefied phy lookup table: [PATCHv2 0/6] phy: simplified phy lookup [2], applied against 'usb-next' branch of Greg's usb tree. Tested on peach-pit boards with Sup

Re: [PATCH 6/9] usb: chipidea: add Berlin USB support

2014-06-06 Thread Antoine Ténart
Sebastian, On Fri, Jun 06, 2014 at 12:55:54PM +0200, Sebastian Hesselbarth wrote: > On 06/05/2014 05:48 PM, Antoine Ténart wrote: > >+ > >+static const struct of_device_id ci_hdrc_berlin_of_match[] = { > >+{ .compatible = "marvell,berlin-usb" }, > > Looking at the driver, I can see no Berlin-

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-06 Thread Antoine Ténart
Sebastian, On Fri, Jun 06, 2014 at 12:54:06PM +0200, Sebastian Hesselbarth wrote: > On 06/05/2014 05:48 PM, Antoine Ténart wrote: > >+ > >+#include > >+#include > >+#include > >+#include > >+#include > >+#include > >+#include > > nit: keep above alphabetically sorted. Oops. Sure. > >+ >

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-06 Thread Vivek Gautam
Hi, On Fri, Jun 6, 2014 at 12:41 PM, Antoine Ténart wrote: > Hi, > > On Fri, Jun 06, 2014 at 12:09:06PM +0530, Vivek Gautam wrote: >> On Thu, Jun 5, 2014 at 9:18 PM, Antoine Ténart >> wrote: >> > Add the driver driving the Marvell Berlin USB PHY. This allows to >> > initialize the PHY and to use

Re: [PATCH 6/9] usb: chipidea: add Berlin USB support

2014-06-06 Thread Sebastian Hesselbarth
On 06/05/2014 05:48 PM, Antoine Ténart wrote: The Marvell Berlin USB controllers are compatible with ChipIdea. Add a driver using the ChipIdea common functions to support them. Signed-off-by: Antoine Ténart --- drivers/usb/chipidea/Makefile | 1 + drivers/usb/chipidea/ci_hdrc_berli

Re: [PATCH 1/2] usb: ohci-exynos: Use NULL instead of 0

2014-06-06 Thread Vivek Gautam
On Fri, Jun 6, 2014 at 2:13 PM, Sachin Kamat wrote: > The third argument of devm_of_phy_get expects a pointer. > Hence use NULL instead of 0. > > Signed-off-by: Sachin Kamat > --- > drivers/usb/host/ohci-exynos.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-06 Thread Sebastian Hesselbarth
On 06/05/2014 05:48 PM, Antoine Ténart wrote: Add the driver driving the Marvell Berlin USB PHY. This allows to initialize the PHY and to use it from the USB driver later. Signed-off-by: Antoine Ténart --- drivers/usb/phy/Kconfig | 9 ++ drivers/usb/phy/Makefile | 1 +

Re: [PATCH v2] leds: USB: Add support for MSI GT683R led panels

2014-06-06 Thread Johan Hovold
[ +CC: Jiri, linux-input, linux-usb (again) ] First of all, please reply to the original thread and make sure to not drop people or lists from CC. On Fri, Jun 06, 2014 at 12:29:06AM +0300, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exist in > MSI GT683R

[PATCHv2 3/5] usb: gadget: f_fs: add usb_functionfs_descs_head_v2 structure

2014-06-06 Thread Michal Nazarewicz
The structure can be used with user space tools that use the new functionfs description format, for example as follows: static const struct { struct usb_functionfs_descs_head_v2 header; __le32 fs_count; __le32 hs_count; struct { … } fs_desc;

[PATCHv2 2/5] tools: ffs-test: fix header values endianess

2014-06-06 Thread Michal Nazarewicz
It appears that no one ever run ffs-test on a big-endian machine, since it used cpu-endianess for fs_count and hs_count fields which should be in little-endian format. Fix by wrapping the numbers in cpu_to_le32. Cc: sta...@vger.kernel.org Signed-off-by: Michal Nazarewicz --- tools/usb/ffs-test.

[PATCHv2 5/5] tools: ffs-test: add compatibility code for old kernels

2014-06-06 Thread Michal Nazarewicz
If ffs-test is used with a kernel prior to 3.14, which do not support the new descriptors format, it will fail when trying to write the descriptors. Add a function that converts the new descriptors to the legacy ones and use it to retry writing the descriptors using the legacy format. Also add “-

[PATCHv2 4/5] tools: ffs-test: convert to new descriptor format

2014-06-06 Thread Michal Nazarewicz
Since commit [ac8dde11: “Add flags to descriptors block”] functionfs supports a new, more powerful and extensible, descriptor format. Since ffs-test is probably the first thing users of the functionfs interface see when they start writing functionfs user space daemons, convert it to use the new for

[PATCHv2 1/5] usb: gadget: f_fs: resurect usb_functionfs_descs_head structure

2014-06-06 Thread Michal Nazarewicz
Even though usb_functionfs_descs_head structure is now deprecated, it has been used by some user space tools. Its removel in commit [ac8dde1: “Add flags to descriptors block”] was an oversight leading to build breakage for such tools. Bring it back so that old user space tools can still be build

[PATCH 1/2] usb: ohci-exynos: Use NULL instead of 0

2014-06-06 Thread Sachin Kamat
The third argument of devm_of_phy_get expects a pointer. Hence use NULL instead of 0. Signed-off-by: Sachin Kamat --- drivers/usb/host/ohci-exynos.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 060a6a

[PATCH 2/2] usb: ehci-exynos: Use NULL instead of 0

2014-06-06 Thread Sachin Kamat
The third argument of devm_of_phy_get expects a pointer. Hence use NULL instead of 0. Fixes the following warning: drivers/usb/host/ehci-exynos.c:91:51: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat --- drivers/usb/host/ehci-exynos.c |2 +- 1 file changed, 1 inser

Re: [PATCH 07/10] xhci: Use command structures when queuing commands on the command ring

2014-06-06 Thread Mathias Nyman
On 06/06/2014 01:16 AM, Dan Williams wrote: > Hi Mathias, hit a small issue playing with -next: > > On Thu, May 8, 2014 at 9:26 AM, Mathias Nyman > wrote: >> To create a global command queue we require that each command put on the >> command ring is submitted with a command structure. >> >> Funct

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-06 Thread Antoine Ténart
Hi, On Fri, Jun 06, 2014 at 12:09:06PM +0530, Vivek Gautam wrote: > On Thu, Jun 5, 2014 at 9:18 PM, Antoine Ténart > wrote: > > Add the driver driving the Marvell Berlin USB PHY. This allows to > > initialize the PHY and to use it from the USB driver later. > > Just out of curiosity, going forwa