Re: [PATCH] USB: cdc-acm: fix broken runtime suspend

2014-05-24 Thread Johan Hovold
On Sat, May 24, 2014 at 12:59:07PM -0700, Greg Kroah-Hartman wrote: > On Sat, May 24, 2014 at 04:42:42PM +0200, Johan Hovold wrote: > > Could you please discard this one for now? I've found a couple of more > > PM related problems and I'll submit a slight update of this one as part > > of a larger

[PATCH] [usb] Fixed a few typos

2014-05-24 Thread Mickael Maison
Signed-off-by: Mickael Maison --- drivers/usb/gadget/mv_udc_core.c | 4 ++-- drivers/usb/gadget/s3c-hsotg.c | 2 +- drivers/usb/usb-common.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c index f

Re: [PATCH] USB: cdc-acm: fix broken runtime suspend

2014-05-24 Thread Greg Kroah-Hartman
On Sat, May 24, 2014 at 04:42:42PM +0200, Johan Hovold wrote: > On Mon, Apr 14, 2014 at 09:58:12PM +0200, Johan Hovold wrote: > > The current ACM runtime-suspend implementation is broken in several > > ways: > > > > Firstly, it buffers only the first write request being made while > > suspended --

Re: [PATCH] [usb] Fixed a few typos

2014-05-24 Thread Greg KH
On Sat, May 24, 2014 at 04:44:22PM +0200, Mickael Maison wrote: > --- > drivers/usb/gadget/mv_udc_core.c | 4 ++-- > drivers/usb/gadget/s3c-hsotg.c | 2 +- > drivers/usb/usb-common.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) Always run your patches through scripts/chec

Re: ehci-hcd.c causes: irq : nobody cared

2014-05-24 Thread Dr. Werner Fink
On Sat, May 24, 2014 at 11:18:31AM -0400, Alan Stern wrote: > On Sat, 24 May 2014, Dr. Werner Fink wrote: > > > > > During debugging and rebooting I've seen the problem again: > > What patch were you using when you saw the problem again? The attached one (as it does not help I've attached it;)

[PATCH v3 4/4] libusbg: Do not dereference usb config attributes when they are NULL. CID#56126

2014-05-24 Thread philippedeswert
From: Philippe De Swert We probably need to check if we get valid attributes passed. Otherwise we will try to dereference a NULL-pointer as the usb_config_attr will not be valid. Signed-off-by: Philippe De Swert --- src/usbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v3 3/4] libusbg: Do not try to dereference func when it is NULL. CID#56127

2014-05-24 Thread philippedeswert
From: Philippe De Swert We check if func is NULL, so if the allocation function failed we should not dereference or handle it anymore, so we jump straight to the end. Signed-off-by: Philippe De Swert --- src/usbg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/usbg.c b/src/usbg.c ind

[PATCH v3 2/4] libusbg: Fix buffer overrun issue. CID#56128

2014-05-24 Thread philippedeswert
From: Philippe De Swert Avoid calling usbg_read_string() with a 40 byte long buffer, which in turn is filled in by usbg_read_buf() which uses a maximum of 256 bytes (USBG_MAX_STR_LENGTH). This adjusts the buffer to be the right size. Signed-off-by: Philippe De Swert --- src/usbg.c | 2 +- 1

[PATCH v3 1/4] libusbg: Fix readlink/buffer overrun issue. CID#56130, CID#56129

2014-05-24 Thread philippedeswert
From: Philippe De Swert Readlink() can return the total length of the buffer (here 4096/USBG_MAX_PATH_LENGTH), so we do not want to dereference target[4096] as that would give an off by one error. Signed-off-by: Philippe De Swert --- src/usbg.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH v3 0/4] libusbg: Fix potential issues found with coverity

2014-05-24 Thread philippedeswert
From: Philippe De Swert This patch series fixes a number of issues found with coverity in libusbg A pull request has also be made: https://github.com/libusbg/libusbg/pull/4 This is the third revision with all comments corrected. Philippe De Swert (4): libusbg: Fix readlink/buffer overrun issu

Re: ehci-hcd.c causes: irq : nobody cared

2014-05-24 Thread Alan Stern
On Sat, 24 May 2014, Dr. Werner Fink wrote: > On Wed, May 14, 2014 at 10:32:21AM -0400, Alan Stern wrote: > > On Tue, 13 May 2014, Dr. Werner Fink wrote: > > > > > On Tue, May 13, 2014 at 06:10:46PM +0200, Dr. Werner Fink wrote: > > > > On Tue, May 13, 2014 at 11:59:38AM -0400, Alan Stern wrote:

Re: debug info for scheduling

2014-05-24 Thread Alan Stern
On Sat, 24 May 2014, vichy wrote: > hi Alan: > > 2014-05-23 22:34 GMT+08:00 Alan Stern : > > On Fri, 23 May 2014, vichy wrote: > > > >> hi all: > >> Sorry for not making my description more clearer. > >> in ehci controller, > >> 1. is it possible to know the period bandwidth in a frame from sys

Re: [PATCH RESEND v4 0/8] Add Allwinner A31 USB support

2014-05-24 Thread Maxime Ripard
On Sat, May 24, 2014 at 07:19:40AM +0900, Greg Kroah-Hartman wrote: > On Fri, May 23, 2014 at 08:33:39PM +0200, Maxime Ripard wrote: > > Hi Greg, > > > > On Wed, May 14, 2014 at 06:05:20PM +0200, Greg Kroah-Hartman wrote: > > > On Wed, May 14, 2014 at 02:34:19PM +0200, Maxime Ripard wrote: > > > >

[PATCH] [usb] Fixed a few typos

2014-05-24 Thread Mickael Maison
--- drivers/usb/gadget/mv_udc_core.c | 4 ++-- drivers/usb/gadget/s3c-hsotg.c | 2 +- drivers/usb/usb-common.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c index fcff3a5..040fb16 100644 --- a/dr

Re: [PATCH] USB: cdc-acm: fix broken runtime suspend

2014-05-24 Thread Johan Hovold
On Mon, Apr 14, 2014 at 09:58:12PM +0200, Johan Hovold wrote: > The current ACM runtime-suspend implementation is broken in several > ways: > > Firstly, it buffers only the first write request being made while > suspended -- any further writes are silently dropped. > > Secondly, writes being drop

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-24 Thread Dan Williams
On Fri, May 23, 2014 at 11:39 PM, Holger Hans Peter Freyther wrote: > On Tue, May 20, 2014 at 03:40:16PM -0700, Dan Williams wrote: > > Dear Dan, > >> Sorry, I don't think it is fair to users to force them to re-compile >> their kernel to get their device to work. Granted, I'm new to USB >> devel

Re: ehci-hcd.c causes: irq : nobody cared

2014-05-24 Thread Dr. Werner Fink
On Wed, May 14, 2014 at 10:32:21AM -0400, Alan Stern wrote: > On Tue, 13 May 2014, Dr. Werner Fink wrote: > > > On Tue, May 13, 2014 at 06:10:46PM +0200, Dr. Werner Fink wrote: > > > On Tue, May 13, 2014 at 11:59:38AM -0400, Alan Stern wrote: > > > > > > > > What about something like this instead

[PATCH V3] USB: Add LVS Test device driver

2014-05-24 Thread Pratyush Anand
OTG3 and EH Compliance Plan 1.0 talks about Super Speed OTG Verification system (SS-OVS) which consists of an excersizer and analyzer. USB Compliance Suite from Lecroy or Ellisys can act as such SS-OVS for Link Layer Validation (LVS). Some modifications are needed for an embedded Linux USB host t

Re: [PATCH v2 4/6] usb: musb: fix bit masks for CSR in musb_h_tx_flush_fifo()

2014-05-24 Thread Daniel Mack
On 05/23/2014 11:15 PM, Sergei Shtylyov wrote: > On 05/23/2014 04:57 PM, Daniel Mack wrote: >> I I'd say it's not supposed to. I just wanted the bit to be 0 when >> writing back the CSR. > >You failed to achieve that since you forgot ~; you're clearing all bits > but > this one. Ouch, total