On Tue, Mar 18, 2014 at 6:09 PM, Julius Werner wrote:
> I think a better place for this would be in usbnet_probe() (together
> with all the other dev->xxx initialization).
Definitely better.
@@ -1536,6 +1536,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb
dev->driver_name
> I tried adding the following change on top of your patch but believe
> the plumbing still isn't quite correct since the USB device (eth0) is
> reporting a link but no TX or RX of traffic:
> @@ -805,6 +807,9 @@ int usbnet_open (struct net_device *net)
> goto done;
> }
>
>
Fix the following checkpatch.pl issues in wl_netdev.c:
ERROR: do not use C99 // comments
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 150
1 file changed, 75 insertions(+), 75 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_
Adjust multi-line comments to “net/” kernel coding style in wl_netdev.c.
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 351 ++--
1 file changed, 203 insertions(+), 148 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
b/dr
Fix the following checkpatch.pl issues in wl_netdev.c:
WARNING: suspect code indent for conditional statements
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 56
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/
Where possible, fix lines that exceed 80 characters in wl_netdev.c
WARNING: line over 80 characters
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 62 +++-
1 file changed, 38 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/wla
Fix the following checkpatch.pl issue in wl_netdev.c:
WARNING: space prohibited between function name and open parenthesis
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlags49_h2/wl_
Fix the following checkpatch.pl issue in wl_netdev.c:
ERROR: do not use assignment in if condition
Signed-off-by: Jelena Bjelja
---
Changes in v2:
Delete unnecessary line added in a previous version, noted
by Julia Lawall
drivers/staging/wlags49_h2/wl_netdev.c |3 ++-
1 fil
Fix the following checkpatch.pl issue in wl_netdev.c:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
b/drivers/staging/w
Fix the following checkpatch.pl issue in wl_netdev.c:
ERROR: spaces required around that '='
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
b/drivers/staging/wl
Fix the following checkpatch.pl issues in wl_netdev.c:
ERROR: else should follow close brace '}'
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_netdev.c
b/drive
Fix the following checkpatch.pl issues in wl_netdev.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/wlag
Fix the following checkpatch.pl issues in wl_netdev.c:
ERROR: Macros with multiple statements should be enclosed in a do -
while loop
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/sta
Fix the following checkpatch.pl issues in wl_netdev.c:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 35
1 file changed, 9 insertions(+), 26 deletions(-)
diff --git a/
Fix the following checkpatch.pl issues in wl_netdev.c:
ERROR: space required before the open parenthesis '('
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 170
1 file changed, 85 insertions(+), 85 deletions(-)
diff --git a/drivers/st
Fix the following checkpatch.pl issues in wl_netdev.c:
ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 628
1 file changed, 314 insertions(+), 314 deletions(-)
diff --git a/driver
Fix the following checkpatch.pl issues in wl_netdev.c:
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Jelena Bjelja
---
drivers/staging/wlags49_h2/wl_netdev.c | 628
1 file changed, 314 insertions(+), 314 deletions(-)
diff --git a/driv
This patchset fixes most of the checkpatch.pl issues in wl_netdev.c
Changes in v2:
* Delete unnecessary line added in a previous version (v1) of the patch:
staging: wlags49_h2: Do not use assignment in if condition
noted by Julia Lawall
* U
On Tue, Mar 18, 2014 at 1:51 PM, Grant Grundler wrote:
> On Mon, Mar 17, 2014 at 2:55 PM, Oliver Neukum wrote:
>> I am hping for the reporter of the original bug to test it.
>
> Oliver,
> on a haswell system running ChromeOS-3.8 kernel, this patch as-is
> resulted in a "Bad Spinlock Magic" error
On Mon, Mar 17, 2014 at 2:55 PM, Oliver Neukum wrote:
> I am hping for the reporter of the original bug to test it.
Oliver,
on a haswell system running ChromeOS-3.8 kernel, this patch as-is
resulted in a "Bad Spinlock Magic" error and subsequent pagefault.
I believe the sequence was:
usbnet_op
On Tue, Mar 18, 2014 at 10:11:20PM +0200, Valentina Manea wrote:
> After migrating userspace code to libudev, converting usbip-host
> to a device driver and various bug fixes and enhancements, USB/IP
> is fully functional and can be moved out of staging.
>
> This patch series moves it as following
Add functions which allow to remove strings in gadget
and configuration.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 16 +++
src/usbg.c | 56 +++
2 files changed, 72 insertions(+)
diff --git a/include/usbg/u
Add function which allow to remove USB function.
This functions also remove function from internal
library structures what means that after this
operation all pointers to removed function are invalid.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 10 ++
src/usbg.c
Removing gadget/config/function/binding functionality
has been added to API so add example of how to use it.
Signed-off-by: Krzysztof Opasiak
---
examples/Makefile.am |3 +-
examples/gadget-vid-pid-remove.c | 113 ++
include/usbg/usbg.h
Add function which allow to remove configuration.
This functions also remove binding from internal
library structures what means that after this
operation all pointers to removed config are invalid.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 10
src/usbg.c |
Add function which allow to remove USB gadget.
This functions also remove gadget from internal
library structures what means that after this
operation all pointers to removed gadget are invalid.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 10 ++
src/usbg.c | 5
Add function which allow to remove binding between function
and configuration. This functions also remove binding from
internal library structures wht means that after this
operation all pointers to removed binding are invalid.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 10
Dear Matt,
In this series of patch I have added remove gadget, config, function,
binding functionality which was missing since introduction of library.
I have also added remove strings functionality which allow to remove
gadget and configuration strings in given language.
To show how to use new
Variable target is a place for path to USB function
so it should have size USBG_MAX_PATH_LENGTH not
USBG_MAX_STR_LENGTH size.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/usbg.c b/src/usbg.c
index f655675..33dbd92 1006
Path length should not be placed in constant size buffer
but in allocated memory.
Signed-off-by: Krzysztof Opasiak
---
configure.ac |1 +
src/usbg.c | 16
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 45449e2..878c2ab 1
Path and name length should not be placed in constant
size buffer but in allocated memory.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 61
1 file changed, 37 insertions(+), 24 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
Path and name length should not be placed in constant
size buffer but in allocated memory.
Use PATH_MAX macro from limits.h as default size for
USBG_MAX_PATH_LENGTH.
Handle overflows of snprintf in related funcitons.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h |4 ++-
src/usbg
Usage of sprintf() may be dangerous in some cases
so use snprintf() to avoid writing after allocated
memory.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 177 +++-
1 file changed, 115 insertions(+), 62 deletions(-)
diff --git a/src/u
Path and name length should not be placed in constant
size buffer but in allocated memory.
Handle overflows of snprintf in related funcitons.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 90
1 file changed, 66 insertions(+), 24
Path and name length should not be placed in constant
size buffer but in allocated memory.
Handle overflows of snprintf in related funcitons.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 169
1 file changed, 114 insertions(+), 5
Dear Matt,
due to recent discussion at linux-usb mailing list [1] about usage
of sprintf in libusbg I took up the task to fix this issue.
I have removed fixed size tabs in library structures reserved for
name and path and replaced the with dynamically alocated strings.
I have also replaced sprin
On Tue, 2014-03-18 at 22:11 +0200, Valentina Manea wrote:
> After migrating userspace code to libudev, converting usbip-host
> to a device driver and various bug fixes and enhancements, USB/IP
> is fully functional and can be moved out of staging.
>
> This patch series moves it as following:
> * u
After migrating userspace code to libudev, converting usbip-host
to a device driver and various bug fixes and enhancements, USB/IP
is fully functional and can be moved out of staging.
This patch series moves it as following:
* userspace code to tools/usb/usbip
* kernel code to drivers/usb/usbip
B
This was used back when usbip-host was an interface device driver;
after the conversion to device driver, the table remained unused.
Remove it in order to stop receiving a warning about it.
Signed-off-by: Valentina Manea
---
drivers/usb/usbip/stub_dev.c | 27 ---
1 file c
Hi,
> -Original Message-
> From: David Laight [mailto:david.lai...@aculab.com]
> Sent: Thursday, March 13, 2014 5:29 PM
> To: Krzysztof Opasiak; mpor...@linaro.org; linux-
> u...@vger.kernel.org
> Cc: Andrzej Pietrasiewicz; Karol Lewandowski; Stanislaw Wadas;
> ty317@samsung.com; Marek
From: Bjørn Mork
Date: Mon, 17 Mar 2014 16:25:18 +0100
> This is a context modified revert of commit 6a9612e2cb22
> ("net: cdc_ncm: remove ncm_parm field") which introduced
> a NCM specification violation, causing setup errors for
> some devices. These errors resulted in the device and
> host dis
Hello Rob,
On Mon, Feb-17-2014 at 01:45:52 AM +0100, Apelete Seketeli wrote:
> Document the process of writing an musb glue layer by taking the
> Ingenic JZ4740 glue layer as an example, as it seems more simple than
> most glue layers due to the basic feature set of the JZ4740 USB device
> control
On Mon, Mar 17, 2014 at 11:38:06PM +0100, Jelena Bjelja wrote:
> This patchset resolves most of checkpatch.pl issues in
> wlags49_h2/wl_netdev.c
>
> Jelena Bjelja (16):
> staging: wlags49_h2: Use tabs for indentation
> staging: wlags49_h2: Delete space after open parenthesis
> staging: wlags
Hi,
On 03/18/2014 03:39 PM, Alan Stern wrote:
> The USB_QUIRK_RESET flag indicates that a USB device changes its
> identity in some way when it is reset. It may lose its firmware, its
> descriptors may change, or it may switch back to a default mode of
> operation.
>
> If a device does this, the
On Tue, 18 Mar 2014, Peter Münster wrote:
> Hi,
>
> Commit 0aa2832dd0d9d8609fd8f15139bc7572541a1215 introduces a problem for
> my system:
You should include the name of the commit along with the hash ID;
otherwise nobody will know what it is unless they go to the trouble of
looking it up for t
On Mon, Mar 10, 2014 at 9:52 PM, Emmanuel Grumbach wrote:
> On Mon, Mar 10, 2014 at 3:20 PM, Shuduo Sang wrote:
>> On Mon, Mar 10, 2014 at 6:50 PM, Emmanuel Grumbach
>> wrote:
>>> Hi,
>>>
>>> On Mon, Mar 10, 2014 at 7:05 AM, Shuduo Sang
>>> wrote:
Hi,
>>>
Hi,
On Tue, Mar 18, 2014 at 09:04:40PM +0900, Chanwoo Choi wrote:
> This patch move simply OF helper function to extcon core and change function
> name as following:
> - of_extcon_get_extcon_dev() -> extcon_get_edev_by_phandle()
>
> Signed-off-by: Chanwoo Choi
> ---
> drivers/extcon/Kconfig
On Tue, 18 Mar 2014, Andreas Reis wrote:
> [9732.160783] usb-storage 2-1:1.0: Abort srbs: 8804255c1980
> 8804255c1980
> [9732.160791] usb-storage 2-1:1.0: Calling stop_transport
> [9732.160836] usb-storage 2-1:1.0: Starting port reset
> [9732.267771] usb 2-1: reset SuperSpeed USB device n
Hi Tony,
On 03/13/2014 11:44 PM, Paul Walmsley wrote:
> On Wed, 12 Mar 2014, Tony Lindgren wrote:
>
>> * Roger Quadros [140307 02:18]:
>>> From: Keshava Munegowda
>>>
>>> Create hwmods for ocp2scp3 and sata modules.
>>
>> Paul, does this look OK to you?
>
> I didn't go over every entry with a
The USB_QUIRK_RESET flag indicates that a USB device changes its
identity in some way when it is reset. It may lose its firmware, its
descriptors may change, or it may switch back to a default mode of
operation.
If a device does this, the kernel needs to avoid resetting it. Resets
are likely to
This patch remove unnecessary function call in of_extcon_get_extcon_dev()
by using the name of device_node structure.
Signed-off-by: Chanwoo Choi
---
drivers/extcon/of_extcon.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/extcon/of_extcon.c b/drivers/
This patch move simply OF helper function to extcon core and change function
name as following:
- of_extcon_get_extcon_dev() -> extcon_get_edev_by_phandle()
Signed-off-by: Chanwoo Choi
---
drivers/extcon/Kconfig | 4 ---
drivers/extcon/Makefile | 2 --
drivers/extcon/extcon-
Thisp patchset remove unnecessary function call in of_extcon_get_extcon_dev()
which get the extcon device from devicetree. Also, this patchset move OF helper
func
to extcon core and change function name as following:
- of_extcon_get_extcon_dev() -> extcon_get_edev_by_phandle()
Chanwoo Choi (2):
Hi,
Commit 0aa2832dd0d9d8609fd8f15139bc7572541a1215 introduces a problem for
my system:
When it wakes up after s2ram, it freezes. Screen is black, keyboard
does not work, no ssh-connection. Just the network-ping works.
Please see here for more details, especially information about the
hardware: h
Am Montag, 17. März 2014, 16:25:18 schrieben Sie:
> This is a context modified revert of commit 6a9612e2cb22
> ("net: cdc_ncm: remove ncm_parm field") which introduced
> a NCM specification violation, causing setup errors for
> some devices. These errors resulted in the device and
> host disagreein
On Tue, 2014-03-18 at 10:29 +, David Laight wrote:
> From: Bjørn Mork
Hi,
> > To recall: The NCM and MBIM protocols aggregate packets before
> > transission over the USB link, requiring USB buffers with multiple
> > ethernet/IP packets. Common code used by both cdc_mbim and cdc_ncm
> > curre
From: Bjørn Mork
> Hello Oliver & other clueful gurus!
>
> I started looking at how to improve the OOM handling in usbnet, but have
> to admit that this is way over my head. I don't think I dare touching
> it...
>
> I've seen a few reports clearly showing that we do have a problem. One
> example
On Tue, Mar 18, 2014 at 09:10:10AM +0100, Johan Hovold wrote:
> On Mon, Mar 17, 2014 at 11:58:57PM -0700, Benjamin West wrote:
> > On Mon, Mar 17, 2014 at 11:40 AM, Johan Hovold wrote:
> > >> issues. It's included below
> > >> https://gist.github.com/bewest/6488955#file-lsusb
> >
> > > I'm respo
Hello Oliver & other clueful gurus!
I started looking at how to improve the OOM handling in usbnet, but have
to admit that this is way over my head. I don't think I dare touching
it...
I've seen a few reports clearly showing that we do have a problem. One
example is here:
http://forums.whirlpool
Ben Chan writes:
> This patch adds the MBIM extended functional descriptor structure
> defined in "Universal Serial Bus Communications Class Subclass
> Specification for Mobile Broadband Interface Model, Revision 1.0,
> Errata-1" published by USB-IF.
>
> Signed-off-by: Ben Chan
> ---
> No change
Ben Chan writes:
> According to "Universal Serial Bus Communications Class Subclass
> Specification for Mobile Broadband Interface Model, Revision 1.0,
> Errata-1" published by USB-IF, the wMTU field of the MBIM extended
> functional descriptor indicates the operator preferred MTU for IP data
> s
On Mon, Mar 17, 2014 at 11:58:57PM -0700, Benjamin West wrote:
> On Mon, Mar 17, 2014 at 11:40 AM, Johan Hovold wrote:
> >> issues. It's included below
> >> https://gist.github.com/bewest/6488955#file-lsusb
>
> > I'm responding to this mail with a patch for you to test. The patch is
> > also ava
On Tue, Mar 18, 2014 at 12:59:05PM +0800, Li Jun wrote:
> From: Li Jun
>
> This patchset has some improvements for interfaces of read and write some
> controller registers.
>
> Change for v4:
> Use one write for BSV irq status clear and enable in
> udc_id_switch_for_device().
>
> Changes for v
On Tue, Mar 18, 2014 at 10:36:17AM +0800, Peter Chen wrote:
> On Mon, Mar 17, 2014 at 01:43:05PM +0800, Li Jun wrote:
> > On Wed, Mar 12, 2014 at 04:21:28PM +0800, Peter Chen wrote:
> > > On Wed, Mar 12, 2014 at 03:12:48PM +0800, Li Jun wrote:
> > > > On Wed, Mar 12, 2014 at 03:01:15PM +0800, Peter
64 matches
Mail list logo
