On Wed, Mar 05, 2014 at 04:28:14PM +0800, Peter Chen wrote:
> On Thu, Feb 27, 2014 at 07:38:25AM +0800, Li Jun wrote:
> > Add OTG HNP and SRP operation functions implementation:
> > - charge vbus
> > - drive vbus
> > - connection signaling
> > - drive sof
> > - start data pulse
> > - add fsm timer
On Wed, Mar 5, 2014 at 10:14 PM, Valentina Manea
wrote:
> On Tue, Mar 4, 2014 at 9:20 PM, Greg KH wrote:
>> On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote:
>>> -AC_INIT([usbip-utils], [1.1.1], [linux-usb@vger.kernel.org])
>>> +AC_INIT([usbip-utils], [2.0], [linux-usb@vger.kernel.
The rtl8152_get_stats() returns the point address of the struct
net_device_stats. This could be got from struct net_device directly.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 21 ++---
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/drivers/net/usb/r8
Add or remove some empty lines. Replace the spaces with the tabs.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 0654bd3..c8bad62 100644
--- a/drivers/net/u
Replace some tp->netdev with netdev.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index c8bad62..151398b 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/u
Deal with some empty lines and spaces, replace some tp->netdev with netdev,
and remove the unnecessary function.
Hayes Wang (3):
r8152: deal with the empty line and space
r8152: replace tp->netdev with netdev
r8152: remove rtl8152_get_stats
drivers/net/usb/r8152.c | 36
On 05/03/14 11:17 PM, Robert Hancock wrote:
I have a USB 3.0 multi-card reader device:
Bus 004 Device 002: ID 05e3:0743 Genesys Logic, Inc.
which seems to work fine in 3.13.4 (Fedora version kernel-3.13.4-200
specifically) but fails in 3.13.5 (specifically kernel-3.13.5-202).
Below is what I ge
On Tue, Mar 4, 2014 at 9:20 PM, Greg KH wrote:
> On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote:
>> Signed-off-by: Valentina Manea
>> ---
>> drivers/staging/usbip/userspace/configure.ac | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/u
On Wed, Mar 5, 2014 at 12:15 PM, Dan Carpenter wrote:
> On Wed, Mar 05, 2014 at 12:42:59PM +0300, Dan Carpenter wrote:
>> On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote:
>> > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.h
>> > b/drivers/staging/usbip/userspace
A device should not be able to be used concurrently both by
the server and the client. Claiming the port used by the
shared device ensures no interface drivers bind to it and
that it is not usable from the server.
Signed-off-by: Valentina Manea
---
Changes since v1:
* add commit description
* mov
>
> Hi Peter,
>
> Thanks for your reply.
>
> I can use pm_runtime_get in interrupt handler, but i am not getting your
> idea of using pm_runtime_put in interrupt handler?
>
After your device finishes using usb, it may need to toggle gpio to trigger
interrupt, and you can suspend usb at thi
Hi Peter,
Thanks for your reply.
I can use pm_runtime_get in interrupt handler, but i am not getting
your idea of using pm_runtime_put in interrupt handler?
My device is usb telephony modem, which will give interrupt through
gpio when call comes. so at that time i want to wakeup the usb
function
On Thu, Feb 27, 2014 at 07:38:31AM +0800, Li Jun wrote:
> This patch adds sysfs interface description for chipidea USB OTG role switch
> in HNP.
>
> Signed-off-by: Li Jun
> ---
> .../ABI/testing/sysfs-platform-chipidea-usb-otg| 55
>
> 1 file changed, 55 insertions(+)
On Thu, Feb 27, 2014 at 07:38:30AM +0800, Li Jun wrote:
> This patch adds below registers dump for debug:
> - USBINTR
> - USBSTS
> - USBMODE
> - USBCMD
> - PORTSC
> - OTGSC
>
> Signed-off-by: Li Jun
> ---
> drivers/usb/chipidea/debug.c | 48
> ++
> 1 fi
On Thu, Feb 27, 2014 at 07:38:28AM +0800, Li Jun wrote:
> This patch adds sys input to control and show OTG fsm inputs by application,
> user can do host and preipheral role switch by change these inputs.
>
> Signed-off-by: Li Jun
> ---
> drivers/usb/chipidea/otg.c |1 +
> drivers/usb/ch
On Thu, Feb 27, 2014 at 07:38:27AM +0800, Li Jun wrote:
> USB OTG interrupt handling and fsm transition according to USB OTG
> and EH 2.0, update otg timer timeout handlers.
>
> Signed-off-by: Li Jun
> ---
> drivers/usb/chipidea/core.c| 10 ++-
> drivers/usb/chipidea/otg.c |9 +-
>
On Thu, Feb 27, 2014 at 07:38:26AM +0800, Li Jun wrote:
> This patch adds OTG fsm timers initialization, which use controller's 1ms
> interrupt as timeout counter, also adds some local timers which are not
> in otg_fsm_timer list.
>
> Signed-off-by: Li Jun
> ---
> drivers/usb/chipidea/bits.h
I have a USB 3.0 multi-card reader device:
Bus 004 Device 002: ID 05e3:0743 Genesys Logic, Inc.
which seems to work fine in 3.13.4 (Fedora version kernel-3.13.4-200
specifically) but fails in 3.13.5 (specifically kernel-3.13.5-202).
Below is what I get in dmesg. Essentially there's a bunch of
From: Hayes Wang
Date: Wed, 5 Mar 2014 14:49:27 +0800
> Add additional parameter for non x86 platform for better throughput.
>
> Signed-off-by: Hayes Wang
This commit message tells me absolutely nothing.
First of all, it doesn't say what the issue is, why is the chip
slower on non-x86 platfor
Hi Alan,
Thanks for you informative reply.
I will try your suggestion. yes, i will not get more than one wakeup per second.
I have tried below things.
My usb device is using the cdc-acm.c driver.
inside cdc-acm.c file,
static struct usb_device *usb_device;
static int acm_probe(, )
>
> > Hi,
> > There is some inconsistency in remote wakeup functionality in my
> > custom board. so I want to wakeup the runtime suspended USB host
> > through interrupt. My USB device is connected to the board through USB
> > interface and some gpios. device will give interrupt on processor gpi
> Here are my changes:
>
> diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-
> pdk.dts index 7a6d21f..fc91592 100644
> --- a/arch/arm/boot/dts/imx25-pdk.dts
> +++ b/arch/arm/boot/dts/imx25-pdk.dts
> @@ -107,3 +107,8 @@
> fsl,uart-has-rtscts;
> status = "okay
WARNING: CPU: 3 PID: 25477 at lib/dma-debug.c:593
debug_dma_assert_idle+0x1ba/0x223()
uhci_hcd :00:1d.2: DMA-API: cpu touching an active dma mapped cacheline
[cln=0x02355f80]
Modules linked in: fuse tun l2tp_ppp l2tp_netlink l2tp_core can_raw can_bcm
scsi_transport_iscsi nfc caif_soc
On Wed, Mar 05, 2014 at 11:26:06AM -0500, Alan Stern wrote:
> On Wed, 5 Mar 2014, Poulain, Loic wrote:
>
> > + function 'do_rebind_interface' is in charge of unbind and rebind the
> > interfaces with the 'need_binfind' flag set.
> > + However this method is only called in 'usb_resume_complete'.
>
Hi Peter,
On Wed, Mar 5, 2014 at 10:33 PM, Peter Chen wrote:
> The nop phy driver is at: drivers/usb/phy/phy-generic.c
> The compatible string is: "usb-nop-xceiv"
This is not enough.
Here are my changes:
diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-pdk.dts
index 7a6d
> Hi,
>
> Has anyone succeeded on getting USB host support on mx25 with the
> chipidea driver?
>
> I am trying to add USB host1 support for mx25pdk and I am starting to
> debug it, but
>
>
> Looking at imx25.dtsi we have:
>
> usbphy1: usbphy@1 {
> compatible = "n
On Wed, 2014-03-05 at 16:44 -0500, Alan Stern wrote:
> On Wed, 5 Mar 2014, Dan Williams wrote:
>
> > 8<
> > Subject: usb: find internal hub tier mismatch via acpi
> >
> > From: Dan Williams
> >
> > ACPI identifies peer ports by setting their 'group_token' and
> > 'group_position' _P
On Mon, Mar 3, 2014 at 1:25 PM, Daniel Mack wrote:
> From: Alan Stern
>
> Evidently some wacky USB-ATA bridges don't recognize the SYNCHRONIZE
> CACHE command, as shown in this email thread:
>
> http://marc.info/?t=13897835622&r=1&w=2
>
> The fact that we can't tell them to drain thei
Hello Kamil,
this looks very good. I just tested the patchset on my ODROID-X2
(Exynos4412-based board) and the USB stability issues I mentioned to you
before (with the older patchset) seem to be gone.
All devices on the USB behave normally (mass storage, ethernet and
bluetooth).
With best wishe
I recently bought one of these and have video but no audio.
# lsmod | grep cx231
cx231xx_alsa7824 0
cx231xx 143824 1 cx231xx_alsa
cx2341x16463 1 cx231xx
v4l2_common 3850 3 cx2341x,cx231xx,cx25840
videobuf_vmalloc3975 1 cx231xx
v
On Wed, 5 Mar 2014, Dan Williams wrote:
> 8<-
> Subject: usb: sysfs link peer ports
>
> From: Dan Williams
>
> The usb topology after this change will have symlinks between usb3 ports
> and their usb2 peers, for example:
>
> usb2/2-1/2-1:1.0/2-1-port1/peer => ../../../../usb3/3-1/3-1:1
On Wed, 5 Mar 2014, Dan Williams wrote:
> 8<
> Subject: usb: find internal hub tier mismatch via acpi
>
> From: Dan Williams
>
> ACPI identifies peer ports by setting their 'group_token' and
> 'group_position' _PLD data to the same value. If a platform has tier
> mismatch [1] , ACP
From: Dinh Nguyen
The dwc2 IP on the SOCFPGA cannot use the default HW configured
FIFO sizes. The total FIFO depth as read from GHWCFG3 reports 0x1f80 or 8064
32-bit words. But the GRXFSIZ, GNPTXFSIZ, and HPTXFSIZ register defaults
to 0x2000 or 8192 32-bit words. So the driver cannot just use the
From: Dinh Nguyen
The dwc2 IP on the SOCFPGA cannot use the default HW configured
FIFO sizes. The total FIFO depth as read from GHWCFG3 reports 0x1f80 or 8064
32-bit words. But the GRXFSIZ, GNPTXFSIZ, and HPTXFSIZ register defaults
to 0x2000 or 8192 32-bit words. So the driver cannot just use the
Hi,
Has anyone succeeded on getting USB host support on mx25 with the
chipidea driver?
I am trying to add USB host1 support for mx25pdk and I am starting to
debug it, but
Looking at imx25.dtsi we have:
usbphy1: usbphy@1 {
compatible = "nop-usbphy";
s
On Wed, Mar 5, 2014 at 12:18 PM, Alan Stern wrote:
> On Wed, 5 Mar 2014, Dan Williams wrote:
>
>> Please have a look at the following. I'm sure Greg will be happy that
>> we are killing these bugs before they become fodder for -stable. Thanks
>
> Wow, do you really think all these changes will e
On Wed, 5 Mar 2014, Dan Williams wrote:
> 8<---
> Subject: usb: assign usb3 external hub port peers
>
> From: Dan Williams
>
> Given that root hub port peers are already established, external hub peer
> ports can be determined by traversing the device topology:
>
> 1/ ascend to the parent
On Wed, 5 Mar 2014, Dan Williams wrote:
> Please have a look at the following. I'm sure Greg will be happy that
> we are killing these bugs before they become fodder for -stable. Thanks
Wow, do you really think all these changes will ever go into -stable?
I'm doubtful; they're rather large.
On Mon, 2014-03-03 at 18:42 -0800, Dan Williams wrote:
> On Fri, 2014-02-28 at 15:18 -0800, Dan Williams wrote:
> > ClearPortFeature(PORT_POWER) on a usb3 port places the port in either a
> > DSPORT.Powered-off-detect / DSPORT.Powered-off-reset loop, or the
> > DSPORT.Powered-off state. There is n
On Mon, 2014-03-03 at 18:39 -0800, Dan Williams wrote:
> On Fri, 2014-02-28 at 15:18 -0800, Dan Williams wrote:
> > The usb topology after this change will have symlinks between usb3 ports
> > and their usb2 peers, for example:
> >
> > usb2/2-1/2-1:1.0/2-1-port1/peer => ../../../../usb3/3-1/3-1:1.
On Tue, 2014-03-04 at 11:33 -0500, Alan Stern wrote:
> > static struct usb_port *find_default_peer(struct usb_hub *hub, int port1)
> > {
> > + struct usb_port *port_dev = hub->ports[port1 - 1];
> > struct usb_device *hdev = hub->hdev;
> > struct usb_device *peer_hdev = NULL;
> > str
* Kishon Vijay Abraham I [140305 04:46]:
> Tony/Benoit,
>
> On Monday 03 March 2014 05:08 PM, Kishon Vijay Abraham I wrote:
> >Added device tree bindings for dwc3, usb2 and usb3 PHYs. The documentation
> >of these can be found at
> >Documentation/devicetree/bindings/phy/phy-bindings.txt
> >and D
On Mon, 2014-03-03 at 18:33 -0800, Dan Williams wrote:
> Subject: usb: assign usb3 external hub port peers
>
> From: Dan Williams
>
> Given that root hub port peers are already established, external hub peer
> ports can be determined by traversing the device topology:
>
> 1/ ascend to the paren
On Tue, 2014-03-04 at 10:58 -0500, Alan Stern wrote:
> On Mon, 3 Mar 2014, Dan Williams wrote:
>
> > Ok, so the root issue is that the peering code needs to see
> > hcd->primary_hcd = NULL to know that there is no longer a peer. I
> > update usb_remove_hcd() to clear out ->shared_hcd and ->primar
On Wed, Mar 05, 2014 at 09:45:22AM -0600, Felipe Balbi wrote:
> On Mon, Mar 03, 2014 at 04:52:27PM -0600, Felipe Balbi wrote:
> > On Mon, Mar 03, 2014 at 02:46:32PM -0800, Greg KH wrote:
> > > On Mon, Mar 03, 2014 at 11:04:02AM -0600, Felipe Balbi wrote:
> > > > during the conversion to a new metho
Hello.
On 03/05/2014 05:14 PM, Krzysztof Opasiak wrote:
usbg_parse_bindings() function has done parsing incorrectly
and in inefficent way. Changes made in this function provide
better performance and fix wrong linking issue when having
two instances of the same function.
Signed-off-by: Krzys
On Wed, Mar 05, 2014 at 01:11:15PM +0100, Christian Riesch wrote:
> Signed-off-by: Christian Riesch
> Cc: Felipe Balbi
> ---
> Hi,
>
> I have successfully tested this driver with kernel 3.14-rc5 on a custom
> Texas Instruments AM1808 board in gadget mode, RNDIS network gadget.
> Therefore I thin
* Roger Quadros [140305 04:26]:
> + George
>
> Tony,
>
> On 03/04/2014 06:28 PM, Tony Lindgren wrote:
> > * Roger Quadros [140304 01:17]:
> >> Hi Tony,
> >>
> >> On 03/03/2014 09:02 PM, Tony Lindgren wrote:
> >>> * Roger Quadros [140303 07:10]:
> Move omap-control binding information to t
On Wed, 5 Mar 2014, Poulain, Loic wrote:
> + function 'do_rebind_interface' is in charge of unbind and rebind the
> interfaces with the 'need_binfind' flag set.
> + However this method is only called in 'usb_resume_complete'.
> + Problem is that 'usb_resume_complete' is a dev_pm_ops callback (cor
On Wed, 5 Mar 2014, Oliver Neukum wrote:
> On Wed, 2014-03-05 at 09:40 +, Poulain, Loic wrote:
> > Hi,
> >
> > I think there is an issue with the reset-resume mechanism during USB
> > runtime resume, leaving the interfaces suspended forever.
> >
> > - Context:
> >
> > Android platform, runn
On Wed, 5 Mar 2014, Jagdish Gedia wrote:
> Hi,
> There is some inconsistency in remote wakeup functionality in my
> custom board. so I want to wakeup the runtime suspended USB host
> through interrupt. My USB device is connected to the board through USB
> interface and some gpios. device will give
On 05.03.2014 16:28, Kamil Debski wrote:
Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic
PHY framework. The driver includes support for the Exynos 4x10 and 4x12
SoC families.
Signed-off-by: Kamil Debski
---
.../devicetree/bindings/phy/samsung-phy.txt| 53
On 05.03.2014 16:28, Kamil Debski wrote:
Adding devm_of_phy_get will allow to get phys by supplying a
pointer to the struct device_node instead of struct device.
Signed-off-by: Kamil Debski
---
drivers/phy/phy-core.c | 31 +++
include/linux/phy/phy.h |8 +++
On 05.03.2014 16:28, Kamil Debski wrote:
Previously the of_phy_get function took a struct device * and
was declared static. It was impossible to call it from
another driver and thus it was impossible to get phy defined
for a given node. The old function was renamed to _of_phy_get
and was left for
On Wed, Mar 05, 2014 at 04:47:31PM +0530, George Cherian wrote:
> On 2/26/2014 1:10 AM, Felipe Balbi wrote:
> >We must read HWPARAMS4 register to figure out
> >how many scratch buffers we should allocate.
> >
> >Later patch will use "Set Scratchpad Buffer
> >Array" command to pass the pointer to th
On Mon, Mar 03, 2014 at 04:52:27PM -0600, Felipe Balbi wrote:
> On Mon, Mar 03, 2014 at 02:46:32PM -0800, Greg KH wrote:
> > On Mon, Mar 03, 2014 at 11:04:02AM -0600, Felipe Balbi wrote:
> > > during the conversion to a new method of finding
> > > proper endpoints, we need to give our users a
> > >
Hi,
On Wed, Mar 05, 2014 at 12:08:08AM -0600, dingu...@altera.com wrote:
> From: Dinh Nguyen
>
> The dwc2 IP on the SOCFPGA cannot use the default HW configured
> FIFO sizes. The total FIFO depth as read from GHWCFG3 reports 0x1f80 or 8064
> 32-bit words. But the GRXFSIZ, GNPTXFSIZ, and HPTXFSIZ
Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic
PHY framework. The driver includes support for the Exynos 4x10 and 4x12
SoC families.
Signed-off-by: Kamil Debski
---
.../devicetree/bindings/phy/samsung-phy.txt| 53
Documentation/phy/samsung-usb2.txt
Adding devm_of_phy_get will allow to get phys by supplying a
pointer to the struct device_node instead of struct device.
Signed-off-by: Kamil Debski
---
drivers/phy/phy-core.c | 31 +++
include/linux/phy/phy.h |8
2 files changed, 39 insertions(+)
dif
Hi,
This is the ninth version of this patchset. First and most significant change
since v6 is that this patchset includes only patches touching the Generic PHY
Framework. Patches to the USB controllers were stripped as they require
additional work. S5PV210 support is also omitted - it requires mor
Add support for Exynos 5250. This driver is to replace the old
USB 2.0 PHY driver.
Signed-off-by: Kamil Debski
---
.../devicetree/bindings/phy/samsung-phy.txt|1 +
drivers/phy/Kconfig| 11 +
drivers/phy/Makefile |1 +
Previously the of_phy_get function took a struct device * and
was declared static. It was impossible to call it from
another driver and thus it was impossible to get phy defined
for a given node. The old function was renamed to _of_phy_get
and was left for internal use. of_phy_get function was adde
On 03/05/2014 04:47 PM, Kishon Vijay Abraham I wrote:
> Roger,
>
> On Wednesday 05 March 2014 08:13 PM, Roger Quadros wrote:
>> Hi Kishon,
>>
>> On 03/03/2014 01:38 PM, Kishon Vijay Abraham I wrote:
>>> Adapted dwc3 core to use the Generic PHY Framework. So for init, exit,
>>> power_on and power_o
On Tue, Mar 04, 2014 at 11:38:32PM +, Liu, Chuansheng wrote:
> Hi Balbi,
>
> > -Original Message-
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Wednesday, March 05, 2014 3:56 AM
> > To: Michal Nazarewicz
> > Cc: Robert Baldyga; Felipe Balbi; Sergei Shtylyov; Liu, Chuansheng;
>
On Wed, 2014-03-05 at 09:40 +, Poulain, Loic wrote:
> Hi,
>
> I think there is an issue with the reset-resume mechanism during USB
> runtime resume, leaving the interfaces suspended forever.
>
> - Context:
>
> Android platform, running a 3.13 + Google AOSP patches kernel.
> I'm facing a USB
Roger,
On Wednesday 05 March 2014 08:13 PM, Roger Quadros wrote:
Hi Kishon,
On 03/03/2014 01:38 PM, Kishon Vijay Abraham I wrote:
Adapted dwc3 core to use the Generic PHY Framework. So for init, exit,
power_on and power_off the following APIs are used phy_init(), phy_exit(),
phy_power_on() and
Hi Kishon,
On 03/03/2014 01:38 PM, Kishon Vijay Abraham I wrote:
> Adapted dwc3 core to use the Generic PHY Framework. So for init, exit,
> power_on and power_off the following APIs are used phy_init(), phy_exit(),
> phy_power_on() and phy_power_off().
>
> However using the old USB phy library wo
Hi,
On Wednesday 05 March 2014 07:48 PM, Kamil Debski wrote:
Add support for Exynos 5250. This driver is to replace the old
USB 2.0 PHY driver.
Pls fix this error too..
Applying: phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver
/home/kishon/repos/linux-phy/.git/rebase-apply/patch
Kamil,
On Wednesday 05 March 2014 07:48 PM, Kamil Debski wrote:
Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic
PHY framework. The driver includes support for the Exynos 4x10 and 4x12
SoC families.
Pls fix these errors which I get while applying your patch.
Applyi
Each usbg_set_*() may fail so it should have a return value
to notify user about reason of failure.
To be consistent with rest of API usbg_create_function()
should also return error code to notify user about reasons
of failure instead of binary information (NULL or not).
Signed-off-by: Krzysztof
Hi,
There is some inconsistency in remote wakeup functionality in my
custom board. so I want to wakeup the runtime suspended USB host
through interrupt. My USB device is connected to the board through USB
interface and some gpios. device will give interrupt on processor gpio
when it needs attention
Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic
PHY framework. The driver includes support for the Exynos 4x10 and 4x12
SoC families.
Signed-off-by: Kamil Debski
---
.../devicetree/bindings/phy/samsung-phy.txt| 53
Documentation/phy/samsung-usb2.txt
Each usbg_set_config_*() may fail so it should have
a return value to notify user about reason of failure.
To be consistent with rest of API usbg_create_config()
should also return error code to notify user about reasons
of failure instead of binary information (NULL or not).
Signed-off-by: Krzys
Previously the of_phy_get function took a struct device * and
was declared static. It was impossible to call it from
another driver and thus it was impossible to get phy defined
for a given node. The old function was renamed to _of_phy_get
and was left for internal use. of_phy_get function was adde
Add support for Exynos 5250. This driver is to replace the old
USB 2.0 PHY driver.
Signed-off-by: Kamil Debski
---
.../devicetree/bindings/phy/samsung-phy.txt|1 +
drivers/phy/Kconfig| 11 +
drivers/phy/Makefile |1 +
Adding devm_of_phy_get will allow to get phys by supplying a
pointer to the struct device_node instead of struct device.
Signed-off-by: Kamil Debski
---
drivers/phy/phy-core.c | 31 +++
include/linux/phy/phy.h |8
2 files changed, 39 insertions(+)
dif
Hi,
This is the eighth version of this patchset. First and most significant change
since v6 is that this patchset includes only patches touching the Generic PHY
Framework. Patches to the USB controllers were stripped as they require
additional work. S5PV210 support is also omitted - it requires mo
Examples provided with the library should use returned
error codes and provide information to user.
Remove todo baceuse it has been already done.
Signed-off-by: Krzysztof Opasiak
---
examples/gadget-acm-ecm.c | 51 +++--
examples/show-gadgets.c | 40
Change usbg_get_config_strs() and usbg_get_config_attrs()
to return usbg_error instead of NULL pointer.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h |9 -
src/usbg.c | 50 +-
2 files changed, 29 insertions(+), 30
usbg_get_function_attrs() may fail due to many reasons
so it should notify the user about exact reason of failure
instead of returning only NULL pointer.
Add also USBG_ERROR_NOT_SUPPORTED to usbg_set_function_attrs().
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h |5 ++--
src/usb
Change usbg_add_config_function() to return usbg_error
instead of returning 0 or -1.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h |2 +-
src/usbg.c | 14 --
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/include/usbg/usbg.h b/include/usbg/us
Add usbg_error_name() to get error name as a string.
Add usbg_strerror() to get brief error description in English.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 16 ++
src/usbg.c | 86 +++
2 files changed, 102 in
Change usbg_get_gadget_strs() and usbg_get_gadget_attrs()
to return usbg_error instead of NULL pointer.
Signed-off-by: Krzysztof Opasiak
Conflicts:
src/usbg.c
---
include/usbg/usbg.h | 10 --
src/usbg.c | 43 ++-
2 files chan
Enabling and disabling gadget may fail due to many reasons
so those functions should notify user about it.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 10 +---
src/usbg.c | 67 ++-
2 files changed, 57 insertions(+),
Setting each of attribute may fail due to a lot of reasons
so those functions should report this failure to a user.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 33 +---
src/usbg.c | 85 +--
2 files change
API should be consistent and use error codes to determine what
type of error occurred instead of returning NULL only.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 24 ++---
src/usbg.c | 60 ---
2 files cha
Functions related to gadget creation should return error codes
instead of pointer.
Signed-off-by: Krzysztof Opasiak
---
examples/gadget-acm-ecm.c |4 +-
include/usbg/usbg.h | 21 ++--
src/usbg.c| 258 +
3 files changed, 185
Surround each pointer in macro with parenthesis to avid
errors related to operator precedence.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
index 56588c0..d5c36c9 100644
--- a/src/us
Functions which provides user length of some internal
strings should return usbg_error instead of -1.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h | 12 ++--
src/usbg.c | 12 ++--
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/include/us
Assumption that all malloc() and read()/write() finish correctly
is too bold. Errors should be handled and propagated to upper
layers of library and returned to user.
Signed-off-by: Krzysztof Opasiak
Conflicts:
src/usbg.c
---
examples/gadget-acm-ecm.c |5 +-
examples/show-gadgets.c
usbg_parse_bindings() function has done parsing incorrectly
and in inefficent way. Changes made in this function provide
better performance and fix wrong linking issue when having
two instances of the same function.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 34 -
Function attributes may be changed by kernel or other
user so they should not be cached in library structures.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 31 +++
1 file changed, 11 insertions(+), 20 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
index 63b
Library should have internal API for freing structures instead of
copy pasting same code in different places.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 77 +++-
1 file changed, 50 insertions(+), 27 deletions(-)
diff --git a/src/u
Config attributes may be changed by kernel or other
user so they should not be cached in library structures.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
index 4a69b9c..e11f44e 100644
--- a
Config strings should not be cached in library.
Removing internal strings structure allowed to add
full support for multilingual strings.
Signed-off-by: Krzysztof Opasiak
---
examples/show-gadgets.c |2 +-
include/usbg/usbg.h |3 ++-
src/usbg.c | 31 ---
Gadget strings should not be cached in library.
Removing internal strings structure allowed to add
full support for multilingual strings.
Signed-off-by: Krzysztof Opasiak
---
examples/show-gadgets.c |2 +-
include/usbg/usbg.h |6 --
src/usbg.c | 48
Gadget attributes may be changed by kernel or other
user so they should not be cached in library structures.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
index 91165b8..ae26434 10064
Dear Matt,
I have prepared next series of patches. This time I have added error code
propagation which you have palced at todo list.
In this series I have also removed caching gadget/function/config attributes
in internal structures. Thos attributes may be changed by kernel when
enabling gadget,
Signed-off-by: Krzysztof Opasiak
---
examples/gadget-acm-ecm.c |1 -
examples/show-gadgets.c |1 -
src/usbg.c|2 --
3 files changed, 4 deletions(-)
diff --git a/examples/gadget-acm-ecm.c b/examples/gadget-acm-ecm.c
index b3c776d..5b027b6 100644
--- a/examples/gadget
Tony/Benoit,
On Monday 03 March 2014 05:08 PM, Kishon Vijay Abraham I wrote:
Added device tree bindings for dwc3, usb2 and usb3 PHYs. The documentation
of these can be found at Documentation/devicetree/bindings/phy/phy-bindings.txt
and Documentation/devicetree/bindings/phy/ti-phy.txt.
Can this
1 - 100 of 133 matches
Mail list logo
