Hi,
On Mon, Jan 27, 2014 at 6:02 PM, Yufeng Shen wrote:
> There is timeout error during initialization:
> kernel: [ 11.733104] hid-multitouch 0003:1870:0110.0001:
> usb_submit_urb(ctrl) failed: -1
> kernel: [ 11.734093] hid-multitouch 0003:1870:0110.0001: timeout
> initializing reports
>
>
On Mon, Jan 27, 2014 at 10:52:48AM -0500, Alan Stern wrote:
> On Mon, 27 Jan 2014, Peter Chen wrote:
>
> > If the high-speed device does not enter full-speed idle after
> > wakeup on disconnect logic has effected, there will be an
> > unexpected disconnect wakeup interrupt due to the bus is still
On 01/27/2014 02:52 PM, Greg KH wrote:
On Mon, Jan 27, 2014 at 02:29:53PM -0800, nubjub wrote:
The precise meaning of dead would be: Absolutely nothing is logged when
I plug a device into one of the other two ports. But for instance I have
a bus powered usb sound card that has an led indicat
On Mon, Jan 27, 2014 at 03:27:36PM -0800, Greg KH wrote:
> On Tue, Jan 28, 2014 at 02:02:12AM +0300, Dan Carpenter wrote:
> > On Mon, Jan 27, 2014 at 02:50:04PM -0800, Greg KH wrote:
> > > On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote:
> > > > From: Heinrich Schuchardt
> > > >
Hi Keith,
You've told me in the past that you've run into an issue where you can
hang the xHCI driver when one of your TeleMetrum boards refuses to
respond to a Set Address command.
Can you test the following patchset, and see if it fixes your problem?
I've applied the patchset against 3.13 here:
Walt reports that the PCI add-in card for his 0.96 ASMedia host dies in
a particular machine. This symptom goes away when commit
35773dac5f862cb1c82ea151eba3e2f6de51ec3e "usb: xhci: Link TRB must not
occur within a USB payload burst" is reverted.
Only 1.0 xHCI hosts actually need TD fragments, so
On Mon, Jan 27, 2014 at 04:06:22PM +, David Laight wrote:
> Many of the net/usb ethernet drivers (including common ones like
> the smsc95xx) will fail to transmit all packet length properly
> when connected to a USB3 port (ie using the xhci driver).
That's odd, as I've never had a problem with
On Tue, Jan 28, 2014 at 02:02:12AM +0300, Dan Carpenter wrote:
> On Mon, Jan 27, 2014 at 02:50:04PM -0800, Greg KH wrote:
> > On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote:
> > > From: Heinrich Schuchardt
> > >
> > > p is freed if NULL.
> >
> > Not a real problem, right?
> >
David, you are overwhelming my capacity to handle patches right now. I
appreciate that you would like to clean up the driver, but the bug fixes
you're sending me are getting lost in the noise of random cleanup
patches.
Can you please limit the xHCI patches you send to bug fixes for now?
Also, can
On Wed, Jan 22, 2014 at 09:46:58AM +, David Laight wrote:
> From: Sarah Sharp
> > On Tue, Jan 21, 2014 at 12:02:56PM +, David Laight wrote:
> > > Don't trace short receives if URB_SHORT_NOT_OK is set.
> > > Short receives are normal for USB ethernet devices.
> > >
> > > Don't trace unexpec
On Mon, Jan 27, 2014 at 02:50:04PM -0800, Greg KH wrote:
> On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote:
> > From: Heinrich Schuchardt
> >
> > p is freed if NULL.
>
> Not a real problem, right?
>
> > p is leaked if second calloc fails.
>
> You just created a new bug in yo
There is timeout error during initialization:
kernel: [ 11.733104] hid-multitouch 0003:1870:0110.0001: usb_submit_urb(ctrl)
failed: -1
kernel: [ 11.734093] hid-multitouch 0003:1870:0110.0001: timeout initializing
reports
Adding quirk HID_QUIRK_NO_INIT_REPORTS can solve the problem.
Signed-o
It helps if you Cc testers on your patches. Adding Jérôme, please test.
Sarah Sharp
On Thu, Jan 23, 2014 at 01:42:28PM +, David Laight wrote:
> Transfer requests for usb disks can contain a large number of 4k fragments.
> Assume that it doesn't matter if there are LINK TRB in fragment lists
On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote:
> From: Heinrich Schuchardt
Fix your email account so we can get this automatically from your email.
Currently the From header on your email is just:
From: xypron.g...@gmx.de
without your name.
>
> p is freed if NULL.
> p is
Hello.
On 01/28/2014 01:29 AM, xypron.g...@gmx.de wrote:
From: Heinrich Schuchardt
p is freed if NULL.
This is not an issue.
p is leaked if second calloc fails.
Signed-off-by: Heinrich Schuchardt
---
drivers/staging/usbip/userspace/libsrc/names.c |2 +-
1 file changed, 1 ins
On Mon, Jan 27, 2014 at 02:29:53PM -0800, nubjub wrote:
> The precise meaning of dead would be: Absolutely nothing is logged when
> I plug a device into one of the other two ports. But for instance I have
> a bus powered usb sound card that has an led indicating it's on, that
> led illuminates.
On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote:
> From: Heinrich Schuchardt
>
> p is freed if NULL.
Not a real problem, right?
> p is leaked if second calloc fails.
You just created a new bug in your "fix" :(
Please run your patches through scripts/checkpatch.pl, odds are,
On 2014.01.27 20:44, Jens Bauer wrote:
Pete, you are young
Not a good start.
What if I told you I started programming in the mid 80s? Do I still qualify?
But you have a problem. You feel attacked whenever anyone says something that
you do not agree with.
Yes, I tend to be annoyed when peo
The precise meaning of dead would be: Absolutely nothing is logged when
I plug a device into one of the other two ports. But for instance I have
a bus powered usb sound card that has an led indicating it's on, that
led illuminates. I also have a usb dvd drive which has an led that
illuminates i
From: Heinrich Schuchardt
p is freed if NULL.
p is leaked if second calloc fails.
Signed-off-by: Heinrich Schuchardt
---
drivers/staging/usbip/userspace/libsrc/names.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/libsrc/names.c
b/drive
Hi Willy,
Willy Tarreau writes:
>> > I don't know if it should have included FL1009, it was just a guess,
>> > based on the fact that the 0x1000 and 0x1400 devices did need MSI
>> > disabled. I can attempt to ask the Fresco Logic folks I know, but I'm
>> > not sure if/when I'll get a response b
On Mon, Jan 27, 2014 at 3:27 PM, Alan Stern wrote:
> On Mon, 27 Jan 2014, Josh Boyer wrote:
>
>> On Mon, Jan 27, 2014 at 3:44 PM, Sergei Shtylyov
>> wrote:
>> > Hello.
>> >
>> >
>> > On 01/27/2014 10:23 PM, Josh Boyer wrote:
>> >
>> >> the PHY layer is supposed to be optional,
>> >> considering s
On Mon, Jan 27, 2014 at 10:27 AM, Felipe Balbi wrote:
> the PHY layer is supposed to be optional,
> considering some PHY have no control bus
> for SW to poke around.
>
> After commit 1ae5799 (usb: hcd: Initialize
> USB phy if needed) any HCD which didn't provide
> a PHY driver would emit annoying
Hi Pete.
What you are saying to me is meaningless.
On Mon, 27 Jan 2014 13:59:22 +, Pete Batard wrote:
> OK, so Peter's propaganda has worked.
Pete, you are young and have many good qualities. One of them is to analyze and
find errors.
But you have a problem. You feel attacked whenever anyon
On Mon, 27 Jan 2014, Josh Boyer wrote:
> On Mon, Jan 27, 2014 at 3:44 PM, Sergei Shtylyov
> wrote:
> > Hello.
> >
> >
> > On 01/27/2014 10:23 PM, Josh Boyer wrote:
> >
> >> the PHY layer is supposed to be optional,
> >> considering some PHY have no control bus
> >> for SW to poke around.
> >
> >
On Mon, Jan 27, 2014 at 02:46:40PM -0500, Josh Boyer wrote:
> On Mon, Jan 27, 2014 at 3:44 PM, Sergei Shtylyov
> wrote:
> > Hello.
> >
> >
> > On 01/27/2014 10:23 PM, Josh Boyer wrote:
> >
> >> the PHY layer is supposed to be optional,
> >> considering some PHY have no control bus
> >> for SW to p
Hi,
On Mon, Jan 27, 2014 at 11:44:16PM +0300, Sergei Shtylyov wrote:
> >diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
> >index e6f61e4..db18011 100644
> >--- a/drivers/usb/phy/phy.c
> >+++ b/drivers/usb/phy/phy.c
> >@@ -130,7 +130,7 @@ struct usb_phy *usb_get_phy(enum usb_phy_type typ
On 01/27/2014 11:44 PM, Sergei Shtylyov wrote:
the PHY layer is supposed to be optional,
considering some PHY have no control bus
for SW to poke around.
After commit 1ae5799 (usb: hcd: Initialize
USB phy if needed) any HCD which didn't provide
a PHY driver would emit annoying error messages.
On Mon, Jan 27, 2014 at 3:44 PM, Sergei Shtylyov
wrote:
> Hello.
>
>
> On 01/27/2014 10:23 PM, Josh Boyer wrote:
>
>> the PHY layer is supposed to be optional,
>> considering some PHY have no control bus
>> for SW to poke around.
>
>
>> After commit 1ae5799 (usb: hcd: Initialize
>> USB phy if need
Hello.
On 01/27/2014 10:23 PM, Josh Boyer wrote:
the PHY layer is supposed to be optional,
considering some PHY have no control bus
for SW to poke around.
After commit 1ae5799 (usb: hcd: Initialize
USB phy if needed) any HCD which didn't provide
a PHY driver would emit annoying error message
the PHY layer is supposed to be optional,
considering some PHY have no control bus
for SW to poke around.
After commit 1ae5799 (usb: hcd: Initialize
USB phy if needed) any HCD which didn't provide
a PHY driver would emit annoying error messages.
In this patch we're decreasing those messages
to de
On 27/01/14 18:23, Sergei Shtylyov wrote:
Hello.
On 01/26/2014 08:05 PM, Ben Dooks wrote:
[snip]
+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = {
+{ .compatible = "renesas,usb-phy-r8a7790", },
+{ .compatible = "renesas,rcar-gen2-usb-phy", },
Frankly speaking, I don'
Hi Thomas and Sarah,
Thomas Petazzoni writes:
> On Thu, 23 Jan 2014 09:24:41 +0100, Arnaud Ebalard wrote:
>
>> The various Armada-based devices I have are NAS which do not have PCIe
>> slots to plug additional devices (everything is soldered). I don't know
>> which device Thomas used for its tes
On Thu, Jan 23, 2014 at 10:35:56AM +, David Laight wrote:
> From: Sarah Sharp
> > Hi David,
> >
> > I've been thinking about this some more, and I'd like to propose a much
> > simpler solution.
> >
> > The TD fragment rules didn't go into the xHCI specification until the
> > 1.0 revision. Th
Hello.
On 01/26/2014 08:05 PM, Ben Dooks wrote:
Add support for the phy-rcar-gen2-usb driver to be probed from device tree.
Signed-off-by: Ben Dooks
Reviewed-by: Ian Molton
---
Fixes from v2:
- fix missing of_if patch
(I clearly should not be let near git-rebase when hungry)
Fix
Surround header with include guards to protect against
multiple inclusion.
Signed-off-by: Krzysztof Opasiak
---
include/usbg/usbg.h |4
1 file changed, 4 insertions(+)
diff --git a/include/usbg/usbg.h b/include/usbg/usbg.h
index 319cc1e..d2c9f0c 100644
--- a/include/usbg/usbg.h
+++ b/i
Afther creation of configuration its attributes left uninitialized.
Config attrs should be initialized with default values provided
by kernel.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/usbg.c b/src/usbg.c
index 6f752a9..ab9f253 1
Change order of gadget creation and attribute writting
to fix No such file or directory error while creating
new gadget.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
index b13c666..e9bd41
Make use of previously unused variable ret to cleanup
after successful gadget creation.
Signed-off-by: Krzysztof Opasiak
---
examples/gadget-acm-ecm.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/examples/gadget-acm-ecm.c b/examples/gadget-acm-ecm.
Add return 0 in functions which return non-void to
suppress compiler complaint.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c |4
1 file changed, 4 insertions(+)
diff --git a/src/usbg.c b/src/usbg.c
index c88358d..b13c666 100644
--- a/src/usbg.c
+++ b/src/usbg.c
@@ -228,6 +228,8 @@ s
Fix gadget_create_gadget function to initialize gadget attributes
and strings with default values provided by kernel.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
index 11a9abf..9ee3d35 100644
Free the memory allocated for gadget/config/function structure
when faild to create suitable directory.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/src/usbg.c b/src/usbg.c
index e9bd418..ca444db 100644
--- a/src/usbg.c
+++ b/src/usbg.
Move creation of symlink after memory allocation for
binding structure. Fix missing initialization of parent.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
index 9ee3d35..515239a 100644
Add error handling when gadget_read_buf() returns NULL.
If read of string fails, the string should be set as empty.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
index ca444db
Replace strings, functions, configs strings placed
everywhere in code with macro defintions STRINGS_DIR,
FUNCTIONS_DIR and CONFIGS_DIR.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 39 ---
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/
Use the assign operator for structure instead of using
memcpy with hard coded size.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
index 515239a..fe20c16 100644
--- a/src/usbg.c
+++ b/src/usbg
Gadget attributes and strings are logically independent,
so they should be initialized in separate functions.
Signed-off-by: Krzysztof Opasiak
---
src/usbg.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/usbg.c b/src/usbg.c
index ab9f253..11a9abf 100644
--
Dear Matt,
Please excuse me my passivity after discussuon about libusbg some time ago.
I had to close some other issues before taking up this one.
Recently I looked into code of libusbg, build it and found some errors
which are fixed in attached patches. Moreover I have done some clean up
and min
Hi,
On Mon, Jan 27, 2014 at 05:08:55PM +0200, Heikki Krogerus wrote:
> > > Since PHYs for dwc3 is optional (not all SoCs that have DWC3 use PHYs),
> > > do not return from probe if the USB PHY library returns -ENODEV as that
> >
> > this isn't correct, they all have PHYs, some of them might not b
Many of the net/usb ethernet drivers (including common ones like
the smsc95xx) will fail to transmit all packet length properly
when connected to a USB3 port (ie using the xhci driver).
The underlying problem is that they assume the host controller
will honour the URB_ZERO_PACKET flag - which usbn
On Mon, 27 Jan 2014, Peter Chen wrote:
> If the high-speed device does not enter full-speed idle after
> wakeup on disconnect logic has effected, there will be an
> unexpected disconnect wakeup interrupt due to the bus is still SE0.
I think you mean "If the high-speed device does not enter full-s
Hi,
On Sun, Jan 26, 2014 at 05:05:01PM +, Ben Dooks wrote:
> Add support for the phy-rcar-gen2-usb driver to be probed from device tree.
>
> Signed-off-by: Ben Dooks
> Reviewed-by: Ian Molton
> ---
> Fixes from v2:
> - fix missing of_if patch
> (I clearly should not be let near git-re
On Sat, Jan 25, 2014 at 03:24:55PM -0500, Josh Boyer wrote:
> On Sat, Jan 25, 2014 at 10:37 AM, Alan Stern
> wrote:
> > On Sat, 25 Jan 2014, Josh Boyer wrote:
> >
> >> commit 1ae5799ef6317 ("usb: hcd: Initialize USB phy if needed") allows
> >> the USB layer to initialize external PHYs if needed.
the PHY layer is supposed to be optional,
considering some PHY have no control bus
for SW to poke around.
After commit 1ae5799 (usb: hcd: Initialize
USB phy if needed) any HCD which didn't provide
a PHY driver would emit annoying error messages.
In this patch we're decreasing those messages
to de
Hi Felipe,
On Tue, Jan 21, 2014 at 08:47:25AM -0600, Felipe Balbi wrote:
> On Tue, Jan 21, 2014 at 03:41:38PM +0530, Kishon Vijay Abraham I wrote:
> > Since PHYs for dwc3 is optional (not all SoCs that have DWC3 use PHYs),
> > do not return from probe if the USB PHY library returns -ENODEV as that
From: Jérôme Carretero
> I was happily using big (10MB) buffers before, and with recent kernels,
> when using USB3, I had to reduce the size of my buffers a lot.
> By the way, I couldn't find any information on a maximum size for the
> bulk transfers using libusb, maybe you know about that also ?
>
Hi Jens,
On 2014.01.27 12:25, Jens Bauer wrote:
On Sun, 26 Jan 2014 17:07:42 +, Pete Batard wrote:
I, and many others, happen to think users of libusb deserve more than
one release in 4 years, even more so as continuous major development has
been going on.
I disagree.
If libusb works fine
Hello.
On 27-01-2014 13:21, George Cherian wrote:
Enable the isochrounous IN handling for AM335x HOST.
Reprogram CPPI to receive consecutive ISOCH frames in the same URB.
Sigh, I knew CPPI ISO path was broken for years but didn't have time to
fix it. :-(
Signed-off-by: George Cherian
Hi Pete.
On Sun, 26 Jan 2014 17:07:42 +, Pete Batard wrote:
> I, and many others, happen to think users of libusb deserve more than
> one release in 4 years, even more so as continuous major development has
> been going on.
I disagree.
If libusb works fine, no need to fix bugs that are not
This series enables the ISOCH IN handling for AM335x HOST mode.
With this series webcam devices are now supported under AM335x
MUSB HOST with CPPI DMA enabled.
Patch 1 - Enable basic ISOCH IN handling
Patch 2 - Make CPPI aware of hb transfers
Patch 3 - Using hrtimer based polling for tx empty lea
Enable CPPI to handle high bandwidth transfers, especially to support
webcam captures. Use a single bd to get the whole of the data in case of
high bandwidth transfers.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_cppi41.c | 13 +
1 file changed, 13 insertions(+)
diff --g
Enable the isochrounous IN handling for AM335x HOST.
Reprogram CPPI to receive consecutive ISOCH frames in the same URB.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_host.c | 30 ++
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/
In case of ISOCH transfers the hrtimer workaround for the hardware issue
is not very reliable. Instead of checking musb_is_tx_fifo_empty() in hrtimer
routine, schedule a completion work and check the same in completion work.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_cppi41.c | 53 +
On 1/24/2014 11:16 PM, Sergei Shtylyov wrote:
Hello.
On 24-01-2014 18:14, George Cherian wrote:
In case of ISOCH transfers the hrtimer workaround for the hardware issue
is not very reliable. Instead of checking musb_is_tx_fifo_empty() in
hrtimer
routine, schedule a completion work and check t
On 1/24/2014 11:13 PM, Sergei Shtylyov wrote:
Hello.
On 24-01-2014 18:14, George Cherian wrote:
Enable the isochrounous IN handling for AM335x HOST.
Reprogram CPPI to receive consecutive ISOCH frames in the same URB.
Sigh, I knew CPPI ISO path was broken for years but didn't have
time to
Hi,
On Monday 20 January 2014 07:12 PM, Vivek Gautam wrote:
> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
> The new driver uses the generic PHY framework and will interact
> with DWC3 controller present on Exynos5 series of SoCs.
> Thereby, removing old phy-samsung-usb3 driver
66 matches
Mail list logo