RE: [PATCH] usb: chipidea: udc: fix setup_status condition in isr

2014-01-24 Thread Peter Chen
> > The isr is going to check for a status phase on the indexed endpoint. > Input endpoints have no status bits and can be skipped for that test. > > Signed-off-by: Michael Grzeschik > --- > This patch is based on the change mentioned by Matthieu CASTET, > but moves the check before using hw_t

Re: [PATCH] ARM-i.MX6Q-dts : Added USB_OTG Support

2014-01-24 Thread Sascha Hauer
Please add Phytec phyFLEX-i.MX6 to the subject. I assumed some SoC specific changes here. Sascha On Fri, Jan 24, 2014 at 02:58:44PM +0530, Ashutosh singh wrote: > This patch adds support for USB_OTG on Phytec phyFLEX-i.MX6 Quad module. > > Signed-off-by: Ashutosh singh > --- > arch/arm/boot/dt

Re: Odd 'unable to find transceiver' messages from USB with v3.13-3260-g03d11a0 and later

2014-01-24 Thread Josh Boyer
On Fri, Jan 24, 2014 at 2:08 PM, Felipe Balbi wrote: > Hi, > > On Fri, Jan 24, 2014 at 08:47:07AM -0500, Josh Boyer wrote: >> We've had a report [1] of the USB layer throwing out 'unable to find >> transceiver' messages during boot with the 3.14 merge window kernels. >> I've seen this on my person

Re: Lockdep warning upon device removal

2014-01-24 Thread Alan Stern
Tejun: You might know something about this. Alan Stern On Fri, 24 Jan 2014, Fabio Estevam wrote: > Hi, > > I am running linux-next-20140124 on a mx6slevk board and I am getting > the following dump when I remove the USB stick: > > $ usb 1-1: USB disconnect, device number 2

Lockdep warning upon device removal

2014-01-24 Thread Fabio Estevam
Hi, I am running linux-next-20140124 on a mx6slevk board and I am getting the following dump when I remove the USB stick: $ usb 1-1: USB disconnect, device number 2 INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness

Re: Odd 'unable to find transceiver' messages from USB with v3.13-3260-g03d11a0 and later

2014-01-24 Thread Felipe Balbi
Hi, On Fri, Jan 24, 2014 at 08:47:07AM -0500, Josh Boyer wrote: > We've had a report [1] of the USB layer throwing out 'unable to find > transceiver' messages during boot with the 3.14 merge window kernels. > I've seen this on my personal machine as well and included the dmesg > section below. Th

[PATCH v2] staging/usbip: userspace to use linux header for usb_device_speed enum, missing speeds to speed_strings array

2014-01-24 Thread Shuah Khan
Remove usb_device_speed enum define from usbip_common.h and change it to include linux/usb/ch9.h instead. Add speed strings for usb wireless and 3.0 to speed_strings array. Signed-off-by: Shuah Khan --- v2: combined the following two userspace patches and addressed comments. https://lkml.org/lkm

Re: [PATCH] staging/usbip: Change userspace to use linux include for usb_device_speed enum

2014-01-24 Thread Shuah Khan
On 01/22/2014 10:56 AM, Shuah Khan wrote: Remove usb_device_speed enum define from usbip_common.h and change it to include linux/usb/ch9.h instead. Signed-off-by: Shuah Khan --- drivers/staging/usbip/userspace/libsrc/usbip_common.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-)

Re: [PATCH 3/3] usb: musb: musb_cppi41: Handle ISOCH differently and not use the hrtimer.

2014-01-24 Thread Sergei Shtylyov
Hello. On 24-01-2014 18:14, George Cherian wrote: In case of ISOCH transfers the hrtimer workaround for the hardware issue is not very reliable. Instead of checking musb_is_tx_fifo_empty() in hrtimer routine, schedule a completion work and check the same in completion work. Signed-off-by: Ge

Re: [PATCH 1/3] usb: musb: musb_host: Enable ISOCH IN handling for AM335x host

2014-01-24 Thread Sergei Shtylyov
Hello. On 24-01-2014 18:14, George Cherian wrote: Enable the isochrounous IN handling for AM335x HOST. Reprogram CPPI to receive consecutive ISOCH frames in the same URB. Sigh, I knew CPPI ISO path was broken for years but didn't have time to fix it. :-( Signed-off-by: George Cherian

Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array

2014-01-24 Thread Shuah Khan
On 01/24/2014 10:31 AM, Thomas Pugliese wrote: On Fri, 24 Jan 2014, Shuah Khan wrote: On 01/24/2014 10:08 AM, Thomas Pugliese wrote: On Wed, 22 Jan 2014, Shuah Khan wrote: Add speed strings for usb wireless and 3.0 to speed_strings array. Signed-off-by: Shuah Khan --- drivers/stagin

Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array

2014-01-24 Thread Thomas Pugliese
On Fri, 24 Jan 2014, Shuah Khan wrote: > On 01/24/2014 10:08 AM, Thomas Pugliese wrote: > > > > > > On Wed, 22 Jan 2014, Shuah Khan wrote: > > > > > Add speed strings for usb wireless and 3.0 to speed_strings array. > > > > > > Signed-off-by: Shuah Khan > > > --- > > > drivers/staging/usb

Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array

2014-01-24 Thread Shuah Khan
On 01/24/2014 10:08 AM, Thomas Pugliese wrote: On Wed, 22 Jan 2014, Shuah Khan wrote: Add speed strings for usb wireless and 3.0 to speed_strings array. Signed-off-by: Shuah Khan --- drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array

2014-01-24 Thread Thomas Pugliese
On Wed, 22 Jan 2014, Shuah Khan wrote: > Add speed strings for usb wireless and 3.0 to speed_strings array. > > Signed-off-by: Shuah Khan > --- > drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/usbip/userspace/l

[PATCH] staging/usbip: simplify usbip_dump_usb_device() udev->speed handling

2014-01-24 Thread Shuah Khan
Change usbip_dump_usb_device() to use usb_speed_string() and remove the code that does switch on udev->speed and builds custom speed strings. Signed-off-by: Shuah Khan --- drivers/staging/usbip/usbip_common.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --g

Re: [usb-storage] Re: usb disk recognized but fails

2014-01-24 Thread Alan Stern
Matthieu: Can you help with this problem? On Fri, 24 Jan 2014, Milan Svoboda wrote: > >I don't see how that could have made any difference. The Cypress-ATACB > >driver works just like the default driver, except for two commands > >(ATA(12) and ATA(16)) neither of which appeared in the usbmon t

Re: [PATCH] ARM-i.MX6Q-dts : Added USB_OTG Support

2014-01-24 Thread Mark Rutland
On Fri, Jan 24, 2014 at 12:15:08PM +, Fabio Estevam wrote: > Hi Mark, > > On Fri, Jan 24, 2014 at 9:50 AM, Mark Rutland wrote: > > >> + > >> + regulators { > >> + compatible = "simple-bus"; > > > > This is _not_ a simple bus. It doesn't have the required ranges > > property.

Re: [PATCH] ARM-i.MX6Q-dts : Added USB_OTG Support

2014-01-24 Thread Shawn Guo
On Fri, Jan 24, 2014 at 11:50:05AM +, Mark Rutland wrote: > > @@ -18,6 +18,19 @@ > > memory { > > reg = <0x1000 0x8000>; > > }; > > + > > + regulators { > > + compatible = "simple-bus"; > > This is _not_ a simple bus. It doesn't have the required ranges

[PATCH] usb: chipidea: udc: fix setup_status condition in isr

2014-01-24 Thread Michael Grzeschik
The isr is going to check for a status phase on the indexed endpoint. Input endpoints have no status bits and can be skipped for that test. Signed-off-by: Michael Grzeschik --- This patch is based on the change mentioned by Matthieu CASTET, but moves the check before using hw_test_and_clear_setup

[PATCH v7 1/4] libusbg: Replace array lengths with defines

2014-01-24 Thread Stanislaw Wadas
Replace hard coded value of 256 by two constant defines, USBG_MAX_STR_LENGTH and USBG_MAX_PATH_LENGTH Define USBG_MAX_NAME_LENGTH for name[] array Signed-off-by: Stanislaw Wadas --- include/usbg/usbg.h | 36 src/usbg.c | 46 ++

[PATCH v7 4/4] libusbg: Add inline to gadget_write_string().

2014-01-24 Thread Stanislaw Wadas
Add inline to gadget_write_string(). Signed-off-by: Stanislaw Wadas --- src/usbg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/usbg.c b/src/usbg.c index a0be6f3..c88358d 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -167,7 +167,7 @@ static void usbg_write_int(char *p

[PATCH v7 2/4] libusbg: Add fputs()/fgets()/fprintf() error

2014-01-24 Thread Stanislaw Wadas
Add error handling to fputs()/fgets()/fprintf() functions. Signed-off-by: Stanislaw Wadas --- src/usbg.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/usbg.c b/src/usbg.c index 198b504..bbc5db5 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -36,12 +36,14

[PATCH v7 3/4] libusbg: Move mkdir functions

2014-01-24 Thread Stanislaw Wadas
Call mkdir() function after successful memory allocation and gadget function creation. Signed-off-by: Stanislaw Wadas --- src/usbg.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/usbg.c b/src/usbg.c index bbc5db5..a0be6f3 100644

[PATCH v7 0/4] libusbg: clean up and error handling

2014-01-24 Thread Stanislaw Wadas
In reference to the message sent by Andrzej Pietrasiewicz (about libusbg (formerly libgadget)) I would like to propose some changes to libusbg. Creating directories is now performed after successful memory allocation and gadget function creation. Hard coded values are replaced with constants. Erro

[PATCH 2/3] usb: musb: musb_cppi41: Make CPPI aware of high bandwidth transfers

2014-01-24 Thread George Cherian
Enable CPPI to handle high bandwidth transfers, especially to support webcam captures. Use a single bd to get the whole of the data in case of high bandwidth transfers. Signed-off-by: George Cherian --- drivers/usb/musb/musb_cppi41.c | 13 + 1 file changed, 13 insertions(+) diff --g

RE: [PATCH] xhci: Don't add NOP TRB for aligned bulk sg transfers

2014-01-24 Thread David Laight
From: David Laight > Transfer requests for usb disks can contain a large number of 4k fragments. > Assume that it doesn't matter if there are LINK TRB in fragment lists > that are 1k aligned. > > This should stop errors when transfer requests for usb disks contain > more fragments that will fit in

Re: [PATCH] net: sk == 0xffffffff fix - not for commit

2014-01-24 Thread Andrew Ruder
On Fri, Jan 24, 2014 at 07:38:31AM -0600, Andrew Ruder wrote: > http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg574770.html > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58854 Just a little further confirmation. This appears in __inet_lookup_established as the last four instructions b

[PATCH 1/3] usb: musb: musb_host: Enable ISOCH IN handling for AM335x host

2014-01-24 Thread George Cherian
Enable the isochrounous IN handling for AM335x HOST. Reprogram CPPI to receive consecutive ISOCH frames in the same URB. Signed-off-by: George Cherian --- drivers/usb/musb/musb_host.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/usb/m

[PATCH 0/3] Enable ISOCH IN handling for AM335x

2014-01-24 Thread George Cherian
This series enables the ISOCH IN handling for AM335x HOST mode. With this series webcam devices are now supported under AM335x MUSB HOST with CPPI DMA enabled. Patch 1 - Enable basic ISOCH IN handling Patch 2 - Make CPPI aware of hb transfers Patch 3 - Using hrtimer based polling for tx empty lead

[PATCH 3/3] usb: musb: musb_cppi41: Handle ISOCH differently and not use the hrtimer.

2014-01-24 Thread George Cherian
In case of ISOCH transfers the hrtimer workaround for the hardware issue is not very reliable. Instead of checking musb_is_tx_fifo_empty() in hrtimer routine, schedule a completion work and check the same in completion work. Signed-off-by: George Cherian --- drivers/usb/musb/musb_cppi41.c | 54 +

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-24 Thread Kishon Vijay Abraham I
Hi, On Tuesday 21 January 2014 08:17 PM, Felipe Balbi wrote: > On Tue, Jan 21, 2014 at 03:41:38PM +0530, Kishon Vijay Abraham I wrote: >> Since PHYs for dwc3 is optional (not all SoCs that have DWC3 use PHYs), >> do not return from probe if the USB PHY library returns -ENODEV as that > > this isn

Re: [PATCH v6 2/4] libusbg: Add fputs()/fgets() error handling

2014-01-24 Thread Stanislaw Wadas
Hello David, On 22.01.2014 17:05, David Laight wrote: From: Stanislaw Wadas Add error handling to fputs()/fgets() functions. ... - fputs(buf, fp); + if (fputs(buf, fp) == EOF) { + ERROR("write error"); + fclose(fp); + return; + } Po

Odd 'unable to find transceiver' messages from USB with v3.13-3260-g03d11a0 and later

2014-01-24 Thread Josh Boyer
Hi All, We've had a report [1] of the USB layer throwing out 'unable to find transceiver' messages during boot with the 3.14 merge window kernels. I've seen this on my personal machine as well and included the dmesg section below. This does not happen with the 3.13 kernel. There are only a handf

Re: [PATCH] net: sk == 0xffffffff fix - not for commit

2014-01-24 Thread Andrew Ruder
Actually found what looks to be a fix for this in another thread. http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg574770.html http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58854 Cheers, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message

Re: [PATCH] ARM-i.MX6Q-dts : Added USB_OTG Support

2014-01-24 Thread Fabio Estevam
Hi Mark, On Fri, Jan 24, 2014 at 9:50 AM, Mark Rutland wrote: >> + >> + regulators { >> + compatible = "simple-bus"; > > This is _not_ a simple bus. It doesn't have the required ranges > property. > > Why do these need to be in a regulators container node? We don't group > dma co

Re: 30 sec boot delay and logitech mouse disconnection

2014-01-24 Thread Larry Keegan
On Thu, 23 Jan 2014 15:40:28 -0500 glphvgacs wrote: > On Thu, Jan 23, 2014 at 03:12:10PM -0500, Alan Stern wrote: > > On Thu, 23 Jan 2014, glphvgacs wrote: > > > > > > The trace shows that the mouse appears, and then apparently is > > > > unused. It kind of looks as though the mouse goes into run

Re: [PATCH] ARM-i.MX6Q-dts : Added USB_OTG Support

2014-01-24 Thread Mark Rutland
On Fri, Jan 24, 2014 at 09:28:44AM +, Ashutosh singh wrote: > This patch adds support for USB_OTG on Phytec phyFLEX-i.MX6 Quad module. > > Signed-off-by: Ashutosh singh > --- > arch/arm/boot/dts/imx6q-phytec-pbab01.dts |4 > arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi | 22 +++

xhci_urb_dequeue() and td_list bugs

2014-01-24 Thread David Laight
If you cancel an isoc urb that has multiple TD (I suspect this is most isoc urb) then (if I'm reading the code correctly) the urb completion routine is called for each TD, and the memory for each td_list entry is freed separately (even though they are allocated by a single kmalloc()). Neither of th

[PATCH] USB: simple: add Dynastream ANT USB-m Stick device support

2014-01-24 Thread Johan Hovold
From: Kristóf Ralovich Add support for ANT USB-m Stick from Dynastream Innovations, by listing USB pid [34366.944805] usb 6-1: New USB device found, idVendor=0fcf, idProduct=1009 [34366.944817] usb 6-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [34366.944824] usb 6-1: Product: ANT

Re: Regression on next-20140116 [Was: [PATCH 3/3 v4] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init]

2014-01-24 Thread Uwe Kleine-König
Hello Peter, On Thu, Jan 23, 2014 at 09:22:41AM +0800, Peter Chen wrote: > On Wed, Jan 22, 2014 at 10:41:33PM +0100, Uwe Kleine-König wrote: > > On Wed, Jan 22, 2014 at 10:49:51AM +0100, Uwe Kleine-König wrote: > > > On Tue, Dec 03, 2013 at 04:01:50PM +0800, Chris Ruehl wrote: > > > > usb: chipide

Re: [PATCH] USB: simple: add Dynastream ANT USB-m Stick device support

2014-01-24 Thread kristof.ralov...@gmail.com
On Thu, Jan 23, 2014 at 5:01 PM, Johan Hovold wrote: > On Thu, Jan 23, 2014 at 03:59:37PM +0100, RALOVICH, Kristof wrote: >> From: RALOVICH, Kristof > > Don't you want to use "Kristóf Ralovich" here as well? That will be the > name of the author in the git logs. > >> Add support for ANT USB-m Sti

[PATCH] ARM-i.MX6Q-dts : Added USB_OTG Support

2014-01-24 Thread Ashutosh singh
This patch adds support for USB_OTG on Phytec phyFLEX-i.MX6 Quad module. Signed-off-by: Ashutosh singh --- arch/arm/boot/dts/imx6q-phytec-pbab01.dts |4 arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi | 22 ++ 2 files changed, 26 insertions(+) diff --git a/arch/arm/bo