On Thu, 2014-01-02 at 16:45 -0800, Sarah Sharp wrote:
> On Sat, Dec 21, 2013 at 03:51:25PM -0500, Alan Stern wrote:
> > On Fri, 20 Dec 2013, Sarah Sharp wrote:
> >
> > > On Thu, Dec 19, 2013 at 11:48:47AM -0800, James Bottomley wrote:
> > > > It should apply incrementally on top of the previous tw
On Fri, Jan 03, 2014 at 11:21:56AM +0800, Hayes Wang wrote:
> The return value should be the boolean value, not the error code.
>
> Signed-off-by: Hayes Wang
> Spotted-by: Dan Carpenter
> ---
> drivers/net/usb/r8152.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dri
Fixes the following compilation warning:
drivers/usb/gadget/s3c-hsudc.c: In function ‘s3c_hsudc_probe’:
drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label ‘err_add_device’
defined but not used [-Wunused-label]
Signed-off-by: Sachin Kamat
---
drivers/usb/gadget/s3c-hsudc.c |1 -
1 file cha
Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'.
Fixes the following compilation error introduced by commit e117e742d310
("usb: gadget: add "maxpacket_limit" field to struct usb_ep"):
drivers/usb/gadget/s3c2410_udc.c: In function ‘s3c2410_udc_reinit’:
drivers/usb/gadget/s
On Thu, 2 Jan 2014 16:03:34 -0800
Sarah Sharp wrote:
> On Sun, Dec 22, 2013 at 09:47:49AM +0200, Denis Turischev wrote:
> > On 12/21/2013 01:45 AM, Sarah Sharp wrote:
> > > On Fri, Dec 20, 2013 at 12:41:11PM +0200, Denis Turischev wrote:
> > >>> Also, which kernel are you experiencing this issue
The return value should be the boolean value, not the error code.
Signed-off-by: Hayes Wang
Spotted-by: Dan Carpenter
---
drivers/net/usb/r8152.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index e3d878c..13fabbb 100644
-
Bjørn Mork [mailto:bj...@mork.no]
> Sent: Thursday, January 02, 2014 10:25 PM
> To: Hayeswang
> Cc: oli...@neukum.org; net...@vger.kernel.org; nic_swsd;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next v2 6/6] r8152: support RTL8153
>
[...]
> > +#if defin
> On Thu, 26 Dec 2013, Du, ChangbinX wrote:
>
> > I can reproduce issue by adding a delay just after
> > usb_set_intfdata(intf, NULL) (echo -1 > bConfigurationValue to trigger
> hub_dissconnect())without your patch.
> >
> > After patch applied, cannot reproduce and didn't found any other issue.
>
On Sat, Dec 21, 2013 at 03:51:25PM -0500, Alan Stern wrote:
> On Fri, 20 Dec 2013, Sarah Sharp wrote:
>
> > On Thu, Dec 19, 2013 at 11:48:47AM -0800, James Bottomley wrote:
> > > It should apply incrementally on top of the previous two. If it
> > > actually works, I'll fold it into the first patc
In the highly unusual case where two threads are running concurrently through
the scanning code scanning the same target, we run into the situation where
one may allocate the target while the other is still using it. In this case,
because the reap checks for STARGET_CREATED and kills the target wi
This patch eliminates the reap_ref and replaces it with a proper kref.
On last put of this kref, the target is removed from visibility in
sysfs. The final call to scsi_target_reap() for the device is done from
__scsi_remove_device() and only if the device was made visible. This
ensures that the t
This set should fix our target problems with USB by making the target
visibility properly reference counted. Since it's a major change to the
infrastructure, we'll incubate upstream first before backporting to
stable.
James Bottomley (2):
[SCSI] fix our current target reap infrastructure.
[SC
On Sat, 2013-12-21 at 15:51 -0500, Alan Stern wrote:
> On Fri, 20 Dec 2013, Sarah Sharp wrote:
>
> > On Thu, Dec 19, 2013 at 11:48:47AM -0800, James Bottomley wrote:
> > > It should apply incrementally on top of the previous two. If it
> > > actually works, I'll fold it into the first patch.
> >
On Sun, Dec 22, 2013 at 09:47:49AM +0200, Denis Turischev wrote:
> On 12/21/2013 01:45 AM, Sarah Sharp wrote:
> > On Fri, Dec 20, 2013 at 12:41:11PM +0200, Denis Turischev wrote:
> >>> Also, which kernel are you experiencing this issue on? In 3.12, I
> >>> queued a separate patch to deal with spur
On Sun, Dec 29, 2013 at 06:28:20AM -0800, Eric Decker wrote:
> Hi Sarah,
>
> I hope this is reasonable to send this directly to you. If not please feel
> free to point me in the right direction.
Thanks for the bug report! It's always good to Cc the kernel subsystem
mailing list on bug reports (
On Sun, Dec 29, 2013 at 02:54:40AM -0200, Mauro Carvalho Chehab wrote:
> It seems that usb_unlink_urb() is causing troubles with xHCI: the
> endpoint stops streaming, but, after that, it doesn't start again,
> and lots of debug messages are produced. I emailed you the full log
> after start streami
Clean up interrupt completion handler somewhat.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index ac21618ace19..65a81c64bf7b 100644
---
Only wake up MSR wait queue on actual modem-status changes.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 025b7857a36c..acc88650ac0a 100644
--- a/drivers/usb/serial/c
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
Cc: Arnd Bergmann
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 49 -
1 file changed, 8 inserti
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
Cc: Arnd Bergmann
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cypress_m8.c | 63 +++--
1 file changed, 16 insert
Fix ring-indicator (RI) status-bit definition, which was defined as CTS,
effectively preventing RI-changes from being detected while reporting
false RI status.
This bug predates git.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cypress_m8.h | 2 +-
1 file change
Switch to the generic TIOCMIWAIT implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/oti6858.c | 55 ++--
1 file changed, 12 insertions(+), 43 deletions(-)
diff --git a/drivers/usb/serial/oti6858.c b/drivers/usb/serial/oti6858.c
index 9ea15
Only wake up MSR wait queue on actual modem-status changes.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 11de1f169308..64f093f1698
Clean up protocol definitions.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cypress_m8.h | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/serial/cypress_m8.h b/drivers/usb/serial/cypress_m8.h
index ce13e61b7d55..68bfd5197a63 10
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
Cc: Arnd Bergmann
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 49 --
1 file changed, 8 inserti
Clean up line-status handling.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index f647dbdcb27d..9dd94a7e08b9 100644
--- a/drivers/usb/
Refactor line-status handling.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 51 +-
1 file changed, 28 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 8908760cca9f..f647dbdcb27d
Make sure the TIOCMIWAIT mask is always honoured.
The CH341 interrupt status has a multiple-status changed flag which
indicates that multiple status changes has occurred since last interrupt
event. Unfortunately, if the final status is the same, there appears to
be no way to determine which signal
Hi Greg,
Here's a second batch of patches for v3.14 (again, if not too late).
The first one is a minor fix to the series posted last week (missing
const) and the remaining patches clean up modem-status handling and
switches the remaining usb-serial drivers with custom
TIOCMIWAIT-implementations o
Clean up line-status handling somewhat.
Get tty-reference only when actually needed.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl230
Only wake up MSR wait queue on actual modem-status changes.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/oti6858.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/oti6858.c b/drivers/usb/serial/oti6858.c
index 1dea599bb71b..9ea15e0a22d8 100644
--
Only wake up MSR wait queue on actual modem-status changes.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cypress_m8.c | 5 -
drivers/usb/serial/cypress_m8.h | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress
Declare constant device-type data as const.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 253cc9c367c1..9951dfddc784 100644
--- a/drivers/usb/seri
Hi Arnd,
On Thu, Jan 02, 2014 at 01:07:39PM +0100, Arnd Bergmann wrote:
> We really want to kill off interruptible_sleep_on, which is defined
> in a way that is always racy. There are four usb-serial drivers using
> it to implement their tiocmiwait() functions, which is defined in
> a way that alw
On Thu, Jan 02, 2014 at 04:01:29PM -0500, Mark Lord wrote:
> On 14-01-02 02:15 PM, Sarah Sharp wrote:
> > On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote:
> ..
> >> Unfortunately this patch causes a regression when copying large files to my
> >> outboard USB3 drive. (Nothing at all to do with
On Thu, 2014-01-02 at 16:01 -0500, Mark Lord wrote:
> On 14-01-02 02:15 PM, Sarah Sharp wrote:
> > On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote:
> ..
> >> Unfortunately this patch causes a regression when copying large files to my
> >> outboard USB3 drive. (Nothing at all to do with network
On 14-01-02 02:15 PM, Sarah Sharp wrote:
> On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote:
..
>> Unfortunately this patch causes a regression when copying large files to my
>> outboard USB3 drive. (Nothing at all to do with networking.)
>>
>> When I try to copy a large (20GB) file to the USB3
Peter Palúch writes:
>
> Hi Andrej,
>
> > Same problem here. HP elitebook 8560w. Running on Arch linux, kernel:
> > 3.12.5. Attaching WD Elements 1TB.no
>
> Thanks for confirming that the issue also occurs with HP EliteBook
> 8560w. Do you believe you could also create the usbmon capture trac
On Thu, 26 Dec 2013, Du, ChangbinX wrote:
> I can reproduce issue by adding a delay just after usb_set_intfdata(intf,
> NULL)
> (echo -1 > bConfigurationValue to trigger hub_dissconnect())without your
> patch.
>
> After patch applied, cannot reproduce and didn't found any other issue. Patch
>
On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote:
> On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote:
> > 3.12-stable review patch. If anyone has any objections, please let me know.
> >
> > --
> >
> > From: David Laight
> >
> > commit 35773dac5f862cb1c82ea151eba3e2f6de51ec3
Hello Alan Ott,
> The modifiers are shared between keyboards by default in Linux. If you
> hold CTRL on one keyboard and C on the other, you'll get the same result
> as having pressed CTRL-C on one keyboard.
Thanks for clearing it up. I was able to test the modifiers being
shared between keyboard
On Sun, 2013-12-29 at 15:35 +0700, Lars Melin wrote:
> On 2013-12-29 00:55, Greg KH wrote:
> > On Sat, Dec 28, 2013 at 02:13:08PM +, thomas.takacs.a...@gmail.com
> > wrote:
> >> Hi,
> >> I've seen this message: tell linux-usb... to add your device to a proper
> >> device.
> >> My USB modem is
Hi Kamil,
On Thursday 02 January 2014 09:50 PM, Kamil Debski wrote:
Hi Kishon,
I wanted to ask about your comments to this patchset. As I mentioned
there are two alternative version where the Exynos 4210 and 4212
support is merged in one file.
I would be grateful if you had some time to look a
Add return 0 in functions which return non-void to
suppress compiler complaint.
Signed-off-by: Krzysztof Opasiak
---
src/gadget.c |4
1 file changed, 4 insertions(+)
diff --git a/src/gadget.c b/src/gadget.c
index 8ca68b3..8320f34 100644
--- a/src/gadget.c
+++ b/src/gadget.c
@@ -223,6 +
Hi Kishon,
I wanted to ask about your comments to this patchset. As I mentioned
there are two alternative version where the Exynos 4210 and 4212
support is merged in one file.
I would be grateful if you had some time to look at the patchset
and share your comments.
Best wishes and happy new yea
Replace strings, functions, configs strings placed
everywhere in code with macro defintions STRINGS_DIR,
FUNCTIONS_DIR and CONFIGS_DIR.
Signed-off-by: Krzysztof Opasiak
---
src/gadget.c | 37 +++--
1 file changed, 23 insertions(+), 14 deletions(-)
diff --git a/
Fix gadget_create_gadget function to initialize gadget attributes
and strings with default values provided by kernel.
Signed-off-by: Krzysztof Opasiak
---
src/gadget.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/gadget.c b/src/gadget.c
index 2686d62..0554c7d 1
Use the assign operator for structure instead of using
memcpy with hard coded size.
Signed-off-by: Krzysztof Opasiak
---
src/gadget.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/gadget.c b/src/gadget.c
index 2bc4f2e..005d9b0 100644
--- a/src/gadget.c
+++ b/
Move creation of symlink after memory allocation for
binding structure. Fix missing initialization of parent.
Signed-off-by: Krzysztof Opasiak
---
src/gadget.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/gadget.c b/src/gadget.c
index 0554c7d..2bc4f2e 10
Add error handling when gadget_read_buf() returns NULL.
If read of string fails, the string should be set as empty.
Signed-off-by: Krzysztof Opasiak
---
Changes since v2:
- replace // comments with /* */
- add missing parenthesis in commit message
src/gadget.c | 23 +++
Change order of gadget creation and attribute writting
to fix No such file or directory error while creating
new gadget.
Signed-off-by: Krzysztof Opasiak
---
src/gadget.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gadget.c b/src/gadget.c
index 8320f34..
Surround header with include guards to protect against
multiple inclusion.
Signed-off-by: Krzysztof Opasiak
---
include/gadget/gadget.h |4
1 file changed, 4 insertions(+)
diff --git a/include/gadget/gadget.h b/include/gadget/gadget.h
index 9bca97e..f3c08e9 100644
--- a/include/gadget/
Gadget attributes and strings are logically independent,
so they should be initialized in separate functions.
Signed-off-by: Krzysztof Opasiak
---
src/gadget.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/gadget.c b/src/gadget.c
index 31adb67..2686d62 10064
Afther creation of configuration its attributes left uninitialized.
Config attrs should be initialized with default values provided
by kernel.
Signed-off-by: Krzysztof Opasiak
---
src/gadget.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gadget.c b/src/gadget.c
index 6f0c84a..31a
Free the memory allocated for gadget/config/function structure
when faild to create suitable directory.
Signed-off-by: Krzysztof Opasiak
---
src/gadget.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gadget.c b/src/gadget.c
index aea9b2e..f613c3e 100644
--- a/src/gadget.c
+++ b/s
Dear Matt,
Please excuse me my passivity after discussuon about libusbg some time ago.
I had to close some other issues before taking up this one.
Recently I looked into code of libusbg, build it and found some errors
which are fixed in attached patches. Moreover I have done some clean up
and min
Make use of previously unused variable ret to cleanup
after successful gadget creation.
Signed-off-by: Krzysztof Opasiak
---
examples/gadget-acm-ecm.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/examples/gadget-acm-ecm.c b/examples/gadget-acm-ecm.
Add support for iBall 3.5G connect usb modem.
$lsusb
Bus 002 Device 006: ID 1c9e:9605 OMEGA TECHNOLOGY
$usb-devices
T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 6 Spd=480 MxCh= 0
D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
P: Vendor=1c9e ProdID=9605 Rev=00.00
S: Manufacturer
Hi,
> -Original Message-
> From: Alan Ott [mailto:a...@signal11.us]
> Sent: Tuesday, December 31, 2013 4:32 AM
> To: Krzysztof Opasiak; mpor...@linaro.org; linux-
> u...@vger.kernel.org
> Cc: Andrzej Pietrasiewicz; Piotr Bereza; Karol Lewandowski;
> Aleksander Zdyb; Stanislaw Wadas; myungj
On Thu, Jan 2, 2014 at 7:35 PM, Bjørn Mork wrote:
> Rahul Bedarkar writes:
>
>> I am using iBall 3.5G usb modem. When I connected it to my laptop
>> first time, it was detected by kernel but got segfault in
>> usb_modeswitch.
>
> I don't think the segfault is related to the drivers or kernel in a
Quoting Alan Ott (a...@signal11.us):
> >I'm no kernel hacker nor am i a USB expert so i'm not sure wether or not
> >ep_out is mandatory but looking at the rest of the code it would seem the
> >function should return -ENODEV as with ep_in == NULL.
> >That's a bug, no?
> It appears that way. Especia
Hayes Wang writes:
> Support new chip RTL8153 which is the USB 3.0 giga ethernet adapter.
>
> Signed-off-by: Hayes Wang
> ---
> drivers/net/usb/cdc_ether.c | 10 +
> drivers/net/usb/r8152.c | 615
> +++-
> drivers/net/usb/r815x.c | 2 +-
> 3 f
Rahul Bedarkar writes:
> I am using iBall 3.5G usb modem. When I connected it to my laptop
> first time, it was detected by kernel but got segfault in
> usb_modeswitch.
I don't think the segfault is related to the drivers or kernel in any
way. It is probably a usb_modeswitch bug. But the devic
Signed-off-by: Rahul Bedarkar
---
drivers/usb/serial/aircable.c | 10 +-
drivers/usb/serial/ark3116.c | 4 ++--
drivers/usb/serial/belkin_sa.c| 2 +-
drivers/usb/serial/cyberjack.c| 2 +-
drivers/usb/serial/garmin_gps.c | 4 ++--
drivers/usb/ser
Signed-off-by: Rahul Bedarkar
---
drivers/usb/musb/blackfin.c| 4 ++--
drivers/usb/musb/musb_core.c | 6 +++---
drivers/usb/musb/musb_cppi41.c | 2 +-
drivers/usb/musb/musb_host.c | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/musb/blackfin.c b/drivers
Signed-off-by: Rahul Bedarkar
---
drivers/usb/misc/idmouse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/misc/idmouse.c b/drivers/usb/misc/idmouse.c
index ce97838..49235bd 100644
--- a/drivers/usb/misc/idmouse.c
+++ b/drivers/usb/misc/idmouse.c
@@ -386,7 +386,
This driver won't link without USB support.
Reported-by: Jim Davis
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/media/sn9c102/Kconfig
b/drivers/staging/media/sn9c102/Kconfig
index d8ae2354b626..3ab9c81173da 100644
--- a/drivers/staging/media/sn9c102/Kconfig
+++ b/drivers/staging/m
We really want to kill off interruptible_sleep_on, which is defined
in a way that is always racy. There are four usb-serial drivers using
it to implement their tiocmiwait() functions, which is defined in
a way that always has a race when called from user space.
This patch changes the four drivers
The functions sleep_on, sleep_on_timeout, interruptible_sleep_on
and interruptible_sleep_on_timeout have been deprecated for as
long as I can remember, and a number of people have contributed
patches in the past to remove them from various drivers.
This has recently popped up again and I decided t
-Werror=unused-parameter is stupid. Better to turn it off instead of
ugly work arounds.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-i
On Fri, Dec 27, 2013 at 11:20:26AM -0600, Felipe Balbi wrote:
> Hi,
>
> On Fri, Dec 27, 2013 at 04:11:21PM +0800, Peter Chen wrote:
> > > > > > > > Add clock enable/disable at .set_suspend if the PHY has
> > > > > > > > suspend requirement, it can be benefit of power saving for
> > > > > > > > phy
71 matches
Mail list logo
