On Fri, Dec 13, 2013 at 3:38 PM, Lothar Waßmann
wrote:
> Hi,
>
> Peter Chen wrote:
>> On Fri, Dec 13, 2013 at 3:15 PM, Lothar Waßmann
>> wrote:
>> > Hi,
>> >
>> > Peter Chen wrote:
>> >> Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add
>> >> "fsl,imx6sl-usbphy" for imx6sl.
>> >>
>> >> Signed-o
On 2013-12-12 19:01, Felipe Balbi wrote:
Hi,
On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote:
+static void gr_finish_request(struct gr_ep *ep, struct gr_request *req,
+ int status)
+{
+ struct gr_udc *dev;
+
+ list_del_init(&req->queue);
+
Hi,
Peter Chen wrote:
> On Fri, Dec 13, 2013 at 3:15 PM, Lothar Waßmann
> wrote:
> > Hi,
> >
> > Peter Chen wrote:
> >> Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add
> >> "fsl,imx6sl-usbphy" for imx6sl.
> >>
> >> Signed-off-by: Peter Chen
> >> ---
> >> Documentation/devicetree/bindings/usb
On Fri, Dec 13, 2013 at 3:15 PM, Lothar Waßmann
wrote:
> Hi,
>
> Peter Chen wrote:
>> Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add
>> "fsl,imx6sl-usbphy" for imx6sl.
>>
>> Signed-off-by: Peter Chen
>> ---
>> Documentation/devicetree/bindings/usb/mxs-phy.txt |3 ++-
>> 1 files changed,
Hi,
Peter Chen wrote:
> Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add
> "fsl,imx6sl-usbphy" for imx6sl.
>
> Signed-off-by: Peter Chen
> ---
> Documentation/devicetree/bindings/usb/mxs-phy.txt |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/devi
On Fri, Dec 13, 2013 at 12:39 PM, Felipe Balbi wrote:
> On Fri, Dec 13, 2013 at 09:23:45AM +0800, Peter Chen wrote:
>> After clear portsc.phcd, PHY needs 200us stable time for switch
>> 32K clock to AHB clock.
>>
>> Signed-off-by: Peter Chen
>> ---
>> drivers/usb/phy/phy-mxs-usb.c | 11 +++
On Fri, Dec 13, 2013 at 12:38 PM, Felipe Balbi wrote:
> On Fri, Dec 13, 2013 at 09:23:44AM +0800, Peter Chen wrote:
>> +SIMPLE_DEV_PM_OPS(mxs_phy_pm, mxs_phy_system_suspend,
>> mxs_phy_system_resume);
>
> should be static.
>
Will change.
--
BR,
Peter Chen
--
To unsubscribe from this list: send
On Fri, Dec 13, 2013 at 12:32 PM, Felipe Balbi wrote:
> On Fri, Dec 13, 2013 at 09:23:38AM +0800, Peter Chen wrote:
>> Implementation of notify_suspend and notify_resume will be different
>> according to mxs_phy_data->flags.
>>
>> Signed-off-by: Peter Chen
>> ---
>> drivers/usb/phy/phy-mxs-usb.c
On Fri, Dec 13, 2013 at 12:27 PM, Felipe Balbi wrote:
> On Fri, Dec 13, 2013 at 09:23:37AM +0800, Peter Chen wrote:
>> They are used to notify PHY that the controller enters suspend
>> or finishes resume.
>>
>> Signed-off-by: Peter Chen
>> ---
>> include/linux/usb/phy.h | 23 ++
On Fri, Dec 13, 2013 at 12:26 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Dec 13, 2013 at 09:23:36AM +0800, Peter Chen wrote:
>> @@ -226,6 +235,16 @@ static int mxs_phy_probe(struct platform_device *pdev)
>>
>> platform_set_drvdata(pdev, mxs_phy);
>>
>> + if (mxs_phy->data->flags & MXS_PHY
On Fri, Dec 13, 2013 at 12:25 PM, Felipe Balbi wrote:
> On Fri, Dec 13, 2013 at 09:23:34AM +0800, Peter Chen wrote:
>> Add anatop phandle which is used to access anatop registers to
>> control PHY's power and other USB operations.
>
> no related to this patch, but this feels like OMAP's System Con
On Fri, Dec 13, 2013 at 12:23 PM, Felipe Balbi wrote:
> On Fri, Dec 13, 2013 at 09:23:33AM +0800, Peter Chen wrote:
>> With the auto setting, the PHY's clock and power can be
>> recovered correctly from low power mode, it is ganranteed by IC logic.
>
> s/ganranteed/guaranteed
>
Will change.
> Al
On Thu, Dec 12, 2013 at 10:19:19PM -0600, Felipe Balbi wrote:
> On Fri, Dec 13, 2013 at 09:23:32AM +0800, Peter Chen wrote:
> > The mxs-phy has several bugs and features at different
> > versions, the driver code can get it through of_device_id.data.
> >
> > Signed-off-by: Peter Chen
> > ---
> >
On Thu, Dec 12, 2013 at 07:25:55PM -0800, David Cohen wrote:
> On Thu, Dec 12, 2013 at 09:01:04PM -0500, Santosh Shilimkar wrote:
> > On Thursday 12 December 2013 08:51 PM, David Cohen wrote:
> > > On Thu, Dec 12, 2013 at 08:06:24PM -0500, Santosh Shilimkar wrote:
> > >> Otherwise you get below bui
Hi,
These patches are proposal to extend the lack of #ifdef checks on PM callback
to its implementation too.
Currently SET_*_PM_OPS() macros make #ifdefs checks not necessary when setting
the callback to PM ops, but the callbacks implementation don't see same
benefit.
This RFC Solves a problem r
This patch makes SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS() more
smart.
Despite those macros check for '#ifdef CONFIG_PM_SLEEP/RUNTIME' to avoid
setting the callbacks when such #ifdef's aren't defined, they don't
handle compiler to avoid messages like that:
drivers/usb/host/xhci-plat.c:20
Current xhci_suspend() and xhci_resume() implementation in case of
CONFIG_PM not defined is buggy. If we try to use them we get the
following error:
drivers/usb/host/xhci-plat.c: In function ‘xhci_plat_suspend’:
drivers/usb/host/xhci-plat.c:205:21: error: called object ‘0u’ is not a function
drive
From: Santosh Shilimkar
Drivers using SET_*_PM_OPS() no longer need to #ifdef for CONFIG_PM_*
So, let's remove the unnecessary #ifdef's.
Signed-off-by: Santosh Shilimkar
Signed-off-by: David Cohen
---
drivers/usb/host/xhci-plat.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
di
Hi Felipe,
> -static int dwc3_exynos_suspend(struct device *dev)
> +static int __dwc3_exynos_suspend(struct dwc3_exynos *exynos)
> {
> - struct dwc3_exynos *exynos = dev_get_drvdata(dev);
> -
> clk_disable(exynos->clk);
>
> return 0;
> }
>
> +static int __dwc3_exynos_resume(str
On Fri, Dec 13, 2013 at 09:23:45AM +0800, Peter Chen wrote:
> After clear portsc.phcd, PHY needs 200us stable time for switch
> 32K clock to AHB clock.
>
> Signed-off-by: Peter Chen
> ---
> drivers/usb/phy/phy-mxs-usb.c | 11 +++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
>
On Fri, Dec 13, 2013 at 09:23:44AM +0800, Peter Chen wrote:
> +SIMPLE_DEV_PM_OPS(mxs_phy_pm, mxs_phy_system_suspend, mxs_phy_system_resume);
should be static.
--
balbi
signature.asc
Description: Digital signature
On Fri, Dec 13, 2013 at 09:23:38AM +0800, Peter Chen wrote:
> Implementation of notify_suspend and notify_resume will be different
> according to mxs_phy_data->flags.
>
> Signed-off-by: Peter Chen
> ---
> drivers/usb/phy/phy-mxs-usb.c | 55
> ++---
> 1 file
On Fri, Dec 13, 2013 at 09:23:37AM +0800, Peter Chen wrote:
> They are used to notify PHY that the controller enters suspend
> or finishes resume.
>
> Signed-off-by: Peter Chen
> ---
> include/linux/usb/phy.h | 23 +++
> 1 files changed, 23 insertions(+), 0 deletions(-)
>
Hi,
On Fri, Dec 13, 2013 at 09:23:36AM +0800, Peter Chen wrote:
> @@ -226,6 +235,16 @@ static int mxs_phy_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, mxs_phy);
>
> + if (mxs_phy->data->flags & MXS_PHY_HAS_ANATOP) {
instead of the flag, you can check if that bi
On Fri, Dec 13, 2013 at 09:23:34AM +0800, Peter Chen wrote:
> Add anatop phandle which is used to access anatop registers to
> control PHY's power and other USB operations.
no related to this patch, but this feels like OMAP's System Control
Module (a rather simplistic IP which control power for a
On Thu, Dec 12, 2013 at 10:17:19PM -0600, Felipe Balbi wrote:
> On Thu, Dec 12, 2013 at 05:56:05PM -0800, David Cohen wrote:
> > On Thu, Dec 12, 2013 at 03:38:41PM -0600, Felipe Balbi wrote:
> > > teach the PCI glue about pm_runtime so that
> > > it's easier to teach dwc3 core about it
> > > later.
On Fri, Dec 13, 2013 at 09:23:33AM +0800, Peter Chen wrote:
> With the auto setting, the PHY's clock and power can be
> recovered correctly from low power mode, it is ganranteed by IC logic.
s/ganranteed/guaranteed
Also, I think you need to be slightly more verbose here. Maybe explain a
bit what
On Fri, Dec 13, 2013 at 09:23:32AM +0800, Peter Chen wrote:
> The mxs-phy has several bugs and features at different
> versions, the driver code can get it through of_device_id.data.
>
> Signed-off-by: Peter Chen
> ---
> drivers/usb/phy/phy-mxs-usb.c | 58 ++
On Thu, Dec 12, 2013 at 05:56:05PM -0800, David Cohen wrote:
> On Thu, Dec 12, 2013 at 03:38:41PM -0600, Felipe Balbi wrote:
> > teach the PCI glue about pm_runtime so that
> > it's easier to teach dwc3 core about it
> > later.
> >
> > No functional changes otherwise.
> >
> > Signed-off-by: Felip
On Thu, Dec 12, 2013 at 09:01:04PM -0500, Santosh Shilimkar wrote:
> On Thursday 12 December 2013 08:51 PM, David Cohen wrote:
> > On Thu, Dec 12, 2013 at 08:06:24PM -0500, Santosh Shilimkar wrote:
> >> Otherwise you get below build warnings
> >>
> >> drivers/usb/host/xhci-plat.c:201:12: warning: ‘
On Thursday 12 December 2013 08:51 PM, David Cohen wrote:
> On Thu, Dec 12, 2013 at 08:06:24PM -0500, Santosh Shilimkar wrote:
>> Otherwise you get below build warnings
>>
>> drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined
>> but not used [-Wunused-function]
>> drivers/us
We need this to keep PHY's power on or off during the system
suspend mode. If we need to enable USB wakeup, then we
must keep PHY's power being on during the system suspend mode.
Otherwise, we need to keep PHY's power being off to save power.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs
After clear portsc.phcd, PHY needs 200us stable time for switch
32K clock to AHB clock.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
in
Two PHY bugs are fixed by IC logic, but these bits are not
enabled by default, so we enable them at driver.
The two bugs are: MXS_PHY_ABNORMAL_IN_SUSPEND and MXS_PHY_SENDING_SOF_TOO_FAST
which are described at code.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 23 +
Implementation of notify_suspend and notify_resume will be different
according to mxs_phy_data->flags.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 55 ++---
1 files changed, 51 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/phy/phy
The mxs-phy has several bugs and features at different
versions, the driver code can get it through of_device_id.data.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 58 ++--
1 files changed, 49 insertions(+), 9 deletions(-)
diff --git a/driv
When we need the PHY can be waken up by external signals,
we can call this API. Besides, we call mxs_phy_disconnect_line
at this API to close the connection between USB PHY and
controller, after that, the line state from controller is SE0.
Once the PHY is out of power, without calling mxs_phy_disco
It is used to access un-regulator registers according to
different controllers.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index b446cc2.
Hi Felipe & Shawn,
The serial adds power management support for MXS PHY, it includes:
- Add three common PHY APIs, .set_wakeup, .notify_suspend, notify_resume.
- Related above API implementation at mxs phy driver
- misc changes and bug fixes for mxs phy to support low power mode and wakeup.
It i
It is needed by imx6 SoC series, but not for imx23 and imx28.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 23 +--
1 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index 0c6f3bc..0
Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add
"fsl,imx6sl-usbphy" for imx6sl.
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/mxs-phy.txt |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt
b/Docume
With the auto setting, the PHY's clock and power can be
recovered correctly from low power mode, it is ganranteed by IC logic.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 20 +---
1 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/phy/
They are used to notify PHY that the controller enters suspend
or finishes resume.
Signed-off-by: Peter Chen
---
include/linux/usb/phy.h | 23 +++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h
index 6c0b1c5
Add anatop phandle for usbphy
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx6qdl.dtsi |2 ++
arch/arm/boot/dts/imx6sl.dtsi |2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 59154dc..4e74962 10
Add anatop phandle which is used to access anatop registers to
control PHY's power and other USB operations.
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings
We need to use controller id to access different register regions
for mxs phy.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx23.dtsi |1 +
arch/arm/boot/dts/imx28.dtsi |2 ++
arch/arm/boot/dts/imx6qdl.dtsi |2 ++
arch/arm/boot/dts/imx6sl.dtsi |2 ++
4 files changed, 7 i
This API is used to set wakeup enable at PHY registers, in that
case, the PHY can be waken up from suspend due to external events,
like vbus change, dp/dm change and id change.
Signed-off-by: Peter Chen
---
include/linux/usb/phy.h | 16
1 files changed, 16 insertions(+), 0 del
On Thu, Dec 12, 2013 at 03:38:41PM -0600, Felipe Balbi wrote:
> teach the PCI glue about pm_runtime so that
> it's easier to teach dwc3 core about it
> later.
>
> No functional changes otherwise.
>
> Signed-off-by: Felipe Balbi
I was able to test this one with Intel Merrifield:
Acked-by: David
On Thu, Dec 12, 2013 at 08:06:24PM -0500, Santosh Shilimkar wrote:
> Otherwise you get below build warnings
>
> drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined but
> not used [-Wunused-function]
> drivers/usb/host/xhci-plat.c:209:12: warning: ‘xhci_plat_resume’ defined b
Otherwise you get below build warnings
drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined but
not used [-Wunused-function]
drivers/usb/host/xhci-plat.c:209:12: warning: ‘xhci_plat_resume’ defined but
not used [-Wunused-function]
Cc: Sarah Sharp
Cc: Greg Kroah-Hartman
Si
On Thu, Oct 24, 2013 at 12:09:03PM -0400, Alan Stern wrote:
> On Thu, 24 Oct 2013, [iso-8859-2] J�nosi Zoli wrote:
>
> > https://bugzilla.kernel.org/show_bug.cgi?id=63611
> > �
> > Bug ID: 63611
> > Summary: cant connect sony phones in mass storage mode
>
> Is CONFIG_USB_OTG turned on in your ker
On Thu, Dec 12, 2013 at 07:29:24PM -0500, Santosh Shilimkar wrote:
> On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote:
> > A bare-minimum PM implementation which will
> > server as building block for more complex
> s/server/serve ;-)
hah! :-) will fix in my branch.
> > PM implementation
On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote:
> A bare-minimum PM implementation which will
> server as building block for more complex
s/server/serve ;-)
> PM implementation in the future.
>
> At the least will not leave clocks on unnecessarily
> when e.g. a user write mem to /sys/p
Hi Felipe
> > + chan = dma_request_slave_channel_compat(mask,
> > + shdma_chan_filter, (void *)id, dev, name);
>
> this adds a build warning:
>
> drivers/usb/renesas_usbhs/fifo.c:1012:24: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cas
On 12/12/13 4:07 PM, Matt Porter wrote:
> On Thu, Dec 12, 2013 at 03:51:31PM -0600, Dinh Nguyen wrote:
>> Hi Matt,
>>
>> On 12/12/13 7:26 AM, Matt Porter wrote:
>>> Remove unused Samsung-specific machine include and Kconfig
>>> dependency on S3C.
>>>
>>> Signed-off-by: Matt Porter
>>> Reviewed-by
On Thu, Dec 12, 2013 at 03:51:31PM -0600, Dinh Nguyen wrote:
> Hi Matt,
>
> On 12/12/13 7:26 AM, Matt Porter wrote:
> > Remove unused Samsung-specific machine include and Kconfig
> > dependency on S3C.
> >
> > Signed-off-by: Matt Porter
> > Reviewed-by: Markus Mayer
> > Reviewed-by: Tim Kryger
On Wed, 11 Dec 2013, Sarah Sharp wrote:
> Hi Hans,
>
> I've been testing the UAS code you sent a pull request for against
> 3.13-rc1, and I've run into a rather nasty issue with USB disconnect.
>
> I ran some tests with a USB 3.0 storage device under xHCI. The disk has
> three 10GB partitions:
it's best to remove all ifdefs and always
define our dev_pm-ops structure.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/core.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 74f9cf0..288e478 100644
--- a/driv
Hi Matt,
On 12/12/13 7:26 AM, Matt Porter wrote:
> Remove unused Samsung-specific machine include and Kconfig
> dependency on S3C.
>
> Signed-off-by: Matt Porter
> Reviewed-by: Markus Mayer
> Reviewed-by: Tim Kryger
> ---
> drivers/usb/gadget/Kconfig | 7 +++
> drivers/usb/gadget/s3c-h
it's best to just remove all ifdefs and always
define our dev_pm_ops structure.
Signed-off-by: Felipe Balbi
---
one more patch
drivers/usb/dwc3/dwc3-omap.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
ind
Hi,
On Thu, Dec 12, 2013 at 03:45:55PM -0600, Felipe Balbi wrote:
> +static const struct dev_pm_ops kdwc3_dev_pm_ops = {
> + .prepare= kdwc3_prepare,
> + .complete = kdwc3_complete,
> +
> + SET_SYSTEM_SLEEP_PM_OPS(kdwc3_suspend, kdwc3_resume)
> + SET_RUNTIME_PM_OPS(kd
A bare-minimum PM implementation which will
server as building block for more complex
PM implementation in the future.
At the least will not leave clocks on unnecessarily
when e.g. a user write mem to /sys/power/state.
Signed-off-by: Felipe Balbi
---
improve error path a little bit.
drivers/
On Thu, Dec 12, 2013 at 03:38:39PM -0600, Felipe Balbi wrote:
> A bare-minimum PM implementation which will
> server as building block for more complex
> PM implementation in the future.
>
> At the least will not leave clocks on unnecessarily
> when e.g. a user write mem to /sys/power/state.
>
>
If we want to suspend/runtime in runtime, we
can do so, in OMAP's case at least, with the
same implementation we use for system pm.
This patch adds basic pm_runtime support with
that in mind.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/dwc3-omap.c | 39 +++--
hi all,
these patches add pm_runtime support for all glue layers.
I plan to add pm_runtime support for dwc3 after these
patches are merged upstream.
Please test.
Felipe Balbi (7):
usb: dwc3: keystone: add basic PM support
usb: dwc3: omap: add basic pm_runtime support
usb: dwc3: pci: add p
even if pm_runtime_get*() fails, it still increments
pm usage counter, so we must pm_runtime_put*()
in that case too. Fix that observation in dwc3-omap.c.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/dwc3-omap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/u
it's best to just remove all ifdefs and always
define our dev_pm_ops structure.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/dwc3-exynos.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index 8b20c70.
teach Exynos glue about pm_runtime so that
it's easier to teach dwc3 core about it
later.
No functional changes otherwise.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/dwc3-exynos.c | 65 --
1 file changed, 56 insertions(+), 9 deletions(-)
diff --git
A bare-minimum PM implementation which will
server as building block for more complex
PM implementation in the future.
At the least will not leave clocks on unnecessarily
when e.g. a user write mem to /sys/power/state.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/dwc3-keystone.c | 97 +
teach the PCI glue about pm_runtime so that
it's easier to teach dwc3 core about it
later.
No functional changes otherwise.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/dwc3-pci.c | 66 ++---
1 file changed, 51 insertions(+), 15 deletions(-)
diff --g
pm_runtime_put_sync() will kill dwc3's clocks and,
since dwc3 core accesses registers during removal,
we must make sure to unregister core before
disabling clocks and pm_runtime.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/dwc3-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
Hi Grazvydas,
Von: Grazvydas Ignotas [mailto:nota...@gmail.com]
Gesendet: Donnerstag, 12. Dezember 2013 01:21
An: linux-usb@vger.kernel.org
Cc: Felipe Balbi; linux-o...@vger.kernel.org; Naumann Andreas; Grazvydas
Ignotas; sta...@vger.kernel.org
Betreff: [PATCH] usb: musb: omap2430: fix occasion
On Thu, Dec 12 2013, Felipe Balbi wrote:
> use NULL when returning NULL pointers, not 0.
>
> Signed-off-by: Felipe Balbi
Acked-by: Michal Nazarewicz
> ---
> drivers/usb/gadget/f_fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/f_fs.c b/drivers/us
Hi,
On Thu, Dec 12, 2013 at 02:49:22PM -0500, WingMan Kwok wrote:
> +static int kdwc3_remove(struct platform_device *pdev)
> +{
> + struct dwc3_keystone *kdwc = platform_get_drvdata(pdev);
> +
> + kdwc3_disable_irqs(kdwc);
> + device_for_each_child(&pdev->dev, NULL, kdwc3_remove_core);
On Thursday 12 December 2013 02:41 PM, Felipe Balbi wrote:
> On Thu, Dec 12, 2013 at 02:36:01PM -0500, Santosh Shilimkar wrote:
>> On Thursday 12 December 2013 12:48 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Tue, Dec 10, 2013 at 10:11:36AM -0500, Santosh Shilimkar wrote:
>> +static int kdwc3_r
Add Keystone platform specific glue layer to support
USB3 Host mode.
Cc: Santosh Shilimkar
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Acked-by: Santosh Shilimkar
Signed-off-by: WingMan Kwok
---
v4->v5: Moved clk_disable after removing core.
drivers/usb/dwc3/Kconfig |7 ++
drivers/
On Thu, Dec 12, 2013 at 02:36:01PM -0500, Santosh Shilimkar wrote:
> On Thursday 12 December 2013 12:48 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Dec 10, 2013 at 10:11:36AM -0500, Santosh Shilimkar wrote:
> +static int kdwc3_remove(struct platform_device *pdev)
> +{
> +
On Thursday 12 December 2013 12:48 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Dec 10, 2013 at 10:11:36AM -0500, Santosh Shilimkar wrote:
+static int kdwc3_remove(struct platform_device *pdev)
+{
+ struct dwc3_keystone *kdwc = platform_get_drvdata(pdev);
+
+ kdwc3_disable_
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Robert Baldyga
> Sent: Thursday, December 12, 2013 12:51 AM
>
> This patch adds "maxpacket_limit" to struct usb_ep. This field contains
> maximum value of maxpacket supported by driver, and is set in d
In case pm_runtime_get*() fails, it still
increments pm usage counter, so we *must*
make sure to pm_runtime_put() even in those
cases.
This patch fixes that mistake the same way
usbcore treats those possible failures.
Signed-off-by: Felipe Balbi
---
drivers/phy/phy-core.c | 12 ++--
1 f
On Mon, Dec 09, 2013 at 10:52:45AM +0200, Heikki Krogerus wrote:
> Hi,
>
> On Fri, Dec 06, 2013 at 02:15:30PM -0600, Felipe Balbi wrote:
> > On Tue, Dec 03, 2013 at 12:39:50PM +0200, Heikki Krogerus wrote:
> > > On Thu, Oct 17, 2013 at 09:54:26AM -0500, Felipe Balbi wrote:
> > > > On Wed, Oct 16,
On Thu, Dec 12, 2013 at 09:51:24AM +0100, Robert Baldyga wrote:
> This patch adds "maxpacket_limit" to struct usb_ep. This field contains
> maximum value of maxpacket supported by driver, and is set in driver probe.
> This value should be used by autoconfig() function, because value of field
> "max
On Thu, Dec 12, 2013 at 08:26:03AM -0500, Matt Porter wrote:
> dwc2/s3c-hsotg require a single clock to be specified and optionally
> a generic phy. On the s3c-hsotg driver old style USB phy support is
> present as a fallback so the generic phy properties are optional.
>
> Signed-off-by: Matt Port
Hi,
On Thu, Dec 12, 2013 at 08:26:02AM -0500, Matt Porter wrote:
> This adds a pair of APIs that allows the generic PHY subsystem to
> provide information on the PHY bus width. The PHY provider driver may
> use phy_set_bus_width() to set the bus width that the PHY supports.
> The controller driver
On Thu, Dec 12, 2013 at 12:16:31PM -0600, Felipe Balbi wrote:
> use NULL when returning NULL pointers, not 0.
>
> Signed-off-by: Felipe Balbi
> ---
> drivers/usb/gadget/f_fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget
use NULL when returning NULL pointers, not 0.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/f_fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c
index 12a64e1..306a2b5 100644
--- a/drivers/usb/gadget/f_fs.c
+++ b/dr
On Tue, Dec 10, 2013 at 07:09:19PM -0800, Kuninori Morimoto wrote:
> From: Kuninori Morimoto
>
> Remove original filter from usbhsf_dma_init(),
> and use SH-DMA suitable filter.
>
> Signed-off-by: Kuninori Morimoto
> ---
> drivers/usb/renesas_usbhs/fifo.c | 76
> +++-
Hi,
On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote:
> +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req,
> + int status)
> +{
> + struct gr_udc *dev;
> +
> + list_del_init(&req->queue);
> +
> + if (likely(req->req.status
Thanks for the quick response. I think we can use the extcon framework for our
events. The usb_phy_vbus_on/off() can probably be handled with the extcon
events. Right now we register gadget->vbus_draw with our usb_phy_set_power().
I don't see how the generic phy handles this. Also we use
u
Hi,
On Tue, Dec 10, 2013 at 10:11:36AM -0500, Santosh Shilimkar wrote:
> >> +static int kdwc3_remove(struct platform_device *pdev)
> >> +{
> >> + struct dwc3_keystone *kdwc = platform_get_drvdata(pdev);
> >> +
> >> + kdwc3_disable_irqs(kdwc);
> >> + clk_disable_unprepare(kdwc->clk);
> >
> > I
On Thu, Dec 12, 2013 at 11:20:54AM -0600, Kwok, WingMan wrote:
> > -Original Message-
> > From: Shilimkar, Santosh
> > Sent: Tuesday, December 10, 2013 10:15 AM
> > To: Balbi, Felipe
> > Cc: Kwok, WingMan; linux-usb@vger.kernel.org; linux-arm-
> > ker...@lists.infradead.org; Greg Kroah-Hart
Hi,
On Thu, Dec 12, 2013 at 12:25:29PM -0500, WingMan Kwok wrote:
> +static int kdwc3_remove(struct platform_device *pdev)
> +{
> + struct dwc3_keystone *kdwc = platform_get_drvdata(pdev);
> +
> + kdwc3_disable_irqs(kdwc);
> + clk_disable_unprepare(kdwc->clk);
isn't this same clock fe
Resending the series with suggested minor updates from v3 [1].
Series adds USB host support for Keystone SOCs. Keystone SOCs
uses dwc3 hardware IP implementation. On Keystone II platforms,
we use no-op phy driver.
Patchset are tested on Keystone II EVM with USB2.0 and USB3.0
flash drives along w
Add Keystone platform USB PHY driver support. Current main purpose
of this driver is to enable the PHY reference clock gate on the
Keystone SoC. Otherwise it is a nop PHY.
Cc: Santosh Shilimkar
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Acked-by: Santosh Shilimkar
Signed-off-by: WingMan Kwok
---
Add Keystone platform specific glue layer to support
USB3 Host mode.
Cc: Santosh Shilimkar
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Acked-by: Santosh Shilimkar
Signed-off-by: WingMan Kwok
---
drivers/usb/dwc3/Kconfig |7 ++
drivers/usb/dwc3/Makefile|1 +
drivers/usb/dw
> -Original Message-
> From: Quadros, Roger
> Sent: Monday, December 09, 2013 10:09 PM
> To: Kwok, WingMan; linux-usb@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org; Shilimkar, Santosh; Balbi, Felipe;
> Greg Kroah-Hartman
> Subject: Re: [PATCH v3 2/2] usb: phy: Add keystone us
> -Original Message-
> From: Shilimkar, Santosh
> Sent: Tuesday, December 10, 2013 10:15 AM
> To: Balbi, Felipe
> Cc: Kwok, WingMan; linux-usb@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; Greg Kroah-Hartman
> Subject: Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver
>
On Wed, 11 Dec 2013, Julius Werner wrote:
> >> ...although, the spec says that it does not wait for the port resets
> >> to complete. As far as I can see re-issuing a warm reset and waiting
> >> is the only way to guarantee the core times the recovery. Presumably
> >> the portstatus debounce in
On Fri, Dec 06, 2013 at 02:35:23PM -0600, Felipe Balbi wrote:
> Hi,
>
> On Fri, Dec 06, 2013 at 01:03:44PM +0100, Robert Baldyga wrote:
> > This patch set maximum possible maxpacket value for each speed. Previous
> > values didn't allow to use maxpacket sizes greater than 64 in full speed
> > and
Changes since v4:
- phy_set/get_bus_width now use an int for bus_width
Changes since v3:
- Rebased on 3.13-rc3
- Move struct phy bus_width attribute back into struct phy_attrs
- Fix build issue on !GENERIC_PHY
- Update dwc2 binding to reflect optional phy pr
1 - 100 of 123 matches
Mail list logo
