Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-11 Thread Julius Werner
>> ...although, the spec says that it does not wait for the port resets >> to complete. As far as I can see re-issuing a warm reset and waiting >> is the only way to guarantee the core times the recovery. Presumably >> the portstatus debounce in hub_activate() mitigates this, but that >> 100ms is

Re: Generic phy framework

2013-12-11 Thread Kishon Vijay Abraham I
Hi, On Thursday 12 December 2013 03:27 AM, Graham Williams wrote: > Hi Kishon, > > I see you have added this new generic phy framework. The usb phy framework > contains a struct notifier_block to send usb specific events like > USB_EVENT_ID. Will this new generic phy support notifications lik

Re: [PATCH 0/4] Bugfixes for UVC gadget test application

2013-12-11 Thread Laurent Pinchart
Hi Robert, [Repost with Bhupesh's hopefully correct e-mail address] On Tuesday 10 December 2013 12:40:33 Robert Baldyga wrote: > Hello, > > This patchset fixes UVC gadget test application, created by Laurent Pinchart > (git tree available here: git://git.ideasonboard.org/uvc-gadget.git), with >

Re: [PATCH 0/4] Bugfixes for UVC gadget test application

2013-12-11 Thread Laurent Pinchart
Hi Robert, On Tuesday 10 December 2013 12:40:33 Robert Baldyga wrote: > Hello, > > This patchset fixes UVC gadget test application, created by Laurent Pinchart > (git tree available here: git://git.ideasonboard.org/uvc-gadget.git), with > applied patches created by Bhupesh Sharma (which can be fo

Re: [PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-11 Thread David Cohen
On Thu, Dec 12, 2013 at 02:20:59AM +0200, Grazvydas Ignotas wrote: > This is a hard to reproduce problem which leads to non-functional > USB-OTG port in 0.1%-1% of all boots. Tracked it down to commit > e25bec160158abe86c "omap2+: save and restore OTG_INTERFSEL", > which introduces save/restore of

[PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-11 Thread Grazvydas Ignotas
This is a hard to reproduce problem which leads to non-functional USB-OTG port in 0.1%-1% of all boots. Tracked it down to commit e25bec160158abe86c "omap2+: save and restore OTG_INTERFSEL", which introduces save/restore of OTG_INTERFSEL over suspend. Since the resume function is also called early

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-11 Thread Dan Williams
On Wed, Dec 11, 2013 at 2:51 PM, Dan Williams wrote: > On Wed, Dec 11, 2013 at 11:36 AM, Sarah Sharp > wrote: >> On Wed, Dec 11, 2013 at 11:00:13AM -0800, Julius Werner wrote: >>> > I don't know what you mean by "fails". The system goes to sleep and >>> > then later on wakes up, doesn't it? >>>

Re: BTRFS doesn't handle USB device disconnect

2013-12-11 Thread Sarah Sharp
On Wed, Dec 11, 2013 at 11:03:09AM -0500, Alan Stern wrote: > On Tue, 10 Dec 2013, Sarah Sharp wrote: > > On 3.13-rc1, the btrfs partion from the disconnected USB device > > continues to be listed as mounted. Yanking the cable produces some > > additional oops messages. It also produced a couple

Re: [PATCH 05/12] USB: ohci-at91: Use devm_*() functions

2013-12-11 Thread Jingoo Han
On Wednesday, December 11, 2013 5:13 PM, Nicolas Ferre wrote: > On 11/12/2013 08:31, Jingoo Han : > > Use devm_*() functions to make cleanup paths simpler. > > > > Signed-off-by: Jingoo Han > > Jingoo, > > Well, these modifications are already addressed by a series written by > Boris. > "[PATCH

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-11 Thread Dan Williams
On Wed, Dec 11, 2013 at 11:36 AM, Sarah Sharp wrote: > On Wed, Dec 11, 2013 at 11:00:13AM -0800, Julius Werner wrote: >> > I don't know what you mean by "fails". The system goes to sleep and >> > then later on wakes up, doesn't it? >> > >> > Do you mean that the Jetflash device gets disconnected

Generic phy framework

2013-12-11 Thread Graham Williams
Hi Kishon, I see you have added this new generic phy framework.  The usb phy framework contains a struct notifier_block to send usb specific events like USB_EVENT_ID.  Will this new generic phy support notifications like the usb phy?  Also will set_power() and set_vbus() ops get added?  Or shou

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-11 Thread Sarah Sharp
On Wed, Dec 11, 2013 at 11:00:13AM -0800, Julius Werner wrote: > > I don't know what you mean by "fails". The system goes to sleep and > > then later on wakes up, doesn't it? > > > > Do you mean that the Jetflash device gets disconnected when the system > > wakes up? That's _supposed_ to happen u

Re: [PATCH v2] usb: core: Make sure usb_set_configuration(-1) cannot fail

2013-12-11 Thread Julius Werner
> Sorry for not getting back to this sooner. Ironically, it looks like > this change isn't needed any more, thanks to Thomas Pugliese's patch: > > http://marc.info/?l=linux-usb&m=13866180520&w=2 Yes... thanks for pointing it out, that would make this patch obsolete. I'll wait a few da

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-11 Thread Julius Werner
> I don't know what you mean by "fails". The system goes to sleep and > then later on wakes up, doesn't it? > > Do you mean that the Jetflash device gets disconnected when the system > wakes up? That's _supposed_ to happen under those circumstances. > When hub_activate() sees HUB_RESET_RESUME, al

Re: [PATCH 01/12] USB: ehci-orion: Use devm_*() functions

2013-12-11 Thread Jason Cooper
On Wed, Dec 11, 2013 at 04:16:33PM +0900, Jingoo Han wrote: > Use devm_*() functions to make cleanup paths simpler. > > Signed-off-by: Jingoo Han > --- > drivers/usb/host/ehci-orion.c | 43 > - > 1 file changed, 12 insertions(+), 31 deletions(-) Acked-

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-11 Thread Alan Stern
On Tue, 10 Dec 2013, Vikas Sajjan wrote: > > Finally, I don't see why you put this in hub_activate(). Isn't it more > > closely connected with the reset-resume procedure for the child device? > > > I was trying to add a FIX in usb_port_resume(), but in our case we > have CONFIG_USB_DEFAULT_PERS

Re: [PATCH 1/1] AX88179_178A: Enable the hardware pseudo header in case of the NET_IP_ALIGN equals 0

2013-12-11 Thread David Miller
From: Freddy Xin Date: Wed, 11 Dec 2013 14:17:59 +0800 > I think there is no way of undoing the reservation in the driver. Then you should add a flag that, indeed, tells usbnet not to do the reservation in the first place. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" i

Re: [PATCH v2] usb: core: Make sure usb_set_configuration(-1) cannot fail

2013-12-11 Thread Alan Stern
On Thu, 5 Dec 2013, Julius Werner wrote: > usb_deauthorize_device() tries to unset the configuration of a USB > device and then unconditionally blows away the configuration descriptors > with usb_destroy_configuration(). This is bad if the > usb_set_configuration() call failed before the configura

Re: BTRFS doesn't handle USB device disconnect

2013-12-11 Thread Hugo Mills
On Wed, Dec 11, 2013 at 11:03:09AM -0500, Alan Stern wrote: > On Tue, 10 Dec 2013, Sarah Sharp wrote: > > > In order to stress test the uas driver (next-gen USB storage driver), I > > decided to run some tests with a USB 3.0 storage device with four 10GB > > partitions: BTRFS, ext3, ext4, and fat3

Re: uhci_hcd: Possible corruption of DMA pool uhci->td_pool

2013-12-11 Thread Alan Stern
On Wed, 11 Dec 2013, Eugene Shatokhin wrote: > Hi, > > On ROSA Linux with kernel 3.10.21 with DMA debug options enabled, the > kernel sometimes issues a warning about DMA pool corruption (see the log > below). > > That happens sometimes, when the system boots or resumes from > hibernation wit

Re: [PATCH] USB: gadget: add "maxpacket_limit" field to struct usb_ep

2013-12-11 Thread Alan Stern
On Wed, 11 Dec 2013, Robert Baldyga wrote: > This patch adds "maxpacket_limit" to struct usb_ep. This field contains > maximum value of maxpacket supported by driver, and is set in driver probe. > This value should be used by autoconfig() function, because value of field > "maxpacket" is set to va

Re: BTRFS doesn't handle USB device disconnect

2013-12-11 Thread Alan Stern
On Tue, 10 Dec 2013, Sarah Sharp wrote: > In order to stress test the uas driver (next-gen USB storage driver), I > decided to run some tests with a USB 3.0 storage device with four 10GB > partitions: BTRFS, ext3, ext4, and fat32. > > It seems that BTRFS doesn't handle unexpected USB disconnect v

Re: [PATCH v4 5/9] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework

2013-12-11 Thread Matt Porter
On Thu, Dec 05, 2013 at 01:29:35PM +0100, Kamil Debski wrote: > Change the used phy driver to the new Exynos USB phy driver that uses the > generic phy framework. > > Signed-off-by: Kamil Debski > Signed-off-by: Kyungmin Park > --- > .../devicetree/bindings/usb/samsung-hsotg.txt |4 +++

uhci_hcd: Possible corruption of DMA pool uhci->td_pool

2013-12-11 Thread Eugene Shatokhin
Hi, On ROSA Linux with kernel 3.10.21 with DMA debug options enabled, the kernel sometimes issues a warning about DMA pool corruption (see the log below). That happens sometimes, when the system boots or resumes from hibernation with Samson C01U USB microphone attached. The affected DMA po

[PATCH] USB: gadget: add "maxpacket_limit" field to struct usb_ep

2013-12-11 Thread Robert Baldyga
This patch adds "maxpacket_limit" to struct usb_ep. This field contains maximum value of maxpacket supported by driver, and is set in driver probe. This value should be used by autoconfig() function, because value of field "maxpacket" is set to value from endpoint descriptor when endpoint becomes e

RE: [PATCH 1/1] AX88179_178A: Enable the hardware pseudo header in case of the NET_IP_ALIGN equals 0

2013-12-11 Thread David Laight
> From: Freddy Xin > On 2013年12月10日 09:01, David Miller wrote: > > From: fre...@asix.com.tw > > Date: Fri, 6 Dec 2013 17:58:18 +0800 > > > >> From: Freddy Xin > >> > >> The AX88179_178A has a hardware feature that it can insert a 2-bytes pseudo > >> header in front of each received frame by setti

Re: [PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state

2013-12-11 Thread Ivan T. Ivanov
Hi, On Wed, 2013-12-04 at 21:38 +0800, Peter Chen wrote: > On Wed, Dec 04, 2013 at 11:35:54AM +0200, Ivan T. Ivanov wrote: > > > > Hi Peter, > > > > On Wed, 2013-12-04 at 13:37 +0800, Peter Chen wrote: > > > On Mon, Nov 11, 2013 at 04:36:09PM +0200, Ivan T. Ivanov wrote: > > > > > > > > Hi

Re: [PATCH v4 01/15] usb: phy: msm: Move mach dependent code to platform data

2013-12-11 Thread Ivan T. Ivanov
On Tue, 2013-11-12 at 16:51 +0200, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > This patch fix compilation error when driver is compiled > in multi-platform builds. > > drivers/built-in.o: In function `msm_otg_link_clk_reset': > ./drivers/usb/phy/phy-msm-usb.c:314: undefined reference to

Re: [PATCH v4 10/15] usb: phy: msm: Add device tree support and binding information

2013-12-11 Thread Ivan T. Ivanov
Hi, On Thu, 2013-12-05 at 10:41 +, Mark Rutland wrote: > On Mon, Nov 18, 2013 at 12:54:37PM +, Ivan T. Ivanov wrote: > > Hi Mark, > > > > On Fri, 2013-11-15 at 16:38 +, Mark Rutland wrote: > > > On Tue, Nov 12, 2013 at 02:51:45PM +, Ivan T. Ivanov wrote: > > > > From: "Ivan T.

Re: [PATCH v3 04/10] usb: dwc3: use quirks to know if a particualr platform doesn't have PHY

2013-12-11 Thread Kishon Vijay Abraham I
On Wednesday 11 December 2013 02:23 PM, Heikki Krogerus wrote: > Hi, > > On Mon, Dec 09, 2013 at 11:26:04AM +0200, Heikki Krogerus wrote: >> Can you guys explain why is something like this needed? Like with >> clocks and gpios, the device drivers shouldn't need to care any more >> if t

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Heikki Krogerus
Hi again, On Wed, Dec 11, 2013 at 02:02:43PM +0530, Vivek Gautam wrote: > On Wed, Dec 11, 2013 at 1:39 PM, Heikki Krogerus > wrote: > > On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: > >> On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus > >> > I think "setup" instead of "tune" is m

Re: [PATCH v3 04/10] usb: dwc3: use quirks to know if a particualr platform doesn't have PHY

2013-12-11 Thread Heikki Krogerus
Hi, On Mon, Dec 09, 2013 at 11:26:04AM +0200, Heikki Krogerus wrote: > > >>>Can you guys explain why is something like this needed? Like with > > >>>clocks and gpios, the device drivers shouldn't need to care any more > > >>>if the platform has the phys or not. -ENODEV tells you your platform > >

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Vivek Gautam
Hi Kishon, On Wed, Dec 11, 2013 at 1:47 PM, Kishon Vijay Abraham I wrote: > On Wednesday 11 December 2013 12:08 PM, Vivek Gautam wrote: >> Hi, >> >> >> On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus >> wrote: >>> Hi, >> >> Thanks for reviewing this. >> >>> >>> On Tue, Dec 10, 2013 at 04:25:23

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Vivek Gautam
Hi, On Wed, Dec 11, 2013 at 1:39 PM, Heikki Krogerus wrote: > Hi, > > On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: >> On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus >> > I think "setup" instead of "tune" is much more clear and reusable. >> >> I think "setup" will look more lik

Re: [PATCH v4 12/15] usb: phy: msm: Add support for secondary PHY control

2013-12-11 Thread Ivan T. Ivanov
Hi, On Thu, 2013-12-05 at 10:42 +, Mark Rutland wrote: > On Mon, Nov 18, 2013 at 12:57:42PM +, Ivan T. Ivanov wrote: > > > > Hi Mark, > > > > On Fri, 2013-11-15 at 16:42 +, Mark Rutland wrote: > > > On Tue, Nov 12, 2013 at 02:51:47PM +, Ivan T. Ivanov wrote: > > > > From: "Iva

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Kishon Vijay Abraham I
On Wednesday 11 December 2013 12:08 PM, Vivek Gautam wrote: > Hi, > > > On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus > wrote: >> Hi, > > Thanks for reviewing this. > >> >> On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote: >>> Some PHY controllers may need to tune PHY post-initi

Re: [PATCH 05/12] USB: ohci-at91: Use devm_*() functions

2013-12-11 Thread Nicolas Ferre
On 11/12/2013 08:31, Jingoo Han : Use devm_*() functions to make cleanup paths simpler. Signed-off-by: Jingoo Han Jingoo, Well, these modifications are already addressed by a series written by Boris. "[PATCH v5 0/3] usb: ohci-at91: various improvements" Thanks for your patch anyway. Bes

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Heikki Krogerus
Hi, On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: > On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus > > I think "setup" instead of "tune" is much more clear and reusable. > > I think "setup" will look more like first time setting up the phy, > which is rather served by "init" cal