Hi,
On Thu, Dec 05, 2013 at 12:04:46PM +0530, Kishon Vijay Abraham I wrote:
> On Wednesday 04 December 2013 08:10 PM, Heikki Krogerus wrote:
> > On Mon, Nov 25, 2013 at 03:31:24PM +0530, Kishon Vijay Abraham I wrote:
> >> There can be systems which does not have an external phy, so get
> >> phy on
Due to imx28 needs ARM swp instruction for writing, we set
CI_HDRC_IMX28_WRITE_FIX for imx28.
Signed-off-by: Peter Chen
Signed-off-by: Marc Kleine-Budde
Tested-by: Marc Kleine-Budde
---
drivers/usb/chipidea/ci_hdrc_imx.c | 32 ++--
1 files changed, 26 insertions(+
According to Freescale imx28 Errata, "ENGR119653 USB: ARM to USB
register error issue", All USB register write operations must
use the ARM SWP instruction. So, we implement a special ehci_write
for imx28.
Discussion for it at below:
http://marc.info/?l=linux-usb&m=137996395529294&w=2
Signed-off-b
If we connect Male-A-To-Male-A cable between otg-host and host pc,
the ci->vbus_active is set wrongly, and cause the controller run
at peripheral mode when we load gadget module (ci_udc_start will be run),
but the software runs at host mode due to id = 0. The ehci_irq
can't handle suspend (USBi_SLI
From: Chris Ruehl
* init the sts flag to 0 (missed)
* fix write the real bit not sts value
* Set PORTCS_STS and DEVLC_STS only if sts = 1
Signed-off-by: Chris Ruehl
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/core.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
dif
According to Freescale imx28 Errata, "ENGR119653 USB: ARM to USB
register error issue", All USB register write operations must
use the ARM SWP instruction. So, we implement special hw_write
and hw_test_and_clear for imx28.
Discussion for it at below:
http://marc.info/?l=linux-usb&m=137996395529294
From: Fabio Estevam
Commit 40ed51a4b (usb: chipidea: host: add vbus regulator
control) introduced a smatch complaint because regulator_disable() is called
without checking whether ci->platdata->reg_vbus is not NULL.
Fix this by adding the check.
This patch is needed for 3.12 stable
Cc: stable
From: Chris Ruehl
hw_phymode_configure configures the PORTSC registers and allow the
following phy_inits to operate on the right parameters. This fix a problem
where the UPLI (ISP1504) could not be detected, because the Viewport was not
available and read the viewport return 0's only.
Signed-off
Hi Greg,
This patchset includes chipidea fixes for 3.13-rc2, the mainly
fixes include add correct imx28 write register method, fixing
un-initialized variable, etc.
Chris Ruehl (2):
usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag
usb: chipidea: put hw_phymode_configure be
From: Daniel Tang
The device tree binding chosen for the nspire-usb driver was inappropriate and
should be renamed to lsi,zevio-usb.
References to nspire have been replaced with zevio (the SoC name)
Signed-off-by: Daniel Tang
---
.../devicetree/bindings/usb/ci-hdrc-nspire.txt | 17 -
Hi,
On Wednesday 04 December 2013 08:10 PM, Heikki Krogerus wrote:
> Hi guys,
>
> Kishon, sorry I did not see this v3 set.
>
> On Mon, Nov 25, 2013 at 03:31:24PM +0530, Kishon Vijay Abraham I wrote:
>> There can be systems which does not have an external phy, so get
>> phy only if no quirks are
Hi,
On 05/12/2013, at 12:44 AM, Peter Chen wrote:
>
> lsi is vendor name, what are zevio and nspire?
> Usually, the compatible string should be "vendor_name,soc_name-module_name"
>
Because this port uses documentation from reverse engineering, it's difficult
to work out what is SoC specific
Hi,
On 04/12/2013, at 11:18 PM, Mark Rutland wrote:
>>
>>
>> Required properties:
>> -- compatible: Should be "zevio,nspire-usb"
>> +- compatible: Should be "lsi,nspire-usb"
>
> Surely this should be lsi,zevio-usb, matching the lsi,zevio-timer
> binding?
You're right. I'll fix up the patch a
> Instead, how about changing usb_set_configuration() so that it will
> never fail when the new config is -1? Except perhaps for -ENODEV
> errors (the device has been disconnected), which
> usb_deauthorize_device() could check for.
Yes, that should work as well. It's really just one autoresume an
On Wednesday, December 04, 2013 05:49 PM, Heikki Krogerus wrote:
Hi Chris,
On Wed, Dec 04, 2013 at 03:16:21PM +0800, Chris Ruehl wrote:
On Tuesday, December 03, 2013 04:15 PM, Heikki Krogerus wrote:
On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote:
@@ -154,6 +164,27 @@ int usb_ph
On Tue, Dec 03, 2013 at 02:18:57PM +0100, David Cluytens wrote:
> Signed-off-by: David Cluytens
> ---
> drivers/usb/class/cdc-acm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Yeah, that finally worked !
Now applied, thanks.
greg k-h
--
To unsubscribe from this list: send the line "unsubscrib
On Sat, Nov 30, 2013 at 11:51:31PM +0100, Gerhard Sittig wrote:
> after device tree based clock lookup became available, the peripheral
> driver need no longer construct clock names which include the component
> index -- remove the "usb%d_clk" template, always use "ipg" instead
>
> Cc: Greg Kroah-
We have already renamed the file name, change doc name at this
patch.
Cc: devicet...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Peter Chen
---
.../usb/{ci13xxx-imx.txt => ci-hdrc-imx.txt} |0
1 files changed, 0 insertions(+), 0 deletions(-)
rename Documentation/devic
We have already renamed the file name, change doc name at this
patch.
Cc: devicet...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Peter Chen
---
.../usb/{ci13xxx-imx.txt => ci-hdrc-imx.txt} |0
1 files changed, 0 insertions(+), 0 deletions(-)
rename Documentation/devic
I'm okay with these patches. No need to resend to the USB Storage
list, tho I would appreciate such in the future.
Acked-By: Matthew Dharm
Matt
On Wed, Dec 4, 2013 at 3:58 PM, Sarah Sharp
wrote:
> On Mon, Nov 18, 2013 at 03:39:05PM +0100, Hans de Goede wrote:
>> Hi Sarah et al,
>
> Hi Hans,
>
On Tue, Nov 19, 2013 at 02:53:22PM +, Cortes, Alexis wrote:
> Hi Sarah,
>
> Sorry for my delayed response, I just saw your e-mail (it got filtered
> somehow). About your question: actually I'm not sure, I'll have to check that
> to confirm it. I'll get back to you with an answer as soon as
On Mon, Nov 18, 2013 at 03:39:05PM +0100, Hans de Goede wrote:
> Hi Sarah et al,
Hi Hans,
> Here is v3 of my patch-series / pull-req for you to pull into your xhci tree
> for 3.14.
I was just about to start testing the code I merged from you, when I
realized the last round of patches didn't Cc t
Hello, Josh.
On Wed, Dec 04, 2013 at 05:01:53PM -0600, Josh Hunt wrote:
> So there used to be a call to async_synchronize_full() in
> ata_host_register(), but it was removed by
> f29d3b23238e1955a8094e038c72546e99308e61 as part of some fastboot
> changes. Adding it back (in the attached patch) see
On Tue, Dec 3, 2013 at 9:19 AM, Tejun Heo wrote:
> Hello,
>
> On Tue, Dec 03, 2013 at 08:28:43AM -0600, Josh Hunt wrote:
>> You're right. Thanks for pointing this out. I did not realize there
>> was a bug in the init script. The version of initramfs-tools I was
>> using had the following bug:
>> h
On Wed, 4 Dec 2013, Kumar Gokhare wrote:
> Hi Alan,
>
> Thanks for your response.
>
> It seems that in my case, the root hub is getting this disconnect
> event which is disconnecting all devices.
> Could you point me which kernel module raises these event and if any
> debugs I can turn on in the
Here is the updated version of the series which addresses comments from
earlier version [1]. The PHY register programming is moved to a separate
PHY driver.
Series adds USB host support for Keystone SOCs. Keystone SOCs uses dwc3
hardware IP implementation. On Keystone II platforms, we use no-op
Added device tree support for TI's Keystone USB PHY driver and updated the
Documentation with device tree binding information.
Cc: Santosh Shilimkar
Signed-off-by: WingMan Kwok
---
.../devicetree/bindings/usb/keystone-phy.txt | 19 +++
arch/arm/boot/dts/keystone.dtsi
Enable the USB support (Host mode only) on TI's Keystone platform.
It also enables the support of usb mass storage, FAT and Ext4
filesystems to test rootfs mount over an USB disk.
Cc: Santosh Shilimkar
Signed-off-by: WingMan Kwok
---
arch/arm/configs/keystone_defconfig | 20 ++
Add Keystone platform specific glue layer to support
USB3 Host mode.
Cc: Santosh Shilimkar
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Signed-off-by: WingMan Kwok
---
drivers/usb/dwc3/Kconfig |7 ++
drivers/usb/dwc3/Makefile|1 +
drivers/usb/dwc3/dwc3-keystone.c | 210 +++
Added device tree support for TI's Keystone USB driver and updated the
Documentation with device tree binding information.
Cc: Santosh Shilimkar
Signed-off-by: WingMan Kwok
---
.../devicetree/bindings/usb/keystone-usb.txt | 41
arch/arm/boot/dts/keystone.dtsi
Add Keystone platform USB PHY driver support. Current main purpose
of this driver is to enable the PHY reference clock gate on the
Keystone SoC. Otherwise it is a nop PHY.
Cc: Santosh Shilimkar
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Signed-off-by: WingMan Kwok
---
drivers/usb/phy/Kconfig
On 12/04/2013 07:58 PM, Sebastian Andrzej Siewior wrote:
> * Daniel Mack | 2013-12-04 18:22:24 [+0100]:
>
>> cdd->cd and cdd->descs_phys are allocated DESCS_AREAS times from
>> init_descs() and freed as often from purge_descs(). This leads to both
>> memory leaks and double-frees.
>>
>> Fix this b
On 12/04/2013 07:58 PM, Sebastian Andrzej Siewior wrote:
> * Daniel Mack | 2013-12-04 18:22:24 [+0100]:
>
>> cdd->cd and cdd->descs_phys are allocated DESCS_AREAS times from
>> init_descs() and freed as often from purge_descs(). This leads to both
>> memory leaks and double-frees.
>>
>> Fix this b
* Daniel Mack | 2013-12-04 18:22:24 [+0100]:
>cdd->cd and cdd->descs_phys are allocated DESCS_AREAS times from
>init_descs() and freed as often from purge_descs(). This leads to both
>memory leaks and double-frees.
>
>Fix this by pulling the calls to dma_{alloc,free}_coherent() out of the
>loops.
cdd->cd and cdd->descs_phys are allocated DESCS_AREAS times from
init_descs() and freed as often from purge_descs(). This leads to both
memory leaks and double-frees.
Fix this by pulling the calls to dma_{alloc,free}_coherent() out of the
loops.
While at it, remove the intermediate variable mem_d
On 12/04/2013 12:51 PM, Steve Cotton wrote:
> On Wed, Dec 04, 2013 at 11:21 +0100, Daniel Mack wrote:
>> While at it, remove the intermediate variable mem_decs (I guess it was
>> only there to make the code comply to the 80-chars CodingSytle rule).
>
> purge_descs() still has a (now unused) mem_de
2013/12/4 Douglas Gilbert :
> On 13-12-04 04:21 PM, Alan Stern wrote:
>>
>> On Wed, 4 Dec 2013, boris brezillon wrote:
>>
The patches look fine to me. But only the 1/3 patch fixes a bug; the
others merely change the resource management.
>>>
>>>
>>> Do you want me to split this series ?
>
On 13-12-04 04:21 PM, Alan Stern wrote:
On Wed, 4 Dec 2013, boris brezillon wrote:
The patches look fine to me. But only the 1/3 patch fixes a bug; the
others merely change the resource management.
Do you want me to split this series ?
1) the 1st patch that should be merged in 3.13
2)
On Wed, Dec 04, 2013 at 07:10:42AM +, Peter Chen wrote:
>
>
> >
> > On Tue, Nov 26, 2013 at 08:11:26PM +0800, Peter Chen wrote:
> > > According to Freescale imx28 Errata, "ENGR119653 USB: ARM to USB
> > > register error issue", All USB register write operations must
> > > use the ARM SWP in
On Tue, 3 Dec 2013, Julius Werner wrote:
> usb_deauthorize_device() tries to unset the configuration of a USB
> device and then unconditionally blows away the configuration descriptors
> with usb_destroy_configuration(). This is bad if the
> usb_set_configuration() call failed before the configura
On Wed, 4 Dec 2013, boris brezillon wrote:
> > The patches look fine to me. But only the 1/3 patch fixes a bug; the
> > others merely change the resource management.
>
> Do you want me to split this series ?
> 1) the 1st patch that should be merged in 3.13
> 2) patches 2 to 4 that might be a
Hi guys,
Kishon, sorry I did not see this v3 set.
On Mon, Nov 25, 2013 at 03:31:24PM +0530, Kishon Vijay Abraham I wrote:
> There can be systems which does not have an external phy, so get
> phy only if no quirks are added that indicates the PHY is not present.
> Introduced two quirk flags to ind
Hi Vivek,
On Wednesday 20 November 2013 09:14 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 20 November 2013 03:02 PM, Vivek Gautam wrote:
>> On Wed, Nov 20, 2013 at 2:34 PM, Kishon Vijay Abraham I
>> wrote:
>>> On Wednesday 20 November 2013 02:27 PM, Vivek Gautam wrote:
Hi Kish
On Tue, Nov 26, 2013 at 07:36:49PM +0400, Alexander Shiyan wrote:
> This adds i.MX27 and i.MX31 as the next user of the usbmisc driver.
>
> Signed-off-by: Alexander Shiyan
> ---
> drivers/usb/chipidea/usbmisc_imx.c | 42
> ++
> 1 file changed, 42 insertions(+
On Tue, Nov 26, 2013 at 07:36:50PM +0400, Alexander Shiyan wrote:
> This adds i.MX51 as the next user of the usbmisc driver.
> Functionality is similar to i.MX53, so at this stage simply
> reuse existing i.MX53 calls.
>
> Signed-off-by: Alexander Shiyan
> ---
> drivers/usb/chipidea/usbmisc_imx.c
On Wed, Dec 04, 2013 at 08:20:07PM +1100, dt.ta...@gmail.com wrote:
> From: Daniel Tang
>
> The SoC name was mistakenly used instead of the vendor name in the
> device tree binding for nspire-usb.
>
> This patch fixes this before the driver becomes widely adopted.
>
> Signed-off-by: Daniel Tang
On Wed, Dec 04, 2013 at 11:35:54AM +0200, Ivan T. Ivanov wrote:
>
> Hi Peter,
>
> On Wed, 2013-12-04 at 13:37 +0800, Peter Chen wrote:
> > On Mon, Nov 11, 2013 at 04:36:09PM +0200, Ivan T. Ivanov wrote:
> > >
> > > Hi Peter,
> > >
> > > On Mon, 2013-11-11 at 21:59 +0800, Peter Chen wrote:
>
On Wed, Dec 04, 2013 at 10:33:57AM +0200, Ivan T. Ivanov wrote:
> Hi Peter,
>
> Thank you for reviewing this patch.
>
> On Wed, 2013-12-04 at 13:40 +0800, Peter Chen wrote:
> > On Mon, Nov 11, 2013 at 03:35:34PM +0200, Ivan T. Ivanov wrote:
> > > From: "Ivan T. Ivanov"
> > >
> >
> > Please a
On Wed, Dec 04, 2013 at 09:33:26AM +0100, Marc Kleine-Budde wrote:
> On 12/04/2013 02:40 AM, Peter Chen wrote:
> > There are some re-work for this serial, I will do it.
> > But I don't get your mean why it needs to squash into another patch?
>
> Let's look at the code again:
>
> > - if (imx_pla
On Wed, Dec 04, 2013 at 11:21 +0100, Daniel Mack wrote:
> While at it, remove the intermediate variable mem_decs (I guess it was
> only there to make the code comply to the 80-chars CodingSytle rule).
purge_descs() still has a (now unused) mem_decs intermediate variable.
Regards,
Steve
--
To unsu
Hi,
Does the old phy-samsung-usb3 driver currently work on Exynos5250? If yes,
then this patch should be merged with patch #1 to preserve bisectability.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
On Wednesday, December 04, 2013 03:39:05 PM Vivek
+Kishon
On 12/03/2013 11:33 PM, Belisko Marek wrote:
> Hi,
>
> current 3.13-rcX break usb support on gta04 board (similar to
> beagleboard) when booting via board file.
>
> In console we can see messages:
> [ 5227.287841] twl4030_usb twl4030_usb: Timeout setting T2 HSUSB PHY DPLL
> clock
> [ 5
On Wed, Dec 04, 2013 at 09:20:07AM +, dt.ta...@gmail.com wrote:
> From: Daniel Tang
>
> The SoC name was mistakenly used instead of the vendor name in the
> device tree binding for nspire-usb.
>
> This patch fixes this before the driver becomes widely adopted.
How widely adopted is it so fa
cdd->cd and cdd->descs_phys are allocated DESCS_AREAS times from
init_descs() and freed as often from purge_descs(). This doesn't cause
any trouble as DESCS_AREAS is ensured to be 1, but it looks wrong to
do the (de)allocation inside the loop.
While at it, remove the intermediate variable mem_decs
Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
The new driver uses the generic PHY framework and will interact
with DWC3 controller present on Exynos5 series of SoCs.
Thereby, removing old phy-samsung-usb3 driver and related code
used untill now which was based on usb/phy framework
Adding a phy driver for USB 3.0 PHY controller present on Exynos5
series of SoCs alongwith DWC3 controller for USB 3.0 operations.
Few functions used in this driver to translate ref clock rate are
common to Kamil's usb2.0 phy driver [1]. So we can figure out how
to re-use them across these drivers
Add device tree nodes for DWC3 controller present on
Exynos 5420 SoC, to enable support for USB 3.0.
Signed-off-by: Vivek Gautam
---
arch/arm/boot/dts/exynos5420.dtsi | 38 +++-
1 files changed, 36 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/ex
Update device tree bindings for DWC3 controller and
USB 3.0 phy present on Exynos 5250 SoC, to start using
the phy driver based on generic phy framework.
Signed-off-by: Vivek Gautam
---
arch/arm/boot/dts/exynos5250.dtsi | 16 ++--
1 files changed, 6 insertions(+), 10 deletions(-)
Add device tree nodes for USB 3.0 PHY present alongwith
USB 3.0 controller Exynos 5420 SoC. This phy driver is
based on generic phy framework.
Signed-off-by: Vivek Gautam
---
arch/arm/boot/dts/exynos5420.dtsi | 20
1 files changed, 20 insertions(+), 0 deletions(-)
diff --
On Wed, Dec 04, 2013 at 10:02:44AM +0800, Chris Ruehl wrote:
> usb: phy-tegra-usb.c: wrong pointer check for remap UTMI
>
> A wrong pointer was used to test the result of devm_ioremap()
>
> Signed-off-by: Chris Ruehl
> Acked-by: Venu Byravarasu
> ---
> drivers/usb/phy/phy-tegra-usb.c |2 +-
On 2013-12-03 16:25, Roger Quadros wrote:
> Hi,
>
> This is a follow up solution to the original series in [1]
>
> The first patch fixes the OMAP4 Panda USB detection problems on 3.13-rc1
> with u-boot v2013.10.
>
> The remaining 2 patches are required if SOFTRESET needs to be done for the
> USB
Hi Chris,
On Wed, Dec 04, 2013 at 03:16:21PM +0800, Chris Ruehl wrote:
> On Tuesday, December 03, 2013 04:15 PM, Heikki Krogerus wrote:
> >On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote:
> >>@@ -154,6 +164,27 @@ int usb_phy_gen_create_phy(struct device *dev, struct
> >>usb_phy_gen_xc
Hi Peter,
On Wed, 2013-12-04 at 13:37 +0800, Peter Chen wrote:
> On Mon, Nov 11, 2013 at 04:36:09PM +0200, Ivan T. Ivanov wrote:
> >
> > Hi Peter,
> >
> > On Mon, 2013-11-11 at 21:59 +0800, Peter Chen wrote:
> > > On Mon, Nov 11, 2013 at 03:35:37PM +0200, Ivan T. Ivanov wrote:
> > > > From:
From: Daniel Tang
The SoC name was mistakenly used instead of the vendor name in the
device tree binding for nspire-usb.
This patch fixes this before the driver becomes widely adopted.
Signed-off-by: Daniel Tang
---
Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt |4 ++--
drivers
From: Daniel Tang
This patch adds the needed compatible key to the device tree for TI-Nspires.
Signed-off-by: Daniel Tang
---
arch/arm/boot/dts/nspire.dtsi |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/nspire.dtsi b/arch/arm/boot/dts/nspire.dtsi
index a22ffe6..baf715
On Wed, 2013-12-04 at 13:43 +0800, Peter Chen wrote:
> On Mon, Nov 11, 2013 at 03:35:36PM +0200, Ivan T. Ivanov wrote:
> > From: "Ivan T. Ivanov"
> >
>
> The commit log is needed.
Will fix it.
Regards,
Ivan
>
> > Signed-off-by: Ivan T. Ivanov
> > ---
> > drivers/usb/chipidea/ci_hdrc_msm.
Hi Peter,
Thank you for reviewing this patch.
On Wed, 2013-12-04 at 13:40 +0800, Peter Chen wrote:
> On Mon, Nov 11, 2013 at 03:35:34PM +0200, Ivan T. Ivanov wrote:
> > From: "Ivan T. Ivanov"
> >
>
> Please add something in commit log
>
> > Signed-off-by: Ivan T. Ivanov
> > Cc: devicet...@
On 12/04/2013 02:40 AM, Peter Chen wrote:
> There are some re-work for this serial, I will do it.
> But I don't get your mean why it needs to squash into another patch?
Let's look at the code again:
> - if (imx_platform_flag->flags & CI_HDRC_IMX_SUPPORT_RUNTIME_PM)
> + if (imx_platform_fl
Hello Alan,
On 03/12/2013 16:32, Alan Stern wrote:
On Tue, 3 Dec 2013, Nicolas Ferre wrote:
On 03/12/2013 15:07, Boris BREZILLON :
Replace clk_get calls by devm_clk_get calls.
Signed-off-by: Boris BREZILLON
Tested-by: Robert Nelson
Acked-by: Nicolas Ferre
Thanks Boris for these fixes.
69 matches
Mail list logo