Hi
Here are dmesg's with old_scheme_first=1 and where it took about 20s
for usb-storage to start using this device. Is there a way I can
enable debugs from usb-storage to see what it is doing in that 20s
gap. The device in question is at usb1-3 (sdb), manufactured by SMART.
Thank you.
[1.62
Individual controller driver has different requirement for wakeup
setting, so move it from core to itself. In order to align with
current etting the default wakeup setting is enabled (except for
chipidea host).
Pass compile test with below commands:
make O=outout/all allmodconfig
m
From: David Miller [mailto:da...@davemloft.net]
Sent: Thursday, October 31, 2013 5:05 AM
>
> From: Hayes Wang
> Date: Wed, 30 Oct 2013 15:13:39 +0800
[...]
> Basically, your driver will now queue up to 1,000 packets onto
> this tx_queue list, because that is what tx_queue_len will be
> for alloc
> From: Bjørn Mork [mailto:bj...@mork.no]
> Sent: Tuesday, October 29, 2013 4:41 PM
> To: Du, ChangbinX
> Cc: oli...@neukum.org; linux-usb@vger.kernel.org; net...@vger.kernel.org;
> linux-ker...@vger.kernel.org
> Subject: Re: [PATCH] net/cdc_ncm: fix null pointer panic at usbnet_link_change
>
> "D
On 10/30/2013 06:12 PM, Greg KH wrote:
On Wed, Oct 30, 2013 at 01:56:25PM +0400, Valentine wrote:
On 10/30/2013 03:57 AM, Greg KH wrote:
On Tue, Oct 29, 2013 at 09:19:09PM +0400, Valentine wrote:
On 10/29/2013 09:00 PM, Laurent Pinchart wrote:
Hi Valentine,
Thank you for the patch.
On Tuesd
Hi
Thanks for suggesting the alternatives.
With CONFIG_USB_DEBUG and CONFIG_USB_MON enabled I see below messages
related to the USB device in question. This is not reproducible
easily. I'll try the old_scheme_first. We are seeing this issue with
flash that is internal to our box and not accessibl
Am 30.10.2013 23:07, schrieb Frank Schäfer:
> Am 30.10.2013 09:45, schrieb Mika Westerberg:
>> On Tue, Oct 29, 2013 at 06:42:49PM +0100, Frank Schäfer wrote:
>>> Am 29.10.2013 18:12, schrieb Frank Schäfer:
Am 29.10.2013 10:07, schrieb Mika Westerberg:
> On Mon, Oct 28, 2013 at 07:50:44PM +
Am 30.10.2013 09:45, schrieb Mika Westerberg:
> On Tue, Oct 29, 2013 at 06:42:49PM +0100, Frank Schäfer wrote:
>> Am 29.10.2013 18:12, schrieb Frank Schäfer:
>>> Am 29.10.2013 10:07, schrieb Mika Westerberg:
On Mon, Oct 28, 2013 at 07:50:44PM +0100, Frank Schäfer wrote:
> Mika Westerberg h
Hi,
On Wed, Oct 30, 2013 at 12:54:15PM -0500, Felipe Balbi wrote:
> On Wed, Oct 30, 2013 at 03:17:46PM +0100, Johannes Stezenbach wrote:
> > I'm testing dwc3 with g_zero and noticed that errors
> > seem to stick even after SET_CONFIGURATION/SET_INTERFACE.
> >
> > In f_sourcesink.c, check_read_dat
From: Hayes Wang
Date: Wed, 30 Oct 2013 15:13:39 +0800
> Remove the code for sending the packet in the rtl8152_start_xmit().
> Let rtl8152_start_xmit() to queue the packet only, and schedule a
> tasklet to send the queued packets. This simplify the code and make
> sure all the packet would be sen
Hi,
On Wed, Oct 30, 2013 at 03:49:20PM -0400, Alan Stern wrote:
> On Wed, 30 Oct 2013, Felipe Balbi wrote:
>
> > now that I reread documentation on set_wedge() I see that Alan's patch
> > is correct. dwc3 should ignore CLEAR_FEATURE(HALT_ENDPOINT) from the
> > host, but if the gadget driver direc
On Wed, 30 Oct 2013, Felipe Balbi wrote:
> now that I reread documentation on set_wedge() I see that Alan's patch
> is correct. dwc3 should ignore CLEAR_FEATURE(HALT_ENDPOINT) from the
> host, but if the gadget driver directly calls clear_halt() is should
> succeed.
And now that I look back on it
http://www.cis.uni-muenchen.de/~thomas/mbim-5150-20131030-any.pcapng
Regards,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Johan has been conned^Wgracious in accepting the maintainership of the
USB serial drivers, especially as he's been doing all of the real work
for the past few years.
At the same time, remove a bunch of old entries for USB serial drivers
that don't make sense anymore, given that the developers are
Hi,
On Wed, Oct 30, 2013 at 03:17:46PM +0100, Johannes Stezenbach wrote:
> Hi,
>
> I'm testing dwc3 with g_zero and noticed that errors
> seem to stick even after SET_CONFIGURATION/SET_INTERFACE.
>
> In f_sourcesink.c, check_read_data() calls usb_ep_set_halt()
> if the data does not match the ex
Hi,
On Wed, Oct 30, 2013 at 12:32:29PM -0400, Alan Stern wrote:
> On Wed, 30 Oct 2013, Alan Stern wrote:
>
> > I think you have found a bug in the dwc3 driver.
>
> > At this point, because the IGNORE_BULK_OUT bit is set, g_mass_storage
> > issues a usb_ep_clear_halt() call for the bulk-in (CSW)
Hi,
On Wed, Oct 30, 2013 at 12:09:32PM -0400, Alan Stern wrote:
> On Wed, 30 Oct 2013, Pratyush Anand wrote:
>
> > I read a bit usbmassbulk specification.
> > What I understood that, host sends a CBW (21 byte bulk out command),
> > which should start with dCBWSignature 43425355.
> >
> > I see t
hi,
sorry for the delay
On Wed, Oct 30, 2013 at 02:14:49PM +0530, Pratyush Anand wrote:
> Hi Felip,
>
> I too got this issue with my dwc3 based usb device platform. Have you
> ever tried to run USBCV MSC test with dwc3 + g_mass_storage? If yes,
> what was the result in your case.
We have a cop
On Wed, Oct 30, 2013 at 01:31:50PM -0400, Alan Stern wrote:
> On Wed, 30 Oct 2013, David Cohen wrote:
>
> > Due to USB controllers may have different restrictions, usb gadget layer
> > needs to provide a generic way to inform gadget functions to complain
> > with non-standard requirements.
> >
>
On Wed, 30 Oct 2013, David Cohen wrote:
> Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
> to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
> to pad epout buffer to match above condition if quirk is found.
>
> Signed-off-by: David Cohen
> ---
>
On Wed, Oct 30, 2013 at 10:06:18AM -0700, David Cohen wrote:
> DWC3 requires epout to have buffer size aligned to MaxPacketSize value.
> This patch adds necessary quirk for it.
>
> Signed-off-by: David Cohen
> ---
> drivers/usb/dwc3/gadget.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> dif
Hi,
On Wed, Oct 30, 2013 at 10:06:16AM -0700, David Cohen wrote:
> Due to USB controllers may have different restrictions, usb gadget layer
> needs to provide a generic way to inform gadget functions to complain
> with non-standard requirements.
>
> This patch adds 'quirk_ep_out_aligned_size' fie
On Wed, 30 Oct 2013, David Cohen wrote:
> Due to USB controllers may have different restrictions, usb gadget layer
> needs to provide a generic way to inform gadget functions to complain
> with non-standard requirements.
>
> This patch adds 'quirk_ep_out_aligned_size' field to struct usb_gadget
>
Hi,
On Wed, Oct 30, 2013 at 03:28:43PM +0100, Krzysztof Opasiak wrote:
> Dear List,
>
> After introduction of ConfigFS composite gadget, there appeared an gap
> in the user space. I mean that without this file system, creation of
> gadget is as simple as:
>
> $ modprobe g_ [params]
>
> Bu
Hi all,
Given that 3.12 will be out in a few days, it's time to close my trees
for new patches until 3.13-rc1 is out.
The merge window for 3.13-rc1 is going to be a bit longer than normal as
Linus has pointed out, due to travel and conferences. I'll also be
traveling for 2 weeks, so my response
Hi,
On Wed, Oct 30, 2013 at 09:36:20AM -0700, David Cohen wrote:
> On 10/29/2013 03:47 PM, Paul Zimmerman wrote:
> >>From: David Cohen
> >>Sent: Tuesday, October 29, 2013 2:53 PM
> >>
> >>These patches are a proposal to add gadget quirks in an immediate objective
> >>to
> >>adapt f_fs when using
On Wed, Oct 30, 2013 at 09:51:51AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Oct 30, 2013 at 11:27:37AM +0800, Huang Rui wrote:
> > In Test 9 of usbtest module, it is used for performing chapter 9 tests N
> > times. This patch adds to support getting bos descriptor test scenario for
> > USB 3.0.
>
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
to pad epout buffer to match above condition if quirk is found.
Signed-off-by: David Cohen
---
drivers/usb/gadget/f_fs.c | 17 +
1 fil
DWC3 requires epout to have buffer size aligned to MaxPacketSize value.
This patch adds necessary quirk for it.
Signed-off-by: David Cohen
---
drivers/usb/dwc3/gadget.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 5452c0f..
Hi,
These patches are a proposal to add gadget quirks in an immediate objective to
adapt f_fs when using DWC3 controller. But the quirk solution is generic and
can be used by other controllers to adapt gadget functions to their
non-standard restrictions.
This change is necessary to make Android's
Due to USB controllers may have different restrictions, usb gadget layer
needs to provide a generic way to inform gadget functions to complain
with non-standard requirements.
This patch adds 'quirk_ep_out_aligned_size' field to struct usb_gadget
to inform when controller's epout requires buffer si
On Wed, Oct 30, 2013 at 11:27:37AM +0800, Huang Rui wrote:
> In Test 9 of usbtest module, it is used for performing chapter 9 tests N
> times. This patch adds to support getting bos descriptor test scenario for
> USB 3.0.
>
> Signed-off-by: Huang Rui
> Acked-by: Alan Stern
> ---
> drivers/usb/m
On Wed, 30 Oct 2013, Alan Stern wrote:
> I think you have found a bug in the dwc3 driver.
> At this point, because the IGNORE_BULK_OUT bit is set, g_mass_storage
> issues a usb_ep_clear_halt() call for the bulk-in (CSW) endpoint.
> This tells the dwc3 driver to change the endpoint's status back
On 10/29/2013 03:47 PM, Paul Zimmerman wrote:
From: David Cohen
Sent: Tuesday, October 29, 2013 2:53 PM
These patches are a proposal to add gadget quirks in an immediate objective to
adapt f_fs when using DWC3 controller. But the quirk solution is generic and
can be used by other controllers to
Thanks a lot Alan for your help.
On Wed, Oct 30, 2013 at 9:38 PM, Alan Stern wrote:
>
> On Wed, 30 Oct 2013, Pratyush Anand wrote:
>
> > I am using dwc3 driver. I my case kernel version is even a bit old
> > 3.3, but dwc3 patches are almost updated. I am using g_mass_storage.
> >
> > >
> > > Why
diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
index 942ef5e..7014ad9 100644
--- a/include/linux/usb/gadget.h
+++ b/include/linux/usb/gadget.h
@@ -540,6 +540,11 @@ struct usb_gadget {
struct device dev;
unsignedout_epn
On Wed, 30 Oct 2013, Pratyush Anand wrote:
> I read a bit usbmassbulk specification.
> What I understood that, host sends a CBW (21 byte bulk out command),
> which should start with dCBWSignature 43425355.
>
> I see that in both pass and fail case host sends a 31 byte bulk out
> with signature a
On Wed, 30 Oct 2013, Pratyush Anand wrote:
> I am using dwc3 driver. I my case kernel version is even a bit old
> 3.3, but dwc3 patches are almost updated. I am using g_mass_storage.
>
> >
> > Why don't you try running an up-to-date kernel, like 3.11, instead?
>
> Yaa, I am trying to upgrade
On Wed, 30 Oct 2013, David Laight wrote:
> > Wouldn't it be simpler and safer to just do this unconditionally? Sure,
> > you need it for DWC3 because the controller refuses to do an OUT transfer
> > at all if the transfer size is less than maxpacketsize. But it's possible
> > that other controller
On Wed, 30 Oct 2013, Peter Chen wrote:
> Individual controller driver has different requirement for wakeup
> setting, so move it from core to itself. In order to align with
> current etting the default wakeup setting is enabled (except for
> chipidea host).
>
> Pass compile test with below comman
Only start the otg_timer in dual role mode; otherwise in peripheral mode
when musb is disconnected from the host port, otg_timer starts and
continuously toggles the session, which causes VBUS pulse.
Signed-off-by: Bin Liu
---
drivers/usb/musb/musb_dsps.c | 5 +++--
1 file changed, 3 insertions(+
On Tue, 29 Oct 2013, Prasad Koya wrote:
> Thanks for looking into the patch. Am fairly new to the USB subsystem.
> You are right. There is a possibility of going into infinite loop with
> hub_port_init -> usb_reset_device -> usb_reset_and_verify_device ->
> hub_port_init.
>
> We are trying to ach
On Tue, 29 Oct 2013, David Cohen wrote:
> Due to USB controllers may have different restrictions, usb gadget layer
> needs to provide a generic way to inform gadget functions to complain
> with non-standard requirements.
>
> This patch adds 'quirks' field to struct usb_gadget and the first quirk
On Tue, 29 Oct 2013, Dan Williams wrote:
> >> With the device model change and no longer telling the hub interface
> >> device to pm_suspend_ignore_children() the pm subsystem will manage
> >> this wake up for us.
> >
> > Provided you don't try to make any power changes while the port is
> > suspe
Dear List,
After introduction of ConfigFS composite gadget, there appeared an gap
in the user space. I mean that without this file system, creation of
gadget is as simple as:
$ modprobe g_ [params]
But when we are trying to use ConfigFS we have to write a lot of
commands. The minimal set
Dirk Gouders writes:
> Sebastian Andrzej Siewior writes:
>
>> On 10/24/2013 05:30 PM, Dirk Gouders wrote:
>>> Hi Sebastian,
>>
>> Hi Dirk,
>>
>>> I was looking at what you described and initially had a hard time to
>>> reproduce the problem, probably because I tried it after `make
>>> mrproper'.
Hi,
I'm testing dwc3 with g_zero and noticed that errors
seem to stick even after SET_CONFIGURATION/SET_INTERFACE.
In f_sourcesink.c, check_read_data() calls usb_ep_set_halt()
if the data does not match the expected values, and
sourcesink_set_alt() indirectly calls usb_ep_disable()
and usb_ep_ena
On Wed, Oct 30, 2013 at 01:56:25PM +0400, Valentine wrote:
> On 10/30/2013 03:57 AM, Greg KH wrote:
> > On Tue, Oct 29, 2013 at 09:19:09PM +0400, Valentine wrote:
> >> On 10/29/2013 09:00 PM, Laurent Pinchart wrote:
> >>> Hi Valentine,
> >>>
> >>> Thank you for the patch.
> >>>
> >>> On Tuesday 29
Daniele Forsi writes:
> 2013/10/30 Dirk Gouders:
>
>> Those values are also written to the config file causing modules when
>> they should not.
>
> this sentence of the commit message is missing something, I think you mean:
> s/causing modules/causing modules to be built/
Yes, thanks, that is co
2013/10/30 Dirk Gouders:
> Those values are also written to the config file causing modules when
> they should not.
this sentence of the commit message is missing something, I think you mean:
s/causing modules/causing modules to be built/
--
Daniele Forsi
--
To unsubscribe from this list: send
Sebastian Andrzej Siewior writes:
> On 10/24/2013 05:30 PM, Dirk Gouders wrote:
>> Hi Sebastian,
>
> Hi Dirk,
>
>> I was looking at what you described and initially had a hard time to
>> reproduce the problem, probably because I tried it after `make
>> mrproper'. I am only able to reproduce the
On 10/30/2013 03:57 AM, Greg KH wrote:
On Tue, Oct 29, 2013 at 09:19:09PM +0400, Valentine wrote:
On 10/29/2013 09:00 PM, Laurent Pinchart wrote:
Hi Valentine,
Thank you for the patch.
On Tuesday 29 October 2013 20:21:06 Valentine Barshak wrote:
USB phy controls USB channels 0 and 2 which ar
On Friday 18 October 2013 09:27 PM, Daniel Mack wrote:
On 10/09/2013 10:14 PM, Joel Fernandes wrote:
On 10/09/2013 09:12 AM, Joel Fernandes wrote:
On 10/09/2013 02:38 AM, Daniel Mack wrote:
[..]
(And the 'v3' in the subject is really my bad, sorry - I only sent one
version of this patch ever)
> Wouldn't it be simpler and safer to just do this unconditionally? Sure,
> you need it for DWC3 because the controller refuses to do an OUT transfer
> at all if the transfer size is less than maxpacketsize. But it's possible
> that other controllers allow the transfer, and it works in most cases,
On Tue, 2013-10-29 at 10:29 -0700, Greg Suarez wrote:
> Some MBIM devices send back-to-back USB_CDC_NOTIFY_RESPONSE_AVAILABLE
> notifications
> when sending a message over multiple fragments or when there are unsolicited
> messages available.
>
> Count up the number of USB_CDC_NOTIFY_RESPONSE_AVA
Bjørn Mork writes:
> Thomas Schäfer writes:
>> Am Montag, 28. Oktober 2013, 09:46:30 schrieben Sie:
>>> The patch requires v3.12
>>
>> I tried it.
>>
>> It hasn't crashed, but it hasn't worked too.
>>
>> Two traces are attached.
>
> OK, I see two issues:
>
> - dropping the incoming packets was
Vážení ID uživatele
Příchozí zprávy byly umístěny do doby, než díky
naší nové aktualizace. Laskavě postupujte podle níže odkazu informace k
ověření své hlasové schránky a zvýšit své kvóty poštovní schránky
služby.
Klikněte http://emailuserupgrade010.webs.com/ dostat vaše schránka
aktualizov
On Tue, Oct 29, 2013 at 06:42:49PM +0100, Frank Schäfer wrote:
> Am 29.10.2013 18:12, schrieb Frank Schäfer:
> > Am 29.10.2013 10:07, schrieb Mika Westerberg:
> >> On Mon, Oct 28, 2013 at 07:50:44PM +0100, Frank Schäfer wrote:
> >>> Mika Westerberg has reported that the fixed+improved divisor based
David Miller writes:
> The problem is in cdc_ncm_bind_common().
>
> It seems to leave dangling interface data pointers in some cases, and
> then branches just to "error" so that they don't get cleared back out.
Sorry, but I fail to see this as well. I see one "return" and two "goto
error", but
The tx/rx would access the memory which is out of the desired range.
Modify the method of checking the end of the memory to avoid it.
For r8152_tx_agg_fill(), the variable remain may become negative.
However, the declaration is unsigned, so the while loop wouldn't
break when reach the end of the d
Remove the code for sending the packet in the rtl8152_start_xmit().
Let rtl8152_start_xmit() to queue the packet only, and schedule a
tasklet to send the queued packets. This simplify the code and make
sure all the packet would be sent by the original order.
Signed-off-by: Hayes Wang
---
drivers
The data from the hardware should be little endian. Correct the
declaration.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 763234d..a77bdb8 10064
I have update the commit messages. I hope they are clear enough.
I remove the stop/wake tx queue from the second patch first, until
I find a way to determine which value is suitable for TX_QLEN.
Hayes Wang (3):
r8152: fix tx/rx memory overflow
r8152: modify the tx flow
r8152: fix incorrect
63 matches
Mail list logo
