Re: [Patch v2 13/14] usb: phy-mxs: Add implementation of set_wakeup

2013-10-22 Thread Shawn Guo
On Tue, Oct 22, 2013 at 01:58:47PM +0800, Peter Chen wrote: > When we need the PHY can be waken up by external signals, > we can call this API. Besides, we call mxs_phy_disconnect_line > at this API to close the connection between USB PHY and > controller, after that, the line state from controller

Re: [Patch v2 01/14] usb: doc: phy-mxs: Add more compatible strings

2013-10-22 Thread Peter Chen
On Wed, Oct 23, 2013 at 01:56:00PM +0800, Shawn Guo wrote: > On Tue, Oct 22, 2013 at 01:58:35PM +0800, Peter Chen wrote: > > Since there are three mxs PHY versions, using three compatible > > strings for them. > > > > Signed-off-by: Peter Chen > > --- > > Documentation/devicetree/bindings/usb/mx

Re: [Patch v2 10/14] usb: doc: phy-mxs: update binding for adding disconnect line property

2013-10-22 Thread Shawn Guo
On Tue, Oct 22, 2013 at 01:58:44PM +0800, Peter Chen wrote: > This property is used to disconnect line between USB PHY and > USB controller. > > Signed-off-by: Peter Chen > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt |4 > 1 files changed, 4 insertions(+), 0 deletions(-) >

Re: [Patch v2 02/14] usb: phy-mxs: Add platform judgement code

2013-10-22 Thread Shawn Guo
On Tue, Oct 22, 2013 at 01:58:36PM +0800, Peter Chen wrote: > The mxs-phy has three versions until now, each versions have > some differences among PHY operations. the 1st version is > for mx23/mx28 SoC, The 2nd version is for mx6q and mx6dl, the > 3rd version is for mx6sl and later mx6 platform. >

Re: [Patch v2 01/14] usb: doc: phy-mxs: Add more compatible strings

2013-10-22 Thread Shawn Guo
On Tue, Oct 22, 2013 at 01:58:35PM +0800, Peter Chen wrote: > Since there are three mxs PHY versions, using three compatible > strings for them. > > Signed-off-by: Peter Chen > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt |6 +- > 1 files changed, 5 insertions(+), 1 deletions(

Re: [Patch v2 01/14] usb: doc: phy-mxs: Add more compatible strings

2013-10-22 Thread Shawn Guo
On Tue, Oct 22, 2013 at 01:58:35PM +0800, Peter Chen wrote: > Since there are three mxs PHY versions, using three compatible > strings for them. > > Signed-off-by: Peter Chen > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt |6 +- > 1 files changed, 5 insertions(+), 1 deletions(

Re: [PATCH 2/2] uas: Fix reset handling for externally triggered reset

2013-10-22 Thread Hans de Goede
Hi, On 10/22/2013 08:52 PM, Oliver Neukum wrote: On Tue, 2013-10-22 at 16:58 +0100, Hans de Goede wrote: Handle usb-device resets not triggered from uas_eh_bus_reset_handler(), when this happens, disable cmd queuing during the reset, and wait for existing requests to finish in pre_reset. Hm.

Re: [RFC] Does PHY UTMI data width belong to DWC2 or PHY binding?

2013-10-22 Thread Rob Herring
On 10/22/2013 06:25 AM, Matt Porter wrote: > On Tue, Oct 22, 2013 at 12:48:29PM +0200, Matthijs Kooijman wrote: >> Hi Kishon, >> >> On Mon, Oct 21, 2013 at 02:57:26PM +0530, Kishon Vijay Abraham I wrote: >>> I think it makes sense to keep the data width property in the dwc2 node >>> itself. >>> I

Re: [PATCH 2/4] power: isp1704_charger: Fix driver to work with changes introduced in v3.5

2013-10-22 Thread Anton Vorontsov
On Sun, Sep 08, 2013 at 10:50:37AM +0200, Pali Rohár wrote: > * omap musb driver does not report USB_EVENT_ENUMERATED event anymore > * omap musb driver reporting USB_EVENT_VBUS when charger is connected > * read last event from phy->last_event (instead from ulpi register) > * do not call wall char

Re: [PATCH 2/2] uas: Fix reset handling for externally triggered reset

2013-10-22 Thread Oliver Neukum
On Tue, 2013-10-22 at 16:58 +0100, Hans de Goede wrote: > Handle usb-device resets not triggered from uas_eh_bus_reset_handler(), when > this happens, disable cmd queuing during the reset, and wait for existing > requests to finish in pre_reset. Hm. The most likely reason for resetting a device is

Re: [PATCH 2/2] [PATCH] ax88179_178a: Add VID:DID for Samsung USB Ethernet Adapter

2013-10-22 Thread David Miller
From: fre...@asix.com.tw Date: Tue, 22 Oct 2013 15:32:11 +0800 > From: Freddy Xin > > Add VID:DID for Samsung USB Ethernet Adapter. > > Signed-off-by: Freddy Xin Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.

Re: [PATCH 1/2] [PATCH] ax88179_178a: Correct the RX error definition in RX header

2013-10-22 Thread David Miller
From: fre...@asix.com.tw Date: Tue, 22 Oct 2013 15:32:10 +0800 > From: Freddy Xin > > Correct the definition of AX_RXHDR_CRC_ERR and > AX_RXHDR_DROP_ERR. They are BIT29 and BIT31 in pkt_hdr > seperately. > > Signed-off-by: Freddy Xin Applied. -- To unsubscribe from this list: send the line "u

[RFC] usb: XHCI: Handle ZLP data properly in control transfers

2013-10-22 Thread Jack Pham
From: Hemant Kumar USB control transfers can contain an optional IN data stage, in which case the xHCI driver would queue an additional TRB. The interrupt on short packet (ISP) bit is set so that the host controller driver can update the URB's actual_length field if packet is received has length

[PATCH 1/2] uas: Fix reset locking

2013-10-22 Thread Hans de Goede
Fix the uas_eh_bus_reset_handler not properly taking the usbdev lock before calling usb_device_reset, the usb-core expects this lock to be taken when usb_device_reset is called. Signed-off-by: Hans de Goede --- drivers/usb/storage/uas.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 2/2] uas: Fix reset handling for externally triggered reset

2013-10-22 Thread Hans de Goede
Handle usb-device resets not triggered from uas_eh_bus_reset_handler(), when this happens, disable cmd queuing during the reset, and wait for existing requests to finish in pre_reset. Signed-off-by: Hans de Goede --- drivers/usb/storage/uas.c | 47 ++-

[RFC 0/2] uas: Deal with externally triggered reset, and fix reset locking (v2)

2013-10-22 Thread Hans de Goede
Hi All, Here is v2 of my "uas: Deal with externally triggered reset, and fix reset locking" patch, now split into 2 patches. Besides being split into 2 patches, this new version should deal properly with externally triggered resets. Note this is RFC only for now, as I'm travelling without access

Re: [PATCH 1/5] uas: Deal with externally triggered reset, and fix reset locking

2013-10-22 Thread Hans de Goede
Hi, On 10/21/2013 09:21 AM, Oliver Neukum wrote: On Thu, 2013-10-17 at 20:49 +0200, Hans de Goede wrote: The uas driver is only capable of dealing with an usb-reset it has triggered itself, fix the pre and post reset return values to reflect this. What happens if you get an external reset?

Re: [PATCH v6 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's

2013-10-22 Thread Ivan T. Ivanov
Hi, On Tue, 2013-10-22 at 15:32 +0100, Mark Rutland wrote: > [...] > > > > > + phy->sleep_a_clk = devm_clk_get(phy->dev, "sleep_a"); > > > > > > What means the "_a" in clock name? > > > > They are 2 PHY's on 8074 chip. This drivers is supposed to > > operate on PHY 0, thus sleep_a. PHY 1 is

Re: [PATCH v2 5/6] Revert "ARM: OMAP2+: Provide alias to USB PHY clock"

2013-10-22 Thread Tony Lindgren
* Roger Quadros [131010 02:23]: > On 10/09/2013 06:15 PM, Tony Lindgren wrote: > > * Roger Quadros [131009 00:19]: > >> Hi Tony, > >> > >> On 10/08/2013 01:06 PM, Roger Quadros wrote: > >>> This reverts commit 741532c4a995be11815cb72d4d7a48f442a22fea. > >>> > >>> The proper clock reference is pro

Re: [PATCH v6 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's

2013-10-22 Thread Mark Rutland
[...] > > > + phy->sleep_a_clk = devm_clk_get(phy->dev, "sleep_a"); > > > > What means the "_a" in clock name? > > They are 2 PHY's on 8074 chip. This drivers is supposed to > operate on PHY 0, thus sleep_a. PHY 1 is using sleep_b. Take a look > here http://www.spinics.net/lists/arm-kernel/msg2

Re: Linux USB file storage gadget with new UDC

2013-10-22 Thread Alan Stern
On Tue, 22 Oct 2013, Victor Yeo wrote: > Hi, > > > It looks like you didn't add the dump_stack() call to the UDC driver's > > queue function. You need to add it. > > The attached is the log of dump_stack() call in the UDC driver queue > function, for the last few USB request in the USBCV "devic

Re: [RFC] Does PHY UTMI data width belong to DWC2 or PHY binding?

2013-10-22 Thread Matt Porter
On Tue, Oct 22, 2013 at 12:48:29PM +0200, Matthijs Kooijman wrote: > Hi Kishon, > > On Mon, Oct 21, 2013 at 02:57:26PM +0530, Kishon Vijay Abraham I wrote: > > I think it makes sense to keep the data width property in the dwc2 node > > itself. > > I mean it describes how the dwc2 IP is configured

Re: When USB PHY framework should be used?

2013-10-22 Thread Maxime Ripard
On Mon, Oct 21, 2013 at 01:19:46PM +0200, Arokux X wrote: > Dear Kishon, > > thank you for the answer, no problem it was late! Your understanding > is almost correct. > > > From whatever I could understand, you have a USB HOST controller (each HOST > > controller has an EHCI controller and a comp

Re: [RFC] Does PHY UTMI data width belong to DWC2 or PHY binding?

2013-10-22 Thread Matthijs Kooijman
Hi Kishon, On Mon, Oct 21, 2013 at 02:57:26PM +0530, Kishon Vijay Abraham I wrote: > I think it makes sense to keep the data width property in the dwc2 node > itself. > I mean it describes how the dwc2 IP is configured in that particular SoC > (given > that it can be either <8> or <16>). If I'm

Re: [Patch v2 00/14] Add power management support for MXS PHY

2013-10-22 Thread Peter Chen
Hi Marek, I have tried this patchset as well as my chipidea runtime pm patchset at imx28 evk, it works ok except below two problems: - Without CONFIG_MFD_SYSCON causes build error, fixed by below patches http://marc.info/?l=linux-arm-kernel&m=138243289017143&w=2 - Unbalanced IRQ wake disable kern

Re: [x0148406:am43x-next 2892/6980] drivers/usb/gadget/zero.c:99:10: sparse: symbol 'max_autoresume' was not declared. Should it be static?

2013-10-22 Thread Peter Chen
On Tue, Oct 22, 2013 at 05:06:35PM +0800, kbuild test robot wrote: > tree: git://gitorious.org/x0148406-public/linux-kernel am43x-next > head: 0f0018fe622301c41bc9a332cbc75f716ca296db > commit: 36ed03f7796a6695ee1b6c4893ef022328a50e70 [2892/6980] usb: gadget: > zero: Add flexible auto remote w

Controller's wakeup setting at usb_add_hcd

2013-10-22 Thread Peter Chen
Hi Alan, Currently, the controller's wakeup setting is enabled by default, is it ok let it be disabled by default, and let the user control it. Enable usb wakeup will cause more power consumption(some phy logic need to be on to detect wakeup) and unexpected usb wakeup may be considered as an unexp

[PATCH 1/2] [PATCH] ax88179_178a: Correct the RX error definition in RX header

2013-10-22 Thread freddy
From: Freddy Xin Correct the definition of AX_RXHDR_CRC_ERR and AX_RXHDR_DROP_ERR. They are BIT29 and BIT31 in pkt_hdr seperately. Signed-off-by: Freddy Xin --- drivers/net/usb/ax88179_178a.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/ax88179_178

[PATCH 2/2] [PATCH] ax88179_178a: Add VID:DID for Samsung USB Ethernet Adapter

2013-10-22 Thread freddy
From: Freddy Xin Add VID:DID for Samsung USB Ethernet Adapter. Signed-off-by: Freddy Xin --- drivers/net/usb/ax88179_178a.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 3bcd0d9..8