On Fri, Oct 18, 2013 at 3:06 PM, Alan Stern wrote:
> On Fri, 18 Oct 2013, Andiry Xu wrote:
>
>> On Wed, Oct 16, 2013 at 9:14 AM, Alan Stern
>> wrote:
>> > Sarah:
>> >
>> > While working on some general fixes for wakeup races during PCI
>> > suspend, I noticed that xhci_pci_suspend() ignores its
Hello Nicolas,
This patch should fix the bug you were seeing with USB device
enumaration after moving to CCF.
Tell me if this solves the issue (it worked for me).
Best Regards,
Boris
On 18/10/2013 21:26, Boris BREZILLON wrote:
The AT91 PMC (Power Management Controller) provides a USB clock
On Fri, 18 Oct 2013, Andiry Xu wrote:
> On Wed, Oct 16, 2013 at 9:14 AM, Alan Stern wrote:
> > Sarah:
> >
> > While working on some general fixes for wakeup races during PCI
> > suspend, I noticed that xhci_pci_suspend() ignores its do_wakeup
> > argument. What's the story?
> >
>
> I believe it
cbaf_probe() does cbaf->usb_dev = usb_get_dev(interface_to_usbdev(iface)),
but there is no usb_put_dev() anywhere in cbaf.
The patch adds usb_put_dev() to cbaf_disconnect() and to an error path in
cbaf_probe().
Also it adds missed usb_put_intf(iface) to the error path.
Found by Linux Driver Veri
The AT91 PMC (Power Management Controller) provides a USB clock used by
the different USB controllers (ehci, ohci and udc).
The atmel-ehci driver must configure the usb clock rate to 48Mhz in order
to get a fully functionnal USB host controller.
This configuration was formely done in mach-at91/cloc
On Wed, Oct 16, 2013 at 9:14 AM, Alan Stern wrote:
> Sarah:
>
> While working on some general fixes for wakeup races during PCI
> suspend, I noticed that xhci_pci_suspend() ignores its do_wakeup
> argument. What's the story?
>
I believe it's simply because I don't know how to handle the argument
Hi Roger,
On 18/10/2013 14:00, Roger Quadros wrote:
Hi Benoit,
Could you please include this one for 3.13?
Without this OTG port will be broken for beagle. Thanks.
I've just applied it.
Thanks,
Benoit
cheers,
-roger
On 10/07/2013 01:46 PM, Roger Quadros wrote:
The generic PHY framewrok
On 10/09/2013 10:14 PM, Joel Fernandes wrote:
> On 10/09/2013 09:12 AM, Joel Fernandes wrote:
>> On 10/09/2013 02:38 AM, Daniel Mack wrote:
> [..]
>>> (And the 'v3' in the subject is really my bad, sorry - I only sent one
>>> version of this patch ever).
>>>
>>> I can respin the patch on top of the
On Fri, Oct 18, 2013 at 04:22:02PM +0100, David Laight wrote:
> > It's not too hard. Here's some directions:
> > http://kernelnewbies.org/KernelBuild
>
> I can build it easily enough but ...
>
> Is there a .config file with a sane list of modules anywhere?
> (and builtin drivers for disk boot)
>
> It's not too hard. Here's some directions:
> http://kernelnewbies.org/KernelBuild
I can build it easily enough but ...
Is there a .config file with a sane list of modules anywhere?
(and builtin drivers for disk boot)
The defconfig one doesn't seem to contain enough to be useful,
and the allmo
hcd-pci.c in usbcore contains a check for wakeup requests racing with
controller suspend. This check is going to be moved out of usbcore
and into the individual controller drivers, where it can apply to all
platforms, not just PCI.
This patch adds the check to uhci-hcd. Ironically, none of the
n
hcd-pci.c in usbcore contains a check for wakeup requests racing with
controller suspend. This check is going to be moved out of usbcore
and into the individual controller drivers, where it can apply to all
platforms, not just PCI.
This patch adds the check to ehci-hcd.
Signed-off-by: Alan Stern
This patch changes a dev_warn() call in usbcore to dev_dbg(). It's
not necessary to warn about drivers missing a reset-resume callback,
since the reset-resume method is optional.
Signed-off-by: Alan Stern
CC: Clemens Ladisch
---
[as1728]
drivers/usb/core/driver.c |4 ++--
1 file changed
This patch fixes an endian-related error in ohci-hcd (detected by
sparse) and clarifies a comment explaining a peculiar locking
arrangement that sparse warns about.
Signed-off-by: Alan Stern
---
[as1727]
drivers/usb/host/ohci-hub.c |9 +
1 file changed, 5 insertions(+), 4 deletion
This patch fixes several sparse errors in ehci-hcd introduced by
commit 3d091a6f7039 (USB: EHCI: AMD periodic frame list table quirk).
Although the problem fixed by that commit affects only little-endian
systems, the source code has to use types appropriate for big-endian
too.
Signed-off-by: Alan
This patch fixes a type mismatch in ehci-hcd caused by commit
b35c5009bbf6 (USB: EHCI: create per-TT bandwidth tables). The c_maskp
parameter in check_intr_schedule() was changed to point to unsigned
int rather than __hc32, but the prototype declaration wasn't adjusted
accordingly.
Signed-off-by:
On Fri, 18 Oct 2013, Victor Yeo wrote:
> With your input, i re-do the USBCV test, and put up a table for
> comparison between analyzer log and device log. The comparison result
> is saved as a jpeg file for easy viewing. The analyzer and device log
> are attached as well.
>
> Back to the Set-Conf
On Fri, 18 Oct 2013, Nikita Kiryanov wrote:
> >> + for (i = 0; i < PXA_UHC_MAX_PORTNUM; i++) {
> >> + retval = 0;
> >> + if (ohci->ext_regulator[i])
> >> + retval = regulator_enable(ohci->ext_regulator[i]);
> >> +
> >> + if (retval)
> >> +
This is a summary of an unresolved issue resulting from this thread:
http://www.spinics.net/lists/arm-kernel/msg277700.html
The BCM281xx family of SoCs contain an OTG subsystem consisting of a
DWC2 HSOTG controller and an internal UTMI PHY. This is appears as
follows (monospace font requirement ah
On Fri, 18 Oct 2013, Vishal Annapurve wrote:
> Hi Alan,
>
> What I wanted to say was If the bit US_FLIDX_TIMED_OUT can have more
> meanings than timed out then maybe it would be best to override the
> results after usb-storage is done with the command maybe in scsi layer
> itself who aborted it i
On Thu, 17 Oct 2013, Hans de Goede wrote:
> I thought it would be a good idea to also test uas with usb-2, and it turns
> out
> it ws, as it did not work. The problem is that the uas driver was passing the
> bEndpointAddress' direction bit to usb_rcvbulkpipe, the xhci code seems to
> not care abo
Hi Benoit,
Could you please include this one for 3.13?
Without this OTG port will be broken for beagle. Thanks.
cheers,
-roger
On 10/07/2013 01:46 PM, Roger Quadros wrote:
> The generic PHY framewrok expects different properties than the
> old USB PHY framework. Supply those properties.
>
> Fix
Suspend scenario in case of ohci-spear glue was not
properly handled as it was not suspending generic part
of ohci controller. Alan Stern suggested, properly handle
ohci-spear suspend scenario.
Calling explicitly the ohci_suspend() routine in
spear_ohci_hcd_drv_suspend() will ensure proper
handli
Suspend scenario in case of ohci-s3c2410 glue was not
properly handled as it was not suspending generic part
of ohci controller. Alan Stern suggested, properly handle
ohci-s3c2410 suspend scenario.
Calling explicitly the ohci_suspend()
routine in ohci_hcd_s3c2410_drv_suspend() will ensure
proper h
Suspend scenario in case of ohci-exynos glue was not
properly handled as it was not suspending generic part
of ohci controller. Alan Stern suggested, properly handle
ohci-exynos suspend scenario.
Calling explicitly the ohci_suspend() routine in
exynos_ohci_suspend() will ensure proper handling of
Suspend scenario in case of ohci-at91 glue was not properly handled
as it was not suspending generic part of ohci controller. Alan Stern
suggested, properly handle ohci-at91 suspend scenario.
Calling explicitly the ohci_suspend() routine in ohci_hcd_at91_drv_suspend()
will ensure proper handling o
Suspend scenario in case of OHCI was not properly
handled in ochi_suspend()routine. Alan Stern
suggested, properly handle OHCI suspend scenario.
This does generic proper handling of suspend
scenario to all OHCI SOC.
Signed-off-by: Manjunath Goudar
Acked-by: Alan Stern
Cc: Greg KH
Cc: linux-us
On 10/16/2013 06:01 PM, Alan Stern wrote:
On Wed, 16 Oct 2013, Nikita Kiryanov wrote:
This patchset adds regulator support for pxa27x ohci to make it possible
to turn the ohci controller and its usb devices on/off during probe/remove,
as well as resume/suspend.
Cc: Alan Stern
Cc: Greg Kroah-H
On 10/16/2013 05:58 PM, Alan Stern wrote:
On Wed, 16 Oct 2013, Nikita Kiryanov wrote:
Add regulator support for devices that sit on USB ports,
thus allowing usb devices power management for suspend/resume.
Cc: Alan Stern
Cc: Greg Kroah-Hartman
Signed-off-by: Nikita Kiryanov
Signed-off-by: I
On 10/18/2013 12:02 PM, Daniel Mack wrote:
> As mentioned, that doesn't hit me anymore with the current patch stack.
>
> That doesn't mean we should ignore that issue, of course, we're still
> sleeping while atomic. But I removed the patch from the series for now,
> so we can address that separate
On 10/18/2013 11:59 AM, Sebastian Andrzej Siewior wrote:
> On 10/18/2013 11:39 AM, Daniel Mack wrote:
>> v3 of my musb_dsps suspend patches.
>>
>> With these patches applied, I can successfully bring an AM335x board
>> to suspend with a USB media connected, and access it again after
>> resume.
>>
>
On 10/18/2013 11:58 AM, Sebastian Andrzej Siewior wrote:
> On 10/18/2013 11:39 AM, Daniel Mack wrote:
>
>> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
>> index da21a4e..ce5bbc6 100644
>> --- a/drivers/usb/musb/musb_dsps.c
>> +++ b/drivers/usb/musb/musb_dsps.c
>> @@ -63
On 10/18/2013 11:39 AM, Daniel Mack wrote:
> v3 of my musb_dsps suspend patches.
>
> With these patches applied, I can successfully bring an AM335x board
> to suspend with a USB media connected, and access it again after
> resume.
>
> This works for both PIO mode and CPPI41 enabled configurations
On 10/18/2013 11:39 AM, Daniel Mack wrote:
> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> index da21a4e..ce5bbc6 100644
> --- a/drivers/usb/musb/musb_dsps.c
> +++ b/drivers/usb/musb/musb_dsps.c
> @@ -632,11 +648,54 @@ static const struct of_device_id musb_dsps_of_matc
rx_mode and tx_mode need to be read at suspend time and restored on
resume for dsps platforms. So add it to the wrapper struct first, and
initialize the values.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_dsps.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/musb/mu
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers/usb/musb/musb_vir
It appears not all platforms featuring a musb core need to save the musb
core registers at suspend time and restore them on resume.
The dsps platform does, however. So add a bit in struct
musb_hdrc_platform_data to let platforms specify their need of such
action being taken.
Signed-off-by: Daniel
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know that the core registers need to be
saved as well.
We also have to call musb_port_reset() for this platform upon resume,
Just a cosmetic thing, no functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_dsps.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index ce5bbc6..0fa3468 100644
--- a/d
v3 of my musb_dsps suspend patches.
With these patches applied, I can successfully bring an AM335x board
to suspend with a USB media connected, and access it again after
resume.
This works for both PIO mode and CPPI41 enabled configurations,
together with Sebasitian's and my cppi41 patches recent
On 11/10/2013 09:37, Boris BREZILLON :
Hello,
This patch series is the 4th version of the new at91 clock implementation
(using common clk framework).
Mike, DT maintainers,
Can you have a look at this series converting the AT91 family to common
clock framework and associated Device Tree descr
On 17/10/2013 18:55, Boris BREZILLON :
This patch adds new at91 usb clock implementation using common clk framework.
This clock is used to clock usb ports (ohci, ehci and udc).
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Ok, this one is now replacing the older 13/17.
Thanks Boris
On 10/15/2013 01:02 PM, George Cherian wrote:
> This adds omap control module support for USBSS in AM437x SoC.
> Update DT binding information to reflect these changes.
>
> Signed-off-by: George Cherian
Acked-by: Roger Quadros
> ---
> Changes from v1:
> Make ON and OFF operations symmetr
43 matches
Mail list logo
