Hi Alan,
What I wanted to say was If the bit US_FLIDX_TIMED_OUT can have more
meanings than timed out then maybe it would be best to override the
results after usb-storage is done with the command maybe in scsi layer
itself who aborted it in the first place.
My concern was that overriding the res
On Thu, Oct 17, 2013 at 01:31:47PM -0700, Guenter Roeck wrote:
> On Thu, Oct 17, 2013 at 01:25:48PM -0400, Josh Boyer wrote:
> > On Wed, Oct 16, 2013 at 07:18:41PM -0700, Guenter Roeck wrote:
> > > Commit 3fa4d734 (usb: phy: rename nop_usb_xceiv => usb_phy_gen_xceiv)
> > > changed the conditional a
From: Xenia Ragiadakou
This patch adds a new variable 'cmd_trb' to hold the address of the
command TRB, that is associated with the command completion event,
and to replace repetitions of xhci->cmd_ring->dequeue into the code.
Signed-off-by: Xenia Ragiadakou
Acked-by: Sarah Sharp
Signed-off-by
From: Xenia Ragiadakou
This patch adds a new variable 'cmd_type' to hold the command type so that
switch cases can be simplified by removing TRB_TYPE() macro improving
code readability.
Signed-off-by: Xenia Ragiadakou
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.c | 27 ++
From: Xenia Ragiadakou
This patch replaces 'xhci->cmd_ring->dequeue' with 'trb', the address of
the command TRB, since it is available to reduce line length.
Signed-off-by: Xenia Ragiadakou
Acked-by: Sarah Sharp
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.c | 6 ++
1 file c
From: Dan Williams
Perform an unconditional toggle of the cycle bit with 'xor'.
Signed-off-by: Dan Williams
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring
From: Xenia Ragiadakou
The function that handles xHCI command completion is much too long and
there is need to be broken up into individual functions for each command
completion to improve code readablity.
This patch refactors the code in TRB_NEC_GET_FW switch case in
handle_cmd_completion() into
From: Dan Williams
Only used for debug output, so we don't need to save it.
Signed-off-by: Dan Williams
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci.c | 10 ++
drivers/usb/host/xhci.h | 2 --
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/host/xhc
From: Dan Williams
Remove a few extra lines and make it clear that all implementations
disable the port by sharing the same line of code.
Acked-by: Alan Stern
Signed-off-by: Dan Williams
Signed-off-by: Sarah Sharp
---
drivers/usb/core/hub.c | 11 ---
1 file changed, 4 insertions(+),
From: Xenia Ragiadakou
This patch replaces the 'event' argument of xhci_handle_cmd_set_deq() and
xhci_handle_cmd_reset_ep(), which is used to retrieve the command completion
status code, with the cmd_comp_code directly, since it is available.
Signed-off-by: Xenia Ragiadakou
Acked-by: Sarah Shar
From: Xenia Ragiadakou
This patch adds a new variable 'cmd_comp_code' to hold the command completion
status code aiming to reduce code duplication and to improve code readability.
Signed-off-by: Xenia Ragiadakou
Acked-by: Sarah Sharp
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.
From: Xenia Ragiadakou
Since the Slot ID field in the command completion event matches the Slot ID
field in the associated command TRB for the Stop Endpoint, Set Dequeue Pointer
and Reset Endpoint commands, this patch adds in the handlers of their
completion events a 'slot_id' argument and remove
From: Xenia Ragiadakou
The function that handles xHCI command completion is much too long and
there is need to be broken up into individual functions for each command
completion to improve code readablity.
This patch refactors the code in TRB_RESET_DEV switch case in
handle_cmd_completion() into
From: Xenia Ragiadakou
The function that handles xHCI command completion is much too long and
there is need to be broken up into individual functions for each command
completion to improve code readablity.
This patch refactors the code in TRB_EVAL_CONTEXT switch case in
handle_cmd_completion() in
How it's supposed to work:
--
USB 2.0 Link PM is a lower power state that some newer USB 2.0 devices
support. USB 3.0 devices certified by the USB-IF are required to
support it if they are plugged into a USB 2.0 only port, or a USB 2.0
cable is used. USB 2.0 Link PM requi
From: Xenia Ragiadakou
The function that handles xHCI command completion is much too long and
there is need to be broken up into individual functions for each command
completion to improve code readablity.
This patch refactors the code in TRB_CONFIG_EP switch case, in
handle_cmd_completion(), int
From: Xenia Ragiadakou
Since the slot id retrieved from the Reset Device TRB matches the slot id in
the command completion event, which is available, there is no need to determine
it again.
This patch removes the uneccessary reassignment to slot id and adds a WARN_ON
in case the two Slot ID field
From: Xenia Ragiadakou
The function that handles xHCI command completion is much too long and
there is need to be broken up into individual functions for each command
completion to improve code readablity.
This patch refactors the code in TRB_ADDR_DEV switch case in
handle_cmd_completion() into a
From: Xenia Ragiadakou
This patch renames the function handlers of a triggered Command Completion
Event that correspond to each command type into 'xhci_handle_cmd_'.
That is done to give a consistent naming space to all the functions that
handle Command Completion Events and that will permit the
From: Xenia Ragiadakou
This patch removes the variable 'ep_ring' that is assigned in
TRB_CONFIG_EP switch case but never used.
Signed-off-by: Xenia Ragiadakou
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci
From: Xenia Ragiadakou
The function that handles xHCI command completion is much too long and
there is need to be broken up into individual functions for each command
completion to improve code readablity.
This patch refactors the code in TRB_DISABLE_SLOT switch case in
handle_cmd_completion() in
To enable USB 2.0 Link Power Management (LPM), the xHCI host controller
needs the device slot ID to generate the device address used in L1 entry
tokens. That information is set in the L1 device slot ID field of the
USB 2.0 LPM registers.
Currently, the L1 device slot ID is overwritten when the xH
From: Xenia Ragiadakou
The function that handles xHCI command completion is much too long and
there is need to be broken up into individual functions for each command
completion to improve code readablity.
This patch refactors the code in TRB_ENABLE_SLOT switch case in
handle_cmd_completion() int
From: Xenia Ragiadakou
This patch removes the "adjective" argument from xhci_giveback_urb_in_irq(),
since it is not used in the function anymore.
Signed-off-by: Xenia Ragiadakou
Acked-by: Sarah Sharp
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.c | 8
1 file changed, 4
The USB core currently handles enabling and disabling optional USB power
management features during device transitions (device suspend/resume,
driver bind/unbind, device reset, and device disconnect). Those
optional power features include Latency Tolerance Messaging (LTM),
USB 3.0 Link PM, and USB
From: Sachin Kamat
'xhci_del_comp_mod_timer' is local to this file.
Signed-off-by: Sachin Kamat
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-hub.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index 773a
From: Mathias Nyman
Some usb3 devices falsely claim they support usb2 hardware Link PM
when connected to a usb2 port. We only trust hardwired devices
or devices with the later BESL LPM support to be LPM enabled as default.
[Note: Sarah re-worked the original patch to move the code into the USB
c
From: xiao jin
The usage of USB_CTRL_SET_TIMEOUT in xhci is incorrect.
The definition of USB_CTRL_SET_TIMEOUT is 5000ms. The
input timeout to wait_for_completion_interruptible_timeout
is jiffies. That makes the timeout be longer than what
we want, such as 50s in some platform.
The patch is to us
Before the USB core resets a device, we need to disable the L1 timeout
for the roothub, if USB 2.0 Link PM is enabled. Otherwise the port may
transition into L1 in between descriptor fetches, before we know if the
USB device descriptors changed. LPM will be re-enabled after the
full device descri
The following changes since commit c00809d330cfe42469fcd1cfd63f0690b47ea9bb:
USB: ohci-exynos: Remove non-DT support (2013-10-14 11:09:13 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
tags/for-usb-next-2013-10-17
for you to fetc
I thought it would be a good idea to also test uas with usb-2, and it turns out
it ws, as it did not work. The problem is that the uas driver was passing the
bEndpointAddress' direction bit to usb_rcvbulkpipe, the xhci code seems to
not care about this, but with the ehci code this causes usb_submit
Hi,
Ignore please I accidentally left some debugging in here,
expect a v2 shortly.
Regards,
Hans
On 10/17/2013 11:22 PM, Hans de Goede wrote:
I thought it would be a good idea to also test uas with usb-2, and it turns out
it ws, as it did not work. The problem is that the uas driver was pass
I thought it would be a good idea to also test uas with usb-2, and it turns out
it ws, as it did not work. The problem is that the uas driver was passing the
bEndpointAddress' direction bit to usb_rcvbulkpipe, the xhci code seems to
not care about this, but with the ehci code this causes usb_submit
Hi,
On 10/17/2013 09:44 PM, Sarah Sharp wrote:
If we're expanding a stream ring, we want to make sure we can add those
ring segments to the radix tree that maps segments to ring pointers.
Try the radix tree insert after the new ring segments have been allocated
(the last segment in the new ring
On Thu, 17 Oct 2013, H Hartley Sweeten wrote:
> Convert ep93xx to use the OHCI platform driver and remove the
> ohci-ep93xx bus glue driver.
>
> Enable CONFIG_OHCI_HCD_PLATFORM in the ep93xx_defconfig so that USB
> is still enabled by default on the EP93xx platform.
>
> Signed-off-by: H Hartley
Refresh the ep93xx_defconfig then remove the ep93xx OHCI bus glue
driver in favor of the Generic OHCI driver for a platform device.
v4: propagate errno from clk_enable() in ep93xx_ohci_power_on().
v3: split patch to refresh the ep93xx_defconfig before removing
ohci-ep93xx.c in favor of the Ge
On Thu, Oct 17, 2013 at 01:25:48PM -0400, Josh Boyer wrote:
> On Wed, Oct 16, 2013 at 07:18:41PM -0700, Guenter Roeck wrote:
> > Commit 3fa4d734 (usb: phy: rename nop_usb_xceiv => usb_phy_gen_xceiv)
> > changed the conditional around the declaration of usb_nop_xceiv_register
> > from
> > #if de
Convert ep93xx to use the OHCI platform driver and remove the
ohci-ep93xx bus glue driver.
Enable CONFIG_OHCI_HCD_PLATFORM in the ep93xx_defconfig so that USB
is still enabled by default on the EP93xx platform.
Signed-off-by: H Hartley Sweeten
Acked-by: Alan Stern
Cc: Ryan Mallon
Cc: Lennert B
Generate ep93xx_defconfig by doing:
make ep93xx_defconfig
make savedefconfig
mv defconfig arch/arm/configs/ep93xx_defconfig
No function change. This just refreshes the ep93xx_defconfig to make it
easier and cleaner when adding new entries.
Signed-off-by: H Hartley Sweeten
Acked-by: Ryan Mallon
On 18/10/13 05:25, H Hartley Sweeten wrote:
> Generate ep93xx_defconfig by doing:
>
> make ep93xx_defconfig
> make savedefconfig
> mv defconfig arch/arm/configs/ep93xx_defconfig
>
> No functional change. This just refreshes the ep93xx_defconfig to make it
> easier and cleaner when adding new ent
This patch adds new at91 usb clock implementation using common clk framework.
This clock is used to clock usb ports (ohci, ehci and udc).
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
arch/arm/mach-at91/Kconfig | 11 ++
drivers/clk/at91/Makefile |1 +
drivers/clk/at91/clk-us
From: Enrico Mioso
Date: Tue, 15 Oct 2013 15:06:48 +0200
> This is a QMI device, manufactured by TCT Mobile Phones.
> A companion patch blacklisting this device's QMI interface in the option.c
> driver has been sent.
>
> Signed-off-by: Enrico Mioso
> Signed-off-by: Antonella Pellizzari
Applie
On Thu, Oct 17 2013, Felipe Balbi wrote:
> Hi,
>
> On Wed, Oct 16, 2013 at 02:56:20PM -0700, Michal Nazarewicz wrote:
>> On Tue, Oct 15 2013, Andrzej Pietrasiewicz wrote:
>> > Fix spacing, improve error code returned, remove unused #define,
>> > use strtobool() instead of kstrtou8().
>> >
>> > Sign
From: Wei Yongjun
Date: Sat, 12 Oct 2013 14:24:08 +0800
> From: Wei Yongjun
>
> Fix to return -ENOMEM in the padding pkt alloc fail error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun
Applied, thanks Wei.
--
To unsubscribe from this list: se
If we're expanding a stream ring, we want to make sure we can add those
ring segments to the radix tree that maps segments to ring pointers.
Try the radix tree insert after the new ring segments have been allocated
(the last segment in the new ring chunk will point to the first newly
allocated segm
On Thu, 17 Oct 2013, Majunath Goudar wrote:
> Suspend scenario in case of ohci-at91 glue was not properly handled
> as it was not suspending generic part of ohci controller. Alan Stern
> suggested, properly handle ohci-at91 suspend scenario.
>
> Calling explicitly the ohci_suspend() routine in oh
On Thu, 17 Oct 2013, Majunath Goudar wrote:
> Suspend scenario in case of OHCI was not properly
> handled in ochi_suspend()routine. Alan Stern
> suggested, properly handle OHCI suspend scenario.
>
> This does generic proper handling of suspend
> scenario to all OHCI SOC.
>
> V1->V2:
> - No
On Thu, Oct 17, 2013 at 03:45:24AM +0200, bjoern.glaess...@googlemail.com wrote:
> Hi Sarah...
>
> Sorry, that I contact you directly via email address.
>
> But our pain with this bug is so annoying, that - after a bunch
> of web searches without a solution - I came to the conclusion to ask you
>
Hi guys,
I have finally closed my tree for the merge window. Nothing will go in
anymore and I'll sending a pull request for Greg very soon (tomorrow).
cheers
--
balbi
signature.asc
Description: Digital signature
On Thu, 17 Oct 2013, H Hartley Sweeten wrote:
> Convert ep93xx to use the OHCI platform driver and remove the
> ohci-ep93xx bus glue driver.
>
> Enable CONFIG_OHCI_HCD_PLATFORM in the ep93xx_defconfig so that USB
> is still enabled by default on the EP93xx platform.
>
> Signed-off-by: H Hartley
All callers of unlink_data_urbs drop devinfo->lock before calling it, and
then immediately take it again after the call. And the first thing
unlink_data_urbs does is take the lock again, and the last thing it does
is drop it. This commit removes all the unnecessary lock dropping and taking.
Signed
The uas driver is only capable of dealing with an usb-reset it has triggered
itself, fix the pre and post reset return values to reflect this.
Also fix the uas_eh_bus_reset_handler not properly taking the usbdev lock
before calling usb_device_reset, the usb-core expects this lock to be
taken when
The cmd endpoint never has streams, so the stream_id parameter is unused.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 286225e..bf80ef1 100644
--- a/
- Rename labels to properly reflect this
- Don't skip free-ing the streams when scsi_init_shared_tag_map fails
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb
Otherwise they may complete before they get anchored and thus never get
unanchored (as the unanchoring is done by the usb core on completion).
This commit also remove the usb_get_urb / usb_put_urb around cmd submission +
anchoring, since if done in the proper order this is not necessary.
Signed-o
The more I look at this patch, the more I hate it for the failure cases
it doesn't cover.
What happens if the radix_tree_insert fails in the middle of adding a
set of ring segments? We leave those segments that were inserted in the
radix tree, which is a problem, since we could allocate those seg
On Wednesday, October 16, 2013 2:13 PM, Alan Stern wrote:
> Sure, that's what I meant. All that churn was caused by re-minimizing
> the defconfig file, not by adding USB_OHCI_HCD_PLATFORM.
As requested, I have split this patch to:
1) refresh the ep93xx_defconfig
2) remove the ep93xx bus glue driv
Convert ep93xx to use the OHCI platform driver and remove the
ohci-ep93xx bus glue driver.
Enable CONFIG_OHCI_HCD_PLATFORM in the ep93xx_defconfig so that USB
is still enabled by default on the EP93xx platform.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Alan Stern
Cc: Lennert Buytenh
Generate ep93xx_defconfig by doing:
make ep93xx_defconfig
make savedefconfig
mv defconfig arch/arm/configs/ep93xx_defconfig
No functional change. This just refreshes the ep93xx_defconfig to make it
easier and cleaner when adding new entries.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc:
Refresh the ep93xx_defconfig then remove the ep93xx OHCI bus glue
driver in favor of the Generic OHCI driver for a platform device.
v3: split patch to refresh the ep93xx_defconfig before removing
ohci-ep93xx.c in favor of the Generic OHCI driver for a
platform device.
v2: Use the (*power_
On Thu, 17 Oct 2013, Sarah Sharp wrote:
> > Given the difficulty (or rather the infrequency) of reproducing the
> > problem I'd like to sort out the failing code path before changing
> > kernels so that I can then verify that a more recent kernel fixes it.
>
> The problem is that -ESHUTDOWN usual
On Thu, 17 Oct 2013, Victor Yeo wrote:
> > Here's another experiment you can try. In do_set_config(), just after
> > the "rc = do_set_interface(fsg, -1);" line, add a statement saying
> >
> > INFO(fsg, "fsg->config %d new_config %d\n",
> > fsg->config, new_config);
On Thu, Oct 17, 2013 at 03:30:56PM +0100, David Laight wrote:
> > From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com]
>
> Thanks for taking an interest.
>
> > On Tue, Oct 15, 2013 at 10:59:18AM +0100, David Laight wrote:
> > > We are seeing complete lockups of the transmit side when using
>
On Wed, Oct 16, 2013 at 3:58 PM, Sarah Sharp
wrote:
> Hi Dan,
>
> I'm attempting to put my queue together for usb-next, and this patch
> doesn't apply, due to conflicts in the USB core. Can you rebase this
> patchset on top of my for-usb-next-queue branch, and resend the last two
> patches? The
The following changes since commit d0e639c9e06d44e713170031fe05fb60ebe680af:
Linux 3.12-rc4 (2013-10-06 14:00:20 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/
tags/usb-3.12-rc6
for you to fetch changes up to 94468783cd960aa14b2
On Wed, Oct 16, 2013 at 07:18:41PM -0700, Guenter Roeck wrote:
> Commit 3fa4d734 (usb: phy: rename nop_usb_xceiv => usb_phy_gen_xceiv)
> changed the conditional around the declaration of usb_nop_xceiv_register
> from
> #if defined(CONFIG_NOP_USB_XCEIV) ||
> (defined(CONFIG_NOP_U
On Thu, Oct 17, 2013 at 10:09:00AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap
>
> Fix usb3503 build error - it uses an interface that is provided by
> REGMAP_I2C, so it needs to select that symbol.
>
> drivers/built-in.o: In function `usb3503_i2c_probe':
> usb3503.c:(.text+0x1b2519): un
From: Randy Dunlap
Fix usb3503 build error - it uses an interface that is provided by
REGMAP_I2C, so it needs to select that symbol.
drivers/built-in.o: In function `usb3503_i2c_probe':
usb3503.c:(.text+0x1b2519): undefined reference to `devm_regmap_init_i2c'
Reported-by: JP P
Signed-off-b
Hi,
On 10/17/2013 06:42 PM, Sarah Sharp wrote:
All right, so we have a couple sparse warnings with this patch.
On Thu, Oct 17, 2013 at 01:40:15PM +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
fun-streams-fixes
head: e79db70b0f7d028cb9e9
All right, so we have a couple sparse warnings with this patch.
On Thu, Oct 17, 2013 at 01:40:15PM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
> fun-streams-fixes
> head: e79db70b0f7d028cb9e9cf8ee424a1e92b7d232f
> commit: 0f899d55a18ce7
Hi,
On Wed, Oct 16, 2013 at 01:24:11AM +0530, Kishon Vijay Abraham I wrote:
> There can be systems which does not have a external usb_phy, so get
> usb_phy only if dt data indicates the presence of PHY in the case of dt boot
> or
> if platform_data indicates the presence of PHY. Also remove check
On 11/10/2013 13:38, Boris BREZILLON :
This patch adds new at91 clks dt bindings documentation.
Signed-off-by: Boris BREZILLON
It seems good
Acked-by: Nicolas Ferre
---
.../devicetree/bindings/clock/at91-clock.txt | 328
1 file changed, 328 insertions(+)
c
Hi,
On Wed, Oct 16, 2013 at 02:56:20PM -0700, Michal Nazarewicz wrote:
> On Tue, Oct 15 2013, Andrzej Pietrasiewicz wrote:
> > Fix spacing, improve error code returned, remove unused #define,
> > use strtobool() instead of kstrtou8().
> >
> > Signed-off-by: Andrzej Pietrasiewicz
> > Signed-off-by
On 11/10/2013 13:27, Boris BREZILLON :
This patch adds at91 smd (Soft Modem) clock implementation using common clk
framework.
Not used by any driver right now.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
arch/arm/mach-at91/Kconfig |5 ++
drivers/clk/at91/Makefile |
On 11/10/2013 13:15, Boris BREZILLON :
This patch adds new at91 usb clock implementation using common clk framework.
This clock is used to clock usb ports (ohci, ehci and udc).
Signed-off-by: Boris BREZILLON
Didn't you missed some 9n12 initialization? See below...
---
arch/arm/mach-at91/K
On 11/10/2013 12:22, Boris BREZILLON :
This adds new at91 utmi clock implementation using common clk framework.
This clock is a pll with a fixed factor (x40).
It is used as a source for usb clock.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
arch/arm/mach-at91/Kconfig |
On 11/10/2013 11:57, Boris BREZILLON :
This patch adds new at91 programmable clocks implementation using common clk
framework.
A programmable clock is a clock which can be exported on a given pin to clock
external devices.
Each programmable clock is given an id (from 0 to 8).
The number of availa
On 11/10/2013 11:53, Boris BREZILLON :
This patch adds the peripheral divisors macros (for sam9x5 compatible IPs)
which will be used by peripheral clk dt definitions.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
include/dt-bindings/clk/at91.h |6 ++
1 file changed,
On 11/10/2013 11:44, Boris BREZILLON :
This patch adds new at91 peripheral clock implementation using common clk
framework.
Almost all peripherals provided by at91 SoCs need a clock to work properly.
This clock is enabled/disabled using PCER/PCDR resgisters.
Each peripheral is given an id (see
On 11/10/2013 10:48, Boris BREZILLON :
This patch adds new at91 pll clock implementation using common clk framework.
The pll clock layout describe the PLLX register layout.
There are four pll clock layouts:
- at91rm9200
- at91sam9g20
- at91sam9g45
- sama5d3
PLL clocks are given characteristics:
On 11/10/2013 11:41, Boris BREZILLON :
This patch adds new at91 system clock implementation using common clk
framework.
Some peripherals need to enable a "system" clock in order to work properly.
Each system clock is given an id based on the bit position in SCER/SCDR
registers.
Signed-off-by: B
On 11/10/2013 10:51, Boris BREZILLON :
This patch adds new at91 master clock implementation using common clk
framework.
The master clock layout describe the MCKR register layout.
There are 2 master clock layouts:
- at91rm9200
- at91sam9x5
Master clocks are given characteristics:
- min/max clock
On 11/10/2013 10:44, Boris BREZILLON :
This patch adds new at91 main oscillator clock implementation using common
clk framework.
If rate is not provided during clock registration it is calculated using
the slow clock (main clk parent in this case) rate and MCFR register.
Signed-off-by: Boris BR
On 11/10/2013 10:41, Boris BREZILLON :
This patch adds a new macro file for PMC macros.
This macro file includes the definitions of SR (status register) bit
offsets and will be use to reference PMC irqs.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
include/dt-bindings/clk/
On 11/10/2013 09:37, Boris BREZILLON :
This patch adds at91 PMC (Power Management Controller) base support.
All at91 clocks managed by the PMC unit will use this framework.
This framework provides the following fonctionalities:
- define a new struct at91_pmc to hide PMC internals (lock, PMC mem
Note this patch is probably best squashed into the original
"For streams the dequeue ptr must be read from the stream ctx" patch.
Signed-off-by: Hans de Goede
---
drivers/usb/host/xhci-ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drive
Note this patch is probably best squashed into my
"usb-core: Track if an endpoint has streams" patch.
Signed-off-by: Hans de Goede
---
include/linux/usb.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/usb.h b/include/linux/usb.h
index 1c924eb..a4c8406 100644
--- a/include/lin
On Wed, 16 Oct 2013, Sarah Sharp wrote:
> I think there's some nasty race conditions here. There's several
> different structures this code and other functions are manipulating:
>
> - the endpoint ring contents
> - the endpoint ring dequeue pointer
> - the endpoint's cur_td and cancelled_td l
On Wed, Oct 16, 2013 at 04:27:26PM +0300, Roger Quadros wrote:
> On 10/16/2013 04:10 PM, Kishon Vijay Abraham I wrote:
> > Hi roger,
> >
> > On Wednesday 16 October 2013 06:33 PM, Roger Quadros wrote:
> >> Hi Kishon,
> >>
> >> On 10/15/2013 10:54 PM, Kishon Vijay Abraham I wrote:
> >>> There can b
On Thu, 17 Oct 2013, Dan Streetman wrote:
> On Wed, Oct 16, 2013 at 5:09 PM, Alan Stern wrote:
> > On Wed, 16 Oct 2013, Dan Streetman wrote:
> >
> >> On Wed, Oct 16, 2013 at 10:34 AM, Alan Stern
> >> wrote:
> >> > On Tue, 15 Oct 2013, Dan Streetman wrote:
> >> >
> >
> >> > Until the "new" sched
On Thu, 17 Oct 2013, Alexander Stein wrote:
> > But with xHCI and OHCI, the reconnect succeeds whereas with EHCI it
> > fails?
>
> Yep. But it even works on EHCI if there is a full-speed-hub somewhere before
> that device.
>
> > It's hard to guess why. The behavior under xHCI is slightly diffe
On 10/17/2013 04:23 PM, Daniel Mack wrote:
>> Daniel, could please look if this solves your suspend / resume warnings?
>
> Will do (hopefully) tomorrow. So this is a replacement for my "dma:
> cppi41: move -EAGAIN in tear_down" patch, or does it go on top of it?
I applied your three patches and m
> From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com]
Thanks for taking an interest.
> On Tue, Oct 15, 2013 at 10:59:18AM +0100, David Laight wrote:
> > We are seeing complete lockups of the transmit side when using
> > the smsc95xx driver connected to a USB3 port on an i7 (Ivybridge) cpu.
>
On Wed, 16 Oct 2013, Sarah Sharp wrote:
> Alan, do you have any more feedback on this patchset?
No, it looks like Hans has addressed all the issues I could think of.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.ker
On Wed, 16 Oct 2013, Sarah Sharp wrote:
> > > xhci maintains a radix tree for each stream endpoint because it must
> > > be able to map a trb address to the stream ring. Each ring segment
> > > must be added to the ring for this to work. Currently xhci sticks
> > > only the first segment of each
On 10/17/2013 04:20 PM, Sebastian Andrzej Siewior wrote:
> On 10/17/2013 04:19 PM, Sebastian Andrzej Siewior wrote:
>> This patch changes the logic here to look on both queues for the
>> descriptor.
>
> Daniel, could please look if this solves your suspend / resume warnings?
Will do (hopefully) t
Most of the logic here is try and error since what actually happens does
not match the trm or I miss read it.
My first assumption was that the queue on which the tear-down descriptor
completes (their own complete queue vs "active descriptor" complete
queue) depends on the transfer direction. This s
On 10/17/2013 04:19 PM, Sebastian Andrzej Siewior wrote:
> This patch changes the logic here to look on both queues for the
> descriptor.
Daniel, could please look if this solves your suspend / resume warnings?
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
t
Return code of pm_runtime_get_sync() > 0 is not an error and may happen.
Noticed during rmmod & modprobe testing.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/dma/cppi41.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
inde
Suspend scenario in case of ohci-s3c2410 glue was not
properly handled as it was not suspending generic part
of ohci controller. Alan Stern suggested, properly handle
ohci-s3c2410 suspend scenario.
Calling explicitly the ohci_suspend()
routine in ohci_hcd_s3c2410_drv_suspend() will ensure
proper h
1 - 100 of 115 matches
Mail list logo
