Re: [PATCH v4 0/2] usb: implement AMD remote wakeup quirk

2013-09-23 Thread Huang Rui
Hi Sarah and Alan, On Mon, Sep 23, 2013 at 05:14:02PM -0700, Sarah Sharp wrote: > On Mon, Sep 23, 2013 at 12:43:15PM -0400, Alan Stern wrote: > > This version of the patch set looks good. > > > > Alan Stern > > Looks fine to me as well. > > Acked-by: Sarah Sharp > Thank you for acked-by :) W

Re: [PATCH v2 2/5] usb: chipidea: usbmisc_imx: Using regmap to access register

2013-09-23 Thread Peter Chen
On Tue, Sep 24, 2013 at 12:46:53PM +0800, Peter Chen wrote: Sorry, sending wrongly, please skip it > Signed-off-by: Peter Chen > --- > drivers/usb/chipidea/usbmisc_imx.c | 71 > +--- > 1 files changed, 34 insertions(+), 37 deletions(-) > > diff --git a/driver

Re: [PATCH v2 1/5] usb: chipidea: imx: rename the DT doc name

2013-09-23 Thread Peter Chen
On Tue, Sep 24, 2013 at 12:46:52PM +0800, Peter Chen wrote: Sorry, sending wrongly, please skip it -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

[PATCH 2/3] usb: chipidea: imx: remove PHY operations

2013-09-23 Thread Peter Chen
Since the PHY operations are moved to core, delete the related code at glue layer. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 21 - 1 files changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chip

[PATCH 3/3] usb: chipidea: add ci_hdrc_enter_lpm API

2013-09-23 Thread Peter Chen
This API is used to let the PHY enter/leave low power mode. Before the controller going to work(at probe/resume), it needs to let the PHY leave low power mode. After the controller stopping working(at remove/suspend), it needs to let the PHY enter low power mode to save power consumption. Signed-o

[PATCH 1/3] usb: chipidea: move PHY operation to core

2013-09-23 Thread Peter Chen
PHY operations are common, so move them to core. Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c | 57 ++ drivers/usb/chipidea/udc.c | 39 + 2 files changed, 52 insertions(+), 44 deletions(-) diff --git a/drivers

[PATCH v2 2/5] usb: chipidea: usbmisc_imx: Using regmap to access register

2013-09-23 Thread Peter Chen
Signed-off-by: Peter Chen --- drivers/usb/chipidea/usbmisc_imx.c | 71 +--- 1 files changed, 34 insertions(+), 37 deletions(-) diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c index ac5a461..545efbf 100644 --- a/drivers/usb/c

[PATCH v2 1/5] usb: chipidea: imx: rename the DT doc name

2013-09-23 Thread Peter Chen
To reflect source file name change Signed-off-by: Peter Chen --- .../devicetree/bindings/usb/ci13xxx-imx.txt| 31 .../devicetree/bindings/usb/ci_hdrc_imx.txt| 31 Documentation/devicetree/bindings/usb/mxs-phy.txt | 13 ...

[PATCH 0/3] Chipidea PHY and low power mode change

2013-09-23 Thread Peter Chen
Hi Greg, The this serial includes PHY operation change (move to common code) and low power mode supported, it is based on: http://marc.info/?l=linux-usb&m=137939293826025&w=2. Peter Chen (3): usb: chipidea: move PHY operation to core usb: chipidea: imx: remove PHY operations usb: chipidea:

RE: Mx28 USB workaround for errata

2013-09-23 Thread Chen Peter-B29397
> >> The reason was an mx28 errata: "ENGR119653 USB: ARM to USB register > >> error issue" > > Peter, does this erratum only affect mx28? Yes > >> > >> Freescale issued a patch for 2.6.35 to workaround this problem last > >> year. I ported this patch. However, it is not totally "device tree >

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Greg KH
On Mon, Sep 23, 2013 at 05:23:07PM -0700, Sarah Sharp wrote: > On Mon, Sep 23, 2013 at 02:49:07PM -0700, Greg KH wrote: > > On Mon, Sep 23, 2013 at 04:38:22PM -0500, Bjorn Helgaas wrote: > > > On Mon, Sep 23, 2013 at 3:49 PM, Greg KH wrote: > > > > On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia R

Re: Mx28 USB workaround for errata

2013-09-23 Thread Fabio Estevam
Adding Peter and Marek. On Mon, Sep 23, 2013 at 4:58 PM, Alan Stern wrote: > On Mon, 23 Sep 2013, Robert Hodaszi wrote: > >> Hi, >> >> I had a lot of USB errors on i.mx28. I could reproduce it most easily >> with USB-serial adapters, and USB modems (CDC and WWAN drivers). If I >> sent some data

[Pull Request] xhci: Bug fixes for 3.12.

2013-09-23 Thread Sarah Sharp
The following changes since commit 9d23108df359e572a0dca0b631bfee9f5e0fa9ea: Merge tag 'staging-3.12-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging (2013-09-23 12:53:07 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah

[PATCH 2/5] xhci: Ensure a command structure points to the correct trb on the command ring

2013-09-23 Thread Sarah Sharp
From: Mathias Nyman If a command on the command ring needs to be cancelled before it is handled it can be turned to a no-op operation when the ring is stopped. We want to store the command ring enqueue pointer in the command structure when the command in enqueued for the cancellation case. Some

[PATCH 5/5] usbcore: check usb device's state before sending a Set SEL control transfer

2013-09-23 Thread Sarah Sharp
From: Xenia Ragiadakou Set SEL control urbs cannot be sent to a device in unconfigured state. This patch adds a check in usb_req_set_sel() to ensure the usb device's state is USB_STATE_CONFIGURED. Signed-off-by: Xenia Ragiadakou Reported-by: Martin MOKREJS Suggested-by: Sarah Sharp Signed-off

[PATCH 3/5] usb: Fix xHCI host issues on remote wakeup.

2013-09-23 Thread Sarah Sharp
When a device signals remote wakeup on a roothub, and the suspend change bit is set, the host controller driver must not give control back to the USB core until the port goes back into the active state. EHCI accomplishes this by waiting in the get port status function until the PORT_RESUME bit is

[PATCH 1/5] xhci: Fix oops happening after address device timeout

2013-09-23 Thread Sarah Sharp
From: Mathias Nyman When a command times out, the command ring is first aborted, and then stopped. If the command ring is empty when it is stopped the stop event will point to next command which is not yet set. xHCI tries to handle this next event often causing an oops. Don't handle command comp

[PATCH 4/5] xhci: Fix race between ep halt and URB cancellation

2013-09-23 Thread Sarah Sharp
From: Florian Wolter The halted state of a endpoint cannot be cleared over CLEAR_HALT from a user process, because the stopped_td variable was overwritten in the handle_stopped_endpoint() function. So the xhci_endpoint_reset() function will refuse the reset and communication with device can not r

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Sarah Sharp
On Mon, Sep 23, 2013 at 02:49:07PM -0700, Greg KH wrote: > On Mon, Sep 23, 2013 at 04:38:22PM -0500, Bjorn Helgaas wrote: > > On Mon, Sep 23, 2013 at 3:49 PM, Greg KH wrote: > > > On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia Ragiadakou wrote: > > >> I had in mind that the pci_ops .read and .wri

[PATCH] staging: dwc2: add TODO file

2013-09-23 Thread Paul Zimmerman
Add TODO file for DWC2 driver Signed-off-by: Paul Zimmerman --- Greg, this should be applied after the microframe scheduler patch, since it assumes that one has already been applied. drivers/staging/dwc2/TODO | 33 + 1 file changed, 33 insertions(+) create mode

Re: [PATCH v4 0/2] usb: implement AMD remote wakeup quirk

2013-09-23 Thread Sarah Sharp
On Mon, Sep 23, 2013 at 12:43:15PM -0400, Alan Stern wrote: > This version of the patch set looks good. > > Alan Stern Looks fine to me as well. Acked-by: Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH v3 0/2] staging: dwc2: add microframe scheduler

2013-09-23 Thread Dan Carpenter
On Mon, Sep 23, 2013 at 02:23:32PM -0700, Paul Zimmerman wrote: > There were some style-related comments from Dan Carpenter, but I > would prefer to have those as an additional patch, once we have > this known-good code added to the driver. > Sure. Just add a link to the TODO list so we don't fo

[PATCH 2/4] usb: xhci: kill a conditional when toggling cycle

2013-09-23 Thread Dan Williams
Perform an unconditional toggle of the cycle bit with 'xor'. Signed-off-by: Dan Williams --- drivers/usb/host/xhci-ring.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 411da1f..7c043ec 100644 --- a/driv

[PATCH 4/4] usb: xhci: change enumeration scheme to 'new scheme' by default

2013-09-23 Thread Dan Williams
Change the enumeration scheme for xhci attached devices from: SetAddress GetDescriptor(8) GetDescriptor(18) ...to: GetDescriptor(64) SetAddress GetDescriptor(18) ...as some devices misbehave when encountering a SetAddress command prior to GetDescriptor. There are known device

[PATCH 1/4] usb: hub_activate kill an 'else'

2013-09-23 Thread Dan Williams
Remove a few extra lines and make it clear that all implementations disable the port by sharing the same line of code. Cc: Alan Stern Signed-off-by: Dan Williams --- drivers/usb/core/hub.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/core/hub.c

[PATCH 3/4] usb: xhci: remove the unused ->address field

2013-09-23 Thread Dan Williams
Only used for debug output, so we don't need to save it. Signed-off-by: Dan Williams --- drivers/usb/host/xhci.c | 10 ++ drivers/usb/host/xhci.h |2 -- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 49b6edb..

[PATCH 0/4] usb: xhci: change default enumeration scheme and trivial cleanups

2013-09-23 Thread Dan Williams
Patch 4 is the only interesting one and adds support for the default enumeration scheme used by legacy hosts, details in the changelog. The others are just random cleanup items. The original discussion for patch 4 can be found here: http://marc.info/?l=linux-usb&m=135906806229309&w=2 This is al

Re: [PATCH] usb: LLVMLinux: Remove VLAIS from USB gadget

2013-09-23 Thread Behan Webster
On 09/23/13 18:53, charl...@gmail.com wrote: From: Mark Charlebois The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch removes the use of VLAIS in the gadget drive

Re: ehci-pci D3cold logspam

2013-09-23 Thread Rafael J. Wysocki
On Monday, September 23, 2013 04:28:49 PM Bjorn Helgaas wrote: > [+cc Rafael, linux-pm] > > On Mon, Sep 23, 2013 at 1:36 PM, Alan Stern wrote: > > On Mon, 23 Sep 2013, Andy Lutomirski wrote: > > > >> I've been getting this on several recent kernel revisions. Is it > >> interesting? If so, I'm h

[PATCH] usb: LLVMLinux: Remove VLAIS from USB gadget

2013-09-23 Thread charlebm
From: Mark Charlebois The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch removes the use of VLAIS in the gadget driver. This version has been tested to compile cle

Re: [PATCH] USB: Removing the use of VLAIS from the gadget driver

2013-09-23 Thread Behan Webster
On 09/23/13 16:24, Felipe Balbi wrote: Hi, On Thu, Aug 01, 2013 at 09:35:44PM -0400, beh...@converseincode.com wrote: From: Behan Webster The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the

Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-09-23 Thread Stephen Warren
On 09/23/2013 01:32 PM, Felipe Balbi wrote: > Hi, > > On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote: >> From: "Ivan T. Ivanov" >> >> MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) >> and HS, SS PHY's control and configuration registers. >> >> It could operate

RE: [PATCH v3 1/2] staging: dwc2: validate urb->actual_length for OUT endpoints

2013-09-23 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Monday, September 23, 2013 2:45 PM > > On Mon, Sep 23, 2013 at 02:23:33PM -0700, Paul Zimmerman wrote: > > In dwc2_assign_and_init_hc(), validate urb->actual_length for OUT > > endpoints before using the value. This fix is from the Synopsys > > ve

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Greg KH
On Mon, Sep 23, 2013 at 04:38:22PM -0500, Bjorn Helgaas wrote: > On Mon, Sep 23, 2013 at 3:49 PM, Greg KH wrote: > > On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia Ragiadakou wrote: > >> On 09/23/2013 07:45 PM, Sarah Sharp wrote: > >> >On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wr

Re: [PATCH v3] davinci: fix resources passed to MUSB driver for DM6467

2013-09-23 Thread Felipe Balbi
On Tue, Sep 24, 2013 at 12:50:12AM +0400, Sergei Shtylyov wrote: > Hello. > > On 09/24/2013 12:42 AM, Felipe Balbi wrote: > > >>After commit 09fc7d22b024692b2fe8a943b246de1af307132b (usb: musb: fix > >>incorrect > >>usage of resource pointer), CPPI DMA driver on DaVinci DM6467 can't detect > >

Re: [PATCH v3 1/2] staging: dwc2: validate urb->actual_length for OUT endpoints

2013-09-23 Thread Felipe Balbi
Hi, On Mon, Sep 23, 2013 at 02:23:33PM -0700, Paul Zimmerman wrote: > In dwc2_assign_and_init_hc(), validate urb->actual_length for OUT > endpoints before using the value. This fix is from the Synopsys > vendor driver. > > Signed-off-by: Paul Zimmerman > --- > drivers/staging/dwc2/hcd.c | 4 +++

Re: [PATCH] usb: dwc3: gadget: don't request IRQs in atomic

2013-09-23 Thread Felipe Balbi
Hi, On Mon, Sep 23, 2013 at 02:06:12PM -0700, Greg KH wrote: > On Mon, Sep 23, 2013 at 02:26:29PM -0500, Felipe Balbi wrote: > > mainline commit b0d7ffd44ba9cd2dfbf299674418193a5f9ed21a > > > > We cannot request an IRQ with spinlocks held > > as that would trigger a sleeping inside > > spinlock w

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Bjorn Helgaas
On Mon, Sep 23, 2013 at 3:49 PM, Greg KH wrote: > On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia Ragiadakou wrote: >> On 09/23/2013 07:45 PM, Sarah Sharp wrote: >> >On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wrote: >> >>The function pci_write_config_dword() sets the appropriate by

EHCI bus glue driver works for storage, fails for a WiFi module

2013-09-23 Thread Arokux X
Hi, recently I was working on porting EHCI HCD bus glue driver from the vendors kernel tree to the mainline [1]. I've got the storage (USB stick and USB external hard drive) working and was happy. However it does not work completely. Specifically something goes wrong if WiFi module is talked to. T

Re: ehci-pci D3cold logspam

2013-09-23 Thread Bjorn Helgaas
[+cc Rafael, linux-pm] On Mon, Sep 23, 2013 at 1:36 PM, Alan Stern wrote: > On Mon, 23 Sep 2013, Andy Lutomirski wrote: > >> I've been getting this on several recent kernel revisions. Is it >> interesting? If so, I'm happy to help diagnose it. If not, can the >> message be killed or severely r

[PATCH v3 1/2] staging: dwc2: validate urb->actual_length for OUT endpoints

2013-09-23 Thread Paul Zimmerman
In dwc2_assign_and_init_hc(), validate urb->actual_length for OUT endpoints before using the value. This fix is from the Synopsys vendor driver. Signed-off-by: Paul Zimmerman --- drivers/staging/dwc2/hcd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/dwc2/hcd.c b/drive

[PATCH v3 2/2] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-09-23 Thread Paul Zimmerman
From: Dom Cobley The transfer scheduler in the dwc2 driver is pretty basic, not to mention buggy. It works fairly well with just a couple of devices plugged in, but if you add, say, multiple devices with periodic endpoints, the scheduler breaks down and can't even enumerate all the devices. To i

[PATCH v3 0/2] staging: dwc2: add microframe scheduler

2013-09-23 Thread Paul Zimmerman
Here is the third version of the microframe scheduler patch. This version removes the NAK holdoff patch from the series, since it was effectively a no-op as pointed out by Matthijs. It also splits out into a separate patch one hunk which was not part of the downstream patch. It also acknowledges de

Re: [PATCH] usb: dwc3: gadget: don't request IRQs in atomic

2013-09-23 Thread Greg KH
On Mon, Sep 23, 2013 at 02:26:29PM -0500, Felipe Balbi wrote: > mainline commit b0d7ffd44ba9cd2dfbf299674418193a5f9ed21a > > We cannot request an IRQ with spinlocks held > as that would trigger a sleeping inside > spinlock warning. > > Cc: # v3.10 v3.11 > Reported-by: Stephen Boyd > Signed-off-

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Greg KH
On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia Ragiadakou wrote: > On 09/23/2013 07:45 PM, Sarah Sharp wrote: > >On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wrote: > >>The function pci_write_config_dword() sets the appropriate byteordering > >>internally so the value argument should

Re: [PATCH v3] davinci: fix resources passed to MUSB driver for DM6467

2013-09-23 Thread Sergei Shtylyov
Hello. On 09/24/2013 12:42 AM, Felipe Balbi wrote: After commit 09fc7d22b024692b2fe8a943b246de1af307132b (usb: musb: fix incorrect usage of resource pointer), CPPI DMA driver on DaVinci DM6467 can't detect its dedicated IRQ and so the MUSB IRQ is erroneously used instead. This is because only

Re: [PATCH v3] davinci: fix resources passed to MUSB driver for DM6467

2013-09-23 Thread Felipe Balbi
Hi, On Sun, Sep 22, 2013 at 01:43:58AM +0400, Sergei Shtylyov wrote: > After commit 09fc7d22b024692b2fe8a943b246de1af307132b (usb: musb: fix > incorrect > usage of resource pointer), CPPI DMA driver on DaVinci DM6467 can't detect > its > dedicated IRQ and so the MUSB IRQ is erroneously used in

Re: [PATCH v3 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-09-23 Thread Felipe Balbi
On Thu, Sep 19, 2013 at 08:38:23PM +0800, Peter Chen wrote: > On Thu, Sep 19, 2013 at 09:24:15AM +0200, Daniele Forsi wrote: > > 2013/9/19 Peter Chen: > > > > > + "milliseconds to increase successive wakup delays"); > > > > there's a typo: s/wakup/wakeup/ > > > > Thanks, I think I

Re: [PATCH] USB: Removing the use of VLAIS from the gadget driver

2013-09-23 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 09:35:44PM -0400, beh...@converseincode.com wrote: > From: Behan Webster > > The use of variable length arrays in structs (VLAIS) in the Linux Kernel code > precludes the use of compilers which don't implement VLAIS (for instance the > Clang compiler). This patch remo

Re: [PATCH] usb: gadget LLVMLinux: Removing the use of VLAIS from the gadget driver

2013-09-23 Thread Behan Webster
On 09/23/13 15:08, Linus Torvalds wrote: On Mon, Sep 23, 2013 at 12:30 PM, Felipe Balbi wrote: I remember there was a discussion of not dropping variable length array support, wasn't there ? We should definitely drop it. The feature is an abomination. I thought gcc only allowed them at the end

Re: [PATCH v6 7/8] ARM: dts: omap4: update omap-control-usb nodes

2013-09-23 Thread Felipe Balbi
Hi, On Mon, Aug 26, 2013 at 06:08:32PM +0300, Roger Quadros wrote: > Split otghs_ctrl and USB2 PHY power down into separate > omap-control-usb nodes. Get rid of "ti,type" property. > > Also get rid of "ti,has-mailbox" property from usb_otg_hs > node and provide the ctrl-module phandle. > > CC: B

Re: [PATCH] usb: gadget LLVMLinux: Removing the use of VLAIS from the gadget driver

2013-09-23 Thread Linus Torvalds
On Mon, Sep 23, 2013 at 12:30 PM, Felipe Balbi wrote: > > I remember there was a discussion of not dropping variable length array > support, wasn't there ? We should definitely drop it. The feature is an abomination. I thought gcc only allowed them at the end of structs, in the middle of a struct

Re: [PATCH] usb: gadget LLVMLinux: Removing the use of VLAIS from the gadget driver

2013-09-23 Thread Behan Webster
On 09/23/13 14:30, Felipe Balbi wrote: Hi, On Thu, Sep 05, 2013 at 08:07:11PM -0400, Behan Webster wrote: Replying to my patch email just in case it was missed before. I remember there was a discussion of not dropping variable length array support, wasn't there ? There was mostly an objection

Re: Mx28 USB workaround for errata

2013-09-23 Thread Alan Stern
On Mon, 23 Sep 2013, Robert Hodaszi wrote: > Hi, > > I had a lot of USB errors on i.mx28. I could reproduce it most easily > with USB-serial adapters, and USB modems (CDC and WWAN drivers). If I > sent some data to the TTY port with the echo command in a loop (so > basically open the port, sen

Re: [PATCH v6 8/8] ARM: dts: omap5: update omap-control-usb node

2013-09-23 Thread Felipe Balbi
On Mon, Aug 26, 2013 at 06:08:33PM +0300, Roger Quadros wrote: > Split USB2 PHY and USB3 PHY into separate omap-control-usb > nodes. Get rid of "ti,type" property. > > CC: Benoit Cousson > Signed-off-by: Roger Quadros Benoit ? ping here too... -- balbi signature.asc Description: Digital sig

Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-09-23 Thread Felipe Balbi
Hi, On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > (SNPS) and HS, SS PHY's control and configuration registers. > > It could operate in device mode (SS, HS, FS) and host > mode (SS, HS, FS

Re: [PATCH v5 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's

2013-09-23 Thread Felipe Balbi
Hi, On Wed, Aug 21, 2013 at 04:29:45PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > These drivers handles control and configuration of the HS > and SS USB PHY transceivers. They are part of the driver > which manage Synopsys DesignWare USB3 controller stack > inside Qualcomm SoC's.

Re: [PATCH v4 1/3] usb: dwc3: msm: Add device tree binding information

2013-09-23 Thread Felipe Balbi
Hi, On Tue, Aug 20, 2013 at 12:56:03PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > (SNPS) and HS, SS PHY's control and configuration registers. > > It could operate in device mode (SS, HS, FS) and host > mode (SS, HS, FS

Re: [PATCH] usb: gadget LLVMLinux: Removing the use of VLAIS from the gadget driver

2013-09-23 Thread Felipe Balbi
Hi, On Thu, Sep 05, 2013 at 08:07:11PM -0400, Behan Webster wrote: > Replying to my patch email just in case it was missed before. I remember there was a discussion of not dropping variable length array support, wasn't there ? -- balbi signature.asc Description: Digital signature

[PATCH] usb: dwc3: gadget: don't request IRQs in atomic

2013-09-23 Thread Felipe Balbi
mainline commit b0d7ffd44ba9cd2dfbf299674418193a5f9ed21a We cannot request an IRQ with spinlocks held as that would trigger a sleeping inside spinlock warning. Cc: # v3.10 v3.11 Reported-by: Stephen Boyd Signed-off-by: Felipe Balbi --- Paul reported that this patch wasn't on v3.11 so I cherry

Mx28 USB workaround for errata

2013-09-23 Thread Robert Hodaszi
Hi, I had a lot of USB errors on i.mx28. I could reproduce it most easily with USB-serial adapters, and USB modems (CDC and WWAN drivers). If I sent some data to the TTY port with the echo command in a loop (so basically open the port, send data, and close the port), all of the devices were d

Re: ehci-pci D3cold logspam

2013-09-23 Thread Alan Stern
On Mon, 23 Sep 2013, Andy Lutomirski wrote: > I've been getting this on several recent kernel revisions. Is it > interesting? If so, I'm happy to help diagnose it. If not, can the > message be killed or severely ratelimited? I'm getting so much of > this that it tends to overflow the log ring.

ehci-pci D3cold logspam

2013-09-23 Thread Andy Lutomirski
I've been getting this on several recent kernel revisions. Is it interesting? If so, I'm happy to help diagnose it. If not, can the message be killed or severely ratelimited? I'm getting so much of this that it tends to overflow the log ring. [ 287.344991] ehci-pci :00:1d.0: power state c

Re: [PATCH 36/51] DMA-API: usb: use dma_set_coherent_mask()

2013-09-23 Thread Russell King - ARM Linux
On Mon, Sep 23, 2013 at 02:27:39PM -0400, Alan Stern wrote: > On Thu, 19 Sep 2013, Russell King wrote: > > > The correct way for a driver to specify the coherent DMA mask is > > not to directly access the field in the struct device, but to use > > dma_set_coherent_mask(). Only arch and bus code s

Re: [PATCH 4/4] RX-51: Add platform function and data for bq24150a charger

2013-09-23 Thread Tony Lindgren
* Pali Rohár [130920 12:29]: > On Sunday 08 September 2013 10:50:39 Pali Rohár wrote: > > This patch will register bq24150a charger in RX-51 board data. > > Patch also adding platform function between isp1704 and > > bq2415x drivers for detecting charger type. > > > > So finally charging battery

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Xenia Ragiadakou
On 09/23/2013 07:45 PM, Sarah Sharp wrote: On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wrote: The function pci_write_config_dword() sets the appropriate byteordering internally so the value argument should not be converted to little-endian. This bug was found by sparse. Can you g

Re: [PATCH v2 2/9] usb: phy: nop: Don't use regulator framework for RESET line

2013-09-23 Thread Roger Quadros
Hi Felipe, There is an issue with this patch and is shown below. I will send a v3 for this. On 08/15/2013 01:18 PM, Roger Quadros wrote: > Modelling the RESET line as a regulator supply wasn't a good idea > as it kind of abuses the regulator framework and also makes adaptation > code more complex

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-09-23 Thread Sarah Sharp
On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wrote: > The function pci_write_config_dword() sets the appropriate byteordering > internally so the value argument should not be converted to little-endian. > This bug was found by sparse. Can you give the exact error or warning message t

Re: [PATCH v4 0/2] usb: implement AMD remote wakeup quirk

2013-09-23 Thread Alan Stern
On Mon, 16 Sep 2013, Huang Rui wrote: > Hi Greg, Sarah, Alan, > > The following patches are required to resolve remote wake issues with > certain devices. > > Issue description: > If the remote wake is issued from the device in a specific timing > condition while the system is entering sleep sta

[GIT PATCH] USB fixes for 3.12-rc2

2013-09-23 Thread Greg KH
The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f: Linux 3.12-rc1 (2013-09-16 16:17:51 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.12-rc2 for you to fetch changes up to 42f4891ca29a3c15356

Re: [PATCH v2] usb: usbtest: bmAttributes would better be masked

2013-09-23 Thread Alan Stern
On Tue, 24 Sep 2013, Huang Rui wrote: > When transfer type is isochronous, the other bits (bits 5..2) of > bmAttributes in endpoint descriptor might not be set zero. So it's better > to use usb_endpoint_type routine to mask bmAttributes with > USB_ENDPOINT_XFERTYPE_MASK to judge the transfter type

Re: [PATCH] xhci: Fix race between ep halt and URB cancellation

2013-09-23 Thread Sarah Sharp
Thanks Florian. I was waiting for after the 3.12 merge window to close to send Greg bug fixes. I'm queuing this up for test today, and will send it out once it passes. Sarah Sharp On Sun, Sep 22, 2013 at 09:09:54PM +0200, Florian Wolter wrote: > Hi Sarah, > > the described Problem also exisits

Re: [PATCH 4/7] pcmcia: at91_cf: fix deferred probe from __init

2013-09-23 Thread Nicolas Ferre
On 23/09/2013 16:27, Johan Hovold : Move probe out of __init section and don't use platform_driver_probe which cannot be used with deferred probing. Since commit e9354576 ("gpiolib: Defer failed gpio requests by default") this driver might return -EPROBE_DEFER if a gpio_request fails. Cc: Jean-

[resolved] No keyboard and mouse usb detected at startup.

2013-09-23 Thread HacKurx
It looks like your system did not load the ohci-pci driver. Is CONFIG_USB_OHCI_HCD_PCI enabled? Thanks my problem was there. As I do not have PCI card (Peripheral Component Interconnect) I had not enabled this option thinking I didn't need that... Thank you very much for your help and for y

[PATCH v2] usb: usbtest: bmAttributes would better be masked

2013-09-23 Thread Huang Rui
When transfer type is isochronous, the other bits (bits 5..2) of bmAttributes in endpoint descriptor might not be set zero. So it's better to use usb_endpoint_type routine to mask bmAttributes with USB_ENDPOINT_XFERTYPE_MASK to judge the transfter type later. Signed-off-by: Huang Rui --- Changes

Re: [PATCH] usb/core/devio.c:tolerate wrong direction flag in control endpoints

2013-09-23 Thread Kurt Garloff
Hi Alan, Alan Stern schrieb: > On Mon, 23 Sep 2013, Kurt Garloff wrote: > > > >> that qualifies as a bug or not. Maybe it should not claim to be a > > >> HID device then? > > > Maybe not. This particular combination of bRequestType and > bRequest > > > values (0x22, 0x09) is not defined in t

Re: [PATCH v3 4/5] dma: cppi41: only allocate descriptor memory once

2013-09-23 Thread Vinod Koul
On Mon, Sep 23, 2013 at 04:51:06PM +0200, Sebastian Andrzej Siewior wrote: > On 09/23/2013 06:17 AM, Vinod Koul wrote: > > Looks fine, Sebastian cna you test it pls > > Just noticed that you already applied some of them. I just got back > after a few weeks of. Will review & test as soon as I get t

Re: [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Sascha Hauer
On Mon, Sep 23, 2013 at 05:20:18PM +0200, Johan Hovold wrote: > On Mon, Sep 23, 2013 at 04:50:29PM +0200, Sascha Hauer wrote: > > On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote: > > > Deferred probing cannot be used with platform_driver_probe as by the > > > time probing is retried ei

Re: [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Johan Hovold
On Mon, Sep 23, 2013 at 04:50:29PM +0200, Sascha Hauer wrote: > On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote: > > Deferred probing cannot be used with platform_driver_probe as by the > > time probing is retried either the driver has been unregistered or its > > probe function has be

Re: [PATCH] usb: usbtest: bmAttributes would better be masked

2013-09-23 Thread Huang Rui
On Mon, Sep 23, 2013 at 10:32:30AM -0400, Alan Stern wrote: > On Mon, 23 Sep 2013, Huang Rui wrote: > > > When transfer type is isochronous, the other bits (bits 5..2) of > > bmAttributes in > > endpoint descriptor might not be set zero. So it's better to mask > > bmAttributes > > with USB_ENDPO

Re: [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Sascha Hauer
On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote: > Deferred probing cannot be used with platform_driver_probe as by the > time probing is retried either the driver has been unregistered or its > probe function has been set to platform_drv_probe_fail. > > With commit e9354576 ("gpiolib

RE: [PATCH]fsl/usb: Workarourd for USB erratum-A005697

2013-09-23 Thread Alan Stern
On Fri, 20 Sep 2013, Mehresh Ramneek-B31383 wrote: > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Thursday, September 19, 2013 7:03 PM > To: Mehresh Ramneek-B31383 > Cc: linux-usb@vger.kernel.org > Subject: Re: [PATCH]fsl/usb: Workarourd for USB erratum-A005697 > > On Thu, 19 Sep

Re: [PATCH 3/4] usb: musb: am335x: Do not remove the session bit HOST-only mode

2013-09-23 Thread Sebastian Andrzej Siewior
On 09/20/2013 05:45 PM, Felipe Balbi wrote: > > Acked-by: Felipe Balbi > Those four patches went already in, for instance: commit 781f17983015dae33324e34d1bb831e715fa04d4 Author: Sebastian Andrzej Siewior AuthorDate: Tue Aug 20 18:35:49 2013 +0200 Commit: Felipe Balbi CommitDate: Tue

Re: [PATCH v3 4/5] dma: cppi41: only allocate descriptor memory once

2013-09-23 Thread Sebastian Andrzej Siewior
On 09/23/2013 06:17 AM, Vinod Koul wrote: > Looks fine, Sebastian cna you test it pls Just noticed that you already applied some of them. I just got back after a few weeks of. Will review & test as soon as I get to it. > > ~Vinod > Sebastian -- To unsubscribe from this list: send the line "uns

Re: [PATCH] usb: usbtest: bmAttributes would better be masked

2013-09-23 Thread Alan Stern
On Mon, 23 Sep 2013, Huang Rui wrote: > When transfer type is isochronous, the other bits (bits 5..2) of bmAttributes > in > endpoint descriptor might not be set zero. So it's better to mask bmAttributes > with USB_ENDPOINT_XFERTYPE_MASK to judge the transfter type later. > > Signed-off-by: Huan

[PATCH 1/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Johan Hovold
Prevent drivers relying on platform_driver_probe from requesting deferred probing in order to avoid further futile probe attempts (either the driver has been unregistered or its probe function has been set to platform_drv_probe_fail when probing is retried). Note that several platform drivers curr

[PATCH 7/7] backlight: atmel-pwm-bl: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
Move probe out of __init section and don't use platform_driver_probe which cannot be used with deferred probing. Since commit e9354576 ("gpiolib: Defer failed gpio requests by default") this driver might return -EPROBE_DEFER if a gpio_request fails. Cc: Richard Purdie Cc: Jingoo Han Cc: Jean-Ch

[PATCH 2/7] mmc: mvsdio: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
Move probe out of __init section and don't use platform_driver_probe which cannot be used with deferred probing. Since commit e9354576 ("gpiolib: Defer failed gpio requests by default") this driver might return -EPROBE_DEFER if the mmc_gpio_request_cd fails. Cc: Nicolas Pitre Cc: Chris Ball Sig

[PATCH 6/7] usb: phy: gpio-vbus: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
Move probe out of __init section and don't use platform_driver_probe which cannot be used with deferred probing. Since commit e9354576 ("gpiolib: Defer failed gpio requests by default") and 04bf3011 ("regulator: Support driver probe deferral") this driver might return -EPROBE_DEFER if a gpio_reque

[PATCH 4/7] pcmcia: at91_cf: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
Move probe out of __init section and don't use platform_driver_probe which cannot be used with deferred probing. Since commit e9354576 ("gpiolib: Defer failed gpio requests by default") this driver might return -EPROBE_DEFER if a gpio_request fails. Cc: Jean-Christophe PLAGNIOL-VILLARD Cc: Nicol

[PATCH 5/7] usb: gadget: pxa25x_udc: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
Move probe out of __init section and don't use platform_driver_probe which cannot be used with deferred probing. Since commit e9354576 ("gpiolib: Defer failed gpio requests by default") this driver might return -EPROBE_DEFER if a gpio_request fails. Cc: Eric Miao Cc: Russell King Cc: Haojian Zh

Re: [PATCH] usb/core/devio.c:tolerate wrong direction flag in control endpoints

2013-09-23 Thread Alan Stern
On Mon, 23 Sep 2013, Kurt Garloff wrote: > >> that qualifies as a bug or not. Maybe it should not claim to be a > >> HID device then? > > Maybe not. This particular combination of bRequestType and bRequest > > values (0x22, 0x09) is not defined in the HID 1.11 spec. Do you know > > if it is de

[PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Johan Hovold
Deferred probing cannot be used with platform_driver_probe as by the time probing is retried either the driver has been unregistered or its probe function has been set to platform_drv_probe_fail. With commit e9354576 ("gpiolib: Defer failed gpio requests by default") the gpio subsystem started ret

[PATCH 3/7] mtd: atmel_nand: fix deferred probe from __init

2013-09-23 Thread Johan Hovold
Move probe out of __init section and don't use platform_driver_probe which cannot be used with deferred probing. Since commit e9354576 ("gpiolib: Defer failed gpio requests by default") this driver might return -EPROBE_DEFER if a gpio_request fails. Cc: David Woodhouse Cc: Josh Wu Signed-off-by

Re: No keyboard and mouse usb detected at startup.

2013-09-23 Thread Alan Stern
On Mon, 23 Sep 2013, Kumar Gaurav wrote: > Hi Alan, > I have one question just for knowledge. I was looking for the reason of > this bug but wasn't even able to identify which driver (ehci,xhci etc) > these devices are using. I tried inspecting with my USB mouse and found > out it was ehci (i b

Re: [PATCH] USB: gadget: s3c-hsotg: add isochronous transfers support

2013-09-23 Thread Bartlomiej Zolnierkiewicz
Hi Robert, On Monday, September 23, 2013 10:07:12 AM Robert Baldyga wrote: > This patch adds isochronous transfer support. It adds few modifications: > - Modify s3c_hsotg_write_fifo() function. It actually calculates transfer > size, taking into account Multi Count value, which indicates number

[PATCH] usb: usbtest: bmAttributes would better be masked

2013-09-23 Thread Huang Rui
When transfer type is isochronous, the other bits (bits 5..2) of bmAttributes in endpoint descriptor might not be set zero. So it's better to mask bmAttributes with USB_ENDPOINT_XFERTYPE_MASK to judge the transfter type later. Signed-off-by: Huang Rui --- drivers/usb/misc/usbtest.c | 3 ++- 1 fi

Re: [PATCH v7 09/10] usb: dwc3: omap: manage "usb_otg_ss_refclk960m" clock

2013-09-23 Thread Roger Quadros
Hi Felipe, On 09/18/2013 03:49 PM, Roger Quadros wrote: > "usb_otg_ss_refclk960m" is an optional functional clock to the > UBS_OTG_SS module. So manage it in the driver. > Just realized that "usb_otg_ss_refclk960m" is in fact functional clock to the PHY and not USB_OTG_SS module. The name is mi

[PATCH v1] USBNET: fix handling padding packet

2013-09-23 Thread Ming Lei
Commit 638c5115a7949(USBNET: support DMA SG) introduces DMA SG if the usb host controller is capable of building packet from discontinuous buffers, but missed handling padding packet when building DMA SG. This patch attachs the pre-allocated padding packet at the end of the sg list, so padding pac

Re: [PATCH] usb/core/devio.c:tolerate wrong direction flag in control endpoints

2013-09-23 Thread Kurt Garloff
Hi Alan, On 09/23/2013 04:28 AM, Alan Stern wrote: > On Sun, 22 Sep 2013, Kurt Garloff wrote: > >> Well, this seems to be a question of terminology, no? >> I saw the endpoint byte as consisting of endpoint index plus the direction >> bit. > See the entry for "Endpoint Address" in Chapter 2 (Terms

  1   2   >