Re: [PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data

2013-08-20 Thread Roger Quadros
Hi Thomas, On 08/20/2013 06:04 PM, thomas.lan...@lantiq.com wrote: > Hello Roger, > > this will not work! > > Roger Quadros wrote on 2013-08-20: > >> -struct omap_control_usb_platform_data *pdata = >> -dev_get_platdata(&pdev->dev); >> + >> +if (np) { >> +

Re: [PATCH v5 5/8] usb: musb: omap2430: Don't use omap_get_control_dev()

2013-08-20 Thread Roger Quadros
On 08/20/2013 08:57 PM, Sergei Shtylyov wrote: > Hello. > > On 08/20/2013 06:56 PM, Roger Quadros wrote: > >> omap_get_control_dev() is being deprecated as it doesn't support >> multiple instances. As control device is present only from OMAP4 >> onwards which supports DT only, we use phandles to

Re: [PATCH] Fix stack corruption on some architectures

2013-08-20 Thread David Miller
Please submit this with a more appropriate subject line. After '[PATCH] ' there should be a subsystem or driver name prefix, followed up a semicolon. Here it could be "hso: ", so something like: [PATCH] hso: Fix stack corruption on some architectures. -- To unsubscribe from this list: send the

Re: USB gadget on mx6

2013-08-20 Thread Marek Vasut
Dear Peter Chen, [...] > > Setting up networking on loopback device: > > rm: can't remove '/etc/resolv.conf': Permission denied > > Setting up networking on eth0: > > You need to manually set your nameserver in /etc/resolv.conf > > chown: /home/user/.rhosts: Operation not permitted > > chown: /ho

[PATCH v11 3/8] usb: phy: twl4030: use the new generic PHY framework

2013-08-20 Thread Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. For powering on and powering off the PHY, power_on and power_off ops are used. Once the MUSB OMAP glue is adapted to the new framework, the suspend and resume ops of usb phy library will be removed. Also twl4030-usb driver is moved to drivers/ph

[PATCH v11 0/8] PHY framework

2013-08-20 Thread Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded w

[PATCH v11 6/8] usb: musb: omap2430: use the new generic PHY framework

2013-08-20 Thread Kishon Vijay Abraham I
Use the generic PHY framework API to get the PHY. The usb_phy_set_resume and usb_phy_set_suspend is replaced with power_on and power_off to align with the new PHY framework. musb->xceiv can't be removed as of now because musb core uses xceiv.state and xceiv.otg. Once there is a separate state mach

[PATCH v11 5/8] ARM: dts: omap: update usb_otg_hs data

2013-08-20 Thread Kishon Vijay Abraham I
Updated the usb_otg_hs dt data to include the *phy* and *phy-names* binding in order for the driver to use the new generic PHY framework. Also updated the Documentation to include the binding information. The PHY binding information can be found at Documentation/devicetree/bindings/phy/phy-bindings

[PATCH v11 7/8] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2

2013-08-20 Thread Kishon Vijay Abraham I
Now that omap-usb2 is adapted to the new generic PHY framework, *set_suspend* ops can be removed from omap-usb2 driver. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- drivers/phy/phy-omap-usb2.c | 25 - 1 file changed,

[PATCH v11 4/8] arm: omap3: twl: add phy consumer data in twl4030_usb_data

2013-08-20 Thread Kishon Vijay Abraham I
The PHY framework uses the phy consumer data populated in platform data in the case of non-dt boot to return the reference to the PHY when the controller (PHY consumer) requests for it. So populated the phy consumer data in the platform data of twl usb. Signed-off-by: Kishon Vijay Abraham I ---

[PATCH v11 2/8] usb: phy: omap-usb2: use the new generic PHY framework

2013-08-20 Thread Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. Now the power off and power on are done in omap_usb_power_off and omap_usb_power_on respectively. The omap-usb2 driver is also moved to driver/phy. However using the old USB PHY library cannot be completely removed because OTG is intertwined wi

[PATCH v11 8/8] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

2013-08-20 Thread Kishon Vijay Abraham I
Now that twl4030-usb is adapted to the new generic PHY framework, *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- drivers/phy/phy-twl4030-usb.c | 57 ++---

[PATCH v11 1/8] drivers: phy: add generic PHY framework

2013-08-20 Thread Kishon Vijay Abraham I
The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For dt-boot, the PHY drivers should also register *PHY provider* with the framework. PHY drivers should create the PHY by

Re: USB gadget on mx6

2013-08-20 Thread Fabio Estevam
Hi Marek, On Wed, Aug 21, 2013 at 12:50 AM, Marek Vasut wrote: > Does OTG work for you on MX28 ? The OTG ports works if I do peripheral only or host only. I can't switch roles. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kern

Re: USB gadget on mx6

2013-08-20 Thread Marek Vasut
Dear Fabio Estevam, > On Tue, Aug 20, 2013 at 10:32 PM, Peter Chen wrote: > > On Wed, Aug 21, 2013 at 12:26:33AM -0300, Fabio Estevam wrote: > > > > Have you enabled CONFIG_USB_CHIPIDEA_UDC? > > It is not enabled by default. > > Yes, I did. > > I managed to test g_ether on mx28, but not on mx6

Re: USB gadget on mx6

2013-08-20 Thread Fabio Estevam
On Tue, Aug 20, 2013 at 10:32 PM, Peter Chen wrote: > On Wed, Aug 21, 2013 at 12:26:33AM -0300, Fabio Estevam wrote: > Have you enabled CONFIG_USB_CHIPIDEA_UDC? > It is not enabled by default. Yes, I did. I managed to test g_ether on mx28, but not on mx6. Will try tomorrow on mx6q-sabresd. Th

Re: USB gadget on mx6

2013-08-20 Thread Peter Chen
On Wed, Aug 21, 2013 at 12:26:33AM -0300, Fabio Estevam wrote: > Hi Peter, > > On Tue, Aug 20, 2013 at 8:46 PM, Peter Chen wrote: > > On Mon, Aug 19, 2013 at 03:05:28PM -0300, Fabio Estevam wrote: > > > Hi Fabio, > > > > I have tried today's linux-nex

Re: USB gadget on mx6

2013-08-20 Thread Fabio Estevam
Hi Peter, On Tue, Aug 20, 2013 at 8:46 PM, Peter Chen wrote: > On Mon, Aug 19, 2013 at 03:05:28PM -0300, Fabio Estevam wrote: > Hi Fabio, > > I have tried today's linux-next (Linux version 3.11.0-rc6-next-20130820+) > The USB ether can be enumerated (I can't try

Re: USB gadget on mx6

2013-08-20 Thread Peter Chen
rl-0 = <&pinctrl_usbotg_1>; > + disable-over-current; > + dr_mode = "peripheral"; > + status = "okay"; > +}; > + > &usdhc1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usdhc1_2>; > &g

Re: [Bug] [Sony VAIO SVT15117CXS] USB 2.0 ports not working with any USB device

2013-08-20 Thread Kevin Archer
DMESG log from CONFIG_DUMMY_IRQ per your instructions [ 8561.353244] ath9k: ath9k: Driver unloaded [ 8627.529948] ehci-pci :00:1a.0: remove, state 1 [ 8627.529961] ehci-pci :00:1a.0: roothub graceful disconnect [ 8627.529973] usb usb1: USB disconnect, device number 1 [ 8627.529979] usb 1-1

[PATCH] clk: samsung: pll: Use new registration method for PLL6552 and PLL6553

2013-08-20 Thread Tomasz Figa
This patch modifies PLL6552 and PLL6553 clock drivers to use recently added common Samsung PLL registration method. Signed-off-by: Tomasz Figa --- drivers/clk/samsung/clk-pll.c | 105 +- drivers/clk/samsung/clk-pll.h | 6 +-- 2 files changed, 13 insertio

[PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-20 Thread Julius Werner
The driver methods required for hardware LPM have only been added to the PCI version of the XHCI driver, for no apparent reason. They seem to work just as well with the platform driver, so let's add them to give more devices the chance for additional power savings. Tested on the DWC3 xHC of an Exyn

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Chanwoo Choi
> + > +if (dra7xx_usb->irq_gpio) { > +status = devm_request_threaded_irq(dra7xx_usb->dev, irq_num, > +NULL, id_irq_handler, IRQF_SHARED | > +IRQF_ONESHOT | IRQF_TRIGGER_FALLING, > +dev_name(&pdev->dev), (void *) dra

Re: [Bug] [Sony VAIO SVT15117CXS] USB 2.0 ports not working with any USB device

2013-08-20 Thread Kevin Archer
Here are the registers for :00:1a.0 and :00:1d.0 prior to inserting any usb 2.0 device I have not included the "after" logs as there were no changes that occurred to the file(s) after a device was plugged in. Will work on and add the CONFIG_DUMMY_IRQ logs, but it appears there are errors i

Re: [RFC 2/2] xhci: refactor handle_cmd_completion() switch into separate function

2013-08-20 Thread Sarah Sharp
That's not quite what I wanted. :) What I wanted was for you to take each of the larger chunks of code in the case statements, and turn them into separate functions. I.e.: switch (le32_to_cpu(xhci->cmd_ring->dequeue->generic.field[3]) & TRB_TYPE_BITMASK) { case TR

Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 Device Driver into the Linux Kernel

2013-08-20 Thread Joe Perches
On Tue, 2013-08-20 at 22:46 +0200, Francois Romieu wrote: > liujunliang_ljl : > > + if (i >= SR_SHARE_TIMEOUT) { > > + netdev_err(dev->net, "%s read timed out!", phy ? "phy" : > > "eeprom"); netdev_, like almost all other printk messages needs a terminating "\n" newline to avoid any

Re: [PATCH] usb: xhci: Use non-interruptible sleep for XHCI commands

2013-08-20 Thread Julius Werner
Hi Sarah, I know you are probably swamped with patches, but this (https://patchwork.kernel.org/patch/2612831/) has been hanging a few months and I just wanted to double-check if it slipped through somewhere. I still think this is necessary (regardless of any command queue reengineering in the futu

Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 Device Driver into the Linux Kernel

2013-08-20 Thread Francois Romieu
liujunliang_ljl : [...] > We want to merge SR9700 device driver into the Linux Kernel. The following > is the Linux 3.10.7 version patch for SR9700, Please give us the assessment > and support. Welcome. Go ahead. [...] > diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c > new file

Re: [BUG] ohci-pci: devices not detected after hibernate

2013-08-20 Thread Steve Cotton
On Tue, Aug 20, 2013 at 03:43:28PM -0400, Alan Stern wrote: > On Tue, 20 Aug 2013, Steve Cotton wrote: > > > Once my PC has been hibernated and resumed, some devices plugged > > in to the on-motherboard ports stop working, and don't show up in > > lsusb. The pattern seems to be that ports with US

Re: Bug report: 045e:0721 Microsoft LifeCam NX-3000 not detected

2013-08-20 Thread Alan Stern
On Tue, 20 Aug 2013, Laurent Pinchart wrote: > Hi J�rgen, > > On Monday 12 August 2013 07:33:03 J�rgen Liebmann wrote: > > [1] > > 045e:0721 Microsoft LifeCam NX-3000 not detected > > > > [2] > > Since upgrate from quantal to raring I have the a problem with the webcam > > "Microsoft LifeCam NX-

Re: [PATCH 1/2] usb: fix cleanup after failure in hub_configure()

2013-08-20 Thread Alan Stern
On Tue, 20 Aug 2013, Krzysztof Mazur wrote: > > The second patch can either clean up the port devices by hand, or else > > jump to a new label after the line that sets maxchild to 0. > > Alan Stern > > I think that new label is better, it's equivalent to previous version > except for ugly rename

Re: [PATCH 2/2] usb: fail on usb_hub_create_port_device() errors

2013-08-20 Thread Alan Stern
On Tue, 20 Aug 2013, Krzysztof Mazur wrote: > On Tue, Aug 20, 2013 at 02:18:57PM -0400, Alan Stern wrote: > > On Tue, 20 Aug 2013, Krzysztof Mazur wrote: > > > > > Ignoring usb_hub_create_port_device() errors cause later NULL pointer > > > deference when uninitialized hub->ports[i] entries are de

Re: [BUG] ohci-pci: devices not detected after hibernate

2013-08-20 Thread Alan Stern
On Tue, 20 Aug 2013, Steve Cotton wrote: > Last working release: 3.10 > Bisected earliest broken: c1117afb85 > Broken in: 3.11-rc1, 3.11-rc6, bd479f2933 (the current usb-next) > > Once my PC has been hibernated and resumed, some devices plugged > in to the on-motherboard ports stop working, and d

Re: [PATCH 1/2] usb: fix cleanup after failure in hub_configure()

2013-08-20 Thread Krzysztof Mazur
On Tue, Aug 20, 2013 at 02:59:18PM -0400, Alan Stern wrote: > On Tue, 20 Aug 2013, Krzysztof Mazur wrote: > > > > Why bother with a separate jump label? Just set maxchild to 0 whenever > > > a failure occurs. > > > > > > > Initially I had just straightforward "dev->maxchild = 0;" after fail, >

Re: [PATCH 2/2] usb: fail on usb_hub_create_port_device() errors

2013-08-20 Thread Krzysztof Mazur
On Tue, Aug 20, 2013 at 02:18:57PM -0400, Alan Stern wrote: > On Tue, 20 Aug 2013, Krzysztof Mazur wrote: > > > Ignoring usb_hub_create_port_device() errors cause later NULL pointer > > deference when uninitialized hub->ports[i] entries are dereferenced > > after port memory allocation error. > >

Re: [PATCH 1/2] usb: fix cleanup after failure in hub_configure()

2013-08-20 Thread Alan Stern
On Tue, 20 Aug 2013, Krzysztof Mazur wrote: > > Why bother with a separate jump label? Just set maxchild to 0 whenever > > a failure occurs. > > > > Initially I had just straightforward "dev->maxchild = 0;" after fail, > but I changed that to simplify the second patch and be able to > use goto

Re: [PATCH 1/2] usb: fix cleanup after failure in hub_configure()

2013-08-20 Thread Krzysztof Mazur
On Tue, Aug 20, 2013 at 02:14:42PM -0400, Alan Stern wrote: > On Tue, 20 Aug 2013, Krzysztof Mazur wrote: > > > If the hub_configure() fails after setting the hdev->maxchild > > the hub->ports might be NULL or point to uninitialized kzallocated > > memory causing NULL pointer dereference in hub_qu

Re: [PATCH] xHCI:Fixing xhci_readl definition and function call

2013-08-20 Thread Sarah Sharp
Hi Kumar, This patch is much better, but it still needs a few improvements. :) Please make sure there's a space between xHCI: and the rest of your subject line. Also, when you revise a patch, you typically want to change the subject line to have a version. So in this case, your subject line sho

Re: [PATCH 2/2] usb: fail on usb_hub_create_port_device() errors

2013-08-20 Thread Alan Stern
On Tue, 20 Aug 2013, Krzysztof Mazur wrote: > Ignoring usb_hub_create_port_device() errors cause later NULL pointer > deference when uninitialized hub->ports[i] entries are dereferenced > after port memory allocation error. > > Signed-off-by: Krzysztof Mazur > --- > I'm not sure if failing in th

Re: [PATCH 1/2] usb: fix cleanup after failure in hub_configure()

2013-08-20 Thread Alan Stern
On Tue, 20 Aug 2013, Krzysztof Mazur wrote: > If the hub_configure() fails after setting the hdev->maxchild > the hub->ports might be NULL or point to uninitialized kzallocated > memory causing NULL pointer dereference in hub_quiesce() during cleanup. > > Now after such error the hdev->maxchild i

Re: [PATCH v5 5/8] usb: musb: omap2430: Don't use omap_get_control_dev()

2013-08-20 Thread Sergei Shtylyov
Hello. On 08/20/2013 06:56 PM, Roger Quadros wrote: omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. Also get rid of "t

Re: [Pull Request] xhci: Step 2 to fix usb-linus and usb-next.

2013-08-20 Thread Sarah Sharp
On Mon, Aug 19, 2013 at 05:01:01PM -0700, Greg KH wrote: > On Thu, Aug 15, 2013 at 06:44:03PM -0700, Sarah Sharp wrote: > > The following changes since commit 224563b6ce034b82f8511969d9496113da34fb2c: > > > > Merge tag 'for-usb-next-2013-08-15' of > > git://git.kernel.org/pub/scm/linux/kernel/g

[PATCH 2/2] usb: fail on usb_hub_create_port_device() errors

2013-08-20 Thread Krzysztof Mazur
Ignoring usb_hub_create_port_device() errors cause later NULL pointer deference when uninitialized hub->ports[i] entries are dereferenced after port memory allocation error. Signed-off-by: Krzysztof Mazur --- I'm not sure if failing in that case is a good idea, but other solutions are more comple

[PATCH 1/2] usb: fix cleanup after failure in hub_configure()

2013-08-20 Thread Krzysztof Mazur
If the hub_configure() fails after setting the hdev->maxchild the hub->ports might be NULL or point to uninitialized kzallocated memory causing NULL pointer dereference in hub_quiesce() during cleanup. Now after such error the hdev->maxchild is set to 0 to avoid cleanup of uninitialized ports. Su

[PATCH 0/2] usb: fix hub_configure() error handling

2013-08-20 Thread Krzysztof Mazur
Hi, this series fixes hub_configure() error handling that causes hub->ports[i] NULL pointer dereferences that were previously reported at: "[PATCH] Prevent USB hub remove oops" http://marc.info/?l=linux-kernel&m=136189072520909&w=4 https://bugzilla.redhat.com/show_bug.cgi?id=926907 This bug stil

Re: [PATCH 3/3] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-20 Thread Alan Stern
On Tue, 20 Aug 2013, Ming Lei wrote: > On Mon, Aug 19, 2013 at 10:33 PM, Greg Kroah-Hartman > wrote: > > > > Why would those events not need to be handled? > > For IAA_WATCHDOG event, it needn't to handle when > IAA interrupt comes. > > For START_UNLINK_INTR event, we don't need to unlink intr

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Pawel Moll
On Tue, 2013-08-20 at 16:06 +0100, Pawel Moll wrote: > On Tue, 2013-08-20 at 16:01 +0100, Kumar Gala wrote: > > On Aug 20, 2013, at 9:54 AM, Ivan T. Ivanov wrote: > > > > > > > > Hi, > > > > > > On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: > > >> On Tue, Aug 20, 2013 at 05:09:11PM +0

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Stephen Warren
On 08/20/2013 12:55 AM, George Cherian wrote: > Hi Stephen, > > Thanks for your review. > > On 8/20/2013 1:01 AM, Stephen Warren wrote: > >> On 08/16/2013 04:13 AM, George Cherian wrote: >>> Adding extcon driver for USB ID detection to dynamically >>> configure USB Host/Peripheral mode. >>> diff

[PATCH 09/11] usb: phy: am335x-control: make it compile with CONFIG_BUG=n

2013-08-20 Thread Sebastian Andrzej Siewior
Randy reported this |drivers/usb/phy/phy-am335x-control.c:45:3: error: implicit declaration |of function '__WARN' [-Werror=implicit-function-declaration] and left it as an excercice to figure out that this happens only with CONFIG_BUG=n. As a fix I replace it with WARN_ON(). Acked-by: Randy Dunla

[PATCH 10/11] dma: cpp41: make it compile with CONFIG_BUG=n

2013-08-20 Thread Sebastian Andrzej Siewior
Before Randy figures out that this does not compile with CONFIG_BUG=n here is a fix for it. Acked-by: Vinod Koul Signed-off-by: Sebastian Andrzej Siewior --- drivers/dma/cppi41.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c inde

[PATCH 11/11] dma: cpp41: enable pm_runtime during init

2013-08-20 Thread Sebastian Andrzej Siewior
With enabled pm_runtime in the kernel the device won't work because it is not "on" during the probe function. This patch enables the device via pm_runtime on probe so it remains activated. Cc: Vinod Koul Signed-off-by: Sebastian Andrzej Siewior --- drivers/dma/cppi41.c | 11 +++ 1 file

[PATCH 02/11] usb: musb: only remove host/udc if it has been added

2013-08-20 Thread Sebastian Andrzej Siewior
musb_shutdown() removes always USB host and device. musb_init_controller() adds host and device depending on port_mode. If port mode is set to HOST then the removal of UDC leads only to: |(NULL device *): gadget not registered. and nothing else happens. If port mode is set to DEVICE and we remove t

[PATCH 01/11] usb: musb: honour the return value of dma_map_single()

2013-08-20 Thread Sebastian Andrzej Siewior
Since dma_map_single() may fail it is good to actually check the return code to see if it succeeded. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/musb/musb_gadget.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/

[PATCH 07/11] usb: musb: am335x-evm: Do not remove the session bit HOST-only mode

2013-08-20 Thread Sebastian Andrzej Siewior
This is what I observe: On the first connect, the musb starts with DEVCTL.Session set. On disconnect, musb_core calls try_idle. That functions removes the Session bit signalizing that the session is over (something that only in OTG is required). A new device, that is plugged, is no longer recognize

musb / am335x / dsps fixes for usb-next

2013-08-20 Thread Sebastian Andrzej Siewior
The following changes since commit 67e51ec4ed09482b53a81fb33df81a2d5a15aa2f: uwb: Staticize local symbols (2013-08-19 17:08:16 -0700) are available in the git repository at: git://breakpoint.cc/bigeasy/linux tags/am335x-usb for you to fetch changes up to aa020e604f45fcbe210ba39e31034e4c5c04

[PATCH 04/11] usb: usb: dsps: update device tree bindings

2013-08-20 Thread Sebastian Andrzej Siewior
The support for both am335x-USB instances required changes to the device tree bindings. This patch reflects these changes in the bindings document. v3…v4: - remove the child node for USB. This is driver specific on won't be reflected in the device tree - use the "mentor" prefix instead of "mg".

[PATCH 03/11] usb: musb: dsps fix the typo in reg-names of the dma node

2013-08-20 Thread Sebastian Andrzej Siewior
I forgot to separete the different names in the reg-names property. This didn't cause anything to fail because the driver does not use the names and simply relies on the order of the memory offsets in reg. This patch fixes this in case it is used later. Signed-off-by: Sebastian Andrzej Siewior --

[PATCH 06/11] usb: musb: dsps: do not set is_active on the first drvbus interrupt

2013-08-20 Thread Sebastian Andrzej Siewior
Quite early on init there is an vbus / drvvbus interrupt comming and the dsps code sets is_active to one. As a result we see a lot of |musb_bus_suspend 2459: trying to suspend as a_wait_bcon while active until a device is plugged in with pm_runtime enabled in the kernel. After checking davinci, a

[PATCH 08/11] usb: musb: am335x: add second port to beagle bone

2013-08-20 Thread Sebastian Andrzej Siewior
So I assumed that Beagle bone has only one USB port in host mode because the micro USB connector had an USB-UART there. I was wrong a little. The second port runs on host mode, but the micro USB plug is connected to an internal HUB with two ports: one to the USB-UART and one to musb instance one. F

[PATCH 05/11] usb: usb: dsps: update code according to the binding document

2013-08-20 Thread Sebastian Andrzej Siewior
This relfects the code and dts requires changes due to recent .dts binding updates: - use mg prefix for the Metor Graphics specific attributes - use power in mA not in mA/2 as specifed in the USB2.0 specification - remove the child node for USB. This is driver specific on won't be reflected in th

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-20 Thread Alan Stern
On Fri, 16 Aug 2013, Mark Brown wrote: > > The difficulty with the first proposal is that subsystems aren't > > designed to allow that sort of thing. They expect to be able to > > communicate with the devices they manage, during enumeration and > > probing at least. The difficulty with the secon

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-20 Thread Alan Stern
On Fri, 16 Aug 2013, Mark Brown wrote: > On Fri, Aug 16, 2013 at 03:27:58PM -0400, Alan Stern wrote: > > On Fri, 16 Aug 2013, Mark Brown wrote: > > > > or those for getting platform data to a device when it > > > does enumerate. > > > ? I can't make any sense out of that comment. For one thin

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Ivan T. Ivanov
On Tue, 2013-08-20 at 10:01 -0500, Kumar Gala wrote: > On Aug 20, 2013, at 9:54 AM, Ivan T. Ivanov wrote: > > > > > Hi, > > > > On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: > >> On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: > >>> Hi, > >>> > >>> On Tue, 2013-08-20

[PATCH] usb: acm gadget: Null termintate strings table

2013-08-20 Thread Graham Williams
The gadget strings table should be null terminated. usb_gadget_get_string() loops through the table expecting a null at the end of the list. Signed-off-by: Graham --- drivers/usb/gadget/f_acm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_

RE: [PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data

2013-08-20 Thread thomas.langer
Hello Roger, this will not work! Roger Quadros wrote on 2013-08-20: > - struct omap_control_usb_platform_data *pdata = > - dev_get_platdata(&pdev->dev); > + > + if (np) { > + of_property_read_u32(np, "ti,type", &control_usb->type); here you are dereferenc

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Pawel Moll
On Tue, 2013-08-20 at 16:01 +0100, Kumar Gala wrote: > On Aug 20, 2013, at 9:54 AM, Ivan T. Ivanov wrote: > > > > > Hi, > > > > On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: > >> On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: > >>> Hi, > >>> > >>> On Tue, 2013-08-20

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-20 Thread Mark Brown
On Tue, Aug 20, 2013 at 09:19:07PM +0800, Ming Lei wrote: > On Tue, Aug 20, 2013 at 12:01 AM, Mark Brown wrote: > > I can't parse this at all well - why would DT want to refer to ACPI, do > > you mean people may wish to look at the code as an example? As Grant > I mean usb-acpi provides one app

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Kumar Gala
On Aug 20, 2013, at 9:54 AM, Ivan T. Ivanov wrote: > > Hi, > > On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: >> On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: >>> Hi, >>> >>> On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: Hi, On Tue, Aug 20,

[PATCH v5 5/8] usb: musb: omap2430: Don't use omap_get_control_dev()

2013-08-20 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. Also get rid of "ti,has-mailbox" property as it is redundant and we can dete

[PATCH v5 6/8] usb: phy: omap: get rid of omap_get_control_dev()

2013-08-20 Thread Roger Quadros
This function was preventing us from supporting multiple instances. Get rid of it. Since we support DT boots only, users can get the control device phandle from the DT node. Signed-off-by: Roger Quadros --- drivers/usb/phy/phy-omap-control.c | 31 ++- include/linu

[PATCH v5 8/8] ARM: dts: omap5: update omap-control-usb node

2013-08-20 Thread Roger Quadros
Split USB2 PHY and USB3 PHY into separate omap-control-usb nodes. Get rid of "ti,type" property. CC: Benoit Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap5.dtsi | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/omap5.

[PATCH v5 4/8] usb: phy: omap-usb3: Don't use omap_get_control_dev()

2013-08-20 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. As we don't support non-DT boot, we just bail out on probe if device node is

[PATCH v5 2/8] usb: phy: omap: Add new device types and remove omap_control_usb3_phy_power()

2013-08-20 Thread Roger Quadros
Add support for new device types and in the process rid of "ti,type" device tree property. The correct type of device will be determined from the compatible string instead. Introduce a compatible string for each device type. At the moment we support 4 types Mailbox, USB2, USB3 and DRA7. Update DT

[PATCH v5 7/8] ARM: dts: omap4: update omap-control-usb nodes

2013-08-20 Thread Roger Quadros
Split otghs_ctrl and USB2 PHY power down into separate omap-control-usb nodes. Get rid of "ti,type" property. Also get rid of "ti,has-mailbox" property from usb_otg_hs node and provide the ctrl-module phandle. CC: Benoit Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap4.dtsi |

[PATCH v5 3/8] usb: phy: omap-usb2: Don't use omap_get_control_dev()

2013-08-20 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. As we don't support non-DT boot, we just bail out on probe if device node is

[PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data

2013-08-20 Thread Roger Quadros
omap-control device is present from OMAP4 onwards which support device tree boots only. So get rid of platform data. Signed-off-by: Roger Quadros --- drivers/usb/phy/phy-omap-control.c | 18 +++--- include/linux/usb/omap_control_usb.h |4 2 files changed, 7 insertions(+)

[PATCH v5 0/8] phy: omap-usb: Support multiple instances and new types

2013-08-20 Thread Roger Quadros
Hi, This patchset does the following: * Get rid of omap_control_usb platform data as we support DT only. * Restructure and add support for new PHY types. We now support the follwing four types TYPE_OMAP - if it has otghs_control mailbox register (e.g. on OMAP4) TYPE_USB2 - if it has Power dow

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: > On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: > > Hi, > > > > On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: > > > > >

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Felipe Balbi
On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: > Hi, > > On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: > > Hi, > > > > On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: > > > > On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: > > > > > From:

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: > Hi, > > On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: > > > On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: > > > > From: "Ivan T. Ivanov" > > > > > > > > These drivers handles control and configurat

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Felipe Balbi
Hi, On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: > > On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > > > These drivers handles control and configuration of the HS > > > and SS USB PHY transceivers. They are part of the drive

Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 Device Driver into the Linux Kernel

2013-08-20 Thread Ben Hutchings
On Tue, 2013-08-20 at 18:50 +0800, liujunliang_ljl wrote: > Dear Gregkh & all : > > I am the software engineer Liu Junliang from ShenZhen CoreChips > high technology company, on the market of SR9700 chip is designed and owned > by us. > SR9700 is a type of USB to Ethernet

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-20 at 07:29 -0500, Felipe Balbi wrote: > Hi, > > On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > These drivers handles control and configuration of the HS > > and SS USB PHY transceivers. They are part of the driver > > whi

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread George Cherian
On 8/20/2013 3:59 PM, Chanwoo Choi wrote: Hi George, diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt new file mode 100644 index 000..37e4c22 --- /dev/null +++ b/Documentation/devicetree/bindings/extcon/ext

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-20 Thread Ming Lei
On Tue, Aug 20, 2013 at 12:01 AM, Mark Brown wrote: > On Mon, Aug 19, 2013 at 08:17:53PM +0800, Ming Lei wrote: >> On Sat, Aug 17, 2013 at 9:29 AM, Alan Stern >> wrote: > >> > Aong those lines, I would like to point out that the device concept >> > embodied in the kernel's data structures can be

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Felipe Balbi
Hi, On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > These drivers handles control and configuration of the HS > and SS USB PHY transceivers. They are part of the driver > which manage Synopsys DesignWare USB3 controller stack > inside Qualcomm SoC's.

Re: [PATCH v2] usb-gadget-audio-file-wake-up-sleep-thread

2013-08-20 Thread Felipe Balbi
On Wed, Aug 14, 2013 at 09:26:11AM +0800, Qiao Zhou wrote: > On 08/14/2013 03:23 AM, Felipe Balbi wrote: > >Hi, > > > >On Mon, Aug 12, 2013 at 09:43:24AM +0800, Qiao Zhou wrote: > >>On 08/02/2013 03:31 PM, Felipe Balbi wrote: > >>>Hi, > >>> > >>>On Fri, Aug 02, 2013 at 01:15:33PM +0800, Qiao Zhou w

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-20 Thread Felipe Balbi
Hi, On Mon, Aug 19, 2013 at 10:58:09AM +0530, Kishon Vijay Abraham I wrote: > >> So maybe let's stop solving an already solved problem and just state that > >> you need to explicitly assign device ID to use this framework? > > > > Felipe, > > Can we have it the way I had in my v10 patch series t

Re: Bug report: 045e:0721 Microsoft LifeCam NX-3000 not detected

2013-08-20 Thread Laurent Pinchart
Hi Jürgen, On Monday 12 August 2013 07:33:03 Jürgen Liebmann wrote: > [1] > 045e:0721 Microsoft LifeCam NX-3000 not detected > > [2] > Since upgrate from quantal to raring I have the a problem with the webcam > "Microsoft LifeCam NX-3000". The webcam doesn't work. > > The last good kernel is 3.8

[PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 Device Driver into the Linux Kernel

2013-08-20 Thread liujunliang_ljl
Dear Gregkh & all : I am the software engineer Liu Junliang from ShenZhen CoreChips high technology company, on the market of SR9700 chip is designed and owned by us. SR9700 is a type of USB to Ethernet Converter and is compatible with USB 1.1 protocol, We want to merge

Re: [PATCH 3/3] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-20 Thread Ming Lei
On Mon, Aug 19, 2013 at 10:33 PM, Greg Kroah-Hartman wrote: > > Why would those events not need to be handled? For IAA_WATCHDOG event, it needn't to handle when IAA interrupt comes. For START_UNLINK_INTR event, we don't need to unlink intr qh any more if intr urb submit request comes. > What do

[PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 Device Driver into the Linux Kernel

2013-08-20 Thread liujunliang_ljl
Dear all : I am the software engineer Liu Junliang from ShenZhen CoreChips high technology company, on the market of SR9700 chip is designed and owned by us. SR9700 is a type of USB to Ethernet Converter and is compatible with USB 1.1 protocol, We want to merge SR9700 d

Re: [RFC] USB: cdc-wdm: Extend and improve subdriver interface

2013-08-20 Thread Bjørn Mork
Bjørn Mork writes: > Oliver Neukum writes: >> On Tuesday 04 September 2012 17:32:17 Bjørn Mork wrote: >>> Oliver Neukum writes: >>> > On Tuesday 04 September 2012 15:45:36 Bjørn Mork wrote: >> >>> >> USB_CDC_NOTIFY_NETWORK_CONNECTION and USB_CDC_NOTIFY_SPEED_CHANGE. >>> >> cdc-wdm will just debu

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Chanwoo Choi
Hi George, >>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt >>> b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt >>> new file mode 100644 >>> index 000..37e4c22 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt >>> @@

[PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm SoC's. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/Kconfig | 11 ++

[PATCH v4 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-20 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov --- drivers/usb/dwc3/Kconfig|8 +++ drivers/usb/dw

[PATCH v4 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-20 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-ssusb.t

[PATCH v4 0/3] DWC3 USB support for Qualcomm platform

2013-08-20 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, Here is fourth version of MSM USB3 drivers patches. Changes since v3: * Remove "_clk" suffix from clock names * Clarify required child node for qcom,dwc3 * Fix comments in functions headers * Use dbg instead err in drivers probe functions. Changes since v2: * Several

Re: [PATCH] cdc-wdm: fix race between interrupt handler and tasklet

2013-08-20 Thread Bjørn Mork
oli...@neukum.org writes: > From: Oliver Neukum > > Both could want to submit the same URB. Some checks of the flag > intended to prevent that were missing. > > Signed-off-by: Oliver Neukum > CC: sta...@vger.kernel.org Yes, this is definitely required for 3.11 and stable. Note that it is not j

[PATCH] xHCI:Fixing xhci_readl definition and function call

2013-08-20 Thread Kumar Gaurav
Fixing other programs in xhci driver which calls this function Signed-off-by: Kumar Gaurav --- drivers/usb/host/xhci-dbg.c | 36 +++ drivers/usb/host/xhci-hub.c | 72 +++--- drivers/usb/host/xhci-mem.c | 20 - drivers/usb/host/xhci-ring.c | 1

  1   2   >