On Fri, Aug 09, 2013 at 05:14:48PM -0400, Alan Stern wrote:
> On Fri, 9 Aug 2013, Greg KH wrote:
>
> > On Thu, Aug 08, 2013 at 10:07:19PM +0200, Martin MOKREJŠ wrote:
> > > Hi,
> > > I get plenty of these in /sys/kernel/debug/kmemleak:
> > >
> > > unreferenced object 0x88019f675268 (size 32
> > Hi,
> >
> > On Tue, Aug 13, 2013 at 08:04:26PM +, Paul Zimmerman wrote:
> > > > From: Felipe Balbi
> > > > Sent: Tuesday, August 13, 2013 12:20 PM
> > > >
> > > > On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote:
> > > > > Hi Balbi,
> > > > >
> > > > > Please check the attached lo
This patch defines a new trace event, which is called xhci_dbg_cancel_urb
and belongs to the event class xhci_log_msg, and adds tracepoints that
trace the debug messages related to the removal of a cancelled URB from
the endpoint's transfer ring.
Signed-off-by: Xenia Ragiadakou
---
Difference fr
This patch defines a new trace event, which is called xhci_dbg_ring_expansion
and belongs to the event class xhci_log_msg, and adds tracepoints that trace
the debug messages associated with the expansion of endpoint ring when there
is not enough space allocated to hold all pending TRBs.
Signed-off
This patch defines a new trace event, which is called xhci_dbg_init
and belongs to the event class xhci_log_msg, and adds tracepoints that
trace the debug statements in the functions used to start and stop the
xhci-hcd driver.
Also, it removes an unnecessary cast of variable val to unsigned int
in
> Hi,
>
> On Tue, Aug 13, 2013 at 08:04:26PM +, Paul Zimmerman wrote:
> > > From: Felipe Balbi
> > > Sent: Tuesday, August 13, 2013 12:20 PM
> > >
> > > On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote:
> > > > Hi Balbi,
> > > >
> > > > Please check the attached logs. The kernel base
David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, August 14, 2013 7:41 AM
> To: oneu...@suse.de
> Cc: Hayeswang; net...@vger.kernel.org;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next 1/3] net/usb/r8152: support aggregation
>
[...]
> > I don'
The function dma_set_mask() tests internally whether the dma_mask pointer
for the device is initialized and fails if the dma_mask pointer is NULL.
On pci platforms, the device dma_mask pointer is initialized, when pci
devices are enumerated, to point to the pci_dev->dma_mask which is 0x.
Ho
On Mon, Aug 12, 2013 at 09:22:46AM +0800, Peter Chen wrote:
> This patchset adds tested otg id switch function and vbus connect
> and disconnect detection for chipidea driver. And fix kinds of
> bugs found at chipidea drivers after enabling id and vbus detection.
>
> This patch are fully tested a
On 08/14/2013 03:23 AM, Felipe Balbi wrote:
Hi,
On Mon, Aug 12, 2013 at 09:43:24AM +0800, Qiao Zhou wrote:
On 08/02/2013 03:31 PM, Felipe Balbi wrote:
Hi,
On Fri, Aug 02, 2013 at 01:15:33PM +0800, Qiao Zhou wrote:
On 08/01/2013 06:21 PM, Qiao Zhou wrote:
v2->v1:
stop pcm stream instead of w
On Tue, Aug 13, 2013 at 10:23 PM, Fabio Estevam wrote:
> On Tue, Aug 13, 2013 at 11:05 AM, Peter Chen wrote:
>
>> But what I see is the &dwc3_pci_dev_pm_ops is not NULL if CONFIG_PM_SLEEP
>> is not defined.
>
> The point of this macro is that we do not need to provide the .suspend
> and .resume N
From: Oliver Neukum
Date: Tue, 13 Aug 2013 17:17:10 +0200
> On Tue, 2013-08-13 at 20:32 +0800, hayeswang wrote:
>> Oliver Neukum [mailto:oneu...@suse.de]
>> > Sent: Tuesday, August 13, 2013 4:49 PM
>> > To: Hayeswang
>> > Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
>> > linux-usb
I've tried several ways to apply this patch, and I can't get it to apply
with `git am`. Can you rebase this series against my for-usb-next-queue
branch and resend it?
Thanks,
Sarah Sharp
On Tue, Aug 13, 2013 at 12:38:44AM +0300, Xenia Ragiadakou wrote:
> This patch defines a new trace event, whi
Hi Xenia,
When I apply this patch to Greg's usb-next tree and try to compile, I
get the following error:
sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply
Applying: xhci: fix dma mask setup in xhci.c
total: 0 errors, 0 warnings, 53 lines checked
Your patch has no obvious
On Tue, Aug 13, 2013 at 10:32:57AM -0500, Felipe Balbi wrote:
> On Mon, Aug 12, 2013 at 02:52:33PM -0400, Alan Stern wrote:
> > On Mon, 12 Aug 2013, Felipe Balbi wrote:
> > > anything that USB[23]0CV supports today. There are even link layer tests
> > > for USB3 and a bunch of others. This SINGLE_S
On Wednesday 14 of August 2013 00:19:28 Sylwester Nawrocki wrote:
> W dniu 2013-08-13 14:05, Kishon Vijay Abraham I pisze:
> > On Tuesday 13 August 2013 05:07 PM, Tomasz Figa wrote:
> >> On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote:
> >>> On Wednesday 31 July 2013 11:45 AM, Fe
These make me very happy. Thanks for doing that.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 13, 2013 at 06:29:26PM +0100, Rupesh Gujare wrote:
> From: Dan Carpenter
>
> This patch separates success & failure block along with fixing
> following issues:-
>
> 1. The way oz_hcd_pd_arrived() looks now it's easy to think we free "ep" but
> actually we do this spaghetti thing of s
Hi Florian,
You need to resend the whole patch as a separate email, with the subject
line being the one you want to appear as the patch's short description.
I can't apply the patch with all these reply lines in the body of the
email.
Also, can you please change the subject line of the patch to:
On Mon, Aug 12, 2013 at 12:17:43PM +0530, Rajaram R wrote:
> On Thu, Aug 8, 2013 at 7:55 PM, Sarah Sharp
> wrote:
> > I've heard there's little to do at the software level, but I haven't
> > been following the spec closely.
>
> As I see it at least there has to be some framework that needs to
> s
On Mon, Aug 12, 2013 at 01:44:16PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Aug 06, 2013 at 01:16:50PM -0700, Sarah Sharp wrote:
> > On Tue, Aug 06, 2013 at 02:48:57PM -0400, Alan Stern wrote:
> > > On Tue, 6 Aug 2013, Sarah Sharp wrote:
> > >
> > > > On Tue, Aug 06, 2013 at 10:16:15AM -0400, Al
On Tue, Aug 13, 2013 at 03:01:23PM -0500, Felipe Balbi wrote:
> Hi,
>
> On Tue, Aug 13, 2013 at 02:48:42PM -0500, Felipe Balbi wrote:
> > On Tue, Aug 13, 2013 at 02:41:25PM -0500, Felipe Balbi wrote:
> > > Hi Greg,
> > >
> > > Here's my pull request for v3.12 merge window. I know there are a bunc
W dniu 2013-08-13 14:05, Kishon Vijay Abraham I pisze:
On Tuesday 13 August 2013 05:07 PM, Tomasz Figa wrote:
On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote:
On Wednesday 31 July 2013 11:45 AM, Felipe Balbi wrote:
On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abrah
Alan Stern wrote:
> On Mon, 12 Aug 2013, Takashi Iwai wrote:
>> So... Clemens, Daniel, Eldad, could you guys review the latest version
>> of Alan's patch? I'd love to sort this out for 3.12.
>
> Here's a revised version of the patch (still untested).
> - maxsize = ((ep->freqmax + 0x) * (f
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Tuesday, August 13, 2013 2:12 PM
>
> if pdata is a NULL pointer we could cause a
> kernel oops when probing the driver. Make sure
> to cope with systems which won't pass pdata
> to the driver.
>
> Reported-by: Paul Zimmerman
> Signed-off-by: Fel
Hello.
On 08/14/2013 01:33 AM, Felipe Balbi wrote:
I have basically two questions on this change:
[...]
2) why you omitted am35x.c from this commit?
mistake
Are you going to fix it, or should I?
I'm just not sure how many resources there are with all these
hwmod compl
Hi Alan,
On 13.08.2013 23:06, Alan Stern wrote:
> On Mon, 12 Aug 2013, Alan Stern wrote:
>> On Mon, 12 Aug 2013, Takashi Iwai wrote:
>>
>>> So... Clemens, Daniel, Eldad, could you guys review the latest version
>>> of Alan's patch? I'd love to sort this out for 3.12.
>>
>> Here's a revised versio
Hi,
On Wed, Aug 14, 2013 at 01:20:09AM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 08/12/2013 10:28 PM, Felipe Balbi wrote:
>
> >I have basically two questions on this change:
>
> >>[...]
>
> >2) why you omitted am35x.c from this commit?
>
> mistake
>
> >>>Are you going
Hi,
On Tue, Aug 13, 2013 at 09:12:28PM +, Paul Zimmerman wrote:
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Tuesday, August 13, 2013 2:05 PM
> >
> > On Tue, Aug 13, 2013 at 08:51:27PM +, Paul Zimmerman wrote:
> > >
> > > Hi Felipe,
> > >
> > > I think f7e846f0956 "make maximum-
On Tue, Aug 13, 2013 at 04:17:26PM -0500, Bin Liu wrote:
> On Tue, Aug 13, 2013 at 4:13 PM, Felipe Balbi wrote:
> > On Tue, Aug 13, 2013 at 03:41:01PM -0500, Bin Liu wrote:
> >> On Tue, Aug 13, 2013 at 2:21 PM, Felipe Balbi wrote:
> >> > On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote:
>
Hello.
On 08/12/2013 10:28 PM, Felipe Balbi wrote:
I have basically two questions on this change:
[...]
2) why you omitted am35x.c from this commit?
mistake
Are you going to fix it, or should I?
I'm just not sure how many resources there are with all these
hwmod compl
On Tue, Aug 13, 2013 at 4:13 PM, Felipe Balbi wrote:
> On Tue, Aug 13, 2013 at 03:41:01PM -0500, Bin Liu wrote:
>> On Tue, Aug 13, 2013 at 2:21 PM, Felipe Balbi wrote:
>> > On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote:
>> >> Sebastian,
>> >>
>> >> On Tue, Aug 13, 2013 at 12:38 PM, Seba
From: Mark Brown
Date: Fri, 9 Aug 2013 18:31:21 +0100
> From: Mark Brown
>
> Make functions that are only referenced from ops structures static, they
> do not need to be in the global namespace and sparse complains about this.
>
> Signed-off-by: Mark Brown
Applied.
--
To unsubscribe from th
On Tue, Aug 13, 2013 at 03:41:01PM -0500, Bin Liu wrote:
> On Tue, Aug 13, 2013 at 2:21 PM, Felipe Balbi wrote:
> > On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote:
> >> Sebastian,
> >>
> >> On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior
> >> wrote:
> >> > Since the musb-gadg
From: Mark Brown
Date: Fri, 9 Aug 2013 18:31:22 +0100
> From: Mark Brown
>
> Ensure that the definition of ax88172a_info matches the declaration seen
> by users and silence sparse warnings about symbols without declarations
> in the global namespace by moving the declaration into the shared he
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Tuesday, August 13, 2013 2:05 PM
>
> On Tue, Aug 13, 2013 at 08:51:27PM +, Paul Zimmerman wrote:
> >
> > Hi Felipe,
> >
> > I think f7e846f0956 "make maximum-speed a per-instance attribute"
> > causes an oops when using the dwc3-pci glue layer
if pdata is a NULL pointer we could cause a
kernel oops when probing the driver. Make sure
to cope with systems which won't pass pdata
to the driver.
Reported-by: Paul Zimmerman
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/core.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
di
On Mon, 12 Aug 2013, Alan Stern wrote:
> On Mon, 12 Aug 2013, Takashi Iwai wrote:
>
> > So... Clemens, Daniel, Eldad, could you guys review the latest version
> > of Alan's patch? I'd love to sort this out for 3.12.
>
> Here's a revised version of the patch (still untested). The difference
> i
Hi,
On Tue, Aug 13, 2013 at 08:51:27PM +, Paul Zimmerman wrote:
> > From: Felipe Balbi
> > Sent: Tuesday, August 13, 2013 1:01 PM
> >
> > On Tue, Aug 13, 2013 at 02:48:42PM -0500, Felipe Balbi wrote:
> > > On Tue, Aug 13, 2013 at 02:41:25PM -0500, Felipe Balbi wrote:
> > > > Hi Greg,
> > > >
On Tue, 13 Aug 2013, James Stone wrote:
> >> http://www.spinics.net/lists/linux-usb/msg90457.html
> >
> > This patch is definitely not the way to go. A week ago I posted a
> > completely different approach here:
> >
> > http://marc.info/?l=linux-usb&m=137537866909950&w=2
> >
> > So far th
> From: Felipe Balbi
> Sent: Tuesday, August 13, 2013 1:01 PM
>
> On Tue, Aug 13, 2013 at 02:48:42PM -0500, Felipe Balbi wrote:
> > On Tue, Aug 13, 2013 at 02:41:25PM -0500, Felipe Balbi wrote:
> > > Hi Greg,
> > >
> > > Here's my pull request for v3.12 merge window. I know there are a bunch
> > >
On Tue, 13 Aug 2013, Jack Pham wrote:
> commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE
> test of EHSET") added additional code to the EHCI hub driver but it is
> anticipated to only have a limited audience (e.g. embedded silicon
> vendors and integrators). Avoid subjecting
On Tue, 13 Aug 2013, Sarah Sharp wrote:
> Hi Alan,
>
> Do you know if there's a chance that any USB drivers (or userspace)
> would try to clear an endpoint halt when there are active URBs that have
> not completed on for the endpoint?
They might, but they shouldn't. It would be a bug.
> I ask
On Tue, Aug 13, 2013 at 2:21 PM, Felipe Balbi wrote:
> On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote:
>> Sebastian,
>>
>> On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior
>> wrote:
>> > Since the musb-gadget code now calls the dma engine properly it is
>> > possible to enable
commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE
test of EHSET") added additional code to the EHCI hub driver but it is
anticipated to only have a limited audience (e.g. embedded silicon
vendors and integrators). Avoid subjecting all EHCI (and in the future
maybe xHCI/OHCI, et
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Tuesday, August 13, 2013 1:30 PM
>
> On Tue, Aug 13, 2013 at 08:04:26PM +, Paul Zimmerman wrote:
> > > From: Felipe Balbi
> > > Sent: Tuesday, August 13, 2013 12:20 PM
> > >
> > > On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote:
> >
commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE
test of EHSET") added additional code to the EHCI hub driver but it is
anticipated to only have a limited audience (e.g. embedded silicon
vendors and integrators). Avoid subjecting all EHCI (and in the future
maybe xHCI/OHCI, et
On Tue, Aug 13, 2013 at 10:03:01PM +0200, Frank Schäfer wrote:
> The chip type distinction is getting more and more relevant and
> complicating, so always print the chip type.
> Printing a name string is also much better than just printing an
> internal index number.
>
> Signed-off-by: Frank Schäf
Hi,
On Tue, Aug 13, 2013 at 08:04:26PM +, Paul Zimmerman wrote:
> > From: Felipe Balbi
> > Sent: Tuesday, August 13, 2013 12:20 PM
> >
> > On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote:
> > > Hi Balbi,
> > >
> > > Please check the attached logs. The kernel base one kernel3.10.
>
> From: Felipe Balbi
> Sent: Tuesday, August 13, 2013 12:20 PM
>
> On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote:
> > Hi Balbi,
> >
> > Please check the attached logs. The kernel base one kernel3.10.
>
> you didn't take the regdump after xHCI :-( I need to check if erst_base
> is bei
There is no need for two else-if constructs for the type_1 chip
detection in pl2303_startup(), so merge them.
Signed-off-by: Frank Schäfer
---
drivers/usb/serial/pl2303.c |5 ++---
1 Datei geändert, 2 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-)
diff --git a/drivers/usb/serial/pl2303.c b/dri
On Tue, Aug 13, 2013 at 02:51:00PM -0500, Felipe Balbi wrote:
> that driver uses IS_ERR() macro which is
> defined by .
>
> Signed-off-by: Felipe Balbi
let's ignore this one since Sebastian had already sent the same patch
before me.
--
balbi
signature.asc
Description: Digital signature
The chip type distinction is one of the weak spots of the pl2303 driver.
It currently knows 3 different PL2303 chip types only (the two legacy
chip types type_0 and type_1 (PL2303H ?) and the HX type).
During the last 2-3 years Prolific has introduced additional PL2303
chips, such as the HXD (HX
The driver currently knows about 3 different PL2303 chip types:
The two legacy chip types type_0 and type_1 (PL2303H ?) and the HX
type.
The device distinction is currently completely based on the examination
of the USB descriptors.
During the last years, Prolific has introduced further PL2303 chip
Hi,
On Tue, Aug 13, 2013 at 02:48:42PM -0500, Felipe Balbi wrote:
> On Tue, Aug 13, 2013 at 02:41:25PM -0500, Felipe Balbi wrote:
> > Hi Greg,
> >
> > Here's my pull request for v3.12 merge window. I know there are a bunch
> > of patches pending in the mailing list but I won't have time to fully
The chip type distinction is getting more and more relevant and
complicating, so always print the chip type.
Printing a name string is also much better than just printing an
internal index number.
Signed-off-by: Frank Schäfer
---
drivers/usb/serial/pl2303.c | 15 ++-
1 Datei geände
On 08/09/2013 03:53 AM, Ivan T. Ivanov wrote:
> From: "Ivan T. Ivanov"
>
> MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS)
> and HS, SS PHY's controll and configuration registers.
s/controll/control/
> It could operate in device mode (SS, HS, FS) and host
> mode (SS, HS, FS, LS).
> diff --
that driver uses IS_ERR() macro which is
defined by .
Signed-off-by: Felipe Balbi
---
drivers/usb/phy/phy-am335x-control.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/phy/phy-am335x-control.c
b/drivers/usb/phy/phy-am335x-control.c
index 35494f1..7fa8e0d 100644
--- a/drivers/
On Tue, Aug 13, 2013 at 02:41:25PM -0500, Felipe Balbi wrote:
> Hi Greg,
>
> Here's my pull request for v3.12 merge window. I know there are a bunch
> of patches pending in the mailing list but I won't have time to fully
> review them before merging so I decided that it's best to delay a merge
> w
Hi Greg,
Here's my pull request for v3.12 merge window. I know there are a bunch
of patches pending in the mailing list but I won't have time to fully
review them before merging so I decided that it's best to delay a merge
window than it is to cause a bunch of regressions.
Oh yeah, the patches un
Hi,
On Mon, Aug 12, 2013 at 09:43:24AM +0800, Qiao Zhou wrote:
> On 08/02/2013 03:31 PM, Felipe Balbi wrote:
> >Hi,
> >
> >On Fri, Aug 02, 2013 at 01:15:33PM +0800, Qiao Zhou wrote:
> >>On 08/01/2013 06:21 PM, Qiao Zhou wrote:
> >>>v2->v1:
> >>>stop pcm stream instead of wake up the sleep thread,
On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote:
> Sebastian,
>
> On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior
> wrote:
> > Since the musb-gadget code now calls the dma engine properly it is
> > possible to enable it for the TX path in device mode.
> > AM335x Advisory 1.0.1
Hi,
On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote:
> Hi Balbi,
>
> Please check the attached logs. The kernel base one kernel3.10.
you didn't take the regdump after xHCI :-( I need to check if erst_base
is being mirrored to DEPCMDPAR*
--
balbi
signature.asc
Description: Digital
Hi Alan,
Do you know if there's a chance that any USB drivers (or userspace)
would try to clear an endpoint halt when there are active URBs that have
not completed on for the endpoint?
I ask because in order to handle the case where userspace wants to reset
the toggles with a clear halt control t
On Tue, 13 Aug 2013, Greg Kroah-Hartman wrote:
> On Tue, Aug 13, 2013 at 10:07:58AM -0400, Alan Stern wrote:
> > On Mon, 12 Aug 2013, Jack Pham wrote:
> >
> > > commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE
> > > test of EHSET") added additional code to the EHCI hub drive
On 08/01/2013 09:00 AM, Tuomas Tynkkynen wrote:
> Hi all,
>
> Here's the device tree changes required for USB Host support on Tegra30 and
> Tegra114. This enables USB Host on the Cardhu's dock connector port and on the
> single built-in A-ports on Dalmore and Beaver.
I've applied this series to T
On Mon, Aug 12, 2013 at 01:56:40PM +0200, Andreas Lillebø Holm wrote:
> When communicating with AT90USB1287, at random intervals (1/25 boots)
> the linux hid_output_field Oopses and kills the communicating thread.
> The AT90USB1287 microcontroller uses LUFA library for usb/hid
> communication. It
On Tue, Aug 13, 2013 at 11:18:24AM +0200, Marcin Zajączkowski wrote:
> Hi,
>
> I had no problem with a USB 3.0 port in my Asus N43SN since I bought a
> laptop (~2 years). Recently I replaced a motherboard to the new one
> (N43SL.413 looks the same as the first one) due to a problem with a
> graphi
On Tuesday 13 August 2013 19:27:52 Sergei Shtylyov wrote:
> Hello.
>
> On 08/13/2013 08:52 PM, Florian Wolter wrote:
> >>> Patch to Fix Problem with not cleared halted endpoint.
> >>>
> >>> See Bugtracker Bug 60699
> >>
> >> Hi Florian,
> >>
> >> You need to send your patch inline, not as an at
On Tue, Aug 13, 2013 at 10:07:58AM -0400, Alan Stern wrote:
> On Mon, 12 Aug 2013, Jack Pham wrote:
>
> > commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE
> > test of EHSET") added additional code to the EHCI hub driver but it is
> > anticipated to only have a limited audienc
Sebastian,
On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior
wrote:
> Since the musb-gadget code now calls the dma engine properly it is
> possible to enable it for the TX path in device mode.
> AM335x Advisory 1.0.13 says that we may lose the toggle bit on multiple
> RX transfers. Ther
This patch defines four types of current supported DMA engines and
assignes them to each dma engine. This should get rid of a few ifdefs
later on.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/cppi_dma.c | 1 +
drivers/usb/musb/musb_cppi41.c | 1 +
drivers/usb/musb/musb_dm
Hi,
the musb dma engine abstraction is basically hidden behind ifdefs and set
at compile time. This little incomplete series tries to push this check
to runtime time so we could enable more than one at compile time.
Any comments?
Sebastian
--
To unsubscribe from this list: send the line "unsubs
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/musb_gadget.c | 76 --
1 file changed, 36 insertions(+), 40 deletions(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index c685905..05a59d0 100644
--- a/drivers/
Now pass the dma_controller to the macro that checks if a given dma
engine is available.
For consistency the all the macros start if is_dma_. The mentor and TUSB
is added and will be used later.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/davinci.c | 2 +-
drivers/usb/musb
If we check the use_dma before calling ->channel_program() then in case
of use_dma is 0 we don't have to remove the MUSB_TXCSR_DMAENAB bit
because we never set it.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/musb_gadget.c | 8
1 file changed, 4 insertions(+), 4 deletio
On 08/13/2013 09:40 PM, Rupesh Gujare wrote:
oz_hcd_pd_departed() takes struct oz_port pointer instead of
void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
drivers/staging/ozwpan
On Sat, Aug 10, 2013 at 04:04:02AM +, Paul Zimmerman wrote:
> > From: linux-usb-ow...@vger.kernel.org
> > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alexandra Yates
> > Sent: Friday, August 09, 2013 12:21 PM
>
> Hi Alexandra,
>
>
>
> >
> > +/* USB 2.0 BOS descriptor and a capab
On 13/08/13 18:35, Sergei Shtylyov wrote:
Hello.
On 08/13/2013 09:29 PM, Rupesh Gujare wrote:
oz_hcd_pd_departed() takes struct oz_port pointer instead of
void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/
Since the musb-gadget code now calls the dma engine properly it is
possible to enable it for the TX path in device mode.
AM335x Advisory 1.0.13 says that we may lose the toggle bit on multiple
RX transfers. There is a workaround in host mode but none in device mode
and therefore RX transfers are di
This patch makes use of the two function is_cppi_enabled() and
tusb_dma_omap() instead of the ifdef for the proper DMA implementation
setup code. It basically shifts the code right by one indention level
and adds a few line breaks once the chars are crossed.
Signed-off-by: Sebastian Andrzej Siewio
Hi,
tested a little with g_ncm on amm35x-evm.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
rh_call_control() contains a buffer, tbuf, which it uses to hold
USB descriptors. These discriptors are eventually copied into the
transfer_buffer in the URB. The buffer in the URB is dynamically
defined and is always large enough to hold the amount of data it
requests.
tbuf is currently staticall
On Tue, 2013-08-13 at 18:29 +0100, Rupesh Gujare wrote:
> Swap arguments of oz_ep_alloc() to match kmalloc() for better readability.
[]
> diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
[]
> -static struct oz_endpoint *oz_ep_alloc(gfp_t mem_flags, int buffer_size)
> +st
Since dma_map_single() may fail it is good to actually check the return
code to see if it succeeded.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/musb_gadget.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/
Hello.
On 08/13/2013 09:29 PM, Rupesh Gujare wrote:
oz_hcd_pd_departed() takes struct oz_port pointer instead of
void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
drivers/stagin
oz_hcd_pd_arrived returns struct oz_port *, change function
declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
drivers/staging/ozwpan/ozhcd.h |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --
oz_hcd_pd_departed() takes struct oz_port pointer instead of
void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
drivers/staging/ozwpan/ozhcd.h |2 +-
2 files changed, 3 insertions(+)
Remove variable initialization wherever it is not required.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozeltbuf.c |2 +-
drivers/staging/ozwpan/ozhcd.c| 18 +-
drivers/staging/ozwpan/ozpd.c |4 ++--
3 files changed, 12 insertions(+), 12 deletions(-)
Swap arguments of oz_ep_alloc() to match kmalloc() for better readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 0fd3fea..0
From: Dan Carpenter
This patch separates success & failure block along with fixing
following issues:-
1. The way oz_hcd_pd_arrived() looks now it's easy to think we free "ep" but
actually we do this spaghetti thing of setting it to NULL on success.
2. It is hard to read it because there are unl
We are already checking "ep" earlier in function. Do not
need to check again.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan
Hello.
On 08/13/2013 08:52 PM, Florian Wolter wrote:
Patch to Fix Problem with not cleared halted endpoint.
See Bugtracker Bug 60699
Hi Florian,
You need to send your patch inline, not as an attachment.
Thanks,
Sarah Sharp
Hi Sarah,
Sorry now the Patch is in-lined.
Subject: [
This patch adds blank line between declaration &
code for readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c|6 ++
drivers/staging/ozwpan/ozeltbuf.c |7 +++
drivers/staging/ozwpan/ozhcd.c | 28
drivers
This patch adds a blank line between global declarations &
functions for readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c| 17
drivers/staging/ozwpan/ozeltbuf.c | 12 ++
drivers/staging/ozwpan/ozhcd.c | 68 +
Making code simpler for readability.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 5a417c8..4b658d4
Put spaces around math operations.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 4b658d4..2be15f4 100644
This patch seriese mostly contains coding style fixes & removes unneeded
variable initialization.
Dan Carpenter (1):
staging: ozwpan: Separate success & failure case for
oz_hcd_pd_arrived()
Rupesh Gujare (9):
staging: ozwpan: Add a blank line between declaraction and code.
staging: ozwp
On Tuesday 13 August 2013 12:01 PM, Alexandre Demers wrote:
lsusb gives me the following:
sudo lsusb --verbose -t
/: Bus 13.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 5000M
/: Bus 12.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 480M
/: Bus 11.Port 1: Dev 1, Class=root_hub, Driver=x
Good eye, I completely missed the first goto. I'll update the patch and resend
it. Thanks Greg!
-Sean
> -Original Message-
> From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org]
> Sent: Monday, August 12, 2013 5:28 PM
> To: Stalley, Sean
> Cc: linux-usb@vger.kernel.org; Sarah Sha
1 - 100 of 158 matches
Mail list logo