[RFC v3 3/4] xhci: add xhci_address_ctx trace event

2013-08-05 Thread Xenia Ragiadakou
This patch defines a new event class, called xhci_log_ctx, that records in the ring buffer the context data, the context type (input or output), the context dma and virtual addresses, the context endpoint entries, the slot ID and whether the xHC uses 64 byte context data structures. This informati

[RFC v3 1/4] xhci: add trace for debug messages related to quirks

2013-08-05 Thread Xenia Ragiadakou
This patch defines a new trace event, which is called xhci_dbg_quirks and belongs in the event class xhci_log_msg, and adds tracepoints that trace the debug messages associated with xHCs' quirks. Signed-off-by: Xenia Ragiadakou --- Differences from version 2: Add tracepoints for the debug state

[RFC v3 4/4] xhci: add xhci_cmd_completion trace event

2013-08-05 Thread Xenia Ragiadakou
This patch creates a new event class, called xhci_log_event, and defines the xhci_cmd_completion trace event used for tracing the commands issued to xHC that generate a completion event in the event ring. This info can be used, later, to print, in a human readable way, the completion status and fl

[RFC v3 2/4] xhci: add trace for debug messages related to endpoint reset

2013-08-05 Thread Xenia Ragiadakou
This patch defines a new trace event, which is called xhci_dbg_reset_ep and belongs in the event class xhci_log_msg, and adds tracepoints that trace the debug messages associated with resetting an endpoint after the reception of a STALL packet. Signed-off-by: Xenia Ragiadakou --- drivers/usb/hos

Re: Regression: USB device doesn't get ready to mount

2013-08-05 Thread Guilherme Salazar
Great, the patch solves the problem. Thanks and sorry for reporting a duplicate. On Mon, Aug 5, 2013 at 11:08 PM, Fabio Estevam wrote: > On Mon, Aug 5, 2013 at 10:55 PM, Guilherme Salazar > wrote: >> Flash drive doesn't get ready to mount instantly after it's plugged >> into a USB port; only af

[RFC 0/2] USB port power off bug fixes

2013-08-05 Thread Sarah Sharp
Please review these two bug fixes for the USB port power off mechanism. I especially need review for the second patch, since it involves issues with the runtime status of the USB port. These two patches were tested on a Haswell ULT Sawtooth Peak system. With these two patches, USB 2.0 port power o

[RFC 2/2] usb: Don't fail port power resume on device disconnect.

2013-08-05 Thread Sarah Sharp
Userspace can tell the kernel to power off any USB port, including ones that are visible and connectible to users. When an attached USB device goes into suspend, the port will be powered off if the pm_qos_no_port_poweroff file for its port is set to 0, the device does not have remote wakeup enable

[RFC 1/2] usb: don't check pm qos NO_POWER_OFF flag in usb_port_suspend()

2013-08-05 Thread Sarah Sharp
From: Lan Tianyu The pm qos NO_POWER_OFF flag is checked twice during usb device suspend to see if the usb port power off condition is met. This is redundant and also will prevent the port from being powered off if the NO_POWER_OFF flag is changed to 1 from 0 after the device was already suspende

Re: Regression: USB device doesn't get ready to mount

2013-08-05 Thread Fabio Estevam
On Mon, Aug 5, 2013 at 10:55 PM, Guilherme Salazar wrote: > Flash drive doesn't get ready to mount instantly after it's plugged > into a USB port; only after a few minutes it's possible to mount. Does this patch help? http://marc.info/?l=linux-usb&m=137523956310060&w=2 -- To unsubscribe from this

Regression: USB device doesn't get ready to mount

2013-08-05 Thread Guilherme Salazar
Flash drive doesn't get ready to mount instantly after it's plugged into a USB port; only after a few minutes it's possible to mount. I've checked it out on 3.9.11, 3.10.5, and 3.11-rc4. It works normally on 3.9.11. dmesg output file for each kernel tested: $ cat dmesg-3.9.11 [ 74.391651] usb

[PATCH 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-08-05 Thread Peter Chen
In order to increase test coverage, we can change the interval between two remote wakeups every time, and the interval can be any user defined value. This change will no affect current behavior if the user does not use two introduced module paramters. Signed-off-by: Peter Chen --- drivers/usb/ga

Re: Regression: USB memory stick stalls and no longer automounts under 3.11-rc1

2013-08-05 Thread Alan Stern
On Tue, 6 Aug 2013, Greg KH wrote: > > Have you tried this patch? > > > > http://marc.info/?l=linux-usb&m=137523956310060&w=2 > > What is the status of this patch, I'm starting to get lots of complaints > about this :( James Bottomley has merged it into his Fixes branch, but I don't think

[PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-05 Thread Ming Lei
This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA SG is possible), so TSO can be enabled and skb fragment buffers can be passed to usb stack via urb->sg directly. With the patch, system CPU utilizati

[PATCH v3 2/4] USB: XHCI: mark no_sg_constraint

2013-08-05 Thread Ming Lei
This patch marks all xHCI controllers as no_sg_constraint since xHCI supports building packet from discontinuous buffers. Cc: Alan Stern Acked-by: Sarah Sharp Signed-off-by: Ming Lei --- drivers/usb/host/xhci.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/host/xhci.c

[PATCH v3 3/4] USBNET: support DMA SG

2013-08-05 Thread Ming Lei
This patch introduces support of DMA SG if the USB host controller which usbnet device is attached to is capable of building packet from discontinuous buffers. The patch supports passing the skb fragment buffers to usb stack directly via urb->sg. Cc: Eric Dumazet Cc: Ben Hutchings Cc: Grant Gru

[PATCH v3 1/4] USB: introduce usb_device_no_sg_constraint() helper

2013-08-05 Thread Ming Lei
Some host controllers(such as xHCI) can support building packet from discontinuous buffers, so introduce one flag and helper for this kind of host controllers, then the feature can help some applications(such as usbnet) by supporting arbitrary length of sg buffers. Acked-by: Alan Stern Signed-off

[PATCH v3 0/4] USB & USBNET: loose SG check and support usbnet DMA SG

2013-08-05 Thread Ming Lei
Hi, This patchset allows drivers to pass sg buffers which size can't be divided by max packet size of endpoint if the host controllers(such ax xHCI) support this kind of sg buffers. Previously we added check[1] on the situation and don't allow these sg buffers passed to USB HCD, looks the check i

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-05 Thread Tomasz Figa
On Monday 05 of August 2013 12:02:16 Mike Turquette wrote: > Quoting Kukjin Kim (2013-08-05 11:13:55) > > > On 08/06/13 03:06, Mike Turquette wrote: > > > Quoting Kukjin Kim (2013-08-05 10:01:36) > > > > > >> On 07/23/13 08:49, Tomasz Figa wrote: > > >>> This series is an attempt to move clock su

Re: Regression: USB memory stick stalls and no longer automounts under 3.11-rc1

2013-08-05 Thread Greg KH
On Mon, Aug 05, 2013 at 12:18:55PM -0400, Alan Stern wrote: > On Mon, 5 Aug 2013, [ISO-8859-1] Alex Villac??s Lasso wrote: > > > https://bugzilla.kernel.org/show_bug.cgi?id=60685 > > > > Posting in the mailing list as requested by Greg Kroah-Hartman > > > > > Problem des

Re: [PATCH] usb: fix some scripts/kernel-doc warnings

2013-08-05 Thread Greg Kroah-Hartman
On Mon, Aug 05, 2013 at 08:36:39PM +0200, Yacine Belkadi wrote: > On 08/04/2013 11:29 PM, Greg Kroah-Hartman wrote: > > On Sun, Aug 04, 2013 at 10:05:36PM +0200, Yacine Belkadi wrote: > >> On 08/03/2013 05:29 AM, Greg Kroah-Hartman wrote: > >>> On Fri, Aug 02, 2013 at 08:10:04PM +0200, Yacine Belka

[PATCH] dwc3: Only build debugfs when DWC3_GADGET/DUAL_ROLE is enabled

2013-08-05 Thread Andi Kleen
From: Andi Kleen Fix (randconfig) build problem with DEBUG_FS on Cc: ba...@ti.com Cc: linux-usb@vger.kernel.org Signed-off-by: Andi Kleen --- drivers/usb/dwc3/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile

Re: [PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-08-05 Thread Greg Kroah-Hartman
On Mon, Aug 05, 2013 at 09:46:46AM -0700, Sarah Sharp wrote: > On Mon, Aug 05, 2013 at 01:29:12PM +0800, Greg Kroah-Hartman wrote: > > On Wed, Jul 31, 2013 at 11:30:28AM -0700, Sarah Sharp wrote: > > > From: Julius Werner > > > > > > The USB hub driver's event handler contains a check to catch Su

[RFC v5] xhci: add traces for debug messages in xhci_address_device()

2013-08-05 Thread Xenia Ragiadakou
This patch declares an event class for trace events that trace messages with variadic arguments, called xhci_log_msg, and defines a trace event for tracing the debug messages in xhci_address_device() function, called xhci_dbg_address. In order to implement this type of trace events, a wrapper func

[RFC] xhci: Don't enable/disable RWE on bus suspend/resume.

2013-08-05 Thread Sarah Sharp
The RWE bit of the USB 2.0 PORTPMSC register is supposed to enable remote wakeup for devices in the lower power link state L1. It has nothing to do with the device suspend remote wakeup from L2. The RWE bit is designed to be set once (when USB 2.0 LPM is enabled for the port) and cleared only whe

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-05 Thread Dan Carpenter
Here is what oz_hcd_pd_arrived() looks like after my changes: These lines: - if (ozhcd == NULL) + if (!ozhcd) were personal preference and not official kernel style guidelines. Either way is fine for pointers. oz_ep_alloc() can return NULL. There was no check for failure in the origi

Re: [RFC] usb: rh_call_control tbuf overflow fix

2013-08-05 Thread Alan Stern
On Mon, 5 Aug 2013, Sarah Sharp wrote: > > > You are completely right, no current HCD writes more than a 15 byte BOS > > > descriptor. > > > However, if a future HCD were to attempt to write a descriptor longer > > > than 15 bytes, > > > the value of wLength would be larger than the space availa

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-05 Thread Dan Carpenter
On Mon, Aug 05, 2013 at 07:43:16PM +0100, Rupesh Gujare wrote: > On 05/08/13 18:53, Dan Carpenter wrote: > >On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: > >>This patch fixes crash issue when there is quick cycle of > >>de-enumeration & enumeration due to loss of wireless link. > >

Re: [RFC] usb: rh_call_control tbuf overflow fix

2013-08-05 Thread Sarah Sharp
On Sat, Aug 03, 2013 at 11:49:04AM -0400, Alan Stern wrote: > On Fri, 2 Aug 2013, Stalley, Sean wrote: > > > > > tbuf, however, is statically allocated on the stack with a size of 15 > > > > bytes, regardless of the size specified in the URB. > > > > When this buffer is passed to the hcd via the h

[RFC v5] xhci: fix dma mask setup in xhci.c

2013-08-05 Thread Xenia Ragiadakou
The function dma_set_mask() tests internally whether the dma_mask pointer for the device is initialized and fails if the dma_mask pointer is NULL. On pci platforms, the device dma_mask pointer is initialized, when pci devices are enumerated, to point to the pci_dev->dma_mask which is 0x. Ho

Re: [PATCH 4/4] staging: ozwpan: Return correct hub status.

2013-08-05 Thread Dan Carpenter
On Mon, Aug 05, 2013 at 08:00:59PM +0100, Rupesh Gujare wrote: > Ok. I will rework on style nits. Do it in a follow on patch. It's fine. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majo

Re: Regression: USB memory stick stalls and no longer automounts under 3.11-rc1

2013-08-05 Thread Alex Villací­s Lasso
El 05/08/13 11:18, Alan Stern escribió: On Mon, 5 Aug 2013, [ISO-8859-1] Alex Villac�s Lasso wrote: https://bugzilla.kernel.org/show_bug.cgi?id=60685 Posting in the mailing list as requested by Greg Kroah-Hartman Problem description: All the USB memory sticks I have wo

Re: [PATCH 4/4] staging: ozwpan: Return correct hub status.

2013-08-05 Thread Rupesh Gujare
On 05/08/13 19:56, Dan Carpenter wrote: On Mon, Aug 05, 2013 at 06:40:15PM +0100, Rupesh Gujare wrote: Fix a bug where we were not returning correct hub status for 8th port. What are the user visible effects of this bug? 8 th port is never assigned to new device & we loose one port. Style n

Re: [PATCH 3/4] staging: ozwpan: Reset port configuration number.

2013-08-05 Thread Rupesh Gujare
On 05/08/13 19:21, Dan Carpenter wrote: On Mon, Aug 05, 2013 at 06:40:14PM +0100, Rupesh Gujare wrote: Make sure that we reset port configuration no. when PD departs. What happens if we don't do this? What is the user visible effect of this patch? There is no user visible effect at the mo

Re: [PATCH 4/4] staging: ozwpan: Return correct hub status.

2013-08-05 Thread Dan Carpenter
On Mon, Aug 05, 2013 at 06:40:15PM +0100, Rupesh Gujare wrote: > Fix a bug where we were not returning correct hub status > for 8th port. What are the user visible effects of this bug? Style nits below. > > Signed-off-by: Rupesh Gujare > --- > drivers/staging/ozwpan/ozhcd.c | 11 +--

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-05 Thread Rupesh Gujare
On 05/08/13 18:53, Dan Carpenter wrote: On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: This patch fixes crash issue when there is quick cycle of de-enumeration & enumeration due to loss of wireless link. It is found that sometimes new device (or coming back device) returns very

Re: [PATCH] usb: fix some scripts/kernel-doc warnings

2013-08-05 Thread Yacine Belkadi
On 08/04/2013 11:29 PM, Greg Kroah-Hartman wrote: > On Sun, Aug 04, 2013 at 10:05:36PM +0200, Yacine Belkadi wrote: >> On 08/03/2013 05:29 AM, Greg Kroah-Hartman wrote: >>> On Fri, Aug 02, 2013 at 08:10:04PM +0200, Yacine Belkadi wrote: When building the htmldocs (in verbose mode), scripts/ker

RE: [PATCH 03/13] staging: dwc2: unshift non-bool register value constants

2013-08-05 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Monday, August 05, 2013 7:51 AM > > On Wed, Jul 17, 2013 at 06:52:56PM +, Paul Zimmerman wrote: > > > From: Matthijs Kooijman [mailto:matth...@stdin.nl] > > > Sent: Wednesday, July 17, 2013 8:10 AM > > > > > > Various register fields

Re: [PATCH 3/4] staging: ozwpan: Reset port configuration number.

2013-08-05 Thread Dan Carpenter
On Mon, Aug 05, 2013 at 06:40:14PM +0100, Rupesh Gujare wrote: > Make sure that we reset port configuration no. when PD departs. > What happens if we don't do this? What is the user visible effect of this patch? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 1/4] staging: ozwpan: Fixes crash due to invalid port aceess.

2013-08-05 Thread Dan Carpenter
On Mon, Aug 05, 2013 at 06:40:12PM +0100, Rupesh Gujare wrote: > This patch fixes kernel crash issue, when we receive URB request > after de-enumerating device. > In other words we were getting a NULL dereference dereferencing "ep". There is an existing check already, which should be cleaned up.

Re: After entering D3 cold: URB ffff88020ea41000 submitted while active

2013-08-05 Thread Oleksii Shevchuk
Oliver Neukum writes: I use patched module whole day. Looks like working without issues. Many thanks > On Thu, 2013-07-25 at 18:53 +0300, Oleksii Shevchuk wrote: > > Thank you, > > could you try the attached patch? > > Regards > Oliver -- To unsubscribe from this list: send t

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-05 Thread Kukjin Kim
On 08/06/13 03:06, Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 10:01:36) On 07/23/13 08:49, Tomasz Figa wrote: This series is an attempt to move clock support on Samsung S3C64xx SoCs to Common Clock Framework. First, support for PLL types present on S3C64xx SoCs is added to Samsung Co

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-05 Thread Mike Turquette
Quoting Kukjin Kim (2013-08-05 10:01:36) > On 07/23/13 08:49, Tomasz Figa wrote: > > This series is an attempt to move clock support on Samsung S3C64xx SoCs > > to Common Clock Framework. > > > > First, support for PLL types present on S3C64xx SoCs is added to Samsung > > Common Clock Framework dri

RE: [PATCH 00/13] staging: dwc2: Register-related cleanups

2013-08-05 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Monday, August 05, 2013 7:14 AM > > Hi Paul, > > > With the exception of 1 and 13 which I already commented on, you can add > > my acked-by to the rest of this series. > I assume you meant "3" instead of "13" here, given that you commen

RE: About the hibernation feature implementation in dwc3 driver

2013-08-05 Thread Wang, Yu Y
Hi Balbi, Please check the attached logs. The kernel base one kernel3.10. Thanks, Yu > > > > On Fri, Aug 02, 2013 at 03:42:20PM +, Wang, Yu Y wrote: > > > > Hi, > > > > > > > > On Fri, Aug 02, 2013 at 10:54:18AM +, Wang, Yu Y wrote: > > > > > Check my comments as follows. > > > > > > > >

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-05 Thread Dan Carpenter
On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: > This patch fixes crash issue when there is quick cycle of > de-enumeration & enumeration due to loss of wireless link. > > It is found that sometimes new device (or coming back device) > returns very fast, even before USB core read o

[PATCH 3/4] staging: ozwpan: Reset port configuration number.

2013-08-05 Thread Rupesh Gujare
Make sure that we reset port configuration no. when PD departs. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozhcd.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index a739986..b060e43 100644 --- a/drivers/stagi

[PATCH 4/4] staging: ozwpan: Return correct hub status.

2013-08-05 Thread Rupesh Gujare
Fix a bug where we were not returning correct hub status for 8th port. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozhcd.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index b060e43..

[PATCH 1/4] staging: ozwpan: Fixes crash due to invalid port aceess.

2013-08-05 Thread Rupesh Gujare
This patch fixes kernel crash issue, when we receive URB request after de-enumerating device. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozhcd.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/oz

[PATCH 0/4] staging: ozwpan: Fix crash issues.

2013-08-05 Thread Rupesh Gujare
This patch series fixes crash issues observed, & fix a bug in hub status code. Rupesh Gujare (4): staging: ozwpan: Fixes crash due to invalid port aceess. staging: ozwpan: Increment port number for new device. staging: ozwpan: Reset port configuration number. staging: ozwpan: Return correc

[PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-05 Thread Rupesh Gujare
This patch fixes crash issue when there is quick cycle of de-enumeration & enumeration due to loss of wireless link. It is found that sometimes new device (or coming back device) returns very fast, even before USB core read out hub status, resulting in allocation of same port, which results in uns

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-05 Thread Kukjin Kim
On 07/23/13 08:49, Tomasz Figa wrote: This series is an attempt to move clock support on Samsung S3C64xx SoCs to Common Clock Framework. First, support for PLL types present on S3C64xx SoCs is added to Samsung Common Clock Framework driver. Then the main clock driver for mentioned SoCs is introd

Re: [PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-08-05 Thread Sarah Sharp
On Mon, Aug 05, 2013 at 01:29:12PM +0800, Greg Kroah-Hartman wrote: > On Wed, Jul 31, 2013 at 11:30:28AM -0700, Sarah Sharp wrote: > > From: Julius Werner > > > > The USB hub driver's event handler contains a check to catch SuperSpeed > > devices that transitioned into the SS.Inactive state and t

Re: Possible issues on Intel USB 3.0 ports switchover mechnism.

2013-08-05 Thread Sarah Sharp
Hi Lin, Thanks for the analysis and suggestions. However, I cannot take your patch to modify the Intel port switchover mechanism for several reasons. I'm sorry for the long email, but this question has been asked before, and I feel the need to document the reasons not to do this, so I'm Ccing the

Re: Regression: USB memory stick stalls and no longer automounts under 3.11-rc1

2013-08-05 Thread Alan Stern
On Mon, 5 Aug 2013, [ISO-8859-1] Alex Villac��s Lasso wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=60685 > > Posting in the mailing list as requested by Greg Kroah-Hartman > > Problem description: > All the USB memory sticks I have work correctly under 3.11-rc1,

Re: Audio I/O parameters

2013-08-05 Thread Alan Stern
On Sun, 4 Aug 2013, James Stone wrote: > Don't know if these syslog errors are also related? > > Aug 3 18:34:06 blueberry kernel: [35122.375869] retire_capture_urb: > 3189 callbacks suppressed I don't know. I can't tell where they come from or what they mean. Alan Stern -- To unsubscribe fro

Regression: USB memory stick stalls and no longer automounts under 3.11-rc1

2013-08-05 Thread Alex Villací­s Lasso
https://bugzilla.kernel.org/show_bug.cgi?id=60685 Posting in the mailing list as requested by Greg Kroah-Hartman Latest working kernel version: 3.10 Earliest working kernel version: 3.11-rc1 Distribution: Fedora 18 x86_64 If some fields are empty or look unusual you may

Re: [PATCH 03/13] staging: dwc2: unshift non-bool register value constants

2013-08-05 Thread Matthijs Kooijman
Hi Paul, On Wed, Jul 17, 2013 at 06:52:56PM +, Paul Zimmerman wrote: > > From: Matthijs Kooijman [mailto:matth...@stdin.nl] > > Sent: Wednesday, July 17, 2013 8:10 AM > > > > Various register fields wider than one bit have constants defined for > > their value. Previously, these registers wou

Re: [PATCH] USB: serial: move the "simple" drivers into usb-serial-simple.c

2013-08-05 Thread Frans Klaver
On Mon, Aug 05, 2013 at 07:41:42PM +0800, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > Instead of having to create a new driver for a "simple" usb to serial > device, mush them all into one file, with a macro, so as to make it easy > to add new ones. Sounds like a sensible thing to d

Re: [PATCH] USB: serial: move the "simple" drivers into usb-serial-simple.c

2013-08-05 Thread Dan Williams
On Mon, 2013-08-05 at 19:41 +0800, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > Instead of having to create a new driver for a "simple" usb to serial > device, mush them all into one file, with a macro, so as to make it easy > to add new ones. > > Cc: "René Bürgel" > Cc: Wei Shuai

Re: [PATCH v2 1/4] USB: introduce usb_device_no_sg_constraint() helper

2013-08-05 Thread Ming Lei
On Mon, Aug 5, 2013 at 10:07 PM, Alan Stern wrote: > On Mon, 5 Aug 2013, Ming Lei wrote: > >> Some host controllers(such as xHCI) can support building >> packet from discontinuous buffers, so introduce one flag >> and helper for this kind of host controllers, then the >> feature can help some appl

Re: [PATCH 00/13] staging: dwc2: Register-related cleanups

2013-08-05 Thread Matthijs Kooijman
Hi Paul, > With the exception of 1 and 13 which I already commented on, you can add > my acked-by to the rest of this series. I assume you meant "3" instead of "13" here, given that you commented on patch 3 (about unshifting stuff) but not 13? Gr. Matthijs -- To unsubscribe from this list: send

Re: [PATCH] USB: global suspend and remote wakeup don't mix

2013-08-05 Thread Alan Stern
On Mon, 5 Aug 2013, Huang Rui wrote: > Hi Alan, > > On Thu, Jul 11, 2013 at 02:58:04PM -0400, Alan Stern wrote: > > The hub driver was recently changed to use "global" suspend for system > > suspend transitions on non-SuperSpeed buses. This means that we don't > > suspend devices individually by

Re: [PATCH v2 1/4] USB: introduce usb_device_no_sg_constraint() helper

2013-08-05 Thread Alan Stern
On Mon, 5 Aug 2013, Ming Lei wrote: > Some host controllers(such as xHCI) can support building > packet from discontinuous buffers, so introduce one flag > and helper for this kind of host controllers, then the > feature can help some applications(such as usbnet) by > supporting arbitrary length o

Re: Alcatel X220S HSDPA modem

2013-08-05 Thread Enrico Mioso
Oh - something like it happens for the E173! I'm sorry - I do not have a Windows machine, nor sighted assistance needed to install Windows somewhere. So I will have to wait... Or could someone help? Thank you infinitely for your reply!! On Mon, 5 Aug 2013, Dan Williams wrote: ==Date: Mon, 05

Re: Alcatel X220S HSDPA modem

2013-08-05 Thread Dan Williams
On Sun, 2013-08-04 at 01:59 +0200, Enrico Mioso wrote: > Hello everybody! > I'm going to investigate a little bit on an obscure Alcatel device - the > Alcatel X220s, manifactured by TCT Mobile Phones. > > It supports a NDIS network interface, as you will be able to discover looking > at the driv

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

2013-08-05 Thread Tuomas Tynkkynen
On 08/05/2013 09:38 AM, Prashant Gaikwad wrote: > On Thursday 01 August 2013 02:34 AM, Stephen Warren wrote: >> On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: >>> The lock bit on PLL_U does not seem to be working correctly and >>> sometimes never gets set when waiting for the PLL to come up. >>> R

[PATCH] USB: serial: move the "simple" drivers into usb-serial-simple.c

2013-08-05 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman Instead of having to create a new driver for a "simple" usb to serial device, mush them all into one file, with a macro, so as to make it easy to add new ones. Cc: "René Bürgel" Cc: Wei Shuai Cc: Josh Triplett Cc: Frans Klaver Cc: "Wesley W. Terpstra" Cc: Johan Hovo

[PATCH v2] staging: ozwpan: Fix farewell report.

2013-08-05 Thread Rupesh Gujare
This patch fix following issues reported by Dan:- 1) There is no check limiting the size to 32 and it could be up to 253 bytes. 2) Use defines instead of magic numbers. 3) The oz_farewell struct is supposed to be a variable length struct but the variable part is put in the middle. It doesn'

[PATCH v2] staging: ozwpan: Fix build warning.

2013-08-05 Thread Rupesh Gujare
This patch fixes following build warning. drivers/built-in.o: In function `oz_hcd_heartbeat': >> (.text+0x30aadd): undefined reference to `__divdi3' drivers/built-in.o: In function `oz_hcd_heartbeat': >> (.text+0x30ac85): undefined reference to `__divdi3' Signed-off-by: Rupesh Gujare --- dri

Re: [PATCH] staging: ozwpan: Fix build warning.

2013-08-05 Thread Rupesh Gujare
On 04/08/13 19:17, Anca Emanuel wrote: Why do not use div_u64() ? [quote]unsigned 64bit divide with 32bit divisor This is the most common 64bit divide and should be used if possible, as many 32bit archs can optimize this variant better than a full 64bit divide. [/quote] - ep->cr

Re: [PATCH] USB: global suspend and remote wakeup don't mix

2013-08-05 Thread Huang Rui
Hi Alan, On Thu, Jul 11, 2013 at 02:58:04PM -0400, Alan Stern wrote: > The hub driver was recently changed to use "global" suspend for system > suspend transitions on non-SuperSpeed buses. This means that we don't > suspend devices individually by setting the suspend feature on the > upstream hub

Re: [PATCH v2 3/4] USBNET: support DMA SG

2013-08-05 Thread Ming Lei
On Mon, Aug 5, 2013 at 5:14 PM, Oliver Neukum wrote: > On Mon, 2013-08-05 at 16:47 +0800, Ming Lei wrote: > >> @@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb, >> entry = (struct skb_data *) skb->cb; >> entry->urb = urb; >> entry->dev = dev; >> - en

Re: [PATCH v2 3/4] USBNET: support DMA SG

2013-08-05 Thread Oliver Neukum
On Mon, 2013-08-05 at 16:47 +0800, Ming Lei wrote: > @@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb, > entry = (struct skb_data *) skb->cb; > entry->urb = urb; > entry->dev = dev; > - entry->length = length; > > usb_fill_bulk_urb (urb, dev-

[PATCH v2 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-05 Thread Ming Lei
This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA SG is possible), so TSO can be enabled and skb fragment buffers can be passed to usb stack via urb->sg directly. With the patch, system CPU utilizati

[PATCH v2 2/4] USB: XHCI: mark no_sg_constraint

2013-08-05 Thread Ming Lei
This patch marks all xHCI controllers as no_sg_constraint since xHCI supports building packet from discontinuous buffers. Cc: Alan Stern Acked-by: Sarah Sharp Signed-off-by: Ming Lei --- drivers/usb/host/xhci.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/host/xhci.c

[PATCH v2 3/4] USBNET: support DMA SG

2013-08-05 Thread Ming Lei
This patch introduces support of DMA SG if the USB host controller which usbnet device is attached to is capable of building packet from discontinuous buffers. The patch supports passing the skb fragment buffers to usb stack directly via urb->sg. Cc: Eric Dumazet Cc: Ben Hutchings Cc: Grant Gru

[PATCH v2 0/4] USB & USBNET: loose SG check and support usbnet DMA SG

2013-08-05 Thread Ming Lei
Hi, This patchset allows drivers to pass sg buffers which size can't be divided by max packet size of endpoint if the host controllers(such ax xHCI) support this kind of sg buffers. Previously we added check[1] on the situation and don't allow these sg buffers passed to USB HCD, looks the check i

[PATCH v2 1/4] USB: introduce usb_device_no_sg_constraint() helper

2013-08-05 Thread Ming Lei
Some host controllers(such as xHCI) can support building packet from discontinuous buffers, so introduce one flag and helper for this kind of host controllers, then the feature can help some applications(such as usbnet) by supporting arbitrary length of sg buffers. Cc: Alan Stern Signed-off-by: M

Re: About TRB_TO_EP_INDEX() macro using

2013-08-05 Thread gre...@linuxfoundation.org
On Mon, Aug 05, 2013 at 08:07:25AM +, Du, ChangbinX wrote: > Recently when I check xHCI code, find that some functions try to get EP index > from a Command Completion Event TRB via TRB_TO_EP_INDEX() macro. > > This is totally wrong. The macro definition is: > > #define TRB_TO_EP_INDEX(

About TRB_TO_EP_INDEX() macro using

2013-08-05 Thread Du, ChangbinX
Recently when I check xHCI code, find that some functions try to get EP index from a Command Completion Event TRB via TRB_TO_EP_INDEX() macro. This is totally wrong. The macro definition is: #define TRB_TO_EP_INDEX(p) p) & (0x1f << 16)) >> 16) - 1) TRB_TO_EP_INDEX only

Re: After entering D3 cold: URB ffff88020ea41000 submitted while active

2013-08-05 Thread Oliver Neukum
On Thu, 2013-07-25 at 18:53 +0300, Oleksii Shevchuk wrote: Thank you, could you try the attached patch? Regards Oliver >From 0b46b7c8cd1747470d7ed874b3a130090d4d7d3c Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Mon, 5 Aug 2013 09:13:51 +0200 Subject: [PATCH] cdc-w

Re: [PATCH 1/1] usb: chipidea: refine the operation of creating register mapping

2013-08-05 Thread Peter Chen
On Mon, Aug 05, 2013 at 10:05:56AM +0300, Alexander Shishkin wrote: > Peter Chen writes: > > > - The old operation needs to call hw_alloc_regmap two times, and > > the first operation is only used to know if the controller is > > lpm supported, besides, there is a kfree before kzalloc, it is also

Re: [PATCH 1/1] usb: chipidea: refine the operation of creating register mapping

2013-08-05 Thread Alexander Shishkin
Peter Chen writes: > - The old operation needs to call hw_alloc_regmap two times, and > the first operation is only used to know if the controller is > lpm supported, besides, there is a kfree before kzalloc, it is also > tricky. Why tricky? kfree() is called from either NULL or a valid pointer,