Re: v3.11-rc1 USB regressions

Hi Aaro, On 16.07.2013 00:56, Aaro Koskinen wrote: > Hi, > > I think USB tree introduced regressions in v3.11-rc1, at least for some > OMAP devices using legacy boot. Thanks for checking the tree so early. > I have only bisected these; I have no > idea what the real fixes are but the following

Re: [PATCH v2 0/4] usb: musb: fix USB enumeration issue in OMAP3 platform

Tony, On Monday 08 July 2013 04:44 PM, Kishon Vijay Abraham I wrote: > This series fixes the USB enumeration issue caused because of the controller > not able to get a reference to the PHY because of incorrect binding in the > board file. > > In the case of non-dt boot, the platform specific init

Re: [PATCH] usb: udc: add gadget state kobject uevent

Hi Greg, The USB on our platform can change roles between HOST and GADGET, but it is not capable of OTG. When the USB changes between roles the udev will run some scripts automatically according to the udev rules. The default role is GADGET, and we bind the g_mass_storage to the USB GADGET role.

Re: DWC3: Event Interrupt Mask issue

Hi Felipe, On Mon, Jul 15, 2013 at 11:48:01PM +0800, Felipe Balbi wrote: > On Fri, Jun 14, 2013 at 09:37:54AM +0800, Huang Rui wrote: > > On Thu, Jun 13, 2013 at 10:20:53PM +0800, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Jun 13, 2013 at 08:26:12PM +0800, Huang Rui wrote: > > > > > > I wa

Re: [PATCH v2 4/9] ARM: tegra: Remove USB platform data

On 07/15/2013 01:53 PM, Tuomas Tynkkynen wrote: > USB-related platform data is not used anymore in the Tegra USB drivers, > so remove all of it. Acked-by: Stephen Warren (I said that for v1 too. Tuomas, you can cut/paste that ack into the commit description to keep it for any future postings).

Re: [PATCH v2 0/9] Tegra USB cleanup series

On 07/15/2013 01:53 PM, Tuomas Tynkkynen wrote: > Hi, > > Here's a V2 of the few cleanup patches for the Tegra USB drivers, to be > applied > on top of Mikko's two patch sets. It mostly deals with removing all usage of > platform data and using standard helpers and enums instead of Tegra-specific

Re: [PATCH v6] usb: dwc3: use extcon fwrk to receive connect/disconnect

On 07/16/2013 12:51 AM, Felipe Balbi wrote: > On Mon, Jul 15, 2013 at 09:09:02PM +0530, Kishon Vijay Abraham I wrote: >> Modified dwc3-omap to receive connect and disconnect notification using >> extcon framework. Also did the necessary cleanups required after >> adapting to extcon framework. >> >>

v3.11-rc1 USB regressions

Hi, I think USB tree introduced regressions in v3.11-rc1, at least for some OMAP devices using legacy boot. I have only bisected these; I have no idea what the real fixes are but the following reverts make Nokia OMAP2+ boards again usable for kernel development work (they need working USB connecti

Re: Audio I/O parameters

On Mon, Jul 15, 2013 at 9:42 PM, Alan Stern wrote: > On Mon, 15 Jul 2013, Clemens Ladisch wrote: > >> > The interrupts shouldn't differ by more than the duration of one URB, >> > which would be 1 ms. There is an initial delay when a stream is first >> > started, which generally lasts 5-10 ms. Bu

Re: Audio I/O parameters

On Mon, 15 Jul 2013, Clemens Ladisch wrote: > > The interrupts shouldn't differ by more than the duration of one URB, > > which would be 1 ms. There is an initial delay when a stream is first > > started, which generally lasts 5-10 ms. But I think that hasn't > > changed since the 3.5 kernel. W

[PATCH v2 3/9] usb: tegra: host: Remove references to plat data

Platform data is not used in tegra-ehci anymore, so remove all references to it. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 06e8feb..a208cea 10064

[PATCH v2 5/9] usb: phy: tegra: Register as an USB PHY.

Register the Tegra PHY device instances with the PHY subsystem so that the Tegra EHCI driver can locate a PHY via the standard APIs. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/usb/phy/phy-tegr

[PATCH v2 1/9] usb: phy: tegra: Remove unnecessary 'dev' field

struct usb_phy already has a field for the device pointer, so this unnecessary field can be removed. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 27 +++ include/linux/usb/tegra_usb_phy.h | 1 - 2 files changed, 15 insertions(+), 13 deletions(-

[PATCH v2 2/9] usb: host: tegra: Remove leftover code

ehci-tegra calls devm_usb_get_phy, which will never succeed since the Tegra PHY does not register itself with the PHY subsystem. It is also completely redundant since the code has already located a PHY via an internal API. Call otg_set_host unconditionally to simplify the code since it should be s

[PATCH v2 4/9] ARM: tegra: Remove USB platform data

USB-related platform data is not used anymore in the Tegra USB drivers, so remove all of it. Signed-off-by: Tuomas Tynkkynen --- arch/arm/mach-tegra/tegra.c | 38 + include/linux/platform_data/tegra_usb.h | 32 --- include/linux

[PATCH v2 8/9] usb: phy: tegra: Use DT helpers for phy_type

Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-te

[PATCH v2 9/9] usb: phy: tegra: Use DT helpers for dr_mode

Use the new of_usb_get_dr_mode helper function for parsing dr_mode from the device tree. Also replace the usage of the custom tegra_usb_phy_mode enum with the standard enum. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 24 include/linux/usb/teg

[PATCH v2 7/9] usb: phy: tegra: Remove custom PHY locating APIs

The Tegra EHCI driver is no longer using these custom functions, so they can be removed. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 24 include/linux/usb/tegra_usb_phy.h | 2 -- 2 files changed, 26 deletions(-) diff --git a/drivers/usb/phy/

[PATCH v2 6/9] usb: host: tegra: Locate a PHY via standard API

Use devm_get_phy_by_phandle to get a PHY device instead of the custom Tegra functions. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index

[PATCH v2 0/9] Tegra USB cleanup series

Hi, Here's a V2 of the few cleanup patches for the Tegra USB drivers, to be applied on top of Mikko's two patch sets. It mostly deals with removing all usage of platform data and using standard helpers and enums instead of Tegra-specific ones. V2 Diff: Patch 5: Do the usb_add_phy_dev as the very

Re: Audio I/O parameters

Alan Stern wrote: > On Sat, 13 Jul 2013, Clemens Ladisch wrote: >> James Stone wrote: >>> On Mon, Jul 8, 2013 at 2:12 PM, James Stone wrote: > configuring for 44100Hz, period = 64 frames (1.5 ms), buffer = 2 periods > JackAudioDriver::ProcessAsync: read error, stopping... Some fu

Re: [PATCH] [RFC] usb: dwc3: removal of assumption that usb3 phy always present

On Fri, Jul 05, 2013 at 09:35:05AM -0500, Ruchika Kharwar wrote: > > On 07/04/2013 01:26 AM, Ruchika Kharwar wrote: > >DRA7XX has several USB OTG subsystems. USB_OTG_SS1 includes a USB1 and USB2 > >phy. USB_OTG_SS2 includes only a USB2 phy. > >This patch allows the dwc3 probe to continue if a usb3

Re: [PATCH net 2/2] usb/net/r815x: fix cast to restricted __le32

On Fri, 2013-07-12 at 16:26 +0800, Hayes Wang wrote: > >> drivers/net/usb/r815x.c:38:16: sparse: cast to restricted __le32 > >> drivers/net/usb/r815x.c:67:15: sparse: cast to restricted __le32 > >> drivers/net/usb/r815x.c:69:13: sparse: incorrect type in assignment > >> (different base types) >

Re: [PATCH] usb: udc: add gadget state kobject uevent

On Mon, Jul 15, 2013 at 11:57:24AM +0800, Rong Wang wrote: > usb: udc: add gadget state kobject uevent > > Add USB_UDC_STATE environment variable in udc uevent > callback and trigger kobject_uevent in usb_gadget_set_state > to inform the user-space the state of the gadget. Why? A

Re: [PATCH v6] usb: dwc3: use extcon fwrk to receive connect/disconnect

On Mon, Jul 15, 2013 at 09:09:02PM +0530, Kishon Vijay Abraham I wrote: > Modified dwc3-omap to receive connect and disconnect notification using > extcon framework. Also did the necessary cleanups required after > adapting to extcon framework. > > Signed-off-by: Kishon Vijay Abraham I > Acked-by

Re: DWC3: Event Interrupt Mask issue

On Fri, Jun 14, 2013 at 09:37:54AM +0800, Huang Rui wrote: > On Thu, Jun 13, 2013 at 10:20:53PM +0800, Felipe Balbi wrote: > > Hi, > > > > On Thu, Jun 13, 2013 at 08:26:12PM +0800, Huang Rui wrote: > > > > > I was reading dwc3 codes and found that during the process of > > > > > configuring event

[PATCH v6] usb: dwc3: use extcon fwrk to receive connect/disconnect

Modified dwc3-omap to receive connect and disconnect notification using extcon framework. Also did the necessary cleanups required after adapting to extcon framework. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Acked-by: Chanwoo Choi --- This patch should be applied after all o

Re: [PATCH v2 0/3] usb: tegra: Replace nvidia,vbus-gpio property with vbus-supply

On 07/15/2013 05:57 AM, Mikko Perttunen wrote: > Hey Felipe/Stephen, > > what's the status of this patchset and the other one > ("usb: phy: tegra: Read UTMI parameters from device tree")? > Can I consider them accepted/pulled for 3.12? 3.11-rc1 was just released over the weekend. Patches for 3.12

Re: Linux USB file storage gadget with new UDC

Hi, > Victor, if you can get hold of a USB bus analyzer, you would be able to > see directly when the DATA1 packet does or does not get sent. I am in the process of getting a USB bus analyzer. > No -- the problem is that the UDC completes the Set-Config request > before it should. In other word

Re: Help adding trace events to xHCI

On Fri, Jul 12, 2013 at 12:55:43PM -0400, Steven Rostedt wrote: > On Fri, 2013-07-12 at 09:41 -0700, Sarah Sharp wrote: > > On Fri, Jul 12, 2013 at 07:25:59AM +0300, Kalle Valo wrote: > > > Thanks for the suggestion. I'm not familiar with all the userspace > > tools for trace events, so I didn't

Re: Help adding trace events to xHCI

* Mark Wielaard (m...@redhat.com) wrote: > Hi Mathieu, > > On Fri, Jul 12, 2013 at 01:08:28PM -0400, Mathieu Desnoyers wrote: > > * Sarah Sharp (sarah.a.sh...@linux.intel.com) wrote: > > > Thanks for the suggestion. I'm not familiar with all the userspace > > > tools for trace events, so I didn't

Re: [PATCH v2 0/3] usb: tegra: Replace nvidia,vbus-gpio property with vbus-supply

Hey Felipe/Stephen, what's the status of this patchset and the other one ("usb: phy: tegra: Read UTMI parameters from device tree")? Can I consider them accepted/pulled for 3.12? Thanks, Mikko On 06/28/2013 03:33 PM, Mikko Perttunen wrote: This patchset removes the ehci-tegra device tree prope

Re: [PATCH] usb: dwc3: adapt to use dr_mode device tree helper

On 07/15/2013 01:07 PM, Felipe Balbi wrote: > On Mon, Jul 15, 2013 at 10:03:02AM +0300, Roger Quadros wrote: >> Hi, >> >> On 07/12/2013 12:50 PM, Felipe Balbi wrote: >>> From: Ruchika Kharwar >>> >>> This patch adapts the dwc3 to use the device tree helper >>> "of_usb_get_dr_mode" for the mode of

Re: [PATCH] usb: dwc3: adapt to use dr_mode device tree helper

On Mon, Jul 15, 2013 at 10:03:02AM +0300, Roger Quadros wrote: > Hi, > > On 07/12/2013 12:50 PM, Felipe Balbi wrote: > > From: Ruchika Kharwar > > > > This patch adapts the dwc3 to use the device tree helper > > "of_usb_get_dr_mode" for the mode of operation of the dwc3 instance > > being probed

[PATCH] usb: dwc3: fix the error returned with usb3_phy failure

From: Ruchika Kharwar When there is an error with the usb3_phy probe or absence, the error returned is erroneously for usb2_phy. Cc: Signed-off-by: Ruchika Kharwar Signed-off-by: Felipe Balbi --- resending with stable in Cc drivers/usb/dwc3/core.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] usb: gadget: fotg210-udc: Remove bogus __init/__exit annotations

On Wed, Jul 10, 2013 at 11:45:16PM +0200, Geert Uytterhoeven wrote: > When builtin (CONFIG_USB_FOTG210_UDC=y): > > LD drivers/usb/gadget/built-in.o > WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in > reference from the variable fotg210_driver to the function > .in

[PATCH] usb: dwc3: gadget: don't prevent gadget from being probed if we fail

In case we fail our ->udc_start() callback, we should be ready to accept another modprobe following the failed one. We had forgotten to clear dwc->gadget_driver back to NULL and, because of that, we were preventing gadget driver modprobe from being retried. Cc: Signed-off-by: Felipe Balbi ---

Re: [PATCH] USB: global suspend and remote wakeup don't mix

On Fri, Jul 12, 2013 at 10:57:25AM -0400, Alan Stern wrote: > On Fri, 12 Jul 2013, Peter Chen wrote: > > > > - For hub cases, since you said it must send suspend to hub at > > global suspend case (system suspend procedure), this suspend > > request procedure can't be skipped. > > No -- it is nec

[PATCH 4/4] usbtmc: remove redundant braces

There is a few cases where braces are not needed. This patch removes unnecessary '& 255' pieces as well when lvalue type is u8. Signed-off-by: Andy Shevchenko --- drivers/usb/class/usbtmc.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH 2/4] usbtmc: convert to devm_kzalloc

kfree(data) will be called implicitly. Signed-off-by: Andy Shevchenko --- drivers/usb/class/usbtmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 92eaf9d..91190e6 100644 --- a/drivers/usb/class/usbtmc.c +++ b/

[PATCH 3/4] usbtmc: call pr_err instead of plain printk

Additionally remove useless label. Signed-off-by: Andy Shevchenko --- drivers/usb/class/usbtmc.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 91190e6..cb2d672 100644 --- a/drivers/usb/class/usbtmc.c +++

[PATCH 1/4] usbtmc: remove trailing spaces

Recent patch series introduces few trailing spaces. This patch removes them. No functional change. Signed-off-by: Andy Shevchenko --- drivers/usb/class/usbtmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index

[PATCH 1/1] usb: phy: samsung: Fix an error message typo

The error message is common to both clk_get functions. Update it accordingly. Signed-off-by: Sachin Kamat --- drivers/usb/phy/phy-samsung-usb2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-samsung-usb2.c b/drivers/usb/phy/phy-samsung-usb2.c index 1

Incompleteness of HW capability registers (Was: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame())

Hi Stephen, > > I'm not sure how many of the below driver parameters are actually > > required. I think as least the three fifo size parameters, plus > > max_transfer_size and max_packet_count, are needed. > > I'm curious why any of them are required; why aren't the values embedded > in the HW reg

Re: [PATCH 4/6] mfd: omap-usb-host: Put pins in IDLE state on suspend

On 07/14/2013 04:22 PM, Kevin Hilman wrote: > On 07/10/2013 05:23 PM, Roger Quadros wrote: >> In order to support wake up from suspend use the pinctrl >> framework to put the USB host pins in IDLE state during suspend. >> >> CC: Samuel Ortiz >> Signed-off-by: Roger Quadros > > [...] > >> @@ -60

Re: [PATCH] usb: dwc3: adapt to use dr_mode device tree helper

Hi, On 07/12/2013 12:50 PM, Felipe Balbi wrote: > From: Ruchika Kharwar > > This patch adapts the dwc3 to use the device tree helper > "of_usb_get_dr_mode" for the mode of operation of the dwc3 instance > being probed. > > [ ba...@ti.com : make of_usb_get_dr_mode() conditional on > dev->o