Re: [PATCH v7 1/9] drivers: phy: add generic PHY framework

2013-06-23 Thread Kishon Vijay Abraham I
On Wednesday 19 June 2013 02:52 AM, Sylwester Nawrocki wrote: Hi Kishon, I've noticed there is a little inconsistency between the code and documentation. On 06/13/2013 10:43 AM, Kishon Vijay Abraham I wrote: +3. Creating the PHY + +The PHY driver should create the PHY in order for other periph

Re: [PATCH v7 7/9] usb: musb: omap2430: use the new generic PHY framework

2013-06-23 Thread Felipe Balbi
Hi, On Mon, Jun 24, 2013 at 11:01:56AM +0530, Kishon Vijay Abraham I wrote: > >>@@ -397,9 +407,10 @@ static int omap2430_musb_init(struct musb *musb) > >>if (glue->status != OMAP_MUSB_UNKNOWN) > >>omap_musb_set_mailbox(glue); > >> > >>- usb_phy_init(musb->xceiv); > >>+ phy_init

Re: Linux USB file storage gadget with new UDC

2013-06-23 Thread victor yeo
Hi, >> The problem is in UDC driver. i made the change, it is ok now. > > Good. I noticed that the usb_ep_set_wedge routine still isn't working > right. You might try to fix that. > > Alan Stern > Ok, is the usb_ep_set_wedge routine not working? I can't see that in the log file. Now, in USB 2.

Re: [PATCH v7 7/9] usb: musb: omap2430: use the new generic PHY framework

2013-06-23 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 June 2013 03:17 PM, Felipe Balbi wrote: Hi, On Thu, Jun 13, 2013 at 02:13:57PM +0530, Kishon Vijay Abraham I wrote: Use the generic PHY framework API to get the PHY. The usb_phy_set_resume and usb_phy_set_suspend is replaced with power_on/get_sync and power_off/put_sync to al

Re: [RFC PATCH v1 5/6] USB: EHCI: improve interrupt qh unlink

2013-06-23 Thread Ming Lei
On Sat, Jun 22, 2013 at 4:16 AM, Alan Stern wrote: > On Thu, 20 Jun 2013, Ming Lei wrote: > >> IMO, there is no any side effect when we change the state to >> QH_STATE_UNLINK_WAIT and later change back to QH_STATE_LINKED >> later under this situation. > > I don't like the idea of changing an invar

Re: URB completion order, normal behavior or bug?

2013-06-23 Thread Alan Stern
On Sun, 23 Jun 2013, Daniel Santos wrote: > So I'm working on this MCP2210 driver which talks in 64-byte > request/response pairs using interrupt URBs (it can be used with > hid-generic, but I don't want to do that). I'm testing on a Raspberry > Pi Model B using the Raspbian 3.9.7 kernel. My us

RE: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-23 Thread Chen Peter-B29397
> Hi Peter, > > > > Peter, I dunno if you are already aware of it, but the USB peripheral > > > mode hangs > > > on MX233. It's easy to replicate for example if you try to run CDC > > > ethernet over > > > the USB peripheral mode, then telnet into the board and run "dmesg" . > > > This will > >

[RESEND PATCH v2 1/1] usb: fix build error without CONFIG_USB_PHY

2013-06-23 Thread Peter Chen
on i386: drivers/built-in.o: In function `ci_hdrc_probe': core.c:(.text+0x20446b): undefined reference to `of_usb_get_phy_mode' Signed-off-by: Peter Chen Reported-by: Randy Dunlap Acked-by: Randy Dunlap --- Changes for v2: - Using IS_ENABLED to MACRO define include/linux/usb/of.h | 16 +++

Re: URB completion order, normal behavior or bug?

2013-06-23 Thread Greg KH
On Sun, Jun 23, 2013 at 04:56:22PM -0500, Daniel Santos wrote: > On 06/23/2013 01:43 PM, Greg KH wrote: > >On Sun, Jun 23, 2013 at 01:13:34PM -0500, Daniel Santos wrote: > >>So I'm working on this MCP2210 driver which talks in 64-byte > >>request/response pairs using interrupt URBs (it can be used

Re: URB completion order, normal behavior or bug?

2013-06-23 Thread Daniel Santos
On 06/23/2013 01:43 PM, Greg KH wrote: On Sun, Jun 23, 2013 at 01:13:34PM -0500, Daniel Santos wrote: So I'm working on this MCP2210 driver which talks in 64-byte request/response pairs using interrupt URBs (it can be used with hid-generic, but I don't want to do that). I'm testing on a Raspber

Re: URB completion order, normal behavior or bug?

2013-06-23 Thread Daniel Santos
Ahh, thank you both so very much for the responses, at least I know this isn't because of my code! :) On 06/23/2013 02:03 PM, Gordon Hollingworth wrote: It would be good to try it with the fiq_split branch of the kernel, that has much better scheduling to stop split transactions from going wron

Re: [PATCH 1/1] net: add dm9620 net usb driver

2013-06-23 Thread Peter Korsgaard
> "Joseph" == Joseph CHANG writes: Joseph> DM9620 is an USB2.0 network adapter rather than DM9601 USB1.1. This Joseph> driver processed the RX data 4 bytes header, TX data 2 bytes header, Joseph> make the control bit exactly right in PHY write function, and optional Joseph> IFF_ALLMUTLI b

Re: URB completion order, normal behavior or bug?

2013-06-23 Thread Gordon Hollingworth
It would be good to try it with the fiq_split branch of the kernel, that has much better scheduling to stop split transactions from going wrongŠ In this situation what happens is a split transaction fails (the device you are using is full speed and therefore uses split transactions) and the trans

Re: URB completion order, normal behavior or bug?

2013-06-23 Thread Greg KH
On Sun, Jun 23, 2013 at 01:13:34PM -0500, Daniel Santos wrote: > So I'm working on this MCP2210 driver which talks in 64-byte > request/response pairs using interrupt URBs (it can be used with > hid-generic, but I don't want to do that). I'm testing on a > Raspberry Pi Model B using the Raspbian 3

URB completion order, normal behavior or bug?

2013-06-23 Thread Daniel Santos
So I'm working on this MCP2210 driver which talks in 64-byte request/response pairs using interrupt URBs (it can be used with hid-generic, but I don't want to do that). I'm testing on a Raspberry Pi Model B using the Raspbian 3.9.7 kernel. My usual order of things is: I submit an out URB (to r

Re: [v2] usb: UHCI: fix pkt size in TD for a non-aligned sg element

2013-06-23 Thread Alan Stern
On Sun, 23 Jun 2013, Ming Lei wrote: > >> Since you mentioned it doesn't make sense to generate short packet > >> in the middle of transfer, also it may not be what the driver/device > >> expected, > >> I suggest to add a check in usb_submit_urb() for this case and returns > >> failure on it simp