Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-06-16 Thread Chao Xie
On Sat, Jun 15, 2013 at 4:01 AM, Alan Stern wrote: > On Fri, 14 Jun 2013, Roger Quadros wrote: > >> >> hi >> >> The following is my understanding. >> >> I think for PHY initialization and shutdown part, it is generic for >> >> other parts. >> >> PHY initialization need to be called before hc_drive

[PATCH v2] usb: phy: Improve Kconfig help for CONFIG_USB_PHY

2013-06-16 Thread George Spelvin
The previous text confused users by not describing the very common (e.g. x86 PC) sitations where no PHY driver is necessary. Signed-off-by: George Spelvin --- Just for example, here's some alternate, stronger wording. I don't know if this is true, either. Use whichever you prefer. drivers/usb

Re: [PATCH v4] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-16 Thread Chanwoo Choi
On 06/14/2013 10:10 PM, Kishon Vijay Abraham I wrote: > Modified dwc3-omap to receive connect and disconnect notification using > extcon framework. Also did the necessary cleanups required after > adapting to extcon framework. > > Signed-off-by: Kishon Vijay Abraham I > Acked-by: Felipe Balbi >

[PATCH] usb: phy: Improve Kconfig help for CONFIG_USB_PHY

2013-06-16 Thread George Spelvin
The previous text confused users by not describing the very common (e.g. x86 PC) sitations where no PHY driver is necessary. Signed-off-by: George Spelvin --- I still can't vouch for *correctness* of this text; I'm relying on other people in the S-o-b chain to do that. drivers/usb/phy/Kconfig |

Re: Please improve the Kconfig help for USB_PHY

2013-06-16 Thread Greg KH
On Sun, Jun 16, 2013 at 04:19:23PM -0400, George Spelvin wrote: > So I'm compiling 3.10-rc, and I am presented with a new config option: > > menuconfig USB_PHY > tristate "USB Physical Layer drivers" > select USB_OTG_UTILS > help > USB controllers (those which are host, d

Re: Two remain problems at chipidea driver

2013-06-16 Thread Peter Chen
On Thu, Mar 21, 2013 at 11:06 AM, Peter Chen wrote: > On Wed, Mar 20, 2013 at 01:04:33PM +0200, Alexander Shishkin wrote: >> Peter Chen writes: >> >> > On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: >> >> >> >> > Eg, for tablet or phone, the dr_mode may be "gadget", but the >

Please improve the Kconfig help for USB_PHY

2013-06-16 Thread George Spelvin
So I'm compiling 3.10-rc, and I am presented with a new config option: menuconfig USB_PHY tristate "USB Physical Layer drivers" select USB_OTG_UTILS help USB controllers (those which are host, device or DRD) need a device to handle the physical layer sig

[PATCH v2 3/5] USB: OMAP1: OTG controller driver

2013-06-16 Thread Aaro Koskinen
Transceivers need to manage OTG controller state on OMAP1 to enable switching between peripheral and host modes. Provide a driver for that. Signed-off-by: Aaro Koskinen --- drivers/usb/phy/Kconfig| 10 +++ drivers/usb/phy/Makefile | 1 + drivers/usb/phy/phy-omap-otg.c | 171

[PATCH v2 0/5] USB: OMAP1: Tahvo USB support for 770

2013-06-16 Thread Aaro Koskinen
Hi, These patches add support for Tahvo USB transceiver and allow using both host and peripheral modes on Nokia 770. Tested (peripheral mode, host mode, vbus detection) with 3.10-rc6. History: v2: Use extcon framework to trigger OTG driver mode changes. v1: http://marc.info/?l=li

[PATCH v2 1/5] ARM: OMAP1: USB: move omap_usb_config to platform data

2013-06-16 Thread Aaro Koskinen
Move omap_usb_config to platform data, so that OTG driver can include it. Signed-off-by: Aaro Koskinen --- arch/arm/mach-omap1/include/mach/usb.h | 38 +--- include/linux/platform_data/usb-omap1.h | 51 + 2 files changed, 52 insertions(+), 37

[PATCH v2 5/5] ARM: OMAP1: nokia770: enable Tahvo

2013-06-16 Thread Aaro Koskinen
Add platform data for Tahvo. Signed-off-by: Aaro Koskinen --- arch/arm/mach-omap1/board-nokia770.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/mach-omap1/board-nokia770.c b/arch/arm/mach-omap1/board-nokia770.c index 62a15e2..85089d8 100644 --- a/arch/arm/mach-omap1

[PATCH v2 4/5] USB: OMAP1: Tahvo USB transceiver driver

2013-06-16 Thread Aaro Koskinen
Add Tahvo USB transceiver driver. Based on old code from linux-omap tree. The original driver was written by Juha Yrjölä, Tony Lindgren, and Timo Teräs. Signed-off-by: Aaro Koskinen --- drivers/usb/phy/Kconfig | 14 ++ drivers/usb/phy/Makefile| 1 + drivers/usb/phy/phy-tahvo.c | 448

[PATCH v2 2/5] USB: OMAP1: add extcon to platform data

2013-06-16 Thread Aaro Koskinen
Add extcon field to platform data. Signed-off-by: Aaro Koskinen --- include/linux/platform_data/usb-omap1.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/platform_data/usb-omap1.h b/include/linux/platform_data/usb-omap1.h index 8c7764d..43b5ce1 100644 --- a/include/linux/p

[PATCH] USB: EHCI: Remove double assignment of .start in ehci_msp_hc_driver

2013-06-16 Thread Emil Goode
This patch removes a double assignment of .start in struct hc_driver ehci_msp_hc_driver and also makes the code look more tidy. Signed-off-by: Emil Goode --- drivers/usb/host/ehci-pmcmsp.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-pmcmsp.c b/d

Re: [RFC PATCH] usb: hcd: warn about URB buffers that are not DMA aligned and are about to be DMA mapped

2013-06-16 Thread Jussi Kivilinna
On 15.06.2013 16:47, Ming Lei wrote: > On Sat, Jun 15, 2013 at 9:10 PM, Jussi Kivilinna > wrote: >> On 15.06.2013 15:07, Ming Lei wrote: >>> On Sat, Jun 15, 2013 at 6:19 PM, Jussi Kivilinna >>> wrote: On 15.06.2013 10:41, Ming Lei wrote: > Cc: netdev > > On Fri, Jun 14, 2013 at

Re: [RFC PATCH] usb: hcd: warn about URB buffers that are not DMA aligned and are about to be DMA mapped

2013-06-16 Thread Jussi Kivilinna
On 16.06.2013 11:21, Oliver Neukum wrote: > On Saturday 15 June 2013 16:22:30 Jussi Kivilinna wrote: > >> Hm.. rethink this a bit. >> >> Transfer buffer might be dma aligned but shorter than cacheline and end of >> cacheline >> used as something else. Manual alignment by host driver does not catc

Re: [RFC PATCH] usb: hcd: warn about URB buffers that are not DMA aligned and are about to be DMA mapped

2013-06-16 Thread Oliver Neukum
On Saturday 15 June 2013 16:22:30 Jussi Kivilinna wrote: > Hm.. rethink this a bit. > > Transfer buffer might be dma aligned but shorter than cacheline and end of > cacheline > used as something else. Manual alignment by host driver does not catch that > or fix that. > So, yes.. dma mapping shou