Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-16 Thread Linus Walleij
On Wed, May 15, 2013 at 10:14 PM, Fabio Baltieri wrote: > On Wed, May 15, 2013 at 07:18:01PM +0200, Linus Walleij wrote: >> On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: >> >> > For all ux500 based platforms the maximum number of end-points are used. >> > Move this knowledge into the driver

Re: [PATCH 4/4] usb: tilegx: fix memleak when create hcd fail

2013-05-16 Thread Libo Chen
Hi Greg, On 2013/5/17 8:34, Greg KH wrote: > On Thu, May 09, 2013 at 12:58:11PM +0800, Libo Chen wrote: >> From: Libo Chen >> >> When usb_create_hcd fail, we should call gxio_usb_host_destroy >> >> Signed-off-by: Libo Chen >> --- >> drivers/usb/host/ohci-tilegx.c |7 +-- >> 1 files chan

[PATCH Resend 1/2] net/usb: r8152: Remove redundant version.h header inclusion

2013-05-16 Thread Sachin Kamat
version.h header inclusion is not necessary as detected by checkversion.pl. Signed-off-by: Sachin Kamat --- This series compile tested on linux-next (20130516). --- drivers/net/usb/r8152.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c

[PATCH Resend 2/2] net/usb: r8152: Use module_usb_driver()

2013-05-16 Thread Sachin Kamat
module_usb_driver() eliminates boilerplate and simplifies the code. Signed-off-by: Sachin Kamat Cc: Realtek linux nic maintainers --- drivers/net/usb/r8152.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c ind

usb:is that a bug?

2013-05-16 Thread linux fddl
Hi, When I used mass_storage as a gadget(use a linux-3.0.77 kernel), After the following operations: 1.Turn my board into hibernation. 2.Plug the usb into host before resume. 3.Resume my board. I saw some dump message like this, after some digging, I think the other devices' retore time is too l

Re: [PATCH 1/4] staging: dwc2: Set a default dma_mask for platform devices

2013-05-16 Thread Greg KH
On Fri, May 17, 2013 at 12:08:48AM +, Paul Zimmerman wrote: > > From: Matthijs Kooijman [mailto:matth...@stdin.nl] > > Sent: Wednesday, May 15, 2013 1:28 PM > > > > > No, seems like other folks think it's OK, so I'm fine with it. > > Great. > > > > > I'll ack the patches and send them on once

Re: [PATCH] USB: ftdi: add full listing for RT Systems ftdi devices

2013-05-16 Thread Greg KH
On Tue, Apr 30, 2013 at 07:10:46PM -0400, Rick Farina wrote: > From: "Rick Farina (Zero_Chaos)" > > RT Systems makes many usb serial cables based on the ftdi_sio driver for > programming various amateur radios. This patch is a full listing of > their current product offerings and should allow th

Re: [PATCH 3/4] usb: ohci: fix goto wrong tag in err case

2013-05-16 Thread Greg KH
On Thu, May 09, 2013 at 12:58:10PM +0800, Libo Chen wrote: > From: Libo Chen > > fix goto wrong tag in usb_hcd_nxp_probe > > Signed-off-by: Libo Chen > --- > drivers/usb/host/ohci-nxp.c | 12 ++-- > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/host/o

Re: [PATCH 4/4] usb: tilegx: fix memleak when create hcd fail

2013-05-16 Thread Greg KH
On Thu, May 09, 2013 at 12:58:11PM +0800, Libo Chen wrote: > From: Libo Chen > > When usb_create_hcd fail, we should call gxio_usb_host_destroy > > Signed-off-by: Libo Chen > --- > drivers/usb/host/ohci-tilegx.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) This patch doe

Re: [PATCH v2] usb: ohci: fix goto wrong tag in err case

2013-05-16 Thread Greg KH
On Fri, May 10, 2013 at 02:22:42PM +0800, Libo Chen wrote: > fix goto wrong tag in usb_hcd_nxp_probe > > Signed-off-by: Libo Chen Ah, you redid this, nevermind about the v1 of this patch, sorry... -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH 6/6] USB: IOCTL to toggle the quirk (not required).

2013-05-16 Thread Greg KH
On Tue, Apr 30, 2013 at 12:51:55AM -0500, Alexandre Peixoto Ferreira wrote: > These patches implement a modification of the USBTMC > protocol to allow operation with Rigol equipment. Ioctl change allowing test > and toggling of the status of the rigol_quirk bit. > > > Signed-off-by: Alexandre Pei

Re: [PATCH v3] usb: ehci: Only sleep for post-resume handover if devices use persist

2013-05-16 Thread Greg Kroah-Hartman
On Thu, Apr 25, 2013 at 09:08:27AM -0700, Julius Werner wrote: > The current EHCI code sleeps a flat 110ms in the resume path if there > was a USB 1.1 device connected to its companion controller during > suspend, waiting for the device to reappear and reset so that it can be > handed back to the c

Re: [PATCH v4] usb host: Faraday USB2.0 FUSBH200-HCD driver

2013-05-16 Thread Greg KH
On Fri, Apr 26, 2013 at 09:37:20AM +, Yuan-Hsin Chen wrote: > FUSBH200-HCD is an USB2.0 hcd for Faraday FUSBH200. > FUSBH200 is an ehci-like controller with some differences. > First, register layout of FUSBH200 is incompatible with EHCI. > Furthermore, FUSBH200 is lack of siTDs which means iTD

Re: [PATCH 0/7] staging: dwc2: miscellaneous cleanups

2013-05-16 Thread Greg KH
On Mon, May 13, 2013 at 07:08:05PM -0700, Paul Zimmerman wrote: > Hi Greg, > > Here are some dwc2 patches which Matthijs submitted just before the merge > window opened, looks like they did not get picked up. Please apply. I think I just got all of these, right? thanks, greg k-h -- To unsubscri

RE: [PATCH 1/4] staging: dwc2: Set a default dma_mask for platform devices

2013-05-16 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Wednesday, May 15, 2013 1:28 PM > > > No, seems like other folks think it's OK, so I'm fine with it. > Great. > > > I'll ack the patches and send them on once Greg starts taking staging > > patches again. > Forgive my ignorance here, bu

Re: [PATCH v4 3/8] ARM: tegra: update device trees for USB binding rework

2013-05-16 Thread Stephen Warren
On 05/16/2013 08:12 AM, Venu Byravarasu wrote: > This patch updates all Tegra board files so that they contain all the > properties required by the updated USB DT binding. Note that this patch > only adds the new properties and does not yet remove the old properties, > in order to maintain bisectab

Re: [PATCH v4 7/8] usb: phy: tegra: Add error handling & clean up.

2013-05-16 Thread Stephen Warren
On 05/16/2013 08:13 AM, Venu Byravarasu wrote: > Check return values from all GPIO APIs and handle errors accordingly. > > Remove the call to clk_disable_unprepare(); this function does not > prepare or enable the clock, so the error path should not disable or > unprepare it. > > Signed-off-by: V

[PATCH] lsusb: Fix bug in USB 2.0 extended caps descriptor.

2013-05-16 Thread Sarah Sharp
The upper bits of the USB 2.0 extended capability BOS descriptor weren't being shifted into the right byte position. That didn't matter much before now, but some USB 2.1 devices will soon have a modified BOS descriptor that has BESL values in those upper bits. Signed-off-by: Sarah Sharp --- lsu

RE: [PATCH 0/2] Add multiple transfer descriptors support to chipidea udc

2013-05-16 Thread Svetoslav Neykov
Hi Alex, On Thu, 16 May 2013 12:47:41 +0300 Alexander Shishkin wrote: > Michael Grzeschik writes: > > > These patches add support to handle requests which spawn into several TDs. > > Thanks! > > Svetoslav, if you have time, can you please test this with your mips > device? I am waiting for

Re: [PATCH] ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards

2013-05-16 Thread Tony Lindgren
* Kishon Vijay Abraham I [130514 23:27]: > On Saturday 11 May 2013 08:05 AM, Tony Lindgren wrote: > >Commit ad871c10 (ARM: dts: OMAP: Add usb_otg and glue data to > >OMAP3+ boards) added support for MUSB on omap3 for device tree, > >but added the interrupts the wrong way probably as they were > >c

Re: [OPW kernel] dma_set_coherent_mask

2013-05-16 Thread Sarah Sharp
On Thu, May 16, 2013 at 10:11:00AM -0400, Alan Stern wrote: > On Wed, 15 May 2013, Sarah Sharp wrote: > > > > If you're using 64-bit DMA then you almost certainly do want to call > > > dma_set_coherent_mask(). On the plus side, it is guaranteed that if > > > dma_set_mask() succeeds with a particu

Re: usb: musb: Fix LapDock enumeration on omap for boot and slow cable insertion

2013-05-16 Thread Tony Lindgren
* Felipe Balbi [130515 07:11]: > On Fri, May 03, 2013 at 11:01:33AM -0700, Tony Lindgren wrote: > > * Tony Lindgren [130503 10:55]: > > > Looks like we can get VBUS interrupt before the ID interrupt > > how can this happen ? VBUS interrupt happens when you connect to a port > which is sourcing V

Re: [PATCH 23/33] drivers/usb/host: don't check resource with devm_ioremap_resource

2013-05-16 Thread Alan Stern
On Thu, 16 May 2013, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang > --- > drivers/usb/host/ohci-nxp.c |6 -- > 1 file changed, 6 deletions(-) > > diff --git a/drivers/usb

[PATCH v4 0/8] Tegra USB PHY driver series

2013-05-16 Thread Venu Byravarasu
delta from v3: This patch series is prepared as follow up of TEGRA USB PHY driver patch series discussed at: https://lkml.org/lkml/2013/5/10/241 Venu Byravarasu (8): ARM: tegra: finalize USB EHCI and PHY bindings arm: dt: Tegra20: Modify ULPI reset GPIO properties ARM: tegra: update device t

[PATCH v4 2/8] arm: dt: Tegra20: Modify ULPI reset GPIO properties

2013-05-16 Thread Venu Byravarasu
1. All Tegra20 ULPI reset GPIO DT properties are modified to indicate active low nature of the GPIO. 2. Placed USB PHY DT node immediately below the EHCI controller DT nodes and corrected reg value in the name of USB PHY DT node. Signed-off-by: Venu Byravarasu --- delta from v3: No code changes.

[PATCH v4 4/8] usb: phy: tegra: Return correct error value provided by clk_get_sys

2013-05-16 Thread Venu Byravarasu
In case if clk_get_sys fails, return correct error value provided by the API. Signed-off-by: Venu Byravarasu --- delta from v1, v2 & v3: no change. drivers/usb/phy/phy-tegra-usb.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/driver

[PATCH v4 6/8] usb: phy: tegra: get ULPI reset GPIO info using DT.

2013-05-16 Thread Venu Byravarasu
As GPIO information is avail through DT, used it to get Tegra ULPI reset GPIO number. Added a new member to tegra_usb_phy structure to store this number. Signed-off-by: Venu Byravarasu --- delta from v1, v2 & v3: no change. drivers/usb/phy/phy-tegra-usb.c | 25 +++-- inc

[PATCH v4 8/8] usb: phy: registering Tegra USB PHY as platform driver

2013-05-16 Thread Venu Byravarasu
Registered Tegra USB PHY as a separate platform driver. To synchronize host controller and PHY initialization, used deferred probe mechanism. As PHY should be initialized before EHCI starts running, deferred probe of Tegra EHCI driver till PHY probe gets completed. Got rid of instance number base

[PATCH v4 7/8] usb: phy: tegra: Add error handling & clean up.

2013-05-16 Thread Venu Byravarasu
Check return values from all GPIO APIs and handle errors accordingly. Remove the call to clk_disable_unprepare(); this function does not prepare or enable the clock, so the error path should not disable or unprepare it. Signed-off-by: Venu Byravarasu --- delta from v3: Modified comment section t

[PATCH v4 5/8] usb: phy: tegra: Get PHY mode using DT

2013-05-16 Thread Venu Byravarasu
Added a new PHY mode to support OTG. Obtained Tegra USB PHY mode using DT property. Signed-off-by: Venu Byravarasu --- delta from v3 & v2: No change delta from v1: replaced gadget with peripheral. drivers/usb/host/ehci-tegra.c |1 - drivers/usb/phy/phy-tegra-usb.c | 13 ++

[PATCH v4 3/8] ARM: tegra: update device trees for USB binding rework

2013-05-16 Thread Venu Byravarasu
This patch updates all Tegra board files so that they contain all the properties required by the updated USB DT binding. Note that this patch only adds the new properties and does not yet remove the old properties, in order to maintain bisectability. The old properties will be removed once the driv

[PATCH v4 1/8] ARM: tegra: finalize USB EHCI and PHY bindings

2013-05-16 Thread Venu Byravarasu
The existing Tegra USB bindings have a few issues: 1) Many properties are documented as being part of the EHCI controller node, yet they apply more to the PHY device. They should be moved. 2) Some registers in PHY1 are shared with PHY3, and hence PHY3 needs a reg entry to point at PHY1's register

Re: [OPW kernel] dma_set_coherent_mask

2013-05-16 Thread Alan Stern
On Wed, 15 May 2013, Sarah Sharp wrote: > > If you're using 64-bit DMA then you almost certainly do want to call > > dma_set_coherent_mask(). On the plus side, it is guaranteed that if > > dma_set_mask() succeeds with a particular mask value then > > dma_set_coherent_mask() for the same mask valu

Re: Linux USB file storage gadget with new UDC

2013-05-16 Thread Alan Stern
On Thu, 16 May 2013, victor yeo wrote: > Another question from the bulk_out_complete() printout which is shown > below. The req->actual is 512 byte. The bh->bulk_out_intended_length > is 31. Is this a bug? > > g_file_storage gadget: get_next_command > [start_transfer] 6f007442 7000 > ept1 out que

Re: [PATCH 21/33] drivers/usb/chipidea: don't check resource with devm_ioremap_resource

2013-05-16 Thread Alexander Shishkin
Wolfram Sang writes: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang Acked-by: Alexander Shishkin > --- > drivers/usb/chipidea/core.c |5 - > 1 file changed, 5 deletions(-) > > diff --git a/d

[PATCH 21/33] drivers/usb/chipidea: don't check resource with devm_ioremap_resource

2013-05-16 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/chipidea/core.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 450107e.

[PATCH 18/33] drivers/staging/dwc2: don't check resource with devm_ioremap_resource

2013-05-16 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/staging/dwc2/platform.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/dwc2/platform.c b/drivers/staging/dwc2/platform.c in

[PATCH 23/33] drivers/usb/host: don't check resource with devm_ioremap_resource

2013-05-16 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/host/ohci-nxp.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c index f4988fb

[PATCH 24/33] drivers/usb/phy: don't check resource with devm_ioremap_resource

2013-05-16 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/phy/phy-mv-u3d-usb.c |5 - drivers/usb/phy/phy-mxs-usb.c |5 - drivers/usb/phy/phy-samsung-usb2.c |5 - drivers/usb/

[PATCH 22/33] drivers/usb/gadget: don't check resource with devm_ioremap_resource

2013-05-16 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/usb/gadget/bcm63xx_udc.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/gadget/bcm63xx_udc.c b/drivers/usb/gadget/bcm63xx

Re: [PATCH 02/39] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg()

2013-05-16 Thread Lee Jones
On Thu, 16 May 2013, Vinod Koul wrote: > On Thu, May 16, 2013 at 08:25:57AM +0100, Lee Jones wrote: > > On Thu, 16 May 2013, Vinod Koul wrote: > > > > > On Wed, May 15, 2013 at 10:51:25AM +0100, Lee Jones wrote: > > > > All configuration left in d40_phy_cfg() is runtime configurable and > > > > t

Re: [PATCH 2/2] usb: chipidea: udc: add multiple td support to hardware_{en,de}queue

2013-05-16 Thread Michael Grzeschik
On Thu, May 16, 2013 at 01:17:10PM +0300, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > From: Michael Grzeschik > > > > This patch removes the restriction of having a limited amount of only > > four active tds on one endpoint. We use the linked list implementation > > to manage all

Re: [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface

2013-05-16 Thread Bjørn Mork
Schmiedl Christian writes: > /drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface > by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and > WWAN Interface Number. Much better. But this patch need to go to the netdev list to get picked up by the

Re: [PATCH 34/39] dmaengine: ste_dma40: Convert data_width from register bit format to value

2013-05-16 Thread Vinod Koul
On Thu, May 16, 2013 at 08:35:53AM +0100, Lee Jones wrote: > On Thu, 16 May 2013, Vinod Koul wrote: > > > On Wed, May 15, 2013 at 10:51:57AM +0100, Lee Jones wrote: > > > +u8 d40_width_to_bits(enum dma_slave_buswidth width) > > > +{ > > > + if (width == DMA_SLAVE_BUSWIDTH_1_BYTE) > > > + r

Re: [PATCH 2/2] usb: chipidea: udc: add multiple td support to hardware_{en,de}queue

2013-05-16 Thread Alexander Shishkin
Michael Grzeschik writes: > From: Michael Grzeschik > > This patch removes the restriction of having a limited amount of only > four active tds on one endpoint. We use the linked list implementation > to manage all tds which get added and removed by hardware_{en,de}queue. > > The removal of this

Re: [PATCH 02/39] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg()

2013-05-16 Thread Vinod Koul
On Thu, May 16, 2013 at 08:25:57AM +0100, Lee Jones wrote: > On Thu, 16 May 2013, Vinod Koul wrote: > > > On Wed, May 15, 2013 at 10:51:25AM +0100, Lee Jones wrote: > > > All configuration left in d40_phy_cfg() is runtime configurable and > > > there is already a call into it from d40_runtime_conf

[PATCH v2 6/6] usb: phy: samsung: Add support for USB 2.0 PHY on Exynos 4x12

2013-05-16 Thread Tomasz Figa
This patch adds driver data for Exynos 4x12 USB 2.0 PHY. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/usb/phy/phy-samsung-usb.h | 1 + drivers/usb/phy/phy-samsung-usb2.c | 18 ++ 2 files changed, 19 insertions(+) diff --git a/drivers/usb/phy/phy-samsung

[PATCH v2 5/6] usb: phy: samsung: Pass enable/disable callbacks through driver data

2013-05-16 Thread Tomasz Figa
To remove unnecessary if statements, this patch introduces phy_enable and phy_disable callbacks in driver data structure that implement SoC-specific PHY initialization and deinitialization. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/usb/phy/phy-samsung-usb.h | 2 ++ d

[PATCH v2 3/6] usb: phy: samsung: Consolidate reference clock rate handling

2013-05-16 Thread Tomasz Figa
This patch cleans up handling of reference clock rate in Samsung USB PHY drivers. It is mostly a cosmetic change but improves error handling in case of failing to get reference clock or invalid clock rate. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/usb/phy/phy-samsung-u

[PATCH v2 4/6] usb: phy: samsung: Pass set_isolation callback through driver data

2013-05-16 Thread Tomasz Figa
This patch extends driver data structure with set_isolation callback, which allows to remove the need for checking for SoC type in a switch statement. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/usb/phy/phy-samsung-usb.c | 36 driver

[PATCH v2 2/6] usb: phy: samsung: Use clk_get to get reference clock

2013-05-16 Thread Tomasz Figa
There is no need to use devm_clk_get to get a clock that is being put at the end of the function. This patch changes the code getting reference clock to use clk_get instead of useless in this case devm_clk_get. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/usb/phy/phy-sam

[PATCH v2 1/6] usb: phy: samsung: Select common driver part implicitly

2013-05-16 Thread Tomasz Figa
Since phy-samsung-usb library can be used only by phy-samsung-usb2 and phy-samsung-usb3 drivers, there is no need to give explicit control over its Kconfig symbol. This patch makes CONFIG_SAMSUNG_USBPHY symbol hidden and selected implicitly by CONFIG_SAMSUNG_USB2PHY and CONFIG_SAMSUNG_USB3PHY. Si

[PATCH v2 0/6] Samsung USB PHY SoC support cleanup

2013-05-16 Thread Tomasz Figa
This patch series intends to improve handling of SoC-specific differences in Samsung USB PHY drivers, by reducing the need to explicitly check SoC type using if and switch statements. In addition, last patch adds support for Exynos 4x12, as this is simply a matter of adding appropriate driver data

Re: [PATCH 0/2] Add multiple transfer descriptors support to chipidea udc

2013-05-16 Thread Alexander Shishkin
Michael Grzeschik writes: > These patches add support to handle requests which spawn into several TDs. Thanks! Svetoslav, if you have time, can you please test this with your mips device? Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [PATCH 13/15] chipidea: Allow user to select PCI/IMX options

2013-05-16 Thread Alexander Shishkin
Jiri Slaby writes: > On 05/08/2013 11:07 AM, Alexander Shishkin wrote: >> Jiri Slaby writes: >> >>> From: Jeff Mahoney >>> >>> The chipidea driver currently has needless ifneq rules in the makefile >>> for things that should be config options. >> >> Please elaborate on the "should be" part. >

Re: Linux USB file storage gadget with new UDC

2013-05-16 Thread victor yeo
Hi, >> Just curious. The crash log shows the following UDC driver code which >> is responsible to receive endpoint 0 setup data. However, the host PC >> is sending SCSI_WRITE_10 command at the time of the crash. These two >> does not correlate, right? >> >> unsigned int rdata, rdata1

Re: [PATCH v2] usb: chipidea: udc: configure iso endpoints

2013-05-16 Thread Peter Chen
On Thu, May 16, 2013 at 09:53:57AM +0200, Michael Grzeschik wrote: > This patch adds iso endpoint support to the device controller. > It makes use of the multiplication bits in the maxpacket field > of the endpoint and calculates the multiplier bits for each > transfer description on every request.

[PATCH 2/9] usb/gadget: nokia: convert to new interface of f_obex

2013-05-16 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/nokia.c | 122 ++-- 2 files changed, 85 insertions(+), 38 deletions(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gad

[PATCH v2] usb: chipidea: udc: configure iso endpoints

2013-05-16 Thread Michael Grzeschik
This patch adds iso endpoint support to the device controller. It makes use of the multiplication bits in the maxpacket field of the endpoint and calculates the multiplier bits for each transfer description on every request. Signed-off-by: Michael Grzeschik --- Changes since v1: - fixed style is

Re: [PATCH 34/39] dmaengine: ste_dma40: Convert data_width from register bit format to value

2013-05-16 Thread Lee Jones
On Thu, 16 May 2013, Vinod Koul wrote: > On Wed, May 15, 2013 at 10:51:57AM +0100, Lee Jones wrote: > > When a DMA client requests and configures a DMA channel, it requests > > data_width in Bytes. The DMA40 driver then swiftly converts it over to > > the necessary register bit value. Unfortunatel

Re: [PATCH 01/39] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-05-16 Thread Lee Jones
On Thu, 16 May 2013, Vinod Koul wrote: > On Wed, May 15, 2013 at 06:29:51PM +0200, Linus Walleij wrote: > > On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > > > > > During the initial setup of a logical channel, it is necessary to unmask > > > the GIM in order to receive generated terminal c

Re: [PATCH 02/39] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg()

2013-05-16 Thread Lee Jones
On Thu, 16 May 2013, Vinod Koul wrote: > On Wed, May 15, 2013 at 10:51:25AM +0100, Lee Jones wrote: > > All configuration left in d40_phy_cfg() is runtime configurable and > > there is already a call into it from d40_runtime_config(), so let's > > rely on that. > > > > Acked-by: Vinod Koul > Tha

Re: [PATCH 31/39] dmaengine: ste_dma40: Replace ST-E's home-brew DMA direction defs with generic ones

2013-05-16 Thread Vinod Koul
On Thu, May 16, 2013 at 08:06:38AM +0100, Lee Jones wrote: > On Thu, 16 May 2013, Vinod Koul wrote: > > > On Wed, May 15, 2013 at 10:51:54AM +0100, Lee Jones wrote: > > > STEDMA40_*_TO_* direction definitions are identical in all but name to > > > the pre-defined generic DMA_*_TO_* ones. Let's mak

Re: [PATCH 07/39] dmaengine: ste_dma40: Only use addresses passed as configuration information

2013-05-16 Thread Vinod Koul
On Wed, May 15, 2013 at 10:51:30AM +0100, Lee Jones wrote: > Addresses are passed in from the client's driver via the invocation of > dmaengine_slave_config(), so there's no need to fetch them from platform > data too, hardwired or otherwise. This is a great step forward, as it > elevates a large b

Re: [PATCH 10/39] dmaengine: ste_dma40: Correct copy/paste error

2013-05-16 Thread Vinod Koul
On Wed, May 15, 2013 at 10:51:33AM +0100, Lee Jones wrote: > 'struct stedma40_half_channel_info's header comment says that it's > called 'struct stedma40_chan_cfg'. Let's straighten that out. > > Signed-off-by: Lee Jones > --- Acked-by: Vinod Koul -- ~Vinod > include/linux/platform_data/dma-st

Re: [PATCH 08/39] dmaengine: ste_dma40: Remove redundant address fetching function

2013-05-16 Thread Vinod Koul
On Wed, May 15, 2013 at 10:51:31AM +0100, Lee Jones wrote: > Addresses are now stored in local data structures and are easy to > obtain, thus a specialist function used to fetch them is now surplus > to requirement. > > Signed-off-by: Lee Jones > --- Acked-by: Vinod Koul -- ~Vinod > drivers/dm

Re: [PATCH 03/39] dmaengine: ste_dma40: Don't configure runtime configurable setup during allocate

2013-05-16 Thread Vinod Koul
On Wed, May 15, 2013 at 10:51:26AM +0100, Lee Jones wrote: > Using the dmaengine API, allocating and configuring a channel are two > separate actions. Here we're removing logical channel configuration from > the channel allocating routines. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin

Re: [PATCH 02/39] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg()

2013-05-16 Thread Vinod Koul
On Wed, May 15, 2013 at 10:51:25AM +0100, Lee Jones wrote: > All configuration left in d40_phy_cfg() is runtime configurable and > there is already a call into it from d40_runtime_config(), so let's > rely on that. > > Acked-by: Vinod Koul That needs up update! > Acked-by: Arnd Bergmann > Signe

Re: [PATCH 01/39] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-05-16 Thread Vinod Koul
On Wed, May 15, 2013 at 06:29:51PM +0200, Linus Walleij wrote: > On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > > > During the initial setup of a logical channel, it is necessary to unmask > > the GIM in order to receive generated terminal count and error interrupts. > > We're separating ou

Re: [PATCH 38/39] dmaengine: ste_dma40: Fetch the number of physical channels from DT

2013-05-16 Thread Vinod Koul
On Wed, May 15, 2013 at 10:52:01AM +0100, Lee Jones wrote: > Some platforms insist on obscure physical channel availability. This > information is currently passed though platform data in internal BSP > kernels. Once those platforms land, they'll need to configure them > appropriately, so we may as

Re: [PATCH 34/39] dmaengine: ste_dma40: Convert data_width from register bit format to value

2013-05-16 Thread Vinod Koul
On Wed, May 15, 2013 at 10:51:57AM +0100, Lee Jones wrote: > When a DMA client requests and configures a DMA channel, it requests > data_width in Bytes. The DMA40 driver then swiftly converts it over to > the necessary register bit value. Unfortunately, for any subsequent > calculations we have to

Re: [PATCH 31/39] dmaengine: ste_dma40: Replace ST-E's home-brew DMA direction defs with generic ones

2013-05-16 Thread Lee Jones
On Thu, 16 May 2013, Vinod Koul wrote: > On Wed, May 15, 2013 at 10:51:54AM +0100, Lee Jones wrote: > > STEDMA40_*_TO_* direction definitions are identical in all but name to > > the pre-defined generic DMA_*_TO_* ones. Let's make things easy by not > > duplicating such things. > > > > Cc: Vinod

Re: [PATCH 18/39] crypto: ux500/[cryp|hash] - Show successful start-up in the bootlog

2013-05-16 Thread Herbert Xu
On Wed, May 15, 2013 at 10:51:41AM +0100, Lee Jones wrote: > The Cryp driver is currently silent and the Hash driver prints the > name of its probe function unnecessarily. Let's just put a nice > descriptive one-liner there instead. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin

Re: [PATCH 16/39] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-05-16 Thread Herbert Xu
On Wed, May 15, 2013 at 10:51:39AM +0100, Lee Jones wrote: > The DMA controller currently takes configuration information from > information passed though dma_channel_request(), but it shouldn't. > Using the API, the DMA channel should only be configured during > a dma_slave_config() call. > > Cc:

Re: [PATCH 15/39] crypto: ux500/cryp - Prepare clock before enabling it

2013-05-16 Thread Herbert Xu
On Wed, May 15, 2013 at 10:51:38AM +0100, Lee Jones wrote: > If we fail to prepare the ux500-cryp clock before enabling it the > platform will fail to boot. Here we insure this happens. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin > Cc: linux-cry...@vger.kernel.org > Acked-by:

Re: [PATCH 13/39] crypto: ux500/hash - Set DMA configuration though dma_slave_config()

2013-05-16 Thread Herbert Xu
On Wed, May 15, 2013 at 10:51:36AM +0100, Lee Jones wrote: > The DMA controller currently takes configuration information from > information passed though dma_channel_request(), but it shouldn't. > Using the API, the DMA channel should only be configured during > a dma_slave_config() call. > > Cc:

Re: [PATCH 12/39] crypto: ux500/hash - Prepare clock before enabling it

2013-05-16 Thread Herbert Xu
On Thu, May 16, 2013 at 07:53:55AM +0100, Lee Jones wrote: > On Wed, 15 May 2013, Linus Walleij wrote: > > > On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > > > > > If we fail to prepare the ux500-hash clock before enabling it the > > > platform will fail to boot. Here we insure this happen