why we need a msleep(5) in ehci_bus_suspend/resume

2013-05-12 Thread linux fddl
Hi, From the ehci-hub.c, I find that ehci_bus_suspend/resume have some code like this: if (time_before(jiffies, ehci->netx_statechange)) msleep(5); ... ehci->next_statechange = jiffies + msec_to_jiffies(10); and if (time_before(jiffies, ehci->netx_statechange)) msleep(5); ... ehci->ne

[PATCh V10 12/12] usb: mv_usb: remove the phy callbacks in pdata

2013-05-12 Thread Chao Xie
The phy initialization code will be done by phy driver. Signed-off-by: Chao Xie --- include/linux/platform_data/mv_usb.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/linux/platform_data/mv_usb.h b/include/linux/platform_data/mv_usb.h index 98b7925..b4b5d6f

[PATCh V10 10/12] arm: mmp: remove unused usb devices

2013-05-12 Thread Chao Xie
We defined new usb devices for usb ehci/udc/otg/phy. So remove the old definitions. Signed-off-by: Chao Xie --- arch/arm/mach-mmp/include/mach/pxa910.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach/pxa910.h b/arch/arm/mach-mmp/include/

[PATCh V10 09/12] arm: ttc_dkb: modify usb support

2013-05-12 Thread Chao Xie
for ttc_dkb board, we use phy driver for usb support. Modify the usb support for udc/otg/ehci support. Signed-off-by: Chao Xie --- arch/arm/mach-mmp/ttc_dkb.c | 39 ++- 1 files changed, 30 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb

[PATCh V10 07/12] arm: mmp2: change the defintion of usb devices

2013-05-12 Thread Chao Xie
add the udc/otg/ehci devices for mmp2 Signed-off-by: Chao Xie --- arch/arm/mach-mmp/include/mach/mmp2.h |4 arch/arm/mach-mmp/mmp2.c |4 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach/mmp2.h b/arch/arm/mach-mmp/includ

[PATCh V10 06/12] usb: mv_u3d: usb phy drivers for phy operation

2013-05-12 Thread Chao Xie
The phy_init and phy_deinit APIs are removed from the pdata. Directly get the phy driver and invoke the callbacks of phy drivers for phy initialization and shutdown. Signed-off-by: Chao Xie --- drivers/usb/gadget/mv_u3d.h |3 +- drivers/usb/gadget/mv_u3d_core.c | 54 ++

[PATCh V10 05/12] usb: phy: phy-mv-usb: use USB2 PHY driver for otg

2013-05-12 Thread Chao Xie
Originaly, otg driver will call the callbacks in platform data for PHY initialization and shut down. With PHY driver, it will call the APIs provided by PHY driver for PHY initialization and shutdown. It removes the callbacks in platform data, and at same time it removes one block in the way of enab

[V9 PATCH 00/12] mv-usb phy driver

2013-05-12 Thread Chao Xie
The patches create the mv-usb phy driver The patches remove the callbacks in the platform data for phy initialization and shutdown, and directly write a phy driver and make udc/ehci/otg to call it. usb: phy: protect phy init and shutdown for mutiple deivces usb: phy: mv_usb2: add PHY driver f

[PATCh V10 02/12] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-05-12 Thread Chao Xie
The PHY is seperated from usb controller. The usb controller used in marvell pxa168/pxa910/mmp2 are same, but PHY initialization may be different. the usb controller can support udc/otg/ehci, and for each of the mode, it need PHY to initialized before use the controller. Direclty writing the phy dr

[PATCh V10 11/12] arm: brownstone: add usb support for the board

2013-05-12 Thread Chao Xie
for brownstone board, add the udc/otg/ehci support Signed-off-by: Chao Xie --- arch/arm/mach-mmp/brownstone.c | 56 1 files changed, 56 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp/brownstone.c index 235

[PATCh V10 08/12] arm: pxa910: change the defintion of usb devices

2013-05-12 Thread Chao Xie
because phy is seperated from the usb controller driver, we can use the common pxa_device_desc for device register. Signed-off-by: Chao Xie --- arch/arm/mach-mmp/include/mach/pxa910.h |4 arch/arm/mach-mmp/pxa910.c |4 2 files changed, 8 insertions(+), 0 deletions(

[PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-05-12 Thread Chao Xie
Originaly, ehci driver will call the callbacks in platform data for PHY initialization and shut down. With PHY driver, it will call the APIs provided by PHY driver for PHY initialization and shutdown. It removes the callbacks in platform data, and at same time it removes one block in the way of ena

[PATCh V10 03/12] usb: gadget: mv_udc: use PHY driver for udc

2013-05-12 Thread Chao Xie
Originaly, udc driver will call the callbacks in platform data for PHY initialization and shut down. With PHY driver, it will call the APIs provided by PHY driver for PHY initialization and shut down. It removes the callbacks in platform data, and at same time it removes one block in the way of ena

[V9 PATCH 00/12] mv-usb phy driver

2013-05-12 Thread Chao Xie
The patches create the mv-usb phy driver The patches remove the callbacks in the platform data for phy initialization and shutdown, and directly write a phy driver and make udc/ehci/otg to call it. usb: phy: protect phy init and shutdown for mutiple deivces usb: phy: mv_usb2: add PHY driver f

[PATCh V10 01/12] usb: phy: protect phy init and shutdown for mutiple deivces

2013-05-12 Thread Chao Xie
Some USB devices will share same phy, so make the ->init and ->shutdown to be protected. Only first device will initialize the phy, and only last device can shutdown phy. Signed-off-by: Chao Xie --- drivers/usb/phy/phy.c |6 ++ include/linux/usb/phy.h | 22 ++ 2 f

[PATCH 1/1] USB: quatech2: Staticize local symbol

2013-05-12 Thread Sachin Kamat
'qt2_process_read_urb' is referenced only in this file. Make it static. Signed-off-by: Sachin Kamat --- drivers/usb/serial/quatech2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c index 02b0803..b0a9478 100644

Re: musb throughput issues

2013-05-12 Thread Frederik Schmid
Ming, The ehci controller is bogged down because the frames from the camera and other stuff are being relayed over ethernet. /Frederik On Friday 10 May 2013 23.24.32 Ming Lei wrote: > > Why do you think it's bogged down with ethernet? The ethernet throughput > can go beyond 90Mbps on Pandaboa

Re: [PATCH 10/11] USB: ohci-spear: remove unnecessary platform_set_drvdata()

2013-05-12 Thread Viresh Kumar
On 6 May 2013 15:44, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound). > Thus, it is not needed to manually clear the d

Re: EHCI controller CS5536 hard disk disconnects

2013-05-12 Thread Miguel Dardenne
On 04/11/2012 19:34, Sergey Vlasov wrote: On Sat, Nov 03, 2012 at 09:14:08PM +0100, Miguel Dardenne wrote: On 2012-11-03 17:50, Alan Stern wrote: I get a USB disconnect of my external USB HDD about once per day. Enabling USB debug in the kernel shows the first error as 'ehci_hcd detected XactEr

[PATCH 2/2] usb: storage: alauda: initialize variables directly

2013-05-12 Thread Emilio López
Clean up the code a bit to initialize the variables directly when defining them. Signed-off-by: Emilio López --- Please note that this patch is untested. drivers/usb/storage/alauda.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/drivers

[PATCH 1/2] usb: storage: sddr09: initialize variables directly

2013-05-12 Thread Emilio López
Clean up the code a bit to initialize the variables directly when defining them. Signed-off-by: Emilio López --- Please note that this patch is untested. drivers/usb/storage/sddr09.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/storage/sddr09.c b/drivers