Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-27 Thread ZhenHua
On 04/27/2013 11:14 PM, Alan Stern wrote: On Sat, 27 Apr 2013, ZhenHua wrote: On 04/27/2013 12:51 AM, Alan Stern wrote: On Fri, 26 Apr 2013, ZhenHua wrote: There is a function wait_for_HP() in uhci-hub.c. In this patch, it is used in suspend_rh(), I think this can be a solution. And I have

Re: [PATCH] usb: chipidea: ci13xxx_imx: Use dev_dbg for pinctrl message

2013-04-27 Thread Shawn Guo
On Fri, Apr 26, 2013 at 03:36:42PM +0300, Alexander Shishkin wrote: > In author's words, some controllers don't need it, so it's ok if it > fails. Printing warning in that case is not a good idea, so I agree with > Fabio. I'll apply it soon unless I hear from people involved with > chipidea on imx.

RE: [PATCH] usb: chipidea: ci13xxx_imx: Use dev_dbg for pinctrl message

2013-04-27 Thread Chen Peter-B29397
Hi Fabio, I remebered devm_pinctrl_get_select_default will be returned successfully. Otherwise, how the patch included this code was tested? Best regards, Peter Chen From: Fabio Estevam [feste...@gmail.com] Sent: Sunday, April 28, 2013 3:28 AM To: Chen Pe

Re: [RFT] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-04-27 Thread Tony Camuso
On 04/17/2013 08:27 PM, Sarah Sharp wrote: -- snip -- [Sarah reworked this patch to cover the case where the xHCI restore register operation fails, and (temp & STS_SRE) is true (and we re-init the host, including re-init for the compliance mode), but hibernate is false. The original patch would

Re: [PATCH] usb: chipidea: ci13xxx_imx: Use dev_dbg for pinctrl message

2013-04-27 Thread Fabio Estevam
On Fri, Apr 26, 2013 at 10:22 PM, Peter Chen wrote: > This pin is ID pin for OTG controller, some platforms use dedicated ID pin > which doesn't need to config pinctrl.(mx53, etc), some platforms can > choose ID pin from IOMUXC using pinctrl interface. Actually it is not only OTG ID pin, it can

Re: [PATCH] usb: chipidea: ci13xxx_imx: Use dev_dbg for pinctrl message

2013-04-27 Thread Fabio Estevam
On Fri, Apr 26, 2013 at 9:50 AM, Uwe Kleine-König wrote: > I suggest to improve the commit log to include your explanation. I Done in v2. > wonder that it fails on imx because I thought pinctrl is up and running > there? It fails because there is no pinctrl node passed in the device tree. -- T

[PATCH v2] usb: chipidea: ci13xxx_imx: Use dev_dbg for pinctrl message

2013-04-27 Thread Fabio Estevam
From: Fabio Estevam Since commit b4dbb258b67 (USB: chipidea: imx: add pinctrl support) the following message is seen during boot: imx_usb 8008.usb: pinctrl get/select failed, err=-19 , which does not provide a very useful, nor informative log. Currently there are no i.MX devicetr

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-27 Thread Alan Stern
On Sat, 27 Apr 2013, ZhenHua wrote: > On 04/27/2013 12:51 AM, Alan Stern wrote: > > On Fri, 26 Apr 2013, ZhenHua wrote: > > > >> There is a function wait_for_HP() in uhci-hub.c. In this > >> patch, it is used in suspend_rh(), I think this can be a > >> solution. And I have tested this patch, it

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-27 Thread Clemens Ladisch
Alan Stern wrote: > It is now unnecessary to set urb->start_frame; in fact that field is > now output-only. > > (To be fair, I haven't checked _all_ the HCDs in this regard, just > uhci-hcd, ohci-hcd, and ehci-hcd. However, if any other HCD requires > urb->start_frame to be set then that HCD shoul

Re: TTY Closing Problem

2013-04-27 Thread Johan Hovold
On Thu, Apr 25, 2013 at 02:36:05PM -0400, Dan Therrien wrote: > Hi Johan, > > I was wondering with all the patches you submitted to help me narrow > down my problem. > > I believe it is a TTY problem but I don't know how to proceed further. > > Here is my problem it starts after the 3.7 kernel u