On Sat, Apr 06, 2013 at 12:39:34PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
>
> Signed-off-by: Wei Yongjun
patch looks alright, but you need to blame which commit a
Hi,
On Fri, Apr 05, 2013 at 03:19:22PM -0700, Greg KH wrote:
> On Sat, Apr 06, 2013 at 12:41:02AM +0300, Felipe Balbi wrote:
> > Hi,
> >
> > On Sat, Apr 06, 2013 at 12:21:52AM +0300, Felipe Balbi wrote:
> > > Hi Greg,
> > >
> > > Here's a giant pull request for v3.10. All patches have been on
>
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/cdc2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/cdc2.c b/d
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/f_obex.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/f_obex.c b/drivers/usb/gadg
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/usb/gadget/multi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/multi.c b
Aargh, resending as plain text.
Hi Matthijs,
Thanks for the work, this looks like a valuable set of patches.
But you really need to split this into a more manageable series of
patches. It's really difficult to review when you have so many different
things all munged together like this. It's also
Hello.
On 04/05/2013 08:40 PM, Sergei Shtylyov wrote:
Here's the set of 4 patches against the Simon Horman's
'renesas.git' repo,
'renesas-next-20130404v2' tag and the 2 Ether patches I've reposted
yesterday.
It was created to fix the shortcomings in the R8A7779/Marzen USB
platform code
On Sat, Apr 06, 2013 at 12:41:02AM +0300, Felipe Balbi wrote:
> Hi,
>
> On Sat, Apr 06, 2013 at 12:21:52AM +0300, Felipe Balbi wrote:
> > Hi Greg,
> >
> > Here's a giant pull request for v3.10. All patches have been on linux-next
> > for
> > quite a while and have gone through build and boot tes
From: Stephen Warren
The top-level hcd interrupt handlers already used irq_return_t, but the
functions to which it delegates the actual work and the common irq
handler returned plain ints. In addition, they used the IRQ_RETVAL in
the wrong way (but because of the values of the various constants,
Before, the hwcfg registers were read at device init time, but
interpreted at various parts in the code. This commit unpacks the hwcfg
register values into a struct with properly labeled variables at init
time, which makes all the other code using these values more consise and
easier to read. Some
Before, enabling common interrupts would implicitly disable all other
interrupts and enabling host interrupts would disable all interrupts and
then enable both common and host interrupts.
Now, these two are properly separated: each enable function only enables
its own interrupts and leaves all oth
Before, there were two places that manually read the FRNUM registers,
while there is a function to do this.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/core.c | 8 +---
drivers/staging/dwc2/hcd_intr.c | 5 +
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/hcd_intr.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dwc2/hcd_intr.c b/drivers/staging/dwc2/hcd_intr.c
index 12b5a89..281c2f4 100644
--- a/drivers/staging/dwc2/hcd_intr.c
+++ b/drivers/stag
This simply defines a list of interrupts handled by the the host
interrupt handler.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/core.c | 4 +---
drivers/staging/dwc2/core.h | 4
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dwc2/core.c b/driver
Before, the DISCONNINT interrupt was enabled in
dwc2_enable_host_interrupts, but handled in dwc2_handle_common_intr,
while the RXFLVL interrupt was enabled in dwc2_enable_commont_interrupts
and handled in dwc_handle_hcd_intr.
This moves the enabling of these interrupts around to match the spot
whe
This piece of code manually disabled interrupts, while there are
perfectly good functions to do this.
Technically, the old code really disabled _all_ interrupts, while the
new code only disables a specific list of interrupts, but that list of
interrupts includes all interrupts that are ever enable
It seems this flag is intended to pass to irq_set_status_flags, not
request_irq, and is not available on all architectures. Its value
corresponds to IRQF_PROBE_SHARED, which shouldn't be needed for this
driver, so removing this flag should be safe.
Signed-off-by: Matthijs Kooijman
---
drivers/st
Convert use of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so the explicit
error code can be removed from the failure code path.
Signed-off-by: Matthijs Kooijman
For calculating FIFO offsets, the sizes of preceding fifos need to be
known. For filling the GDFIFOCFG register, these fifo sizes were read
from hardware registers. However, these values were written to these
registers just a few lines before, so we can just use the values written
instead.
Signed-
For host mode, this interrupt is already handled by the hcd interrupt
handler. The common interrupt handler additionally did a noop handling
(it only cleared the flag and nothing else) when in device mode.
Since the driver currently supports only host mode, this shouldn't
result in any behaviour c
The HWCFG4 register stores the supported utmi width values (8, 16 or
both). This commit reads that value and validates the configured value
against that.
If no (valid) value is given, the parameter defaulted to 8 bits
previously. However, the documentation for dwc2_core_params_struct
suggests tha
---
arch/mips/ralink/dts/rt3050.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This patch is just FYI.
diff --git a/arch/mips/ralink/dts/rt3050.dtsi b/arch/mips/ralink/dts/rt3050.dtsi
index 5aede8d..2b7ab42 100644
--- a/arch/mips/ralink/dts/rt3050.dtsi
+++ b/arch/mips/ralink/dts/rt30
This interrupt is currently not enabled anywhere, but there is some
(dummy) handling for it in the host interrupt handler. This marks it as
a host mode interrupt, so it makes sense to disable it when disabling
the other host mode interrupts.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/d
Hi folks,
over the past two weeks, I've worked on the dwc2 driver to make it work
on the RT3052 platform. Basic mass-storage works, there are still some
unsolved problems with 3G modems I haven't looked at closely yet.
During that time, I've done some cleanups and small fixes whenever I
noticed s
This code appears to be partially incorrect. Since this is only debug
code and only applies to device mode, it seems better to remove this
code for now than to invest time fixing it.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/core.c | 19 ---
1 file changed, 19 del
This adds a dwc_platform.ko module that can be loaded by using
compatible = "snps,dwc2" in a device tree.
Signed-off-by: Matthijs Kooijman
---
Documentation/devicetree/bindings/staging/dwc2.txt | 15 +++
drivers/staging/dwc2/Kconfig | 6 +-
drivers/staging/dwc2/Makefile
For some reason, the value of the HPTXFSIZ register was built in the
ptxfsiz variable, while there was also a hptxfsiz variable availble.
Better just use that.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/core.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
dif
Before, this was initialized in pci.c, after the dwc2_hcd_init was
called and the interrupts were enabled. This opened up a small time
window where common interrupts could be triggered, but there was no
handler for them, causing them to keep triggering infinitely and locking
up the machine.
On my
---
arch/mips/ralink/rt305x-usb.c | 5 +
1 file changed, 5 insertions(+)
This patch is just FYI.
diff --git a/arch/mips/ralink/rt305x-usb.c b/arch/mips/ralink/rt305x-usb.c
index 793fc82..7d87740 100644
--- a/arch/mips/ralink/rt305x-usb.c
+++ b/arch/mips/ralink/rt305x-usb.c
@@ -108,6 +108,7 @
This line extracted the available queue space without properly shifting
it. Since the code only cared wether it was zero or not, it worked as
expected without the shift, but adding shift makes the code cleaner.
While we're here, store the result in a helper variable that was already
declared to in
This commit changes expressions from (val >> shift) & (mask >> shift) to
(val & mask) >> shift.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/core.c | 20 ++---
drivers/staging/dwc2/hcd.c | 62 +++--
drivers/staging/dwc2/hcd_ddma.c
---
arch/arm/Kconfig | 1 +
arch/arm/boot/dts/bcm2835.dtsi | 6 ++
arch/arm/configs/bcm2835_defconfig | 20 ++--
3 files changed, 21 insertions(+), 6 deletions(-)
This patch is just FYI.
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 13b7394..7
The value in params->enable_dynamic_fifo can only be true if the
corresponding bit in hwcfg2 is set, this is already checked by
dwc2_set_param_enable_dynamic_fifo.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
This flag is a deprecated NOOP, interrupt handlers are always run
with interupts disabled.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
See include/linux/interrupt.h and 6932bf37 (genirq: Remove IRQF_DISABLED
from core cod
If the platform driver failed to setup a dma_mask, but the hardware
advertises support for DMA, before DMA would be enabled in dwc2, but
disabled in the usb core, making all connectivity break.
With this commit, the dwc2 driver will emit a warning and fall back to
slave mode in this case.
Signed-
Previously, it was "dwc_otg", but this does not correspond to the
directory name and might cause confusion with the old out-of-tree
dwc_otg driver of which many versions circulate.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/hcd.c | 2 +-
drivers/staging/dwc2/pci.c | 2 +-
2 files
This function disables all "common interrupts", i.e., those that are
handled by the common interrupt handler.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/core.c | 14 ++
drivers/staging/dwc2/core.h | 6 ++
drivers/staging/dwc2/core_intr.c | 5 -
3 fi
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/core.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
index 9162bed..9a34ac7 100644
--- a/drivers/staging/dwc2/core.c
+++ b/drivers/staging/dwc2/co
Before, the value of the hcchar register was shifted and masked and then
the debug output extracted the individual values out of the complete
hcchar register again. This commit makes the debug prints directly use
the original values instead.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/d
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/pci.c | 7 ---
1 file changed, 7 deletions(-)
This is just the minimal list of includes that made the compile work.
diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c
index acf2008..a1d2ede 100644
--- a/drivers/stagi
Before, it was a function that would set all members of a given struct
containing only int members to -1. Now, it is renamed to
dwc_set_all_params and it works only on the dwc2_core_params struct.
This makes sure that all of the slightly dubious casting and assumptions
happen inside the function in
Various register fields wider than one bit have constants defined for
their value. Previously, these registers would define the values as they
appear in the register, so shifted to the right to the position the
value appears in the register.
This commit changes those constants to their natural val
From: Stephen Warren
Signed-off-by: Stephen Warren
[matth...@stdin.nl: Split patch from bigger patch and added commit message]
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/core.c | 2 +-
drivers/staging/dwc2/hcd.c | 2 +-
drivers/staging/dwc2/hcd.h | 4 ++--
3 files changed, 4 i
This (read-only) register was read twice, storing it for later use the
second time. Now it is only read once, storing it right away.
Signed-off-by: Matthijs Kooijman
---
drivers/staging/dwc2/hcd.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dwc
Instead of just setting the dma_mask to the empty mask, the pointer to
the mask is cleared altogether. This is needed because
usb_create_shared_hcd sets hcd->self.uses_dma based on
dev->dma_mask != NULL, not by looking at the actual mask itself.
This change thus makes hcd->self.uses_dma have the c
A generic set of FIFOSIZE_* constants was used for both the GNPTXFSIZ
and HPTXFSIZ registers, even where a specific set of constants was a
available for the GNPTXFSIZ register. This change adds specific
constants for the HPTXFSIZ register as well, changes the code to use
those specific constants an
Previously, the max_packet_count could be set to 1 << x, where x is the
number of bits available (width + 4 in the code). Since 1 << x requires
x + 1 bits to represent, this will not work. The real maximum value is
(1 << x) - 1. This value is already used the default when the set value
is invalid,
Some of the defaults were missing or unclear. In particular, I suspect
the defaults were documented assuming there were still module parameters
and taking the default module parameters into account. Now, the defaults
are the values that will get chosen when the params passed to
dwc2_hcd_init are al
Bits 16-31 are reserved, so the old code just reads the whole register to
get bits 0-15, assuming the reserved bits would be 0 (which seems true
on current hardware, but who knows...).
This commit properly masks out the reserved bits when reading and
doesn't touch the reserved bits while writing.
Each of the parameters in the dwc2_core_params struct can now be changed
using devicetree parameters.
Signed-off-by: Matthijs Kooijman
---
Documentation/devicetree/bindings/staging/dwc2.txt | 36
drivers/staging/dwc2/platform.c| 68 ++
2 files
Hi,
On Sat, Apr 06, 2013 at 12:21:52AM +0300, Felipe Balbi wrote:
> Hi Greg,
>
> Here's a giant pull request for v3.10. All patches have been on linux-next for
> quite a while and have gone through build and boot testing.
>
> I haven't heard any complaints from Fengguang's 0-day build for some t
On Thu, Apr 04, 2013 at 04:03:14PM +0200, Stefan Reif wrote:
> From: Kurt Kanzenbach
>
> Since the names.c/names.h are taken from another project, some
> functions which names.c provides aren't used by usbipd.
> This patch fixes:
> - removed useless comments
> - unified debug/error messages by
Hi Greg,
Here's a giant pull request for v3.10. All patches have been on linux-next for
quite a while and have gone through build and boot testing.
I haven't heard any complaints from Fengguang's 0-day build for some time now,
so it shouldn't add any new build warnings or build errors.
Let me kn
On Sat, 6 Apr 2013, Sergei Shtylyov wrote:
> On 04/06/2013 12:56 AM, Alan Stern wrote:
>
> And instead of passing hcd->regs, wouldn't it be better to pass hcd?
> >>> I really don't know.
> >>>
> Other users of this interface might need to initialize something other
> than a non
On 04/06/2013 12:56 AM, Alan Stern wrote:
And instead of passing hcd->regs, wouldn't it be better to pass hcd?
I really don't know.
Other users of this interface might need to initialize something other
than a non-standard register.
Hm, maybe... if passing 'struct usb_hcd *' would in
On Sat, 6 Apr 2013, Sergei Shtylyov wrote:
> On 04/06/2013 12:40 AM, Sergei Shtylyov wrote:
>
> >
> >> And instead of passing hcd->regs, wouldn't it be better to pass hcd?
> >
> >I really don't know.
> >
> >> Other users of this interface might need to initialize something other
> >> than a n
On Sat, 6 Apr 2013, Sergei Shtylyov wrote:
> > And instead of passing hcd->regs, wouldn't it be better to pass hcd?
>
> I really don't know.
>
> > Other users of this interface might need to initialize something other
> > than a non-standard register.
>
> Hm, maybe... if passing 'struct
On 04/06/2013 12:40 AM, Sergei Shtylyov wrote:
And instead of passing hcd->regs, wouldn't it be better to pass hcd?
I really don't know.
Other users of this interface might need to initialize something other
than a non-standard register.
Hm, maybe... if passing 'struct usb_hcd *' w
Hello.
On 04/05/2013 06:43 PM, Alan Stern wrote:
Sometimes there is a need to initialize some non-standard registers mapped to
the EHCI region before accessing the standard EHCI registers. Add the init()
method to the 'ehci-platform' platform data for this purpose.
"init" isn't such a good
On Thu, Apr 04, 2013 at 01:13:45PM +0300, Alexander Shishkin wrote:
> Hi,
>
> This series contains two fixes, both of which are also applicable to
> -stable.
>
> Michael Grzeschik (2):
> usb: chipidea: udc: fix memory access of shared memory on armv5
> machines
> usb: chipidea: udc: fix m
There are no functional changes in this patch. However, because the
compliance mode timer can be deleted in more than one function, it
seemed expedient to include the function name in the debug strings.
Also limited the use of capitals to the first word in the compliance
mode debug messages, excep
On 04/04/2013 07:41 PM, Tony Lindgren wrote:
* Roger Quadros [130404 00:39]:
On 04/04/2013 02:42 AM, Tony Lindgren wrote:
--- a/arch/arm/mach-omap2/cclock44xx_data.c
+++ b/arch/arm/mach-omap2/cclock44xx_data.c
@@ -27,6 +27,7 @@
#include
#include
#include
+#include
#include "soc.
On Wed, 27 Mar 2013, Petko Manolov wrote:
On Tue, 26 Mar 2013, Sarah Sharp wrote:
ctrl_callback is still reading the URB status, and using it in the
switch statement. It's also using the urb->context as well, to dig out
a pointer (pegasus_t) that the pegasus_set_multicast already has access
t
Hello.
On 05-04-2013 6:01, Kuninori Morimoto wrote:
Here's the set of 4 patches against the Simon Horman's 'renesas.git' repo,
'renesas-next-20130404v2' tag and the 2 Ether patches I've reposted yesterday.
It was created to fix the shortcomings in the R8A7779/Marzen USB platform code
and R8
Hello.
On 05-04-2013 4:44, Simon Horman wrote:
Since we're now going to setup the USBPCTRL0 register using the USB PHY device's
platform data, we now need a way to pass those platform data from the board file
to the device which is situated in setup-r8a7779.c -- and what I'm suggesting is
r8a77
Hello.
On 05-04-2013 4:43, Simon Horman wrote:
The memory region that is used by the driver overlaps EHCI and OHCI register
regions for absolutely no reason now -- fix it by adding offset of 0x800 to
the base address, changing the register #define's accordingly. This has extra
positive effect
Hello.
On 05-04-2013 4:43, Simon Horman wrote:
Now that the EHCI internal buffer setup is done by the platform code, we can
remove such code from this driver as it never really belonged here. We also
no longer need the 2nd memory region now (2nd EHCI controller is simply missing
in e.g. R8A7
* Roger Quadros [130405 03:44]:
> On 04/04/2013 07:41 PM, Tony Lindgren wrote:
> > * Roger Quadros [130404 00:39]:
> >> On 04/04/2013 02:42 AM, Tony Lindgren wrote:
> > For v3.10, let's just make sure that USB works with DT as then
> > after v3.10 we can make omap4 DT only and get rid of estimate
On Fri, Apr 05, 2013 at 06:51:21AM +0400, Vladimir Murzin wrote:
> On Thu, Apr 04, 2013 at 12:29:25PM -0700, Sarah Sharp wrote:
> > Someone else is already working on a patch to fix part of this:
> >
> > http://marc.info/?l=linux-usb&m=136509667003716&w=2
> >
> > Please coordinate with them.
> >
* Benoit Cousson [130405 03:00]:
> On 04/05/2013 10:30 AM, Benoit Cousson wrote:
>
> ...
>
> >> ARM: dts: OMAP4: Add HS USB Host IP nodes
> >> ARM: dts: OMAP3: Add HS USB Host IP nodes
> >> ARM: dts: omap3-beagle: Add USB Host support
> >
> > These 3 DTS patches are good to me, but I cann
Initialize the host and gagdet subsystems of the musb driver only when
the appropriate mode is selected from platform data, or device-tree
information, respectively.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_core.c| 22 +-
drivers/usb/musb/musb_virthub.c | 3 +
With the hcd is now a direct member of struct musb, we can now simply
eliminate the musb_to_hcd() macro. There aren't that many users left
anyway, as some where already fixed up when parts were factored out to
musb_host.c
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_core.c| 4 ++--
d
Define MUSB_PORT_MODE_{HOST,GADGET,DUAL_ROLE} and store the
platform-specified value in struct musb.
Note that MUSB_PORT_MODE_HOST has to be set to 1 in order to match
existing device tree bindings which are already documented but in fact
unusued.
Signed-off-by: Daniel Mack
---
drivers/usb/musb
The musb struct is currently allocated along with the hcd, which makes
it difficult to build a driver that only acts as gadget device.
Fix this by allocating musb directly, and keep the hcd around as
a pointer in the musb struct.
struct hc_driver musb_hc_driver can now also be static to musb_host
This patch re-introduces the bits that are necessary to use the musb
controller in host mode.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_core.c | 5 +
drivers/usb/musb/musb_host.c | 21 +
drivers/usb/musb/musb_host.h | 8
3 files changed, 34 insertion
This makes building the actual object files optional to the selected
mode, which saves users who know which kind of USB mode support they
need some binary size.
Unimplemented functions are stubbed out with static inline functions.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/Kconfig |
This function has its only user in musb_virthub.c, so let's move it
there and make it static.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_core.c| 45 -
drivers/usb/musb/musb_core.h| 1 -
drivers/usb/musb/musb_virthub.c | 44 ++
In particular, this introduces musb_host_resume_root_hub()and
musb_host_poke_root_hub() which will be stubbed out later.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_core.c | 18 +++---
drivers/usb/musb/musb_host.c | 15 ++-
drivers/usb/musb/musb_host.h | 3 +++
This will be done from a more appropriate location and as it doesn't
work anyway, it can safely be removed before the other changes.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_gadget.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drive
Let the function declarations live in the header files they belong to,
which makes it easier to stub them out later.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_core.h | 17 -
drivers/usb/musb/musb_gadget.h | 17 +++--
drivers/usb/musb/musb_host.h | 4 ++
The functionality meant to be represented by this symbol will be
re-added later, but for now, USB_GADGET_MUSB_HDRC is in fact unused and
can be dropped.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/Kconfig | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/gadget/Kconfig
Hi all,
here are some patches to separate the HCD and gadget part of the musb
driver so they can be deselected in Kconfig. They also make the driver
keep track of the configured port mode that is set from DT, so the
actual runtime configuration can be selected dynamically.
One thing that is still
On Fri, 5 Apr 2013, Paul Menzel wrote:
> Dear Linux USB folks,
>
>
> using Debian Wheezy/testing with Linux 3.2.39-2 and
> uswsusp 1.0+20110509-3, I see the following problem similar to the one
> described in some Ubuntu forum from 2009 [1] or a question from 2012 to
> Ask Ubuntu [2].
>
> Runni
On Fri, 5 Apr 2013, Sergei Shtylyov wrote:
> Sometimes there is a need to initialize some non-standard registers mapped to
> the EHCI region before accessing the standard EHCI registers. Add the init()
> method to the 'ehci-platform' platform data for this purpose.
"init" isn't such a good name
On Fri, 5 Apr 2013, victor yeo wrote:
> Now i insmod g_file_storage gadget with file=/mnt/sd/backing_file, the
> SCSI_READ_10 command is still not working properly.
What makes you think that?
> See the gadget log below. The g_file_storage gadget receives "SCSI
> command: Unknown xa1" from the Li
Hi,
On Fri, Apr 05, 2013 at 02:40:45PM +0200, Daniel Mack wrote:
> >> Hi all,
> >>
> >> here are some patches to separate the HCD and gadget part of the musb
> >> driver so they can be deselected in Kconfig. They also make the driver
> >> keep track of the configured port mode that is set from DT,
On Thu, Apr 04, 2013 at 09:50:13PM +0200, Daniel Mack wrote:
> With the hcd is now a direct member of struct musb, we can now simply
> eliminate the musb_to_hcd() macro. There aren't that many users left
> anyway, as some where already fixed up when parts were factored out to
> musb_host.c
>
> Sig
Hi,
On Thu, Apr 04, 2013 at 09:50:12PM +0200, Daniel Mack wrote:
> Initialize the host and gagdet subsystems of the musb driver only when
> the appropriate mode is selected from platform data, or device-tree
> information, respectively.
>
> Refuse to start the gadget part if the port is in host-o
On 05.04.2013 15:07, Felipe Balbi wrote:
> Hi,
>
> On Thu, Apr 04, 2013 at 09:50:11PM +0200, Daniel Mack wrote:
>> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
>> index d564580..d298be7 100644
>> --- a/drivers/usb/musb/musb_host.c
>> +++ b/drivers/usb/musb/musb_host.c
>
Hi,
On Thu, Apr 04, 2013 at 09:50:11PM +0200, Daniel Mack wrote:
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index d564580..d298be7 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -2649,6 +2649,27 @@ void musb_host_free(struct
On 05.04.2013 15:03, Felipe Balbi wrote:
> On Thu, Apr 04, 2013 at 09:50:09PM +0200, Daniel Mack wrote:
>> The musb struct is currently allocated along with the hcd, which makes
>> it difficult to build a driver that only acts as gadget device.
>>
>> Fix this by allocation musb directly, and keep t
Hi
On Thu, Apr 04, 2013 at 09:50:10PM +0200, Daniel Mack wrote:
> This makes building the actual object files optional to the selected
> mode, which saves users who know which kind of USB mode support they
> need some binary size.
>
> Unimplemented functions are stubbed out with static inline fun
On Thu, Apr 04, 2013 at 09:50:09PM +0200, Daniel Mack wrote:
> The musb struct is currently allocated along with the hcd, which makes
> it difficult to build a driver that only acts as gadget device.
>
> Fix this by allocation musb directly, and keep the hcd around as pointer.
Fix this by *alloca
On Thu, Apr 04, 2013 at 09:50:08PM +0200, Daniel Mack wrote:
> Let the function declarations live in the header file the belong to,
header file *they* belong to. Typo there.
other than that, patch looks alright.
--
balbi
signature.asc
Description: Digital signature
On Thu, Apr 04, 2013 at 09:50:07PM +0200, Daniel Mack wrote:
> The functionality meant to be represented by this symbol will be
> re-added later, but for now, USB_GADGET_MUSB_HDRC is in fact unused and
> can be dropped.
>
> Signed-off-by: Daniel Mack
this one is good to go for v3.11
--
balbi
Hi,
On 05.04.2013 11:58, Felipe Balbi wrote:
> On Thu, Apr 04, 2013 at 09:50:06PM +0200, Daniel Mack wrote:
>> Hi all,
>>
>> here are some patches to separate the HCD and gadget part of the musb
>> driver so they can be deselected in Kconfig. They also make the driver
>> keep track of the configur
On 04/05/2013 02:11 PM, Grazvydas Ignotas wrote:
> On Thu, Apr 4, 2013 at 2:50 PM, Roger Quadros wrote:
>> correcting misleading subject line.
>> was (Re: MUSB regression in linux next at least for pandboard)
>>
>> On 04/04/2013 02:36 PM, Roger Quadros wrote:
>>> Hi,
>>>
>>> On 02/07/2013 04:10 PM
On Thu, Apr 4, 2013 at 2:50 PM, Roger Quadros wrote:
> correcting misleading subject line.
> was (Re: MUSB regression in linux next at least for pandboard)
>
> On 04/04/2013 02:36 PM, Roger Quadros wrote:
>> Hi,
>>
>> On 02/07/2013 04:10 PM, Grazvydas Ignotas wrote:
>>> On Thu, Feb 7, 2013 at 11:1
On 04/04/2013 07:41 PM, Tony Lindgren wrote:
> * Roger Quadros [130404 00:39]:
>> On 04/04/2013 02:42 AM, Tony Lindgren wrote:
--- a/arch/arm/mach-omap2/cclock44xx_data.c
+++ b/arch/arm/mach-omap2/cclock44xx_data.c
@@ -27,6 +27,7 @@
#include
#include
#include
>>
Hi,
On 05.04.2013 11:58, Felipe Balbi wrote:
> On Thu, Apr 04, 2013 at 09:50:06PM +0200, Daniel Mack wrote:
>> Hi all,
>>
>> here are some patches to separate the HCD and gadget part of the musb
>> driver so they can be deselected in Kconfig. They also make the driver
>> keep track of the configur
1 - 100 of 105 matches
Mail list logo
